test: move ShowErrorsTab false to global fixture, re-enable for error-overlay tests

Consolidate ShowErrorsTab false into ComfyPage fixture setupSettings
so all E2E tests get it by default. Remove redundant per-file settings.
Re-enable ShowErrorsTab true in execution.spec.ts and dialog.spec.ts
for tests that verify error-overlay visibility.

browser_tests/fixtures/ComfyPage.ts

@@ -430,7 +430,10 @@ export const comfyPageFixture = base.extend<{
         'Comfy.VueNodes.AutoScaleLayout': false,
         // Disable toast warning about version compatibility, as they may or
         // may not appear - depending on upstream ComfyUI dependencies
-        'Comfy.VersionCompatibility.DisableWarnings': true
+        'Comfy.VersionCompatibility.DisableWarnings': true,
+        // Disable errors tab to prevent missing model detection from
+        // rendering error indicators on nodes during unrelated tests.
+        'Comfy.RightSidePanel.ShowErrorsTab': false
       })
     } catch (e) {
       console.error(e)

browser_tests/tests/colorPalette.spec.ts

@@ -5,10 +5,6 @@ import type { WorkspaceStore } from '../types/globals'
 
 test.beforeEach(async ({ comfyPage }) => {
   await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
-  await comfyPage.settings.setSetting(
-    'Comfy.RightSidePanel.ShowErrorsTab',
-    false
-  )
 })
 
 const customColorPalettes = {

browser_tests/tests/dialog.spec.ts

@@ -71,6 +71,10 @@ test('Does not report warning on undo/redo', async ({ comfyPage }) => {
 test.describe('Execution error', () => {
   test.beforeEach(async ({ comfyPage }) => {
     await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
+    await comfyPage.settings.setSetting(
+      'Comfy.RightSidePanel.ShowErrorsTab',
+      true
+    )
     await comfyPage.setup()
   })
 

browser_tests/tests/execution.spec.ts

@@ -9,6 +9,10 @@ test.beforeEach(async ({ comfyPage }) => {
 test.describe('Execution', { tag: ['@smoke', '@workflow'] }, () => {
   test.beforeEach(async ({ comfyPage }) => {
     await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
+    await comfyPage.settings.setSetting(
+      'Comfy.RightSidePanel.ShowErrorsTab',
+      true
+    )
     await comfyPage.setup()
   })
 

browser_tests/tests/interaction.spec.ts

@@ -13,10 +13,6 @@ import type { NodeReference } from '../fixtures/utils/litegraphUtils'
 
 test.beforeEach(async ({ comfyPage }) => {
   await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
-  await comfyPage.settings.setSetting(
-    'Comfy.RightSidePanel.ShowErrorsTab',
-    false
-  )
   // Wait for the legacy menu to appear and canvas to settle after layout shift.
   await comfyPage.page.locator('.comfy-menu').waitFor({ state: 'visible' })
   await comfyPage.nextFrame()

browser_tests/tests/lodThreshold.spec.ts

@@ -4,10 +4,6 @@ import { comfyPageFixture as test } from '../fixtures/ComfyPage'
 
 test.beforeEach(async ({ comfyPage }) => {
   await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
-  await comfyPage.settings.setSetting(
-    'Comfy.RightSidePanel.ShowErrorsTab',
-    false
-  )
 })
 
 test.describe('LOD Threshold', { tag: ['@screenshot', '@canvas'] }, () => {

browser_tests/tests/propertiesPanel/propertiesPanel.spec.ts

@@ -3,13 +3,6 @@ import { expect } from '@playwright/test'
 import { comfyPageFixture as test } from '../../fixtures/ComfyPage'
 
 test.describe('Properties panel', () => {
-  test.beforeEach(async ({ comfyPage }) => {
-    await comfyPage.settings.setSetting(
-      'Comfy.RightSidePanel.ShowErrorsTab',
-      false
-    )
-  })
-
   test('opens and updates title based on selection', async ({ comfyPage }) => {
     await comfyPage.actionbar.propertiesButton.click()
 

browser_tests/tests/rerouteNode.spec.ts

@@ -6,10 +6,6 @@ import { getMiddlePoint } from '../fixtures/utils/litegraphUtils'
 test.describe('Reroute Node', { tag: ['@screenshot', '@node'] }, () => {
   test.beforeEach(async ({ comfyPage }) => {
     await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
-    await comfyPage.settings.setSetting(
-      'Comfy.RightSidePanel.ShowErrorsTab',
-      false
-    )
   })
 
   test.afterEach(async ({ comfyPage }) => {
@@ -49,10 +45,6 @@ test.describe(
     test.beforeEach(async ({ comfyPage }) => {
       await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
       await comfyPage.settings.setSetting('LiteGraph.Reroute.SplineOffset', 80)
-      await comfyPage.settings.setSetting(
-        'Comfy.RightSidePanel.ShowErrorsTab',
-        false
-      )
     })
 
     test('loads from workflow', async ({ comfyPage }) => {

browser_tests/tests/selectionToolbox.spec.ts

@@ -8,10 +8,6 @@ const test = comfyPageFixture
 
 test.beforeEach(async ({ comfyPage }) => {
   await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
-  await comfyPage.settings.setSetting(
-    'Comfy.RightSidePanel.ShowErrorsTab',
-    false
-  )
 })
 const BLUE_COLOR = 'rgb(51, 51, 85)'
 const RED_COLOR = 'rgb(85, 51, 51)'

browser_tests/tests/subgraphPromotion.spec.ts

@@ -36,13 +36,6 @@ test.describe(
   'Subgraph Widget Promotion',
   { tag: ['@subgraph', '@widget'] },
   () => {
-    test.beforeEach(async ({ comfyPage }) => {
-      await comfyPage.settings.setSetting(
-        'Comfy.RightSidePanel.ShowErrorsTab',
-        false
-      )
-    })
-
     test.describe('Auto-promotion on Convert to Subgraph', () => {
       test('Recommended widgets are auto-promoted when creating a subgraph', async ({
         comfyPage

browser_tests/tests/subgraphSearchAliases.spec.ts

@@ -58,10 +58,6 @@ test.describe('Subgraph Search Aliases', { tag: ['@subgraph'] }, () => {
       'Comfy.NodeSearchBoxImpl',
       'v1 (legacy)'
     )
-    await comfyPage.settings.setSetting(
-      'Comfy.RightSidePanel.ShowErrorsTab',
-      false
-    )
   })
 
   test('Can set search aliases on subgraph and find via search', async ({

browser_tests/tests/vueNodes/interactions/node/rename.spec.ts

@@ -8,10 +8,6 @@ test.describe('Vue Nodes Renaming', () => {
   test.beforeEach(async ({ comfyPage }) => {
     await comfyPage.settings.setSetting('Comfy.Graph.CanvasMenu', false)
     await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
-    await comfyPage.settings.setSetting(
-      'Comfy.RightSidePanel.ShowErrorsTab',
-      false
-    )
     await comfyPage.setup()
     await comfyPage.vueNodes.waitForNodes()
   })

browser_tests/tests/vueNodes/interactions/node/resize.spec.ts

@@ -6,10 +6,6 @@ import {
 test.describe('Vue Node Resizing', () => {
   test.beforeEach(async ({ comfyPage }) => {
     await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
-    await comfyPage.settings.setSetting(
-      'Comfy.RightSidePanel.ShowErrorsTab',
-      false
-    )
     await comfyPage.vueNodes.waitForNodes()
   })
 

browser_tests/tests/vueNodes/nodeStates/collapse.spec.ts

@@ -8,10 +8,6 @@ test.describe('Vue Node Collapse', () => {
     await comfyPage.settings.setSetting('Comfy.Graph.CanvasMenu', false)
     await comfyPage.settings.setSetting('Comfy.EnableTooltips', true)
     await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
-    await comfyPage.settings.setSetting(
-      'Comfy.RightSidePanel.ShowErrorsTab',
-      false
-    )
     await comfyPage.setup()
     await comfyPage.vueNodes.waitForNodes()
   })