Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-19 22:09:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent replace-bare-page from matching inside comfyPage.page.

Browse Source 
Addresses review feedback:
https://github.com/Comfy-Org/ComfyUI_frontend/pull/10694#discussion_r3007032663
This commit is contained in:
bymyself
2026-03-29 17:41:58 -07:00
parent c8a0324df1
commit f884b234ed
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tools/test-recorder/src/transform/rules.ts
View File

@@ -12,7 +12,7 @@ export const transformRules: TransformRule[] = [
name: 'replace-test-import',
description: 'Use comfyPageFixture instead of @playwright/test',
pattern:
/import\s*\{\s*test\s*,?\s*expect\s*\}\s*from\s*['"]@playwright\/test['"]/,
/import\s*\{\s*(?:test\s*,?\s*expect|expect\s*,?\s*test)\s*\}\s*from\s*['"]@playwright\/test['"]/,
replacement: `import {\n comfyPageFixture as test,\n comfyExpect as expect\n} from '../fixtures/ComfyPage'`,
category: 'import'
},
@@ -35,7 +35,7 @@ export const transformRules: TransformRule[] = [
{
name: 'replace-page-destructure',
description: 'Use comfyPage fixture instead of page',
pattern: /async\s*\(\s*\{\s*page\s*\}\s*\)/g,
pattern: /async\s*\(\s*\{\s*page\s*(?:,\s*\w+\s*)*\}\s*\)/g,
replacement: 'async ({ comfyPage })',
category: 'fixture'
},
@@ -67,7 +67,7 @@ export const transformRules: TransformRule[] = [
{
name: 'replace-bare-page',
description: 'Replace bare page references with comfyPage.page',
pattern: /(?<!\w)page\./g,
pattern: /(?<![\w.])page\./g,
replacement: 'comfyPage.page.',
category: 'locator'
},
@@ -107,7 +107,7 @@ export const structuralTransforms: StructuralTransform[] = [
)
// Find the test() call and wrap it
const testMatch = code.match(/^(import[\s\S]*?\n\n?)(test\s*\([\s\S]*)$/m)
const testMatch = code.match(/^(import[\s\S]*?\n\n?)(test(?:\.(?:only|skip|fixme))?\s*\([\s\S]*)$/m)
if (!testMatch) return code
const imports = testMatch[1]
@@ -118,7 +118,7 @@ export const structuralTransforms: StructuralTransform[] = [
await comfyPage.canvasOps.resetView()
})
${testBody.replace(/^/gm, ' ').trimStart()}
${testBody.replace(/^(?=.)/gm, ' ').trimStart()}
})\n`
}
}