Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-20 06:20:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: escape backticks in QA prompt heredoc to prevent command substitution

Browse Source 
Backtick-wrapped playwright-cli examples in the unquoted heredoc were
being interpreted as bash command substitution, producing empty prompts.
Replace backtick syntax with plain "Run:" prefixed commands.
This commit is contained in:
snomiao
2026-03-18 13:48:06 +00:00
parent 31675b62cc
commit f8bdda585a
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
.github/workflows/pr-qa.yaml vendored
View File

@@ -1,4 +1,4 @@
# Automated QA of ComfyUI frontend using Claude CLI + Playwright MCP.
# Automated QA of ComfyUI frontend using Claude CLI + playwright-cli.
# Two modes:
# Focused (qa-changes label): Linux-only, tests areas affected by PR changes
# Full (qa-full label): 3-OS matrix, full test plan
@@ -156,10 +156,10 @@ jobs:
Commit: ${SHA}
1. Use playwright-cli via Bash to navigate http://127.0.0.1:8188
- Run `playwright-cli goto http://127.0.0.1:8188` to open the app
- Run `playwright-cli snapshot` after each navigation to get element refs
- Use `playwright-cli click <ref>`, `playwright-cli press <key>`, etc. for interactions
- Run `playwright-cli screenshot --filename=<path>` to capture failures
- Run: playwright-cli goto http://127.0.0.1:8188
- Run: playwright-cli snapshot (after each navigation to get element refs)
- Use: playwright-cli click <ref>, playwright-cli press <key>, etc.
- Run: playwright-cli screenshot --filename=<path> (to capture failures)
2. Run the FULL QA test plan from the skill file
3. IMPORTANT: Take a screenshot after EVERY significant interaction to build a video.
Save all screenshots sequentially to \$QA_ARTIFACTS/frames/:
@@ -192,10 +192,10 @@ jobs:
Instructions:
1. Read the diff above to understand what changed in this PR
2. Use playwright-cli via Bash to navigate http://127.0.0.1:8188
- Run `playwright-cli goto http://127.0.0.1:8188` to open the app
- Run `playwright-cli snapshot` after each navigation to get element refs
- Use `playwright-cli click <ref>`, `playwright-cli press <key>`, etc. for interactions
- Run `playwright-cli screenshot --filename=<path>` to capture failures into \$QA_ARTIFACTS
- Run: playwright-cli goto http://127.0.0.1:8188
- Run: playwright-cli snapshot (after each navigation to get element refs)
- Use: playwright-cli click <ref>, playwright-cli press <key>, etc.
- Run: playwright-cli screenshot --filename=<path> (to save failures into \$QA_ARTIFACTS)
3. IMPORTANT: Take a screenshot after EVERY significant interaction to build a video.
Save all screenshots sequentially to \$QA_ARTIFACTS/frames/:
mkdir -p \$QA_ARTIFACTS/frames