Benjamin Lu
f5726e5948
[test] Add test to verify targetSelector property deletion
...
Add a specific test case to ensure the keybinding migration properly
deletes the deprecated 'targetSelector' property after migrating to
'targetElementId'. This test provides additional coverage to verify
the migration doesn't leave behind obsolete properties.
The test verifies:
- The old 'targetSelector' property is removed
- The new 'targetElementId' property is added with correct value
- Other properties remain unchanged
2025-07-01 19:21:02 -04:00
Benjamin Lu
bd0df83a7c
[fix] Improve type safety in keybinding migration
...
Replace 'any' type with proper 'Keybinding[]' type annotation in the
keybinding migration. Also create new objects during migration to avoid
mutating the original keybinding data, which follows immutability best
practices and prevents potential side effects.
This ensures better type checking and makes the migration code more
robust and maintainable.
2025-07-01 19:20:26 -04:00
Benjamin Lu
c5edbe588c
[refactor] Move setting migrations to settingStore
...
Relocate runSettingMigrations() from GraphCanvas.vue to settingStore's
loadSettingValues() method. This improves separation of concerns by keeping
data migration logic within the store rather than coupling it to UI components.
The migrations now run at the optimal time: after loading setting values from
the server but before any settings are registered, ensuring proper initialization
order and preventing potential race conditions.
This change makes the architecture cleaner and more maintainable by centralizing
all setting-related logic in the appropriate store.
2025-07-01 19:19:51 -04:00
Benjamin Lu
6def711414
Add tests
2025-07-01 18:54:40 -04:00
Benjamin Lu
472f90799d
[refactor] Consolidate settings migration logic into dedicated utility
...
- Extract all migrateDeprecatedValue logic from individual settings into centralized settingsMigration.ts
- Remove migrateDeprecatedValue from SettingParams interface and coreSettings definitions
- Simplify settingStore by removing tryMigrateDeprecatedValue function
- Ensure migrations run after loadSettingValues() for clean initialization flow
- Update tests to reflect new migration approach
This refactor centralizes all setting value migrations in one place, making them easier to maintain and avoiding timing issues with settings that don't exist yet.
2025-07-01 18:47:04 -04:00
Comfy Org PR Bot
4c177121a6
[chore] Update Comfy Registry API types from comfy-api@065aded ( #4274 )
...
Co-authored-by: bmcomfy <214909599+bmcomfy@users.noreply.github.com >
2025-06-25 23:57:37 +00:00
Jin Yi
63181a1ddd
[Manager] Standardize Card Aspect Ratios & Enhance UI ( #4271 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-06-25 12:34:19 -07:00
Jin Yi
e17ca7ce71
fix: node migration TypeError ( #4260 )
2025-06-25 03:01:40 -07:00
Comfy Org PR Bot
77d2cae301
1.23.2 ( #4266 )
...
Co-authored-by: webfiltered <176114999+webfiltered@users.noreply.github.com >
2025-06-25 00:48:39 +00:00
Comfy Org PR Bot
164a4c4c25
[chore] Update Comfy Registry API types from comfy-api@af72ba5 ( #4264 )
...
Co-authored-by: bmcomfy <214909599+bmcomfy@users.noreply.github.com >
2025-06-24 14:57:41 -07:00
Jin Yi
47145ce4b8
[Manager] Modal UI Adjustment (Align with Design) ( #4222 )
2025-06-23 21:30:56 -07:00
Christian Byrne
6cf77a9814
[Manager] Fix bug: installed packs metadata not re-fetched after installations ( #4254 )
2025-06-23 04:37:50 -07:00
Christian Byrne
886e4908d4
[Manager] Fix flush timing issue when switching tabs ( #4253 )
2025-06-23 03:49:47 -07:00
Christian Byrne
24cbc41832
[Manager] Fix bug: opening modal when last focused tab was 'Installed' always shows empty list ( #4252 )
2025-06-23 02:41:15 -07:00
Christian Byrne
a80a939324
Fix: virtual grid scrolling bug when container is rendered with emtpy items (switching tabs) ( #4251 )
2025-06-23 00:13:46 -07:00
Christian Byrne
8e2d7cabba
Fix bug: drag-and-drop, copy-paste, and upload don't work in nodes that specify upload folder that isn't 'input' ( #4186 )
2025-06-22 20:18:36 -07:00
Christian Byrne
e8dd26ff59
[Manager] Fix: When using registry search provider, results not properly paginated' ( #4249 )
2025-06-22 20:05:37 -07:00
Christian Byrne
3a1bd1829a
[feat] Add auto-refresh on task completion for RemoteWidget nodes ( #4191 )
...
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com >
2025-06-22 17:30:24 -07:00
ComfyUI Wiki
2f9dcd1669
Fix: fix typo in Lite Graph settings ( #4245 )
2025-06-22 08:32:09 +00:00
filtered
e23547dd5a
[TS] Remove expect-error (type fix) ( #4235 )
2025-06-21 20:52:35 -07:00
Comfy Org PR Bot
f0f40bc39b
1.23.1 ( #4234 )
...
Co-authored-by: webfiltered <176114999+webfiltered@users.noreply.github.com >
2025-06-21 18:37:51 +00:00
Christian Byrne
4b32786ef5
[Manager] Update Algolia mappings ( #4230 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-06-21 11:09:14 -07:00
Comfy Org PR Bot
9942b17388
[chore] Update Comfy Registry API types from comfy-api@4286a10 ( #4229 )
...
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
2025-06-20 15:47:04 -07:00
Christian Byrne
b99214bf5e
[feat] Show version-specific missing core nodes in workflow warnings ( #4227 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-06-20 15:33:47 -07:00
Christian Byrne
2ef760c599
[Manager] Keep progress dialog on top using priority system ( #4225 )
2025-06-20 15:22:42 -07:00
Christian Byrne
429ab6c365
[Manager] Fix "total nodes" count when selecting multiple packs ( #4228 )
2025-06-20 15:20:26 -07:00
ComfyUI Wiki
b7693ae9f5
Fix typo in 3D settings ( #4224 )
2025-06-20 13:26:40 -07:00
filtered
ebedf1074d
[CI] Fix intermittent actions/cache errors ( #4220 )
2025-06-18 03:55:05 -07:00
filtered
0832347f47
[CI] Fix intermittent failure when using actions/cache ( #4219 )
2025-06-18 01:24:42 -07:00
filtered
c745af0f25
[Test] Fix vitest scope overlaps playwright tests ( #4218 )
2025-06-18 01:08:30 -07:00
Comfy Org PR Bot
8c05266b83
1.23.0 ( #4217 )
...
Co-authored-by: webfiltered <176114999+webfiltered@users.noreply.github.com >
2025-06-18 00:32:54 -07:00
Jin Yi
fa14ec52f4
[Manager] Impletent “Install All” button ( #4196 )
...
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com >
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
Co-authored-by: Terry Jia <terryjia88@gmail.com >
Co-authored-by: comfy-waifu <comfywaifu.ai@gmail.com >
Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com >
2025-06-18 10:52:24 +09:00
Christian Byrne
ec9da0b6c5
[refactor] Add ResultItemType and improve image upload typing ( #4200 )
2025-06-16 14:31:24 -07:00
Christian Byrne
98bb1df436
[refactor] introduce frontend type augmentation pattern ( #4192 )
2025-06-16 11:32:07 -07:00
Christian Byrne
75077fe9ed
[Manager] Add registry search fallback with gateway pattern ( #4187 )
2025-06-15 17:22:05 -07:00
filtered
d5ecfb2c99
Revert "[refactor] Refactor and type image upload options" ( #4190 )
2025-06-15 12:17:54 -07:00
Christian Byrne
3211875084
[refactor] Refactor and type image upload options ( #4185 )
2025-06-15 12:07:26 -07:00
Christian Byrne
a6bd04f951
[Manager] Make dialog closeable with button and hotkey ( #4179 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-06-14 15:21:43 -07:00
Christian Byrne
5b32d2aad0
[Manager] Persist/Restore Manager UI state ( #4180 )
2025-06-14 15:19:56 -07:00
Christian Byrne
23ba7e6501
[Manager] Fix version selector popover not closing when selecting different pack ( #4176 )
2025-06-14 15:06:32 -07:00
Comfy Org PR Bot
1e2b16f14d
1.22.2 ( #4170 )
...
Co-authored-by: webfiltered <176114999+webfiltered@users.noreply.github.com >
2025-06-14 07:19:53 +00:00
Christian Byrne
ec27d50333
[Manager] Fix selection state race condition during pack data merge ( #4165 )
2025-06-13 23:46:53 -07:00
Christian Byrne
693e156ab2
[Manager] Update PackCard styling to match Figma design ( #4164 )
2025-06-13 22:27:34 -07:00
comfy-waifu
8274df5075
Fixed favicon some progress frames not found - by ComfyWaifu 🤍 ( #4143 )
2025-06-13 21:59:35 -07:00
Christian Byrne
55bf36564d
[Manager] Fix card selection highlight z-index and border radius issues ( #4160 )
2025-06-13 21:19:11 -07:00
Christian Byrne
48ac4a2b36
[Manager] Fix race condition in pack selection ( #4158 )
2025-06-14 03:53:06 +00:00
Christian Byrne
c9c1275e4c
[Manager] Add enable/disable toggle for installed node packs ( #4157 )
2025-06-13 20:43:38 -07:00
Terry Jia
78ebc54ebe
[3d] bugfix for preview manager ( #4147 )
2025-06-13 17:34:45 -07:00
Christian Byrne
88f2cc7847
[Manager] Refactor search result types ( #4154 )
2025-06-13 15:08:55 -07:00
Christian Byrne
7907e206da
[Types] Remove outdated type intersection ( #4146 )
2025-06-13 14:08:59 -07:00
