* Release v1.25.10
* handle minimap cleanup called before map set (#5038)
Co-authored-by: bymyself <cbyrne@comfy.org>
---------
Co-authored-by: ComfyUI Wiki <contact@comfyui-wiki.com>
- Change defaultsByInstallVersion from 'standard' to 'legacy' for version 1.25.0
- Update legacy navigation display name from 'Left-Click Pan (Legacy)' to 'Drag Navigation'
- Maintains both navigation systems over long term while improving UX clarity
* [fix] resolve group node execution error when connecting to external nodes
Fixed ExecutableGroupNodeChildDTO.resolveInput to properly handle connections from group node children to external nodes. The method now tries to find nodes by their full ID first (for external nodes) before falling back to the shortened ID (for internal group nodes).
Added comprehensive unit tests to prevent regression.
* [feat] Add error check for unsupported group nodes inside subgraphs
Added validation to detect when group node children are executing within subgraph contexts (execution ID has >2 segments) and provide clear error message directing users to convert to subgraphs instead.
Includes comprehensive test coverage for the new validation.
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
* Refactor app menu items (#4665)
* Restructures the application menu
- rename Workflow to File
- move new & template items to top level
- add View menu and related sub items
Commands
- add "active" state getter shown as checkmark in the menu
Node side panel
- add refresh node defs
- change reset view icon
Help center
- change to use store for visibility
Fixes
- Fix bug with mouse down where if you drag mouse out, mouse up wasn't caught
- Fix issue with canvas info setting not triggering a redraw on change
* Fix missing translation warnings
* Add separator under new
* tidy
* Update locales [skip ci]
* fix some tests
* fix
* Hide icon if there is an active state within the menu item group
* Update locales [skip ci]
* Fix tests
* Implement feedback
- Remove queue, node lib, model lib, workflows, manager, help center
- Add minimap, link visibility
* Update locales [skip ci]
* Add plus icon on "New" menu item
* Update locales [skip ci]
* Fix test
* Fix translations
* Update locales [skip ci]
* Update locales [skip ci]
---------
Co-authored-by: github-actions <github-actions@github.com>
* Update side toolbar menu (#4946)
Side toolbar menu UI updates
- Currently the template modal is very hidden. Many users do not find it
- The current icons are quite aleatory
**What**:
- Add templates shortcut button
- Add item label in normal size
- Use custom icon
Critical design decisions or edge cases that need attention:
- Sidebar tabs registered using custom icons will have their associated
command registed with an undefined icon (currently only string icons are
accepted, not components). I couldn't see anywhere directly using this
icon, but we should consider autogenerating an icon font so we can use
classes for our custom icons (or locating and updating locations to
support both icon types)
Normal mode:
<img width="621" height="1034" alt="image"
src="https://github.com/user-attachments/assets/c1d1cee2-004e-4ff8-b3fa-197329b0d2ae"
/>
Small mode:
<img width="176" height="325" alt="image"
src="https://github.com/user-attachments/assets/3824b8f6-bc96-4e62-aece-f0265113d2e3"
/>
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4946-Update-side-toolbar-menu-24d6d73d365081c5b2bdc0ee8b61dc50)
by [Unito](https://www.unito.io)
---------
Co-authored-by: github-actions <github-actions@github.com>
---------
Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
When saving workflows with nested subgraphs, promoted widget values were not being synchronized back to the subgraph definitions before serialization. This caused widget values to revert to their original defaults when reloading the workflow.
The fix overrides the serialize() method in SubgraphNode to sync promoted widget values to their corresponding widgets in the subgraph definition before serialization occurs.
Fixes the issue where nested subgraph widget values would be lost after save/reload.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Claude <noreply@anthropic.com>
* Deep copy to clipboard, update nested ids on paste
The copyToClipboard function wasn't walking subgraphs and leaving nested
subgraphs unserialized. This has now been fixed.
This requires that equivalent support be added to _pasteFromClipboard to
update the ids of nested subgraphs which are pasted.
* Add extra advisory comments
Co-authored-by: AustinMroz <austin@comfy.org>
- Replace single callback storage with Map using graph UUIDs as keys
- Fix minimap not updating when navigating between subgraphs
- Add proper cleanup and error handling for callback management
- Switch from app.canvas.graph to reactive workflowStore.activeSubgraph
- Prevent callback wrapping recursion by tracking setup state per graph
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
* [bugfix] Fix widget disconnection issue in subgraphs
When disconnecting a node from a SubgraphInput, the target input's link
reference was not being cleared in LLink.disconnect(). This caused
widgets to remain greyed out because they still thought they were
connected (slot.link was not null).
The fix ensures that when a link is disconnected, the target node's
input slot is properly cleaned up by setting input.link = null.
Fixes#4922🤖 Generated with [Claude Code](https://claude.ai/code)
* [test] Add tests for LLink disconnect fix for widget issue
Add comprehensive tests for the LLink.disconnect() method to verify
that target input link references are properly cleared when disconnecting.
This prevents widgets from remaining greyed out after disconnection.
Tests cover:
- Basic disconnect functionality with link reference cleanup
- Edge cases with invalid target nodes
- Preventing interference between different connections
Related to #4922🤖 Generated with [Claude Code](https://claude.ai/code)
---------
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Claude <noreply@anthropic.com>
- Add comprehensive test coverage for the new --disable-api-nodes argument handling
- Tests verify release fetching is properly skipped when argument is present
- Cover edge cases including multiple args, null argv, and missing system stats
- Ensures backward compatibility when argument is not present
Co-authored-by: Yoland Yan <4950057+yoland68@users.noreply.github.com>
* Correct some translations that use traditional Chinese to simplified Chinese.
* Update locales [skip ci]
* Correct the rest of the translations
---------
Co-authored-by: ComfyUI Wiki <contact@comfyui-wiki.com>
Co-authored-by: github-actions <github-actions@github.com>
* [feat] Restore group node conversion menu with deprecated label (#4967)
* Fix screenshot conflicts - use core/1.25 baseline versions
* Revert screenshots to PR version with deprecated menu item
When a node is bypassed from the selection toolbox or by pressing a
keybind for bypass, it will also recursively bypass the contents of a
subgraph. This effect was not applied when clicking the bypass button
from the context menu. The context menu option has been updated to
perform the same action as the others so that behaviour is consistent.
Co-authored-by: AustinMroz <austin@comfy.org>
When loading workflows, SubgraphNode would throw an error if an input
exists in the serialized data that doesn't exist in the current subgraph
definition. This can happen when:
- Subgraph definitions change after workflows are saved
- Workflows are shared between users with different subgraph versions
- Dynamic inputs were added that don't exist in the base definition
This change converts the hard error to a warning and continues processing,
allowing workflows to load even with mismatched subgraph configurations.
Fixes#4905
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
