Commit Graph

6420 Commits

Author SHA1 Message Date
Alexander Brown
71c36991d3 fix: add defensive checks for undefined assets in useAssetWidgetData 2026-01-18 20:09:17 -08:00
Alexander Brown
f5b422d493 feat: implement progressive pagination for Asset Browser model assets 2026-01-18 20:09:16 -08:00
Alexander Brown
d9e0577df4 Merge branch 'main' into drjkl/others-call-it-a-garage-sale 2026-01-18 20:05:51 -08:00
Alexander Brown
e5d85db632 fix: use toBeInViewport for clipped nav visibility check in templates test 2026-01-18 19:42:06 -08:00
Comfy Org PR Bot
12ee5de73b 1.38.6 (#8154)
Patch version increment to 1.38.6

**Base branch:** `main`

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8154-1-38-6-2ed6d73d36508100be3bee4c2639481e)
by [Unito](https://www.unito.io)

Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com>
v1.38.6
2026-01-18 19:15:37 -08:00
AustinMroz
6db4750d96 Fix crosshair cursor in vue mode (#8120)
When the mouse cursor is at the very edge of a a node in vue mode, a
crosshair cursor will sometimes display. This happens because the mouse
is over the canvas, and `LGraphCanvas.processMouseMove` determines the
cursor is still above the node.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8120-Fix-crosshair-cursor-in-vue-mode-2eb6d73d36508116a3cfdd407c5e1e9c)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
2026-01-18 11:00:00 -08:00
Alexander Brown
feadad506f feat: add placeholder content to right panel when no asset selected 2026-01-18 01:26:01 -08:00
Alexander Brown
1ea0d7fa63 feat: control right panel via button instead of asset focus 2026-01-18 01:26:00 -08:00
Alexander Brown
1b05f7893f fix: ensure left panel background fills full height in BaseModalLayout 2026-01-18 01:25:58 -08:00
Alexander Brown
b388ba6fff feat: add maxColumns prop to VirtualGrid for responsive column capping 2026-01-18 01:25:57 -08:00
Alexander Brown
7af6603bf3 fix: use fixed rem units for grid columns to enable animation 2026-01-18 01:25:56 -08:00
Alexander Brown
9879fefa04 fix: add min-w-72 to right panel inner div for proper animation 2026-01-18 01:25:54 -08:00
Alexander Brown
f45af6c455 refactor: restructure BaseModalLayout from flexbox to CSS Grid 2026-01-18 01:25:53 -08:00
Alexander Brown
44c8d801f2 refactor: remove unused fade transition CSS from BaseModalLayout 2026-01-18 01:25:52 -08:00
Alexander Brown
26e43e01af fix: Consistent keydown use for EditableText events. 2026-01-18 01:25:51 -08:00
Alexander Brown
e2b89a766d fix: use keydown.escape in NodeHeader test to match component handler 2026-01-18 01:25:49 -08:00
Alexander Brown
c6ea94d9ab fix: update ModelInfoPanel tests to use correct field names and real i18n
Amp-Thread-ID: https://ampcode.com/threads/T-019bcde2-7b3d-734c-90f8-0e898f4f7ce3
Co-authored-by: Amp <amp@ampcode.com>
2026-01-18 01:25:48 -08:00
Alexander Brown
70565ce11d Only color the display name when it is editable. 2026-01-18 01:25:47 -08:00
Alexander Brown
21a808b90a feat: replace double-click with Use button on Asset Cards 2026-01-18 01:25:46 -08:00
Alexander Brown
6b16001f32 Non-muted text for editable Display Name 2026-01-18 01:25:45 -08:00
Alexander Brown
a37ae19ef0 chore: remove unused SelectItemText component
Amp-Thread-ID: https://ampcode.com/threads/T-019bcae2-7722-75dc-9f77-d7a044654c89
Co-authored-by: Amp <amp@ampcode.com>
2026-01-18 01:25:43 -08:00
Alexander Brown
8115df86ce fix: set SelectContent z-index to 3000 to appear above PrimeVue dialogs
Amp-Thread-ID: https://ampcode.com/threads/T-019bcae2-7722-75dc-9f77-d7a044654c89
Co-authored-by: Amp <amp@ampcode.com>
2026-01-18 01:25:42 -08:00
Alexander Brown
5c9dce05f3 feat: use Select component in ModelInfoPanel for model type selection 2026-01-18 01:25:41 -08:00
Alexander Brown
586c6e3b71 feat: add shadcn-vue Select components with design system styling 2026-01-18 01:25:40 -08:00
Alexander Brown
a390f03763 fix: update display name optimistically from pendingUpdates 2026-01-18 01:25:39 -08:00
Alexander Brown
cfd03ab282 feat: make display name editable in ModelInfoPanel 2026-01-18 01:25:38 -08:00
Alexander Brown
0289cc8c65 Escape when in the main modal closes the modal 2026-01-18 01:25:36 -08:00
Alexander Brown
f2365f55b2 fix: blur textarea on Escape 2026-01-18 01:25:35 -08:00
Alexander Brown
30a4cfcda3 fix: prevent Escape key in TagsInput from closing parent modal 2026-01-18 01:25:34 -08:00
Alexander Brown
2839731819 fix: prevent panel close when interacting with select dropdown
Amp-Thread-ID: https://ampcode.com/threads/T-019bc9c3-5f90-712a-ad23-8df1b17034eb
Co-authored-by: Amp <amp@ampcode.com>
2026-01-18 01:25:33 -08:00
Alexander Brown
df74315194 fix: clear focusedAsset when side panel is closed via button 2026-01-18 01:25:32 -08:00
Alexander Brown
9864c7ef42 Fix the color of the accordion header. 2026-01-18 01:25:31 -08:00
Alexander Brown
2c6e349182 Knip fix 2026-01-18 01:25:30 -08:00
Alexander Brown
9b18d1c604 fix: handle optional created_at in asset schema 2026-01-18 01:25:29 -08:00
Alexander Brown
bf2327a468 refactor: use computed properties in ModelInfoPanel 2026-01-18 01:25:28 -08:00
Alexander Brown
de23f55937 feat: add editable Description field to model user_metadata 2026-01-18 01:25:27 -08:00
Alexander Brown
9146b33659 feat: add slide-in animation for right panel in BaseModalLayout 2026-01-18 01:25:26 -08:00
Alexander Brown
ea78e3c2a3 fix: show collapse button in AssetBrowserModal right panel header 2026-01-18 01:25:25 -08:00
Alexander Brown
d284c0eaf7 feat: add editable Model Type select to ModelInfoPanel 2026-01-18 01:25:24 -08:00
Alexander Brown
d6a64cadb8 feat(assetsStore): add updateAssetMetadata with optimistic cache update 2026-01-18 01:25:23 -08:00
Alexander Brown
87173ee2d5 feat(ModelInfoPanel): use TagsInput for Additional Tags 2026-01-18 01:25:22 -08:00
Alexander Brown
d824d643b0 feat(ModelInfoPanel): use TagsInput for Compatible Base Models 2026-01-18 01:25:21 -08:00
Alexander Brown
09dd3f1a2c fix: update asset metadata to use correct user_metadata fields
Amp-Thread-ID: https://ampcode.com/threads/T-019bc5e5-232c-72bc-893a-afda46003fd3
Co-authored-by: Amp <amp@ampcode.com>
2026-01-18 01:25:20 -08:00
Alexander Brown
19f18ed151 style(ModelInfoPanel): improve source link styling with Civitai logo
Amp-Thread-ID: https://ampcode.com/threads/T-019bc49a-df5a-7708-8fc2-da5cb1c686d1
Co-authored-by: Amp <amp@ampcode.com>
2026-01-18 01:25:19 -08:00
Alexander Brown
f7c73797b1 style: add border separators to ModelInfoPanel accordion items 2026-01-18 01:25:18 -08:00
Alexander Brown
13b4c88754 refactor: improve modal layout and add class prop to PropertiesAccordionItem 2026-01-18 01:25:16 -08:00
Alexander Brown
48e5a9394f refactor(BaseModalLayout): convert right panel state to defineModel 2026-01-18 01:25:15 -08:00
Alexander Brown
e8df692f8d Add tests for ModelInfoPanel and assetMetadataUtils 2026-01-18 01:25:14 -08:00
Alexander Brown
e838f0ae62 feat(assets): add ModelInfoPanel for asset browser right panel
Amp-Thread-ID: https://ampcode.com/threads/T-019bc42f-b9b7-71de-9d8f-6584610ab21e
Co-authored-by: Amp <amp@ampcode.com>
2026-01-18 01:25:13 -08:00
Rizumu Ayaka
30907f99f1 chore: move renameWidget function to widgetUtil.ts (#8042)
related:
https://github.com/Comfy-Org/ComfyUI_frontend/pull/7812#discussion_r2685121387

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8042-chore-move-renameWidget-function-to-widgetUtil-ts-2e86d73d3650813fa502d38b1ca53ab0)
by [Unito](https://www.unito.io)
2026-01-17 21:30:00 -07:00