snomiao
0d25e53861
[test] Add failing tests to reproduce Firebase Auth network issue #4468
...
Add test cases that demonstrate the current problematic behavior where
Firebase Auth makes network requests when offline without graceful error
handling, causing toast error messages and degraded offline experience.
Tests reproduce:
- getIdToken() throwing auth/network-request-failed instead of returning null
- getAuthHeader() failing to fallback gracefully when Firebase token refresh fails
These tests currently pass by expecting the error to be thrown. After
implementing the fix, the tests should be updated to verify graceful
handling (returning null instead of throwing).
Related to issue #4468 : Firebase Auth makes network requests when offline
without evicting token
🤖 Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com >
2025-08-05 16:53:38 +00:00
Christian Byrne
1bf2470f8f
[feat] Add dynamic price badge for Veo3VideoGenerationNode ( #4682 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-08-04 15:05:00 -07:00
Christian Byrne
681d4c6758
[Bug] SaveAnimatedPNG node does not display generated APNG ( #4197 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-08-04 14:57:54 -07:00
Comfy Org PR Bot
821f3765cc
[chore] Update litegraph to 0.17.1 ( #4676 )
...
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
2025-08-04 09:49:41 -07:00
Matthew Meredith
669ee2633a
include litegraph augmentation in generated declarations ( #4614 )
2025-08-03 15:55:29 -07:00
Comfy Org PR Bot
1eadf80fec
1.25.4 ( #4660 )
...
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
2025-08-02 20:59:05 -07:00
Comfy Org PR Bot
f1aba23ee1
[chore] Update litegraph to 0.17.0 ( #4659 )
...
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
2025-08-02 20:05:06 -07:00
Chenlei Hu
934f2674e9
[refactor] Reorganize CLAUDE.md into hierarchical subdirectory files ( #4640 )
2025-08-02 19:52:33 -07:00
Chenlei Hu
907662a42b
[feat] Add Upstash Context7 MCP server to .mcp.json ( #4656 )
2025-08-02 19:52:01 -07:00
Chenlei Hu
378ac4880c
[improve] Streamline GitHub issue templates for better UX ( #4657 )
2025-08-02 19:49:53 -07:00
Jin Yi
4c6e7f106b
[fix] Detect missing nodes in subgraphs ( #4639 )
...
Co-authored-by: bymyself <cbyrne@comfy.org >
2025-08-02 19:45:05 -07:00
Christian Byrne
dc395f5d6d
[fix] Fix viewport sync in minimap and subgraphs navigation ( #4644 )
2025-08-01 18:12:18 -07:00
Christian Byrne
61c9341450
[fix] Add type guard for SubgraphDefinition to improve TypeScript inference ( #4651 )
2025-08-01 17:37:06 -07:00
Benjamin Lu
d96d8cb9a9
Ignore Claude local config ( #4649 )
2025-08-01 16:22:42 -07:00
Chenlei Hu
d779df5f64
[bugfix] Fix pre-commit hook cross-platform compatibility ( #4643 )
2025-08-01 15:43:44 -07:00
Christian Byrne
47e1808861
[fix] Toggle bypass/mute of subgraph nodes applies mode to all children recursively ( #4636 )
2025-08-01 00:35:11 -07:00
Christian Byrne
eae4b954d0
[fix] Preserve per-workflow subgraph navigation state ( #4616 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-07-31 19:37:17 -07:00
Christian Byrne
baea47c493
Extract selection filtering logic to useSelectedLiteGraphItems composable and don't show toolbox when selecting Reroutes ( #4634 )
2025-07-31 18:02:08 -07:00
Comfy Org PR Bot
8673e0e6c4
1.25.3 ( #4633 )
...
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
2025-07-31 15:11:36 -07:00
Christian Byrne
b125e0aa3a
[feat] Move partial execution to the backend and make work with subgraphs ( #4624 )
2025-07-31 13:28:52 -07:00
Christian Byrne
aabea4b78d
[feat] Viewport persistence for subgraph navigation ( #4613 )
2025-07-30 17:54:35 -07:00
Christian Byrne
f85df302fb
[fix] show tooltip on color picker button in selection toolbox ( #4612 )
2025-07-30 17:24:48 -07:00
Christian Byrne
b2b50ac012
[Style] Update "convert to subgraph" icon ( #4611 )
2025-07-30 13:29:30 -07:00
Christian Byrne
fe475403b0
[feat] Add theme-aware colors to minimap ( #4598 )
2025-07-30 12:41:02 -07:00
Christian Byrne
efb08bf2ba
[Style] Fix node preview header/title overflow ( #4610 )
2025-07-30 11:46:50 -07:00
Christian Byrne
2c84ecbf6e
[fix] Make minimap reactive to subgraph context changes ( #4597 )
2025-07-30 10:41:17 -07:00
Christian Byrne
f987cf9dbd
[feat] Improve SubgraphNode badge with sitemap icon and primary color ( #4596 )
2025-07-30 02:48:02 -07:00
Comfy Org PR Bot
2b019935a7
[chore] Update litegraph to 0.16.20 ( #4594 )
...
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
2025-07-30 02:31:50 -07:00
Christian Byrne
f8ec532f1a
[ci] Include litegraph changes in changelog during automated release process ( #4595 )
2025-07-30 02:31:29 -07:00
Christian Byrne
b370b6387d
[fix] DOM widgets lose correct positioning when SubgraphNodes are nested ( #4588 )
2025-07-30 02:18:58 -07:00
Christian Byrne
516eb26d3e
[feat] Add custom icon system with workflow icon ( #4590 )
2025-07-30 01:27:15 -07:00
Christian Byrne
5c71854a96
[ci] Enable CI tests for all feature branch PRs ( #4591 )
2025-07-30 01:27:02 -07:00
Christian Byrne
b0d05c6ef6
[chore] Mark generated TypeScript files in .gitattributes ( #4592 )
2025-07-30 01:19:01 -07:00
Christian Byrne
596c51d1ef
[fix] Fix "Require confirmation before clearing workflow" setting not working ( #4587 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-07-30 00:08:06 -07:00
Christian Byrne
d70949dd47
[feat] Remove default Backspace keybinding to clear workflow ( #4586 )
2025-07-29 20:42:38 -07:00
Comfy Org PR Bot
f064fec3a8
1.25.2 ( #4580 )
...
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
2025-07-29 02:04:00 -07:00
Rizumu Ayaka
abf591d122
fix: DOM widget position offset after canvas moves ( #4557 )
2025-07-29 01:40:47 -07:00
Comfy Org PR Bot
e7a425eeae
[chore] Update litegraph to 0.16.19 ( #4578 )
...
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
2025-07-29 01:26:48 -07:00
Christian Byrne
7d8c56c5e6
[feat] Add comprehensive Claude PR review with inline comments ( #4453 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-07-29 01:16:30 -07:00
Christian Byrne
cf072b8420
[fix] Fix link input slots not being updated in subgraphs ( #4575 )
2025-07-29 00:32:39 -07:00
Christian Byrne
4b75528c39
[fix] Fix graph configuration callbacks not reaching subgraph nodes ( #4572 )
2025-07-29 00:17:03 -07:00
Christian Byrne
dd14144f47
[fix] Update Search & Replace to support nodes in subgraphs ( #4576 )
2025-07-29 00:10:56 -07:00
Christian Byrne
00cd9fadec
[feat] Prevent browser zoom on UI components with canvas wheel event forwarding ( #4574 )
2025-07-28 23:51:09 -07:00
Christian Byrne
98d694f7e3
[fix] Prevent incorrect 'frontend_only' badges in subgraphs ( #4571 )
2025-07-28 23:05:27 -07:00
Christian Byrne
b1fc8846a3
[fix] Update API node pricing for multiple providers ( #4564 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-07-28 23:01:46 -07:00
Jin Yi
680c09a584
[fix] Detect missing nodes in subgraphs ( #4547 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-07-28 21:55:53 -07:00
Christian Byrne
7fe4c07a9c
[fix] Preserve subgraph structure when clearing workflow ( #4567 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-07-28 20:53:05 -07:00
SHIVANSH GUPTA
577cd23c3e
Feature Implemented: Warning displayed when frontend version mismatches ( #4363 )
...
Co-authored-by: bymyself <cbyrne@comfy.org >
Co-authored-by: Claude <noreply@anthropic.com >
2025-07-28 18:23:49 -07:00
Christian Byrne
b1436a068b
[feat] sync subgraph node titles with breadcrumb renaming ( #4565 )
2025-07-28 18:00:59 -07:00
Christian Byrne
b6922cf386
Add delay to breadcrumb and workflow tab tooltips ( #4559 )
2025-07-28 13:09:34 -07:00
