Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-20 23:04:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,959 Commits 659 Branches 552 Tags
sno-firebaseauth-network-problem
Commit Graph

62 Commits

Author SHA1 Message Date
snomiao
0d25e53861 [test] Add failing tests to reproduce Firebase Auth network issue #4468 
Add test cases that demonstrate the current problematic behavior where
Firebase Auth makes network requests when offline without graceful error
handling, causing toast error messages and degraded offline experience.

Tests reproduce:
- getIdToken() throwing auth/network-request-failed instead of returning null
- getAuthHeader() failing to fallback gracefully when Firebase token refresh fails

These tests currently pass by expecting the error to be thrown. After
implementing the fix, the tests should be updated to verify graceful
handling (returning null instead of throwing).

Related to issue #4468: Firebase Auth makes network requests when offline
without evicting token

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-08-05 16:53:38 +00:00
Christian Byrne
eae4b954d0 [fix] Preserve per-workflow subgraph navigation state (#4616) 
Co-authored-by: Claude <noreply@anthropic.com>
 2025-07-31 19:37:17 -07:00
Christian Byrne
aabea4b78d [feat] Viewport persistence for subgraph navigation (#4613) 2025-07-30 17:54:35 -07:00
Christian Byrne
7fe4c07a9c [fix] Preserve subgraph structure when clearing workflow (#4567) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-07-28 20:53:05 -07:00
SHIVANSH GUPTA
577cd23c3e Feature Implemented: Warning displayed when frontend version mismatches (#4363) 
Co-authored-by: bymyself <cbyrne@comfy.org>
Co-authored-by: Claude <noreply@anthropic.com>
 2025-07-28 18:23:49 -07:00
Sidharth
b240c090aa Fix: Escape closes Settings dialog if login dialog open (#4364) 2025-07-23 22:41:26 -07:00
guill
7eb3eb2473 Update the frontend to support async nodes. (#4382) 
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
 2025-07-23 13:46:00 +10:00
Christian Byrne
ff68c42162 [feat] Hide subgraph nodes from node library and search (#4498) 2025-07-22 12:59:25 -07:00
Christian Byrne
280131d33d [feat] Node Definition Filter Registry System (#4497) 2025-07-22 12:27:32 -07:00
bmcomfy
d6f6407c44 [System Pop Up] Add setting to disable version update notifications (#4388) 2025-07-08 14:43:11 -07:00
Terry Jia
4cbcded820 add defaultsByInstallVersion (#4354) 2025-07-06 13:28:58 -07:00
Christian Byrne
44bbfa9f39 [feat] Implement getNodeByComfyNodeName API integration (#4343) 2025-07-03 17:59:21 -07:00
filtered
a7fb685290 Add Subgraphs (#3905) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-06-28 15:37:23 -07:00
bmcomfy
2d2cec2e79 [System Pop Up] Add help center with release notifications and "What's New" popup (#4256) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-06-26 14:11:15 -07:00
Christian Byrne
2ef760c599 [Manager] Keep progress dialog on top using priority system (#4225) 2025-06-20 15:22:42 -07:00
Benjamin Lu
40cfc43c54 Add Help Menu in NodeLibrarySidebarTab (#3922) 
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Claude <noreply@anthropic.com>
 2025-06-01 23:24:31 +10:00
Christian Byrne
4ad6475283 [Feature] Add audio preview support to queue sidebar (#3954) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-05-21 21:31:38 -04:00
Christian Byrne
a7ee3fae05 Add tests for ChatHistoryWidget and related features (#3921) 2025-05-18 12:16:06 -04:00
filtered
7f2b8a5321 [CodeHealth] Add various minor fixes - logging, missed i18n (#3895) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-05-15 22:04:48 +10:00
Christian Byrne
1ef3c007e6 [Auth] Allow user select GitHub account on login (#3801) 2025-05-07 12:03:23 -04:00
Chenlei Hu
d05a340949 [Auth] Allow user select google account on login (#3777) 2025-05-05 23:16:16 -04:00
Christian Byrne
743f3cb5a1 [Subgraph] Add subgraph breadcrumbs component (#3241) 
Co-authored-by: filtered <176114999+webfiltered@users.noreply.github.com>
 2025-05-03 09:31:45 +10:00
Christian Byrne
23d32282bc Fix: server fails to load SVG outputs when user has "Preview Format" setting specified (#3734) 2025-05-02 10:09:50 -07:00
Chenlei Hu
5ec4ec8303 [Bug] Fix mp4 output preview in queue (#3672) 2025-04-28 15:25:53 -04:00
Chenlei Hu
b05407ffdd [Refactor] Split authStore into authStore and authService (#3612) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-04-24 20:45:30 -04:00
Chenlei Hu
0ed29a198d [Cleanup] Remove unnecessary null check on auth (#3610) 2025-04-24 17:36:16 -04:00
Christian Byrne
8558f87547 [API Node] User management (#3567) 
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Chenlei Hu <hcl@comfy.org>
 2025-04-22 18:48:45 -04:00
Christian Byrne
9cd11261f9 [API Node] Set auth persistence in local stoarge (#3514) 2025-04-18 23:15:07 -04:00
Chenlei Hu
2f77d74891 [Refactor] Move tree logic to setting composable (#3491) 2025-04-17 16:34:42 -04:00
Chenlei Hu
06caa21a4d [API Nodes] Setup Google/Github login (#3471) 2025-04-15 20:56:18 -04:00
Christian Byrne
cec0dcbccd [Api Node] Firebase auth and user auth store (#3467) 2025-04-15 17:15:51 -04:00
Benjamin Lu
c8b8953e0a Add reset individual keybind button (#3423) 
Co-authored-by: Benjamin Lu <templu1107@proton.me>
 2025-04-12 16:59:00 -04:00
Chenlei Hu
1c41db75f8 [Type] Enable strict schema type for setting entries (#3425) 2025-04-12 11:34:02 -04:00
Benjamin Lu
1990f25638 Allow keybind overwriting (#3393) 
Co-authored-by: Benjamin Lu <templu1107@proton.me>
 2025-04-11 14:28:36 -04:00
Christian Byrne
4bfc8e9e33 [Manager] Fetch lists of node packs in single request (#3250) 2025-03-27 11:49:05 -04:00
Christian Byrne
71968ae133 Translate action history items (#3249) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-03-27 11:13:24 -04:00
Christian Byrne
c34cc301f1 [Manager] Allow cancelling registry requests by route (#3158) 2025-03-20 10:30:00 -04:00
Chenlei Hu
a049e9ae2d [TS] Enable strict mode (#3136) 2025-03-18 22:57:17 -04:00
Chenlei Hu
91a8591249 Add support for webm video from SaveWEBM node (#3132) 2025-03-18 17:46:18 -04:00
Christian Byrne
cf732974a9 [Manager] Fix enabled/disabled node pack logic (#3061) 2025-03-14 21:25:07 -04:00
bymyself
a415da616c Add Comfy Registry store and search hook (#2848) 2025-03-04 16:33:46 -05:00
Chenlei Hu
a814f9f902 [Test] Run unittest with vitest (#2779) 2025-02-28 22:09:17 -05:00
Chenlei Hu
bdfa2efa50 [BugFix] Remove outputs.animated in queueStore (#2740) 2025-02-26 16:04:01 -05:00
bymyself
ce0726d85e Restore all open workflows on load (#2238) 2025-01-13 20:24:40 -05:00
Chenlei Hu
ea6c9e7ca5 Replace unset unknown keybinding error with warn (#2186) 2025-01-07 10:33:23 -05:00
Chenlei Hu
077ded2cce [Refactor] Simplify keybindingStore with _.groupBy (#2180) 2025-01-06 19:46:20 -05:00
Chenlei Hu
31ea39e44c Prevent reference sharing on settingStore content (#2160) 2025-01-04 19:31:32 -05:00
Chenlei Hu
3d2b9a8d9d Call api.storeSetting only when setting value changes (#2119) 2025-01-01 17:34:58 -05:00
bymyself
f507142e6a Fix error when adding custom setting with no category (#2112) 
Co-authored-by: huchenlei <huchenlei@proton.me>
 2024-12-31 19:04:58 -05:00
Chenlei Hu
d8f074fea0 [Lint] Sort imports (#2104) 2024-12-30 17:26:37 -05:00