Commit Graph

4960 Commits

Author SHA1 Message Date
Jin Yi
33bf377350 [fix] ci error fixed & button max-width modified 2025-08-27 22:29:54 +09:00
Jin Yi
4c99172106 [types] Add proper types for ImportFailInfo API endpoints (#4783) 2025-08-27 22:29:08 +09:00
Comfy Org PR Bot
7d0e971f3a [chore] Update ComfyUI-Manager API types from ComfyUI-Manager@4e6f970 (#4782)
Co-authored-by: viva-jinyi <53567196+viva-jinyi@users.noreply.github.com>
2025-08-27 22:29:08 +09:00
Jin Yi
87db9cc65f [fix] test code timeout error fixed 2025-08-27 22:29:08 +09:00
Jin Yi
73f24896af fix: use selected target_branch for PR base in update-manager-types workflow 2025-08-27 22:29:08 +09:00
Jin Yi
63b6af5e27 [fix] Add conflict detection when installed packages list updates
- Import useConflictDetection composable in comfyManagerStore
- Call performConflictDetection after refreshing installed packages list
- Ensures conflict status stays up-to-date when packages change
- Follows existing codebase patterns for composable usage
2025-08-27 22:29:08 +09:00
Jin Yi
42ad8ebc82 [fix] Fix conflict red dot not syncing
between components

  Resolve reactivity issue by sharing
  useStorage refs across all
  composable instances to ensure UI
  consistency.
2025-08-27 22:29:08 +09:00
Jin Yi
ff31e2d50a [fix] title text modified 2025-08-27 22:29:08 +09:00
Jin Yi
134341d4dd [fix] Fix date format in PackCard test for locale consistency 2025-08-27 22:29:08 +09:00
Jin Yi
7389790e8e [feature] dual modal supported 2025-08-27 22:29:08 +09:00
Jin Yi
aefa3a9eb0 [fix] Use Vue 3.5 destructuring syntax for props with defaults
Remove deprecated withDefaults usage in NodeConflictDialogContent.vue and use destructuring with default values instead
2025-08-27 22:27:45 +09:00
Jin Yi
a1ea18c326 [fix] Restore conflict notification work and fix tests
- Fix missing footerProps property in DialogInstance interface
- Add missing InstalledPacksResponse type import in tests
- Add missing getImportFailInfoBulk method to test mock
- Remove unused ManagerComponents import causing type error
- All unit and component tests now pass successfully
2025-08-27 22:27:08 +09:00
Jin Yi
3e3448e0fd [restore] conflict notification commits restore 2025-08-27 22:27:07 +09:00
Jin Yi
6470869eb1 feat: Add loading state to PackInstallButton and improve UI (#5153) 2025-08-23 13:28:13 +09:00
Jin Yi
7d1659c04a Fix: Restore api.ts from main branch after incorrect rebase (#5150)
* fix: api.ts file is different with main branch

* Update locales [skip ci]

* fix: restore support dotprop access

* fix: apply locales based on manager/menu-items-migration

* fix: Add missing shortcuts translation section for CI tests

- Added shortcuts section with keyboardShortcuts key
- Fixes failing Playwright test looking for 'Keyboard Shortcuts' aria-label
- Issue was caused by incomplete rebase from main branch

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: Add missing versionMismatchWarning translations for CI tests

- Added versionMismatchWarning section with all required keys
- Added general versionMismatch related keys (updateFrontend, dismiss, etc.)
- Fixes failing Playwright tests for version mismatch warnings
- These keys were lost during the rebase from main branch

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-08-22 10:41:39 -07:00
Jin Yi
3352c0627d fix: v2 prefix (#5145) 2025-08-21 15:54:27 +09:00
Christian Byrne
3c3ed2b532 [cleanup] Remove unused manager route enums (#4875) 2025-08-21 15:54:27 +09:00
Christian Byrne
2e4b510a50 [feat] Add v2/ prefix to manager service base URL (#4872) 2025-08-21 15:54:27 +09:00
Christian Byrne
b7f778bfc8 [feat] Add reactive feature flags foundation (#4817) 2025-08-21 15:54:27 +09:00
Jin Yi
808adc06ac [Manager] "Restarting" state after clicking restart button (#4637) 2025-08-21 15:54:27 +09:00
github-actions
a2df972c8a Update locales [skip ci] 2025-08-21 15:54:27 +09:00
Christian Byrne
8ceb5e4bef Fix errors from rebase (removed Tag component import and duplicated imports in api.ts) (#4608)
Co-authored-by: github-actions <github-actions@github.com>
2025-08-21 15:54:27 +09:00
Christian Byrne
ec923e209c [fix] Fix json syntax error from rebase (#4607) 2025-08-21 15:54:27 +09:00
github-actions
2d117b1144 Update locales [skip ci] 2025-08-21 15:54:26 +09:00
bymyself
0f97a6fd1b [Update to v2 API] update WS done message 2025-08-21 15:53:32 +09:00
bymyself
8a2747f29e dont show missing nodes button in legacy manager mode 2025-08-21 15:53:32 +09:00
bymyself
e8e558b431 improve command names 2025-08-21 15:53:32 +09:00
bymyself
cf174d30b9 use correct response shape 2025-08-21 15:53:32 +09:00
github-actions
226f84eaf1 Update locales [skip ci] 2025-08-21 15:53:32 +09:00
bymyself
7ec70e5487 add "Check for Updates", "Install Missing" menu items 2025-08-21 15:53:32 +09:00
github-actions
29cdd57de2 Update locales [skip ci] 2025-08-21 15:50:18 +09:00
bymyself
be7433be46 Add banner indicating how to use legacy manager UI 2025-08-21 15:50:18 +09:00
bymyself
61fa2fd25a move legacy option to startup arg 2025-08-21 15:50:18 +09:00
bymyself
fd3362ed0d await promises. update settings schema 2025-08-21 15:46:58 +09:00
bymyself
cd7d64ae5f re-arrange menu items 2025-08-21 15:46:58 +09:00
bymyself
d2d85650da switch to v2 manager API endpoints 2025-08-21 15:46:58 +09:00
github-actions
d96265a93b Update locales [skip ci] 2025-08-21 15:46:58 +09:00
bymyself
5846117f4e migrate manager menu items 2025-08-21 15:42:08 +09:00
Comfy Org PR Bot
23b3914714 [release] Increment version to 1.26.6 (#5148)
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com>
v1.26.6
2025-08-20 23:20:22 -07:00
filtered
ea9cb3cb45 Allow Macs to zoom with Cmd + wheel (#5143)
* Allow Mac to zoom with cmd+wheel

* Only zoom when exact modifier pressed
2025-08-20 22:18:04 -07:00
Jin Yi
11f5439d29 [feat] Add comprehensive Storybook stories for custom UI components (#5098) 2025-08-21 08:41:54 +09:00
Benjamin Lu
4e8f665a19 [bugfix] Remove empty title field from issue templates (#5136)
Removed `title: ''` from bug report and feature request templates

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>
2025-08-20 16:01:24 -07:00
Johnpaul Chiwetelu
20b0927783 Fix CopyToClipboard Issue (#5109)
* feat: enhance clipboard functionality with fallback support

* feat: refactor toast notifications for clipboard copy functionality

* refactor: simplify clipboard fallback logic by removing support check

* refactor: improve fallback copy textarea styling for better accessibility
2025-08-20 12:26:30 -07:00
filtered
e789227420 Add support for high-resolution wheel events (#5092)
* Add high res wheel event handling

Attempts to resolve high res wheel event handling.  First pass.

* [Test] Add comprehensive TDD tests for device detection spec

* Implement efficient timestamp-based device detection for mouse/trackpad

- Add timestamp-based detection without creating timers on every event
- Implement 500ms cooldown period to prevent rapid mode switching
- Support Linux wheel event buffering with divisibility detection
- Maintain backward compatibility with isTrackpadGesture()
- All 69 device detection tests passing

* Remove magic number and unused code from device detection

- Replace hardcoded 500ms with CanvasPointer.trackpadMaxGap constant
- Update trackpadMaxGap from 200ms to 500ms for cooldown period
- Remove unused lastIntegerDelta property that was only set but never read
- Update tests to remove references to removed property

* Update old CanvasPointer tests to match new device detection behavior

- Update tests to require two-finger panning (deltaX && deltaY) for trackpad detection
- Fix expectations to match new default mouse mode behavior
- Small values alone no longer automatically mean trackpad
- All 15 legacy tests now pass with new implementation

* Consolidate CanvasPointer tests and remove redundant test file

- Add backward compatibility test to comprehensive test file
- Remove old CanvasPointer.test.ts that was created on this branch
- Old file had 15 tests, mostly redundant or testing unused features
- New comprehensive file now has 70 tests with full coverage
- Preserves the only unique test (lastTrackpadEvent backward compatibility)

* Simplify conditional assignment with ternary operator

* Remove redundant code

* Simplify comments to remove redundant explanations for developers

* Refactor device detection for improved readability and maintainability

* Inline immediately-returned variable for conciseness

* Cleanup: Remove redundant code, fix style

* Update test expectations

* Guard against invalid state in event comparison

* Fix node.js setTimeout type issue

Caused by node.js types being loaded globally.

* Remove any type from unit test

* Address PR feedback

- Add static value to handle the high-res maximum buffer time.
- nits
2025-08-20 11:51:29 -07:00
Alexander Brown
4db9e3d7fb Fix: Shift+Click+Drag from outputs with Subgraph outputs (#5115)
* fix: Handle shift+click+drag to collectively move outputs when connected to a subgraph output

* [Bug]: Multiple issues with shift-dragging links to subgraph output node input slots
Fixes #4877
When shift clicking, ignore links that are no longer present in the subgraph.

* cleanup: Utility function to filter for relevant outputs when shift+clicking

* cleanup: Remove some pieces that are redundant in this context.
Different enough to warrant not extracting a common function yet.
2025-08-20 11:22:02 -07:00
Simula_r
1e9d4c7c37 Fix/widget ordering consistency (#5106)
* feat: input ordered nodes

* fix: ensure node input order upon creation using input_order

* refactor: back to the original state of migrations.ts

* refactor: remove console.logs

* test: fix widget ordering tests

* fix: any types
2025-08-20 11:07:40 -07:00
Arjan Singh
180f95182d [fix] reposition TaskItem info #4996 (#5113)
Position sidebar task items at top of tile
2025-08-20 10:16:42 -07:00
Benjamin Lu
bcdb96a727 Remove duplicate semantic labeling from issue templates (#5114)
- Remove [Bug] and [Feature] prefixes from titles
- Remove enhancement label from feature template

Fixes #5100
2025-08-20 09:52:15 -07:00
snomiao
337fb2100a [ci] Add retry logic to wrangler page deploy step (#5118)
- Implement 3-attempt retry mechanism for Cloudflare Pages deployment
- Add 10-second delay between retry attempts
- Install wrangler globally to ensure CLI availability
- Maintain existing functionality while improving stability

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Claude <noreply@anthropic.com>
2025-08-20 09:50:38 -07:00
Jin Yi
2407748425 [feat] Add enhanced filter UI components with search and clear functionality (#5119)
* [feat] Add enhanced filter UI components with search and clear functionality

- Add SearchBox, clear all button, and item count to MultiSelect header
- Add 'fit-content' size option to button types for flexible sizing
- Update SingleSelect and ModelSelector components for consistency
- Add localization strings for item selection and clear all functionality

Co-Authored-By: Claude <noreply@anthropic.com>

* Update locales [skip ci]

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: github-actions <github-actions@github.com>
2025-08-20 09:36:19 -07:00