Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-10 10:00:08 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,292 Commits 622 Branches 539 Tags
477d498d6b8e764fc85f001f10d89488d7743fb0
Commit Graph

815 Commits

Author SHA1 Message Date
filtered
477d498d6b [API] Remove unused: optional_inputs & outputs (#597) 
Code search shows zero usage. If kept, typing properly would require
effort.

Removed:
- `LGraphNode.optional_inputs`
- `LGraphNode.optional_outputs`
 2025-02-25 16:33:21 +00:00
filtered
4920e10f0c [TS] Use strict mode in LiteGraphGlobal (#593) 
- Adds minor type coercions to resolve type errors
- Adds ts-ignore that must be removed later
 2025-02-25 11:59:39 +00:00
filtered
6bd151c91e [API] Remove LiteGraph.searchbox_extras (#592) 
- Unused, loose typing
- Code search shows usage is limited to code copy & paste of litegraph
code
- So long as the `searchbox_extras` property exists and is empty, there
is no change to downstream consumers
 2025-02-25 09:16:49 +00:00
filtered
a4b9704a80 Remove entry point import, merge modules (#590) 
* Remove unused import in lib entry point

* [Refactor] Merge type util modules
 2025-02-25 01:25:42 +00:00
filtered
ad8dd7a9d8 Export enum (#589) 
* Revert "Export enum (#587)"

This reverts commit cf8565eb13.

* Export enums
 2025-02-25 01:08:04 +00:00
Chenlei Hu
cf8565eb13 Export enum (#587) 2025-02-24 19:37:18 -05:00
Chenlei Hu
fadece7fdf Type LGraphNode.addInput/Output (#585) 2025-02-24 19:29:04 -05:00
Chenlei Hu
59dea644f2 Move marker property from BaseWidget to SliderWidget (#584) 
* Move marker property from BaseWidget to SliderWidget

* nit
 2025-02-24 16:35:34 -05:00
Chenlei Hu
170341db73 Type ButtonWidget (#583) 
* Type ButtonWidget

* nit
 2025-02-24 16:30:04 -05:00
filtered
630fd00086 [API] Remove unused LiteGraph APIs (#582) 
* [API] Remove unused LiteGraph APIs

These features have not been maintained, and would require refactoring / rewrites. As code search revealed them to be unused, they are being removed.

- addNodeMethod
- compareObjects
- auto_sort_node_types

* Udpate API.md
 2025-02-24 12:04:07 +00:00
filtered
c8ffacf172 [TS] Use strict mode in LGraph (#579) 
* [TS] Undefined is not a valid object key

* Deprecate unused code

Adds ts-expect-error to TS strict issues on unmaintained public interfaces.

* [TS] Fix nullability: asSerialisable return type

* nit - Remove outdated comment

* [TS] Strict mode: LGraph

- Adds minor coercion changes; would need extremely specific hacks performed to result in runtime change

* [TMP] Work around typescript-strict-plugin

Must be reverted once plugin removed.
See #578
 2025-02-24 11:12:46 +00:00
filtered
9d6c867607 [TS] Strict mode: CurveEditor (#580) 
- Converts `CurveEditor` to ts strict
- Two runtime changes: explicit throws instead of `TypeError` on following line
 2025-02-24 10:21:35 +00:00
filtered
bcd5a77837 [TS] Strict initializers - LGraph (#573) 
Duplicates values from clear() to property initializers.
 2025-02-24 03:30:20 +00:00
filtered
1800d31a5a [Refactor] Prefer modern for..of loops 2 (#569) 
* [Refactor] Prefer for..of

* [Refactor] Prefer for..of - manual refactoring

* Partially revert change - potential conflict

Not worth time investment to fix - reverted.
 2025-02-23 16:36:52 -05:00
Chenlei Hu
f300e37a89 Remove NodeSlot.pos when serializing WidgetInputSlot (#570) 2025-02-23 16:11:56 -05:00
filtered
4add6c3211 [Cleanup] Follow-up on #566 - fix style (#568) 2025-02-23 20:20:44 +00:00
filtered
46535409c8 [CI] Fix existing lint warnings & disallow in future (#567) 
* Fix lint warnings

* [CI] Fail lint checks instead of warning

* [CI] Fail stylistic lint checks instead of warning
 2025-02-23 20:12:04 +00:00
filtered
4163cb04b8 [Refactor] Prefer modern for..of loops (#566) 
- Replaces traditional incrementing `for` loops and `forEach()` calls with modern `for..of` syntax
- Improves readability
- Semantic checking used; not expecting issues to arise from this portion
 2025-02-23 19:59:41 +00:00
Chenlei Hu
86f823b7d5 [nit] Move isColorable out of interfaces.ts (#564) 2025-02-23 13:06:03 -05:00
bymyself
d17e7f567d type LGraphNode.addWidget (#562) 
* type addWidget

* help out ts compiler

* Update LGraphNode.ts

---------

Co-authored-by: Chenlei Hu <huchenlei@proton.me>
 2025-02-23 13:01:17 -05:00
Chenlei Hu
dc9a76200b [BugFix] Call LGraphCanvas.deleteSelected on context menu remove (#560) 2025-02-20 15:22:53 -05:00
Chenlei Hu
c8385657db Add LGraphNode.expandToFitContent (#558) 2025-02-20 13:55:02 -05:00
Chenlei Hu
dcac6dba80 [BugFix] Auto grow node if widgets need more space (#556) 2025-02-20 12:45:31 -05:00
filtered
1dee497e40 Fix drag event throws introduced in #554 (#555) 2025-02-20 16:30:38 +11:00
filtered
b67f34e7f3 [Cleanup] Remove lint bypass, remove unused vars (#554) 2025-02-20 11:17:35 +11:00
filtered
485bfd1628 [Cleanup] Remove unused code (#553) 2025-02-20 10:54:24 +11:00
Chenlei Hu
7bab620986 Fix IColorable.getColorOption (#551) 
* Fix IColorable.getColorOption

* nit
 2025-02-19 14:57:29 -05:00
Chenlei Hu
6b1e40a011 Add IColorable interface (#549) 
* Add IColorable interface

* Set color option

* nit

* nit

* nit
 2025-02-19 13:56:08 -05:00
Chenlei Hu
d27ced7cf3 [BugFix] Fix unknown node with converted widgets (#547) 2025-02-18 19:32:06 -05:00
Chenlei Hu
6703a1f1fa [Type] Mark LGraphGroup.color as optional (#545) 
* [Type] Mark LGraphGroup.color as optional

* nit
 2025-02-18 16:51:17 -05:00
Chenlei Hu
196645ce7e Clear selectedItems on canvas clear (#543) 2025-02-18 11:49:06 -05:00
bymyself
e800eeb202 type selected_nodes (#541) 2025-02-18 11:48:54 -05:00
Chenlei Hu
9288709497 Trigger onSelectionChange on deleteSelected (#539) 2025-02-17 17:22:32 -05:00
Chenlei Hu
28e86820d6 Trigger LGraphCanvas.onSelectionChange on drag-select (#537) 2025-02-16 20:24:59 -05:00
Chenlei Hu
1e71da9a38 Show widget input inplace (#535) 
* Show widget input inplace

* nit

* nit
 2025-02-16 11:37:47 -05:00
Chenlei Hu
7a25899ecc Reverse computeSize and computeLayoutSize priority (#533) 2025-02-15 14:35:09 -05:00
Chenlei Hu
d23a320f9f Upstream frontend widgets layout logic (#531) 
* Upstream frontend widgets layout logic

* Add back LGraphNode.freeWidgetSpace

* nit

* update expectations
 2025-02-14 19:22:37 -05:00
Chenlei Hu
a5c89c0152 [Performance] Avoid double measure on node rendering (#529) 
* [Performance] Avoid double measure on node rendering

* Move _collapsed_width calc

* nit

* nit

* nit

* nit

* nit
 2025-02-14 14:15:40 -05:00
Chenlei Hu
de10bf0c3a [Cleanup] Remove LGraphCanvas.adjustNodesSize (#528) 2025-02-14 11:10:40 -05:00
Chenlei Hu
75267957d5 Use LGraphNode.setSize (#527) 2025-02-14 11:06:49 -05:00
Chenlei Hu
ce44cea409 Split layout and draw for slots (#524) 
* Split layout and draw for slots

* nit

* nit

* Fix serialization

* Move effect (highlight/invalid) to layout calculation

* nit

* Fix type issue

* Resolve review comments
 2025-02-13 20:20:57 -05:00
Chenlei Hu
361a1a76ef Add LGraphNode.getExtraSlotMenuOptions hook (#522) 2025-02-12 15:52:27 -05:00
Chenlei Hu
9abcf0fd32 Remove LGraphNode.horizontal (#521) 
* Remove LGraphNode.horizontal

* nit
 2025-02-12 15:11:59 -05:00
Chenlei Hu
7813e5207a Revert "Revert "Convert i/o slot to class in LGraphNode.configure"" (#518) 
* Revert "Revert "Convert i/o slot to class in LGraphNode.configure (#506)" (#511)"

This reverts commit d029bd8924.

* nit
 2025-02-12 11:06:35 -05:00
Chenlei Hu
f0eca030c4 [BugFix] Trigger IWidget.callback on widget drag (#514) 2025-02-10 14:37:16 -05:00
Chenlei Hu
adff23bb84 Add ISerialisedNode.widgets_values documentation (#513) 2025-02-10 11:17:09 -05:00
Chenlei Hu
d029bd8924 Revert "Convert i/o slot to class in LGraphNode.configure (#506)" (#511) 
This reverts commit c75157e86e.
 2025-02-09 23:35:40 -05:00
Chenlei Hu
c75157e86e Convert i/o slot to class in LGraphNode.configure (#506) 2025-02-09 15:23:38 -05:00
Chenlei Hu
997d673bd9 [Refactor] LgraphNode.drawSlots (#503) 
* wip

* nit
 2025-02-09 12:53:41 -05:00
Chenlei Hu
048fa5bb88 [Refactor] NodeSlot.isValidTarget (#501) 2025-02-09 11:59:52 -05:00