Comfy Org PR Bot
99f5b36383
[backport cloud/1.36] feat: local/legacy settings dialog fix ( #8004 )
...
Backport of #7990 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8004-backport-cloud-1-36-feat-local-legacy-settings-dialog-fix-2e76d73d3650814398aff135890ee1cb )
by [Unito](https://www.unito.io )
Co-authored-by: Simula_r <18093452+simula-r@users.noreply.github.com >
2026-01-12 22:59:51 -07:00
Comfy Org PR Bot
2da833854a
[backport cloud/1.36] Dynamic input fixes ( #8008 )
...
Backport of #7837 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8008-backport-cloud-1-36-Dynamic-input-fixes-2e76d73d3650811186daca4b7e20b83a )
by [Unito](https://www.unito.io )
Co-authored-by: AustinMroz <austin@comfy.org >
2026-01-12 22:49:26 -07:00
Comfy Org PR Bot
15955bd940
[backport cloud/1.36] fix: wrap image preview navigation dots when overflowing node width ( #8006 )
...
Backport of #7891 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8006-backport-cloud-1-36-fix-wrap-image-preview-navigation-dots-when-overflowing-node-width-2e76d73d3650814ead44ebf4a66d4765 )
by [Unito](https://www.unito.io )
Co-authored-by: Terry Jia <terryjia88@gmail.com >
2026-01-12 22:41:51 -07:00
Comfy Org PR Bot
8e62359af9
[backport cloud/1.36] Fix reactivity washing in refreshNodeSlots ( #8019 )
...
Backport of #7802 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8019-backport-cloud-1-36-Fix-reactivity-washing-in-refreshNodeSlots-2e76d73d36508113b3eec5aab31165a7 )
by [Unito](https://www.unito.io )
Co-authored-by: AustinMroz <austin@comfy.org >
Co-authored-by: Alexander Brown <drjkl@comfy.org >
2026-01-12 22:34:10 -07:00
Comfy Org PR Bot
fca4931f52
[backport cloud/1.36] feat(price-badges): add price badges for Vidu2 nodes ( #8017 )
...
Backport of #7927 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8017-backport-cloud-1-36-feat-price-badges-add-price-badges-for-Vidu2-nodes-2e76d73d3650810ea3b1d37744fe0523 )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com >
2026-01-12 22:29:36 -07:00
Comfy Org PR Bot
eeb0fd354a
[backport cloud/1.36] fix: enable immediate file saving for i18n translations ( #8015 )
...
Backport of #7785 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8015-backport-cloud-1-36-fix-enable-immediate-file-saving-for-i18n-translations-2e76d73d365081f6b6aae8ab76c677c5 )
by [Unito](https://www.unito.io )
Co-authored-by: sno <snomiao@gmail.com >
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: Alexander Brown <drjkl@comfy.org >
2026-01-12 22:25:31 -07:00
Comfy Org PR Bot
c28e60e5a8
[backport cloud/1.36] fix: remove negative margin from legacy widget canvas ( #8013 )
...
Backport of #7925 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8013-backport-cloud-1-36-fix-remove-negative-margin-from-legacy-widget-canvas-2e76d73d3650818a983bf2ed6095e599 )
by [Unito](https://www.unito.io )
Co-authored-by: Terry Jia <terryjia88@gmail.com >
2026-01-12 22:24:02 -07:00
Comfy Org PR Bot
dc0d85990d
[backport cloud/1.36] fix: respect node resizable property in vueNodes mode ( #8011 )
...
Backport of #7934 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8011-backport-cloud-1-36-fix-respect-node-resizable-property-in-vueNodes-mode-2e76d73d365081509c9bfe6603052452 )
by [Unito](https://www.unito.io )
Co-authored-by: Terry Jia <terryjia88@gmail.com >
2026-01-12 22:19:50 -07:00
Comfy Org PR Bot
74ebfec582
[backport cloud/1.36] Fix linked asset widget promotion in vue ( #8003 )
...
Backport of #7895 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8003-backport-cloud-1-36-Fix-linked-asset-widget-promotion-in-vue-2e76d73d365081758120de9d88ee632a )
by [Unito](https://www.unito.io )
Co-authored-by: AustinMroz <austin@comfy.org >
2026-01-12 22:10:28 -07:00
Comfy Org PR Bot
bc4b3d0a95
[backport cloud/1.36] fix(price-badges): add missing badge for WanReferenceVideoApi node ( #8001 )
...
Backport of #7901 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8001-backport-cloud-1-36-fix-price-badges-add-missing-badge-for-WanReferenceVideoApi-node-2e76d73d3650814c9939e8f27c4e48db )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com >
2026-01-12 22:07:00 -07:00
Comfy Org PR Bot
4a6a1287ce
[backport cloud/1.36] fix(price-badges): improve Gemini and OpenAI chat nodes ( #7999 )
...
Backport of #7900 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7999-backport-cloud-1-36-fix-price-badges-improve-Gemini-and-OpenAI-chat-nodes-2e76d73d36508169a65cce327fd7bdaf )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com >
2026-01-12 22:04:34 -07:00
Comfy Org PR Bot
9bf5176b8f
[backport cloud/1.36] fix: prevent image preview resize issues when switching to vueNodes mode ( #7997 )
...
Backport of #7868 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7997-backport-cloud-1-36-fix-prevent-image-preview-resize-issues-when-switching-to-vueNodes-2e76d73d36508164be55fceba35aa0d8 )
by [Unito](https://www.unito.io )
Co-authored-by: Terry Jia <terryjia88@gmail.com >
2026-01-12 22:03:39 -07:00
Comfy Org PR Bot
056308a026
[backport cloud/1.36] fix: continue rendering when 3D animation is playing ( #7995 )
...
Backport of #7836 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7995-backport-cloud-1-36-fix-continue-rendering-when-3D-animation-is-playing-2e76d73d3650811fb287cc0f31c5301c )
by [Unito](https://www.unito.io )
Co-authored-by: Terry Jia <terryjia88@gmail.com >
2026-01-12 22:02:46 -07:00
Comfy Org PR Bot
fe48900c56
[backport cloud/1.36] fix: disable frustum culling for SkinnedMesh to prevent clipping during animation ( #7989 )
...
Backport of #7856 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7989-backport-cloud-1-36-fix-disable-frustum-culling-for-SkinnedMesh-to-prevent-clipping-du-2e76d73d365081e9b323d462a60cf7dc )
by [Unito](https://www.unito.io )
Co-authored-by: Terry Jia <terryjia88@gmail.com >
2026-01-12 21:08:23 -07:00
Comfy Org PR Bot
19db196727
[backport cloud/1.36] fix: Improve legacy widget compatibility in vueNodes mode ( #7987 )
...
Backport of #7766 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7987-backport-cloud-1-36-fix-Improve-legacy-widget-compatibility-in-vueNodes-mode-2e76d73d365081c7a2e0db7aa23748f5 )
by [Unito](https://www.unito.io )
Co-authored-by: Terry Jia <terryjia88@gmail.com >
2026-01-12 21:02:19 -07:00
Comfy Org PR Bot
4963f59264
[backport cloud/1.36] refactor: simplify asset download state and fix deletion UI ( #7991 )
...
Backport of #7974 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7991-backport-cloud-1-36-refactor-simplify-asset-download-state-and-fix-deletion-UI-2e76d73d365081ac8a99c9d4c849325f )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Amp <amp@ampcode.com >
2026-01-12 19:59:03 -08:00
Alexander Brown
7f83af391c
[backport cloud/1.36] feat: add polling fallback for stale asset downloads ( #7981 )
...
Backport of #7926 to cloud/1.36
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7981-backport-cloud-1-36-feat-add-polling-fallback-for-stale-asset-downloads-2e76d73d365081a983a4e5a8683ae2c9 )
by [Unito](https://www.unito.io )
Co-authored-by: Amp <amp@ampcode.com >
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2026-01-12 19:41:57 -08:00
Comfy Org PR Bot
2d04cf4757
[backport cloud/1.36] fix 3d-min-resize ( #7985 )
...
Backport of #7815 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7985-backport-cloud-1-36-fix-3d-min-resize-2e76d73d365081f88c7ce59a24f4c3c7 )
by [Unito](https://www.unito.io )
Co-authored-by: Kelly Yang <124ykl@gmail.com >
2026-01-12 20:29:43 -07:00
Comfy Org PR Bot
89a00fe459
[backport cloud/1.36] CI: Use custom container for E2E tests ( #7983 )
...
Backport of #7625 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7983-backport-cloud-1-36-CI-Use-custom-container-for-E2E-tests-2e76d73d365081608f74da4b8add041e )
by [Unito](https://www.unito.io )
Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
2026-01-12 20:13:28 -07:00
Comfy Org PR Bot
7158e81a4d
[backport cloud/1.36] disable workflow validation warnings by default ( #7978 )
...
Backport of #7795 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7978-backport-cloud-1-36-disable-workflow-validation-warnings-by-default-2e76d73d365081bb88e9ff3df97a2bf3 )
by [Unito](https://www.unito.io )
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
2026-01-12 20:01:47 -07:00
Comfy Org PR Bot
53d76c42c2
[backport cloud/1.36] fix: PrimitiveNode combo widget value not persisting in vueNodes mode ( #7980 )
...
Backport of #7782 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7980-backport-cloud-1-36-fix-PrimitiveNode-combo-widget-value-not-persisting-in-vueNodes-mo-2e76d73d36508169870ec429b84d3765 )
by [Unito](https://www.unito.io )
Co-authored-by: Terry Jia <terryjia88@gmail.com >
2026-01-12 20:00:23 -07:00
Comfy Org PR Bot
1abe3f2707
[backport cloud/1.36] fix(upload-model): UI/UX improvements for Upload Model Dialog ( #7976 )
...
Backport of #7969 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7976-backport-cloud-1-36-fix-upload-model-UI-UX-improvements-for-Upload-Model-Dialog-2e76d73d365081d49320d6edadb06736 )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Brown <drjkl@comfy.org >
2026-01-12 17:58:09 -08:00
Comfy Org PR Bot
e84b6f3696
[backport cloud/1.36] fix(UploadModel): truncate long filenames in wizard ( #7944 )
...
Backport of #7939 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7944-backport-cloud-1-36-fix-UploadModel-truncate-long-filenames-in-wizard-2e46d73d365081518cf3f78545ca5ecd )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Brown <drjkl@comfy.org >
2026-01-10 11:52:18 -07:00
Comfy Org PR Bot
348d674455
[backport cloud/1.36] fix: Model upload UI improvements ( #7943 )
...
Backport of #7938 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7943-backport-cloud-1-36-fix-Model-upload-UI-improvements-2e46d73d365081fcadd1f71e7fa012d6 )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Amp <amp@ampcode.com >
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2026-01-10 11:52:09 -07:00
Comfy Org PR Bot
4165f52109
[backport cloud/1.36] fix: UX nits and styles ( #7936 )
...
Backport of #7933 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7936-backport-cloud-1-36-fix-UX-nits-and-styles-2e36d73d365081ce89add4b9857df1db )
by [Unito](https://www.unito.io )
Co-authored-by: Simula_r <18093452+simula-r@users.noreply.github.com >
2026-01-09 16:51:08 -08:00
Simula_r
b53976c775
[backport cloud/1.36] Feat(cloud)/new top up dialog ( #7932 )
...
Backport of #7899 to `cloud/1.36`
## Summary
- Implement the new add credits (top up) dialog
- Refactor the subscription dialog to make different credit types easier
to understand
## Conflicts Resolved
- `src/components/dialog/content/TopUpCreditsDialogContent.vue` - Took
PR version (new UI)
- `src/locales/en/main.json` - Added missing `usdAmount` translation key
Automatically created by manual backport process.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7932-backport-cloud-1-36-Feat-cloud-new-top-up-dialog-2e36d73d3650812dba2cd7edcb43259b )
by [Unito](https://www.unito.io )
2026-01-09 15:14:55 -08:00
Comfy Org PR Bot
ec7a3a9e20
[backport cloud/1.36] perf(AssetBrowserModal): virtualize asset grid to reduce network requests ( #7922 )
...
Backport of #7919 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7922-backport-cloud-1-36-perf-AssetBrowserModal-virtualize-asset-grid-to-reduce-network-re-2e36d73d3650812ca602d496f4decec4 )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Amp <amp@ampcode.com >
2026-01-08 19:15:27 -08:00
Comfy Org PR Bot
be8ee3d228
[backport cloud/1.36] fix: Button sizing in modals and asset browser ( #7921 )
...
Backport of #7920 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7921-backport-cloud-1-36-fix-Button-sizing-in-modals-and-asset-browser-2e36d73d365081b9a52af74dc2b5e94c )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Brown <drjkl@comfy.org >
2026-01-08 19:14:14 -08:00
Luke Mino-Altherr
b9e6f3d9fa
[backport cloud/1.36] feat: add HoneyToast component for persistent progress notifications ( #7918 )
...
Backport of #7902 to cloud/1.36
Original PR: https://github.com/Comfy-Org/ComfyUI_frontend/pull/7902
Cherry-picked merge commit e26e1f0c9e .
## Conflicts resolved
- **pnpm-lock.yaml**: Regenerated with `pnpm install`
-
**tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts**:
Removed (PR deletes this file along with the component it tested)
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7918-backport-cloud-1-36-feat-add-HoneyToast-component-for-persistent-progress-notification-2e36d73d3650811a9f57f26c56b84c97 )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Amp <amp@ampcode.com >
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: sno <snomiao@gmail.com >
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: GitHub Action <action@github.com >
2026-01-08 17:43:30 -08:00
Comfy Org PR Bot
e912b42fff
[backport cloud/1.36] feat: add model download progress dialog ( #7917 )
...
Backport of #7897 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7917-backport-cloud-1-36-feat-add-model-download-progress-dialog-2e36d73d365081b18bddeb4835f4d706 )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Amp <amp@ampcode.com >
2026-01-08 17:29:03 -08:00
Comfy Org PR Bot
aecb841cc0
[backport cloud/1.36] feature: model browser folder grouping ( #7916 )
...
Backport of #7892 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7916-backport-cloud-1-36-feature-model-browser-folder-grouping-2e36d73d365081279a6bf032c6e0893d )
by [Unito](https://www.unito.io )
Co-authored-by: Jin Yi <jin12cc@gmail.com >
2026-01-08 17:22:03 -08:00
Comfy Org PR Bot
b4e4cccc31
[backport cloud/1.36] Fix run badge anchoring ( #7915 )
...
Backport of #7912 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7915-backport-cloud-1-36-Fix-run-badge-anchoring-2e36d73d36508160a874dea0a732a9af )
by [Unito](https://www.unito.io )
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
Co-authored-by: github-actions <github-actions@github.com >
2026-01-08 17:32:03 -07:00
Comfy Org PR Bot
2a15325d81
[backport cloud/1.36] Prevent nav item shrink ( #7890 )
...
Backport of #7869 to `cloud/1.36`
Automatically created by backport workflow.
Co-authored-by: Jin Yi <jin12cc@gmail.com >
2026-01-07 16:51:27 -08:00
Comfy Org PR Bot
f1b874eeed
[backport cloud/1.36] feat: Stale-while-revalidate pattern for AssetBrowserModal ( #7889 )
...
Backport of #7880 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7889-backport-cloud-1-36-feat-Stale-while-revalidate-pattern-for-AssetBrowserModal-2e26d73d365081fb854bfe4189a94bef )
by [Unito](https://www.unito.io )
Co-authored-by: Alexander Brown <drjkl@comfy.org >
Co-authored-by: Amp <amp@ampcode.com >
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2026-01-07 16:42:29 -08:00
Comfy Org PR Bot
1de23b8aa2
[backport cloud/1.36] feat: split asset_update_options_enabled into separate deletion and rename flags ( #7888 )
...
Backport of #7864 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7888-backport-cloud-1-36-feat-split-asset_update_options_enabled-into-separate-deletion-and-2e26d73d365081edb755ede860c53f97 )
by [Unito](https://www.unito.io )
Co-authored-by: Luke Mino-Altherr <luke@comfy.org >
Co-authored-by: Amp <amp@ampcode.com >
2026-01-07 16:28:14 -08:00
Comfy Org PR Bot
e9c47e80b9
[backport cloud/1.36] [feat] Add async model upload with WebSocket progress tracking ( #7887 )
...
Backport of #7746 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7887-backport-cloud-1-36-feat-Add-async-model-upload-with-WebSocket-progress-tracking-2e26d73d365081c4a060e6e88f33016d )
by [Unito](https://www.unito.io )
Co-authored-by: Luke Mino-Altherr <luke@comfy.org >
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: GitHub Action <action@github.com >
2026-01-07 16:25:55 -08:00
Comfy Org PR Bot
8eb2ba0745
[backport cloud/1.36] [feat] Filter out nlf model type from Upload Model flow ( #7886 )
...
Backport of #7793 to `cloud/1.36`
Automatically created by backport workflow.
Co-authored-by: Luke Mino-Altherr <luke@comfy.org >
Co-authored-by: Claude <noreply@anthropic.com >
2026-01-07 16:17:35 -08:00
Comfy Org PR Bot
4957cd356b
[backport cloud/1.36] Guard downgrades via billing portal ( #7820 )
...
Backport of #7813 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7820-backport-cloud-1-36-Guard-downgrades-via-billing-portal-2db6d73d3650814fb2fbd73697ed070c )
by [Unito](https://www.unito.io )
Co-authored-by: Christian Byrne <cbyrne@comfy.org >
2025-12-31 18:27:19 -07:00
Comfy Org PR Bot
9f3bbb94fd
[backport cloud/1.36] fix: restore mask editor compatibility with Impact-Pack plugin ( #7801 )
...
Backport of #7762 to `cloud/1.36`
Automatically created by backport workflow.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7801-backport-cloud-1-36-fix-restore-mask-editor-compatibility-with-Impact-Pack-plugin-2d96d73d36508190b073e683e4f08f2b )
by [Unito](https://www.unito.io )
Co-authored-by: Terry Jia <terryjia88@gmail.com >
cloud/v1.36.12
2025-12-30 12:54:32 -07:00
Alexander Brown
7b68b19f11
Component: The Rest of the PrimeVue buttons ( #7649 )
...
## Summary
Automated initial change, cleaned up manually.
Please check the screenshot changes.
Includes a11y updates to icon buttons.
Doesn't hit the buttons in Desktop.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7649-WIP-Component-The-Rest-of-the-PrimeVue-buttons-2ce6d73d365081d68e06f200f1321267 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: GitHub Action <action@github.com >
Co-authored-by: github-actions <github-actions@github.com >
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-12-29 15:03:34 -08:00
Godwin Iheuwa
ea96c71818
fix(queue): Cancel button now works for pending jobs ( #7788 )
...
## Summary
Fixes the cancel button on queue job items to properly handle pending
(queued) jobs.
## Problem
The cancel button was calling `api.interrupt()` for all jobs, but
interrupt only affects running/initializing jobs. For pending jobs, it
silently fails with log message: `"Prompt ... is not currently running,
skipping interrupt"`.
The "Cancel job" option in the context menu worked correctly because it
checks the job state first.
Reported in #7758 .
## Changes
Update `onCancelItem` in `QueueProgressOverlay.vue` to mirror the
behavior of `cancelJob()` in `useJobMenu.ts`:
- Check `item.state` before deciding which API to call
- Call `api.interrupt(promptId)` for `running` or `initialization`
states
- Call `api.deleteItem('queue', promptId)` for `pending` state
- Refresh queue state after cancel action with `queueStore.update()`
## Testing
- All 3816 unit tests pass
- Type check passes
- Lint passes (prettier, oxlint, eslint)
## Steps to Reproduce (before fix)
1. Queue more than 1 job
2. Open job history
3. Click "Cancel" button on any "in queue" job
4. Observe nothing happens (job remains in queue)
After this fix, clicking Cancel on a pending job will remove it from the
queue.
Fixes #7758
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7788-fix-queue-Cancel-button-now-works-for-pending-jobs-2d86d73d365081b3957fdf1d5d677809 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: RUiNtheExtinct <deepkarma001@gmail.com >
2025-12-29 11:48:59 -08:00
Csongor Czezar
a87bd0eb37
feat: position properties panel opposite to sidebar ( #7647 )
...
## Problem
When sidebar is positioned on the right, the properties panel also
appears on the right, causing both panels to compete for space and
creating a poor layout.
## Solution
Properties panel now dynamically positions itself opposite to the
sidebar:
- Sidebar left → Properties panel right (default)
- Sidebar right → Properties panel left
## Changes
- Modified `LiteGraphCanvasSplitterOverlay.vue` to conditionally render
properties panel based on sidebar location
- Updated splitter refresh key to recalculate layout when sidebar
position changes
- Added dynamic close button icon in `RightSidePanel.vue` that points in
the correct direction
## Testing
- Created E2E tests to verify positioning behavior
- Manually verified visual behavior in browser
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7647-feat-position-properties-panel-opposite-to-sidebar-2ce6d73d365081049683e74c8d03dbdd )
by [Unito](https://www.unito.io )
2025-12-29 10:58:38 -08:00
Christian Byrne
33d8cb7069
test: deflake templates locale coverage ( #7705 )
...
## Summary
Ensure the templates locale Playwright test validates localized UI text
instead of waiting on a flaky network request.
## Changes
- **What**: Update `Templates >> Uses proper locale files for templates`
to assert on French strings rendered in the dialog and confirm English
fallback is absent
## Review Focus
- Confirm the chosen French strings always appear when the localized
bundle loads so the test meaningfully covers the regression
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7705-test-deflake-templates-locale-coverage-2d16d73d365081ffbf9adc1623a36733 )
by [Unito](https://www.unito.io )
2025-12-27 18:40:00 -07:00
Comfy Org PR Bot
52bb58d307
1.36.12 ( #7763 )
...
Patch version increment to 1.36.12
**Base branch:** `main`
---------
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
v1.36.12
2025-12-27 17:05:27 -08:00
Terry Jia
59af15961f
feat: add ImageCompare node ( #7538 )
...
## Summary
add ImageCompare node, which is high demand among custom nodes, such as
rgthree, we should support as core node
Need BE change https://github.com/comfyanonymous/ComfyUI/pull/11343
## Screenshots (if applicable)
https://github.com/user-attachments/assets/a37bdcd0-de59-4bdd-bfc7-1adbe92f5298
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7538-feat-add-ImageCompare-node-2cb6d73d36508163a7d5f4807aece01a )
by [Unito](https://www.unito.io )
2025-12-26 13:27:44 -07:00
Tommie
533295ab76
Fix component widget state on graph change ( #7648 )
...
## Summary
Component widgets (e.g. Load3D) in the root graph stay inactive after
leaving a subgraph.
## Changes
- Adds component widget class to the active widget filter.
## Screenshots
|Before|After|
|-|-|
|||
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7648-Fix-component-widget-state-on-graph-change-2ce6d73d365081aabff5d6c07430da3d )
by [Unito](https://www.unito.io )
2025-12-26 11:09:12 -07:00
Jin Yi
39815b5a66
fix: import fail info warning icon ( #7753 )
...
# Fix Import Failed Warning Icon
## Problem Description
Warning icons were not displayed when import failed errors occurred in
installed packages.
## Root Cause
Conflict detection logic mismatch between `PackCardFooter` and
`PackEnableToggle`:
- **PackCardFooter**: Uses `checkNodeCompatibility()`
- System compatibility check **before** installation (OS, accelerator,
version, etc.)
- Does not include import failed information
- **PackEnableToggle**: Uses `getConflictsForPackageByID()`
- Actual conflict data **after** installation (including import failed)
- But was dependent on parent component's `hasConflict` prop
## Changes Made
### 1. PackEnableToggle.vue
```diff
- <div v-if="hasConflict">
+ <div v-if="packageConflict?.has_conflict">
```
- Removed `hasConflict` prop dependency
- Changed to use only internal store data (`packageConflict`)
### 2. PackCardFooter.vue
```diff
- <PackEnableToggle :has-conflict="hasConflicts" :node-pack="nodePack" />
+ <PackEnableToggle :node-pack="nodePack" />
```
- Removed unnecessary `has-conflict` prop passing
## Result
- ✅ Warning icon properly displays for installed packages with import
failed errors
- ✅ Conflict modal works correctly when clicked
- ✅ Each component uses appropriate conflict detection logic
[after.webm](https://github.com/user-attachments/assets/80576018-0a5b-4e32-9df6-686be3774313 )
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7753-fix-import-fail-info-warning-icon-2d36d73d365081518fbeedf539a19040 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: github-actions <github-actions@github.com >
2025-12-26 11:08:00 -07:00
DorotaL
27a479f9c4
[i18n] update zh ( #7761 )
...
## Summary
Update zh, supplemented the untranslated content.
Only locale changes.
## Changes
zh locales
## Review Focus
no sure this needs a review
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7761-i18n-update-zh-2d46d73d365081c59c27f0b6ba257526 )
by [Unito](https://www.unito.io )
2025-12-26 11:06:45 -07:00
Comfy Org PR Bot
f855deb4b1
1.36.11 ( #7760 )
...
Patch version increment to 1.36.11
**Base branch:** `main`
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7760-1-36-11-2d46d73d36508186b333d015d914acb5 )
by [Unito](https://www.unito.io )
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
v1.36.11
2025-12-24 16:39:49 -08:00
Alexander Piskun
723bbb98eb
add prices for Kling Motion Control node ( #7756 )
...
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7756-add-prices-for-Kling-Motion-Control-node-2d36d73d3650814193f3c84f25624518 )
by [Unito](https://www.unito.io )
2025-12-24 19:37:54 +02:00