Christian Byrne
cd970bd29d
fix: Add guards for _listenerController.abort() calls in SubgraphNode ( #4968 )
...
This fix adds guards before calling `_listenerController.abort()` to
prevent runtime errors when loading workflows. The guards check that
`_listenerController` exists and has an `abort` function before calling
it, matching the pattern used in Comfy-Org/litegraph.js#1134 .
Fixes https://github.com/Comfy-Org/ComfyUI_frontend/issues/4907
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4968-fix-Add-guards-for-_listenerController-abort-calls-in-SubgraphNode-24e6d73d3650813ebeeed69ee676faeb )
by [Unito](https://www.unito.io )
2025-08-14 10:45:33 +00:00
Terry Jia
ad7d23177e
show group self color in minimap ( #4954 )
...
a tiny fix that show group self color in minimap when checking node
color
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4954-show-group-self-color-in-minimap-24e6d73d3650812dbc58e9b134805f2d )
by [Unito](https://www.unito.io )
2025-08-14 10:45:32 +00:00
AustinMroz
ccaeab1541
Bundled subgraph fixes ( #4964 )
...
### Group support for subgraph unpacking
The unpacking code would silently delete groups (the cosmetic colored
rectangles). They are now correctly transferred.
### Fix subgraph node position on conversion to subgraph
Converting to subgraph will no longer cause nodes to inch upwards
### Make unpacking use same positioning calcs as conversion
Non trivial, but unpacking is now a proper inverse for conversion.
### Clean up old output links when unpacking
Unpacked nodes were left with dangling outputs. This would cause
cascading issues later, such as when consecutively unpacking nested
subgraphs.
### Minor refactoring for code clarity
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4964-Bundled-subgraph-fixes-24e6d73d365081d3a043ef1531d9d38a )
by [Unito](https://www.unito.io )
2025-08-14 10:45:32 +00:00
pythongosssss
3024dcc41b
Update side toolbar menu ( #4946 )
...
Side toolbar menu UI updates
## Summary
- Currently the template modal is very hidden. Many users do not find it
- The current icons are quite aleatory
## Changes
**What**:
- Add templates shortcut button
- Add item label in normal size
- Use custom icon
Critical design decisions or edge cases that need attention:
- Sidebar tabs registered using custom icons will have their associated
command registed with an undefined icon (currently only string icons are
accepted, not components). I couldn't see anywhere directly using this
icon, but we should consider autogenerating an icon font so we can use
classes for our custom icons (or locating and updating locations to
support both icon types)
## Screenshots (if applicable)
Normal mode:
<img width="621" height="1034" alt="image"
src="https://github.com/user-attachments/assets/c1d1cee2-004e-4ff8-b3fa-197329b0d2ae "
/>
Small mode:
<img width="176" height="325" alt="image"
src="https://github.com/user-attachments/assets/3824b8f6-bc96-4e62-aece-f0265113d2e3 "
/>
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4946-Update-side-toolbar-menu-24d6d73d365081c5b2bdc0ee8b61dc50 )
by [Unito](https://www.unito.io )
---------
Co-authored-by: github-actions <github-actions@github.com >
2025-08-14 10:45:32 +00:00
snomiao
c5581c9393
[feat] Add alternative package manager lockfiles to .gitignore ( #4961 )
...
## Summary
- Add bun.lock, bun.lockb, pnpm-lock.yaml, and yarn.lock to .gitignore
- Allows users to use faster package managers (Bun, pnpm) without making
git status dirty
- Maintains npm as the default while supporting developer choice of
package manager
## Test plan
- [x] Verify .gitignore changes are correct
- [ ] Test that creating these lockfiles doesn't show in git status
- [ ] Confirm existing npm functionality remains unaffected
🤖 Generated with [Claude Code](https://claude.ai/code )
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-4961-feat-Add-alternative-package-manager-lockfiles-to-gitignore-24e6d73d3650817c8fa4fb8e94df5ac6 )
by [Unito](https://www.unito.io )
Co-authored-by: Claude <noreply@anthropic.com >
2025-08-14 10:45:32 +00:00
snomiao
fe0054d9dd
[feat] Add Linux core dump to .gitignore ( #4960 )
...
Co-authored-by: Claude <noreply@anthropic.com >
Co-authored-by: github-actions <github-actions@github.com >
2025-08-14 10:45:32 +00:00
snomiao
b4bf72b2b7
Merge branch 'main' into sno-lint-issue-write
2025-08-13 15:56:38 +09:00
snomiao
45b43aa093
feat: Add issues write permission to workflows to avoid lint and i18n workflow conflicts
...
- Add issues: write permission to lint-and-format.yaml
- Add issues: write permission to i18n.yaml
- Prevents workflow conflicts when updating PR statuses or comments
2025-08-13 06:50:54 +00:00
snomiao
ec2888a116
[auto-fix] Apply ESLint and Prettier fixe
2025-08-13 05:25:41 +00:00
snomiao
0f747f3c5d
use auto-commit-action to handle pullrequest-ref name
2025-08-13 05:21:29 +00:00
AustinMroz
eba0b42674
Trigger updateSelectedItems on subgraph conversion ( #4949 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-08-12 20:16:48 -07:00
Alexander Piskun
ef1852d551
gemini-2.5-pro and flash models; corrected prices ( #4945 )
2025-08-12 14:52:44 -07:00
Alexander Piskun
983ebb2ba7
pricing update for MinimaxHailuoVideo node and Kling "kling-v2-1" model ( #4938 )
2025-08-12 14:15:06 -07:00
AustinMroz
db71365768
Implement subgraph unpacking ( #4840 )
2025-08-12 13:45:29 -07:00
Christian Byrne
17d7ba8bcb
[ci] Add lint:fix:no-cache script for consistency ( #4948 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-08-12 13:25:22 -07:00
Christian Byrne
24a386c766
fix: add cleanup for graphChanged listener in useWorkflowPersistence ( #4947 )
2025-08-12 12:27:04 -07:00
Christian Byrne
c42c9315f4
[refactor] Replace lodash with es-toolkit ( #4935 )
2025-08-12 12:22:09 -07:00
Sidharth
d068b8351e
Feat: add duplicate workflow on sidebar ( #4895 )
2025-08-12 12:04:29 -07:00
Christian Byrne
1cf8087be0
[ci] Optimize ESLint performance with caching and generated file excl… ( #4926 )
...
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com >
2025-08-12 13:31:54 -04:00
filtered
9c31d708a2
Add automatic trackpad / mouse sensing ( #4913 )
2025-08-12 10:15:32 -07:00
snomiao
7ee33e2892
kick-format-modify-main-ts
2025-08-12 11:52:25 +00:00
snomiao
73f71fc018
kick-format
2025-08-12 11:48:32 +00:00
Comfy Org PR Bot
9a70e927aa
1.26.2 ( #4939 )
...
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
Co-authored-by: github-actions <github-actions@github.com >
2025-08-12 00:52:23 -07:00
snomiao
6b085ea8c4
[feat] Add issues: write permission to lint-and-format workflow
...
The lint-and-format workflow creates comments on PRs, which requires
the issues: write permission to function properly.
🤖 Generated with [Claude Code](https://claude.ai/code )
Co-Authored-By: Claude <noreply@anthropic.com >
2025-08-12 06:49:15 +00:00
arab-future-academy
dc444faa75
Feature/arabic translation ( #4916 )
2025-08-11 23:29:01 -07:00
Jennifer Weber
a055ec2dff
[bugfix] Fix queue not updating with completed task images ( #4936 )
...
Co-authored-by: Jennifer Weber <weberjc@MacBookPro.lan >
2025-08-11 22:36:43 -07:00
Christian Byrne
2138ceea80
[fix] ensure consistent link release behavior for subgraph IO nodes ( #4931 )
2025-08-11 19:28:15 -07:00
Christian Byrne
7972550f6b
[fix] Fix link deletion from middle button when connected to reroute nodes deletes wrong link ( #4928 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-08-11 19:26:37 -07:00
Chenlei Hu
c7baf3c340
[feat] Add knip for unused code detection ( #4890 )
2025-08-11 19:23:08 -07:00
Terry Jia
8403bd0e3e
minimap improve ( #4679 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-08-11 14:04:02 -07:00
Christian Byrne
90f54414ab
fix: Multiple links from reroute create single slot on SubgraphOutputNode ( #4915 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-08-11 13:12:31 -07:00
Christian Byrne
505c242ff4
[refactor] Replace stringOrEmpty with lodash toString ( #4917 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-08-11 11:48:59 -07:00
Christian Byrne
fbc6edde25
[feat] Add red styling to Remove Slot context menu option ( #4918 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-08-11 11:48:02 -07:00
AustinMroz
2c215a6251
Fix subgraph reroute serialization ( #4911 )
2025-08-11 11:46:32 -07:00
Christian Byrne
71a43193df
[feat] Make hotkey for exiting subgraphs configurable in user keybindings ( #4818 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-08-11 10:22:13 -07:00
Christian Byrne
d0d13bfe4c
[ci] standardize release notes format in release commands ( #4912 )
2025-08-11 10:07:29 -07:00
Christian Byrne
a1a8d48544
[feat] Replace removeFromArray with lodash pull ( #4906 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-08-11 09:13:02 -07:00
Terry Jia
d22d62b670
[3d] initial version of 3d viewer ( #3968 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-08-10 21:09:19 -07:00
Chenlei Hu
8e357c41e3
[feat] Add PR creation automation command ( #4892 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-08-10 19:53:35 -04:00
Christian Byrne
c4912dcd54
[fix] Add bounds checking for clipspace indices to prevent paste errors ( #4849 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-08-10 15:45:28 -07:00
Comfy Org PR Bot
109542dca3
1.26.1 ( #4889 )
...
Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com >
2025-08-09 19:48:35 -07:00
Christian Byrne
ffc812a8f5
[refactor] Remove unused omitBy function ( #4886 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-08-09 19:12:48 -07:00
Christian Byrne
b745f533ba
[feat] Replace manual clamp function with lodash ( #4874 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-08-09 15:34:18 -07:00
Christian Byrne
8f289c8e67
Fix Alt-Click-Drag-Copy of Subgraph Nodes ( #4879 )
2025-08-09 15:33:59 -07:00
Vivek Chavan
79b4c78116
fix: hide More menu when no submenu items are visible ( #4837 )
2025-08-09 15:12:31 -07:00
Vivek Chavan
48aea928e0
fix: hide Desktop User Guide menu item in web builds ( #4828 )
2025-08-09 15:08:33 -07:00
pythongosssss
03ad06ea14
Add preview to workflow tabs ( #4290 )
2025-08-09 14:39:40 -07:00
filtered
ff5943f770
Reorder subgraph context menu items ( #4870 )
...
Co-authored-by: github-actions <github-actions@github.com >
2025-08-09 14:20:26 -07:00
Christian Byrne
b1117b9838
[ci] Add chromium-0.5x to test matrix ( #4880 )
...
Co-authored-by: Claude <noreply@anthropic.com >
2025-08-09 14:15:08 -07:00
filtered
2d11fb1f90
[CI] Pin third party GH actions to specific SHAs ( #4878 )
2025-08-09 13:18:43 -07:00
