Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-24 00:34:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
6,736 Commits 660 Branches 559 Tags
d3c0e331eb6fe825640137eff49cd872fcec1921
Commit Graph

4793 Commits

Author SHA1 Message Date
Chenlei Hu
dbe016b934 Move widget prop to INodeInputSlot (#606) 
Ref: https://github.com/Comfy-Org/ComfyUI_frontend/pull/2728
 2025-02-25 19:37:40 -05:00
Chenlei Hu
a784abef0d Type INodeOutputSlot widget hack on PrimitiveNode (#2728) 2025-02-25 19:34:23 -05:00
Chenlei Hu
cdbd0899e2 [Reland][TS] Use strict mode in LGraphNode - part 2 (#604) 
Reverts Comfy-Org/litegraph.js#603
 2025-02-25 16:39:31 -05:00
Chenlei Hu
67d8c3177a Revert "[TS] Use strict mode in LGraphNode - part 2" (#603) 
Reverts Comfy-Org/litegraph.js#601

Reason: breaks legacy reroute

On inserting a workflow with legacy reroute node
```
Uncaught (in promise) NullGraphError: Attempted to access LGraph reference that was null or undefined.
    at RerouteNode.removeOutput (LGraphNode.ts:1425:28)
    at RerouteNode.clone (rerouteNode.ts:215:18)
    at LGraphCanvas.copyToClipboard (LGraphCanvas.ts:3331:29)
    at Object.insertWorkflow (workflowService.ts:350:12)
```
 2025-02-25 14:10:27 -05:00
filtered
67ee55ede1 [TS] Use strict mode in LGraphNode - part 2 (#601) 
- Guards against nullish `graph`
- [Fix regression in return type -
getInputLink](143ca5f3f2)
- long-standing, so no impact apparently
- Resolves some potential null dereferencing
 2025-02-25 13:40:50 -05:00
filtered
c20ea0c523 [TS] Add null check in graph to prompt (#2727) 2025-02-25 13:39:46 -05:00
filtered
f39e1d96e8 [TS] Use strict mode in LLink & Reroute (#602) 
- Adds fallback colour if reroute colour is somehow nullish
 2025-02-25 18:00:33 +00:00
filtered
4636367de2 [TS] Use strict mode in LGraphNode - initial (#598) 
- Part of effort to convert LGraphNode to TS strict
- Adds some small runtime changes - no impact expected, but it is
possible
- Runtime changes are in separate commits from compile-time type changes
- Risk of downstream impact is low
 2025-02-25 17:19:27 +00:00
filtered
0b84ca83d8 [TS] Use strict mode in LGraphGroup (#599) 
- Adds `NullGraphError` to reduce boilerplate null check code
- Prefer optional `undefined` to explicit `null`
  - Related: https://github.com/Comfy-Org/litegraph.js/issues/595
- Adds strict types
 2025-02-25 17:15:48 +00:00
filtered
101e8dea11 [TS] Update type to match strict Litegraph (#2726) 2025-02-26 04:00:55 +11:00
filtered
477d498d6b [API] Remove unused: optional_inputs & outputs (#597) 
Code search shows zero usage. If kept, typing properly would require
effort.

Removed:
- `LGraphNode.optional_inputs`
- `LGraphNode.optional_outputs`
 2025-02-25 16:33:21 +00:00
Chenlei Hu
156013aa24 [Reland] Restrict applyToGraph to PrimitiveNode (#2724) 2025-02-25 10:54:21 -05:00
Comfy Org PR Bot
1a7145fbc9 Update locales for node definitions (#2723) 
Co-authored-by: huchenlei <20929282+huchenlei@users.noreply.github.com>
 2025-02-25 10:24:09 -05:00
Terry Jia
956b9609fd [3d] disable depth mode (#2720) 2025-02-25 10:05:10 -05:00
filtered
4920e10f0c [TS] Use strict mode in LiteGraphGlobal (#593) 
- Adds minor type coercions to resolve type errors
- Adds ts-ignore that must be removed later
 2025-02-25 11:59:39 +00:00
filtered
51c16a4f56 [TS] Add null check in paste handler (#2722) 2025-02-25 22:45:37 +11:00
filtered
417a089186 [Refactor] Use more explicit types in usePaste (#2721) 2025-02-25 21:52:47 +11:00
filtered
6bd151c91e [API] Remove LiteGraph.searchbox_extras (#592) 
- Unused, loose typing
- Code search shows usage is limited to code copy & paste of litegraph
code
- So long as the `searchbox_extras` property exists and is empty, there
is no change to downstream consumers
 2025-02-25 09:16:49 +00:00
Chenlei Hu
f5cec41130 [i18n] Translate button widget labels (#2719) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-02-24 20:31:14 -05:00
filtered
a4b9704a80 Remove entry point import, merge modules (#590) 
* Remove unused import in lib entry point

* [Refactor] Merge type util modules
 2025-02-25 01:25:42 +00:00
filtered
ad8dd7a9d8 Export enum (#589) 
* Revert "Export enum (#587)"

This reverts commit cf8565eb13.

* Export enums
 2025-02-25 01:08:04 +00:00
Chenlei Hu
d3dda14267 Update litegraph 0.8.95 (#2718) 2025-02-24 19:48:44 -05:00
Chenlei Hu
cf8565eb13 Export enum (#587) 2025-02-24 19:37:18 -05:00
Chenlei Hu
fadece7fdf Type LGraphNode.addInput/Output (#585) 2025-02-24 19:29:04 -05:00
bymyself
aabd409bf7 Add copy paste audio files onto LoadAudio nodes or canvas (#2716) 2025-02-24 16:37:03 -05:00
Chenlei Hu
59dea644f2 Move marker property from BaseWidget to SliderWidget (#584) 
* Move marker property from BaseWidget to SliderWidget

* nit
 2025-02-24 16:35:34 -05:00
Chenlei Hu
170341db73 Type ButtonWidget (#583) 
* Type ButtonWidget

* nit
 2025-02-24 16:30:04 -05:00
Terry Jia
7f98342492 [3d] some general improvement (#2714) 2025-02-24 14:57:36 -05:00
Chenlei Hu
1a9d6aca7d [nit] Fix import path (#2715) 2025-02-24 14:57:20 -05:00
bymyself
15785fea68 Add drag and drop audio files onto LoadAudio nodes (#2710) 
Co-authored-by: Chenlei Hu <huchenlei@proton.me>
 2025-02-24 14:05:44 -05:00
bymyself
d340e634a8 [Refactor] Move node composables to subfolder (#2712) 2025-02-24 14:04:16 -05:00
bymyself
9cb993cd3d [CodeHealth] Remove unused var (#2713) 2025-02-24 14:03:52 -05:00
Chenlei Hu
2ac67f2dd0 Add tooltip show-delay in action bar (#2709) 2025-02-24 11:22:26 -05:00
Chenlei Hu
96ba2b4564 Allow quitting instant queue mode with the stop button (#2708) 2025-02-24 11:20:34 -05:00
bymyself
05bd64820d Fix node videos when preview format setting is set (#2706) 2025-02-24 10:49:45 -05:00
bymyself
a35071fcb2 Add previewMediaType flag for simpler node preview rendering (#2694) 
Co-authored-by: huchenlei <huchenlei@proton.me>
 2025-02-24 10:48:55 -05:00
bymyself
37d4cc974b Cleanup node's file input elements on node removal (#2703) 
Co-authored-by: huchenlei <huchenlei@proton.me>
 2025-02-24 10:45:27 -05:00
bymyself
81102604f5 Type addDOMWidget (#2705) 2025-02-24 10:32:43 -05:00
filtered
630fd00086 [API] Remove unused LiteGraph APIs (#582) 
* [API] Remove unused LiteGraph APIs

These features have not been maintained, and would require refactoring / rewrites. As code search revealed them to be unused, they are being removed.

- addNodeMethod
- compareObjects
- auto_sort_node_types

* Udpate API.md
 2025-02-24 12:04:07 +00:00
filtered
c8ffacf172 [TS] Use strict mode in LGraph (#579) 
* [TS] Undefined is not a valid object key

* Deprecate unused code

Adds ts-expect-error to TS strict issues on unmaintained public interfaces.

* [TS] Fix nullability: asSerialisable return type

* nit - Remove outdated comment

* [TS] Strict mode: LGraph

- Adds minor coercion changes; would need extremely specific hacks performed to result in runtime change

* [TMP] Work around typescript-strict-plugin

Must be reverted once plugin removed.
See #578
 2025-02-24 11:12:46 +00:00
filtered
97f9d654b6 [TS] Fix nullability (#2702) 
`LGraphCanvas.graph` may explicity set to null by litegraph.
 2025-02-24 22:00:19 +11:00
filtered
9d6c867607 [TS] Strict mode: CurveEditor (#580) 
- Converts `CurveEditor` to ts strict
- Two runtime changes: explicit throws instead of `TypeError` on following line
 2025-02-24 10:21:35 +00:00
Terry Jia
822a8e02f8 [3d] add missing i18n (#2700) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-02-23 23:50:13 -05:00
filtered
bcd5a77837 [TS] Strict initializers - LGraph (#573) 
Duplicates values from clear() to property initializers.
 2025-02-24 03:30:20 +00:00
Chenlei Hu
eb951c9cf9 Show image size (W x H) on image nodes (#2699) 2025-02-23 19:52:58 -05:00
filtered
1800d31a5a [Refactor] Prefer modern for..of loops 2 (#569) 
* [Refactor] Prefer for..of

* [Refactor] Prefer for..of - manual refactoring

* Partially revert change - potential conflict

Not worth time investment to fix - reverted.
 2025-02-23 16:36:52 -05:00
filtered
436b952c59 [Refactor] Simplify & document graphToPrompt (#2696) 2025-02-23 16:18:06 -05:00
Chenlei Hu
f300e37a89 Remove NodeSlot.pos when serializing WidgetInputSlot (#570) 2025-02-23 16:11:56 -05:00
filtered
4add6c3211 [Cleanup] Follow-up on #566 - fix style (#568) 2025-02-23 20:20:44 +00:00
filtered
46535409c8 [CI] Fix existing lint warnings & disallow in future (#567) 
* Fix lint warnings

* [CI] Fail lint checks instead of warning

* [CI] Fail stylistic lint checks instead of warning
 2025-02-23 20:12:04 +00:00