Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-07 00:20:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,639 Commits 601 Branches 536 Tags
da078a60715ff07b2fc6e1b3283c6f8564a46613
Commit Graph

3858 Commits

Author SHA1 Message Date
Chenlei Hu
963e4b0904 [Type] Mark name as required prop for IBaseWidget (#623) 2025-02-26 15:03:31 -05:00
Chenlei Hu
d20aab757c Serialize NodeInputSlot.widget (#622) 
Serialize linked widget on node input slot properly according to current
save format in
76818b54e6/src/extensions/core/widgetInputs.ts
 2025-02-26 14:15:31 -05:00
Chenlei Hu
2d41aed051 [BugFix] Properly update color button color on first selection (#2736) 2025-02-26 13:43:09 -05:00
filtered
c166a34fd8 Add ESLint rules to enforce existing lib style (#621) 
Adds a few rules that enforce consistency across the repo.

Only change is one top-level const arrow function is now a function
definition.
 2025-02-26 18:12:26 +00:00
Miguel C
7e6b64f216 Fix widget sizing logic in LGraphCanvas and LGraphNode (#609) 
This fixes an issue with widget heights not coinciding with actual
computed heights.
<img
src="https://github.com/user-attachments/assets/50b4b86c-8de8-4844-9a17-6f18d32e7f5e"
height="128" alt="old">old
<img
src="https://github.com/user-attachments/assets/c34e432a-6941-469e-99cd-df15c0a527de"
height="256" alt="new">new
 2025-02-26 10:56:30 -05:00
bymyself
237b895e8b Add thumbnails for workflow templates (#2729) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-02-26 10:39:27 -05:00
bymyself
74e8852958 Fix combo values from optional inputs not changed when refreshing (#2733) 2025-02-26 10:35:22 -05:00
filtered
0e9b8b03b7 Enforce curly braces in multi-line if statements (#619) 
Removes formatters' ability to print code that goes to a new line, but
uses no braces to delineate.

It becomes more difficult to follow when using JS-style indents (two
spaces).

No effort required - braces added by auto-fixer.
 2025-02-26 15:08:23 +00:00
filtered
a43109d58a [TS] Use strict mode in ContextMenu (#618) 
- Adds minor type coercions to resolve type errors
- Uses the same type-coercion behaviour of the target DOM object
properties
- Resolves a long-standing type issue in context menu interfaces
(converts to generic - `unknown` by default)
- Fixes several incorrect types
- Adds ts-ignore that must be removed later
 2025-02-26 14:29:45 +00:00
filtered
3040924d76 [TS] Use strict mode in CanvasPointer, measure, and polyfills (#617) 
- Adds runtime type guard
- Adds ts-ignore that must be removed later
  * [ ] #578
 2025-02-26 13:05:40 +00:00
filtered
0b59c00597 [API] Remove deprecated: DragAndScale mouse (#615) 
Removed unused public methods (unmaintained, non-functional):
- bindEvents
- onMouse

`onredraw` is in use by extension authors.

This file now passes TS strict checks.
 2025-02-26 11:59:12 +00:00
filtered
867b9ed316 [nit] Add consistent method chaining linter (#613) 
Enforces that chained accessed should **either** all be on one line, or
all on individual lines (same as imports).
 2025-02-26 10:11:11 +00:00
filtered
5cdd0581fa Add import / export sort rules (#612) 
- Adds ESLint package
- Applies import/export rules to all files
- Uses newline delineated grouping, with type-only imports first
 2025-02-26 09:21:33 +00:00
filtered
9ded97d189 [Doc] Add JSDoc linter & general comment clean up (#611) 
- Prefer comments above lines over end-of-line comments
  - Makes auto-formatting easier
  - Subjective, but it is generally easier to read in JS
- Standardises JSdoc format
- Auto-fixes for many issues (applies on save w/ESLint extension)
 2025-02-26 08:54:18 +00:00
Chenlei Hu
953ae434ea Type serialized NodeSlot (#605) 2025-02-25 19:38:14 -05:00
Chenlei Hu
dbe016b934 Move widget prop to INodeInputSlot (#606) 
Ref: https://github.com/Comfy-Org/ComfyUI_frontend/pull/2728
 2025-02-25 19:37:40 -05:00
Chenlei Hu
a784abef0d Type INodeOutputSlot widget hack on PrimitiveNode (#2728) 2025-02-25 19:34:23 -05:00
Chenlei Hu
cdbd0899e2 [Reland][TS] Use strict mode in LGraphNode - part 2 (#604) 
Reverts Comfy-Org/litegraph.js#603
 2025-02-25 16:39:31 -05:00
Chenlei Hu
67d8c3177a Revert "[TS] Use strict mode in LGraphNode - part 2" (#603) 
Reverts Comfy-Org/litegraph.js#601

Reason: breaks legacy reroute

On inserting a workflow with legacy reroute node
```
Uncaught (in promise) NullGraphError: Attempted to access LGraph reference that was null or undefined.
    at RerouteNode.removeOutput (LGraphNode.ts:1425:28)
    at RerouteNode.clone (rerouteNode.ts:215:18)
    at LGraphCanvas.copyToClipboard (LGraphCanvas.ts:3331:29)
    at Object.insertWorkflow (workflowService.ts:350:12)
```
 2025-02-25 14:10:27 -05:00
filtered
67ee55ede1 [TS] Use strict mode in LGraphNode - part 2 (#601) 
- Guards against nullish `graph`
- [Fix regression in return type -
getInputLink](143ca5f3f2)
- long-standing, so no impact apparently
- Resolves some potential null dereferencing
 2025-02-25 13:40:50 -05:00
filtered
c20ea0c523 [TS] Add null check in graph to prompt (#2727) 2025-02-25 13:39:46 -05:00
filtered
f39e1d96e8 [TS] Use strict mode in LLink & Reroute (#602) 
- Adds fallback colour if reroute colour is somehow nullish
 2025-02-25 18:00:33 +00:00
filtered
4636367de2 [TS] Use strict mode in LGraphNode - initial (#598) 
- Part of effort to convert LGraphNode to TS strict
- Adds some small runtime changes - no impact expected, but it is
possible
- Runtime changes are in separate commits from compile-time type changes
- Risk of downstream impact is low
 2025-02-25 17:19:27 +00:00
filtered
0b84ca83d8 [TS] Use strict mode in LGraphGroup (#599) 
- Adds `NullGraphError` to reduce boilerplate null check code
- Prefer optional `undefined` to explicit `null`
  - Related: https://github.com/Comfy-Org/litegraph.js/issues/595
- Adds strict types
 2025-02-25 17:15:48 +00:00
filtered
101e8dea11 [TS] Update type to match strict Litegraph (#2726) 2025-02-26 04:00:55 +11:00
filtered
477d498d6b [API] Remove unused: optional_inputs & outputs (#597) 
Code search shows zero usage. If kept, typing properly would require
effort.

Removed:
- `LGraphNode.optional_inputs`
- `LGraphNode.optional_outputs`
 2025-02-25 16:33:21 +00:00
Chenlei Hu
156013aa24 [Reland] Restrict applyToGraph to PrimitiveNode (#2724) 2025-02-25 10:54:21 -05:00
Comfy Org PR Bot
1a7145fbc9 Update locales for node definitions (#2723) 
Co-authored-by: huchenlei <20929282+huchenlei@users.noreply.github.com>
 2025-02-25 10:24:09 -05:00
Terry Jia
956b9609fd [3d] disable depth mode (#2720) 2025-02-25 10:05:10 -05:00
filtered
4920e10f0c [TS] Use strict mode in LiteGraphGlobal (#593) 
- Adds minor type coercions to resolve type errors
- Adds ts-ignore that must be removed later
 2025-02-25 11:59:39 +00:00
filtered
51c16a4f56 [TS] Add null check in paste handler (#2722) 2025-02-25 22:45:37 +11:00
filtered
417a089186 [Refactor] Use more explicit types in usePaste (#2721) 2025-02-25 21:52:47 +11:00
filtered
6bd151c91e [API] Remove LiteGraph.searchbox_extras (#592) 
- Unused, loose typing
- Code search shows usage is limited to code copy & paste of litegraph
code
- So long as the `searchbox_extras` property exists and is empty, there
is no change to downstream consumers
 2025-02-25 09:16:49 +00:00
Chenlei Hu
f5cec41130 [i18n] Translate button widget labels (#2719) 
Co-authored-by: github-actions <github-actions@github.com>
 2025-02-24 20:31:14 -05:00
filtered
a4b9704a80 Remove entry point import, merge modules (#590) 
* Remove unused import in lib entry point

* [Refactor] Merge type util modules
 2025-02-25 01:25:42 +00:00
filtered
ad8dd7a9d8 Export enum (#589) 
* Revert "Export enum (#587)"

This reverts commit cf8565eb13.

* Export enums
 2025-02-25 01:08:04 +00:00
Chenlei Hu
d3dda14267 Update litegraph 0.8.95 (#2718) 2025-02-24 19:48:44 -05:00
Chenlei Hu
cf8565eb13 Export enum (#587) 2025-02-24 19:37:18 -05:00
Chenlei Hu
fadece7fdf Type LGraphNode.addInput/Output (#585) 2025-02-24 19:29:04 -05:00
bymyself
aabd409bf7 Add copy paste audio files onto LoadAudio nodes or canvas (#2716) 2025-02-24 16:37:03 -05:00
Chenlei Hu
59dea644f2 Move marker property from BaseWidget to SliderWidget (#584) 
* Move marker property from BaseWidget to SliderWidget

* nit
 2025-02-24 16:35:34 -05:00
Chenlei Hu
170341db73 Type ButtonWidget (#583) 
* Type ButtonWidget

* nit
 2025-02-24 16:30:04 -05:00
Terry Jia
7f98342492 [3d] some general improvement (#2714) 2025-02-24 14:57:36 -05:00
Chenlei Hu
1a9d6aca7d [nit] Fix import path (#2715) 2025-02-24 14:57:20 -05:00
bymyself
15785fea68 Add drag and drop audio files onto LoadAudio nodes (#2710) 
Co-authored-by: Chenlei Hu <huchenlei@proton.me>
 2025-02-24 14:05:44 -05:00
bymyself
d340e634a8 [Refactor] Move node composables to subfolder (#2712) 2025-02-24 14:04:16 -05:00
bymyself
9cb993cd3d [CodeHealth] Remove unused var (#2713) 2025-02-24 14:03:52 -05:00
Chenlei Hu
2ac67f2dd0 Add tooltip show-delay in action bar (#2709) 2025-02-24 11:22:26 -05:00
Chenlei Hu
96ba2b4564 Allow quitting instant queue mode with the stop button (#2708) 2025-02-24 11:20:34 -05:00
bymyself
05bd64820d Fix node videos when preview format setting is set (#2706) 2025-02-24 10:49:45 -05:00