Compare commits

...

2 Commits

Author SHA1 Message Date
Glary-Bot
defd48b49c fix: add rel="noopener noreferrer" to privacy-policy links opened in new tab
Addresses CodeRabbit review on PR #12415. Hardens the three external privacy-policy anchors with target="_blank" to prevent the opened page from accessing window.opener.
2026-05-22 07:53:38 +00:00
Glary-Bot
741be80956 fix: redirect /privacy to /privacy-policy on comfy.org
/privacy was 404'ing because the page lives at /privacy-policy. Add a 308 redirect in vercel.json and fix four hardcoded /privacy links (and the browser test asserting the broken URL) to point at /privacy-policy directly.
2026-05-22 07:38:29 +00:00
6 changed files with 24 additions and 13 deletions

View File

@@ -1,23 +1,23 @@
<template>
<div class="flex flex-col gap-6 w-[600px]">
<div class="flex w-[600px] flex-col gap-6">
<div class="flex flex-col gap-4">
<h2 class="text-2xl font-semibold text-neutral-100">
{{ $t('install.desktopAppSettings') }}
</h2>
<p class="text-neutral-400 my-0">
<p class="my-0 text-neutral-400">
{{ $t('install.desktopAppSettingsDescription') }}
</p>
</div>
<div class="flex flex-col bg-neutral-800 p-4 rounded-lg text-sm">
<div class="flex flex-col rounded-lg bg-neutral-800 p-4 text-sm">
<!-- Auto Update Setting -->
<div class="flex items-center gap-4">
<div class="flex-1">
<h3 class="text-lg font-medium text-neutral-100">
{{ $t('install.settings.autoUpdate') }}
</h3>
<p class="text-neutral-400 mt-1">
<p class="mt-1 text-neutral-400">
{{ $t('install.settings.autoUpdateDescription') }}
</p>
</div>
@@ -52,10 +52,10 @@
class="select-none"
>
<div class="text-neutral-300">
<h4 class="font-medium mb-2">
<h4 class="mb-2 font-medium">
{{ $t('install.settings.dataCollectionDialog.whatWeCollect') }}
</h4>
<ul class="list-disc pl-6 space-y-1">
<ul class="list-disc space-y-1 pl-6">
<li>
{{
$t('install.settings.dataCollectionDialog.collect.errorReports')
@@ -73,10 +73,10 @@
</li>
</ul>
<h4 class="font-medium mt-4 mb-2">
<h4 class="mt-4 mb-2 font-medium">
{{ $t('install.settings.dataCollectionDialog.whatWeDoNotCollect') }}
</h4>
<ul class="list-disc pl-6 space-y-1">
<ul class="list-disc space-y-1 pl-6">
<li>
{{
$t(
@@ -108,7 +108,11 @@
</ul>
<div class="mt-4">
<a href="https://comfy.org/privacy" target="_blank">
<a
href="https://comfy.org/privacy-policy"
target="_blank"
rel="noopener noreferrer"
>
{{ $t('install.settings.dataCollectionDialog.viewFullPolicy') }}
</a>
</div>

View File

@@ -13,8 +13,9 @@
<p class="text-neutral-400">
{{ $t('install.moreInfo') }}
<a
href="https://comfy.org/privacy"
href="https://comfy.org/privacy-policy"
target="_blank"
rel="noopener noreferrer"
class="text-blue-400 underline hover:text-blue-300"
>
{{ $t('install.privacyPolicy') }} </a

View File

@@ -22,6 +22,11 @@
"destination": "/cloud/pricing",
"permanent": true
},
{
"source": "/privacy",
"destination": "/privacy-policy",
"permanent": true
},
{
"source": "/enterprise",
"destination": "/cloud/enterprise",

View File

@@ -68,7 +68,7 @@ test.describe('Sign In dialog', { tag: '@ui' }, () => {
await expect(dialog.privacyLink).toBeVisible()
await expect(dialog.privacyLink).toHaveAttribute(
'href',
'https://www.comfy.org/privacy'
'https://www.comfy.org/privacy-policy'
)
})

View File

@@ -126,8 +126,9 @@
</a>
{{ t('auth.login.andText') }}
<a
href="https://www.comfy.org/privacy"
href="https://www.comfy.org/privacy-policy"
target="_blank"
rel="noopener noreferrer"
class="cursor-pointer text-blue-500"
>
{{ t('auth.login.privacyLink') }} </a

View File

@@ -132,7 +132,7 @@
</template>
<template #privacy>
<a
href="https://www.comfy.org/privacy"
href="https://www.comfy.org/privacy-policy"
target="_blank"
rel="noopener noreferrer"
class="underline hover:text-base-foreground"