Merge branch 'main' into feat/websocket-reconnect-telemetry

Reconnect events are operational/debug signals, not product analytics.
Sentry is the right home for this — breadcrumbs for all reconnects,
captureMessage (warning) when jobs were in flight.

Also addresses review feedback:
- Extract to useWebSocketReconnectTracking composable
- Use performance.now() instead of Date.now()
- Add tests for the composable (6 cases)
- Remove PostHog/Mixpanel telemetry plumbing

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

src/composables/useWebSocketReconnectTracking.test.ts

@@ -0,0 +1,101 @@
+import * as Sentry from '@sentry/vue'
+import { createPinia, setActivePinia } from 'pinia'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+import { useWebSocketReconnectTracking } from './useWebSocketReconnectTracking'
+
+vi.mock('@sentry/vue', () => ({
+  addBreadcrumb: vi.fn(),
+  captureMessage: vi.fn()
+}))
+
+vi.mock('@/stores/queueStore', () => ({
+  useQueueStore: () => ({
+    activeJobsCount: mockActiveJobsCount
+  })
+}))
+
+let mockActiveJobsCount = 0
+
+describe('useWebSocketReconnectTracking', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+    mockActiveJobsCount = 0
+    setActivePinia(createPinia())
+  })
+
+  it('does nothing on reconnect without prior disconnect', () => {
+    const { onReconnect } = useWebSocketReconnectTracking()
+    onReconnect()
+    expect(Sentry.addBreadcrumb).not.toHaveBeenCalled()
+    expect(Sentry.captureMessage).not.toHaveBeenCalled()
+  })
+
+  it('adds breadcrumb on reconnect after disconnect', () => {
+    const { onDisconnect, onReconnect } = useWebSocketReconnectTracking()
+    onDisconnect()
+    onReconnect()
+
+    expect(Sentry.addBreadcrumb).toHaveBeenCalledWith(
+      expect.objectContaining({
+        category: 'websocket',
+        message: 'WebSocket reconnected',
+        level: 'info'
+      })
+    )
+  })
+
+  it('captures warning when jobs were active at disconnect', () => {
+    mockActiveJobsCount = 3
+    const { onDisconnect, onReconnect } = useWebSocketReconnectTracking()
+    onDisconnect()
+    onReconnect()
+
+    expect(Sentry.captureMessage).toHaveBeenCalledWith(
+      'WebSocket reconnected with active jobs',
+      expect.objectContaining({
+        level: 'warning',
+        tags: { incident: 'incident-39' },
+        extra: expect.objectContaining({ active_job_count: 3 })
+      })
+    )
+  })
+
+  it('does not capture warning when no jobs were active', () => {
+    mockActiveJobsCount = 0
+    const { onDisconnect, onReconnect } = useWebSocketReconnectTracking()
+    onDisconnect()
+    onReconnect()
+
+    expect(Sentry.addBreadcrumb).toHaveBeenCalled()
+    expect(Sentry.captureMessage).not.toHaveBeenCalled()
+  })
+
+  it('ignores duplicate disconnect calls', () => {
+    mockActiveJobsCount = 2
+    const { onDisconnect, onReconnect } = useWebSocketReconnectTracking()
+    onDisconnect()
+
+    // Job count changes between disconnect calls
+    mockActiveJobsCount = 5
+    onDisconnect()
+
+    onReconnect()
+
+    // Should use the count from the first disconnect (2), not the second (5)
+    expect(Sentry.addBreadcrumb).toHaveBeenCalledWith(
+      expect.objectContaining({
+        data: expect.objectContaining({ active_job_count: 2 })
+      })
+    )
+  })
+
+  it('resets state and prevents stale reconnect', () => {
+    const { onDisconnect, onReconnect, reset } = useWebSocketReconnectTracking()
+    onDisconnect()
+    reset()
+    onReconnect()
+
+    expect(Sentry.addBreadcrumb).not.toHaveBeenCalled()
+  })
+})

src/composables/useWebSocketReconnectTracking.ts

@@ -0,0 +1,66 @@
+import * as Sentry from '@sentry/vue'
+
+import { useQueueStore } from '@/stores/queueStore'
+
+/**
+ * Tracks WebSocket disconnect/reconnect events via Sentry for incident-39
+ * observability. Captures disconnect duration and whether jobs were in flight
+ * when the connection dropped.
+ */
+export function useWebSocketReconnectTracking() {
+  const queueStore = useQueueStore()
+
+  let disconnectedAt: number | null = null
+  let activeJobCountAtDisconnect = 0
+
+  function onDisconnect() {
+    if (disconnectedAt !== null) return
+
+    disconnectedAt = performance.now()
+    // Includes both pending and running tasks. Pending tasks matter because
+    // their pending->running transition is delivered via WebSocket -- if the
+    // connection drops while tasks are queued, the user never sees them start.
+    activeJobCountAtDisconnect = queueStore.activeJobsCount
+  }
+
+  function onReconnect() {
+    if (disconnectedAt === null) return
+
+    const durationMs = Math.round(performance.now() - disconnectedAt)
+    const hadActiveJobs = activeJobCountAtDisconnect > 0
+
+    Sentry.addBreadcrumb({
+      category: 'websocket',
+      message: 'WebSocket reconnected',
+      level: 'info',
+      data: {
+        disconnect_duration_ms: durationMs,
+        had_active_jobs: hadActiveJobs,
+        active_job_count: activeJobCountAtDisconnect
+      }
+    })
+
+    if (hadActiveJobs) {
+      Sentry.captureMessage('WebSocket reconnected with active jobs', {
+        level: 'warning',
+        tags: {
+          incident: 'incident-39'
+        },
+        extra: {
+          disconnect_duration_ms: durationMs,
+          active_job_count: activeJobCountAtDisconnect
+        }
+      })
+    }
+
+    disconnectedAt = null
+    activeJobCountAtDisconnect = 0
+  }
+
+  function reset() {
+    disconnectedAt = null
+    activeJobCountAtDisconnect = 0
+  }
+
+  return { onDisconnect, onReconnect, reset }
+}

src/views/GraphView.vue

@@ -66,6 +66,7 @@ import ModelImportProgressDialog from '@/platform/assets/components/ModelImportP
 import { isCloud, isDesktop } from '@/platform/distribution/types'
 import { useSettingStore } from '@/platform/settings/settingStore'
 import { useTelemetry } from '@/platform/telemetry'
+import { useWebSocketReconnectTracking } from '@/composables/useWebSocketReconnectTracking'
 import { useFrontendVersionMismatchWarning } from '@/platform/updates/common/useFrontendVersionMismatchWarning'
 import { useVersionCompatibilityStore } from '@/platform/updates/common/versionCompatibilityStore'
 import { useCanvasStore } from '@/renderer/core/canvas/canvasStore'
@@ -253,7 +254,10 @@ const reconnectingMessage: ToastMessageOptions = {
   summary: t('g.reconnecting')
 }
 
+const wsReconnectTracking = useWebSocketReconnectTracking()
+
 const onReconnecting = () => {
+  wsReconnectTracking.onDisconnect()
   if (!settingStore.get('Comfy.Toast.DisableReconnectingToast')) {
     toast.remove(reconnectingMessage)
     toast.add(reconnectingMessage)
@@ -261,6 +265,7 @@ const onReconnecting = () => {
 }
 
 const onReconnected = () => {
+  wsReconnectTracking.onReconnect()
   if (!settingStore.get('Comfy.Toast.DisableReconnectingToast')) {
     toast.remove(reconnectingMessage)
     toast.add({
@@ -288,6 +293,7 @@ onMounted(() => {
 })
 
 onBeforeUnmount(() => {
+  wsReconnectTracking.reset()
   executionStore.unbindExecutionEvents()
 })