fix(tests): align LGraphNode mock with Pinia 3

pnpm install
Merge remote-tracking branch 'origin/main' into bl/amd-gpu-picker
2026-04-17 21:21:06 +00:00 · 2025-12-30 16:21:51 -08:00 · 2025-12-30 15:36:23 -08:00 · 2025-12-30 15:33:28 -08:00 · 2025-12-30 15:12:59 -08:00 · 2025-12-30 15:09:26 -08:00
12 changed files with 152 additions and 124 deletions
--- a/apps/desktop-ui/public/assets/images/amd-rocm-logo.png
+++ b/apps/desktop-ui/public/assets/images/amd-rocm-logo.png
--- a/apps/desktop-ui/src/components/install/GpuPicker.vue
+++ b/apps/desktop-ui/src/components/install/GpuPicker.vue
@@ -11,29 +11,32 @@
      <!-- Apple Metal / NVIDIA -->
      <HardwareOption
        v-if="platform === 'darwin'"
-        :image-path="'./assets/images/apple-mps-logo.png'"
+        image-path="./assets/images/apple-mps-logo.png"
        placeholder-text="Apple Metal"
        subtitle="Apple Metal"
-        :value="'mps'"
        :selected="selected === 'mps'"
-        :recommended="true"
        @click="pickGpu('mps')"
      />
-      <HardwareOption
-        v-else
-        :image-path="'./assets/images/nvidia-logo-square.jpg'"
-        placeholder-text="NVIDIA"
-        :subtitle="$t('install.gpuPicker.nvidiaSubtitle')"
-        :value="'nvidia'"
-        :selected="selected === 'nvidia'"
-        :recommended="true"
-        @click="pickGpu('nvidia')"
-      />
+      <template v-else>
+        <HardwareOption
+          image-path="./assets/images/nvidia-logo-square.jpg"
+          placeholder-text="NVIDIA"
+          :subtitle="$t('install.gpuPicker.nvidiaSubtitle')"
+          :selected="selected === 'nvidia'"
+          @click="pickGpu('nvidia')"
+        />
+        <HardwareOption
+          image-path="./assets/images/amd-rocm-logo.png"
+          placeholder-text="AMD"
+          :subtitle="$t('install.gpuPicker.amdSubtitle')"
+          :selected="selected === 'amd'"
+          @click="pickGpu('amd')"
+        />
+      </template>
      <!-- CPU -->
      <HardwareOption
        placeholder-text="CPU"
        :subtitle="$t('install.gpuPicker.cpuSubtitle')"
-        :value="'cpu'"
        :selected="selected === 'cpu'"
        @click="pickGpu('cpu')"
      />
@@ -41,7 +44,6 @@
      <HardwareOption
        placeholder-text="Manual Install"
        :subtitle="$t('install.gpuPicker.manualSubtitle')"
-        :value="'unsupported'"
        :selected="selected === 'unsupported'"
        @click="pickGpu('unsupported')"
      />
@@ -81,13 +83,15 @@ const selected = defineModel<TorchDeviceType | null>('device', {
 const electron = electronAPI()
 const platform = electron.getPlatform()

-const showRecommendedBadge = computed(
-  () => selected.value === 'mps' || selected.value === 'nvidia'
+const recommendedDevices: TorchDeviceType[] = ['mps', 'nvidia', 'amd']
+const showRecommendedBadge = computed(() =>
+  selected.value ? recommendedDevices.includes(selected.value) : false
 )

 const descriptionKeys = {
  mps: 'appleMetal',
  nvidia: 'nvidia',
+  amd: 'amd',
  cpu: 'cpu',
  unsupported: 'manual'
 } as const
@@ -97,7 +101,7 @@ const descriptionText = computed(() => {
  return st(`install.gpuPicker.${key}Description`, '')
 })

-const pickGpu = (value: TorchDeviceType) => {
+function pickGpu(value: TorchDeviceType) {
  selected.value = value
 }
 </script>
--- a/apps/desktop-ui/src/components/install/HardwareOption.stories.ts
+++ b/apps/desktop-ui/src/components/install/HardwareOption.stories.ts
@@ -29,7 +29,6 @@ export const AppleMetalSelected: Story = {
    imagePath: '/assets/images/apple-mps-logo.png',
    placeholderText: 'Apple Metal',
    subtitle: 'Apple Metal',
-    value: 'mps',
    selected: true
  }
 }
@@ -39,7 +38,6 @@ export const AppleMetalUnselected: Story = {
    imagePath: '/assets/images/apple-mps-logo.png',
    placeholderText: 'Apple Metal',
    subtitle: 'Apple Metal',
-    value: 'mps',
    selected: false
  }
 }
@@ -48,7 +46,6 @@ export const CPUOption: Story = {
  args: {
    placeholderText: 'CPU',
    subtitle: 'Subtitle',
-    value: 'cpu',
    selected: false
  }
 }
@@ -57,7 +54,6 @@ export const ManualInstall: Story = {
  args: {
    placeholderText: 'Manual Install',
    subtitle: 'Subtitle',
-    value: 'unsupported',
    selected: false
  }
 }
@@ -67,7 +63,6 @@ export const NvidiaSelected: Story = {
    imagePath: '/assets/images/nvidia-logo-square.jpg',
    placeholderText: 'NVIDIA',
    subtitle: 'NVIDIA',
-    value: 'nvidia',
    selected: true
  }
 }
--- a/apps/desktop-ui/src/components/install/HardwareOption.vue
+++ b/apps/desktop-ui/src/components/install/HardwareOption.vue
@@ -36,17 +36,13 @@
 </template>

 <script setup lang="ts">
-import type { TorchDeviceType } from '@comfyorg/comfyui-electron-types'
-
 import { cn } from '@/utils/tailwindUtil'

 interface Props {
  imagePath?: string
  placeholderText: string
  subtitle?: string
-  value: TorchDeviceType
  selected?: boolean
-  recommended?: boolean
 }

 defineProps<Props>()
--- a/apps/desktop-ui/src/components/install/InstallLocationPicker.vue
+++ b/apps/desktop-ui/src/components/install/InstallLocationPicker.vue
@@ -104,8 +104,8 @@
 </template>

 <script setup lang="ts">
-import type { TorchDeviceType } from '@comfyorg/comfyui-electron-types'
 import { TorchMirrorUrl } from '@comfyorg/comfyui-electron-types'
+import type { TorchDeviceType } from '@comfyorg/comfyui-electron-types'
 import { isInChina } from '@comfyorg/shared-frontend-utils/networkUtil'
 import Accordion from 'primevue/accordion'
 import AccordionContent from 'primevue/accordioncontent'
@@ -155,7 +155,7 @@ const activeAccordionIndex = ref<string[] | undefined>(undefined)
 const electron = electronAPI()

 // Mirror configuration logic
-const getTorchMirrorItem = (device: TorchDeviceType): UVMirror => {
+function getTorchMirrorItem(device: TorchDeviceType): UVMirror {
  const settingId = 'Comfy-Desktop.UV.TorchInstallMirror'
  switch (device) {
    case 'mps':
@@ -170,6 +170,7 @@ const getTorchMirrorItem = (device: TorchDeviceType): UVMirror => {
        mirror: TorchMirrorUrl.Cuda,
        fallbackMirror: TorchMirrorUrl.Cuda
      }
+    case 'amd':
    case 'cpu':
    default:
      return {
--- a/apps/desktop-ui/src/components/maintenance/TaskListPanel.vue
+++ b/apps/desktop-ui/src/components/maintenance/TaskListPanel.vue
@@ -63,7 +63,6 @@ const taskStore = useMaintenanceTaskStore()
 defineProps<{
  displayAsList: string
  filter: MaintenanceFilter
-  isRefreshing: boolean
 }>()

 const executeTask = async (task: MaintenanceTask) => {
--- a/apps/desktop-ui/src/views/InstallView.vue
+++ b/apps/desktop-ui/src/views/InstallView.vue
@@ -143,6 +143,8 @@ const goToPreviousStep = () => {
 const electron = electronAPI()
 const router = useRouter()
 const install = async () => {
+  if (!device.value) return
+
  const options: InstallOptions = {
    installPath: installPath.value,
    autoUpdate: autoUpdate.value,
@@ -152,7 +154,6 @@ const install = async () => {
    pythonMirror: pythonMirror.value,
    pypiMirror: pypiMirror.value,
    torchMirror: torchMirror.value,
-    // @ts-expect-error fixme ts strict error
    device: device.value
  }
  electron.installComfyUI(options)
@@ -166,7 +167,11 @@ onMounted(async () => {
  if (!electron) return

  const detectedGpu = await electron.Config.getDetectedGpu()
-  if (detectedGpu === 'mps' || detectedGpu === 'nvidia') {
+  if (
+    detectedGpu === 'mps' ||
+    detectedGpu === 'nvidia' ||
+    detectedGpu === 'amd'
+  ) {
    device.value = detectedGpu
  }

--- a/apps/desktop-ui/src/views/MaintenanceView.vue
+++ b/apps/desktop-ui/src/views/MaintenanceView.vue
@@ -74,7 +74,6 @@
          class="border-neutral-700 border-solid border-x-0 border-y"
          :filter
          :display-as-list
-          :is-refreshing
        />

        <!-- Actions -->
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -10,8 +10,8 @@ catalogs:
      specifier: ^5.2.0
      version: 5.2.0
    '@comfyorg/comfyui-electron-types':
-      specifier: 0.5.5
-      version: 0.5.5
+      specifier: 0.6.2
+      version: 0.6.2
    '@eslint/js':
      specifier: ^9.39.1
      version: 9.39.1
@@ -215,7 +215,7 @@ catalogs:
      version: 1.1.1
    pinia:
      specifier: ^3.0.4
-      version: 2.2.2
+      version: 3.0.4
    postcss-html:
      specifier: ^1.8.0
      version: 1.8.0
@@ -337,7 +337,7 @@ importers:
        version: 1.3.1
      '@comfyorg/comfyui-electron-types':
        specifier: 'catalog:'
-        version: 0.5.5
+        version: 0.6.2
      '@comfyorg/design-system':
        specifier: workspace:*
        version: link:packages/design-system
@@ -376,7 +376,7 @@ importers:
        version: 4.2.5
      '@sentry/vue':
        specifier: 'catalog:'
-        version: 10.32.1(pinia@2.2.2(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3)))(vue@3.5.13(typescript@5.9.3))
+        version: 10.32.1(pinia@3.0.4(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3)))(vue@3.5.13(typescript@5.9.3))
      '@sparkjsdev/spark':
        specifier: 'catalog:'
        version: 0.1.10
@@ -463,7 +463,7 @@ importers:
        version: 15.0.11
      pinia:
        specifier: 'catalog:'
-        version: 2.2.2(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3))
+        version: 3.0.4(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3))
      primeicons:
        specifier: 'catalog:'
        version: 7.0.0
@@ -530,7 +530,7 @@ importers:
        version: 22.2.6(@babel/traverse@7.28.5)(nx@22.2.6)(typescript@5.9.3)(vite@7.3.0(@types/node@24.10.4)(jiti@2.6.1)(lightningcss@1.30.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.2))(vitest@4.0.16)
      '@pinia/testing':
        specifier: 'catalog:'
-        version: 1.0.3(pinia@2.2.2(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3)))
+        version: 1.0.3(pinia@3.0.4(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3)))
      '@playwright/test':
        specifier: 'catalog:'
        version: 1.57.0
@@ -737,7 +737,7 @@ importers:
    dependencies:
      '@comfyorg/comfyui-electron-types':
        specifier: 'catalog:'
-        version: 0.5.5
+        version: 0.6.2
      '@comfyorg/shared-frontend-utils':
        specifier: workspace:*
        version: link:../../packages/shared-frontend-utils
@@ -752,7 +752,7 @@ importers:
        version: 11.0.0(vue@3.5.13(typescript@5.9.3))
      pinia:
        specifier: 'catalog:'
-        version: 2.2.2(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3))
+        version: 3.0.4(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3))
      primeicons:
        specifier: 'catalog:'
        version: 7.0.0
@@ -1477,8 +1477,8 @@ packages:
  '@cacheable/utils@2.3.2':
    resolution: {integrity: sha512-8kGE2P+HjfY8FglaOiW+y8qxcaQAfAhVML+i66XJR3YX5FtyDqn6Txctr3K2FrbxLKixRRYYBWMbuGciOhYNDg==}

-  '@comfyorg/comfyui-electron-types@0.5.5':
-    resolution: {integrity: sha512-f3XOXpMsALIwHakz7FekVPm4/Fh2pvJPEi8tRe8jYGBt8edsd4Mkkq31Yjs2Weem3BP7yNwbdNuSiQdP/pxJyg==}
+  '@comfyorg/comfyui-electron-types@0.6.2':
+    resolution: {integrity: sha512-r3By5Wbizq8jagUrhtcym79HYUTinsvoBnYkFFWbUmrURBWIaC0HduFVkRkI1PNdI76piW+JSOJJnw00YCVXeg==}

  '@csstools/color-helpers@5.1.0':
    resolution: {integrity: sha512-S11EXWJyy0Mz5SYvRmY8nJYTFFd1LCNV+7cXyAgQtOOuzb4EsgfqDufL+9esx72/eLhsRdGZwaldu/h+E4t4BA==}
@@ -1504,6 +1504,10 @@ packages:
    peerDependencies:
      '@csstools/css-tokenizer': ^3.0.4

+  '@csstools/css-syntax-patches-for-csstree@1.0.20':
+    resolution: {integrity: sha512-8BHsjXfSciZxjmHQOuVdW2b8WLUPts9a+mfL13/PzEviufUEW2xnvQuOlKs9dRBHgRqJ53SF/DUoK9+MZk72oQ==}
+    engines: {node: '>=18'}
+
  '@csstools/css-syntax-patches-for-csstree@1.0.22':
    resolution: {integrity: sha512-qBcx6zYlhleiFfdtzkRgwNC7VVoAwfK76Vmsw5t+PbvtdknO9StgRk7ROvq9so1iqbdW4uLIDAsXRsTfUrIoOw==}
    engines: {node: '>=18'}
@@ -3856,18 +3860,27 @@ packages:
  '@volar/language-core@2.4.15':
    resolution: {integrity: sha512-3VHw+QZU0ZG9IuQmzT68IyN4hZNd9GchGPhbD9+pa8CVv7rnoOZwo7T8weIbrRmihqy3ATpdfXFnqRrfPVK6CA==}

+  '@volar/language-core@2.4.26':
+    resolution: {integrity: sha512-hH0SMitMxnB43OZpyF1IFPS9bgb2I3bpCh76m2WEK7BE0A0EzpYsRp0CCH2xNKshr7kacU5TQBLYn4zj7CG60A==}
+
  '@volar/language-core@2.4.27':
    resolution: {integrity: sha512-DjmjBWZ4tJKxfNC1F6HyYERNHPYS7L7OPFyCrestykNdUZMFYzI9WTyvwPcaNaHlrEUwESHYsfEw3isInncZxQ==}

  '@volar/source-map@2.4.15':
    resolution: {integrity: sha512-CPbMWlUN6hVZJYGcU/GSoHu4EnCHiLaXI9n8c9la6RaI9W5JHX+NqG+GSQcB0JdC2FIBLdZJwGsfKyBB71VlTg==}

+  '@volar/source-map@2.4.26':
+    resolution: {integrity: sha512-JJw0Tt/kSFsIRmgTQF4JSt81AUSI1aEye5Zl65EeZ8H35JHnTvFGmpDOBn5iOxd48fyGE+ZvZBp5FcgAy/1Qhw==}
+
  '@volar/source-map@2.4.27':
    resolution: {integrity: sha512-ynlcBReMgOZj2i6po+qVswtDUeeBRCTgDurjMGShbm8WYZgJ0PA4RmtebBJ0BCYol1qPv3GQF6jK7C9qoVc7lg==}

  '@volar/typescript@2.4.15':
    resolution: {integrity: sha512-2aZ8i0cqPGjXb4BhkMsPYDkkuc2ZQ6yOpqwAuNwUoncELqoy5fRgOQtLR9gB0g902iS0NAkvpIzs27geVyVdPg==}

+  '@volar/typescript@2.4.26':
+    resolution: {integrity: sha512-N87ecLD48Sp6zV9zID/5yuS1+5foj0DfuYGdQ6KHj/IbKvyKv1zNX6VCmnKYwtmHadEO6mFc2EKISiu3RDPAvA==}
+
  '@volar/typescript@2.4.27':
    resolution: {integrity: sha512-eWaYCcl/uAPInSK2Lze6IqVWaBu/itVqR5InXcHXFyles4zO++Mglt3oxdgj75BDcv1Knr9Y93nowS8U3wqhxg==}

@@ -3893,18 +3906,12 @@ packages:
  '@vue/compiler-core@3.5.25':
    resolution: {integrity: sha512-vay5/oQJdsNHmliWoZfHPoVZZRmnSWhug0BYT34njkYTPqClh3DNWLkZNJBVSjsNMrg0CCrBfoKkjZQPM/QVUw==}

-  '@vue/compiler-core@3.5.26':
-    resolution: {integrity: sha512-vXyI5GMfuoBCnv5ucIT7jhHKl55Y477yxP6fc4eUswjP8FG3FFVFd41eNDArR+Uk3QKn2Z85NavjaxLxOC19/w==}
-
  '@vue/compiler-dom@3.5.13':
    resolution: {integrity: sha512-ZOJ46sMOKUjO3e94wPdCzQ6P1Lx/vhp2RSvfaab88Ajexs0AHeV0uasYhi99WPaogmBlRHNRuly8xV75cNTMDA==}

  '@vue/compiler-dom@3.5.25':
    resolution: {integrity: sha512-4We0OAcMZsKgYoGlMjzYvaoErltdFI2/25wqanuTu+S4gismOTRTBPi4IASOjxWdzIwrYSjnqONfKvuqkXzE2Q==}

-  '@vue/compiler-dom@3.5.26':
-    resolution: {integrity: sha512-y1Tcd3eXs834QjswshSilCBnKGeQjQXB6PqFn/1nxcQw4pmG42G8lwz+FZPAZAby6gZeHSt/8LMPfZ4Rb+Bd/A==}
-
  '@vue/compiler-sfc@3.5.13':
    resolution: {integrity: sha512-6VdaljMpD82w6c2749Zhf5T9u5uLBWKnVue6XWxprDobftnletJ8+oel7sexFfM3qIxNmVE7LSFGTpv6obNyaQ==}

@@ -3923,17 +3930,23 @@ packages:
  '@vue/devtools-api@6.6.3':
    resolution: {integrity: sha512-0MiMsFma/HqA6g3KLKn+AGpL1kgKhFWszC9U29NfpWK5LE7bjeXxySWJrOJ77hBz+TBrBQ7o4QJqbPbqbs8rJw==}

-  '@vue/devtools-api@6.6.4':
-    resolution: {integrity: sha512-sGhTPMuXqZ1rVOk32RylztWkfXTRhuS7vgAKv0zjqk8gbsHkJ7xfFf+jbySxt7tWObEJwyKaHMikV/WGDiQm8g==}
+  '@vue/devtools-api@7.7.9':
+    resolution: {integrity: sha512-kIE8wvwlcZ6TJTbNeU2HQNtaxLx3a84aotTITUuL/4bzfPxzajGBOoqjMhwZJ8L9qFYDU/lAYMEEm11dnZOD6g==}

  '@vue/devtools-core@8.0.5':
    resolution: {integrity: sha512-dpCw8nl0GDBuiL9SaY0mtDxoGIEmU38w+TQiYEPOLhW03VDC0lfNMYXS/qhl4I0YlysGp04NLY4UNn6xgD0VIQ==}
    peerDependencies:
      vue: ^3.0.0

+  '@vue/devtools-kit@7.7.9':
+    resolution: {integrity: sha512-PyQ6odHSgiDVd4hnTP+aDk2X4gl2HmLDfiyEnn3/oV+ckFDuswRs4IbBT7vacMuGdwY/XemxBoh302ctbsptuA==}
+
  '@vue/devtools-kit@8.0.5':
    resolution: {integrity: sha512-q2VV6x1U3KJMTQPUlRMyWEKVbcHuxhqJdSr6Jtjz5uAThAIrfJ6WVZdGZm5cuO63ZnSUz0RCsVwiUUb0mDV0Yg==}

+  '@vue/devtools-shared@7.7.9':
+    resolution: {integrity: sha512-iWAb0v2WYf0QWmxCGy0seZNDPdO3Sp5+u78ORnyeonS6MT4PC7VPrryX2BpMJrwlDeaZ6BD4vP4XKjK0SZqaeA==}
+
  '@vue/devtools-shared@8.0.5':
    resolution: {integrity: sha512-bRLn6/spxpmgLk+iwOrR29KrYnJjG9DGpHGkDFG82UM21ZpJ39ztUT9OXX3g+usW7/b2z+h46I9ZiYyB07XMXg==}

@@ -3976,9 +3989,6 @@ packages:
  '@vue/shared@3.5.25':
    resolution: {integrity: sha512-AbOPdQQnAnzs58H2FrrDxYj/TJfmeS2jdfEEhgiKINy+bnOANmVizIEgq1r+C5zsbs6l1CCQxtcj71rwNQ4jWg==}

-  '@vue/shared@3.5.26':
-    resolution: {integrity: sha512-7Z6/y3uFI5PRoKeorTOSXKcDj0MSasfNNltcslbFrPpcw6aXRUALq4IfJlaTRspiWIUOEZbrpM+iQGmCOiWe4A==}
-
  '@vue/test-utils@2.4.6':
    resolution: {integrity: sha512-FMxEjOpYNYiFe0GkaHsnJPXFHxQ6m4t8vI/ElPGpMWxZKpmRvQ33OIrvRXemy6yha03RxhOlQuy+gZMC3CQSow==}

@@ -4165,8 +4175,8 @@ packages:
  alien-signals@1.0.13:
    resolution: {integrity: sha512-OGj9yyTnJEttvzhTUWuscOvtqxq5vrhF7vL9oS0xJ2mK0ItPYP1/y+vCFebfxoEyAz0++1AIwJ5CMr+Fk3nDmg==}

-  alien-signals@3.1.2:
-    resolution: {integrity: sha512-d9dYqZTS90WLiU0I5c6DHj/HcKkF8ZyGN3G5x8wSbslulz70KOxaqCT0hQCo9KOyhVqzqGojvNdJXoTumZOtcw==}
+  alien-signals@3.1.1:
+    resolution: {integrity: sha512-ogkIWbVrLwKtHY6oOAXaYkAxP+cTH7V5FZ5+Tm4NZFd8VDZ6uNMDrfzqctTZ42eTMCSR3ne3otpcxmqSnFfPYA==}

  ansi-align@3.0.1:
    resolution: {integrity: sha512-IOfwwBF5iczOjp/WeY4YxyjqAFMQoZufdQWDd19SEExbVLNXqvpzSJ/M7Za4/sCPmQ0+GRquoA7bGcINcxew6w==}
@@ -4939,10 +4949,6 @@ packages:
    resolution: {integrity: sha512-aN97NXWF6AWBTahfVOIrB/NShkzi5H7F9r1s9mD3cDj4Ko5f2qhhVoYMibXF7GlLveb/D2ioWay8lxI97Ven3g==}
    engines: {node: '>=0.12'}

-  entities@7.0.0:
-    resolution: {integrity: sha512-FDWG5cmEYf2Z00IkYRhbFrwIwvdFKH07uV8dvNy0omp/Qb1xcyCWp2UDtcwJF4QZZvk0sLudP6/hAu42TaqVhQ==}
-    engines: {node: '>=0.12'}
-
  env-paths@2.2.1:
    resolution: {integrity: sha512-+h1lkLKhZMTYjog1VEpJNG7NZJWcuc2DDk/qsqSTRRCOXiLjeQ1d1/udrUGhqMxUgAlwKNZ0cf2uqan5GLuS2A==}
    engines: {node: '>=6'}
@@ -5209,8 +5215,8 @@ packages:
  eventemitter3@5.0.1:
    resolution: {integrity: sha512-GWkBvjiSZK87ELrYOSESUYeVIc9mvLLf/nXalMOS5dYrgZq9o5OVkbZAVM06CVxYsCwH9BDZFPlQTlPA1j4ahA==}

-  expect-type@1.3.0:
-    resolution: {integrity: sha512-knvyeauYhqjOYvQ66MznSMs83wmHrCycNEN6Ao+2AeYEfxUIkuiVxdEa1qlGEPK+We3n0THiDciYSsCcgW/DoA==}
+  expect-type@1.2.2:
+    resolution: {integrity: sha512-JhFGDVJ7tmDJItKhYgJCGLOWjuK9vPxiXoUFLwLDc99NlmklilbiQJwoctZtt13+xMw91MCk/REan6MWHqDjyA==}
    engines: {node: '>=12.0.0'}

  exsolve@1.0.8:
@@ -6214,6 +6220,10 @@ packages:
  lru-cache@10.4.3:
    resolution: {integrity: sha512-JNAzZcXrCt42VGLuYz0zfAzDfAvJWW6AfYlDBQyDV5DClI2m5sAmK+OIO7s59XfsRsWHp02jAJrRadPRGTt6SQ==}

+  lru-cache@11.1.0:
+    resolution: {integrity: sha512-QIXZUBJUx+2zHUdQujWejBkcD9+cs94tLn0+YL8UrCh+D5sCXZ4c7LaEH48pNwRY3MLDgqUFyhlCyjJPf1WP0A==}
+    engines: {node: 20 || >=22}
+
  lru-cache@11.2.4:
    resolution: {integrity: sha512-B5Y16Jr9LB9dHVkh6ZevG+vAbOsNOYCX+sXvFWFu7B3Iz5mijW3zdbMyhsh8ANd2mSWBYdJgnqi+mL7/LrOPYg==}
    engines: {node: 20 || >=22}
@@ -6797,6 +6807,9 @@ packages:
    resolution: {integrity: sha512-//nshmD55c46FuFw26xV/xFAaB5HF9Xdap7HJBBnrKdAd6/GxDBaNA1870O79+9ueg61cZLSVc+OaFlfmObYVQ==}
    engines: {node: '>= 14.16'}

+  perfect-debounce@1.0.0:
+    resolution: {integrity: sha512-xCy9V055GLEqoFaHoC1SoLIaLmWctgCUaBaWxDZ7/Zx4CTyX7cJQLJOok/orfjZAh9kEYpjJa4d0KcJmCbctZA==}
+
  perfect-debounce@2.0.0:
    resolution: {integrity: sha512-fkEH/OBiKrqqI/yIgjR92lMfs2K8105zt/VT6+7eTjNwisrsh47CeIED9z58zI7DfKdH3uHAn25ziRZn3kgAow==}

@@ -6820,15 +6833,12 @@ packages:
    engines: {node: '>=0.10'}
    hasBin: true

-  pinia@2.2.2:
-    resolution: {integrity: sha512-ja2XqFWZC36mupU4z1ZzxeTApV7DOw44cV4dhQ9sGwun+N89v/XP7+j7q6TanS1u1tdbK4r+1BUx7heMaIdagA==}
+  pinia@3.0.4:
+    resolution: {integrity: sha512-l7pqLUFTI/+ESXn6k3nu30ZIzW5E2WZF/LaHJEpoq6ElcLD+wduZoB2kBN19du6K/4FDpPMazY2wJr+IndBtQw==}
    peerDependencies:
-      '@vue/composition-api': ^1.4.0
-      typescript: '>=4.4.4'
-      vue: ^2.6.14 || ^3.3.0
+      typescript: '>=4.5.0'
+      vue: ^3.5.11
    peerDependenciesMeta:
-      '@vue/composition-api':
-        optional: true
      typescript:
        optional: true

@@ -9179,7 +9189,7 @@ snapshots:
      hashery: 1.3.0
      keyv: 5.5.5

-  '@comfyorg/comfyui-electron-types@0.5.5': {}
+  '@comfyorg/comfyui-electron-types@0.6.2': {}

  '@csstools/color-helpers@5.1.0': {}

@@ -9199,6 +9209,8 @@ snapshots:
    dependencies:
      '@csstools/css-tokenizer': 3.0.4

+  '@csstools/css-syntax-patches-for-csstree@1.0.20': {}
+
  '@csstools/css-syntax-patches-for-csstree@1.0.22': {}

  '@csstools/css-tokenizer@3.0.4': {}
@@ -10592,9 +10604,9 @@ snapshots:
      esquery: 1.6.0
      typescript: 5.9.3

-  '@pinia/testing@1.0.3(pinia@2.2.2(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3)))':
+  '@pinia/testing@1.0.3(pinia@3.0.4(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3)))':
    dependencies:
-      pinia: 2.2.2(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3))
+      pinia: 3.0.4(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3))

  '@pkgjs/parseargs@0.11.0':
    optional: true
@@ -10897,13 +10909,13 @@ snapshots:
      - encoding
      - supports-color

-  '@sentry/vue@10.32.1(pinia@2.2.2(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3)))(vue@3.5.13(typescript@5.9.3))':
+  '@sentry/vue@10.32.1(pinia@3.0.4(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3)))(vue@3.5.13(typescript@5.9.3))':
    dependencies:
      '@sentry/browser': 10.32.1
      '@sentry/core': 10.32.1
      vue: 3.5.13(typescript@5.9.3)
    optionalDependencies:
-      pinia: 2.2.2(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3))
+      pinia: 3.0.4(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3))

  '@sinclair/typebox@0.34.40': {}

@@ -11717,12 +11729,18 @@ snapshots:
    dependencies:
      '@volar/source-map': 2.4.15

+  '@volar/language-core@2.4.26':
+    dependencies:
+      '@volar/source-map': 2.4.26
+
  '@volar/language-core@2.4.27':
    dependencies:
      '@volar/source-map': 2.4.27

  '@volar/source-map@2.4.15': {}

+  '@volar/source-map@2.4.26': {}
+
  '@volar/source-map@2.4.27': {}

  '@volar/typescript@2.4.15':
@@ -11731,6 +11749,12 @@ snapshots:
      path-browserify: 1.0.1
      vscode-uri: 3.1.0

+  '@volar/typescript@2.4.26':
+    dependencies:
+      '@volar/language-core': 2.4.26
+      path-browserify: 1.0.1
+      vscode-uri: 3.1.0
+
  '@volar/typescript@2.4.27':
    dependencies:
      '@volar/language-core': 2.4.27
@@ -11749,7 +11773,7 @@ snapshots:
      '@babel/types': 7.28.5
      '@vue/babel-helper-vue-transform-on': 1.4.0
      '@vue/babel-plugin-resolve-type': 1.4.0(@babel/core@7.28.5)
-      '@vue/shared': 3.5.26
+      '@vue/shared': 3.5.25
    optionalDependencies:
      '@babel/core': 7.28.5
    transitivePeerDependencies:
@@ -11782,14 +11806,6 @@ snapshots:
      estree-walker: 2.0.2
      source-map-js: 1.2.1

-  '@vue/compiler-core@3.5.26':
-    dependencies:
-      '@babel/parser': 7.28.5
-      '@vue/shared': 3.5.26
-      entities: 7.0.0
-      estree-walker: 2.0.2
-      source-map-js: 1.2.1
-
  '@vue/compiler-dom@3.5.13':
    dependencies:
      '@vue/compiler-core': 3.5.13
@@ -11800,11 +11816,6 @@ snapshots:
      '@vue/compiler-core': 3.5.25
      '@vue/shared': 3.5.25

-  '@vue/compiler-dom@3.5.26':
-    dependencies:
-      '@vue/compiler-core': 3.5.26
-      '@vue/shared': 3.5.26
-
  '@vue/compiler-sfc@3.5.13':
    dependencies:
      '@babel/parser': 7.28.5
@@ -11846,7 +11857,9 @@ snapshots:

  '@vue/devtools-api@6.6.3': {}

-  '@vue/devtools-api@6.6.4': {}
+  '@vue/devtools-api@7.7.9':
+    dependencies:
+      '@vue/devtools-kit': 7.7.9

  '@vue/devtools-core@8.0.5(vite@7.3.0(@types/node@24.10.4)(jiti@2.6.1)(lightningcss@1.30.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.2))(vue@3.5.13(typescript@5.9.3))':
    dependencies:
@@ -11872,6 +11885,16 @@ snapshots:
    transitivePeerDependencies:
      - vite

+  '@vue/devtools-kit@7.7.9':
+    dependencies:
+      '@vue/devtools-shared': 7.7.9
+      birpc: 2.9.0
+      hookable: 5.5.3
+      mitt: 3.0.1
+      perfect-debounce: 1.0.0
+      speakingurl: 14.0.1
+      superjson: 2.2.2
+
  '@vue/devtools-kit@8.0.5':
    dependencies:
      '@vue/devtools-shared': 8.0.5
@@ -11882,16 +11905,20 @@ snapshots:
      speakingurl: 14.0.1
      superjson: 2.2.2

+  '@vue/devtools-shared@7.7.9':
+    dependencies:
+      rfdc: 1.4.1
+
  '@vue/devtools-shared@8.0.5':
    dependencies:
      rfdc: 1.4.1

  '@vue/language-core@2.2.0(typescript@5.9.3)':
    dependencies:
-      '@volar/language-core': 2.4.27
-      '@vue/compiler-dom': 3.5.26
+      '@volar/language-core': 2.4.26
+      '@vue/compiler-dom': 3.5.25
      '@vue/compiler-vue2': 2.7.16
-      '@vue/shared': 3.5.26
+      '@vue/shared': 3.5.25
      alien-signals: 0.4.14
      minimatch: 9.0.5
      muggle-string: 0.4.1
@@ -11902,9 +11929,9 @@ snapshots:
  '@vue/language-core@2.2.12(typescript@5.9.3)':
    dependencies:
      '@volar/language-core': 2.4.15
-      '@vue/compiler-dom': 3.5.26
+      '@vue/compiler-dom': 3.5.25
      '@vue/compiler-vue2': 2.7.16
-      '@vue/shared': 3.5.26
+      '@vue/shared': 3.5.25
      alien-signals: 1.0.13
      minimatch: 9.0.5
      muggle-string: 0.4.1
@@ -11915,9 +11942,9 @@ snapshots:
  '@vue/language-core@3.2.1':
    dependencies:
      '@volar/language-core': 2.4.27
-      '@vue/compiler-dom': 3.5.26
-      '@vue/shared': 3.5.26
-      alien-signals: 3.1.2
+      '@vue/compiler-dom': 3.5.25
+      '@vue/shared': 3.5.25
+      alien-signals: 3.1.1
      muggle-string: 0.4.1
      path-browserify: 1.0.1
      picomatch: 4.0.3
@@ -11948,8 +11975,6 @@ snapshots:

  '@vue/shared@3.5.25': {}

-  '@vue/shared@3.5.26': {}
-
  '@vue/test-utils@2.4.6':
    dependencies:
      js-beautify: 1.15.1
@@ -12128,7 +12153,7 @@ snapshots:

  alien-signals@1.0.13: {}

-  alien-signals@3.1.2: {}
+  alien-signals@3.1.1: {}

  ansi-align@3.0.1:
    dependencies:
@@ -12929,8 +12954,6 @@ snapshots:

  entities@6.0.1: {}

-  entities@7.0.0: {}
-
  env-paths@2.2.1: {}

  env-paths@3.0.0: {}
@@ -13322,7 +13345,7 @@ snapshots:

  eventemitter3@5.0.1: {}

-  expect-type@1.3.0: {}
+  expect-type@1.2.2: {}

  exsolve@1.0.8: {}

@@ -14407,6 +14430,8 @@ snapshots:

  lru-cache@10.4.3: {}

+  lru-cache@11.1.0: {}
+
  lru-cache@11.2.4: {}

  lru-cache@5.1.1:
@@ -15280,7 +15305,7 @@ snapshots:

  path-scurry@2.0.0:
    dependencies:
-      lru-cache: 11.2.4
+      lru-cache: 11.1.0
      minipass: 7.1.2

  path-type@4.0.0: {}
@@ -15293,6 +15318,8 @@ snapshots:

  pathval@2.0.1: {}

+  perfect-debounce@1.0.0: {}
+
  perfect-debounce@2.0.0: {}

  picocolors@1.1.1: {}
@@ -15305,11 +15332,10 @@ snapshots:

  pidtree@0.6.0: {}

-  pinia@2.2.2(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3)):
+  pinia@3.0.4(typescript@5.9.3)(vue@3.5.13(typescript@5.9.3)):
    dependencies:
-      '@vue/devtools-api': 6.6.4
+      '@vue/devtools-api': 7.7.9
      vue: 3.5.13(typescript@5.9.3)
-      vue-demi: 0.14.10(vue@3.5.13(typescript@5.9.3))
    optionalDependencies:
      typescript: 5.9.3

@@ -16165,7 +16191,7 @@ snapshots:
  stylelint@16.26.1(typescript@5.9.3):
    dependencies:
      '@csstools/css-parser-algorithms': 3.0.5(@csstools/css-tokenizer@3.0.4)
-      '@csstools/css-syntax-patches-for-csstree': 1.0.22
+      '@csstools/css-syntax-patches-for-csstree': 1.0.20
      '@csstools/css-tokenizer': 3.0.4
      '@csstools/media-query-list-parser': 4.0.3(@csstools/css-parser-algorithms@3.0.5(@csstools/css-tokenizer@3.0.4))(@csstools/css-tokenizer@3.0.4)
      '@csstools/selector-specificity': 5.0.0(postcss-selector-parser@7.1.1)
@@ -16669,7 +16695,7 @@ snapshots:
    dependencies:
      '@microsoft/api-extractor': 7.52.13(@types/node@24.10.4)
      '@rollup/pluginutils': 5.3.0(rollup@4.53.5)
-      '@volar/typescript': 2.4.27
+      '@volar/typescript': 2.4.26
      '@vue/language-core': 2.2.0(typescript@5.9.3)
      compare-versions: 6.1.1
      debug: 4.4.3
@@ -16782,7 +16808,7 @@ snapshots:
      '@babel/plugin-syntax-import-meta': 7.10.4(@babel/core@7.28.5)
      '@babel/plugin-transform-typescript': 7.28.5(@babel/core@7.28.5)
      '@vue/babel-plugin-jsx': 1.4.0(@babel/core@7.28.5)
-      '@vue/compiler-dom': 3.5.26
+      '@vue/compiler-dom': 3.5.25
      kolorist: 1.8.0
      magic-string: 0.30.21
      vite: 7.3.0(@types/node@24.10.4)(jiti@2.6.1)(lightningcss@1.30.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.2)
@@ -16797,7 +16823,7 @@ snapshots:
      '@babel/plugin-syntax-import-meta': 7.10.4(@babel/core@7.28.5)
      '@babel/plugin-transform-typescript': 7.28.5(@babel/core@7.28.5)
      '@vue/babel-plugin-jsx': 1.4.0(@babel/core@7.28.5)
-      '@vue/compiler-dom': 3.5.26
+      '@vue/compiler-dom': 3.5.25
      kolorist: 1.8.0
      magic-string: 0.30.21
      vite: 7.3.0(@types/node@25.0.3)(jiti@2.6.1)(lightningcss@1.30.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.2)
@@ -16848,7 +16874,7 @@ snapshots:
      '@vitest/spy': 4.0.16
      '@vitest/utils': 4.0.16
      es-module-lexer: 1.7.0
-      expect-type: 1.3.0
+      expect-type: 1.2.2
      magic-string: 0.30.21
      obug: 2.1.1
      pathe: 2.0.3
@@ -16903,7 +16929,7 @@ snapshots:
    dependencies:
      '@babel/parser': 7.28.5
      '@babel/types': 7.28.5
-      '@vue/compiler-dom': 3.5.26
+      '@vue/compiler-dom': 3.5.25
      '@vue/compiler-sfc': 3.5.25
      ast-types: 0.16.1
      esm-resolve: 1.0.11
--- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -4,7 +4,7 @@ packages:

 catalog:
  '@alloc/quick-lru': ^5.2.0
-  '@comfyorg/comfyui-electron-types': 0.5.5
+  '@comfyorg/comfyui-electron-types': 0.6.2
  '@eslint/js': ^9.39.1
  '@iconify-json/lucide': ^1.1.178
  '@iconify/json': ^2.2.380
--- a/src/locales/en/main.json
+++ b/src/locales/en/main.json
@@ -508,10 +508,12 @@
      "title": "Choose your hardware setup",
      "recommended": "RECOMMENDED",
      "nvidiaSubtitle": "NVIDIA CUDA",
+      "amdSubtitle": "AMD ROCm™",
      "cpuSubtitle": "CPU Mode",
      "manualSubtitle": "Manual Setup",
      "appleMetalDescription": "Leverages your Mac's GPU for faster speed and a better overall experience",
      "nvidiaDescription": "Use your NVIDIA GPU with CUDA acceleration for the best performance.",
+      "amdDescription": "Use your AMD GPU with ROCm acceleration for the best performance.",
      "cpuDescription": "Use CPU mode for compatibility when GPU acceleration is not available",
      "manualDescription": "Configure ComfyUI manually for advanced setups or unsupported hardware"
    },
@@ -2449,4 +2451,4 @@
    "recentReleases": "Recent releases",
    "helpCenterMenu": "Help Center Menu"
  }
-}
+}
--- a/tests-ui/tests/renderer/extensions/vueNodes/components/LGraphNode.test.ts
+++ b/tests-ui/tests/renderer/extensions/vueNodes/components/LGraphNode.test.ts
@@ -1,7 +1,7 @@
 import { createTestingPinia } from '@pinia/testing'
 import { mount } from '@vue/test-utils'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
-import { computed, toValue } from 'vue'
+import { computed, reactive, ref, toValue } from 'vue'
 import type { ComponentProps } from 'vue-component-type-helpers'
 import { createI18n } from 'vue-i18n'

@@ -10,7 +10,7 @@ import LGraphNode from '@/renderer/extensions/vueNodes/components/LGraphNode.vue
 import { useVueElementTracking } from '@/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking'

 const mockData = vi.hoisted(() => ({
-  mockNodeIds: new Set<string>(),
+  selectedNodeIds: ref(new Set<string>()),
  mockExecuting: false
 }))

@@ -27,10 +27,11 @@ vi.mock('@/renderer/core/layout/transform/useTransformState', () => {

 vi.mock('@/renderer/core/canvas/canvasStore', () => {
  const getCanvas = vi.fn()
-  const useCanvasStore = () => ({
-    getCanvas,
-    selectedNodeIds: computed(() => mockData.mockNodeIds)
-  })
+  const useCanvasStore = () =>
+    reactive({
+      getCanvas,
+      selectedNodeIds: mockData.selectedNodeIds
+    })
  return {
    useCanvasStore
  }
@@ -142,7 +143,7 @@ const mockNodeData: VueNodeData = {
 describe('LGraphNode', () => {
  beforeEach(() => {
    vi.resetAllMocks()
-    mockData.mockNodeIds = new Set()
+    mockData.selectedNodeIds.value = new Set()
    mockData.mockExecuting = false
  })

@@ -188,7 +189,7 @@ describe('LGraphNode', () => {
  })

  it('should apply selected styling when selected prop is true', () => {
-    mockData.mockNodeIds = new Set(['test-node-123'])
+    mockData.selectedNodeIds.value = new Set(['test-node-123'])
    const wrapper = mountLGraphNode({ nodeData: mockNodeData })
    expect(wrapper.classes()).toContain('outline-2')
    expect(wrapper.classes()).toContain('outline-node-component-outline')
Author	SHA1	Message	Date
Benjamin Lu	ee2e1a909e	fix(tests): align LGraphNode mock with Pinia 3	2025-12-30 16:21:51 -08:00
Benjamin Lu	4fced8a3f8	pnpm install	2025-12-30 15:36:23 -08:00
Benjamin Lu	a1f798c6c2	Merge remote-tracking branch 'origin/main' into bl/amd-gpu-picker	2025-12-30 15:33:28 -08:00
Benjamin Lu	6e3723d814	minor text change	2025-12-30 15:12:59 -08:00
Benjamin Lu	ebf11faeea	Switch to new desktop types packages	2025-12-30 15:09:26 -08:00
Benjamin Lu	b1d94b6619	Group NVIDIA and AMD after darwin	2025-12-30 12:31:11 -08:00
Benjamin Lu	62c7ad8482	Add AMD logo and text	2025-12-30 12:26:34 -08:00
Benjamin Lu	4df0ad3dc7	Add AMD as an install option + lint fixes	2025-12-29 20:22:32 -08:00