fix: Add component-level test for DomWidget disabled state logic (#9290)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

src/components/graph/widgets/DomWidget.test.ts

@@ -113,4 +113,62 @@ describe('DomWidget disabled style', () => {
     expect(root.style.pointerEvents).toBe('none')
     expect(root.style.opacity).toBe('0.5')
   })
+
+  it('uses enabled style when promoted override widget is not computedDisabled', async () => {
+    const widgetState = createWidgetState(false)
+    const wrapper = mount(DomWidget, {
+      props: {
+        widgetState
+      }
+    })
+
+    widgetState.zIndex = 3
+    await wrapper.vm.$nextTick()
+
+    const root = wrapper.get('.dom-widget').element as HTMLElement
+    expect(root.style.pointerEvents).toBe('auto')
+    expect(root.style.opacity).toBe('1')
+  })
+
+  it('falls back to widget.computedDisabled when no position override exists', async () => {
+    const domWidgetStore = useDomWidgetStore()
+    const node = createMockLGraphNode({
+      id: 3,
+      constructor: {
+        nodeData: {}
+      }
+    })
+
+    const widget = {
+      id: 'dom-widget-no-override',
+      name: 'test_widget',
+      type: 'custom',
+      value: '',
+      options: {},
+      node,
+      computedDisabled: true
+    } as unknown as BaseDOMWidget<object | string>
+
+    domWidgetStore.registerWidget(widget)
+
+    const state = domWidgetStore.widgetStates.get(widget.id)
+    if (!state) throw new Error('Expected registered DomWidgetState')
+
+    state.zIndex = 2
+    state.size = [100, 40]
+
+    const widgetState = reactive(state)
+    const wrapper = mount(DomWidget, {
+      props: {
+        widgetState
+      }
+    })
+
+    widgetState.zIndex = 3
+    await wrapper.vm.$nextTick()
+
+    const root = wrapper.get('.dom-widget').element as HTMLElement
+    expect(root.style.pointerEvents).toBe('none')
+    expect(root.style.opacity).toBe('0.5')
+  })
 })

src/locales/en/main.json

@@ -178,7 +178,7 @@
     "uploadAlreadyInProgress": "Upload already in progress",
     "capture": "capture",
     "nodes": "Nodes",
-    "nodesCount": "{count} nodes | {count} node | {count} nodes",
+    "nodesCount": "{count} node | {count} nodes",
     "addNode": "Add a node...",
     "filterBy": "Filter by:",
     "filterByType": "Filter by {type}...",
@@ -222,7 +222,7 @@
     "failed": "Failed",
     "cancelled": "Cancelled",
     "job": "Job",
-    "asset": "{count} assets | {count} asset | {count} assets",
+    "asset": "{count} asset | {count} assets",
     "untitled": "Untitled",
     "emDash": "—",
     "enabling": "Enabling {id}",
@@ -3347,7 +3347,7 @@
     }
   },
   "errorOverlay": {
-    "errorCount": "{count} ERRORS | {count} ERROR | {count} ERRORS",
+    "errorCount": "{count} ERROR | {count} ERRORS",
     "seeErrors": "See Errors"
   },
   "help": {
@@ -3357,7 +3357,7 @@
   "progressToast": {
     "importingModels": "Importing Models",
     "downloadingModel": "Downloading model...",
-    "downloadsFailed": "{count} downloads failed | {count} download failed | {count} downloads failed",
+    "downloadsFailed": "{count} download failed | {count} downloads failed",
     "allDownloadsCompleted": "All downloads completed",
     "noImportsInQueue": "No {filter} in queue",
     "failed": "Failed",
@@ -3374,7 +3374,7 @@
     "exportingAssets": "Exporting Assets",
     "preparingExport": "Preparing export...",
     "exportError": "Export failed",
-    "exportFailed": "{count} export failed | {count} export failed | {count} exports failed",
+    "exportFailed": "{count} export failed | {count} exports failed",
     "allExportsCompleted": "All exports completed",
     "noExportsInQueue": "No {filter} exports in queue",
     "exportStarted": "Preparing ZIP download...",

src/platform/workflow/sharing/components/publish/ComfyHubPublishDialog.test.ts

@@ -1,79 +1,59 @@
 import { flushPromises, mount } from '@vue/test-utils'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { ref } from 'vue'
 
 import ComfyHubPublishDialog from '@/platform/workflow/sharing/components/publish/ComfyHubPublishDialog.vue'
-import type { ComfyHubProfile } from '@/schemas/apiSchema'
 
-const mockFetchApi = vi.hoisted(() => vi.fn())
-const mockToastErrorHandler = vi.hoisted(() => vi.fn())
-const mockResolvedUserInfo = vi.hoisted(() => ({
-  value: { id: 'user-a' }
-}))
+const mockFetchProfile = vi.hoisted(() => vi.fn())
+const mockGoToStep = vi.hoisted(() => vi.fn())
+const mockGoNext = vi.hoisted(() => vi.fn())
+const mockGoBack = vi.hoisted(() => vi.fn())
+const mockOpenProfileCreationStep = vi.hoisted(() => vi.fn())
+const mockCloseProfileCreationStep = vi.hoisted(() => vi.fn())
 
-vi.mock('@/scripts/api', () => ({
-  api: {
-    fetchApi: mockFetchApi
-  }
-}))
-
-vi.mock('@/composables/auth/useCurrentUser', () => ({
-  useCurrentUser: () => ({
-    resolvedUserInfo: mockResolvedUserInfo
+vi.mock(
+  '@/platform/workflow/sharing/composables/useComfyHubProfileGate',
+  () => ({
+    useComfyHubProfileGate: () => ({
+      fetchProfile: mockFetchProfile
+    })
   })
-}))
+)
 
-vi.mock('@/composables/useErrorHandling', () => ({
-  useErrorHandling: () => ({
-    toastErrorHandler: mockToastErrorHandler
+vi.mock(
+  '@/platform/workflow/sharing/composables/useComfyHubPublishWizard',
+  () => ({
+    useComfyHubPublishWizard: () => ({
+      currentStep: ref('finish'),
+      formData: ref({
+        name: '',
+        description: '',
+        workflowType: '',
+        tags: [],
+        thumbnailType: 'image',
+        thumbnailFile: null,
+        comparisonBeforeFile: null,
+        comparisonAfterFile: null,
+        exampleImages: [],
+        selectedExampleIds: []
+      }),
+      isFirstStep: ref(false),
+      isLastStep: ref(true),
+      goToStep: mockGoToStep,
+      goNext: mockGoNext,
+      goBack: mockGoBack,
+      openProfileCreationStep: mockOpenProfileCreationStep,
+      closeProfileCreationStep: mockCloseProfileCreationStep
+    })
   })
-}))
-
-vi.mock('@/platform/workflow/management/stores/workflowStore', () => ({
-  useWorkflowStore: () => ({
-    activeWorkflow: { filename: 'test-workflow' }
-  })
-}))
-
-const mockProfile: ComfyHubProfile = {
-  username: 'testuser',
-  name: 'Test User',
-  description: 'A test profile'
-}
-
-function mockSuccessResponse(data?: unknown) {
-  return {
-    ok: true,
-    json: async () => data ?? mockProfile
-  } as Response
-}
-
-function mockErrorResponse(status = 404) {
-  return {
-    ok: false,
-    status,
-    json: async () => ({ message: 'Not found' })
-  } as Response
-}
-
-// Reset module-level singleton state in useComfyHubProfileGate between tests
-async function resetProfileGateSingleton() {
-  const { useComfyHubProfileGate } =
-    await import('@/platform/workflow/sharing/composables/useComfyHubProfileGate')
-  const gate = useComfyHubProfileGate()
-  gate.hasProfile.value = null
-  gate.profile.value = null
-  gate.isCheckingProfile.value = false
-  gate.isFetchingProfile.value = false
-}
+)
 
 describe('ComfyHubPublishDialog', () => {
   const onClose = vi.fn()
 
-  beforeEach(async () => {
+  beforeEach(() => {
     vi.clearAllMocks()
-    mockResolvedUserInfo.value = { id: 'user-a' }
-    mockFetchApi.mockResolvedValue(mockErrorResponse())
-    await resetProfileGateSingleton()
+    mockFetchProfile.mockResolvedValue(null)
   })
 
   function createWrapper() {
@@ -98,7 +78,7 @@ describe('ComfyHubPublishDialog', () => {
           },
           ComfyHubPublishWizardContent: {
             template:
-              '<div><button data-testid="require-profile" @click="$props.onRequireProfile()" /><button data-testid="gate-complete" @click="$props.onGateComplete()" /><button data-testid="gate-close" @click="$props.onGateClose()" /><span data-testid="current-step">{{ $props.currentStep }}</span></div>',
+              '<div><button data-testid="require-profile" @click="$props.onRequireProfile()" /><button data-testid="gate-complete" @click="$props.onGateComplete()" /><button data-testid="gate-close" @click="$props.onGateClose()" /></div>',
             props: [
               'currentStep',
               'formData',
@@ -108,9 +88,7 @@ describe('ComfyHubPublishDialog', () => {
               'onGoBack',
               'onRequireProfile',
               'onGateComplete',
-              'onGateClose',
-              'onUpdateFormData',
-              'onPublish'
+              'onGateClose'
             ]
           }
         }
@@ -118,62 +96,44 @@ describe('ComfyHubPublishDialog', () => {
     })
   }
 
-  it('prefetches profile on mount via real composable', async () => {
+  it('starts in publish wizard mode and prefetches profile asynchronously', async () => {
     createWrapper()
     await flushPromises()
 
-    expect(mockFetchApi).toHaveBeenCalledWith('/hub/profile')
+    expect(mockFetchProfile).toHaveBeenCalledWith()
   })
 
-  it('starts on the describe step with real wizard composable', async () => {
-    const wrapper = createWrapper()
-    await flushPromises()
-
-    expect(wrapper.find('[data-testid="current-step"]').text()).toBe('describe')
-  })
-
-  it('switches to profileCreation step when require-profile is triggered', async () => {
+  it('switches to profile creation step when final-step publish requires profile', async () => {
     const wrapper = createWrapper()
     await flushPromises()
 
     await wrapper.find('[data-testid="require-profile"]').trigger('click')
 
-    expect(wrapper.find('[data-testid="current-step"]').text()).toBe(
-      'profileCreation'
-    )
+    expect(mockOpenProfileCreationStep).toHaveBeenCalledOnce()
   })
 
-  it('returns to finish step and re-fetches profile after gate complete', async () => {
-    mockFetchApi.mockResolvedValue(mockSuccessResponse())
+  it('returns to finish state after gate complete and does not auto-close', async () => {
     const wrapper = createWrapper()
     await flushPromises()
 
     await wrapper.find('[data-testid="require-profile"]').trigger('click')
-    expect(wrapper.find('[data-testid="current-step"]').text()).toBe(
-      'profileCreation'
-    )
-
     await wrapper.find('[data-testid="gate-complete"]').trigger('click')
-    await flushPromises()
 
-    expect(wrapper.find('[data-testid="current-step"]').text()).toBe('finish')
-    // Initial prefetch + force re-fetch after gate complete
-    expect(mockFetchApi).toHaveBeenCalledTimes(2)
+    expect(mockOpenProfileCreationStep).toHaveBeenCalledOnce()
+    expect(mockCloseProfileCreationStep).toHaveBeenCalledOnce()
+    expect(mockFetchProfile).toHaveBeenCalledWith({ force: true })
     expect(onClose).not.toHaveBeenCalled()
   })
 
-  it('returns to finish step when profile gate is closed', async () => {
+  it('returns to finish state when profile gate is closed', async () => {
     const wrapper = createWrapper()
     await flushPromises()
 
     await wrapper.find('[data-testid="require-profile"]').trigger('click')
-    expect(wrapper.find('[data-testid="current-step"]').text()).toBe(
-      'profileCreation'
-    )
-
     await wrapper.find('[data-testid="gate-close"]').trigger('click')
 
-    expect(wrapper.find('[data-testid="current-step"]').text()).toBe('finish')
+    expect(mockOpenProfileCreationStep).toHaveBeenCalledOnce()
+    expect(mockCloseProfileCreationStep).toHaveBeenCalledOnce()
     expect(onClose).not.toHaveBeenCalled()
   })
 })