draft test for issue

browser_tests/fixtures/ComfyPage.ts

@@ -1046,8 +1046,6 @@ export class ComfyPage {
   }
 }
 
-export const testComfySnapToGridGridSize = 50
-
 export const comfyPageFixture = base.extend<{
   comfyPage: ComfyPage
   comfyMouse: ComfyMouse
@@ -1075,7 +1073,8 @@ export const comfyPageFixture = base.extend<{
         'Comfy.userId': userId,
         // Set tutorial completed to true to avoid loading the tutorial workflow.
         'Comfy.TutorialCompleted': true,
-        'Comfy.SnapToGrid.GridSize': testComfySnapToGridGridSize
+        // Set installed version for consistent test behavior.
+        'Comfy.InstalledVersion': '1.22.0'
       })
     } catch (e) {
       console.error(e)
@@ -1086,7 +1085,7 @@ export const comfyPageFixture = base.extend<{
   },
   comfyMouse: async ({ comfyPage }, use) => {
     const comfyMouse = new ComfyMouse(comfyPage)
-    use(comfyMouse)
+    await use(comfyMouse)
   }
 })
 

browser_tests/tests/interaction.spec.ts

@@ -1,12 +1,6 @@
 import { expect } from '@playwright/test'
-import { Position } from '@vueuse/core'
 
-import {
-  type ComfyPage,
-  comfyPageFixture as test,
-  testComfySnapToGridGridSize
-} from '../fixtures/ComfyPage'
-import { type NodeReference } from '../fixtures/utils/litegraphUtils'
+import { type ComfyPage, comfyPageFixture as test } from '../fixtures/ComfyPage'
 
 test.describe('Item Interaction', () => {
   test('Can select/delete all items', async ({ comfyPage }) => {
@@ -63,10 +57,8 @@ test.describe('Node Interaction', () => {
       await expect(comfyPage.canvas).toHaveScreenshot('selected-node2.png')
     })
 
-    const dragSelectNodes = async (
-      comfyPage: ComfyPage,
-      clipNodes: NodeReference[]
-    ) => {
+    test('Can drag-select nodes with Meta (mac)', async ({ comfyPage }) => {
+      const clipNodes = await comfyPage.getNodeRefsByType('CLIPTextEncode')
       const clipNode1Pos = await clipNodes[0].getPosition()
       const clipNode2Pos = await clipNodes[1].getPosition()
       const offset = 64
@@ -82,67 +74,10 @@ test.describe('Node Interaction', () => {
         }
       )
       await comfyPage.page.keyboard.up('Meta')
-    }
-
-    test('Can drag-select nodes with Meta (mac)', async ({ comfyPage }) => {
-      const clipNodes = await comfyPage.getNodeRefsByType('CLIPTextEncode')
-      await dragSelectNodes(comfyPage, clipNodes)
       expect(await comfyPage.getSelectedGraphNodesCount()).toBe(
         clipNodes.length
       )
     })
-
-    test('Can move selected nodes using the Comfy.Canvas.MoveSelectedNodes.{Up|Down|Left|Right} commands', async ({
-      comfyPage
-    }) => {
-      const clipNodes = await comfyPage.getNodeRefsByType('CLIPTextEncode')
-      const getPositions = () =>
-        Promise.all(clipNodes.map((node) => node.getPosition()))
-      const testDirection = async ({
-        direction,
-        expectedPosition
-      }: {
-        direction: string
-        expectedPosition: (originalPosition: Position) => Position
-      }) => {
-        const originalPositions = await getPositions()
-        await dragSelectNodes(comfyPage, clipNodes)
-        await comfyPage.executeCommand(
-          `Comfy.Canvas.MoveSelectedNodes.${direction}`
-        )
-        await comfyPage.canvas.press(`Control+Arrow${direction}`)
-        const newPositions = await getPositions()
-        expect(newPositions).toEqual(originalPositions.map(expectedPosition))
-      }
-      await testDirection({
-        direction: 'Down',
-        expectedPosition: (originalPosition) => ({
-          ...originalPosition,
-          y: originalPosition.y + testComfySnapToGridGridSize
-        })
-      })
-      await testDirection({
-        direction: 'Right',
-        expectedPosition: (originalPosition) => ({
-          ...originalPosition,
-          x: originalPosition.x + testComfySnapToGridGridSize
-        })
-      })
-      await testDirection({
-        direction: 'Up',
-        expectedPosition: (originalPosition) => ({
-          ...originalPosition,
-          y: originalPosition.y - testComfySnapToGridGridSize
-        })
-      })
-      await testDirection({
-        direction: 'Left',
-        expectedPosition: (originalPosition) => ({
-          ...originalPosition,
-          x: originalPosition.x - testComfySnapToGridGridSize
-        })
-      })
-    })
   })
 
   test('Can drag node', async ({ comfyPage }) => {

src/components/graph/GraphCanvas.vue

@@ -86,7 +86,6 @@ import { useSettingStore } from '@/stores/settingStore'
 import { useToastStore } from '@/stores/toastStore'
 import { useColorPaletteStore } from '@/stores/workspace/colorPaletteStore'
 import { useWorkspaceStore } from '@/stores/workspaceStore'
-import { getCurrentVersion } from '@/utils/versioning'
 
 const emit = defineEmits<{
   ready: []
@@ -301,13 +300,6 @@ onMounted(async () => {
   CORE_SETTINGS.forEach((setting) => {
     settingStore.addSetting(setting)
   })
-  if (!settingStore.get('Comfy.InstalledVersion')) {
-    const currentVersion =
-      Object.keys(settingStore.settingValues).length > 0
-        ? '0.0.1'
-        : getCurrentVersion()
-    await settingStore.set('Comfy.InstalledVersion', currentVersion)
-  }
   // @ts-expect-error fixme ts strict error
   await comfyApp.setup(canvasRef.value)
   canvasStore.canvas = comfyApp.canvas

src/composables/useCoreCommands.ts

@@ -4,7 +4,6 @@ import {
   LGraphNode,
   LiteGraph
 } from '@comfyorg/litegraph'
-import { Point } from '@comfyorg/litegraph'
 
 import { useFirebaseAuthActions } from '@/composables/auth/useFirebaseAuthActions'
 import {
@@ -28,8 +27,6 @@ import { useColorPaletteStore } from '@/stores/workspace/colorPaletteStore'
 import { useSearchBoxStore } from '@/stores/workspace/searchBoxStore'
 import { useWorkspaceStore } from '@/stores/workspaceStore'
 
-const moveSelectedNodesVersionAdded = '1.22.2'
-
 export function useCoreCommands(): ComfyCommand[] {
   const workflowService = useWorkflowService()
   const workflowStore = useWorkflowStore()
@@ -61,20 +58,6 @@ export function useCoreCommands(): ComfyCommand[] {
     })
   }
 
-  const moveSelectedNodes = (
-    positionUpdater: (pos: Point, gridSize: number) => Point
-  ) => {
-    const selectedNodes = getSelectedNodes()
-    if (selectedNodes.length === 0) return
-
-    const gridSize = useSettingStore().get('Comfy.SnapToGrid.GridSize')
-    selectedNodes.forEach((node) => {
-      node.pos = positionUpdater(node.pos, gridSize)
-    })
-    app.canvas.state.selectionChanged = true
-    app.canvas.setDirty(true, true)
-  }
-
   const commands = [
     {
       id: 'Comfy.NewBlankWorkflow',
@@ -690,34 +673,6 @@ export function useCoreCommands(): ComfyCommand[] {
       function: async () => {
         await firebaseAuthActions.logout()
       }
-    },
-    {
-      id: 'Comfy.Canvas.MoveSelectedNodes.Up',
-      icon: 'pi pi-arrow-up',
-      label: 'Move Selected Nodes Up',
-      versionAdded: moveSelectedNodesVersionAdded,
-      function: () => moveSelectedNodes(([x, y], gridSize) => [x, y - gridSize])
-    },
-    {
-      id: 'Comfy.Canvas.MoveSelectedNodes.Down',
-      icon: 'pi pi-arrow-down',
-      label: 'Move Selected Nodes Down',
-      versionAdded: moveSelectedNodesVersionAdded,
-      function: () => moveSelectedNodes(([x, y], gridSize) => [x, y + gridSize])
-    },
-    {
-      id: 'Comfy.Canvas.MoveSelectedNodes.Left',
-      icon: 'pi pi-arrow-left',
-      label: 'Move Selected Nodes Left',
-      versionAdded: moveSelectedNodesVersionAdded,
-      function: () => moveSelectedNodes(([x, y], gridSize) => [x - gridSize, y])
-    },
-    {
-      id: 'Comfy.Canvas.MoveSelectedNodes.Right',
-      icon: 'pi pi-arrow-right',
-      label: 'Move Selected Nodes Right',
-      versionAdded: moveSelectedNodesVersionAdded,
-      function: () => moveSelectedNodes(([x, y], gridSize) => [x + gridSize, y])
     }
   ]
 

src/composables/useWorkflowPersistence.ts

@@ -6,7 +6,25 @@ import { getStorageValue, setStorageValue } from '@/scripts/utils'
 import { useWorkflowService } from '@/services/workflowService'
 import { useCommandStore } from '@/stores/commandStore'
 import { useSettingStore } from '@/stores/settingStore'
+import { useSystemStatsStore } from '@/stores/systemStatsStore'
 import { useWorkflowStore } from '@/stores/workflowStore'
+import { electronAPI, isElectron } from '@/utils/envUtil'
+
+/**
+ * Get the current ComfyUI version for version tracking
+ */
+function getCurrentVersion(): string {
+  if (isElectron()) {
+    return electronAPI().getComfyUIVersion()
+  } else {
+    // For web version, use systemStats or fallback to frontend version
+    const systemStatsStore = useSystemStatsStore()
+    return (
+      systemStatsStore.systemStats?.system?.comfyui_version ||
+      __COMFYUI_FRONTEND_VERSION__
+    )
+  }
+}
 
 export function useWorkflowPersistence() {
   const workflowStore = useWorkflowStore()
@@ -53,6 +71,11 @@ export function useWorkflowPersistence() {
   }
 
   const loadDefaultWorkflow = async () => {
+    // Initialize installed version for new users
+    if (!settingStore.get('Comfy.InstalledVersion')) {
+      await settingStore.set('Comfy.InstalledVersion', getCurrentVersion())
+    }
+
     if (!settingStore.get('Comfy.TutorialCompleted')) {
       await settingStore.set('Comfy.TutorialCompleted', true)
       await useWorkflowService().loadBlankWorkflow()

src/constants/coreSettings.ts

@@ -755,7 +755,7 @@ export const CORE_SETTINGS: SettingParams[] = [
     name: 'Installed version',
     type: 'hidden',
     defaultValue: null,
-    versionAdded: '1.22.1'
+    versionAdded: '1.22.0'
   },
   {
     id: 'LiteGraph.ContextMenu.Scaling',

src/locales/en/commands.json

@@ -44,18 +44,6 @@
   "Comfy_Canvas_FitView": {
     "label": "Fit view to selected nodes"
   },
-  "Comfy_Canvas_MoveSelectedNodes_Down": {
-    "label": "Move Selected Nodes Down"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Left": {
-    "label": "Move Selected Nodes Left"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Right": {
-    "label": "Move Selected Nodes Right"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Up": {
-    "label": "Move Selected Nodes Up"
-  },
   "Comfy_Canvas_ResetView": {
     "label": "Reset View"
   },

src/locales/en/main.json

@@ -794,10 +794,6 @@
     "Browse Templates": "Browse Templates",
     "Delete Selected Items": "Delete Selected Items",
     "Fit view to selected nodes": "Fit view to selected nodes",
-    "Move Selected Nodes Down": "Move Selected Nodes Down",
-    "Move Selected Nodes Left": "Move Selected Nodes Left",
-    "Move Selected Nodes Right": "Move Selected Nodes Right",
-    "Move Selected Nodes Up": "Move Selected Nodes Up",
     "Reset View": "Reset View",
     "Resize Selected Nodes": "Resize Selected Nodes",
     "Canvas Toggle Link Visibility": "Canvas Toggle Link Visibility",

src/locales/es/commands.json

@@ -44,18 +44,6 @@
   "Comfy_Canvas_FitView": {
     "label": "Ajustar vista a los nodos seleccionados"
   },
-  "Comfy_Canvas_MoveSelectedNodes_Down": {
-    "label": "Mover nodos seleccionados hacia abajo"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Left": {
-    "label": "Mover nodos seleccionados a la izquierda"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Right": {
-    "label": "Mover nodos seleccionados a la derecha"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Up": {
-    "label": "Mover nodos seleccionados hacia arriba"
-  },
   "Comfy_Canvas_ResetView": {
     "label": "Restablecer vista"
   },

src/locales/es/main.json

@@ -709,10 +709,6 @@
     "Interrupt": "Interrumpir",
     "Load Default Workflow": "Cargar flujo de trabajo predeterminado",
     "Manage group nodes": "Gestionar nodos de grupo",
-    "Move Selected Nodes Down": "Mover nodos seleccionados hacia abajo",
-    "Move Selected Nodes Left": "Mover nodos seleccionados hacia la izquierda",
-    "Move Selected Nodes Right": "Mover nodos seleccionados hacia la derecha",
-    "Move Selected Nodes Up": "Mover nodos seleccionados hacia arriba",
     "Mute/Unmute Selected Nodes": "Silenciar/Activar sonido de nodos seleccionados",
     "New": "Nuevo",
     "Next Opened Workflow": "Siguiente flujo de trabajo abierto",

src/locales/fr/commands.json

@@ -44,18 +44,6 @@
   "Comfy_Canvas_FitView": {
     "label": "Ajuster la vue aux nœuds sélectionnés"
   },
-  "Comfy_Canvas_MoveSelectedNodes_Down": {
-    "label": "Déplacer les nœuds sélectionnés vers le bas"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Left": {
-    "label": "Déplacer les nœuds sélectionnés vers la gauche"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Right": {
-    "label": "Déplacer les nœuds sélectionnés vers la droite"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Up": {
-    "label": "Déplacer les nœuds sélectionnés vers le haut"
-  },
   "Comfy_Canvas_ResetView": {
     "label": "Réinitialiser la vue"
   },

src/locales/fr/main.json

@@ -709,10 +709,6 @@
     "Interrupt": "Interrompre",
     "Load Default Workflow": "Charger le flux de travail par défaut",
     "Manage group nodes": "Gérer les nœuds de groupe",
-    "Move Selected Nodes Down": "Déplacer les nœuds sélectionnés vers le bas",
-    "Move Selected Nodes Left": "Déplacer les nœuds sélectionnés vers la gauche",
-    "Move Selected Nodes Right": "Déplacer les nœuds sélectionnés vers la droite",
-    "Move Selected Nodes Up": "Déplacer les nœuds sélectionnés vers le haut",
     "Mute/Unmute Selected Nodes": "Mettre en sourdine/Activer le son des nœuds sélectionnés",
     "New": "Nouveau",
     "Next Opened Workflow": "Prochain flux de travail ouvert",

src/locales/ja/commands.json

@@ -44,18 +44,6 @@
   "Comfy_Canvas_FitView": {
     "label": "選択したノードにビューを合わせる"
   },
-  "Comfy_Canvas_MoveSelectedNodes_Down": {
-    "label": "選択したノードを下に移動"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Left": {
-    "label": "選択したノードを左に移動"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Right": {
-    "label": "選択したノードを右に移動"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Up": {
-    "label": "選択したノードを上に移動"
-  },
   "Comfy_Canvas_ResetView": {
     "label": "ビューをリセット"
   },

src/locales/ja/main.json

@@ -709,10 +709,6 @@
     "Interrupt": "中断",
     "Load Default Workflow": "デフォルトワークフローを読み込む",
     "Manage group nodes": "グループノードを管理",
-    "Move Selected Nodes Down": "選択したノードを下に移動",
-    "Move Selected Nodes Left": "選択したノードを左に移動",
-    "Move Selected Nodes Right": "選択したノードを右に移動",
-    "Move Selected Nodes Up": "選択したノードを上に移動",
     "Mute/Unmute Selected Nodes": "選択したノードのミュート/ミュート解除",
     "New": "新規",
     "Next Opened Workflow": "次に開いたワークフロー",

src/locales/ko/commands.json

@@ -44,18 +44,6 @@
   "Comfy_Canvas_FitView": {
     "label": "선택한 노드에 뷰 맞추기"
   },
-  "Comfy_Canvas_MoveSelectedNodes_Down": {
-    "label": "선택한 노드 아래로 이동"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Left": {
-    "label": "선택한 노드 왼쪽으로 이동"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Right": {
-    "label": "선택한 노드 오른쪽으로 이동"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Up": {
-    "label": "선택한 노드 위로 이동"
-  },
   "Comfy_Canvas_ResetView": {
     "label": "뷰 재설정"
   },

src/locales/ko/main.json

@@ -709,10 +709,6 @@
     "Interrupt": "중단",
     "Load Default Workflow": "기본 워크플로 불러오기",
     "Manage group nodes": "그룹 노드 관리",
-    "Move Selected Nodes Down": "선택한 노드 아래로 이동",
-    "Move Selected Nodes Left": "선택한 노드 왼쪽으로 이동",
-    "Move Selected Nodes Right": "선택한 노드 오른쪽으로 이동",
-    "Move Selected Nodes Up": "선택한 노드 위로 이동",
     "Mute/Unmute Selected Nodes": "선택한 노드 활성화/비활성화",
     "New": "새로 만들기",
     "Next Opened Workflow": "다음 열린 워크플로",

src/locales/ru/commands.json

@@ -44,18 +44,6 @@
   "Comfy_Canvas_FitView": {
     "label": "Подогнать вид к выбранным нодам"
   },
-  "Comfy_Canvas_MoveSelectedNodes_Down": {
-    "label": "Переместить выбранные узлы вниз"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Left": {
-    "label": "Переместить выбранные узлы влево"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Right": {
-    "label": "Переместить выбранные узлы вправо"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Up": {
-    "label": "Переместить выбранные узлы вверх"
-  },
   "Comfy_Canvas_ResetView": {
     "label": "Сбросить вид"
   },

src/locales/ru/main.json

@@ -709,10 +709,6 @@
     "Interrupt": "Прервать",
     "Load Default Workflow": "Загрузить стандартный рабочий процесс",
     "Manage group nodes": "Управление групповыми нодами",
-    "Move Selected Nodes Down": "Переместить выбранные узлы вниз",
-    "Move Selected Nodes Left": "Переместить выбранные узлы влево",
-    "Move Selected Nodes Right": "Переместить выбранные узлы вправо",
-    "Move Selected Nodes Up": "Переместить выбранные узлы вверх",
     "Mute/Unmute Selected Nodes": "Отключить/включить звук для выбранных нод",
     "New": "Новый",
     "Next Opened Workflow": "Следующий открытый рабочий процесс",

src/locales/zh/commands.json

@@ -44,18 +44,6 @@
   "Comfy_Canvas_FitView": {
     "label": "适应视图到选中节点"
   },
-  "Comfy_Canvas_MoveSelectedNodes_Down": {
-    "label": "下移所选节点"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Left": {
-    "label": "向左移动选中节点"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Right": {
-    "label": "向右移动选中节点"
-  },
-  "Comfy_Canvas_MoveSelectedNodes_Up": {
-    "label": "上移所选节点"
-  },
   "Comfy_Canvas_ResetView": {
     "label": "重置视图"
   },

src/locales/zh/main.json

@@ -709,10 +709,6 @@
     "Interrupt": "中断",
     "Load Default Workflow": "加载默认工作流",
     "Manage group nodes": "管理组节点",
-    "Move Selected Nodes Down": "下移所选节点",
-    "Move Selected Nodes Left": "左移所选节点",
-    "Move Selected Nodes Right": "右移所选节点",
-    "Move Selected Nodes Up": "上移所选节点",
     "Mute/Unmute Selected Nodes": "静音/取消静音选定节点",
     "New": "新建",
     "Next Opened Workflow": "下一个打开的工作流",

src/schemas/apiSchema.ts

@@ -473,6 +473,8 @@ const zSettings = z.object({
   /** Settings used for testing */
   'test.setting': z.any(),
   'test.versionedSetting': z.any(),
+  'test.versionedSetting2': z.any(),
+  'test.versionedSetting3': z.any(),
   'main.sub.setting.name': z.any(),
   'single.setting': z.any(),
   'LiteGraph.Node.DefaultPadding': z.boolean(),

src/services/algoliaSearchService.ts

@@ -124,7 +124,19 @@ export const useAlgoliaSearchService = (
     maxCacheSize = DEFAULT_MAX_CACHE_SIZE,
     minCharsForSuggestions = DEFAULT_MIN_CHARS_FOR_SUGGESTIONS
   } = options
-  const searchClient = algoliasearch(__ALGOLIA_APP_ID__, __ALGOLIA_API_KEY__)
+  const searchClient = algoliasearch(__ALGOLIA_APP_ID__, __ALGOLIA_API_KEY__, {
+    hosts: [
+      {
+        url: 'search.comfy.org/api/search',
+        accept: 'read',
+        protocol: 'https'
+      }
+    ],
+    baseHeaders: {
+      'X-Algolia-Application-Id': __ALGOLIA_APP_ID__,
+      'X-Algolia-API-Key': __ALGOLIA_API_KEY__
+    }
+  })
   const searchPacksCache = new QuickLRU<string, SearchPacksResult>({
     maxSize: maxCacheSize
   })

src/stores/settingStore.ts

@@ -7,7 +7,31 @@ import { api } from '@/scripts/api'
 import { app } from '@/scripts/app'
 import type { SettingParams } from '@/types/settingTypes'
 import type { TreeNode } from '@/types/treeExplorerTypes'
-import { compareVersions } from '@/utils/versioning'
+
+/**
+ * Compare two semantic version strings.
+ * @param a - First version string
+ * @param b - Second version string
+ * @returns 0 if equal, 1 if a > b, -1 if a < b
+ */
+function compareVersions(a: string, b: string): number {
+  const parseVersion = (version: string) => {
+    return version.split('.').map((v) => parseInt(v, 10) || 0)
+  }
+
+  const versionA = parseVersion(a)
+  const versionB = parseVersion(b)
+
+  for (let i = 0; i < Math.max(versionA.length, versionB.length); i++) {
+    const numA = versionA[i] || 0
+    const numB = versionB[i] || 0
+
+    if (numA > numB) return 1
+    if (numA < numB) return -1
+  }
+
+  return 0
+}
 
 export const getSettingInfo = (setting: SettingParams) => {
   const parts = setting.category || setting.id.split('.')
@@ -87,7 +111,7 @@ export const useSettingStore = defineStore('setting', () => {
 
     // Check for versioned defaults based on installation version
     if (param?.defaultsByInstallVersion) {
-      const installedVersion = get('Comfy.InstalledVersion')
+      const installedVersion = settingValues.value['Comfy.InstalledVersion']
 
       if (installedVersion) {
         // Find the highest version that is <= installedVersion

src/utils/versioning.ts

@@ -1,37 +0,0 @@
-import { electronAPI, isElectron } from '@/utils/envUtil'
-
-/**
- * Compare two semantic version strings.
- * @param a - First version string
- * @param b - Second version string
- * @returns 0 if equal, 1 if a > b, -1 if a < b
- */
-export function compareVersions(a: string, b: string): number {
-  const parseVersion = (version: string) => {
-    return version.split('.').map((v) => parseInt(v, 10) || 0)
-  }
-
-  const versionA = parseVersion(a)
-  const versionB = parseVersion(b)
-
-  for (let i = 0; i < Math.max(versionA.length, versionB.length); i++) {
-    const numA = versionA[i] || 0
-    const numB = versionB[i] || 0
-
-    if (numA > numB) return 1
-    if (numA < numB) return -1
-  }
-
-  return 0
-}
-
-/**
- * Get the current ComfyUI version for version tracking
- */
-export function getCurrentVersion(): string {
-  if (isElectron()) {
-    return electronAPI().getComfyUIVersion()
-  }
-  // For web version, fallback to frontend version
-  return __COMFYUI_FRONTEND_VERSION__
-}

tests-ui/tests/store/settingStore.test.ts

@@ -142,6 +142,41 @@ describe('useSettingStore', () => {
       expect(store.get('test.versionedSetting')).toBe('version_1_24')
     })
 
+    it('should fallback to original default when no installation version is set', () => {
+      const setting: SettingParams = {
+        id: 'test.versionedSetting2',
+        name: 'test.versionedSetting2',
+        type: 'text',
+        defaultValue: 'original',
+        defaultsByInstallVersion: {
+          '1.20.0': 'version_1_20'
+        }
+      }
+      store.addSetting(setting)
+
+      // Should use original default when no installation version
+      expect(store.get('test.versionedSetting2')).toBe('original')
+    })
+
+    it('should fallback to original default when installation version is older than any versioned default', () => {
+      store.settingValues['Comfy.InstalledVersion'] = '1.10.0'
+
+      const setting: SettingParams = {
+        id: 'test.versionedSetting3',
+        name: 'test.versionedSetting3',
+        type: 'text',
+        defaultValue: 'original',
+        defaultsByInstallVersion: {
+          '1.20.0': 'version_1_20',
+          '1.24.0': 'version_1_24'
+        }
+      }
+      store.addSetting(setting)
+
+      // Should use original default when installation version is too old
+      expect(store.get('test.versionedSetting3')).toBe('original')
+    })
+
     it('should set value and trigger onChange', async () => {
       const onChangeMock = vi.fn()
       const dispatchChangeMock = vi.mocked(app.ui.settings.dispatchChange)