Compare commits

...

1 Commits

Author SHA1 Message Date
dante01yoon
956d9a3b9d fix(settings): widen the Settings dialog to 1280
The redesigned Settings dialog (DES 3253-16079) is 1280px wide but rendered
at 960px — capped in two places: SETTINGS_CONTENT_CLASS (Reka dialog shell)
and BaseModalLayout size="sm" in SettingDialog. Set both to 1280px and let
BaseModalLayout fill the shell (size="full"). Dialog width is not a
workspace-specific concern, so this applies to all settings (OSS + cloud).
2026-06-15 18:22:58 +09:00
3 changed files with 8 additions and 4 deletions

View File

@@ -1,5 +1,5 @@
<template>
<BaseModalLayout content-title="" data-testid="settings-dialog" size="sm">
<BaseModalLayout content-title="" data-testid="settings-dialog" size="full">
<template #leftPanelHeaderTitle>
<i class="icon-[lucide--settings]" />
<h2 class="text-neutral text-base">{{ $t('g.settings') }}</h2>

View File

@@ -53,13 +53,16 @@ describe('useSettingsDialog', () => {
isCloudRef.value = false
})
it("show() opens the Reka renderer with size 'full' and 960px content sizing", () => {
it("show() opens the Reka renderer with size 'full' and 1280px content sizing", () => {
useSettingsDialog().show()
const [args] = showDialog.mock.calls[0]
expect(args.key).toBe('global-settings')
expect(args.dialogComponentProps.renderer).toBe('reka')
expect(args.dialogComponentProps.size).toBe('full')
expect(args.dialogComponentProps.contentClass).toContain('max-w-[960px]')
expect(args.dialogComponentProps.contentClass).toContain('max-w-[1280px]')
expect(args.dialogComponentProps.contentClass).not.toContain(
'max-w-[960px]'
)
expect(args.dialogComponentProps.contentClass).toContain('h-[80vh]')
})

View File

@@ -8,8 +8,9 @@ import type { SettingPanelType } from '@/platform/settings/types'
const DIALOG_KEY = 'global-settings'
// The redesigned Settings dialog is 1280px wide (DES 3253-16079).
const SETTINGS_CONTENT_CLASS =
'w-[90vw] max-w-[960px] sm:max-w-[960px] h-[80vh] max-h-none rounded-2xl overflow-hidden'
'w-[90vw] max-w-[1280px] sm:max-w-[1280px] h-[80vh] max-h-none rounded-2xl overflow-hidden'
export function useSettingsDialog() {
const dialogService = useDialogService()