[backport cloud/1.43] fix: use cloud assets for asset widget default value (#10986)

Backport of #10983 to `cloud/1.43`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10986-backport-cloud-1-43-fix-use-cloud-assets-for-asset-widget-default-value-33d6d73d365081f0bb1ee04f90d87299)
by [Unito](https://www.unito.io)

Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>

.agents/checks/adr-compliance.md

@@ -33,15 +33,15 @@ Flag:
 - **New circular entity dependencies** — New circular imports between `LGraph` ↔ `Subgraph`, `LGraphNode` ↔ `LGraphCanvas`, or similar entity classes.
 - **Direct `graph._version++`** — Mutating the private version counter directly instead of through a public API. Extensions already depend on this side-channel; it must become a proper API.
 
-### Dedicated Stores and Data/Behavior Separation
+### Centralized Registries and ECS-Style Access
 
-Entity data lives in dedicated Pinia stores keyed by string IDs (`widgetValueStore`, `domWidgetStore`, `layoutStore`, `nodeOutputStore`, `subgraphNavigationStore`, `previewExposureStore`), not on entity instances.
+All entity data access should move toward centralized query patterns, not instance property access.
 
 Flag:
 
-- **New instance method/property patterns** — Adding `node.someProperty` or `node.someMethod()` for data that belongs in a dedicated store (e.g. widget values → `widgetValueStore` keyed by `WidgetId`).
+- **New instance method/property patterns** — Adding `node.someProperty` or `node.someMethod()` for data that should be a component in the World, queried via `world.getComponent(entityId, ComponentType)`.
 - **OOP inheritance for entity modeling** — Extending entity classes with new subclasses instead of composing behavior through components and systems.
-- **Duplicated authority** — Storing the same entity state in both a class property and a store, or across two stores, so ownership becomes ambiguous. Each piece of state should have one owning store.
+- **Scattered state** — New entity state stored in multiple locations (class properties, stores, local variables) instead of being consolidated in the World or in a single store.
 
 ### Extension Ecosystem Impact
 

.claude/settings.json

@@ -0,0 +1,9 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(pnpx vitest run --testPathPattern=\"draftCacheV2.property\")",
+      "Bash(pnpx vitest run \"draftCacheV2.property\")",
+      "Bash(node -e \"const fc = require\\(''fast-check''\\); console.log\\(Object.keys\\(fc\\).filter\\(k => k.includes\\(''string''\\)\\).join\\('', ''\\)\\)\")"
+    ]
+  }
+}

.claude/skills/add-model-page/SKILL.md

@@ -1,173 +0,0 @@
----
-name: add-model-page
-description: 'add, update, or remove a model page entry on the comfy org website. creates a PR to Comfy-Org/ComfyUI_frontend apps/website folder with the change and posts a Vercel preview link back to Slack.'
----
-
-# add-model-page
-
-add, update, or remove model pages in the ComfyUI website.
-
-## Trigger phrases
-
-- `Add a model page for <model-name>`
-- `Update the model page for <model-name>`
-- `Remove <model-name> from model pages`
-
-## Phase 1 — Parse the request
-
-Extract:
-
-- **action**: `add` | `update` | `remove`
-- **model-name**: raw string (e.g. `flux1-schnell`, `flux1_dev.safetensors`)
-
-Normalize to a slug: lowercase, replace `_` and `.` with `-`, strip file extensions.
-Example: `flux1_dev.safetensors` → `flux1-dev`
-
-## Architecture overview
-
-Models come from two sources merged at build time:
-
-| File                                            | Purpose                                                                                                                           |
-| ----------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------- |
-| `apps/website/src/config/generated-models.json` | Auto-generated from workflow_templates (slug, name, directory, huggingFaceUrl, workflowCount, displayName, thumbnailUrl, docsUrl) |
-| `apps/website/src/config/model-metadata.ts`     | Hand-curated overrides (docsUrl, blogUrl, featured) — only add entries that need overrides                                        |
-| `apps/website/src/config/models.ts`             | Merges the two above; exports typed `Model[]`                                                                                     |
-
-To regenerate the JSON from workflow_templates:
-
-```bash
-pnpm tsx apps/website/scripts/generate-models.ts
-```
-
-This writes `apps/website/src/config/generated-models.json` directly.
-Thumbnails are populated from local `.webp` files in `workflow_templates/templates/` — no network access needed.
-
----
-
-## Phase 2 — Gather model data (ADD / UPDATE)
-
-Run the generator to get fresh data, then find the model:
-
-```bash
-pnpm tsx apps/website/scripts/generate-models.ts
-jq '.[] | select(.slug | contains("MODEL_SLUG"))' \
-  apps/website/src/config/generated-models.json
-```
-
-The JSON fields are:
-
-- `slug` — URL slug
-- `name` — exact filename or display name for partner nodes
-- `huggingFaceUrl` — download URL (empty for partner nodes)
-- `directory` — `diffusion_models` | `loras` | … | `partner_nodes`
-- `workflowCount` — integer
-- `displayName` — human-readable name
-
-If no match and it is a known API/partner model, add it to `API_PROVIDER_MAP` in
-`generate-models.ts` and re-run. Otherwise tell the user.
-
----
-
-## Phase 3 — Check for existing entry
-
-```bash
-jq --arg slug "${SLUG}" '.[] | select(.slug == $slug)' \
-  apps/website/src/config/generated-models.json
-```
-
-- Match found + action is `add` → switch to UPDATE flow automatically
-- No match + action is `update` → stop and tell the user
-
----
-
-## Phase 4A — ADD: new partner/API model not in workflow_templates
-
-For partner nodes (no local file), add an entry to `API_PROVIDER_MAP` in
-`apps/website/scripts/generate-models.ts`:
-
-```typescript
-mymodel: { name: 'My Model', slug: 'my-model' },
-```
-
-Then re-run `pnpm tsx apps/website/scripts/generate-models.ts` — it will appear
-in `generated-models.json` automatically.
-
-If you also want a `docsUrl`, `blogUrl`, or a link to the hub model page, add an entry to `model-metadata.ts`:
-
-```typescript
-'my-model': {
-  docsUrl: 'https://docs.comfy.org/tutorials/...',
-  blogUrl: 'https://blog.comfy.org/...',
-  hubSlug: 'my-model',   // slug at comfy.org/workflows/model/{hubSlug} — only set if the page exists (returns 200)
-  featured: true
-}
-```
-
-No changes to `models.ts` or `translations.ts` are needed.
-
----
-
-## Phase 4B — UPDATE: edit existing entry
-
-Only `model-metadata.ts` needs editing for most updates (docsUrl, blogUrl,
-featured). For `displayName` or `directory` changes, edit the entry directly in
-`generated-models.json` (until the next generator run would overwrite it — then
-fix the source in `generate-models.ts`).
-
----
-
-## Phase 4C — REMOVE: delete entry
-
-Remove the entry from `generated-models.json` (or mark it with `canonicalSlug`
-pointing to the replacement). No translation file changes needed.
-
----
-
-## Phase 5 — Verify TypeScript
-
-```bash
-pnpm typecheck 2>&1 | grep -E "error|warning" | head -20
-```
-
-Fix any type errors before proceeding. Common issues:
-
-- `ModelDirectory` type not matching a new `directory` value — add it to the union
-- JSON import shape mismatch — `generated-models.json` must match `OutputModel`
-
----
-
-## Phase 6 — Create PR
-
-```bash
-BRANCH="add-model-page-MODEL-SLUG"   # or update- / remove-
-git checkout -b $BRANCH
-git add apps/website/src/config/generated-models.json \
-        apps/website/scripts/generate-models.ts \
-        apps/website/src/config/model-metadata.ts
-git commit -m "feat(models): add model page for MODEL-SLUG"
-git push -u origin $BRANCH
-gh pr create \
-  --title "Add model page: MODEL-SLUG" \
-  --body "$(cat <<'EOF'
-Adds a new model page entry for MODEL-SLUG.
-
-## Changes
-- `generated-models.json`: regenerated with new entry (workflowCount N, directory DIRECTORY)
-- `model-metadata.ts`: editorial overrides (docsUrl, featured) if needed
-EOF
-)"
-```
-
-For UPDATE use branch `update-model-page-MODEL-SLUG`.
-For REMOVE use `remove-model-page-MODEL-SLUG`.
-
----
-
-## Error states
-
-| Situation                       | Response                                                         |
-| ------------------------------- | ---------------------------------------------------------------- |
-| Model not in workflow templates | Ask user to verify spelling or add it manually as a partner node |
-| Slug already exists (add)       | Switch to update flow automatically                              |
-| Slug not found (update/remove)  | Stop and ask user to confirm                                     |
-| Typecheck fails                 | Fix the error before pushing                                     |

.claude/skills/backport-management/SKILL.md

@@ -9,18 +9,13 @@ Cherry-pick backport management for Comfy-Org/ComfyUI_frontend stable release br
 
 ## Quick Start
 
-1. **Discover** — Collect candidates from Slack bot + git log gap, then **reconcile both lists** (`reference/discovery.md`)
-2. **Pre-filter by path** — Auto-skip PRs whose changed files are entirely under `apps/website/`, `browser_tests/`, `.github/`, `packages/design-system/`, `packages/{cloud,registry}-types/`, `.claude/`, `docs/`. Don't read PR bodies for these — they don't ship to core ComfyUI users (`reference/analysis.md`)
-3. **Verify target file existence** — For each surviving candidate, run `git cat-file -e origin/$TARGET:$path` for primary changed files. If they don't exist on the target, auto-mark SKIP with reason `feature-not-on-branch`
-4. **Tiered triage** — Bucket into **Tier 1 (core editor must-haves)**, **Tier 2 (cloud-distribution only)**, **Tier 3 (skip)** before reviewing individually (`reference/analysis.md`)
-5. **Analyze** — Categorize remaining MUST/SHOULD, check deps (`reference/analysis.md`)
-6. **Human Review** — Present candidates in batches for interactive approval, with tier context attached (see Interactive Approval Flow)
-7. **Plan** — Order by dependency (leaf fixes first), group into waves per branch
-8. **Test-then-resolve dry-run** — Classify clean vs conflict before committing time (`reference/execution.md`)
-9. **Execute** — Label-driven automation for clean PRs → worktree fallback for conflicts (`reference/execution.md`)
-10. **Public-API conflict review** — If conflict resolution touches a public LiteGraph callback, extension API, or `node.*` method, consult oracle for compat-regression review BEFORE pushing (`reference/execution.md`)
-11. **Verify** — Per-PR validation (typecheck + targeted tests + lint on changed files) AND per-wave verification (full typecheck + test:unit on branch HEAD)
-12. **Log & Report** — Generate session report + author accountability report + Slack status update (`reference/logging.md`)
+1. **Discover** — Collect candidates from Slack bot + git log gap (`reference/discovery.md`)
+2. **Analyze** — Categorize MUST/SHOULD/SKIP, check deps (`reference/analysis.md`)
+3. **Human Review** — Present candidates in batches for interactive approval (see Interactive Approval Flow)
+4. **Plan** — Order by dependency (leaf fixes first), group into waves per branch
+5. **Execute** — Label-driven automation → worktree fallback for conflicts (`reference/execution.md`)
+6. **Verify** — After each wave, verify branch integrity before proceeding
+7. **Log & Report** — Generate session report (`reference/logging.md`)
 
 ## System Context
 
@@ -112,35 +107,6 @@ Husky hooks fail in worktrees (can't find lint-staged config). Always use `git p
 
 In the 2026-04-06 session: core/1.42 got 18/26 auto-PRs, cloud/1.42 got only 1/25. The cloud branch has more divergence. **Always plan for manual fallback** — don't assume automation will handle most PRs.
 
-### Cherry-Picked Tests Can Reference Files Added By Earlier Unbackported PRs
-
-A common conflict: PR A on main modifies a test file that was _added_ on main by an earlier PR B (not backported to the target). The cherry-pick of A reports "modify/delete" on B's test file because the file doesn't exist on the target. Adding the new file would smuggle in B's test scaffolding without B's runtime changes.
-
-**Detection:** Conflict says `deleted in HEAD and modified in <PR>`. Verify with:
-
-```bash
-git log --diff-filter=A --oneline origin/main -- path/to/test.ts
-```
-
-If the introducing commit is **not** on the target branch, the test file isn't a real prerequisite for the runtime fix.
-
-**Fix:** `git rm` the test file (drop it from the backport). Document in the commit body which PR introduced it on main and why dropping it is safe. The runtime fix itself usually doesn't depend on these tests — coverage exists at the integration layer.
-
-### Backport-Only Compatibility Shims
-
-When a PR's _mechanism_ relies on changes upstream that aren't on the older branch, a literal cherry-pick can recreate the original bug for any consumer still using the old contract. This is most dangerous for **public LiteGraph callbacks, extension APIs, and `node.*` methods** that custom-node packages depend on.
-
-**Real example (#11541, core/1.43 backport):** The PR removed `LGraphNode.vue`'s legacy `handled === true` sync-return check from `handleDrop`, replacing it with `await node.onDragDrop(event, true)`. Safe on `main` because all in-repo `onDragDrop` handlers had migrated to participate in the new `claimEvent` flag. On `core/1.43`, `onDragDrop` is a public callback — custom-node packages with synchronous `onDragDrop` returning `true` would no longer have their event claimed, recreating the duplicate-node-creation bug the PR was fixing.
-
-**Detection:** The PR's diff modifies a file that is part of a public extension API surface. Look for:
-
-- `node.onXxx` callback assignments
-- Methods on `LGraphNode`, `LGraphCanvas`, `LGraph`, `Subgraph`
-- Public exports from `src/lib/litegraph/`
-- Type changes affecting `litegraph-augmentation.d.ts`
-
-**Fix:** Add a backport-only compatibility shim that preserves the old contract while keeping the new fix. Document it explicitly in the commit body under a `## Backport-only compatibility fix` heading. Consult oracle for review before pushing — a bad shim is worse than no fix.
-
 ## Conflict Triage
 
 **Always categorize before deciding to skip. High conflict count ≠ hard conflicts.**
@@ -181,26 +147,6 @@ Skip these without discussion:
 - **Features not on target branch** — e.g., Painter, GLSLShader, appModeStore on core/1.40
 - **Cloud-only PRs on core/\* branches** — Team workspaces, cloud queue, cloud-only login. (Note: app mode and Firebase auth are NOT cloud-only — see Branch Scope Rules)
 
-### Path Pre-Filter (run BEFORE reading PR bodies)
-
-For 50+ candidate PRs, classify by changed paths first to skip the unproductive ones without spending time on triage. Run `git show --stat $SHA` (or `gh pr view --json files`) and bucket:
-
-| Path prefix                                    | Bucket                 | Reason                                           |
-| ---------------------------------------------- | ---------------------- | ------------------------------------------------ |
-| `apps/website/`                                | SKIP                   | Marketing/platform site, not core ComfyUI bundle |
-| `apps/desktop-ui/`                             | SKIP for `core/*`      | Desktop app, separate release cadence            |
-| `browser_tests/` only (no `src/`)              | SKIP                   | Test-only                                        |
-| `.github/workflows/` only                      | SKIP                   | CI/release infra                                 |
-| `packages/design-system/` only                 | SKIP                   | Design tokens, not core                          |
-| `packages/{cloud,registry,ingest}-types/` only | SKIP                   | Generated types                                  |
-| `.claude/`, `.agents/`, `docs/`                | SKIP                   | Agent / documentation                            |
-| `*.stories.ts` only                            | SKIP                   | Storybook only                                   |
-| `src/` (core editor)                           | KEEP — analyze further | Runtime/editor code that requires full triage    |
-
-A PR touches multiple paths? Keep it if **any** changed file is under `src/` (or other core paths) and run normal analysis. Auto-skip is conservative — only skip when _all_ paths match the SKIP buckets.
-
-This filter alone removes ~30-50% of candidates in a typical session, leaving only the PRs that need real triage.
-
 ## Wave Verification
 
 After merging each wave of PRs to a target branch, verify branch integrity before proceeding:

.claude/skills/backport-management/reference/analysis.md

@@ -39,89 +39,6 @@ Check before backporting — these don't exist on older branches:
 - **App builder** — check per branch
 - **appModeStore.ts** — not on core/1.40
 
-### Verify Target File Existence (Run Before Cherry-Pick)
-
-Before cherry-picking any PR, confirm the files it modifies actually exist on the target branch. If they don't, the PR's runtime fix is for a feature that hasn't been added yet — skip cleanly without attempting cherry-pick:
-
-```bash
-# For each file the PR changes
-for f in $(gh pr view $PR --json files --jq '.files[].path' | grep -v "^browser_tests/\|\.test\." ); do
-  if ! git cat-file -e origin/$TARGET:$f 2>/dev/null; then
-    echo "MISSING on $TARGET: $f"
-  fi
-done
-```
-
-If the _primary_ changed files (the runtime ones, not tests) are missing, mark the PR `SKIP / feature-not-on-branch`. This is faster than letting cherry-pick fail with modify/delete conflicts and gives a clean signal.
-
-This check is the first thing that runs after the path pre-filter and BEFORE you spend time reading PR descriptions.
-
-## Tiered Triage (Recommended for 30+ Candidates)
-
-Before the interactive Y/N approval flow, bucket all surviving candidates into three tiers. This surfaces release-engineering decisions that a flat MUST/SHOULD list obscures:
-
-### Tier 1 — Core Editor Must-Haves
-
-User-facing bugs, crashes, data corruption, or security issues in code paths that exist on the target branch. These are the strongest backport candidates.
-
-Indicators:
-
-- `fix:` prefix and the bug is reproducible on the target branch
-- Crash guards, runtime null checks, race-condition fixes
-- Data-loss bugs (state not persisted, duplicates, drops)
-- Security hardening (CSRF, XSS, auth)
-- Vue Nodes 2.0 regression cluster (if the target ships Vue Nodes 2.0)
-- Subgraph correctness fixes
-- Public-API extension callback fixes
-
-Recommend `Y` to user.
-
-### Tier 2 — Cloud-Distribution Only
-
-Bugs that only manifest on cloud-hosted distributions (Secrets panel, subscription flows, cloud signup, workspace tracking, etc.). Whether to backport depends on whether cloud ships from the target `core/*` branch in your release matrix.
-
-Indicators:
-
-- Files under `src/platform/secrets/`, `src/platform/subscription/`, signup flows
-- PR description mentions cloud staging issues
-- Fix gated behind cloud feature flags
-
-Default: ask the cloud release rotation owner. If unsure, defer.
-
-### Tier 3 — Skip
-
-Path pre-filter caught most of these. The rest are PRs where the diff _touches_ `src/` but the practical impact is non-user-facing or scoped to features the target doesn't ship.
-
-Indicators:
-
-- All changes in test files even if the PR touched `src/` test files
-- Storybook stories only
-- Lint config / lint rule additions
-- Documentation comments
-- Internal refactors with no behavior change
-
-### Presentation Format
-
-When showing tier results to the user, format as:
-
-```text
-Tier 1 (N PRs) — strong backport candidates
-- #11541 fix: stop duplicate node creation when dropping image on Vue nodes
-  Why: Vue Nodes 2.0 regression — async onDragDrop bypassed handled-check, drops bubble to document, spawns extra LoadImage nodes
-- #10849 fix: store promoted widget values per SubgraphNode instance
-  Why: Multiple instances overwriting each other's promoted widget values — data loss
-
-Tier 2 (N PRs) — cloud-distribution release rotation should decide
-- #11636 fix: enable Chrome password autofill on signup form
-- ...
-
-Tier 3 (N PRs) — skip recommended
-- #11586 fix: website polish (apps/website/ only)
-- ...
-```
-
-Then run interactive Y/N over Tier 1 and Tier 2; Tier 3 gets confirmed-skip without per-PR review.
-
 ## Dep Refresh PRs
 
 Always SKIP on stable branches. Risk of transitive dependency regressions outweighs audit cleanup benefit. If a specific CVE fix is needed, cherry-pick that individual fix instead.

.claude/skills/backport-management/reference/discovery.md

@@ -1,11 +1,5 @@
 # Discovery — Candidate Collection
 
-**Run all sources, then reconcile.** No single source is authoritative:
-
-- Slack bot may flag PRs that have already been backported (false positive)
-- Git gap may include PRs that don't need backport (test-only, design-system, website)
-- Bot can also miss PRs that landed without the right labels
-
 ## Source 1: Slack Backport-Checker Bot
 
 Use `slackdump` skill to export `#frontend-releases` channel (C09K9TPU2G7):
@@ -42,43 +36,7 @@ gh pr view $PR --json mergeCommit,title --jq '"Title: \(.title)\nMerge: \(.merge
 gh pr view $PR --json files --jq '.files[].path'
 ```
 
-## Source 4: Already-Backported PRs (cross-reference)
-
-When the target branch already has some cherry-picks on it (e.g., partway through a release window), extract the originals to avoid re-backporting:
-
-```bash
-# Get all original PR numbers already backported to TARGET since the last release tag
-git log --format="%H%n%B" $LAST_TAG..origin/$TARGET \
-  | grep -oiE "(backport of|cherry.picked) #?[0-9]+" \
-  | grep -oE "[0-9]+" \
-  | sort -un > /tmp/already-backported.txt
-```
-
-Subtract this list from your candidates.
-
-## Reconciliation Workflow
-
-```bash
-# 1. Slack bot list (parse from export)
-# /tmp/bot-flagged.txt — one PR# per line, sorted
-
-# 2. Git gap fix/perf only
-MB=$(git merge-base origin/main origin/$TARGET)
-git log --format="%h|%s" $MB..origin/main \
-  | grep -iE "^[a-f0-9]+\|(fix|perf)" \
-  | grep -oE "#[0-9]+\)" | grep -oE "[0-9]+" \
-  | sort -un > /tmp/gap-fixes.txt
-
-# 3. Already backported (Source 4 above)
-
-# 4. Candidates = (gap-fixes ∪ bot-flagged) − already-backported
-sort -u /tmp/gap-fixes.txt /tmp/bot-flagged.txt > /tmp/union.txt
-comm -23 /tmp/union.txt /tmp/already-backported.txt > /tmp/candidates.txt
-```
-
-The result is the input to the path pre-filter (`SKILL.md` Quick Start step 2).
-
 ## Output: candidate_list.md
 
 Table per target branch:
-| PR# | Title | Source (bot/gap/both) | Path bucket | Tier | Decision |
+| PR# | Title | Category | Flagged by Bot? | Decision |

.claude/skills/backport-management/reference/execution.md

@@ -6,43 +6,6 @@
 2. Medium gap next (quick win)
 3. Largest gap last (main effort)
 
-## Step 0: Test-Then-Resolve Pre-Pass (Recommended)
-
-Before triggering label-driven automation, run a dry-run cherry-pick loop to classify candidates. This is much faster than discovering conflicts after-the-fact across automation, manual cherry-picks, and CI failures.
-
-```bash
-git fetch origin TARGET_BRANCH
-git worktree add /tmp/dryrun-TARGET origin/TARGET_BRANCH
-cd /tmp/dryrun-TARGET
-
-CLEAN=()
-CONFLICT=()
-for pr in "${CANDIDATES[@]}"; do
-  SHA=$(gh pr view $pr --json mergeCommit --jq '.mergeCommit.oid')
-  git checkout -b dryrun-$pr origin/TARGET_BRANCH 2>/dev/null
-  if git cherry-pick -m 1 $SHA 2>/dev/null; then
-    CLEAN+=($pr)
-  else
-    CONFLICT+=($pr)
-    git cherry-pick --abort
-  fi
-  git checkout --detach HEAD 2>/dev/null
-  git branch -D dryrun-$pr 2>/dev/null
-done
-
-echo "CLEAN (${#CLEAN[@]}): ${CLEAN[*]}"
-echo "CONFLICT (${#CONFLICT[@]}): ${CONFLICT[*]}"
-
-cd -
-git worktree remove /tmp/dryrun-TARGET --force
-```
-
-Use the result to:
-
-- Send CLEAN PRs through label-driven automation (Step 1) — they'll typically self-merge
-- Reserve manual worktree time (Step 3) for CONFLICT PRs only
-- Surface PRs likely to need backport-only compat shims (CONFLICT files in `src/lib/litegraph/` or `src/scripts/app.ts`)
-
 ## Step 1: Label-Driven Automation (Batch)
 
 ```bash
@@ -125,39 +88,6 @@ for PR in ${CONFLICT_PRS[@]}; do
   git add .
   GIT_EDITOR=true git cherry-pick --continue
 
-  # ── Public-API conflict review (REQUIRED for extension-API surfaces) ──
-  # If the conflict resolution touched any of these surfaces, consult oracle
-  # BEFORE pushing. A bad shim is worse than no fix:
-  #   - node.onXxx callback assignments (onDragDrop, onConnectionsChange, onRemoved, onConfigure, etc.)
-  #   - Methods on LGraphNode, LGraphCanvas, LGraph, Subgraph
-  #   - Public exports from src/lib/litegraph/
-  #   - Type changes in litegraph-augmentation.d.ts
-  # If a public callback's signature/contract changed: add a backport-only
-  # compatibility shim that preserves the OLD contract while keeping the
-  # new fix. Document it in the commit body under
-  # "## Backport-only compatibility fix". See SKILL.md gotcha section.
-  # ───────────────────────────────────────────────────────────────────────
-
-  # Per-PR validation BEFORE push (catches issues earlier than wave verification).
-  # Guard each targeted command against empty file lists — running `pnpm test:unit`
-  # with no path filter would run the full suite, and `pnpm exec eslint` with no args errors.
-  pnpm typecheck
-
-  mapfile -t TEST_FILES < <(git diff --name-only HEAD~1 | grep -E '\.test\.ts$' || true)
-  if [ ${#TEST_FILES[@]} -gt 0 ]; then
-    pnpm test:unit "${TEST_FILES[@]}"
-  else
-    echo "No changed test files — skipping targeted unit tests"
-  fi
-
-  mapfile -t CODE_FILES < <(git diff --name-only HEAD~1 | grep -E '\.(ts|vue)$' || true)
-  if [ ${#CODE_FILES[@]} -gt 0 ]; then
-    pnpm exec eslint "${CODE_FILES[@]}"
-    pnpm exec oxfmt --check "${CODE_FILES[@]}"
-  else
-    echo "No changed ts/vue files — skipping targeted lint/format"
-  fi
-
   git push origin backport-$PR-to-TARGET --no-verify
   NEW_PR=$(gh pr create --base TARGET_BRANCH --head backport-$PR-to-TARGET \
     --title "[backport TARGET] TITLE (#$PR)" \
@@ -313,9 +243,6 @@ gh pr checks $PR --watch --fail-fast && gh pr merge $PR --squash --admin
 16. **Use `--no-verify` in worktrees** — husky hooks fail in `/tmp/` worktrees. Always push/commit with `--no-verify`.
 17. **Automation success varies by branch** — core/1.42 got 18/26 auto-PRs (69%), cloud/1.42 got 1/25 (4%). Cloud branches diverge more. Plan for manual fallback.
 18. **Test-then-resolve pattern** — for branches with low automation success, run a dry-run loop to classify clean vs conflict PRs before processing. This is much faster than resolving conflicts serially.
-19. **Public-API conflict resolutions need oracle review** — when a conflict touches `node.onXxx` callbacks, `LGraphNode`/`LGraphCanvas`/`LGraph`/`Subgraph` methods, or types in `litegraph-augmentation.d.ts`, consult oracle BEFORE pushing. Custom-node packages depend on these contracts. A literal cherry-pick of a refactor-style fix can silently break extensions still using the old contract — sometimes recreating the very bug the PR was fixing. Document any backport-only compatibility shim explicitly in the commit body.
-20. **Cherry-picked tests can require unbackported test scaffolding** — when a PR modifies a test file that was _added_ on main by an earlier unbackported PR, the cherry-pick reports modify/delete on that file. Drop it from the backport (`git rm`) and document which PR introduced it. Don't smuggle in test infrastructure without its runtime prerequisites.
-21. **Per-PR validation catches issues earlier than wave verification** — for high-stakes branches, run `pnpm typecheck && pnpm exec eslint <changed files> && pnpm exec oxfmt --check` per PR before pushing. Wave verification still matters (it catches cross-PR interactions), but per-PR makes attribution trivial when something fails.
 
 ## CI Failure Triage
 
@@ -341,40 +268,3 @@ Common failure categories:
 | Type error                  | Interface changed on main but not branch | May need manual adaptation                |
 
 **Never assume a failure is safe to skip.** Present all failures to the user with analysis.
-
-## PR Body Template (Manual Cherry-Picks)
-
-Manual cherry-pick PRs need detail beyond the automation's terse default. Use this template — reviewers will look here before re-deriving conflict-resolution logic from the diff.
-
-```markdown
-Manual backport of #ORIG to `TARGET` for inclusion in `vX.Y.Z`.
-
-Cherry-picked from upstream merge commit `SHORT_SHA`.
-
-## Why
-
-[1-2 sentences from the original PR's "Summary" — what bug, what fix mechanism]
-
-## Conflict resolution
-
-- **`path/to/file`** — [what conflicted on this branch] → [resolution chosen + why]
-- **`path/to/dropped-test.test.ts`** — added on main by unrelated PR #XXXX (not backported). Dropped from this backport; runtime fix intact.
-- [...]
-
-## Backport-only compatibility fix (if applicable)
-
-[If you added a shim that wasn't in the upstream PR, document it here — what extension surface, what contract, what the shim preserves, why the upstream version would have regressed it]
-
-## Validation
-
-- `pnpm typecheck` ✅
-- `pnpm test:unit <targeted suites>` ✅ (N/N passing)
-- `pnpm exec eslint <changed files>` ✅ (0 errors)
-- `pnpm exec oxfmt --check` ✅ (clean)
-
-[If manual e2e was skipped, explain why — e.g., requires live backend, headless not feasible. State that source is byte-identical to upstream + how long it's been baking on main.]
-
-Original PR: #ORIG / Original commit: `FULL_SHA`
-```
-
-The conflict-resolution section is non-negotiable — every conflict you resolved by hand needs a one-liner. This makes archaeology trivial six months later when someone asks "why does this look slightly different from main?"

.claude/skills/hardening-flaky-e2e-tests/SKILL.md

@@ -1,246 +0,0 @@
----
-name: hardening-flaky-e2e-tests
-description: 'Diagnoses and fixes flaky Playwright e2e tests by replacing race-prone patterns with retry-safe alternatives. Use when triaging CI flakes, hardening spec files, fixing timing races, or asked to stabilize browser tests. Triggers on: flaky, flake, harden, stabilize, race condition in e2e, intermittent failure.'
----
-
-# Hardening Flaky E2E Tests
-
-Fix flaky Playwright specs by identifying race-prone patterns and replacing them with retry-safe alternatives. This skill covers diagnosis, pattern matching, and mechanical transforms — not writing new tests (see `writing-playwright-tests` for that).
-
-## Workflow
-
-### 1. Gather CI Evidence
-
-```bash
-gh run list --workflow=ci-test.yaml --limit=5
-gh run download <run-id> -n playwright-report
-```
-
-- Open `report.json` and search for `"status": "flaky"` entries.
-- Collect file paths, test titles, and error messages.
-- Do NOT trust green checks alone — flaky tests that passed on retry still need fixing.
-- Use `error-context.md`, traces, and page snapshots before editing code.
-- Pull the newest run after each push instead of assuming the flaky set is unchanged.
-
-### 2. Classify the Flake
-
-Read the failing assertion and match it against the pattern table. Most flakes fall into one of these categories:
-
-| #   | Pattern                               | Signature in Code                                         | Fix                                                              |
-| --- | ------------------------------------- | --------------------------------------------------------- | ---------------------------------------------------------------- |
-| 1   | **Snapshot-then-assert**              | `expect(await evaluate()).toBe(x)`                        | `await expect.poll(() => evaluate()).toBe(x)`                    |
-| 2   | **Immediate count**                   | `const n = await loc.count(); expect(n).toBe(3)`          | `await expect(loc).toHaveCount(3)`                               |
-| 3   | **nextFrame after menu click**        | `clickMenuItem(x); nextFrame()`                           | `clickMenuItem(x); contextMenu.waitForHidden()`                  |
-| 4   | **Tight poll timeout**                | `expect.poll(..., { timeout: 250 })`                      | ≥2000 ms; prefer default 5000 ms                                 |
-| 5   | **Immediate evaluate after mutation** | `setSetting(k, v); expect(await evaluate()).toBe(x)`      | `await expect.poll(() => evaluate()).toBe(x)`                    |
-| 6   | **Screenshot without readiness**      | `loadWorkflow(); nextFrame(); toHaveScreenshot()`         | `waitForNodes()` or poll state first                             |
-| 7   | **Non-deterministic node order**      | `getNodeRefsByType('X')[0]` with >1 match                 | `getNodeRefById(id)` or guard `toHaveLength(1)`                  |
-| 8   | **Fake readiness helper**             | Helper clicks but doesn't assert state                    | Remove; poll the actual value                                    |
-| 9   | **Immediate graph state after drop**  | `expect(await getLinkCount()).toBe(1)`                    | `await expect.poll(() => getLinkCount()).toBe(1)`                |
-| 10  | **Immediate boundingBox/layout read** | `const box = await loc.boundingBox(); expect(box!.width)` | `await expect.poll(() => loc.boundingBox().then(b => b?.width))` |
-
-### 3. Apply the Transform
-
-#### Rule: Choose the Smallest Correct Assertion
-
-- **Locator state** → use built-in retrying assertions: `toBeVisible()`, `toHaveText()`, `toHaveCount()`, `toHaveClass()`
-- **Single async value** → `expect.poll(() => asyncFn()).toBe(expected)`
-- **Multiple assertions that must settle together** → `expect(async () => { ... }).toPass()`
-- **Never** use `waitForTimeout()` to hide a race.
-
-```typescript
-// ✅ Single value — use expect.poll
-await expect
-  .poll(() => comfyPage.page.evaluate(() => window.app!.graph.links.length))
-  .toBe(3)
-
-// ✅ Locator count — use toHaveCount
-await expect(comfyPage.page.locator('.dom-widget')).toHaveCount(2)
-
-// ✅ Multiple conditions — use toPass
-await expect(async () => {
-  expect(await node1.getValue()).toBe('foo')
-  expect(await node2.getValue()).toBe('bar')
-}).toPass({ timeout: 5000 })
-```
-
-#### Rule: Wait for the Real Readiness Boundary
-
-Visible is not always ready. Prefer user-facing assertions when possible; poll internal state only when there is no UI surface to assert on.
-
-Common readiness boundaries:
-
-| After this action...                   | Wait for...                                                  |
-| -------------------------------------- | ------------------------------------------------------------ |
-| Canvas interaction (drag, click node)  | `await comfyPage.nextFrame()`                                |
-| Menu item click                        | `await contextMenu.waitForHidden()`                          |
-| Workflow load                          | `await comfyPage.workflow.loadWorkflow(...)` (built-in wait) |
-| Settings write                         | Poll the setting value with `expect.poll()`                  |
-| Node pin/bypass/collapse toggle        | `await expect.poll(() => nodeRef.isPinned()).toBe(true)`     |
-| Graph mutation (add/remove node, link) | Poll link/node count                                         |
-| Clipboard write                        | Poll pasted value                                            |
-| Screenshot                             | Ensure nodes are rendered: `waitForNodes()` or poll state    |
-
-#### Rule: Expose Locators for Retrying Assertions
-
-When a helper returns a count via `await loc.count()`, callers can't use `toHaveCount()`. Expose the underlying `Locator` as a getter so callers choose between:
-
-```typescript
-// Helper exposes locator
-get domWidgets(): Locator {
-  return this.page.locator('.dom-widget')
-}
-
-// Caller uses retrying assertion
-await expect(comfyPage.domWidgets).toHaveCount(2)
-```
-
-Replace count methods with locator getters so callers can use retrying assertions directly.
-
-#### Rule: Fix Check-then-Act Races in Helpers
-
-```typescript
-// ❌ Race: count can change between check and waitFor
-const count = await locator.count()
-if (count > 0) {
-  await locator.waitFor({ state: 'hidden' })
-}
-
-// ✅ Direct: waitFor handles both cases
-await locator.waitFor({ state: 'hidden' })
-```
-
-#### Rule: Remove force:true from Clicks
-
-`force: true` bypasses actionability checks, hiding real animation/visibility races. Remove it and fix the underlying timing issue.
-
-```typescript
-// ❌ Hides the race
-await closeButton.click({ force: true })
-
-// ✅ Surfaces the real issue — fix with proper wait
-await closeButton.click()
-await dialog.waitForHidden()
-```
-
-#### Rule: Handle Non-deterministic Element Order
-
-When `getNodeRefsByType` returns multiple nodes, the order is not guaranteed. Don't use index `[0]` blindly.
-
-```typescript
-// ❌ Assumes order
-const node = (await comfyPage.nodeOps.getNodeRefsByType('CLIPTextEncode'))[0]
-
-// ✅ Find by ID or proximity
-const nodes = await comfyPage.nodeOps.getNodeRefsByType('CLIPTextEncode')
-let target = nodes[0]
-for (const n of nodes) {
-  const pos = await n.getPosition()
-  if (Math.abs(pos.y - expectedY) < minDist) target = n
-}
-```
-
-Or guard the assumption:
-
-```typescript
-const nodes = await comfyPage.nodeOps.getNodeRefsByType('CLIPTextEncode')
-expect(nodes).toHaveLength(1)
-const node = nodes[0]
-```
-
-#### Rule: Use toPass for Timing-sensitive Dismiss Guards
-
-Some UI elements (e.g. LiteGraph's graphdialog) have built-in dismiss delays. Retry the entire dismiss action:
-
-```typescript
-// ✅ Retry click+assert together
-await expect(async () => {
-  await comfyPage.canvas.click({ position: { x: 10, y: 10 } })
-  await expect(dialog).toBeHidden({ timeout: 500 })
-}).toPass({ timeout: 5000 })
-```
-
-### 4. Keep Changes Narrow
-
-- Shared helpers should drive setup to a stable boundary.
-- Do not encode one-spec timing assumptions into generic helpers.
-- If a race only matters to one spec, prefer a local wait in that spec.
-- If a helper fails before the real test begins, remove or relax the brittle precondition and let downstream UI interaction prove readiness.
-
-### 5. Verify Narrowly
-
-```bash
-# Targeted rerun with repetition
-pnpm test:browser:local -- browser_tests/tests/myFile.spec.ts --repeat-each 10
-
-# Single test by line number (avoids grep quoting issues on Windows)
-pnpm test:browser:local -- browser_tests/tests/myFile.spec.ts:42
-```
-
-- Use `--repeat-each 10` for targeted flake verification (use 20 for single test cases).
-- Verify with the smallest command that exercises the flaky path.
-
-### 6. Watch CI E2E Runs
-
-After pushing, use `gh` to monitor the E2E workflow:
-
-```bash
-# Find the run for the current branch
-gh run list --workflow="CI: Tests E2E" --branch=$(git branch --show-current) --limit=1
-
-# Watch it live (blocks until complete, streams logs)
-gh run watch <run-id>
-
-# One-liner: find and watch the latest E2E run for the current branch
-gh run list --workflow="CI: Tests E2E" --branch=$(git branch --show-current) --limit=1 --json databaseId --jq ".[0].databaseId" | xargs gh run watch
-```
-
-On Windows (PowerShell):
-
-```powershell
-# One-liner equivalent
-gh run watch (gh run list --workflow="CI: Tests E2E" --branch=$(git branch --show-current) --limit=1 --json databaseId --jq ".[0].databaseId")
-```
-
-After the run completes:
-
-```bash
-# Download the Playwright report artifact
-gh run download <run-id> -n playwright-report
-
-# View the run summary in browser
-gh run view <run-id> --web
-```
-
-Also watch the unit test workflow in parallel if you changed helpers:
-
-```bash
-gh run list --workflow="CI: Tests Unit" --branch=$(git branch --show-current) --limit=1
-```
-
-### 7. Pre-merge Checklist
-
-Before merging a flaky-test fix, confirm:
-
-- [ ] The latest CI artifact was inspected directly
-- [ ] The root cause is stated as a race or readiness mismatch
-- [ ] The fix waits on the real readiness boundary
-- [ ] The assertion primitive matches the job (poll vs toHaveCount vs toPass)
-- [ ] The fix stays local unless a shared helper truly owns the race
-- [ ] Local verification uses a targeted rerun
-- [ ] No behavioral changes to the test — only timing/retry strategy updated
-
-## Local Noise — Do Not Fix
-
-These are local distractions, not CI root causes:
-
-- Missing local input fixture files required by the test path
-- Missing local models directory
-- Teardown `EPERM` while restoring the local browser-test user data directory
-- Local screenshot baseline differences on Windows
-
-Rules:
-
-- First confirm whether it blocks the exact flaky path under investigation.
-- Do not commit temporary local assets used only for verification.
-- Do not commit local screenshot baselines.

.claude/skills/perf-fix-with-proof/SKILL.md

@@ -171,7 +171,7 @@ test('canvas text rendering with many nodes', async ({ comfyPage }) => {
 | ----------------- | ----------------------------------------------------- |
 | Perf test file    | `browser_tests/tests/performance.spec.ts`             |
 | PerformanceHelper | `browser_tests/fixtures/helpers/PerformanceHelper.ts` |
-| Perf reporter     | `browser_tests/fixtures/utils/perfReporter.ts`        |
+| Perf reporter     | `browser_tests/helpers/perfReporter.ts`               |
 | CI workflow       | `.github/workflows/ci-perf-report.yaml`               |
 | Report generator  | `scripts/perf-report.ts`                              |
 | Stats utilities   | `scripts/perf-stats.ts`                               |

.claude/skills/red-green-fix/SKILL.md

@@ -95,7 +95,7 @@ Run the test locally before pushing to confirm it fails for the right reason:
 
 ```bash
 # Vitest
-pnpm test:unit <test-file>
+pnpm test:unit -- <test-file>
 
 # Playwright
 pnpm test:browser:local -- --grep "<test name>"

.claude/skills/red-green-fix/reference/testing-anti-patterns.md

@@ -169,7 +169,7 @@ expect(result).toBeDefined() // This proves nothing
 
 ```bash
 # Instead of fixing the code, just updating the snapshot to match buggy output
-pnpm test:unit --update
+pnpm test:unit -- --update
 ```
 
 If a snapshot needs updating, the fix should change the code behavior, not the expected output.

.claude/skills/reviewing-unit-tests/SKILL.md

@@ -1,156 +0,0 @@
----
-name: reviewing-unit-tests
-description: Use when reviewing Vitest unit-test diffs in ComfyUI_frontend, especially new mocks, store tests, component tests, or bugfix regression tests.
----
-
-# Reviewing Unit Tests for ComfyUI_frontend
-
-## Overview
-
-Review for behavior and current repo rules, not motion. Compare to authoritative rules, not prior diffs or legacy snippets.
-
-## Review Workflow
-
-1. Identify the test type: component, store, composable, util, or bugfix regression.
-2. Name the behavior the test proves. If you cannot say it in one sentence, request changes.
-3. Open the authoritative doc section before judging structure.
-4. Scan the red flags below.
-5. State the verdict first. Name the failure mode. Cite the doc or rule.
-
-## Source of Truth / Precedence
-
-When docs and examples conflict, use this order:
-
-1. Explicit repo rules, lint rules, and note blocks.
-2. [`docs/testing/vitest-patterns.md`](../../../docs/testing/vitest-patterns.md)
-3. Rule sections in [`docs/testing/unit-testing.md`](../../../docs/testing/unit-testing.md), [`docs/testing/store-testing.md`](../../../docs/testing/store-testing.md), and [`docs/testing/component-testing.md`](../../../docs/testing/component-testing.md)
-4. Example snippets
-5. Prior diffs
-
-Apply these repo-specific clarifications:
-
-- [`docs/testing/component-testing.md`](../../../docs/testing/component-testing.md) starts with the authoritative rule: new component tests use `@testing-library/vue` with `@testing-library/user-event`. The `@vue/test-utils` snippets below it are legacy examples.
-- [`docs/testing/store-testing.md`](../../../docs/testing/store-testing.md) still contains `as any` examples. Treat them as legacy snippets, not approval for new or edited test code.
-- If docs conflict, prefer the stricter newer rule and call out the doc ambiguity. Do not approve through it.
-- Motion != fix.
-
-## 30-Second Red Flags
-
-| If you see...                                                                             | Failure mode                    | Default action                                                |
-| ----------------------------------------------------------------------------------------- | ------------------------------- | ------------------------------------------------------------- |
-| New `@vue/test-utils` import in a new component test                                      | legacy test API                 | Request changes                                               |
-| `vi.mock('vue-i18n', ...)`                                                                | mocked i18n                     | Request changes                                               |
-| `as any`, `@ts-expect-error`, `as Mock`, `as ReturnType<typeof vi.fn>`, `as unknown as X` | unnecessary cast or type escape | Request changes unless the author proves no safer type exists |
-| `getXMock()`, renamed wrapper, or helper that only returns a mocked value                 | alias-by-renaming               | Request changes                                               |
-| `beforeEach` recreates the return object for a module-mocked composable or service        | shared mock setup drift         | Request changes                                               |
-| Assertions only check defaults, mock plumbing, or CSS hooks                               | non-behavioral test             | Request changes                                               |
-| Bugfix test has no proof it fails on pre-fix code                                         | unproven regression             | Request changes                                               |
-
-## Rationalization Table
-
-| Excuse                              | Reality                                                                                                |
-| ----------------------------------- | ------------------------------------------------------------------------------------------------------ |
-| "I restructured the mocks"          | If the indirection stayed, nothing improved. Flag `alias-by-renaming`.                                 |
-| "The docs do it"                    | Rule, note, and lint beat legacy snippet. Compare to the current rule, not the nearest example.        |
-| "TypeScript required the cast"      | `vi.mocked()` usually narrows mock methods. Assertion-only references need no cast.                    |
-| "Putting it in `beforeEach` is DRY" | Recreating module mock state in hooks hides singleton behavior and drifts from the documented pattern. |
-| "It is only a nit"                  | Explicit repo-rule violations are never nits.                                                          |
-| "No behavior changed, just cleanup" | Motion != fix. Ask what behavior got stronger.                                                         |
-| "Mental revert is enough"           | For bugfix tests, establish red on pre-fix code or ask the author to show it.                          |
-
-## Mocking Rules
-
-- Fail helpers that do not remove repeated setup, encode domain meaning, or simplify assertions. Barely earning the abstraction is not enough.
-- For composables with reactive or singleton state, define stable mock state inside the `vi.mock()` factory. Access it per test via the composable itself. See [`docs/testing/unit-testing.md`](../../../docs/testing/unit-testing.md) "Mocking Composables with Reactive State".
-- This does not ban local test data builders or per-test `vi.spyOn(...)`.
-- Mock seams, not the project-owned module you are trying to exercise. For store tests, prefer real Pinia plus `createTestingPinia({ stubActions: false })` per [`docs/testing/vitest-patterns.md`](../../../docs/testing/vitest-patterns.md) and [`docs/testing/store-testing.md`](../../../docs/testing/store-testing.md).
-
-### Alias-by-Renaming
-
-```ts
-// Before
-const mockAdd = vi.hoisted(() => vi.fn())
-
-// After: same indirection, new name
-function getToastAddMock() {
-  return useToast().add
-}
-```
-
-If the wrapper only renames or relays a mocked value, fail it. Inline the lookup at the call site or fetch the singleton mock via the documented pattern.
-
-### `vi.mocked()` Scope
-
-| Use case                                                        | `vi.mocked()` required? |
-| --------------------------------------------------------------- | ----------------------- |
-| `.mockReturnValue`, `.mockResolvedValue`, `.mockImplementation` | Yes                     |
-| `.mock.calls`, `.mock.results`                                  | Yes                     |
-| `expect(fn).toHaveBeenCalled()`                                 | No                      |
-| `expect(fn).toHaveBeenCalledWith(...)`                          | No                      |
-
-- Flag casts whenever `vi.mocked()` would narrow correctly.
-- Do not add `vi.mocked()` around assertion-only references just for style.
-
-### Reset Hygiene
-
-- Flag per-mock `mockClear()` or `mockReset()` when `vi.clearAllMocks()` or `vi.resetAllMocks()` already runs in the relevant hook chain.
-- Review for redundancy or broken state management. Do not bikeshed `clearAllMocks` vs `resetAllMocks` unless behavior depends on it.
-
-### Third-Party Seams
-
-- Distinguish trivial hooks from behavior-rich APIs.
-- Mocking single-method third-party hooks like `primevue/usetoast` is usually acceptable.
-- That exception does not justify mocking behavior-rich third-party modules.
-
-### `vue-i18n`
-
-- Never mock `vue-i18n` in component tests.
-- Use real `createI18n` per [`docs/testing/vitest-patterns.md`](../../../docs/testing/vitest-patterns.md) and the shared [`testI18n`](../../../src/components/searchbox/v2/__test__/testUtils.ts) setup.
-
-## Test-Body Rules
-
-| Smell                                                             | Review bar                                                                                                                                    |
-| ----------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------- |
-| Change-detector test                                              | Reject. Default values alone prove nothing.                                                                                                   |
-| Mock-only assertion                                               | Accept collaborator-call assertions only when the call is the meaningful external effect and the test also exercises the triggering behavior. |
-| Non-behavioral assertion                                          | Reject tests that only check classes, utility hooks, or styling internals.                                                                    |
-| New component test using `@vue/test-utils`                        | Request changes. Use `@testing-library/vue` plus `@testing-library/user-event`.                                                               |
-| `any`, `as any`, or `@ts-expect-error` in new or edited test code | Request changes unless the author proves no safer type exists. Legacy doc snippets do not authorize it.                                       |
-
-## Bugfix Regression Proof
-
-For `fix:` PRs or bugfix diffs:
-
-1. Identify the production change that fixes the bug.
-2. Verify the new test fails on pre-fix code, or ask the author to show it.
-3. If the test passes on broken code, request changes.
-
-A regression test that never proves red does not pin the bug.
-
-## Review Output Rules
-
-- State verdict before procedural questions.
-- Do not lead with approval language like `LGTM, just one nit` or `approve and move on?`.
-- Name the failure mode directly: `alias-by-renaming`, `unnecessary cast`, `mocked i18n`, `mock-only assertion`, `unproven regression`.
-- Link the authoritative doc section in the review comment.
-- If an explicit repo rule, lint rule, or authoritative doc note is violated, do not downgrade it to "minor deviation" or "nit".
-
-## Quick Reference
-
-| When you see...                     | Read this                                                                                                                                                                                         |
-| ----------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| New `vi.mock(...)` for a composable | [`docs/testing/unit-testing.md`](../../../docs/testing/unit-testing.md) -> "Mocking Composables with Reactive State"                                                                              |
-| New store test or store mock        | [`docs/testing/vitest-patterns.md`](../../../docs/testing/vitest-patterns.md) setup + [`docs/testing/store-testing.md`](../../../docs/testing/store-testing.md)                                   |
-| New component test                  | Top note in [`docs/testing/component-testing.md`](../../../docs/testing/component-testing.md)                                                                                                     |
-| `vue-i18n` in a component test      | [`docs/testing/vitest-patterns.md`](../../../docs/testing/vitest-patterns.md) + [`src/components/searchbox/v2/__test__/testUtils.ts`](../../../src/components/searchbox/v2/__test__/testUtils.ts) |
-| Cast around a mock                  | [`docs/guidance/typescript.md`](../../../docs/guidance/typescript.md) -> "Type Assertion Hierarchy"                                                                                               |
-
-## Key Files to Read
-
-| Purpose                              | Path                                                                                                              |
-| ------------------------------------ | ----------------------------------------------------------------------------------------------------------------- |
-| Composable mocking patterns          | [`docs/testing/unit-testing.md`](../../../docs/testing/unit-testing.md)                                           |
-| Store testing patterns               | [`docs/testing/store-testing.md`](../../../docs/testing/store-testing.md)                                         |
-| Repo-wide Vitest setup defaults      | [`docs/testing/vitest-patterns.md`](../../../docs/testing/vitest-patterns.md)                                     |
-| Component testing rule for new tests | [`docs/testing/component-testing.md`](../../../docs/testing/component-testing.md)                                 |
-| Real i18n setup                      | [`src/components/searchbox/v2/__test__/testUtils.ts`](../../../src/components/searchbox/v2/__test__/testUtils.ts) |

.claude/skills/ticket-intake/SKILL.md

@@ -0,0 +1,361 @@
+---
+name: ticket-intake
+description: 'Parse ticket URL (Notion or GitHub), extract all data, initialize pipeline run. Use when starting work on a new ticket or when asked to pick up a ticket.'
+---
+
+# Ticket Intake
+
+Parses a ticket URL from supported sources (Notion or GitHub), extracts all relevant information, and creates a ticket in the pipeline API.
+
+> **🚨 CRITICAL REQUIREMENT**: This skill MUST register the ticket in the Pipeline API and update the source (Notion/GitHub). If these steps are skipped, the entire pipeline breaks. See [Mandatory API Calls](#mandatory-api-calls-execute-all-three) below.
+
+## Supported Sources
+
+| Source | URL Pattern                                         | Provider File         |
+| ------ | --------------------------------------------------- | --------------------- |
+| Notion | `https://notion.so/...` `https://www.notion.so/...` | `providers/notion.md` |
+| GitHub | `https://github.com/{owner}/{repo}/issues/{n}`      | `providers/github.md` |
+
+## Quick Start
+
+When given a ticket URL:
+
+1. **Detect source type** from URL pattern
+2. **Load provider-specific logic** from `providers/` directory
+3. Fetch ticket content via appropriate API
+4. Extract and normalize properties to common schema
+5. **Register ticket in pipeline API** ← MANDATORY
+6. **Update source** (Notion status / GitHub comment) ← MANDATORY
+7. **Run verification script** to confirm API registration
+8. Output summary and handoff to `research-orchestrator`
+
+## Configuration
+
+Uses the **production API** by default. No configuration needed for read operations.
+
+**Defaults (no setup required):**
+
+- API URL: `https://api-gateway-856475788601.us-central1.run.app`
+- Read-only endpoints at `/public/*` require no authentication
+
+**For write operations** (transitions, creating tickets), set:
+
+```bash
+export PIPELINE_API_KEY="..."  # Get from GCP Secret Manager or ask admin
+```
+
+**Optional (for local working artifacts):**
+
+```bash
+PIPELINE_DIR="${PIPELINE_DIR:-$HOME/repos/ticket-to-pr-pipeline}"
+```
+
+## Mandatory API Calls (Execute ALL Three)
+
+**⚠️ These three API calls are the ENTIRE POINT of this skill. Without them, the ticket is invisible to the pipeline, downstream skills will fail, and Notion status won't update.**
+
+**You MUST make these HTTP requests.** Use `curl` from bash — do not just read this as documentation.
+
+### Call 1: Create Ticket
+
+```bash
+API_URL="${PIPELINE_API_URL:-https://api-gateway-856475788601.us-central1.run.app}"
+API_KEY="${PIPELINE_API_KEY}"
+
+curl -s -X POST "${API_URL}/v1/tickets" \
+  -H "Authorization: Bearer ${API_KEY}" \
+  -H "Content-Type: application/json" \
+  -H "X-Agent-ID: ${AGENT_ID:-amp-agent}" \
+  -d '{
+    "notion_page_id": "NOTION_PAGE_UUID_HERE",
+    "title": "TICKET_TITLE_HERE",
+    "source": "notion",
+    "metadata": {
+      "description": "DESCRIPTION_HERE",
+      "priority": "High",
+      "labels": [],
+      "acceptanceCriteria": []
+    }
+  }'
+```
+
+Save the returned `id` — you need it for the next two calls.
+
+### Call 2: Transition to RESEARCH
+
+```bash
+TICKET_ID="id-from-step-1"
+
+curl -s -X POST "${API_URL}/v1/tickets/${TICKET_ID}/transition" \
+  -H "Authorization: Bearer ${API_KEY}" \
+  -H "Content-Type: application/json" \
+  -H "X-Agent-ID: ${AGENT_ID:-amp-agent}" \
+  -d '{
+    "to_state": "RESEARCH",
+    "reason": "Intake complete, starting research"
+  }'
+```
+
+### Call 3: Queue Source Update
+
+```bash
+curl -s -X POST "${API_URL}/v1/sync/queue" \
+  -H "Authorization: Bearer ${API_KEY}" \
+  -H "Content-Type: application/json" \
+  -H "X-Agent-ID: ${AGENT_ID:-amp-agent}" \
+  -d '{
+    "ticket_id": "TICKET_ID_HERE",
+    "action": "update_status",
+    "payload": { "status": "In Progress" },
+    "priority": "normal"
+  }'
+```
+
+> **Note:** The action MUST be `"update_status"` (not `"UPDATE_NOTION_STATUS"`). Valid actions: `update_status`, `update_pr_url`, `mark_done`.
+
+### TypeScript Equivalent (if using pipeline client)
+
+```typescript
+import { PipelineClient } from '@pipeline/client'
+
+const client = new PipelineClient({
+  apiUrl:
+    process.env.PIPELINE_API_URL ||
+    'https://api-gateway-856475788601.us-central1.run.app',
+  agentId: process.env.AGENT_ID!
+})
+
+const ticket = await client.createTicket({
+  notion_page_id: pageId,
+  title: ticketTitle,
+  source: 'notion',
+  metadata: { description, priority, labels, acceptanceCriteria }
+})
+
+await client.transitionState(
+  ticket.id,
+  'RESEARCH',
+  'Intake complete, starting research'
+)
+
+await client.queueSync(ticket.id, 'update_status', { status: 'In Progress' })
+```
+
+## Workflow
+
+### Step 1: Detect Source Type
+
+Parse the URL to determine source:
+
+```javascript
+if (url.includes('notion.so')) {
+  source = 'notion'
+  // Load providers/notion.md
+} else if (url.match(/github\.com\/[^\/]+\/[^\/]+\/issues\/\d+/)) {
+  source = 'github'
+  // Load providers/github.md
+} else {
+  // Error: Unsupported URL format
+}
+```
+
+### Step 2: Load Provider and Fetch Data
+
+Read the appropriate provider file for source-specific instructions:
+
+- **Notion**: `providers/notion.md` - Uses Notion MCP, handles Slack links
+- **GitHub**: `providers/github.md` - Uses `gh` CLI, handles Dosu comments
+
+Follow the provider's instructions for:
+
+- Fetching content
+- Extracting properties
+- **Updating the source** (Notion status → "In Progress", Assignee → pipeline owner)
+
+### Step 3: Normalize to Common Schema
+
+All providers must extract normalized ticket data following `schema.md`:
+
+```json
+{
+  "id": "abc12345",
+  "url": "https://...",
+  "source": "notion | github",
+  "title": "Ticket title",
+  "description": "Full description",
+  "status": "Not Started",
+  "assignee": "username",
+  "priority": "High",
+  "area": "UI",
+  "labels": ["bug", "frontend"],
+  "acceptanceCriteria": ["Criterion 1", "Criterion 2"],
+  "fetchedAt": "2024-01-15T10:30:00Z"
+}
+```
+
+### Step 4: Register Ticket in Pipeline API (MANDATORY — DO NOT SKIP)
+
+**Execute all three API calls from [Mandatory API Calls](#mandatory-api-calls-execute-all-three) above.**
+
+This is not optional. This is not documentation. You MUST make these HTTP requests right now.
+
+1. `createTicket()` → save the returned ticket ID
+2. `transitionState(id, 'RESEARCH')` → confirm state changed
+3. `queueSync(id, 'update_status', { status: 'In Progress' })` → confirm queued
+
+**If any call fails**, retry once. If it still fails, report the error prominently — do NOT silently continue.
+
+### Step 5: Run Verification Script
+
+After making the API calls, run the verification script to confirm everything worked:
+
+```bash
+bash scripts/verify-intake.sh TICKET_ID_OR_NOTION_PAGE_ID
+```
+
+**If the script is not available locally**, verify manually via the public API:
+
+```bash
+curl -s "${API_URL}/public/tickets/${TICKET_ID}" | jq '{id, state, title, notion_page_id}'
+```
+
+Expected output:
+
+```json
+{
+  "id": "...",
+  "state": "RESEARCH",
+  "title": "...",
+  "notion_page_id": "..."
+}
+```
+
+**If `state` is not `RESEARCH`, go back to Step 4 and complete the missing calls.**
+
+### Step 6: Output Summary and Handoff
+
+Print a clear summary:
+
+```markdown
+## Ticket Intake Complete
+
+**Source:** Notion | GitHub
+**Title:** [Ticket title]
+**ID:** abc12345
+**Status:** In Progress (queued)
+**Priority:** High
+**Area:** UI
+
+### Description
+
+[Brief description or first 200 chars]
+
+### Acceptance Criteria
+
+- [ ] Criterion 1
+- [ ] Criterion 2
+
+### Links
+
+- **Ticket:** [Original URL]
+- **Slack:** [Slack thread content fetched via slackdump] (Notion only)
+
+### Pipeline
+
+- **API Ticket ID:** abc12345
+- **State:** RESEARCH
+- **Verified:** ✅ (via verify-intake.sh or public API)
+```
+
+**After printing the summary, immediately handoff** to continue the pipeline. Use the `handoff` tool with all necessary context (ticket ID, source, title, description, slack context if any):
+
+> **Handoff goal:** "Continue pipeline for ticket {ID} ({title}). Ticket is in RESEARCH state. Load skill: `research-orchestrator` to begin research phase. Ticket data: source={source}, notion_page_id={pageId}, priority={priority}. {slack context summary if available}"
+
+**Do NOT wait for human approval to proceed.** The intake phase is complete — handoff immediately.
+
+## Error Handling
+
+### Unsupported URL
+
+```
+❌ Unsupported ticket URL format.
+
+Supported formats:
+- Notion: https://notion.so/... or https://www.notion.so/...
+- GitHub: https://github.com/{owner}/{repo}/issues/{number}
+
+Received: [provided URL]
+```
+
+### Provider-Specific Errors
+
+See individual provider files for source-specific error handling:
+
+- `providers/notion.md` - Authentication, page not found
+- `providers/github.md` - Auth, rate limits, issue not found
+
+### Missing Properties
+
+Continue with available data and note what's missing:
+
+```
+⚠️ Some properties unavailable:
+- Priority: not found (using default: Medium)
+- Area: not found
+
+Proceeding with available data...
+```
+
+### API Call Failures
+
+```
+❌ Pipeline API call failed: {method} {endpoint}
+   Status: {status}
+   Error: {message}
+
+Retrying once...
+
+❌ Retry also failed. INTAKE IS INCOMPLETE.
+   The ticket was NOT registered in the pipeline.
+   Downstream skills will not work until this is fixed.
+```
+
+## Notes
+
+- This skill focuses ONLY on intake — it does not do research
+- Slack thread content is fetched automatically via the `slackdump` skill — no manual copy-paste needed
+- ALL API calls (createTicket, transitionState, queueSync) are MANDATORY — never skip them
+- The `queueSync` action must be `"update_status"`, NOT `"UPDATE_NOTION_STATUS"`
+- Pipeline state is tracked via the API, not local files
+- Working artifacts (research-report.md, plan.md) can be saved locally to `$PIPELINE_DIR/runs/{ticket-id}/`
+- The `source` field in the ticket determines which research strategies to use
+
+## API Client Reference
+
+### Available Methods
+
+| Method                                                      | Description                                                         |
+| ----------------------------------------------------------- | ------------------------------------------------------------------- |
+| `createTicket({ notion_page_id, title, source, metadata })` | Create a new ticket in the API                                      |
+| `getTicket(id)`                                             | Retrieve a ticket by ID                                             |
+| `findByNotionId(notionPageId)`                              | Look up a ticket by its Notion page ID                              |
+| `listTickets({ state, agent_id, limit, offset })`           | List tickets with optional filters                                  |
+| `transitionState(id, state, reason)`                        | Move ticket to a new state (e.g., `'RESEARCH'`)                     |
+| `setPRCreated(id, prUrl)`                                   | Mark ticket as having a PR created                                  |
+| `queueSync(id, action, payload)`                            | Queue a sync action (`update_status`, `update_pr_url`, `mark_done`) |
+| `registerBranch(id, branch, repo)`                          | Register working branch for automatic PR detection                  |
+
+### Error Handling
+
+```typescript
+import { PipelineClient, PipelineAPIError } from '@pipeline/client';
+
+try {
+  await client.createTicket({ ... });
+} catch (error) {
+  if (error instanceof PipelineAPIError) {
+    console.error(`API Error ${error.status}: ${error.message}`);
+  }
+  throw error;
+}
+```

.claude/skills/ticket-intake/providers/github.md

@@ -0,0 +1,194 @@
+# GitHub Provider - Ticket Intake
+
+Provider-specific logic for ingesting tickets from GitHub Issues.
+
+## URL Pattern
+
+```
+https://github.com/{owner}/{repo}/issues/{number}
+https://www.github.com/{owner}/{repo}/issues/{number}
+```
+
+Extract: `owner`, `repo`, `issue_number` from URL.
+
+## Prerequisites
+
+- `gh` CLI authenticated (`gh auth status`)
+- Access to the repository
+
+## Fetch Issue Content
+
+Use `gh` CLI to fetch issue details:
+
+```bash
+# Get issue details in JSON
+gh issue view {number} --repo {owner}/{repo} --json title,body,state,labels,assignees,milestone,author,createdAt,comments,linkedPRs
+
+# Get comments separately if needed
+gh issue view {number} --repo {owner}/{repo} --comments
+```
+
+## Extract Ticket Data
+
+Map GitHub issue fields to normalized ticket data (stored via API):
+
+| GitHub Field | ticket.json Field | Notes                      |
+| ------------ | ----------------- | -------------------------- |
+| title        | title             | Direct mapping             |
+| body         | description       | Issue body/description     |
+| state        | status            | Map: open → "Not Started"  |
+| labels       | labels            | Array of label names       |
+| assignees    | assignee          | First assignee login       |
+| author       | author            | Issue author login         |
+| milestone    | milestone         | Milestone title if present |
+| comments     | comments          | Array of comment objects   |
+| linkedPRs    | linkedPRs         | PRs linked to this issue   |
+
+### Priority Mapping
+
+Infer priority from labels:
+
+- `priority:critical`, `P0` → "Critical"
+- `priority:high`, `P1` → "High"
+- `priority:medium`, `P2` → "Medium"
+- `priority:low`, `P3` → "Low"
+- No priority label → "Medium" (default)
+
+### Area Mapping
+
+Infer area from labels:
+
+- `area:ui`, `frontend`, `component:*` → "UI"
+- `area:api`, `backend` → "API"
+- `area:docs`, `documentation` → "Docs"
+- `bug`, `fix` → "Bug"
+- `enhancement`, `feature` → "Feature"
+
+## Update Source
+
+**For GitHub issues, update is optional but recommended.**
+
+Add a comment to indicate work has started:
+
+```bash
+gh issue comment {number} --repo {owner}/{repo} --body "🤖 Pipeline started processing this issue."
+```
+
+Optionally assign to self:
+
+```bash
+gh issue edit {number} --repo {owner}/{repo} --add-assignee @me
+```
+
+Log any updates via the Pipeline API:
+
+```typescript
+await client.updateTicket(ticketId, {
+  metadata: {
+    ...ticket.metadata,
+    githubWrites: [
+      ...(ticket.metadata?.githubWrites || []),
+      {
+        action: 'comment',
+        issueNumber: 123,
+        at: new Date().toISOString(),
+        skill: 'ticket-intake',
+        success: true
+      }
+    ]
+  }
+})
+```
+
+## GitHub-Specific Ticket Fields
+
+Store via API using `client.createTicket()`:
+
+```json
+{
+  "source": "github",
+  "githubOwner": "Comfy-Org",
+  "githubRepo": "ComfyUI_frontend",
+  "githubIssueNumber": 123,
+  "githubIssueUrl": "https://github.com/Comfy-Org/ComfyUI_frontend/issues/123",
+  "labels": ["bug", "area:ui", "priority:high"],
+  "linkedPRs": [456, 789],
+  "dosuComment": "..." // Extracted Dosu bot analysis if present
+}
+```
+
+## Dosu Bot Detection
+
+Many repositories use Dosu bot for automated issue analysis. Check comments for Dosu:
+
+```bash
+gh issue view {number} --repo {owner}/{repo} --comments | grep -A 100 "dosu"
+```
+
+Look for comments from:
+
+- `dosu[bot]`
+- `dosu-bot`
+
+Extract Dosu analysis which typically includes:
+
+- Root cause analysis
+- Suggested files to modify
+- Related issues/PRs
+- Potential solutions
+
+Store in ticket data via API:
+
+```json
+{
+  "dosuComment": {
+    "found": true,
+    "analysis": "...",
+    "suggestedFiles": ["src/file1.ts", "src/file2.ts"],
+    "relatedIssues": [100, 101]
+  }
+}
+```
+
+## Extract Linked Issues/PRs
+
+Parse issue body and comments for references:
+
+- `#123` → Issue or PR reference
+- `fixes #123`, `closes #123` → Linked issue
+- `https://github.com/.../issues/123` → Full URL reference
+
+Store in ticket data via API for research phase:
+
+```json
+{
+  "referencedIssues": [100, 101, 102],
+  "referencedPRs": [200, 201]
+}
+```
+
+## Error Handling
+
+### Authentication Error
+
+```
+⚠️ GitHub CLI not authenticated.
+Run: gh auth login
+```
+
+### Issue Not Found
+
+```
+❌ GitHub issue not found or inaccessible.
+- Check the URL is correct
+- Ensure you have access to this repository
+- Run: gh auth status
+```
+
+### Rate Limiting
+
+```
+⚠️ GitHub API rate limited.
+Wait a few minutes and try again.
+Check status: gh api rate_limit
+```

.claude/skills/ticket-intake/providers/notion.md

@@ -0,0 +1,202 @@
+# Notion Provider - Ticket Intake
+
+Provider-specific logic for ingesting tickets from Notion.
+
+## URL Pattern
+
+```
+https://www.notion.so/workspace/Page-Title-abc123def456...
+https://notion.so/Page-Title-abc123def456...
+https://www.notion.so/abc123def456...
+```
+
+Page ID is the 32-character hex string (with or without hyphens).
+
+## Prerequisites
+
+- Notion MCP connected and authenticated
+- If not setup: `claude mcp add --transport http notion https://mcp.notion.com/mcp`
+- Authenticate via `/mcp` command if prompted
+
+## Fetch Ticket Content
+
+Use `Notion:notion-fetch` with the page URL or ID:
+
+```
+Fetch the full page content including all properties
+```
+
+## Extract Ticket Data
+
+Extract these properties (names may vary):
+
+| Property      | Expected Name             | Type         |
+| ------------- | ------------------------- | ------------ |
+| Title         | Name / Title              | Title        |
+| Status        | Status                    | Select       |
+| Assignee      | Assignee / Assigned To    | Person       |
+| Description   | -                         | Page content |
+| Slack Link    | Slack Link / Slack Thread | URL          |
+| GitHub PR     | GitHub PR / PR Link       | URL          |
+| Priority      | Priority                  | Select       |
+| Area          | Area / Category           | Select       |
+| Related Tasks | Related Tasks             | Relation     |
+
+**If properties are missing**: Note what's unavailable and continue with available data.
+
+## Update Source (REQUIRED)
+
+**⚠️ DO NOT SKIP THIS STEP. This is a required action, not optional.**
+
+**⚠️ Notion Write Safety rules apply (see `$PIPELINE_DIR/docs/notion-write-safety.md` for full reference):**
+
+- **Whitelist**: Only `Status`, `GitHub PR`, and `Assignee` fields may be written
+- **Valid transitions**: Not Started → In Progress, In Progress → In Review, In Review → Done
+- **Logging**: Every write attempt MUST be logged with timestamp, field, value, previous value, skill name, and success status
+
+Use `Notion:notion-update-page` to update the ticket:
+
+1. **Status**: Set to "In Progress" (only valid from "Not Started")
+2. **Assignee**: Assign to pipeline owner (Notion ID: `175d872b-594c-81d4-ba5a-0002911c5966`)
+
+```json
+{
+  "page_id": "{page_id_from_ticket}",
+  "command": "update_properties",
+  "properties": {
+    "Status": "In Progress",
+    "Assignee": "175d872b-594c-81d4-ba5a-0002911c5966"
+  }
+}
+```
+
+**After the update succeeds**, log the write via the Pipeline API:
+
+```typescript
+await client.updateTicket(ticketId, {
+  metadata: {
+    ...ticket.metadata,
+    notionWrites: [
+      ...(ticket.metadata?.notionWrites || []),
+      {
+        field: 'Status',
+        value: 'In Progress',
+        previousValue: 'Not Started',
+        at: new Date().toISOString(),
+        skill: 'ticket-intake',
+        success: true
+      }
+    ]
+  }
+})
+```
+
+If update fails, log with `success: false` and continue.
+
+## Notion-Specific Ticket Fields
+
+Store via API using `client.createTicket()`:
+
+```json
+{
+  "source": "notion",
+  "notionPageId": "abc123def456...",
+  "slackLink": "https://slack.com/...",
+  "relatedTasks": ["page-id-1", "page-id-2"]
+}
+```
+
+## Slack Thread Handling
+
+If a Slack link exists, use the `slackdump` skill to fetch the thread content programmatically.
+
+### Slack URL Conversion
+
+Notion stores Slack links in `slackMessage://` format:
+
+```
+slackMessage://comfy-organization.slack.com/CHANNEL_ID/THREAD_TS/MESSAGE_TS
+```
+
+Convert to browser-clickable format:
+
+```
+https://comfy-organization.slack.com/archives/CHANNEL_ID/pMESSAGE_TS_NO_DOT
+```
+
+**Example:**
+
+- Input: `slackMessage://comfy-organization.slack.com/C075ANWQ8KS/1766022478.450909/1764772881.854829`
+- Output: `https://comfy-organization.slack.com/archives/C075ANWQ8KS/p1764772881854829`
+
+(Remove the dot from the last timestamp and prefix with `p`)
+
+### Fetching Thread Content
+
+Load the `slackdump` skill and use the **export-thread** workflow:
+
+```bash
+# Export thread by URL
+slackdump dump "https://comfy-organization.slack.com/archives/CHANNEL_ID/pMESSAGE_TS"
+
+# Or by colon notation (channel_id:thread_ts)
+slackdump dump CHANNEL_ID:THREAD_TS
+```
+
+Save the thread content to `$RUN_DIR/slack-context.md` and include it in the ticket metadata.
+
+> **No manual action required.** The slackdump CLI handles authentication via stored credentials at `~/.cache/slackdump/comfy-organization.bin`.
+
+## Database Reference: Comfy Tasks
+
+The "Comfy Tasks" database has these properties (verify via `notion-search`):
+
+- **Status values**: Not Started, In Progress, In Review, Done
+- **Team assignment**: "Frontend Team" for unassigned tickets
+- **Filtering note**: Team filtering in Notion may have quirks - handle gracefully
+
+### Pipeline Owner Details
+
+When assigning tickets, use these identifiers:
+
+| Platform        | Identifier                             |
+| --------------- | -------------------------------------- |
+| Notion User ID  | `175d872b-594c-81d4-ba5a-0002911c5966` |
+| Notion Name     | Christian Byrne                        |
+| Notion Email    | cbyrne@comfy.org                       |
+| Slack User ID   | U087MJCDHHC                            |
+| GitHub Username | christian-byrne                        |
+
+**To update Assignee**, use the Notion User ID (not name):
+
+```
+properties: {"Assignee": "175d872b-594c-81d4-ba5a-0002911c5966"}
+```
+
+### Finding Active Tickets
+
+To list your active tickets:
+
+```
+Use Notion:notion-search for "Comfy Tasks"
+Filter by Assignee = current user OR Team = "Frontend Team"
+```
+
+## Error Handling
+
+### Authentication Error
+
+```
+⚠️ Notion authentication required.
+Run: claude mcp add --transport http notion https://mcp.notion.com/mcp
+Then authenticate via /mcp command.
+```
+
+### Page Not Found
+
+```
+❌ Notion page not found or inaccessible.
+- Check the URL is correct
+- Ensure you have access to this page
+- Try re-authenticating via /mcp
+```

.claude/skills/ticket-intake/schema.md

@@ -0,0 +1,81 @@
+# Ticket Schema
+
+Common schema for normalized ticket data across all sources. This data is stored and retrieved via the Pipeline API, not local files.
+
+## Ticket Data Schema
+
+```json
+{
+  // Required fields (all sources)
+  "id": "string", // Unique identifier (short form)
+  "url": "string", // Original URL
+  "source": "notion | github", // Source type
+  "title": "string", // Ticket title
+  "description": "string", // Full description/body
+  "fetchedAt": "ISO8601", // When ticket was fetched
+
+  // Common optional fields
+  "status": "string", // Current status
+  "assignee": "string", // Assigned user
+  "priority": "string", // Priority level
+  "area": "string", // Category/area
+  "labels": ["string"], // Tags/labels
+  "acceptanceCriteria": ["string"] // List of AC items
+
+  // Source-specific fields (see providers)
+  // Notion: notionPageId, slackLink, relatedTasks, notionWrites
+  // GitHub: githubOwner, githubRepo, githubIssueNumber, linkedPRs, dosuComment, referencedIssues
+}
+```
+
+## Ticket State Schema (via API)
+
+State is managed via the Pipeline API using `client.transitionState()`:
+
+```json
+{
+  "ticketId": "string",
+  "state": "intake | research | planning | implementation | pr_created | done | failed",
+  "stateChangedAt": "ISO8601",
+
+  // Timestamps tracked by API
+  "createdAt": "ISO8601",
+  "updatedAt": "ISO8601"
+}
+```
+
+## Priority Normalization
+
+All sources should normalize to these values:
+
+| Normalized | Description               |
+| ---------- | ------------------------- |
+| Critical   | Production down, security |
+| High       | Blocking work, urgent     |
+| Medium     | Normal priority (default) |
+| Low        | Nice to have, backlog     |
+
+## Status Normalization
+
+Pipeline tracks these statuses internally:
+
+| Status         | Description                  |
+| -------------- | ---------------------------- |
+| research       | Gathering context            |
+| planning       | Creating implementation plan |
+| implementation | Writing code                 |
+| review         | Code review in progress      |
+| qa             | Quality assurance            |
+| done           | PR merged or completed       |
+
+## ID Generation
+
+IDs are generated by the API when creating tickets. For reference:
+
+- **Notion**: First 8 characters of page ID
+- **GitHub**: `gh-{owner}-{repo}-{issue_number}` (sanitized)
+
+Examples:
+
+- Notion: `abc12345`
+- GitHub: `gh-comfy-org-frontend-123`

.claude/skills/writing-playwright-tests/SKILL.md

@@ -114,7 +114,7 @@ await expect(async () => {
 ## CI Debugging
 
 1. Download artifacts from failed CI run
-2. Extract and view trace: `pnpm dlx playwright show-trace trace.zip`
+2. Extract and view trace: `npx playwright show-trace trace.zip`
 3. CI deploys HTML report to Cloudflare Pages (link in PR comment)
 4. Reproduce CI: `CI=true pnpm test:browser`
 5. Local runs: `pnpm test:browser:local`

.coderabbit.yaml

@@ -2,7 +2,6 @@ issue_enrichment:
   auto_enrich:
     enabled: true
 reviews:
-  profile: assertive
   high_level_summary: false
   request_changes_workflow: true
   auto_review:
@@ -16,35 +15,19 @@ reviews:
       - github-actions[bot]
   pre_merge_checks:
     override_requested_reviewers_only: true
-    # Explicitly disable the built-in docstring coverage check, which is
-    # enabled via organization-level settings. This repo opts out at the
-    # repo level without affecting other org repos.
-    docstrings:
-      mode: 'off'
     custom_checks:
       - name: End-to-end regression coverage for fixes
         mode: error
         instructions: |
-          Use only PR metadata already available in the review context:
-            - the PR title
-            - commit subjects in this PR
-            - The files changed in this PR relative to the PR base (equivalent to `base...head`)
-            - the PR description.
-          Do not rely on shell commands.
-          Do not inspect reverse diffs, files changed only on the base branch, or files outside this PR.
-          If the changed-file list or commit subjects are unavailable, mark the check inconclusive instead of guessing.
+          Use only PR metadata already available in the review context: the PR title, commit subjects in this PR, the files changed in this PR relative to the PR base (equivalent to `base...head`), and the PR description.
+          Do not rely on shell commands. Do not inspect reverse diffs, files changed only on the base branch, or files outside this PR. If the changed-file list or commit subjects are unavailable, mark the check inconclusive instead of guessing.
 
-          Fail if all of the following are true:
-          1. The PR title and/or any commit subject in the PR uses bug-fix language such as `fix`, `fixed`, `fixes`, `fixing`, `bugfix`, or `hotfix`.
-          2. The PR changes files under `src/` or `packages/` related to the main frontend application but the PR does not change at least one file under `browser_tests/`.
-          3. The PR description lacks a concrete explanation of why an end-to-end regression test was not added.
-
-          Do not fail if the changes are exclusively in `apps/website`, just documentation changes, or changes related to CI processes.
-          The goal is to make sure that fixes include End-to-End regression tests. Do not insist on tests when the PR is not fixing a bug.
-
-          Pass otherwise.
-          When failing, mention which bug-fix signal you found and ask the author to either add or update a Playwright regression test under `browser_tests/` or add a concrete explanation in the PR description of why an end-to-end regression test is not practical.
+          Pass if at least one of the following is true:
+          1. Neither the PR title nor any commit subject in the PR uses bug-fix language such as `fix`, `fixed`, `fixes`, `fixing`, `bugfix`, or `hotfix`.
+          2. The PR changes at least one file under `browser_tests/`.
+          3. The PR description includes a concrete, non-placeholder explanation of why an end-to-end regression test was not added.
 
+          Fail otherwise. When failing, mention which bug-fix signal you found and ask the author to either add or update a Playwright regression test under `browser_tests/` or add a concrete explanation in the PR description of why an end-to-end regression test is not practical.
       - name: ADR compliance for entity/litegraph changes
         mode: warning
         instructions: |
@@ -63,14 +46,3 @@ reviews:
           Pass if none of these patterns are found in the diff.
 
           When warning, reference the specific ADR by number and link to `docs/adr/` for context. Frame findings as directional guidance since ADR 0003 and 0008 are in Proposed status.
-
-  path_instructions:
-    - path: '**/*.test.ts'
-      instructions: |
-        Treat `.agents/checks/test-quality.md`, `docs/testing/README.md`, and `docs/guidance/vitest.md` as required review context for every changed Vitest test file.
-    - path: 'src/lib/litegraph/**/*.test.ts'
-      instructions: |
-        Treat `.agents/checks/test-quality.md`, `docs/testing/README.md`, `docs/guidance/vitest.md`, and `docs/testing/litegraph-testing.md` as required review context for every changed litegraph Vitest test file.
-    - path: '{browser_tests,apps/website/e2e}/**/*.spec.ts'
-      instructions: |
-        Treat `.agents/checks/test-quality.md`, `docs/testing/README.md`, and `docs/guidance/playwright.md` as required review context for every changed Playwright test file.

.editorconfig

@@ -1,12 +0,0 @@
-root = true
-
-[*]
-indent_style = space
-indent_size = 2
-end_of_line = lf
-charset = utf-8
-trim_trailing_whitespace = true
-insert_final_newline = true
-
-[*.md]
-trim_trailing_whitespace = false

.env_example

@@ -41,18 +41,8 @@ ALGOLIA_API_KEY=684d998c36b67a9a9fce8fc2d8860579
 # Enable PostHog debug logging in the browser console.
 # VITE_POSTHOG_DEBUG=true
 
-# Override staging comfy-api / comfy-platform base URLs.
-# VITE_STAGING_API_BASE_URL=https://stagingapi.comfy.org
-# VITE_STAGING_PLATFORM_BASE_URL=https://stagingplatform.comfy.org
-
 # Sentry ENV vars replace with real ones for debugging
 # SENTRY_AUTH_TOKEN=private-token # get from sentry
 # SENTRY_ORG=comfy-org
 # SENTRY_PROJECT=cloud-frontend-staging
 # SENTRY_PROJECT_PROD= # prod project slug for sourcemap uploads
-
-# Ashby (apps/website careers page build).
-# Server-only; read inside the Astro build context. Do NOT prefix with PUBLIC_.
-# When unset, the committed snapshot at apps/website/src/data/ashby-roles.snapshot.json is used.
-# WEBSITE_ASHBY_API_KEY=
-# WEBSITE_ASHBY_JOB_BOARD_NAME=comfy-org

.github/actions/ashby-pull/action.yaml

@@ -1,23 +0,0 @@
-name: Ashby Pull
-description: 'Refresh the apps/website Ashby roles snapshot from the Ashby job board API'
-inputs:
-  api_key:
-    description: 'Ashby API key (WEBSITE_ASHBY_API_KEY).'
-    required: true
-  job_board_name:
-    description: 'Ashby job board name (WEBSITE_ASHBY_JOB_BOARD_NAME).'
-    required: true
-runs:
-  using: 'composite'
-  steps:
-    # Note: this action assumes the frontend repo is checked out at the workspace root.
-
-    - name: Setup frontend
-      uses: ./.github/actions/setup-frontend
-
-    - name: Refresh Ashby snapshot
-      shell: bash
-      env:
-        WEBSITE_ASHBY_API_KEY: ${{ inputs.api_key }}
-        WEBSITE_ASHBY_JOB_BOARD_NAME: ${{ inputs.job_board_name }}
-      run: pnpm --filter @comfyorg/website ashby:refresh-snapshot

.github/actions/changes-filter/action.yaml

@@ -1,87 +0,0 @@
-# Outputs default to 'true' for non-pull_request events (push, merge_group):
-# granular path filtering is a PR-only optimization. This avoids the silent
-# skip footgun where a job gated on e.g. `app-website-changes == 'true'`
-# would never run on push.
-#
-# Shared dependency files (root package.json, pnpm-lock.yaml,
-# pnpm-workspace.yaml) are folded into every app-* and packages-changes
-# output so a lockfile bump correctly invalidates each granular gate. They
-# are NOT folded into docs-changes.
-#
-# Two paths-filter steps are needed because predicate-quantifier=every is
-# required for the negated globs in `should-run` but breaks multi-pattern
-# OR filters like `docs:` and `deps:`.
-#
-# Requires the caller to have checked out the repository.
-
-name: 'Detect Path Changes'
-description: >
-  Computes typed *-changes outputs and a back-compat should-run for
-  path-gated CI jobs.
-
-outputs:
-  should-run:
-    description: 'Any file outside `apps/`, `docs/`, `.storybook/`, or `**/*.md` changed.'
-    value: ${{ github.event_name != 'pull_request' || steps.relevant.outputs.relevant == 'true' }}
-  app-website-changes:
-    description: 'Shared deps or `apps/website/**` changed.'
-    value: ${{ github.event_name != 'pull_request' || steps.filter.outputs.deps == 'true' || steps.filter.outputs.app_website == 'true' }}
-  app-desktop-changes:
-    description: 'Shared deps or `apps/desktop-ui/**` changed.'
-    value: ${{ github.event_name != 'pull_request' || steps.filter.outputs.deps == 'true' || steps.filter.outputs.app_desktop == 'true' }}
-  app-frontend-changes:
-    description: 'Shared deps or `src/**` changed.'
-    value: ${{ github.event_name != 'pull_request' || steps.filter.outputs.deps == 'true' || steps.filter.outputs.app_frontend == 'true' }}
-  packages-changes:
-    description: 'Shared deps or `packages/**` changed.'
-    value: ${{ github.event_name != 'pull_request' || steps.filter.outputs.deps == 'true' || steps.filter.outputs.packages == 'true' }}
-  storybook-changes:
-    description: 'Shared deps or `.storybook/**` changed.'
-    value: ${{ github.event_name != 'pull_request' || steps.filter.outputs.deps == 'true' || steps.filter.outputs.storybook == 'true' }}
-  docs-changes:
-    description: '`docs/**` or any `**/*.md` changed (deps NOT folded in).'
-    value: ${{ github.event_name != 'pull_request' || steps.filter.outputs.docs == 'true' }}
-  dependency-changes:
-    description: 'Root `package.json`, `pnpm-lock.yaml`, or `pnpm-workspace.yaml` changed.'
-    value: ${{ github.event_name != 'pull_request' || steps.filter.outputs.deps == 'true' }}
-
-runs:
-  using: composite
-  steps:
-    - name: Filter typed changes
-      if: ${{ github.event_name == 'pull_request' }}
-      id: filter
-      uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
-      with:
-        filters: |
-          app_website:
-            - 'apps/website/**'
-          app_desktop:
-            - 'apps/desktop-ui/**'
-          app_frontend:
-            - 'src/**'
-          packages:
-            - 'packages/**'
-          storybook:
-            - '.storybook/**'
-          docs:
-            - 'docs/**'
-            - '**/*.md'
-          deps:
-            - 'package.json'
-            - 'pnpm-lock.yaml'
-            - 'pnpm-workspace.yaml'
-
-    - name: Filter relevant changes
-      if: ${{ github.event_name == 'pull_request' }}
-      id: relevant
-      uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
-      with:
-        predicate-quantifier: 'every'
-        filters: |
-          relevant:
-            - '**'
-            - '!apps/**'
-            - '!docs/**'
-            - '!.storybook/**'
-            - '!**/*.md'

.github/actions/cloud-nodes-pull/action.yaml

@@ -1,19 +0,0 @@
-name: Cloud Nodes Pull
-description: 'Refresh the apps/website cloud nodes snapshot from the Comfy Cloud /api/object_info endpoint'
-inputs:
-  api_key:
-    description: 'Comfy Cloud API key (WEBSITE_CLOUD_API_KEY).'
-    required: true
-runs:
-  using: 'composite'
-  steps:
-    # Note: this action assumes the frontend repo is checked out at the workspace root.
-
-    - name: Setup frontend
-      uses: ./.github/actions/setup-frontend
-
-    - name: Refresh cloud nodes snapshot
-      shell: bash
-      env:
-        WEBSITE_CLOUD_API_KEY: ${{ inputs.api_key }}
-      run: pnpm --filter @comfyorg/website cloud-nodes:refresh-snapshot

.github/actions/find-workflow-run/action.yaml

@@ -1,65 +0,0 @@
-name: Find Workflow Run
-description: Finds a workflow run for a given commit SHA and outputs its status and run ID.
-
-inputs:
-  workflow-id:
-    description: The workflow filename (e.g., 'ci-size-data.yaml')
-    required: true
-  head-sha:
-    description: The commit SHA to find runs for
-    required: true
-  not-found-status:
-    description: Status to output when no run exists
-    required: false
-    default: pending
-  token:
-    description: GitHub token for API access
-    required: true
-
-outputs:
-  status:
-    description: One of 'ready', 'pending', 'failed', or the not-found-status value
-    value: ${{ steps.find.outputs.status }}
-  run-id:
-    description: The workflow run ID (only set when status is 'ready')
-    value: ${{ steps.find.outputs.run-id }}
-
-runs:
-  using: composite
-  steps:
-    - name: Find workflow run
-      id: find
-      uses: actions/github-script@v8
-      env:
-        WORKFLOW_ID: ${{ inputs.workflow-id }}
-        HEAD_SHA: ${{ inputs.head-sha }}
-        NOT_FOUND_STATUS: ${{ inputs.not-found-status }}
-      with:
-        github-token: ${{ inputs.token }}
-        script: |
-          const { data: runs } = await github.rest.actions.listWorkflowRuns({
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            workflow_id: process.env.WORKFLOW_ID,
-            head_sha: process.env.HEAD_SHA,
-            per_page: 1,
-          });
-
-          const run = runs.workflow_runs[0];
-          if (!run) {
-            core.setOutput('status', process.env.NOT_FOUND_STATUS);
-            return;
-          }
-
-          if (run.status !== 'completed') {
-            core.setOutput('status', 'pending');
-            return;
-          }
-
-          if (run.conclusion !== 'success') {
-            core.setOutput('status', 'failed');
-            return;
-          }
-
-          core.setOutput('status', 'ready');
-          core.setOutput('run-id', String(run.id));

.github/actions/lint-format-verify/action.yml

@@ -1,31 +0,0 @@
-name: 'Lint and format verify'
-description: >
-  Runs the lint/format/knip verification suite plus a conditional
-  browser-tests typecheck. Shared by ci-lint-format.yaml (PR) and
-  ci-lint-format-queue.yaml (merge queue) so both paths run the exact
-  same checks. The caller is responsible for checkout and frontend setup
-  before invoking this action.
-
-runs:
-  using: composite
-  steps:
-    - name: Detect browser_tests changes
-      id: changed-paths
-      uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
-      with:
-        filters: |
-          browser_tests:
-            - 'browser_tests/**'
-
-    - name: Verify lint and format
-      shell: bash
-      run: |
-        pnpm lint
-        pnpm stylelint
-        pnpm format:check
-        pnpm knip
-
-    - name: Typecheck browser tests
-      if: steps.changed-paths.outputs.browser_tests == 'true'
-      shell: bash
-      run: pnpm typecheck:browser

.github/actions/resolve-pr-from-workflow-run/action.yaml

@@ -1,88 +0,0 @@
-name: Resolve PR from workflow_run
-description: >
-  Resolves the PR number from a workflow_run event using pull_requests[0]
-  with a listPullRequestsAssociatedWithCommit fallback.
-  Skips closed/merged PRs and stale runs (head SHA mismatch).
-
-inputs:
-  token:
-    description: GitHub token for API calls
-    required: false
-    default: ${{ github.token }}
-
-outputs:
-  skip:
-    description: "'true' when no open PR was found or the run is stale"
-    value: ${{ steps.resolve.outputs.skip }}
-  number:
-    description: The PR number (empty when skip is true)
-    value: ${{ steps.resolve.outputs.number }}
-  base:
-    description: The PR base branch (empty when skip is true)
-    value: ${{ steps.resolve.outputs.base }}
-  head-sha:
-    description: The PR head SHA (empty when skip is true)
-    value: ${{ steps.resolve.outputs.head-sha }}
-
-runs:
-  using: composite
-  steps:
-    - name: Resolve PR
-      id: resolve
-      uses: actions/github-script@v8
-      with:
-        github-token: ${{ inputs.token }}
-        script: |
-          let pr = context.payload.workflow_run.pull_requests?.[0];
-          if (!pr) {
-            const { data: prs } = await github.rest.repos.listPullRequestsAssociatedWithCommit({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              commit_sha: context.payload.workflow_run.head_sha,
-            });
-            pr = prs.find(p => p.state === 'open');
-          }
-
-          // Fork PRs: pull_requests is empty and commit SHA may not be in
-          // the base repo graph. Fall back to pulls.list with head filter.
-          if (!pr && context.payload.workflow_run.head_repository?.owner?.login) {
-            const { data: prs } = await github.rest.pulls.list({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              state: 'open',
-              head: `${context.payload.workflow_run.head_repository.owner.login}:${context.payload.workflow_run.head_branch}`,
-              per_page: 1,
-            });
-            pr = prs.find(p => p.head.sha === context.payload.workflow_run.head_sha);
-          }
-
-          if (!pr) {
-            core.info('No open PR found for this workflow run — skipping.');
-            core.setOutput('skip', 'true');
-            return;
-          }
-
-          const { data: livePr } = await github.rest.pulls.get({
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            pull_number: pr.number,
-          });
-
-          if (livePr.state !== 'open') {
-            core.info(`PR #${pr.number} is ${livePr.state} — skipping.`);
-            core.setOutput('skip', 'true');
-            return;
-          }
-
-          if (livePr.head.sha !== context.payload.workflow_run.head_sha) {
-            core.info(
-              `Stale run: workflow SHA ${context.payload.workflow_run.head_sha} != PR head ${livePr.head.sha}`
-            );
-            core.setOutput('skip', 'true');
-            return;
-          }
-
-          core.setOutput('base', livePr.base.ref);
-          core.setOutput('head-sha', livePr.head.sha);
-          core.setOutput('skip', 'false');
-          core.setOutput('number', String(pr.number));

.github/actions/setup-frontend/action.yaml

@@ -29,5 +29,3 @@ runs:
       if: ${{ inputs.include_build_step == 'true' }}
       shell: bash
       run: pnpm build
-      env:
-        VITE_USE_LEGACY_DEFAULT_GRAPH: 'true'

.github/actions/upsert-comment-section/action.yaml

@@ -1,84 +0,0 @@
-name: Upsert Comment Section
-description: >
-  Manage a consolidated PR comment with independently-updatable sections.
-  Multiple CI workflows can share the same comment by using the same
-  comment-marker and different section-names. Each workflow upserts only
-  its own section, leaving other sections intact.
-
-inputs:
-  pr-number:
-    description: PR number to comment on
-    required: true
-  section-name:
-    description: 'Section identifier (e.g. "playwright", "storybook", "e2e", "preview")'
-    required: true
-  section-content:
-    description: Markdown content for this section
-    required: true
-  comment-marker:
-    description: Top-level HTML comment marker shared by all sections in this comment
-    required: true
-  token:
-    description: GitHub token with pull-requests write permission
-    required: true
-
-runs:
-  using: composite
-  steps:
-    - uses: actions/github-script@v8
-      env:
-        INPUT_PR_NUMBER: ${{ inputs.pr-number }}
-        INPUT_SECTION_NAME: ${{ inputs.section-name }}
-        INPUT_SECTION_CONTENT: ${{ inputs.section-content }}
-        INPUT_COMMENT_MARKER: ${{ inputs.comment-marker }}
-      with:
-        github-token: ${{ inputs.token }}
-        script: |
-          const prNumber = Number(process.env.INPUT_PR_NUMBER)
-          const sectionName = process.env.INPUT_SECTION_NAME
-          const sectionContent = process.env.INPUT_SECTION_CONTENT
-          const commentMarker = process.env.INPUT_COMMENT_MARKER
-
-          if (!/^[a-z0-9-]+$/.test(sectionName)) {
-            throw new Error(`Invalid section-name: ${sectionName}`)
-          }
-
-          const sectionStart = `<!-- section:${sectionName}:start -->`
-          const sectionEnd = `<!-- section:${sectionName}:end -->`
-          const sectionBlock = `${sectionStart}\n${sectionContent}\n${sectionEnd}`
-
-          // Escape special regex characters in delimiter strings
-          const escapeRegex = (s) => s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')
-
-          const comments = await github.paginate(
-            github.rest.issues.listComments,
-            { ...context.repo, issue_number: prNumber }
-          )
-
-          const existing = comments.find(
-            (c) =>
-              c.user?.login === 'github-actions[bot]' &&
-              c.body?.includes(commentMarker)
-          )
-
-          if (!existing) {
-            return github.rest.issues.createComment({
-              ...context.repo,
-              issue_number: prNumber,
-              body: `${commentMarker}\n${sectionBlock}`
-            })
-          }
-
-          const body = existing.body ?? ''
-          const sectionRegex = new RegExp(
-            `${escapeRegex(sectionStart)}[\\s\\S]*?${escapeRegex(sectionEnd)}`
-          )
-          const updated = sectionRegex.test(body)
-            ? body.replace(sectionRegex, sectionBlock)
-            : body.trimEnd() + '\n\n' + sectionBlock
-
-          return github.rest.issues.updateComment({
-            ...context.repo,
-            comment_id: existing.id,
-            body: updated
-          })

.github/workflows/backport-auto-merge.yaml

@@ -1,197 +0,0 @@
----
-name: Backport Auto-Merge
-
-# Completes the merge of backport PRs once they are approved and their required
-# checks pass.
-#
-# Background: pr-backport.yaml opens each backport PR (labelled `backport`) and
-# calls `gh pr merge --auto`, which relies on the repo-level "Allow auto-merge"
-# setting. That setting is off, so `--auto` is a silent no-op and backport PRs
-# sit unmerged until a human clicks merge. This workflow performs the merge
-# directly (a plain `gh pr merge --squash`, which does not depend on that
-# setting) once GitHub itself reports the PR as ready to merge.
-#
-# Safety: branch protection on core/** and cloud/** is the hard gate — it
-# unconditionally requires an approval + the required status checks and cannot
-# be bypassed, and GitHub's merge API re-enforces it at merge time. This
-# workflow can only ever complete a merge that already satisfies those rules;
-# the eligibility check below only avoids pointless merge attempts.
-#
-# The merge uses PR_GH_TOKEN (not the default GITHUB_TOKEN) on purpose: a merge
-# performed by the default token does not emit events that trigger other
-# workflows, which would silently starve cloud-backport-tag.yaml (it runs on the
-# backport PR's `pull_request: closed` event to create the release tag).
-
-on:
-  # Fires when someone approves — if the required checks are already green, the
-  # PR merges immediately.
-  pull_request_review:
-    types: [submitted]
-  # Primary catch for the "approved first, checks went green later" case, plus a
-  # general backstop. A `check_suite`/`workflow_run` trigger would react faster to
-  # checks completing, but GitHub suppresses `check_suite` events for its own
-  # Actions suites (so it wouldn't fire for this repo's CI), and `workflow_run` is
-  # a secrets-bearing "dangerous" trigger we don't want on a public repo for a
-  # non-latency-critical task. Backports wait hours today, so a short sweep is a
-  # large improvement and needs neither.
-  schedule:
-    - cron: '*/15 * * * *'
-
-# Only constrains the default github.token (used for read-only PR lookups below).
-# It does NOT constrain PR_GH_TOKEN, whose authority is fixed by its own scopes.
-permissions:
-  contents: read # read-only; required for gh api / gh pr list to resolve candidates
-  pull-requests: read # read-only; required for gh pr view eligibility checks
-
-# Serialize runs that act on the same PR (review events keyed by PR number; all
-# scheduled sweeps share one key). Cross-key overlaps are still possible but
-# harmless: the merge loop treats an already-merged PR as success (idempotent).
-concurrency:
-  group: backport-auto-merge-${{ github.event.pull_request.number || 'sweep' }}
-  cancel-in-progress: false
-
-jobs:
-  merge:
-    name: Merge eligible backport PRs
-    # Skip review events that can't possibly make a PR mergeable — non-approval
-    # reviews, or reviews on non-backport PRs (most reviews in the repo) — before
-    # spending any API call. Schedule sweeps always proceed. The per-PR
-    # eligibility checks in the job still re-verify the label and decision from
-    # live state.
-    if: github.event_name != 'pull_request_review' || (github.event.review.state == 'approved' && contains(github.event.pull_request.labels.*.name, 'backport'))
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read # read-only PR/commit lookups via the default token
-      pull-requests: read # read-only PR metadata via the default token
-    steps:
-      - name: Collect candidate backport PRs
-        id: candidates
-        env:
-          GH_TOKEN: ${{ github.token }}
-          GH_REPO: ${{ github.repository }}
-          EVENT_NAME: ${{ github.event_name }}
-          PR_FROM_REVIEW: ${{ github.event.pull_request.number }}
-        run: |
-          set -euo pipefail
-          numbers=""
-          case "$EVENT_NAME" in
-            pull_request_review)
-              numbers="$PR_FROM_REVIEW"
-              ;;
-            schedule)
-              # Sweep every open backport PR.
-              numbers=$(gh pr list --repo "$GH_REPO" --state open --label backport \
-                --limit 100 --json number --jq '.[].number')
-              ;;
-          esac
-          # De-duplicate and emit space-separated, digit-only tokens.
-          numbers=$(echo "$numbers" | tr ' ' '\n' | grep -E '^[0-9]+$' | sort -u | tr '\n' ' ' || true)
-          echo "numbers=${numbers}" >> "$GITHUB_OUTPUT"
-          echo "Candidate PRs: '${numbers:-<none>}'"
-
-      - name: Merge eligible backport PRs
-        if: steps.candidates.outputs.numbers != ''
-        env:
-          GH_REPO: ${{ github.repository }}
-          # Read with the default token; merge with PR_GH_TOKEN so the merge emits
-          # the events that downstream workflows (cloud-backport-tag.yaml) rely on.
-          READ_TOKEN: ${{ github.token }}
-          MERGE_TOKEN: ${{ secrets.PR_GH_TOKEN }}
-          CANDIDATES: ${{ steps.candidates.outputs.numbers }}
-        run: |
-          set -euo pipefail
-
-          is_merged() {
-            [ "$(GH_TOKEN="$READ_TOKEN" gh pr view "$1" --repo "$GH_REPO" --json merged --jq '.merged' 2>/dev/null || echo false)" = "true" ]
-          }
-
-          for pr in $CANDIDATES; do
-            echo "::group::PR #${pr}"
-
-            info=$(GH_TOKEN="$READ_TOKEN" gh pr view "$pr" --repo "$GH_REPO" \
-              --json number,state,isDraft,labels,baseRefName,reviewDecision,mergeStateStatus 2>/dev/null || echo '')
-            if [ -z "$info" ]; then
-              echo "Could not read PR #${pr} — skipping."; echo "::endgroup::"; continue
-            fi
-
-            state=$(echo "$info" | jq -r '.state')
-            is_draft=$(echo "$info" | jq -r '.isDraft')
-            is_backport=$(echo "$info" | jq -r '[.labels[].name] | any(. == "backport")')
-            base=$(echo "$info" | jq -r '.baseRefName')
-            review=$(echo "$info" | jq -r '.reviewDecision')
-            merge_state=$(echo "$info" | jq -r '.mergeStateStatus')
-
-            # Only ever act on open, non-draft, backport-labelled PRs targeting a
-            # protected release branch.
-            if [ "$state" != "OPEN" ] || [ "$is_draft" != "false" ] || [ "$is_backport" != "true" ]; then
-              echo "Not an actionable backport PR (state=$state draft=$is_draft backport=$is_backport) — skipping."
-              echo "::endgroup::"; continue
-            fi
-            case "$base" in
-              cloud/*|core/*) : ;;
-              *) echo "Base '$base' is not a release branch — skipping."; echo "::endgroup::"; continue ;;
-            esac
-
-            # Ready = approved AND GitHub says it's mergeable with required checks green.
-            #   CLEAN    = approved, all required checks green, mergeable, no conflict.
-            #   UNSTABLE = same, but a NON-required check is pending/failing — GitHub
-            #              still allows the merge, so we do too (matches what a human
-            #              clicking "Squash and merge" can do; required checks are the
-            #              only merge gate per the ruleset). Requiring CLEAN alone would
-            #              stick forever behind flaky/slow non-required checks.
-            # Any other state (BLOCKED/DIRTY/BEHIND/UNKNOWN/...) => not ready; re-checked
-            # by a later event or the next sweep.
-            if [ "$review" != "APPROVED" ] || { [ "$merge_state" != "CLEAN" ] && [ "$merge_state" != "UNSTABLE" ]; }; then
-              echo "Not yet ready (reviewDecision=$review mergeStateStatus=$merge_state) — will re-check later."
-              echo "::endgroup::"; continue
-            fi
-
-            echo "PR #${pr} is ready — attempting squash merge."
-            attempt=0
-            max=3
-            merged=false
-            while [ "$attempt" -lt "$max" ]; do
-              attempt=$((attempt + 1))
-              # A concurrent run (or a human) may have merged it already.
-              if is_merged "$pr"; then merged=true; break; fi
-              if out=$(GH_TOKEN="$MERGE_TOKEN" gh pr merge "$pr" --repo "$GH_REPO" --squash 2>&1); then
-                merged=true; break
-              fi
-              echo "Merge attempt ${attempt}/${max} failed: ${out}"
-              # No sleep after the final attempt.
-              [ "$attempt" -lt "$max" ] && sleep $((attempt * 15))
-            done
-
-            # Final reconciliation: a failed merge command may just mean a concurrent
-            # run won the race — don't post a false failure if the PR is in fact merged.
-            if [ "$merged" != "true" ] && is_merged "$pr"; then merged=true; fi
-
-            if [ "$merged" = "true" ]; then
-              echo "PR #${pr} merged."
-            else
-              echo "::warning::PR #${pr} looked ready but did not merge after ${max} attempts."
-              # Avoid spamming a persistently-stuck PR: only re-warn if the last
-              # warning (identified by its marker) is more than an hour old.
-              marker='<!-- backport-auto-merge:merge-failed -->'
-              # `gh api --paginate` emits one JSON array per page; `--jq` would run
-              # per page (missing the true latest across pages), so slurp all pages
-              # into one array first and filter with a separate jq pass.
-              last_warned=$(GH_TOKEN="$READ_TOKEN" gh api "repos/${GH_REPO}/issues/${pr}/comments" --paginate 2>/dev/null \
-                | jq -s "[.[][] | select(.body | contains(\"${marker}\"))] | sort_by(.created_at) | last | .created_at // empty") || last_warned=''
-              stale=true
-              if [ -n "$last_warned" ]; then
-                last_epoch=$(date -d "$last_warned" +%s 2>/dev/null || echo 0)
-                now_epoch=$(date -u +%s)
-                [ $((now_epoch - last_epoch)) -lt 3600 ] && stale=false
-              fi
-              if [ "$stale" = "true" ]; then
-                body=$(printf '%s\n\n%s' \
-                  "This backport PR is approved and its required checks are green, but automatic merge failed after ${max} attempts. Please merge manually or investigate (possible branch-protection mismatch)." \
-                  "$marker")
-                GH_TOKEN="$MERGE_TOKEN" gh pr comment "$pr" --repo "$GH_REPO" --body "$body" || true
-              else
-                echo "Already warned within the last hour — skipping duplicate comment."
-              fi
-            fi
-            echo "::endgroup::"
-          done

.github/workflows/ci-dist-telemetry-scan.yaml

@@ -12,30 +12,17 @@ permissions:
   contents: read
 
 jobs:
-  changes:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    outputs:
-      should-run: ${{ steps.changes.outputs.should-run }}
-    steps:
-      - uses: actions/checkout@v6
-      - id: changes
-        uses: ./.github/actions/changes-filter
-
   scan:
-    needs: changes
-    if: ${{ needs.changes.outputs.should-run == 'true' }}
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
 
       - name: Install pnpm
         uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
 
       - name: Use Node.js
-        uses: actions/setup-node@v6
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version-file: '.nvmrc'
           cache: 'pnpm'
@@ -109,69 +96,3 @@ jobs:
             exit 1
           fi
           echo '✅ No PostHog references found'
-
-      - name: Scan dist for Customer.io telemetry references
-        run: |
-          set -euo pipefail
-          echo '🔍 Scanning for Customer.io references...'
-          if rg --no-ignore -n \
-            -g '*.html' \
-            -g '*.js' \
-            -e 'CustomerIoTelemetryProvider' \
-            -e '@customerio/cdp-analytics-browser' \
-            -e 'customerio-gist-web' \
-            -e '(?i)cdp\.customer\.io' \
-            -e 'Comfy\.CustomerIo' \
-            dist; then
-            echo '❌ ERROR: Customer.io references found in dist assets!'
-            echo 'Customer.io must be properly tree-shaken from OSS builds.'
-            echo ''
-            echo 'To fix this:'
-            echo '1. Use the TelemetryProvider pattern (see src/platform/telemetry/)'
-            echo '2. Call telemetry via useTelemetry() hook'
-            echo '3. Use conditional dynamic imports behind isCloud checks'
-            exit 1
-          fi
-          echo '✅ No Customer.io references found'
-
-      - name: Scan dist for Syft telemetry references
-        run: |
-          set -euo pipefail
-          echo '🔍 Scanning for Syft references...'
-          if rg --no-ignore -n \
-            -g '*.html' \
-            -g '*.js' \
-            -e '(?i)syft' \
-            -e '(?i)sy-d\.io' \
-            dist; then
-            echo '❌ ERROR: Syft references found in dist assets!'
-            echo 'Syft must be properly tree-shaken from OSS builds.'
-            echo ''
-            echo 'To fix this:'
-            echo '1. Use the TelemetryProvider pattern (see src/platform/telemetry/)'
-            echo '2. Call telemetry via useTelemetry() hook'
-            echo '3. Use conditional dynamic imports behind isCloud checks'
-            exit 1
-          fi
-          echo '✅ No Syft references found'
-
-      - name: Scan dist for Cloudflare Turnstile sitekey references
-        run: |
-          set -euo pipefail
-          echo '🔍 Scanning for Cloudflare Turnstile sitekeys...'
-          if rg --no-ignore -n \
-            -g '*.html' \
-            -g '*.js' \
-            -e '0x4AAAAAADnYZPVOpFCL_zeo' \
-            -e '0x4AAAAAADnYY4_Q0qxHZ5a7' \
-            -e '1x00000000000000000000AA' \
-            dist; then
-            echo '❌ ERROR: Cloudflare Turnstile sitekey found in dist assets!'
-            echo 'The per-env Turnstile sitekeys are cloud-only and must be tree-shaken from OSS builds.'
-            echo ''
-            echo 'To fix this:'
-            echo '1. Gate sitekey selection on the __DISTRIBUTION__ build define, not the runtime isCloud const'
-            echo '2. See getTurnstileSiteKey() in src/config/turnstile.ts'
-            exit 1
-          fi
-          echo '✅ No Turnstile sitekey references found'

.github/workflows/ci-lint-format-queue.yaml

@@ -1,29 +0,0 @@
-# Description: Lint and format verification for GitHub merge queue runs.
-# Paired with ci-lint-format.yaml — workflow name and job name must match
-# so branch protection resolves a single required check in both the
-# pull_request and merge_group contexts. This file runs verify-only steps
-# with a read-only token; auto-fix and PR comments live in the PR workflow.
-name: 'CI: Lint Format'
-
-on:
-  merge_group:
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true
-
-permissions:
-  contents: read
-
-jobs:
-  lint-and-format:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout merge group ref
-        uses: actions/checkout@v6
-
-      - name: Setup frontend
-        uses: ./.github/actions/setup-frontend
-
-      - name: Verify lint and format
-        uses: ./.github/actions/lint-format-verify

.github/workflows/ci-lint-format.yaml

@@ -1,7 +1,4 @@
-# Description: Linting and code formatting validation for pull requests.
-# Paired with ci-lint-format-queue.yaml - workflow name and job name must
-# match so branch protection resolves a single required check in both the
-# pull_request and merge_group contexts.
+# Description: Linting and code formatting validation for pull requests
 name: 'CI: Lint Format'
 
 on:
@@ -29,6 +26,14 @@ jobs:
       - name: Setup frontend
         uses: ./.github/actions/setup-frontend
 
+      - name: Detect browser_tests changes
+        id: changed-paths
+        uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
+        with:
+          filters: |
+            browser_tests:
+              - 'browser_tests/**'
+
       - name: Run ESLint with auto-fix
         run: pnpm lint:fix
 
@@ -72,8 +77,16 @@ jobs:
           echo "See CONTRIBUTING.md for more details."
           exit 1
 
-      - name: Verify lint and format
-        uses: ./.github/actions/lint-format-verify
+      - name: Final validation
+        run: |
+          pnpm lint
+          pnpm stylelint
+          pnpm format:check
+          pnpm knip
+
+      - name: Typecheck browser tests
+        if: steps.changed-paths.outputs.browser_tests == 'true'
+        run: pnpm typecheck:browser
 
       - name: Comment on PR about auto-fix
         if: steps.verify-changed-files.outputs.changed == 'true' && github.event.pull_request.head.repo.full_name == github.repository

.github/workflows/ci-oss-assets-validation.yaml

@@ -14,29 +14,16 @@ permissions:
   contents: read
 
 jobs:
-  changes:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    outputs:
-      should-run: ${{ steps.changes.outputs.should-run }}
-    steps:
-      - uses: actions/checkout@v6
-      - id: changes
-        uses: ./.github/actions/changes-filter
-
   validate-fonts:
-    needs: changes
-    if: ${{ needs.changes.outputs.should-run == 'true' }}
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
 
       - name: Install pnpm
         uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
 
       - name: Use Node.js
-        uses: actions/setup-node@v6
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version-file: '.nvmrc'
           cache: 'pnpm'
@@ -81,17 +68,15 @@ jobs:
           echo '✅ No proprietary fonts found in dist'
 
   validate-licenses:
-    needs: changes
-    if: ${{ needs.changes.outputs.should-run == 'true' }}
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
 
       - name: Install pnpm
         uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
 
       - name: Use Node.js
-        uses: actions/setup-node@v6
+        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
         with:
           node-version-file: '.nvmrc'
           cache: 'pnpm'

.github/workflows/ci-perf-report.yaml

@@ -3,8 +3,10 @@ name: 'CI: Performance Report'
 on:
   push:
     branches: [main, core/*]
+    paths-ignore: ['**/*.md']
   pull_request:
     branches-ignore: [wip/*, draft/*, temp/*]
+    paths-ignore: ['**/*.md']
 
 concurrency:
   group: perf-${{ github.ref }}
@@ -14,24 +16,12 @@ permissions:
   contents: read
 
 jobs:
-  changes:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    outputs:
-      should-run: ${{ steps.changes.outputs.should-run }}
-    steps:
-      - uses: actions/checkout@v6
-      - id: changes
-        uses: ./.github/actions/changes-filter
-
   perf-tests:
-    needs: changes
-    if: ${{ needs.changes.outputs.should-run == 'true' && github.repository == 'Comfy-Org/ComfyUI_frontend' }}
+    if: github.repository == 'Comfy-Org/ComfyUI_frontend'
     runs-on: ubuntu-latest
     timeout-minutes: 30
     container:
-      image: ghcr.io/comfy-org/comfyui-ci-container:0.0.17
+      image: ghcr.io/comfy-org/comfyui-ci-container:0.0.12
       credentials:
         username: ${{ github.actor }}
         password: ${{ secrets.GITHUB_TOKEN }}
@@ -54,14 +44,10 @@ jobs:
       - name: Start ComfyUI server
         uses: ./.github/actions/start-comfyui-server
 
-      # PRs run each test once to keep wall time bounded; main runs 3× so the
-      # baseline saved to perf-data has enough samples to median over noise.
       - name: Run performance tests
         id: perf
         continue-on-error: true
-        env:
-          PERF_REPEAT: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' && '3' || '2' }}
-        run: pnpm exec playwright test --project=performance --workers=1 --repeat-each=$PERF_REPEAT
+        run: pnpm exec playwright test --project=performance --workers=1 --repeat-each=3
 
       - name: Upload perf metrics
         if: always()
@@ -72,6 +58,21 @@ jobs:
           retention-days: 30
           if-no-files-found: warn
 
+      - name: Save PR metadata
+        if: github.event_name == 'pull_request'
+        run: |
+          mkdir -p temp/perf-meta
+          echo "${{ github.event.number }}" > temp/perf-meta/number.txt
+          echo "${{ github.event.pull_request.base.ref }}" > temp/perf-meta/base.txt
+          echo "${{ github.event.pull_request.head.sha }}" > temp/perf-meta/head-sha.txt
+
+      - name: Upload PR metadata
+        if: github.event_name == 'pull_request'
+        uses: actions/upload-artifact@v6
+        with:
+          name: perf-meta
+          path: temp/perf-meta/
+
       - name: Save perf baseline to perf-data branch
         if: github.event_name == 'push' && github.ref == 'refs/heads/main' && steps.perf.outcome == 'success'
         continue-on-error: true

.github/workflows/ci-size-data.yaml

@@ -16,21 +16,8 @@ permissions:
   contents: read
 
 jobs:
-  changes:
-    if: github.repository == 'Comfy-Org/ComfyUI_frontend'
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    outputs:
-      should-run: ${{ steps.changes.outputs.should-run }}
-    steps:
-      - uses: actions/checkout@v6
-      - id: changes
-        uses: ./.github/actions/changes-filter
-
   collect:
-    needs: changes
-    if: ${{ needs.changes.outputs.should-run == 'true' }}
+    if: github.repository == 'Comfy-Org/ComfyUI_frontend'
     runs-on: ubuntu-latest
 
     steps:
@@ -45,6 +32,13 @@ jobs:
       - name: Collect size data
         run: node scripts/size-collect.js
 
+      - name: Save PR metadata
+        if: ${{ github.event_name == 'pull_request' }}
+        run: |
+          echo ${{ github.event.number }} > ./temp/size/number.txt
+          echo ${{ github.base_ref }} > ./temp/size/base.txt
+          echo ${{ github.event.pull_request.head.sha }} > ./temp/size/head-sha.txt
+
       - name: Upload size data
         uses: actions/upload-artifact@v6
         with:

.github/workflows/ci-tests-e2e-coverage.yaml

@@ -1,162 +0,0 @@
-name: 'CI: E2E Coverage'
-
-on:
-  workflow_run:
-    workflows: ['CI: Tests E2E']
-    types:
-      - completed
-
-concurrency:
-  group: e2e-coverage-${{ github.event.workflow_run.head_sha }}
-  cancel-in-progress: true
-
-permissions:
-  contents: read
-
-jobs:
-  merge:
-    if: >
-      github.repository == 'Comfy-Org/ComfyUI_frontend' &&
-      github.event.workflow_run.conclusion == 'success'
-    runs-on: ubuntu-latest
-    timeout-minutes: 10
-    outputs:
-      has-coverage: ${{ steps.coverage-shards.outputs.has-coverage }}
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v6
-
-      - name: Setup frontend
-        uses: ./.github/actions/setup-frontend
-
-      - name: Download all shard coverage data
-        uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
-        with:
-          run_id: ${{ github.event.workflow_run.id }}
-          name: e2e-coverage-shard-.*
-          name_is_regexp: true
-          path: temp/coverage-shards
-          if_no_artifact_found: warn
-
-      - name: Detect shard coverage data
-        id: coverage-shards
-        run: |
-          if [ -d temp/coverage-shards ] && find temp/coverage-shards -name 'coverage.lcov' -type f | grep -q .; then
-            echo "has-coverage=true" >> "$GITHUB_OUTPUT"
-          else
-            echo "has-coverage=false" >> "$GITHUB_OUTPUT"
-            echo "No E2E coverage shard artifacts found; treating this run as skipped." >> "$GITHUB_STEP_SUMMARY"
-          fi
-
-      - name: Install lcov
-        if: steps.coverage-shards.outputs.has-coverage == 'true'
-        run: sudo apt-get install -y -qq lcov
-
-      - name: Merge shard coverage into single LCOV
-        if: steps.coverage-shards.outputs.has-coverage == 'true'
-        run: |
-          mkdir -p coverage/playwright
-          LCOV_FILES=$(find temp/coverage-shards -name 'coverage.lcov' -type f)
-          ADD_ARGS=""
-          for f in $LCOV_FILES; do ADD_ARGS="$ADD_ARGS -a $f"; done
-          lcov $ADD_ARGS -o coverage/playwright/coverage.lcov
-          wc -l coverage/playwright/coverage.lcov
-
-      - name: Validate merged coverage
-        if: steps.coverage-shards.outputs.has-coverage == 'true'
-        run: |
-          MERGED_SF=$(grep -c '^SF:' coverage/playwright/coverage.lcov || echo 0)
-          MERGED_LH=$(awk -F: '/^LH:/{s+=$2}END{print s+0}' coverage/playwright/coverage.lcov)
-          MERGED_LF=$(awk -F: '/^LF:/{s+=$2}END{print s+0}' coverage/playwright/coverage.lcov)
-          echo "### Merged coverage" >> "$GITHUB_STEP_SUMMARY"
-          echo "- **$MERGED_SF** source files" >> "$GITHUB_STEP_SUMMARY"
-          echo "- **$MERGED_LH / $MERGED_LF** lines hit" >> "$GITHUB_STEP_SUMMARY"
-          echo "" >> "$GITHUB_STEP_SUMMARY"
-          echo "| Shard | Files | Lines Hit |" >> "$GITHUB_STEP_SUMMARY"
-          echo "|-------|-------|-----------|" >> "$GITHUB_STEP_SUMMARY"
-          for f in $(find temp/coverage-shards -name 'coverage.lcov' -type f | sort); do
-            SHARD=$(basename "$(dirname "$f")")
-            SHARD_SF=$(grep -c '^SF:' "$f" || echo 0)
-            SHARD_LH=$(awk -F: '/^LH:/{s+=$2}END{print s+0}' "$f")
-            echo "| $SHARD | $SHARD_SF | $SHARD_LH |" >> "$GITHUB_STEP_SUMMARY"
-            if [ "$MERGED_LH" -lt "$SHARD_LH" ]; then
-              echo "::error::Merged LH ($MERGED_LH) < shard LH ($SHARD_LH) in $SHARD — possible data loss"
-            fi
-          done
-
-      - name: Strip non-source entries from coverage
-        if: steps.coverage-shards.outputs.has-coverage == 'true'
-        run: |
-          lcov --remove coverage/playwright/coverage.lcov \
-            '*localhost-8188*' \
-            'assets/images/*' \
-            -o coverage/playwright/coverage.lcov \
-            --ignore-errors unused
-          wc -l coverage/playwright/coverage.lcov
-
-      - name: Upload merged coverage data
-        if: steps.coverage-shards.outputs.has-coverage == 'true'
-        uses: actions/upload-artifact@v6
-        with:
-          name: e2e-coverage
-          path: coverage/playwright/
-          retention-days: 30
-          if-no-files-found: warn
-
-      - name: Upload E2E coverage to Codecov
-        if: steps.coverage-shards.outputs.has-coverage == 'true'
-        uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5.5.3
-        with:
-          files: coverage/playwright/coverage.lcov
-          flags: e2e
-          token: ${{ secrets.CODECOV_TOKEN }}
-          fail_ci_if_error: false
-
-      - name: Generate HTML coverage report
-        if: steps.coverage-shards.outputs.has-coverage == 'true'
-        run: |
-          genhtml coverage/playwright/coverage.lcov \
-            -o coverage/html \
-            --title "ComfyUI E2E Coverage" \
-            --no-function-coverage \
-            --precision 1 \
-            --ignore-errors source,unmapped \
-            --synthesize-missing
-
-      - name: Upload HTML report artifact
-        if: steps.coverage-shards.outputs.has-coverage == 'true'
-        uses: actions/upload-artifact@v6
-        with:
-          name: e2e-coverage-html
-          path: coverage/html/
-          retention-days: 30
-
-  deploy:
-    needs: merge
-    if: >
-      github.event.workflow_run.head_branch == 'main' &&
-      needs.merge.outputs.has-coverage == 'true' &&
-      github.event.workflow_run.event == 'push'
-    runs-on: ubuntu-latest
-    permissions:
-      pages: write
-      id-token: write
-    environment:
-      name: github-pages
-      url: ${{ steps.deployment.outputs.page_url }}
-    steps:
-      - name: Download HTML report
-        uses: actions/download-artifact@v7
-        with:
-          name: e2e-coverage-html
-          path: coverage/html
-
-      - name: Upload to GitHub Pages
-        uses: actions/upload-pages-artifact@56afc609e74202658d3ffba0e8f6dda462b719fa # v3.0.1
-        with:
-          path: coverage/html
-
-      - name: Deploy to GitHub Pages
-        id: deployment
-        uses: actions/deploy-pages@d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e # v4.0.5

.github/workflows/ci-tests-e2e-forks.yaml

@@ -6,10 +6,6 @@ on:
     workflows: ['CI: Tests E2E']
     types: [requested, completed]
 
-concurrency:
-  group: ${{ github.workflow }}-${{ github.event.workflow_run.head_repository.full_name }}-${{ github.event.workflow_run.head_branch }}
-  cancel-in-progress: true
-
 jobs:
   deploy-and-comment-forked-pr:
     runs-on: ubuntu-latest
@@ -34,39 +30,54 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v6
 
-      - name: Resolve PR from workflow_run context
+      - name: Get PR Number
         id: pr
-        uses: ./.github/actions/resolve-pr-from-workflow-run
-
-      - name: Handle Test Start — upsert playwright starting section
-        if: steps.pr.outputs.skip != 'true' && github.event.action == 'requested'
-        uses: ./.github/actions/upsert-comment-section
+        uses: actions/github-script@v8
         with:
-          pr-number: ${{ steps.pr.outputs.number }}
-          section-name: playwright
-          section-content: '## 🎭 Playwright: ⏳ Running...'
-          comment-marker: '<!-- COMFYUI_FRONTEND_PR_REPORT -->'
-          token: ${{ github.token }}
+          script: |
+            const { data: prs } = await github.rest.pulls.list({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              state: 'open',
+            });
+
+            const pr = prs.find(p => p.head.sha === context.payload.workflow_run.head_sha);
+
+            if (!pr) {
+              console.log('No PR found for SHA:', context.payload.workflow_run.head_sha);
+              return null;
+            }
+
+            console.log(`Found PR #${pr.number} from fork: ${context.payload.workflow_run.head_repository.full_name}`);
+            return pr.number;
+
+      - name: Handle Test Start
+        if: steps.pr.outputs.result != 'null' && github.event.action == 'requested'
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+        run: |
+          chmod +x scripts/cicd/pr-playwright-deploy-and-comment.sh
+          ./scripts/cicd/pr-playwright-deploy-and-comment.sh \
+            "${{ steps.pr.outputs.result }}" \
+            "${{ github.event.workflow_run.head_branch }}" \
+            "starting"
 
       - name: Download and Deploy Reports
-        if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed'
-        uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
+        if: steps.pr.outputs.result != 'null' && github.event.action == 'completed'
+        uses: actions/download-artifact@v7
         with:
-          run_id: ${{ github.event.workflow_run.id }}
-          name: playwright-report-.*
-          name_is_regexp: true
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          run-id: ${{ github.event.workflow_run.id }}
+          pattern: playwright-report-*
           path: reports
-          if_no_artifact_found: warn
 
-      - name: Handle Test Completion — deploy and generate section
-        if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed' && hashFiles('reports/**') != ''
+      - name: Handle Test Completion
+        if: steps.pr.outputs.result != 'null' && github.event.action == 'completed'
         env:
           CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           GITHUB_TOKEN: ${{ github.token }}
           GITHUB_SHA: ${{ github.event.workflow_run.head_sha }}
-          SUMMARY_FILE: playwright-section.md
-          BRANCH_NAME: ${{ github.event.workflow_run.head_branch }}
         run: |
           # Rename merged report if exists
           [ -d "reports/playwright-report-chromium-merged" ] && \
@@ -74,23 +85,6 @@ jobs:
 
           chmod +x scripts/cicd/pr-playwright-deploy-and-comment.sh
           ./scripts/cicd/pr-playwright-deploy-and-comment.sh \
-            "${{ steps.pr.outputs.number }}" \
-            "$BRANCH_NAME" \
+            "${{ steps.pr.outputs.result }}" \
+            "${{ github.event.workflow_run.head_branch }}" \
             "completed"
-
-      - name: Read playwright section
-        id: section
-        if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed' && hashFiles('playwright-section.md') != ''
-        uses: juliangruber/read-file-action@b549046febe0fe86f8cb4f93c24e284433f9ab58 # v1.1.7
-        with:
-          path: playwright-section.md
-
-      - name: Upsert playwright section into unified report
-        if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed' && steps.section.outputs.content != ''
-        uses: ./.github/actions/upsert-comment-section
-        with:
-          pr-number: ${{ steps.pr.outputs.number }}
-          section-name: playwright
-          section-content: ${{ steps.section.outputs.content }}
-          comment-marker: '<!-- COMFYUI_FRONTEND_PR_REPORT -->'
-          token: ${{ github.token }}

.github/workflows/ci-tests-e2e.yaml

@@ -4,9 +4,10 @@ name: 'CI: Tests E2E'
 on:
   push:
     branches: [main, master, core/*, desktop/*]
+    paths-ignore: ['**/*.md']
   pull_request:
     branches-ignore: [wip/*, draft/*, temp/*]
-  merge_group:
+    paths-ignore: ['**/*.md']
   workflow_dispatch:
 
 concurrency:
@@ -14,20 +15,7 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  changes:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    outputs:
-      should-run: ${{ steps.changes.outputs.should-run }}
-    steps:
-      - uses: actions/checkout@v6
-      - id: changes
-        uses: ./.github/actions/changes-filter
-
   setup:
-    needs: changes
-    if: ${{ needs.changes.outputs.should-run == 'true' }}
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
@@ -45,10 +33,12 @@ jobs:
           path: dist/
           retention-days: 1
 
+      # Build cloud distribution for @cloud tagged tests
+      # NX_SKIP_NX_CACHE=true is required because `nx build` was already run
+      # for the OSS distribution above. Without skipping cache, Nx returns
+      # the cached OSS build since env vars aren't part of the cache key.
       - name: Build cloud frontend
-        run: pnpm build:cloud
-        env:
-          VITE_USE_LEGACY_DEFAULT_GRAPH: 'true'
+        run: NX_SKIP_NX_CACHE=true pnpm build:cloud
 
       - name: Upload cloud frontend
         uses: actions/upload-artifact@v6
@@ -63,7 +53,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 60
     container:
-      image: ghcr.io/comfy-org/comfyui-ci-container:0.0.17
+      image: ghcr.io/comfy-org/comfyui-ci-container:0.0.16
       credentials:
         username: ${{ github.actor }}
         password: ${{ secrets.GITHUB_TOKEN }}
@@ -73,8 +63,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        shardIndex: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16]
-        shardTotal: [16]
+        shardIndex: [1, 2, 3, 4, 5, 6, 7, 8]
+        shardTotal: [8]
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
@@ -93,10 +83,9 @@ jobs:
       # Run sharded tests (browsers pre-installed in container)
       - name: Run Playwright tests (Shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }})
         id: playwright
-        run: pnpm exec playwright test --project=chromium --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
+        run: pnpm exec playwright test --project=chromium --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }} --reporter=blob
         env:
           PLAYWRIGHT_BLOB_OUTPUT_DIR: ./blob-report
-          COLLECT_COVERAGE: 'true'
 
       - name: Upload blob report
         uses: actions/upload-artifact@v6
@@ -106,22 +95,13 @@ jobs:
           path: blob-report/
           retention-days: 1
 
-      - name: Upload shard coverage data
-        if: always()
-        uses: actions/upload-artifact@v6
-        with:
-          name: e2e-coverage-shard-${{ matrix.shardIndex }}
-          path: coverage/playwright/
-          retention-days: 1
-          if-no-files-found: warn
-
   playwright-tests:
     # Ideally, each shard runs test in 6 minutes, but allow up to 15 minutes
     timeout-minutes: 15
     needs: setup
     runs-on: ubuntu-latest
     container:
-      image: ghcr.io/comfy-org/comfyui-ci-container:0.0.17
+      image: ghcr.io/comfy-org/comfyui-ci-container:0.0.16
       credentials:
         username: ${{ github.actor }}
         password: ${{ secrets.GITHUB_TOKEN }}
@@ -150,7 +130,7 @@ jobs:
       # Run tests (browsers pre-installed in container)
       - name: Run Playwright tests (${{ matrix.browser }})
         id: playwright
-        run: pnpm exec playwright test --project=${{ matrix.browser }}
+        run: pnpm exec playwright test --project=${{ matrix.browser }} --reporter=blob
         env:
           PLAYWRIGHT_BLOB_OUTPUT_DIR: ./blob-report
 
@@ -173,9 +153,9 @@ jobs:
 
   # Merge sharded test reports (no container needed - only runs CLI)
   merge-reports:
-    needs: [changes, playwright-tests-chromium-sharded]
+    needs: [playwright-tests-chromium-sharded]
     runs-on: ubuntu-latest
-    if: ${{ !cancelled() && needs.changes.outputs.should-run == 'true' }}
+    if: ${{ !cancelled() }}
     steps:
       - name: Install pnpm
         uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
@@ -204,64 +184,35 @@ jobs:
           path: ./playwright-report/
           retention-days: 30
 
-  # Gate job — single required check that passes whether the matrix ran or was
-  # skipped. Branch rulesets require this instead of the individual matrix-
-  # expanded check names so PRs with no e2e-relevant changes aren't stuck.
-  e2e-status:
-    if: ${{ always() }}
-    needs: [changes, playwright-tests-chromium-sharded, playwright-tests]
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check E2E results
-        env:
-          SHOULD_RUN: ${{ needs.changes.outputs.should-run }}
-          SHARDED: ${{ needs.playwright-tests-chromium-sharded.result }}
-          BROWSERS: ${{ needs.playwright-tests.result }}
-        run: |
-          [[ "$SHOULD_RUN" != "true" ]] && echo "E2E skipped" && exit 0
-          [[ "$SHARDED" != "success" || "$BROWSERS" != "success" ]] && echo "E2E failed" && exit 1
-          echo "E2E passed"
-
   #### BEGIN Deployment and commenting (non-forked PRs only)
   # when using pull_request event, we have permission to comment directly
   # if its a forked repo, we need to use workflow_run event in a separate workflow (pr-playwright-deploy.yaml)
 
-  # Post starting section into the unified PR report comment for non-forked PRs
+  # Post starting comment for non-forked PRs
   comment-on-pr-start:
-    needs: changes
     runs-on: ubuntu-latest
-    if: >-
-      ${{
-        needs.changes.outputs.should-run == 'true' &&
-        github.event_name == 'pull_request' &&
-        github.event.pull_request.head.repo.fork == false
-      }}
+    if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false
     permissions:
       pull-requests: write
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
 
-      - name: Upsert playwright starting section into unified report
-        uses: ./.github/actions/upsert-comment-section
-        with:
-          pr-number: ${{ github.event.pull_request.number }}
-          section-name: playwright
-          section-content: '## 🎭 Playwright: ⏳ Running...'
-          comment-marker: '<!-- COMFYUI_FRONTEND_PR_REPORT -->'
-          token: ${{ github.token }}
+      - name: Post starting comment
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+        run: |
+          chmod +x scripts/cicd/pr-playwright-deploy-and-comment.sh
+          ./scripts/cicd/pr-playwright-deploy-and-comment.sh \
+            "${{ github.event.pull_request.number }}" \
+            "${{ github.head_ref }}" \
+            "starting"
 
-  # Deploy and upsert final playwright section for non-forked PRs only
+  # Deploy and comment for non-forked PRs only
   deploy-and-comment:
-    needs: [changes, playwright-tests, merge-reports]
+    needs: [playwright-tests, merge-reports]
     runs-on: ubuntu-latest
-    if: >-
-      ${{
-        always() &&
-        needs.changes.outputs.should-run == 'true' &&
-        github.event_name == 'pull_request' &&
-        github.event.pull_request.head.repo.fork == false
-      }}
+    if: always() && github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false
     permissions:
       pull-requests: write
       contents: read
@@ -275,34 +226,15 @@ jobs:
           pattern: playwright-report-*
           path: reports
 
-      - name: Deploy reports and generate section
+      - name: Deploy reports and comment on PR
         env:
           CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           GITHUB_TOKEN: ${{ github.token }}
           GITHUB_SHA: ${{ github.event.pull_request.head.sha }}
-          SUMMARY_FILE: playwright-section.md
-          BRANCH_NAME: ${{ github.head_ref }}
         run: |
           bash ./scripts/cicd/pr-playwright-deploy-and-comment.sh \
             "${{ github.event.pull_request.number }}" \
-            "$BRANCH_NAME" \
+            "${{ github.head_ref }}" \
             "completed"
-
-      - name: Read playwright section
-        id: section
-        if: ${{ !cancelled() && hashFiles('playwright-section.md') != '' }}
-        uses: juliangruber/read-file-action@b549046febe0fe86f8cb4f93c24e284433f9ab58 # v1.1.7
-        with:
-          path: playwright-section.md
-
-      - name: Upsert playwright section into unified report
-        if: ${{ !cancelled() && steps.section.outputs.content != '' }}
-        uses: ./.github/actions/upsert-comment-section
-        with:
-          pr-number: ${{ github.event.pull_request.number }}
-          section-name: playwright
-          section-content: ${{ steps.section.outputs.content }}
-          comment-marker: '<!-- COMFYUI_FRONTEND_PR_REPORT -->'
-          token: ${{ github.token }}
   #### END Deployment and commenting (non-forked PRs only)

.github/workflows/ci-tests-storybook-forks.yaml

@@ -6,10 +6,6 @@ on:
     workflows: ['CI: Tests Storybook']
     types: [requested, completed]
 
-concurrency:
-  group: ${{ github.workflow }}-${{ github.event.workflow_run.head_repository.full_name }}-${{ github.event.workflow_run.head_branch }}
-  cancel-in-progress: true
-
 jobs:
   deploy-and-comment-forked-pr:
     runs-on: ubuntu-latest
@@ -34,22 +30,40 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v6
 
-      - name: Resolve PR from workflow_run context
+      - name: Get PR Number
         id: pr
-        uses: ./.github/actions/resolve-pr-from-workflow-run
-
-      - name: Handle Storybook Start — upsert storybook starting section
-        if: steps.pr.outputs.skip != 'true' && github.event.action == 'requested'
-        uses: ./.github/actions/upsert-comment-section
+        uses: actions/github-script@v8
         with:
-          pr-number: ${{ steps.pr.outputs.number }}
-          section-name: storybook
-          section-content: '## 🎨 Storybook: 🚧 Building...'
-          comment-marker: '<!-- COMFYUI_FRONTEND_PR_REPORT -->'
-          token: ${{ github.token }}
+          script: |
+            const { data: prs } = await github.rest.pulls.list({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              state: 'open',
+            });
+
+            const pr = prs.find(p => p.head.sha === context.payload.workflow_run.head_sha);
+
+            if (!pr) {
+              console.log('No PR found for SHA:', context.payload.workflow_run.head_sha);
+              return null;
+            }
+
+            console.log(`Found PR #${pr.number} from fork: ${context.payload.workflow_run.head_repository.full_name}`);
+            return pr.number;
+
+      - name: Handle Storybook Start
+        if: steps.pr.outputs.result != 'null' && github.event.action == 'requested'
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+        run: |
+          chmod +x scripts/cicd/pr-storybook-deploy-and-comment.sh
+          ./scripts/cicd/pr-storybook-deploy-and-comment.sh \
+            "${{ steps.pr.outputs.result }}" \
+            "${{ github.event.workflow_run.head_branch }}" \
+            "starting"
 
       - name: Download and Deploy Storybook
-        if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed' && github.event.workflow_run.conclusion == 'success'
+        if: steps.pr.outputs.result != 'null' && github.event.action == 'completed' && github.event.workflow_run.conclusion == 'success'
         uses: actions/download-artifact@v7
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
@@ -57,36 +71,17 @@ jobs:
           name: storybook-static
           path: storybook-static
 
-      - name: Handle Storybook Completion — deploy and generate section
-        if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed'
+      - name: Handle Storybook Completion
+        if: steps.pr.outputs.result != 'null' && github.event.action == 'completed'
         env:
           CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           GITHUB_TOKEN: ${{ github.token }}
           WORKFLOW_CONCLUSION: ${{ github.event.workflow_run.conclusion }}
           WORKFLOW_URL: ${{ github.event.workflow_run.html_url }}
-          SUMMARY_FILE: storybook-section.md
-          BRANCH_NAME: ${{ github.event.workflow_run.head_branch }}
         run: |
           chmod +x scripts/cicd/pr-storybook-deploy-and-comment.sh
           ./scripts/cicd/pr-storybook-deploy-and-comment.sh \
-            "${{ steps.pr.outputs.number }}" \
-            "$BRANCH_NAME" \
+            "${{ steps.pr.outputs.result }}" \
+            "${{ github.event.workflow_run.head_branch }}" \
             "completed"
-
-      - name: Read storybook section
-        id: section
-        if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed' && hashFiles('storybook-section.md') != ''
-        uses: juliangruber/read-file-action@b549046febe0fe86f8cb4f93c24e284433f9ab58 # v1.1.7
-        with:
-          path: storybook-section.md
-
-      - name: Upsert storybook section into unified report
-        if: steps.pr.outputs.skip != 'true' && github.event.action == 'completed' && steps.section.outputs.content != ''
-        uses: ./.github/actions/upsert-comment-section
-        with:
-          pr-number: ${{ steps.pr.outputs.number }}
-          section-name: storybook
-          section-content: ${{ steps.section.outputs.content }}
-          comment-marker: '<!-- COMFYUI_FRONTEND_PR_REPORT -->'
-          token: ${{ github.token }}

.github/workflows/ci-tests-storybook.yaml

@@ -8,53 +8,30 @@ on:
     branches: [main]
 
 jobs:
-  changes:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    outputs:
-      storybook-changes: ${{ steps.changes.outputs.storybook-changes }}
-      app-frontend-changes: ${{ steps.changes.outputs.app-frontend-changes }}
-      packages-changes: ${{ steps.changes.outputs.packages-changes }}
-    steps:
-      - uses: actions/checkout@v6
-      - id: changes
-        uses: ./.github/actions/changes-filter
-
   # Post starting comment for non-forked PRs
   comment-on-pr-start:
-    needs: changes
     runs-on: ubuntu-latest
-    if: |
-      github.event_name == 'pull_request'
-      && github.event.pull_request.head.repo.fork == false
-      && (needs.changes.outputs.storybook-changes == 'true'
-          || needs.changes.outputs.app-frontend-changes == 'true'
-          || needs.changes.outputs.packages-changes == 'true')
+    if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false
     permissions:
       pull-requests: write
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
 
-      - name: Upsert storybook starting section into unified report
-        uses: ./.github/actions/upsert-comment-section
-        with:
-          pr-number: ${{ github.event.pull_request.number }}
-          section-name: storybook
-          section-content: '## 🎨 Storybook: 🚧 Building...'
-          comment-marker: '<!-- COMFYUI_FRONTEND_PR_REPORT -->'
-          token: ${{ github.token }}
+      - name: Post starting comment
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+        run: |
+          chmod +x scripts/cicd/pr-storybook-deploy-and-comment.sh
+          ./scripts/cicd/pr-storybook-deploy-and-comment.sh \
+            "${{ github.event.pull_request.number }}" \
+            "${{ github.head_ref }}" \
+            "starting"
 
   # Build Storybook for all PRs (free Cloudflare deployment)
   storybook-build:
-    needs: changes
     runs-on: ubuntu-latest
-    if: |
-      github.event_name == 'pull_request'
-      && (needs.changes.outputs.storybook-changes == 'true'
-          || needs.changes.outputs.app-frontend-changes == 'true'
-          || needs.changes.outputs.packages-changes == 'true')
+    if: github.event_name == 'pull_request'
     outputs:
       conclusion: ${{ steps.job-status.outputs.conclusion }}
       workflow-url: ${{ steps.workflow-url.outputs.url }}
@@ -90,16 +67,8 @@ jobs:
 
   # Chromatic deployment only for version-bump-* branches or manual triggers
   chromatic-deployment:
-    needs: changes
     runs-on: ubuntu-latest
-    if: |
-      github.event_name == 'workflow_dispatch'
-      || (github.event_name == 'pull_request'
-          && github.event.pull_request.head.repo.fork == false
-          && startsWith(github.head_ref, 'version-bump-')
-          && (needs.changes.outputs.storybook-changes == 'true'
-              || needs.changes.outputs.app-frontend-changes == 'true'
-              || needs.changes.outputs.packages-changes == 'true'))
+    if: github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'version-bump-'))
     outputs:
       conclusion: ${{ steps.job-status.outputs.conclusion }}
       workflow-url: ${{ steps.workflow-url.outputs.url }}
@@ -138,15 +107,9 @@ jobs:
 
   # Deploy and comment for non-forked PRs only
   deploy-and-comment:
-    needs: [changes, storybook-build]
+    needs: [storybook-build]
     runs-on: ubuntu-latest
-    if: |
-      always()
-      && github.event_name == 'pull_request'
-      && github.event.pull_request.head.repo.fork == false
-      && (needs.changes.outputs.storybook-changes == 'true'
-          || needs.changes.outputs.app-frontend-changes == 'true'
-          || needs.changes.outputs.packages-changes == 'true')
+    if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false && always()
     permissions:
       pull-requests: write
       contents: read
@@ -164,38 +127,19 @@ jobs:
       - name: Make deployment script executable
         run: chmod +x scripts/cicd/pr-storybook-deploy-and-comment.sh
 
-      - name: Deploy Storybook and generate section
+      - name: Deploy Storybook and comment on PR
         env:
           CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
           GITHUB_TOKEN: ${{ github.token }}
           WORKFLOW_CONCLUSION: ${{ needs.storybook-build.outputs.conclusion }}
           WORKFLOW_URL: ${{ needs.storybook-build.outputs.workflow-url }}
-          SUMMARY_FILE: storybook-section.md
-          BRANCH_NAME: ${{ github.head_ref }}
         run: |
           ./scripts/cicd/pr-storybook-deploy-and-comment.sh \
             "${{ github.event.pull_request.number }}" \
-            "$BRANCH_NAME" \
+            "${{ github.head_ref }}" \
             "completed"
 
-      - name: Read storybook section
-        id: section
-        if: hashFiles('storybook-section.md') != ''
-        uses: juliangruber/read-file-action@b549046febe0fe86f8cb4f93c24e284433f9ab58 # v1.1.7
-        with:
-          path: storybook-section.md
-
-      - name: Upsert storybook section into unified report
-        if: steps.section.outputs.content != ''
-        uses: ./.github/actions/upsert-comment-section
-        with:
-          pr-number: ${{ github.event.pull_request.number }}
-          section-name: storybook
-          section-content: ${{ steps.section.outputs.content }}
-          comment-marker: '<!-- COMFYUI_FRONTEND_PR_REPORT -->'
-          token: ${{ github.token }}
-
   # Deploy Storybook to production URL on main branch push
   deploy-production:
     runs-on: ubuntu-latest
@@ -227,17 +171,35 @@ jobs:
     permissions:
       pull-requests: write
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v6
-
-      - name: Upsert Chromatic section into unified report
-        uses: ./.github/actions/upsert-comment-section
+      - name: Update comment with Chromatic URLs
+        uses: actions/github-script@v8
         with:
-          pr-number: ${{ github.event.pull_request.number }}
-          section-name: chromatic
-          section-content: |
-            ### 🎨 Chromatic Visual Tests
-            - 📊 [View Chromatic Build](${{ needs.chromatic-deployment.outputs.chromatic-build-url }})
-            - 📚 [View Chromatic Storybook](${{ needs.chromatic-deployment.outputs.chromatic-storybook-url }})
-          comment-marker: '<!-- COMFYUI_FRONTEND_PR_REPORT -->'
-          token: ${{ github.token }}
+          script: |
+            const buildUrl = '${{ needs.chromatic-deployment.outputs.chromatic-build-url }}';
+            const storybookUrl = '${{ needs.chromatic-deployment.outputs.chromatic-storybook-url }}';
+
+            // Find the existing Storybook comment
+            const { data: comments } = await github.rest.issues.listComments({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: ${{ github.event.pull_request.number }}
+            });
+
+            const storybookComment = comments.find(comment =>
+              comment.body.includes('<!-- STORYBOOK_BUILD_STATUS -->')
+            );
+
+            if (storybookComment && buildUrl && storybookUrl) {
+              // Append Chromatic info to existing comment
+              const updatedBody = storybookComment.body.replace(
+                /---\n(.*)$/s,
+                `---\n### 🎨 Chromatic Visual Tests\n- 📊 [View Chromatic Build](${buildUrl})\n- 📚 [View Chromatic Storybook](${storybookUrl})\n\n$1`
+              );
+
+              await github.rest.issues.updateComment({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                comment_id: storybookComment.id,
+                body: updatedBody
+              });
+            }

.github/workflows/ci-tests-unit.yaml

@@ -4,29 +4,17 @@ name: 'CI: Tests Unit'
 on:
   push:
     branches: [main, master, dev*, core/*, desktop/*]
+    paths-ignore: ['**/*.md']
   pull_request:
     branches-ignore: [wip/*, draft/*, temp/*]
-  merge_group:
+    paths-ignore: ['**/*.md']
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
 jobs:
-  changes:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    outputs:
-      should-run: ${{ steps.changes.outputs.should-run }}
-    steps:
-      - uses: actions/checkout@v6
-      - id: changes
-        uses: ./.github/actions/changes-filter
-
   test:
-    needs: changes
-    if: ${{ needs.changes.outputs.should-run == 'true' }}
     runs-on: ubuntu-latest
 
     steps:
@@ -38,20 +26,10 @@ jobs:
       - name: Run Vitest tests with coverage
         run: pnpm test:coverage
 
-      - name: Upload unit coverage artifact
-        if: always() && github.event_name == 'push'
-        uses: actions/upload-artifact@v6
-        with:
-          name: unit-coverage
-          path: coverage/lcov.info
-          retention-days: 30
-          if-no-files-found: warn
-
       - name: Upload coverage to Codecov
         if: always()
         uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5.5.3
         with:
           files: coverage/lcov.info
-          flags: unit
           token: ${{ secrets.CODECOV_TOKEN }}
           fail_ci_if_error: false

.github/workflows/ci-vercel-website-preview.yaml

@@ -1,178 +0,0 @@
----
-name: 'CI: Vercel Website Preview'
-
-on:
-  pull_request:
-    types: [opened, synchronize, reopened]
-    branches-ignore:
-      - 'core/**'
-      - 'cloud/**'
-    paths:
-      - 'apps/website/**'
-      - 'packages/design-system/**'
-      - 'packages/tailwind-utils/**'
-  push:
-    branches: [main]
-    paths:
-      - 'apps/website/**'
-      - 'packages/design-system/**'
-      - 'packages/tailwind-utils/**'
-
-env:
-  VERCEL_ORG_ID: ${{ secrets.VERCEL_WEBSITE_ORG_ID }}
-  VERCEL_PROJECT_ID: ${{ secrets.VERCEL_WEBSITE_PROJECT_ID }}
-  VERCEL_TOKEN: ${{ secrets.VERCEL_WEBSITE_TOKEN }}
-  VERCEL_SCOPE: comfyui
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true
-
-jobs:
-  deploy-preview:
-    if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    env:
-      ALIAS_HOST: comfy-website-preview-pr-${{ github.event.pull_request.number }}.vercel.app
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v6
-
-      - name: Install pnpm
-        uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
-
-      - name: Setup Node
-        uses: actions/setup-node@v6
-        with:
-          node-version-file: '.nvmrc'
-
-      - name: Install Vercel CLI
-        run: npm install --global vercel@latest
-
-      - name: Pull Vercel environment information
-        run: vercel pull --yes --environment=preview
-
-      - name: Build project artifacts
-        env:
-          WEBSITE_ASHBY_API_KEY: ${{ secrets.WEBSITE_ASHBY_API_KEY }}
-          WEBSITE_ASHBY_JOB_BOARD_NAME: ${{ secrets.WEBSITE_ASHBY_JOB_BOARD_NAME }}
-          WEBSITE_CLOUD_API_KEY: ${{ secrets.WEBSITE_CLOUD_API_KEY }}
-        run: vercel build
-
-      - name: Fetch head commit metadata
-        id: head-commit
-        uses: actions/github-script@v8
-        with:
-          script: |
-            const { data } = await github.rest.repos.getCommit({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              ref: context.payload.pull_request.head.sha,
-            })
-            const author = data.author?.login || data.commit.author?.name || ''
-            const message = (data.commit.message || '').split('\n', 1)[0]
-            core.setOutput('author', author)
-            core.setOutput('message', message)
-
-      - name: Deploy project artifacts to Vercel
-        id: deploy
-        env:
-          GIT_COMMIT_REF: ${{ github.event.pull_request.head.ref }}
-          GIT_COMMIT_SHA: ${{ github.event.pull_request.head.sha }}
-          GIT_AUTHOR_LOGIN: ${{ steps.head-commit.outputs.author }}
-          GIT_COMMIT_MESSAGE: ${{ steps.head-commit.outputs.message }}
-          GIT_PR_ID: ${{ github.event.pull_request.number }}
-          GIT_REPO: ${{ github.repository }}
-        run: |
-          URL=$(vercel deploy --prebuilt \
-            --meta githubCommitRef="$GIT_COMMIT_REF" \
-            --meta githubCommitSha="$GIT_COMMIT_SHA" \
-            --meta githubCommitAuthorLogin="$GIT_AUTHOR_LOGIN" \
-            --meta githubCommitMessage="$GIT_COMMIT_MESSAGE" \
-            --meta githubPrId="$GIT_PR_ID" \
-            --meta githubRepo="$GIT_REPO")
-          echo "url=$URL" >> "$GITHUB_OUTPUT"
-
-      - name: Alias deployment to stable PR hostname
-        id: alias-set
-        continue-on-error: true
-        env:
-          DEPLOY_URL: ${{ steps.deploy.outputs.url }}
-        run: |
-          vercel alias set "$DEPLOY_URL" "$ALIAS_HOST" --scope="$VERCEL_SCOPE"
-
-      - name: Publish preview outputs
-        env:
-          DEPLOY_URL: ${{ steps.deploy.outputs.url }}
-          ALIAS_OK: ${{ steps.alias-set.outcome == 'success' }}
-        run: |
-          if [[ "$ALIAS_OK" == "true" ]]; then
-            STABLE_URL="https://$ALIAS_HOST"
-          else
-            STABLE_URL="$DEPLOY_URL"
-          fi
-          mkdir -p temp/vercel-preview
-          echo "$DEPLOY_URL" > temp/vercel-preview/url.txt
-          echo "$STABLE_URL" > temp/vercel-preview/stable-url.txt
-          {
-            echo "**Preview:** $STABLE_URL"
-            if [[ "$ALIAS_OK" == "true" ]]; then
-              echo "**This commit:** $DEPLOY_URL"
-            else
-              echo "_Stable alias update failed — URL reflects this commit only._"
-            fi
-          } >> "$GITHUB_STEP_SUMMARY"
-
-      - name: Upload preview metadata
-        uses: actions/upload-artifact@v6
-        with:
-          name: vercel-preview
-          path: temp/vercel-preview
-
-  deploy-production:
-    if: github.event_name == 'push'
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v6
-
-      - name: Install pnpm
-        uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
-
-      - name: Setup Node
-        uses: actions/setup-node@v6
-        with:
-          node-version-file: '.nvmrc'
-
-      - name: Install Vercel CLI
-        run: npm install --global vercel@latest
-
-      - name: Pull Vercel environment information
-        run: vercel pull --yes --environment=production
-
-      - name: Verify WEBSITE_CLOUD_API_KEY is present for production build
-        env:
-          WEBSITE_CLOUD_API_KEY: ${{ secrets.WEBSITE_CLOUD_API_KEY }}
-        run: |
-          if [ -z "${WEBSITE_CLOUD_API_KEY:-}" ]; then
-            echo "::error title=Missing WEBSITE_CLOUD_API_KEY::Production builds require WEBSITE_CLOUD_API_KEY so /cloud/supported-nodes is generated from fresh Cloud API data. Add it as a GitHub Actions repo secret and to the Vercel project environment. See apps/website/README.md."
-            exit 1
-          fi
-
-      - name: Build project artifacts
-        env:
-          WEBSITE_ASHBY_API_KEY: ${{ secrets.WEBSITE_ASHBY_API_KEY }}
-          WEBSITE_ASHBY_JOB_BOARD_NAME: ${{ secrets.WEBSITE_ASHBY_JOB_BOARD_NAME }}
-          WEBSITE_CLOUD_API_KEY: ${{ secrets.WEBSITE_CLOUD_API_KEY }}
-        run: vercel build --prod
-
-      - name: Deploy project artifacts to Vercel
-        id: deploy
-        run: |
-          URL=$(vercel deploy --prebuilt --prod)
-          echo "url=$URL" >> "$GITHUB_OUTPUT"
-
-      - name: Add deployment URL to summary
-        run: echo "**Production:** ${{ steps.deploy.outputs.url }}" >> "$GITHUB_STEP_SUMMARY"

.github/workflows/ci-website-build.yaml

@@ -4,29 +4,23 @@ name: 'CI: Website Build'
 on:
   push:
     branches: [main, master, website/*]
+    paths:
+      - 'apps/website/**'
+      - 'packages/design-system/**'
+      - 'pnpm-lock.yaml'
   pull_request:
     branches-ignore: [wip/*, draft/*, temp/*]
+    paths:
+      - 'apps/website/**'
+      - 'packages/design-system/**'
+      - 'pnpm-lock.yaml'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
 jobs:
-  changes:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    outputs:
-      app-website-changes: ${{ steps.changes.outputs.app-website-changes }}
-      packages-changes: ${{ steps.changes.outputs.packages-changes }}
-    steps:
-      - uses: actions/checkout@v6
-      - id: changes
-        uses: ./.github/actions/changes-filter
-
   build:
-    needs: changes
-    if: ${{ needs.changes.outputs.app-website-changes == 'true' || needs.changes.outputs.packages-changes == 'true' }}
     runs-on: ubuntu-latest
 
     steps:
@@ -36,10 +30,4 @@ jobs:
         uses: ./.github/actions/setup-frontend
 
       - name: Build website
-        env:
-          WEBSITE_ASHBY_API_KEY: ${{ secrets.WEBSITE_ASHBY_API_KEY }}
-          WEBSITE_ASHBY_JOB_BOARD_NAME: ${{ secrets.WEBSITE_ASHBY_JOB_BOARD_NAME }}
         run: pnpm --filter @comfyorg/website build
-
-      - name: Validate JSON-LD structured data
-        run: pnpm --filter @comfyorg/website validate:jsonld

.github/workflows/ci-website-e2e.yaml

@@ -1,278 +0,0 @@
-name: 'CI: Website E2E'
-
-on:
-  push:
-    branches: [main]
-  pull_request:
-    branches-ignore: [wip/*, draft/*, temp/*]
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.repository }}-${{ github.head_ref || github.ref }}
-  cancel-in-progress: true
-
-jobs:
-  changes:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    outputs:
-      app-website-changes: ${{ steps.changes.outputs.app-website-changes }}
-      packages-changes: ${{ steps.changes.outputs.packages-changes }}
-    steps:
-      - uses: actions/checkout@v6
-      - id: changes
-        uses: ./.github/actions/changes-filter
-
-  website-e2e:
-    needs: changes
-    if: ${{ needs.changes.outputs.app-website-changes == 'true' || needs.changes.outputs.packages-changes == 'true' }}
-    runs-on: ubuntu-latest
-    container:
-      image: mcr.microsoft.com/playwright:v1.58.1-noble
-    timeout-minutes: 15
-    permissions:
-      contents: read
-    outputs:
-      test-outcome: ${{ steps.tests.outcome }}
-      report-url: ${{ steps.deploy.outputs.url }}
-      screenshot-failures: ${{ steps.failures.outputs.screenshot }}
-      other-failures: ${{ steps.failures.outputs.other }}
-      # Evaluated at job level (not from a step) — static expression.
-      is-pr: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false }}
-    steps:
-      - uses: actions/checkout@v6
-
-      - name: Install pnpm
-        run: corepack enable && corepack prepare
-
-      - name: Install dependencies
-        run: pnpm install --frozen-lockfile
-
-      - name: Build website
-        env:
-          WEBSITE_GITHUB_STARS_OVERRIDE: 110000
-        run: pnpm --filter @comfyorg/website build
-
-      - name: Run Playwright tests
-        id: tests
-        run: pnpm --filter @comfyorg/website test:e2e
-
-      - name: Upload test report
-        uses: actions/upload-artifact@v6
-        if: ${{ !cancelled() }}
-        with:
-          name: website-playwright-report
-          path: apps/website/playwright-report/
-          retention-days: 30
-
-      - name: Deploy report to Cloudflare
-        id: deploy
-        if: >-
-          ${{
-            always() &&
-            !cancelled() &&
-            (
-              github.event_name != 'pull_request' ||
-              github.event.pull_request.head.repo.fork == false
-            )
-          }}
-        env:
-          CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
-          CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
-          HEAD_REF: ${{ github.head_ref || github.ref_name }}
-        run: |
-          BRANCH=$(echo "$HEAD_REF" | tr '[:upper:]' '[:lower:]' | sed 's/[^a-z0-9-]/-/g;s/--*/-/g;s/^-\|-$//g')
-          DEPLOY_OK=false
-          for i in 1 2 3; do
-            echo "Deployment attempt $i of 3..."
-            OUTPUT=$(npx wrangler@^4.0.0 pages deploy apps/website/playwright-report \
-              --project-name=comfyui-website-e2e \
-              --branch="$BRANCH" 2>&1) && { DEPLOY_OK=true; break; } || echo "$OUTPUT"
-            [ $i -lt 3 ] && sleep 10
-          done
-          echo "$OUTPUT"
-          if [ "$DEPLOY_OK" != "true" ]; then
-            echo "::error::All 3 deployment attempts failed"
-            exit 1
-          fi
-          URL=$(echo "$OUTPUT" | grep -oE 'https://[a-zA-Z0-9.-]+\.pages\.dev\S*' | head -1)
-          echo "url=${URL}" >> $GITHUB_OUTPUT
-
-      - name: Categorize failures
-        id: failures
-        if: always() && !cancelled() && steps.tests.outcome != 'success'
-        uses: actions/github-script@v8
-        with:
-          script: |
-            const fs = require('fs')
-            const report = JSON.parse(fs.readFileSync('apps/website/results.json', 'utf8'))
-
-            function isFailed(t) { return t.status === 'unexpected' || t.status === 'flaky' }
-            function isVisual(spec) {
-              return spec.file?.includes('visual') ||
-                spec.tests?.some(t => t.results?.some(r => r.error?.message?.includes('toHaveScreenshot')))
-            }
-            function specsOf(suite) {
-              return [
-                ...(suite.specs || []),
-                ...(suite.suites || []).flatMap(specsOf)
-              ]
-            }
-
-            // True:  Visual
-            // False: Other
-            const failed = specsOf(report)
-              .flatMap(spec => (spec.tests || [])
-              .filter(isFailed)
-              .map(() => isVisual(spec)))
-
-            const screenshotFailures = failed.filter(Boolean).length
-            core.setOutput('screenshot', screenshotFailures)
-            core.setOutput('other', failed.length - screenshotFailures)
-
-      - name: Write job summary
-        if: always() && !cancelled()
-        uses: actions/github-script@v8
-        env:
-          TEST_OUTCOME: ${{ steps.tests.outcome }}
-          REPORT_URL: ${{ steps.deploy.outputs.url }}
-          SCREENSHOT_FAILURES: ${{ steps.failures.outputs.screenshot }}
-          OTHER_FAILURES: ${{ steps.failures.outputs.other }}
-        with:
-          script: |
-            const passed = process.env.TEST_OUTCOME === 'success'
-            const reportUrl = process.env.REPORT_URL
-            const screenshotFailures = parseInt(process.env.SCREENSHOT_FAILURES) || 0
-            const otherFailures = parseInt(process.env.OTHER_FAILURES) || 0
-
-            const lines = ['## 🌐 Website E2E', '']
-
-            if (passed) {
-              lines.push('> [!TIP]', '> All tests passed.')
-            } else {
-              lines.push('> [!CAUTION]', '> Some tests failed.')
-            }
-
-            const rows = [
-              ['Status', passed ? '✅ Passed' : '❌ Failed'],
-              ['Report', reportUrl ? `[View Report](${reportUrl})` : '_unavailable_']
-            ]
-            if (!passed) {
-              rows.push(
-                ['Screenshot diffs', String(screenshotFailures)],
-                ['Other failures', String(otherFailures)]
-              )
-            }
-            lines.push(
-              '',
-              '| | |',
-              '|---|---|',
-              ...rows.map(([k, v]) => `| **${k}** | ${v} |`)
-            )
-
-            await core.summary.addRaw(lines.join('\n')).write()
-
-  post-starting-comment:
-    # Safe to comment from pull_request trigger: fork PRs are excluded by the guard below.
-    # This avoids a ci-*/pr-* workflow_run split for a comment that must appear immediately.
-    needs: changes
-    if: |
-      github.event_name == 'pull_request'
-      && github.event.pull_request.head.repo.fork == false
-      && (needs.changes.outputs.app-website-changes == 'true' || needs.changes.outputs.packages-changes == 'true')
-    runs-on: ubuntu-latest
-    permissions:
-      pull-requests: write
-      contents: read
-    concurrency:
-      group: website-pr-comment-${{ github.event.pull_request.number }}
-      cancel-in-progress: false
-    steps:
-      - uses: actions/checkout@v6
-      - uses: ./.github/actions/upsert-comment-section
-        with:
-          pr-number: ${{ github.event.pull_request.number }}
-          section-name: e2e
-          comment-marker: '<!-- WEBSITE_CI_REPORT -->'
-          token: ${{ secrets.GITHUB_TOKEN }}
-          section-content: |-
-            ## 🌐 Website E2E
-            <!-- WEBSITE_E2E_STATUS -->
-
-            > [!NOTE]
-            > Tests are running… [View workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
-
-  post-result-comment:
-    needs: website-e2e
-    if: always() && !cancelled() && needs.website-e2e.outputs.is-pr == 'true'
-    runs-on: ubuntu-latest
-    permissions:
-      pull-requests: write
-      contents: read
-    concurrency:
-      group: website-pr-comment-${{ github.event.pull_request.number }}
-      cancel-in-progress: false
-    steps:
-      - uses: actions/checkout@v6
-
-      - name: Build e2e section content
-        id: content
-        uses: actions/github-script@v8
-        env:
-          TEST_OUTCOME: ${{ needs.website-e2e.outputs.test-outcome }}
-          REPORT_URL: ${{ needs.website-e2e.outputs.report-url }}
-          SCREENSHOT_FAILURES: ${{ needs.website-e2e.outputs.screenshot-failures }}
-          OTHER_FAILURES: ${{ needs.website-e2e.outputs.other-failures }}
-        with:
-          script: |
-            const passed = process.env.TEST_OUTCOME === 'success'
-            const reportUrl = process.env.REPORT_URL
-            const screenshotFailures = parseInt(process.env.SCREENSHOT_FAILURES) || 0
-            const otherFailures = parseInt(process.env.OTHER_FAILURES) || 0
-
-            const lines = ['## 🌐 Website E2E', '<!-- WEBSITE_E2E_STATUS -->', '']
-
-            if (passed) {
-              lines.push('> [!TIP]', '> All tests passed.')
-            } else {
-              lines.push('> [!CAUTION]', '> Some tests failed.')
-            }
-
-            const rows = [
-              ['Status', passed ? '✅ Passed' : '❌ Failed'],
-              ['Report', reportUrl ? `[View Report](${reportUrl})` : '_unavailable_']
-            ]
-            if (!passed) {
-              rows.push(
-                ['Screenshot diffs', String(screenshotFailures)],
-                ['Other failures', String(otherFailures)]
-              )
-            }
-            lines.push(
-              '',
-              '| | |',
-              '|---|---|',
-              ...rows.map(([k, v]) => `| **${k}** | ${v} |`)
-            )
-
-            if (screenshotFailures > 0) {
-              const s = screenshotFailures === 1 ? '' : 's'
-              lines.push('', `- [ ] Update website screenshots (${screenshotFailures} screenshot diff${s})`)
-            }
-            if (otherFailures > 0) {
-              lines.push(
-                '',
-                '> [!WARNING]',
-                `> ${otherFailures} non-screenshot failure${otherFailures === 1 ? '' : 's'} — these require manual review.`
-              )
-            }
-
-            core.setOutput('section-content', lines.join('\n'))
-
-      - uses: ./.github/actions/upsert-comment-section
-        with:
-          pr-number: ${{ github.event.pull_request.number }}
-          section-name: e2e
-          comment-marker: '<!-- WEBSITE_CI_REPORT -->'
-          token: ${{ secrets.GITHUB_TOKEN }}
-          section-content: ${{ steps.content.outputs.section-content }}

.github/workflows/cla.yml

@@ -1,99 +0,0 @@
-name: CLA Assistant
-
-on:
-  issue_comment:
-    types: [created]
-  pull_request_target:
-    types: [opened, synchronize, closed]
-  merge_group:
-    types: [checks_requested]
-
-permissions:
-  actions: write
-  contents: read # 'read' is enough because signatures live in a REMOTE repo
-  pull-requests: write
-  statuses: write
-
-jobs:
-  cla-assistant:
-    runs-on: ubuntu-latest
-    steps:
-      - name: CLA already verified before merge queue
-        if: github.event_name == 'merge_group'
-        run: echo "CLA is checked on the pull request before it enters merge queue."
-
-      # The CLA action normally requires every commit author in a PR to sign.
-      # We only want the PR author to sign, so we allowlist all other committers
-      # by computing them from the PR's commits and excluding the PR author.
-      - name: Build author-only allowlist
-        id: allowlist
-        if: >
-          github.event_name == 'pull_request_target' ||
-          (github.event_name == 'issue_comment' && github.event.issue.pull_request && (
-            github.event.comment.body == 'recheck' ||
-            github.event.comment.body == 'I have read and agree to the Contributor License Agreement'
-          ))
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }}
-          PR_AUTHOR: ${{ github.event.pull_request.user.login || github.event.issue.user.login }}
-          BASE_ALLOWLIST: action@github.com,actions-user,ampagent,claude,comfy-pr-bot,GitHub Action,github-actions,github-actions[bot],Glary Bot,Glary-Bot,*[bot]
-        # For each commit emit the GitHub login when the author/committer email resolves to a GitHub account
-        # otherwise fall back to the raw git name.
-        run: |
-          others=$(gh api "repos/${{ github.repository }}/pulls/${PR_NUMBER}/commits" --paginate \
-            --jq '.[] | (.author.login // .commit.author.name // empty), (.committer.login // .commit.committer.name // empty)' \
-            | sort -u | grep -vix "${PR_AUTHOR}" | paste -sd, -)
-          if [ -n "$others" ]; then
-            echo "allowlist=${BASE_ALLOWLIST},${others}" >> "$GITHUB_OUTPUT"
-          else
-            echo "allowlist=${BASE_ALLOWLIST}" >> "$GITHUB_OUTPUT"
-          fi
-
-      - name: CLA Assistant
-        # Run on PR events, on "recheck" comment, or when someone posts the exact signing phrase.
-        # IMPORTANT: this phrase must match `custom-pr-sign-comment` below.
-        if: >
-          github.event_name == 'pull_request_target' ||
-          (github.event_name == 'issue_comment' && github.event.issue.pull_request && (
-            github.event.comment.body == 'recheck' ||
-            github.event.comment.body == 'I have read and agree to the Contributor License Agreement'
-          ))
-        uses: contributor-assistant/github-action@ca4a40a7d1004f18d9960b404b97e5f30a505a08 # v2.6.1
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          # PAT required to write to the centralized signatures repo.
-          PERSONAL_ACCESS_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
-        with:
-          # Where the CLA document lives (shown to contributors)
-          path-to-document: https://github.com/Comfy-Org/comfy-cla/blob/main/comfyui_icla.md
-
-          # Centralized signature storage
-          remote-organization-name: comfy-org
-          remote-repository-name: comfy-cla
-          path-to-signatures: signatures/cla.json
-          branch: main
-
-          # Only the PR author must sign: bots plus every non-author committer
-          # are allowlisted via the "Build author-only allowlist" step above.
-          # *[bot] is a catch-all for any GitHub App bot account.
-          allowlist: ${{ steps.allowlist.outputs.allowlist }}
-
-          # Custom PR comment messages
-          custom-notsigned-prcomment: |
-            🎉 Thank you for your contribution, we really appreciate it! 🎉
-
-            Like many open source projects, we require contributors to sign our [Contributor License Agreement (CLA)](https://github.com/Comfy-Org/comfy-cla/blob/main/comfyui_icla.md). A CLA makes the ownership of contributions explicit, so contributors and the project share a clear understanding of how the code can be used. By signing, you:
-
-            - Confirm that you own your contribution.
-            - Keep the right to reuse your own code.
-            - Grant us a copyright license to include and share it within our projects.
-
-            CLAs are standard practice across major open source projects including those under the Apache Software Foundation and the Linux Foundation. Ours is based on the Apache Software Foundation's CLA. Most importantly, it would enable us to relicense the project under a more permissive license in the future, giving the project and its community greater flexibility.
-
-            ✍ **To sign, please post a new comment on this PR with exactly the following text:** ✍
-
-          custom-pr-sign-comment: I have read and agree to the Contributor License Agreement
-
-          custom-allsigned-prcomment: |
-            ✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged.

.github/workflows/cloud-dispatch-build.yaml

@@ -32,13 +32,12 @@ jobs:
     if: >
       github.repository == 'Comfy-Org/ComfyUI_frontend' &&
       (github.event_name != 'pull_request' ||
-       (github.event.pull_request.head.repo.fork == false &&
-        ((github.event.action == 'labeled' &&
-          contains(fromJSON('["preview","preview-cpu","preview-gpu"]'), github.event.label.name)) ||
-         (github.event.action == 'synchronize' &&
-          (contains(github.event.pull_request.labels.*.name, 'preview') ||
-           contains(github.event.pull_request.labels.*.name, 'preview-cpu') ||
-           contains(github.event.pull_request.labels.*.name, 'preview-gpu'))))))
+       (github.event.action == 'labeled' &&
+        contains(fromJSON('["preview","preview-cpu","preview-gpu"]'), github.event.label.name)) ||
+       (github.event.action == 'synchronize' &&
+        (contains(github.event.pull_request.labels.*.name, 'preview') ||
+         contains(github.event.pull_request.labels.*.name, 'preview-cpu') ||
+         contains(github.event.pull_request.labels.*.name, 'preview-gpu'))))
     runs-on: ubuntu-latest
     steps:
       - name: Build client payload

.github/workflows/cloud-dispatch-cleanup.yaml

@@ -21,7 +21,6 @@ jobs:
     # - Preview label specifically removed
     if: >
       github.repository == 'Comfy-Org/ComfyUI_frontend' &&
-      github.event.pull_request.head.repo.fork == false &&
       ((github.event.action == 'closed' &&
         (contains(github.event.pull_request.labels.*.name, 'preview') ||
          contains(github.event.pull_request.labels.*.name, 'preview-cpu') ||

.github/workflows/coverage-slack-notify.yaml

@@ -1,149 +0,0 @@
-name: 'Coverage: Slack Notification'
-
-on:
-  workflow_run:
-    workflows: ['CI: Tests Unit']
-    branches: [main]
-    types:
-      - completed
-
-permissions:
-  contents: read
-  actions: read
-  pull-requests: read
-
-jobs:
-  notify:
-    if: >
-      github.repository == 'Comfy-Org/ComfyUI_frontend' &&
-      github.event.workflow_run.conclusion == 'success' &&
-      github.event.workflow_run.event == 'push'
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v6
-
-      - name: Setup frontend
-        uses: ./.github/actions/setup-frontend
-
-      - name: Download current unit coverage
-        uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
-        with:
-          run_id: ${{ github.event.workflow_run.id }}
-          name: unit-coverage
-          path: coverage
-
-      - name: Download previous unit coverage baseline
-        continue-on-error: true
-        uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
-        with:
-          branch: main
-          workflow: coverage-slack-notify.yaml
-          name: unit-coverage-baseline
-          path: temp/coverage-baseline
-          if_no_artifact_found: warn
-
-      - name: Download latest E2E coverage
-        continue-on-error: true
-        uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
-        with:
-          branch: main
-          workflow: ci-tests-e2e-coverage.yaml
-          name: e2e-coverage
-          path: temp/e2e-coverage
-          if_no_artifact_found: warn
-
-      - name: Download previous E2E coverage baseline
-        continue-on-error: true
-        uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
-        with:
-          branch: main
-          workflow: coverage-slack-notify.yaml
-          name: e2e-coverage-baseline
-          path: temp/e2e-coverage-baseline
-          if_no_artifact_found: warn
-
-      - name: Resolve merged PR metadata
-        id: pr-meta
-        uses: actions/github-script@v8
-        with:
-          script: |
-            const sha = context.payload.workflow_run.head_sha;
-            const { data: commit } = await github.rest.repos.getCommit({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              ref: sha,
-            });
-            const message = commit.commit.message ?? '';
-            const firstLine = message.split('\n')[0];
-            const match = firstLine.match(/\(#(\d+)\)\s*$/);
-            if (!match) {
-              core.setOutput('skip', 'true');
-              core.info('No PR number found in commit message — skipping.');
-              return;
-            }
-            const prNumber = match[1];
-            const { data: pr } = await github.rest.pulls.get({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: Number(prNumber),
-            });
-            core.setOutput('skip', 'false');
-            core.setOutput('number', prNumber);
-            core.setOutput('url', pr.html_url);
-            core.setOutput('author', pr.user.login);
-
-      - name: Generate Slack notification
-        if: steps.pr-meta.outputs.skip != 'true'
-        id: slack-payload
-        env:
-          PR_URL: ${{ steps.pr-meta.outputs.url }}
-          PR_NUMBER: ${{ steps.pr-meta.outputs.number }}
-          PR_AUTHOR: ${{ steps.pr-meta.outputs.author }}
-        run: |
-          PAYLOAD=$(pnpm exec tsx scripts/coverage-slack-notify.ts \
-            --pr-url="$PR_URL" \
-            --pr-number="$PR_NUMBER" \
-            --author="$PR_AUTHOR")
-          if [ -n "$PAYLOAD" ]; then
-            echo "has_payload=true" >> "$GITHUB_OUTPUT"
-            DELIM="SLACK_PAYLOAD_$(date +%s)"
-            echo "payload<<$DELIM" >> "$GITHUB_OUTPUT"
-            printf '%s\n' "$PAYLOAD" >> "$GITHUB_OUTPUT"
-            echo "$DELIM" >> "$GITHUB_OUTPUT"
-          else
-            echo "has_payload=false" >> "$GITHUB_OUTPUT"
-          fi
-
-      - name: Post to Slack
-        if: steps.slack-payload.outputs.has_payload == 'true'
-        continue-on-error: true
-        env:
-          SLACK_PAYLOAD: ${{ steps.slack-payload.outputs.payload }}
-          SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
-        run: |
-          # Channel: #p-deprecated-frontend-automated-testing
-          BODY=$(echo "$SLACK_PAYLOAD" | jq --arg ch "C0AP09LKRDZ" '. + {channel: $ch}')
-          curl -sf -X POST \
-            -H "Authorization: Bearer $SLACK_BOT_TOKEN" \
-            -H "Content-Type: application/json" \
-            -d "$BODY" \
-            -o /dev/null \
-            https://slack.com/api/chat.postMessage
-
-      - name: Save unit coverage baseline
-        if: always() && hashFiles('coverage/lcov.info') != ''
-        uses: actions/upload-artifact@v6
-        with:
-          name: unit-coverage-baseline
-          path: coverage/lcov.info
-          retention-days: 90
-          if-no-files-found: warn
-
-      - name: Save E2E coverage baseline
-        if: always() && hashFiles('temp/e2e-coverage/coverage.lcov') != ''
-        uses: actions/upload-artifact@v6
-        with:
-          name: e2e-coverage-baseline
-          path: temp/e2e-coverage/coverage.lcov
-          retention-days: 90
-          if-no-files-found: warn

.github/workflows/detect-unreviewed-merge.yml

@@ -1,24 +0,0 @@
-name: Detect Unreviewed Merge
-
-# SOC 2 compliance — reusable workflow lives in Comfy-Org/github-workflows,
-# tracking issues are filed in Comfy-Org/unreviewed-merges.
-
-on:
-  push:
-    branches: [main, master]
-
-concurrency:
-  group: detect-unreviewed-merge-${{ github.sha }}
-  cancel-in-progress: false
-
-permissions:
-  contents: read
-  pull-requests: read
-
-jobs:
-  detect:
-    uses: Comfy-Org/github-workflows/.github/workflows/detect-unreviewed-merge.yml@4d9cb6b87f953bb7cd69954280e1465fb9bd2040 # v1
-    with:
-      approval-mode: latest-per-reviewer
-    secrets:
-      UNREVIEWED_MERGES_TOKEN: ${{ secrets.UNREVIEWED_MERGES_TOKEN }}

.github/workflows/model-page-discovery.yaml

@@ -1,123 +0,0 @@
-name: Model Page Discovery
-
-on:
-  schedule:
-    - cron: '0 9 * * 1'
-  workflow_dispatch:
-
-jobs:
-  discover:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      issues: write
-
-    steps:
-      - name: Fetch model labels from hub API
-        id: hub
-        shell: bash
-        run: |
-          set -euo pipefail
-          curl -fsSL 'https://comfy.org/api/hub/labels?type=model' -o hub-labels.json
-          echo "Fetched $(jq '.labels | length' hub-labels.json) model labels from hub"
-
-      - name: Checkout ComfyUI_frontend
-        uses: actions/checkout@v6
-        with:
-          sparse-checkout: apps/website/src/config/generated-models.json
-
-      - name: Compare against existing models
-        id: compare
-        shell: bash
-        run: |
-          set -euo pipefail
-
-          HUB_SLUGS=$(jq -r '[.labels[].name]' hub-labels.json)
-
-          EXISTING_SLUGS=$(node -e "
-            const fs = require('fs');
-            const models = JSON.parse(
-              fs.readFileSync(
-                'apps/website/src/config/generated-models.json',
-                'utf8'
-              )
-            );
-            console.log(JSON.stringify(models.map(m => m.slug)));
-          " 2>/dev/null || echo '[]')
-
-          ADDED_SLUGS=$(node -e "
-            const hub = $HUB_SLUGS;
-            const existing = new Set($EXISTING_SLUGS);
-            console.log(JSON.stringify(hub.filter(s => !existing.has(s))));
-          ")
-
-          COUNT=$(node -e "console.log($ADDED_SLUGS.length)")
-          echo "new_count=$COUNT" >> \$GITHUB_OUTPUT
-          echo "new_slugs=$ADDED_SLUGS" >> \$GITHUB_OUTPUT
-
-          if [ "\$COUNT" -eq 0 ]; then
-            echo "No new models found."
-          else
-            echo "Found \$COUNT new model(s)"
-          fi
-
-      - name: Check for existing open discovery issue
-        id: existing_issue
-        if: steps.compare.outputs.new_count != '0'
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        shell: bash
-        run: |
-          COUNT=$(gh issue list \
-            --repo "$GITHUB_REPOSITORY" \
-            --state open \
-            --search 'in:title "New models detected"' \
-            --json number \
-            --jq 'length')
-          echo "open_count=$COUNT" >> $GITHUB_OUTPUT
-
-      - name: Open GitHub issue for new models
-        if: |
-          steps.compare.outputs.new_count != '0' &&
-          steps.existing_issue.outputs.open_count == '0'
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          NEW_SLUGS: ${{ steps.compare.outputs.new_slugs }}
-          NEW_COUNT: ${{ steps.compare.outputs.new_count }}
-        shell: bash
-        run: |
-          SLUG_LIST=$(node -e "
-            const slugs = $NEW_SLUGS;
-            console.log(slugs.map(s => '- \`' + s + '\`').join('\n'));
-          ")
-
-          gh issue create \
-            --repo "$GITHUB_REPOSITORY" \
-            --title "New models detected — add to model pages" \
-            --body "## $NEW_COUNT new model(s) found in hub
-
-          The weekly model discovery scan found model labels on the hub not yet in
-          \`apps/website/src/config/generated-models.json\`.
-
-          ### New slugs ($NEW_COUNT)
-
-          $SLUG_LIST
-
-          ### Next steps
-
-          1. Review which of these warrant an SEO model page
-          2. For local models: run \`SKIP_THUMBNAILS=1 pnpm generate:models\` and commit the result
-          3. For partner/API models: add to \`API_PROVIDER_MAP\` in \`generate-models.ts\`, regenerate, commit
-
-          ---
-          *Generated by the [model-page-discovery workflow](https://github.com/$GITHUB_REPOSITORY/actions/workflows/model-page-discovery.yaml)*"
-
-      - name: Skip — open issue already exists
-        if: |
-          steps.compare.outputs.new_count != '0' &&
-          steps.existing_issue.outputs.open_count != '0'
-        run: echo "An open discovery issue already exists — skipping creation."
-
-      - name: No new models found
-        if: steps.compare.outputs.new_count == '0'
-        run: echo "No new models found — nothing to do."

.github/workflows/pr-backport.yaml

@@ -67,11 +67,6 @@ jobs:
         uses: actions/checkout@v6
         with:
           fetch-depth: 0
-          # Persist a token with `workflow` scope so the backport push can
-          # include changes to .github/workflows/**. The default GITHUB_TOKEN
-          # is refused by GitHub when a push creates/updates workflow files,
-          # which silently aborted the whole job (see PR #12804 backport).
-          token: ${{ secrets.PR_GH_TOKEN }}
 
       - name: Configure git
         run: |
@@ -278,49 +273,32 @@ jobs:
               continue
             fi
 
-            # Create backport branch. A failure here (e.g. dirty state left
-            # by a prior target) must not abort the loop and skip remaining
-            # targets, so fall back to a clean checkout and record the error.
-            if ! git checkout -B "${BACKPORT_BRANCH}" "origin/${TARGET_BRANCH}"; then
-              echo "::error::Failed to create branch ${BACKPORT_BRANCH} for ${TARGET_BRANCH}"
-              FAILED="${FAILED}${TARGET_BRANCH}:branch-create-failed "
-              git checkout main || git checkout -f main
-              echo "::endgroup::"
-              continue
-            fi
+            # Create backport branch
+            git checkout -b "${BACKPORT_BRANCH}" "origin/${TARGET_BRANCH}"
 
             # Try cherry-pick
             if git cherry-pick "${MERGE_COMMIT}"; then
               if [ "$REMOTE_BACKPORT_EXISTS" = true ]; then
-                PUSH_CMD=(git push --force-with-lease origin "${BACKPORT_BRANCH}")
+                git push --force-with-lease origin "${BACKPORT_BRANCH}"
               else
-                PUSH_CMD=(git push origin "${BACKPORT_BRANCH}")
+                git push origin "${BACKPORT_BRANCH}"
               fi
-
-              # A push failure for one target must not abort the loop and
-              # prevent remaining targets from being attempted.
-              if "${PUSH_CMD[@]}"; then
-                echo "${BACKPORT_BRANCH}" >> "$CREATED_BRANCHES_FILE"
-                SUCCESS="${SUCCESS}${TARGET_BRANCH}:${BACKPORT_BRANCH} "
-                echo "Successfully created backport branch: ${BACKPORT_BRANCH}"
-              else
-                echo "::error::Failed to push ${BACKPORT_BRANCH} for ${TARGET_BRANCH}"
-                FAILED="${FAILED}${TARGET_BRANCH}:push-failed "
-              fi
-
+              echo "${BACKPORT_BRANCH}" >> "$CREATED_BRANCHES_FILE"
+              SUCCESS="${SUCCESS}${TARGET_BRANCH}:${BACKPORT_BRANCH} "
+              echo "Successfully created backport branch: ${BACKPORT_BRANCH}"
               # Return to main (keep the branch, we need it for PR)
-              git checkout main || git checkout -f main
+              git checkout main
             else
               # Get conflict info
               CONFLICTS=$(git diff --name-only --diff-filter=U | tr '\n' ',')
-              git cherry-pick --abort || true
+              git cherry-pick --abort
 
               echo "::error::Cherry-pick failed due to conflicts"
               FAILED="${FAILED}${TARGET_BRANCH}:conflicts:${CONFLICTS} "
 
               # Clean up the failed branch
-              git checkout main || git checkout -f main
-              git branch -D "${BACKPORT_BRANCH}" || true
+              git checkout main
+              git branch -D "${BACKPORT_BRANCH}"
             fi
 
             echo "::endgroup::"
@@ -401,10 +379,6 @@ jobs:
 
             **Reason:** Merge conflicts detected during cherry-pick of `${MERGE_COMMIT_SHORT}`
 
-            The auto-backport could not be completed automatically. Please backport
-            manually onto branch `${BACKPORT_BRANCH}` (from `origin/${target}`) and
-            open a PR to `${target}`.
-
             <details>
             <summary>📄 Conflicting files</summary>
 
@@ -437,37 +411,19 @@ jobs:
             MERGE_COMMIT=$(jq -r '.pull_request.merge_commit_sha' "$GITHUB_EVENT_PATH")
           fi
 
-          # Post a comment without letting a single failed `gh pr comment` (e.g.
-          # a locked issue, as happened for PR #13359, or a transient API error)
-          # abort the step under `set -e` and swallow the remaining failures.
-          post_comment() {
-            local body="$1"
-            local context="$2"
-            if ! gh pr comment "${PR_NUMBER}" --body "${body}"; then
-              echo "::warning::Could not comment on PR #${PR_NUMBER} about ${context}. Manual backport required."
-            fi
-          }
-
           for failure in ${{ steps.backport.outputs.failed }}; do
             IFS=':' read -r target reason conflicts <<< "${failure}"
 
-            SAFE_TARGET=$(echo "$target" | tr '/' '-')
-            BACKPORT_BRANCH="backport-${PR_NUMBER}-to-${SAFE_TARGET}"
-
             if [ "${reason}" = "branch-missing" ]; then
-              post_comment "@${PR_AUTHOR} Backport failed: Branch \`${target}\` does not exist" "missing branch ${target}"
+              gh pr comment "${PR_NUMBER}" --body "@${PR_AUTHOR} Backport failed: Branch \`${target}\` does not exist"
 
             elif [ "${reason}" = "already-exists" ]; then
-              post_comment "@${PR_AUTHOR} Commit \`${MERGE_COMMIT}\` already exists on branch \`${target}\`. No backport needed." "already-backported ${target}"
-
-            elif [ "${reason}" = "branch-create-failed" ]; then
-              gh pr comment "${PR_NUMBER}" --body "@${PR_AUTHOR} Backport to \`${target}\` failed: could not create the backport branch. Please retry or backport manually."
-
-            elif [ "${reason}" = "push-failed" ]; then
-              gh pr comment "${PR_NUMBER}" --body "@${PR_AUTHOR} Backport to \`${target}\` cherry-picked cleanly but the push failed. Please retry or push the backport branch manually."
+              gh pr comment "${PR_NUMBER}" --body "@${PR_AUTHOR} Commit \`${MERGE_COMMIT}\` already exists on branch \`${target}\`. No backport needed."
 
             elif [ "${reason}" = "conflicts" ]; then
               CONFLICTS_INLINE=$(echo "${conflicts}" | tr ',' ' ')
+              SAFE_TARGET=$(echo "$target" | tr '/' '-')
+              BACKPORT_BRANCH="backport-${PR_NUMBER}-to-${SAFE_TARGET}"
               PR_URL="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/pull/${PR_NUMBER}"
 
               export PR_NUMBER PR_URL MERGE_COMMIT target BACKPORT_BRANCH CONFLICTS_INLINE
@@ -483,10 +439,10 @@ jobs:
               CONFLICTS_BLOCK=$(echo "${conflicts}" | tr ',' '\n')
               MERGE_COMMIT_SHORT="${MERGE_COMMIT:0:7}"
 
-              export target MERGE_COMMIT_SHORT BACKPORT_BRANCH CONFLICTS_BLOCK AGENT_PROMPT PR_AUTHOR
-              COMMENT_BODY=$(envsubst '${target} ${MERGE_COMMIT_SHORT} ${BACKPORT_BRANCH} ${CONFLICTS_BLOCK} ${AGENT_PROMPT} ${PR_AUTHOR}' <<<"$COMMENT_BODY_TEMPLATE")
+              export target MERGE_COMMIT_SHORT CONFLICTS_BLOCK AGENT_PROMPT PR_AUTHOR
+              COMMENT_BODY=$(envsubst '${target} ${MERGE_COMMIT_SHORT} ${CONFLICTS_BLOCK} ${AGENT_PROMPT} ${PR_AUTHOR}' <<<"$COMMENT_BODY_TEMPLATE")
 
-              post_comment "${COMMENT_BODY}" "cherry-pick conflict on ${target} (backport manually onto ${BACKPORT_BRANCH})"
+              gh pr comment "${PR_NUMBER}" --body "${COMMENT_BODY}"
             fi
           done
 

.github/workflows/pr-claude-review.yaml

@@ -39,7 +39,7 @@ jobs:
 
       - name: Install dependencies for analysis tools
         run: |
-          pnpm add -g typescript @vue/compiler-sfc
+          pnpm install -g typescript @vue/compiler-sfc
 
       - name: Run Claude PR Review
         uses: anthropics/claude-code-action@ff34ce0ff04a470bd3fa56c1ef391c8f1c19f8e9 # v1.0.38

.github/workflows/pr-cursor-review.yaml

@@ -1,55 +0,0 @@
-# Description: Team-gated multi-model Cursor review — a thin caller for the
-# reusable workflow in Comfy-Org/github-workflows, which is the single source of
-# truth for the panel, judge, prompts, and scripts. Triggered by the
-# 'cursor-review' label.
-#
-# Access control (team-only, two layers):
-#   1. Only users with triage permission or higher can apply a label in a public
-#      repo, so the public cannot trigger this.
-#   2. The reusable workflow's secret-bearing jobs do not run on fork PRs (forks
-#      get no secrets), so CURSOR_API_KEY is reachable only on internal branches.
-name: 'PR: Cursor Review'
-
-on:
-  pull_request:
-    types: [labeled, unlabeled]
-
-permissions:
-  contents: read
-  pull-requests: write
-
-concurrency:
-  # Re-labeling cancels an in-flight run for the same PR + label.
-  group: cursor-review-pr-${{ github.event.pull_request.number }}-${{ github.event.label.name }}
-  cancel-in-progress: true
-
-jobs:
-  cursor-review:
-    if: github.event.action == 'labeled' && github.event.label.name == 'cursor-review'
-    # SHA-pinned per zizmor `unpinned-uses: hash-pin`. Bump this SHA to pick up
-    # upstream changes; keep `workflows_ref` matching so prompts/scripts load
-    # from the same commit as the workflow definition.
-    uses: Comfy-Org/github-workflows/.github/workflows/cursor-review.yml@df507e6bae179c567ad3849370f99dae588985dc # github-workflows main (df507e6)
-    with:
-      # Overriding diff_excludes replaces the reusable default wholesale, so
-      # this restates the generated/vendored defaults and adds this repo's heavy
-      # paths (Playwright snapshots, generated manager types).
-      diff_excludes: >-
-        :!**/package-lock.json
-        :!**/yarn.lock
-        :!**/pnpm-lock.yaml
-        :!**/node_modules/**
-        :!**/.claude/**
-        :!**/dist/**
-        :!**/vendor/**
-        :!**/*.generated.*
-        :!**/*.min.js
-        :!**/*.min.css
-        :!**/*-snapshots/**
-        :!src/workbench/extensions/manager/types/generatedManagerTypes.ts
-      # Load the prompts/scripts from the same ref as `uses:`.
-      workflows_ref: df507e6bae179c567ad3849370f99dae588985dc
-    secrets:
-      CURSOR_API_KEY: ${{ secrets.CURSOR_API_KEY }}
-      # Optional — enables start/complete Slack DMs to the triggerer.
-      SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}

.github/workflows/pr-report.yaml

@@ -2,11 +2,9 @@ name: 'PR: Unified Report'
 
 on:
   workflow_run:
-    workflows: ['CI: Size Data', 'CI: Performance Report', 'CI: E2E Coverage']
+    workflows: ['CI: Size Data', 'CI: Performance Report']
     types:
       - completed
-    branches-ignore:
-      - main
 
 permissions:
   contents: read
@@ -32,25 +30,110 @@ jobs:
 
       - name: Resolve PR from workflow_run context
         id: pr-meta
-        uses: ./.github/actions/resolve-pr-from-workflow-run
+        uses: actions/github-script@v8
+        with:
+          script: |
+            let pr = context.payload.workflow_run.pull_requests?.[0];
+            if (!pr) {
+              const { data: prs } = await github.rest.repos.listPullRequestsAssociatedWithCommit({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                commit_sha: context.payload.workflow_run.head_sha,
+              });
+              pr = prs.find(p => p.state === 'open');
+            }
 
-      - name: Find size workflow run
+            if (!pr) {
+              core.info('No open PR found for this workflow run — skipping.');
+              core.setOutput('skip', 'true');
+              return;
+            }
+
+            // Verify the workflow_run head SHA matches the current PR head
+            const { data: livePr } = await github.rest.pulls.get({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              pull_number: pr.number,
+            });
+
+            if (livePr.head.sha !== context.payload.workflow_run.head_sha) {
+              core.info(`Stale run: workflow SHA ${context.payload.workflow_run.head_sha} != PR head ${livePr.head.sha}`);
+              core.setOutput('skip', 'true');
+              return;
+            }
+
+            core.setOutput('skip', 'false');
+            core.setOutput('number', String(pr.number));
+            core.setOutput('base', livePr.base.ref);
+            core.setOutput('head-sha', livePr.head.sha);
+
+      - name: Find size workflow run for this commit
         if: steps.pr-meta.outputs.skip != 'true'
         id: find-size
-        uses: ./.github/actions/find-workflow-run
+        uses: actions/github-script@v8
         with:
-          workflow-id: ci-size-data.yaml
-          head-sha: ${{ steps.pr-meta.outputs.head-sha }}
-          token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const headSha = '${{ steps.pr-meta.outputs.head-sha }}';
+            const { data: runs } = await github.rest.actions.listWorkflowRuns({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              workflow_id: 'ci-size-data.yaml',
+              head_sha: headSha,
+              per_page: 1,
+            });
 
-      - name: Find perf workflow run
+            const run = runs.workflow_runs[0];
+            if (!run) {
+              core.setOutput('status', 'pending');
+              return;
+            }
+
+            if (run.status !== 'completed') {
+              core.setOutput('status', 'pending');
+              return;
+            }
+
+            if (run.conclusion !== 'success') {
+              core.setOutput('status', 'failed');
+              return;
+            }
+
+            core.setOutput('status', 'ready');
+            core.setOutput('run-id', String(run.id));
+
+      - name: Find perf workflow run for this commit
         if: steps.pr-meta.outputs.skip != 'true'
         id: find-perf
-        uses: ./.github/actions/find-workflow-run
+        uses: actions/github-script@v8
         with:
-          workflow-id: ci-perf-report.yaml
-          head-sha: ${{ steps.pr-meta.outputs.head-sha }}
-          token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const headSha = '${{ steps.pr-meta.outputs.head-sha }}';
+            const { data: runs } = await github.rest.actions.listWorkflowRuns({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              workflow_id: 'ci-perf-report.yaml',
+              head_sha: headSha,
+              per_page: 1,
+            });
+
+            const run = runs.workflow_runs[0];
+            if (!run) {
+              core.setOutput('status', 'pending');
+              return;
+            }
+
+            if (run.status !== 'completed') {
+              core.setOutput('status', 'pending');
+              return;
+            }
+
+            if (run.conclusion !== 'success') {
+              core.setOutput('status', 'failed');
+              return;
+            }
+
+            core.setOutput('status', 'ready');
+            core.setOutput('run-id', String(run.id));
 
       - name: Download size data (current)
         if: steps.pr-meta.outputs.skip != 'true' && steps.find-size.outputs.status == 'ready'
@@ -71,25 +154,6 @@ jobs:
           path: temp/size-prev
           if_no_artifact_found: warn
 
-      - name: Find coverage workflow run
-        if: steps.pr-meta.outputs.skip != 'true'
-        id: find-coverage
-        uses: ./.github/actions/find-workflow-run
-        with:
-          workflow-id: ci-tests-e2e-coverage.yaml
-          head-sha: ${{ steps.pr-meta.outputs.head-sha }}
-          not-found-status: skip
-          token: ${{ secrets.GITHUB_TOKEN }}
-
-      - name: Download coverage data
-        if: steps.pr-meta.outputs.skip != 'true' && steps.find-coverage.outputs.status == 'ready'
-        uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
-        with:
-          name: e2e-coverage
-          run_id: ${{ steps.find-coverage.outputs.run-id }}
-          path: temp/coverage
-          if_no_artifact_found: warn
-
       - name: Download perf metrics (current)
         if: steps.pr-meta.outputs.skip != 'true' && steps.find-perf.outputs.status == 'ready'
         uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
@@ -125,10 +189,9 @@ jobs:
       - name: Generate unified report
         if: steps.pr-meta.outputs.skip != 'true'
         run: >
-          pnpm exec tsx scripts/unified-report.ts
+          node scripts/unified-report.js
           --size-status=${{ steps.find-size.outputs.status }}
           --perf-status=${{ steps.find-perf.outputs.status }}
-          --coverage-status=${{ steps.find-coverage.outputs.status }}
           > pr-report.md
 
       - name: Remove legacy separate comments
@@ -140,8 +203,6 @@ jobs:
             const legacyMarkers = [
               '<!-- COMFYUI_FRONTEND_SIZE -->',
               '<!-- COMFYUI_FRONTEND_PERF -->',
-              '<!-- PLAYWRIGHT_TEST_STATUS -->',
-              '<!-- STORYBOOK_BUILD_STATUS -->',
             ];
 
             const comments = await github.paginate(github.rest.issues.listComments, {
@@ -162,19 +223,11 @@ jobs:
               }
             }
 
-      - name: Read PR report
-        id: report
+      - name: Post PR comment
         if: steps.pr-meta.outputs.skip != 'true'
-        uses: juliangruber/read-file-action@b549046febe0fe86f8cb4f93c24e284433f9ab58 # v1.1.7
-        with:
-          path: ./pr-report.md
-
-      - name: Upsert bundle/perf/coverage section into unified report
-        if: steps.pr-meta.outputs.skip != 'true'
-        uses: ./.github/actions/upsert-comment-section
+        uses: ./.github/actions/post-pr-report-comment
         with:
           pr-number: ${{ steps.pr-meta.outputs.number }}
-          section-name: ci-metrics
-          section-content: ${{ steps.report.outputs.content }}
+          report-file: ./pr-report.md
           comment-marker: '<!-- COMFYUI_FRONTEND_PR_REPORT -->'
           token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/pr-update-playwright-expectations.yaml

@@ -77,7 +77,7 @@ jobs:
     needs: setup
     runs-on: ubuntu-latest
     container:
-      image: ghcr.io/comfy-org/comfyui-ci-container:0.0.17
+      image: ghcr.io/comfy-org/comfyui-ci-container:0.0.16
       credentials:
         username: ${{ github.actor }}
         password: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/pr-update-website-screenshots.yaml

@@ -1,245 +0,0 @@
-name: 'PR: Update Website Screenshots'
-
-on:
-  pull_request:
-    types: [labeled]
-  issue_comment:
-    types: [created, edited]
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.event.issue.number || github.event.pull_request.number || github.ref }}
-  cancel-in-progress: false
-
-jobs:
-  update-screenshots:
-    runs-on: ubuntu-latest
-    container:
-      image: mcr.microsoft.com/playwright:v1.58.1-noble
-    timeout-minutes: 15
-    permissions:
-      contents: write
-      issues: write
-      pull-requests: read
-    # Trigger: (1) label, (2) /slash-command, or (3) checkbox in E2E status comment
-    # ⚠️ This condition is duplicated on `post-starting-comment` — keep them in sync.
-    if: >
-      ( github.event_name == 'pull_request' &&
-        github.event.label.name == 'Update Website Screenshots' ) ||
-      ( github.event.issue.pull_request &&
-        github.event_name == 'issue_comment' &&
-        (
-          github.event.comment.author_association == 'OWNER' ||
-          github.event.comment.author_association == 'MEMBER' ||
-          github.event.comment.author_association == 'COLLABORATOR'
-        ) &&
-        startsWith(github.event.comment.body, '/update-website-screenshots') ) ||
-      ( github.event.issue.pull_request &&
-        github.event_name == 'issue_comment' &&
-        github.event.comment.user.login == 'github-actions[bot]' &&
-        github.actor != 'github-actions[bot]' &&
-        contains(github.event.comment.body, '<!-- WEBSITE_E2E_STATUS -->') &&
-        contains(github.event.comment.body, '- [x] Update website screenshots') )
-    outputs:
-      pr-number: ${{ steps.pr-info.outputs.pr-number }}
-      update-outcome: ${{ steps.update-screenshots.outcome }}
-      has-changes: ${{ steps.commit.outputs.has-changes }}
-      changed-count: ${{ steps.commit.outputs.changed-count }}
-    steps:
-      - name: Verify sender permissions
-        if: >
-          github.event_name == 'issue_comment' &&
-          contains(github.event.comment.body, '<!-- WEBSITE_E2E_STATUS -->')
-        uses: actions/github-script@v8
-        with:
-          script: |
-            const { data } = await github.rest.repos.getCollaboratorPermissionLevel({
-              ...context.repo,
-              username: context.actor
-            })
-            if (!['admin', 'write'].includes(data.permission)) {
-              core.setFailed(`User ${context.actor} does not have write access`)
-            }
-
-      - name: Get PR info
-        id: pr-info
-        uses: actions/github-script@v8
-        env:
-          PR_NUMBER: ${{ github.event.number || github.event.issue.number }}
-        with:
-          script: |
-            const prNumber = Number(process.env.PR_NUMBER)
-            const { data: pr } = await github.rest.pulls.get({
-              ...context.repo,
-              pull_number: prNumber
-            })
-            core.setOutput('pr-number', prNumber)
-            core.setOutput('branch', pr.head.ref)
-
-      - uses: actions/checkout@v6
-        with:
-          ref: ${{ steps.pr-info.outputs.branch }}
-          token: ${{ secrets.PR_GH_TOKEN }}
-
-      - name: Install pnpm
-        run: corepack enable && corepack prepare
-
-      - name: Install dependencies
-        run: pnpm install --frozen-lockfile
-
-      - name: Build website
-        env:
-          WEBSITE_GITHUB_STARS_OVERRIDE: 110000
-        run: pnpm --filter @comfyorg/website build
-
-      - name: Update screenshots
-        id: update-screenshots
-        run: pnpm --filter @comfyorg/website test:visual:update
-        continue-on-error: true
-
-      - name: Commit updated screenshots
-        id: commit
-        if: steps.update-screenshots.outcome == 'success'
-        run: |
-          git config --global --add safe.directory "$(pwd)"
-          git config --global user.name 'github-actions'
-          git config --global user.email 'github-actions@github.com'
-
-          CHANGED=$(git status --porcelain=v1 --untracked-files=all -- apps/website/e2e/ | wc -l)
-          echo "changed-count=${CHANGED}" >> $GITHUB_OUTPUT
-
-          if [ "$CHANGED" -eq 0 ]; then
-            echo "No screenshot changes to commit"
-            echo "has-changes=false" >> $GITHUB_OUTPUT
-            exit 0
-          fi
-
-          echo "has-changes=true" >> $GITHUB_OUTPUT
-          git add apps/website/e2e/
-          git commit -m "[automated] Update website screenshot expectations"
-          git push origin ${{ steps.pr-info.outputs.branch }}
-
-      - name: Upload test report
-        uses: actions/upload-artifact@v6
-        if: ${{ !cancelled() }}
-        with:
-          name: website-screenshot-update-report
-          path: apps/website/playwright-report/
-          retention-days: 14
-
-      - name: Remove label
-        if: always() && github.event_name == 'pull_request'
-        uses: actions/github-script@v8
-        env:
-          PR_NUMBER: ${{ steps.pr-info.outputs.pr-number }}
-        with:
-          script: |
-            try {
-              await github.rest.issues.removeLabel({
-                ...context.repo,
-                issue_number: Number(process.env.PR_NUMBER),
-                name: 'Update Website Screenshots'
-              })
-            } catch (e) {
-              if (e.status !== 404) {
-                throw e
-              }
-              core.info('Label "Update Website Screenshots" was already removed')
-            }
-
-  post-starting-comment:
-    # Runs in parallel with update-screenshots to show "in progress" immediately.
-    # ⚠️ This condition is duplicated from `update-screenshots` — keep them in sync.
-    if: >
-      ( github.event_name == 'pull_request' &&
-        github.event.label.name == 'Update Website Screenshots' ) ||
-      ( github.event.issue.pull_request &&
-        github.event_name == 'issue_comment' &&
-        (
-          github.event.comment.author_association == 'OWNER' ||
-          github.event.comment.author_association == 'MEMBER' ||
-          github.event.comment.author_association == 'COLLABORATOR'
-        ) &&
-        startsWith(github.event.comment.body, '/update-website-screenshots') ) ||
-      ( github.event.issue.pull_request &&
-        github.event_name == 'issue_comment' &&
-        github.event.comment.user.login == 'github-actions[bot]' &&
-        github.actor != 'github-actions[bot]' &&
-        contains(github.event.comment.body, '<!-- WEBSITE_E2E_STATUS -->') &&
-        contains(github.event.comment.body, '- [x] Update website screenshots') )
-    runs-on: ubuntu-latest
-    permissions:
-      pull-requests: write
-      contents: read
-    concurrency:
-      group: website-pr-comment-${{ github.event.number || github.event.issue.number }}
-      cancel-in-progress: false
-    steps:
-      - uses: actions/checkout@v6
-      - uses: ./.github/actions/upsert-comment-section
-        with:
-          pr-number: ${{ github.event.number || github.event.issue.number }}
-          section-name: screenshot-update
-          comment-marker: '<!-- WEBSITE_CI_REPORT -->'
-          token: ${{ secrets.GITHUB_TOKEN }}
-          section-content: |-
-            ## 📸 Screenshot Update
-
-            > [!NOTE]
-            > Updating screenshots… [View workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
-
-  post-result-comment:
-    needs: update-screenshots
-    if: always() && !cancelled() && needs.update-screenshots.result != 'skipped'
-    runs-on: ubuntu-latest
-    permissions:
-      pull-requests: write
-      contents: read
-    concurrency:
-      group: website-pr-comment-${{ needs.update-screenshots.outputs.pr-number }}
-      cancel-in-progress: false
-    steps:
-      - uses: actions/checkout@v6
-
-      - name: Build screenshot-update section content
-        id: content
-        uses: actions/github-script@v8
-        env:
-          UPDATE_OUTCOME: ${{ needs.update-screenshots.outputs.update-outcome }}
-          HAS_CHANGES: ${{ needs.update-screenshots.outputs.has-changes }}
-          CHANGED_COUNT: ${{ needs.update-screenshots.outputs.changed-count }}
-        with:
-          script: |
-            const outcome = process.env.UPDATE_OUTCOME
-            const hasChanges = process.env.HAS_CHANGES === 'true'
-            const changedCount = parseInt(process.env.CHANGED_COUNT) || 0
-            const runUrl = `${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`
-
-            const lines = ['## 📸 Screenshot Update', '']
-
-            if (outcome !== 'success') {
-              lines.push(
-                '> [!CAUTION]',
-                `> Screenshot update failed. [View workflow run](${runUrl})`
-              )
-            } else if (!hasChanges) {
-              lines.push(
-                '> [!TIP]',
-                '> All screenshots are already up to date.'
-              )
-            } else {
-              const s = changedCount === 1 ? '' : 's'
-              lines.push(
-                '> [!TIP]',
-                `> Updated ${changedCount} screenshot${s} and pushed to the branch.`
-              )
-            }
-
-            core.setOutput('section-content', lines.join('\n'))
-
-      - uses: ./.github/actions/upsert-comment-section
-        with:
-          pr-number: ${{ needs.update-screenshots.outputs.pr-number }}
-          section-name: screenshot-update
-          comment-marker: '<!-- WEBSITE_CI_REPORT -->'
-          token: ${{ secrets.GITHUB_TOKEN }}
-          section-content: ${{ steps.content.outputs.section-content }}

.github/workflows/pr-vercel-website-preview.yaml

@@ -1,70 +0,0 @@
----
-name: 'PR: Vercel Website Preview'
-
-on:
-  workflow_run:
-    workflows: ['CI: Vercel Website Preview']
-    types:
-      - completed
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.event.workflow_run.head_repository.full_name }}-${{ github.event.workflow_run.head_branch }}
-  cancel-in-progress: true
-
-jobs:
-  comment:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-      pull-requests: write
-      actions: read
-    # Uses head_branch as proxy for PR number (unavailable at job-level in workflow_run).
-    # Preview and E2E comment writes are NOT mutually serialized — the race window is
-    # small and self-healing on next push.
-    concurrency:
-      group: website-pr-comment-${{ github.event.workflow_run.head_branch }}
-      cancel-in-progress: false
-    if: >
-      github.repository == 'Comfy-Org/ComfyUI_frontend' &&
-      github.event.workflow_run.event == 'pull_request' &&
-      github.event.workflow_run.conclusion == 'success'
-    steps:
-      - uses: actions/checkout@v6
-
-      - name: Download preview metadata
-        uses: dawidd6/action-download-artifact@0bd50d53a6d7fb5cb921e607957e9cc12b4ce392 # v12
-        with:
-          name: vercel-preview
-          run_id: ${{ github.event.workflow_run.id }}
-          path: temp/vercel-preview
-
-      - name: Resolve PR number from workflow_run context
-        id: pr-meta
-        uses: ./.github/actions/resolve-pr-from-workflow-run
-
-      - name: Read preview URLs
-        if: steps.pr-meta.outputs.skip != 'true'
-        id: urls
-        run: |
-          echo "stable-url=$(cat temp/vercel-preview/stable-url.txt)" >> "$GITHUB_OUTPUT"
-          echo "unique-url=$(cat temp/vercel-preview/url.txt)" >> "$GITHUB_OUTPUT"
-          echo "short-sha=${HEAD_SHA:0:7}" >> "$GITHUB_OUTPUT"
-        env:
-          HEAD_SHA: ${{ github.event.workflow_run.head_sha }}
-
-      - name: Post preview comment
-        if: steps.pr-meta.outputs.skip != 'true'
-        uses: ./.github/actions/upsert-comment-section
-        with:
-          pr-number: ${{ steps.pr-meta.outputs.number }}
-          section-name: preview
-          comment-marker: '<!-- WEBSITE_CI_REPORT -->'
-          token: ${{ secrets.GITHUB_TOKEN }}
-          section-content: |-
-            ## 🔗 Website Preview
-
-            **Website Preview:** ${{ steps.urls.outputs.stable-url }}
-
-            <sub>This commit: ${{ steps.urls.outputs.unique-url }}</sub>
-
-            <sub>Last updated: ${{ github.event.workflow_run.updated_at }} for `${{ steps.urls.outputs.short-sha }}`</sub>

.github/workflows/publish-desktop-bridge-types.yaml

@@ -1,142 +0,0 @@
-name: Publish Desktop Bridge Types
-
-on:
-  workflow_dispatch:
-    inputs:
-      version:
-        description: 'Version to publish (e.g., 0.1.2)'
-        required: true
-        type: string
-      dist_tag:
-        description: 'npm dist-tag to use'
-        required: true
-        default: latest
-        type: string
-      ref:
-        description: 'Git ref to checkout (commit SHA, tag, or branch)'
-        required: false
-        type: string
-  workflow_call:
-    inputs:
-      version:
-        required: true
-        type: string
-      dist_tag:
-        required: false
-        type: string
-        default: latest
-      ref:
-        required: false
-        type: string
-    secrets:
-      NPM_TOKEN:
-        required: true
-
-concurrency:
-  group: publish-desktop-bridge-types-${{ github.workflow }}-${{ inputs.version }}-${{ inputs.dist_tag }}
-  cancel-in-progress: false
-
-jobs:
-  publish_desktop_bridge_types:
-    name: Publish @comfyorg/comfyui-desktop-bridge-types
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    steps:
-      - name: Validate inputs
-        env:
-          VERSION: ${{ inputs.version }}
-        shell: bash
-        run: |
-          set -euo pipefail
-          SEMVER_REGEX='^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(-((0|[1-9][0-9]*|[0-9]*[A-Za-z-][0-9A-Za-z-]*)(\.(0|[1-9][0-9]*|[0-9]*[A-Za-z-][0-9A-Za-z-]*))*))?(\+([0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*))?$'
-          if [[ ! "$VERSION" =~ $SEMVER_REGEX ]]; then
-            echo "::error title=Invalid version::Version '$VERSION' must follow semantic versioning (x.y.z[-suffix][+build])" >&2
-            exit 1
-          fi
-
-      - name: Determine ref to checkout
-        id: resolve_ref
-        env:
-          REF: ${{ inputs.ref }}
-          DEFAULT_REF: ${{ github.ref_name }}
-        shell: bash
-        run: |
-          set -euo pipefail
-          if [ -z "$REF" ]; then
-            REF="$DEFAULT_REF"
-          fi
-          if ! git check-ref-format --allow-onelevel "$REF"; then
-            echo "::error title=Invalid ref::Ref '$REF' fails git check-ref-format validation." >&2
-            exit 1
-          fi
-          echo "ref=$REF" >> "$GITHUB_OUTPUT"
-
-      - name: Checkout repository
-        uses: actions/checkout@v6
-        with:
-          ref: ${{ steps.resolve_ref.outputs.ref }}
-          fetch-depth: 1
-          persist-credentials: false
-
-      - name: Install pnpm
-        uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v6
-        with:
-          node-version-file: '.nvmrc'
-          cache: 'pnpm'
-          registry-url: https://registry.npmjs.org
-
-      - name: Install dependencies
-        run: pnpm install --frozen-lockfile --ignore-scripts
-        env:
-          PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
-
-      - name: Verify package
-        id: pkg
-        env:
-          INPUT_VERSION: ${{ inputs.version }}
-        shell: bash
-        run: |
-          set -euo pipefail
-          PACKAGE_JSON=packages/comfyui-desktop-bridge-types/package.json
-          NAME=$(node -p "require('./${PACKAGE_JSON}').name")
-          VERSION=$(node -p "require('./${PACKAGE_JSON}').version")
-          if [ "$VERSION" != "$INPUT_VERSION" ]; then
-            echo "::error title=Version mismatch::${PACKAGE_JSON} version $VERSION does not match input $INPUT_VERSION" >&2
-            exit 1
-          fi
-          echo "name=$NAME" >> "$GITHUB_OUTPUT"
-          echo "version=$VERSION" >> "$GITHUB_OUTPUT"
-
-      - name: Check if version already on npm
-        id: check_npm
-        env:
-          NAME: ${{ steps.pkg.outputs.name }}
-          VER: ${{ steps.pkg.outputs.version }}
-        shell: bash
-        run: |
-          set -euo pipefail
-          STATUS=0
-          OUTPUT=$(npm view "${NAME}@${VER}" --json 2>&1) || STATUS=$?
-          if [ "$STATUS" -eq 0 ]; then
-            echo "exists=true" >> "$GITHUB_OUTPUT"
-            echo "::warning title=Already published::${NAME}@${VER} already exists on npm. Skipping publish."
-          else
-            if echo "$OUTPUT" | grep -q "E404"; then
-              echo "exists=false" >> "$GITHUB_OUTPUT"
-            else
-              echo "::error title=Registry lookup failed::$OUTPUT" >&2
-              exit "$STATUS"
-            fi
-          fi
-
-      - name: Publish package
-        if: steps.check_npm.outputs.exists == 'false'
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
-          DIST_TAG: ${{ inputs.dist_tag }}
-        run: pnpm publish --access public --tag "$DIST_TAG" --no-git-checks --ignore-scripts
-        working-directory: packages/comfyui-desktop-bridge-types

.github/workflows/release-biweekly-comfyui.yaml

@@ -1,32 +1,19 @@
-# Release workflow for ComfyUI frontend: version bump → PyPI publish → ComfyUI PR.
-# Runs on a bi-weekly schedule for minor releases, or manually for patch/hotfix releases.
-name: 'Release: ComfyUI'
+# Automated bi-weekly workflow to bump ComfyUI frontend RC releases
+name: 'Release: Bi-weekly ComfyUI'
 
 on:
-  # Bi-weekly schedule: Monday at 20:00 UTC
+  # Schedule for Monday at 12:00 PM PST (20:00 UTC)
   schedule:
     - cron: '0 20 * * 1'
 
-  # Manual trigger for both on-demand minor and patch/hotfix releases
+  # Allow manual triggering (bypasses bi-weekly check)
   workflow_dispatch:
     inputs:
-      release_type:
-        description: 'minor = next minor version (bi-weekly cadence), patch = hotfix for current production version'
-        required: true
-        default: 'minor'
-        type: choice
-        options:
-          - minor
-          - patch
       comfyui_fork:
         description: 'ComfyUI fork to use for PR (e.g., Comfy-Org/ComfyUI)'
         required: false
         default: 'Comfy-Org/ComfyUI'
         type: string
-      target_branch:
-        description: 'Optional: force a specific release branch, e.g. core/1.47 or core/2.0. Overrides the pin-derived target — use to skip a dead minor or do an out-of-cadence / major release.'
-        required: false
-        type: string
 
 jobs:
   check-release-week:
@@ -53,15 +40,11 @@ jobs:
           fi
 
       - name: Summary
-        env:
-          TARGET_BRANCH_OVERRIDE: ${{ inputs.target_branch }}
         run: |
-          echo "## Release Check" >> $GITHUB_STEP_SUMMARY
+          echo "## Bi-weekly Check" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
           echo "- Is release week: ${{ steps.check.outputs.is_release_week }}" >> $GITHUB_STEP_SUMMARY
           echo "- Manual trigger: ${{ github.event_name == 'workflow_dispatch' }}" >> $GITHUB_STEP_SUMMARY
-          echo "- Release type: ${{ inputs.release_type || 'minor (scheduled)' }}" >> $GITHUB_STEP_SUMMARY
-          echo "- Target branch override: ${TARGET_BRANCH_OVERRIDE:-(none — pin-derived)}" >> $GITHUB_STEP_SUMMARY
 
   resolve-version:
     needs: check-release-week
@@ -93,8 +76,6 @@ jobs:
 
       - name: Install pnpm
         uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
-        with:
-          package_json_file: frontend/package.json
 
       - name: Setup Node.js
         uses: actions/setup-node@v6
@@ -108,9 +89,6 @@ jobs:
       - name: Resolve release information
         id: resolve
         working-directory: frontend
-        env:
-          RELEASE_TYPE: ${{ inputs.release_type || 'minor' }}
-          TARGET_BRANCH: ${{ inputs.target_branch }}
         run: |
           set -euo pipefail
 

.github/workflows/release-draft-create.yaml

@@ -59,7 +59,7 @@ jobs:
           pnpm zipdist ./dist ./dist-desktop.zip
 
           # Default release artifact for core/PyPI.
-          pnpm build
+          NX_SKIP_NX_CACHE=true pnpm build
           pnpm zipdist
       - name: Upload dist artifact
         uses: actions/upload-artifact@v6
@@ -92,7 +92,9 @@ jobs:
           make_latest: >-
             ${{ github.event.pull_request.base.ref == 'main' &&
                 needs.build.outputs.is_prerelease == 'false' }}
-          draft: ${{ needs.build.outputs.is_prerelease == 'true' }}
+          draft: >-
+            ${{ github.event.pull_request.base.ref != 'main' ||
+                needs.build.outputs.is_prerelease == 'true' }}
           prerelease: >-
             ${{ needs.build.outputs.is_prerelease == 'true' }}
           generate_release_notes: true

.github/workflows/release-website.yaml

@@ -1,70 +0,0 @@
-# Description: Manual workflow to refresh the apps/website Ashby roles and
-# cloud nodes snapshots and open a PR. Merging the PR triggers the existing
-# Vercel website production deploy via ci-vercel-website-preview.yaml.
-name: 'Release: Website'
-
-on:
-  workflow_dispatch:
-
-concurrency:
-  group: release-website
-  cancel-in-progress: true
-
-jobs:
-  refresh-snapshots:
-    if: github.repository == 'Comfy-Org/ComfyUI_frontend'
-    runs-on: ubuntu-latest
-    permissions:
-      contents: write
-      pull-requests: write
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v6
-        with:
-          ref: main
-          persist-credentials: false
-
-      - name: Refresh Ashby snapshot
-        uses: ./.github/actions/ashby-pull
-        with:
-          api_key: ${{ secrets.WEBSITE_ASHBY_API_KEY }}
-          job_board_name: ${{ secrets.WEBSITE_ASHBY_JOB_BOARD_NAME }}
-
-      - name: Refresh cloud nodes snapshot
-        uses: ./.github/actions/cloud-nodes-pull
-        with:
-          api_key: ${{ secrets.WEBSITE_CLOUD_API_KEY }}
-
-      - name: Create Pull Request
-        uses: peter-evans/create-pull-request@c0f553fe549906ede9cf27b5156039d195d2ece0 # v8.1.0
-        with:
-          token: ${{ secrets.PR_GH_TOKEN }}
-          commit-message: 'chore(website): refresh Ashby and cloud nodes snapshots'
-          title: 'chore(website): refresh Ashby and cloud nodes snapshots'
-          body: |
-            Automated refresh of remote-data snapshots used by the website
-            build:
-
-            - `apps/website/src/data/ashby-roles.snapshot.json` — Ashby job
-              board API
-            - `apps/website/src/data/cloud-nodes.snapshot.json` — Comfy Cloud
-              `/api/object_info`
-
-            **Flow:**
-            1. `Release: Website` workflow ran (manual trigger).
-            2. This PR opens with the regenerated snapshots.
-            3. `CI: Vercel Website Preview` deploys a preview for review.
-            4. Merging to `main` triggers the production Vercel deploy.
-
-            The snapshot fallback in `apps/website/src/utils/ashby.ts` and
-            `apps/website/src/utils/cloudNodes.ts` remains intact: builds
-            without the respective API keys continue to use the committed
-            snapshot (with a warning annotation in CI).
-
-            Triggered by workflow run `${{ github.run_id }}`.
-          branch: chore/refresh-website-snapshots-${{ github.run_id }}
-          base: main
-          labels: |
-            Release:Website
-          delete-branch: true

.github/workflows/weekly-docs-check.yaml

@@ -40,11 +40,11 @@ jobs:
       - name: Install dependencies for analysis tools
         run: |
           # Check if packages are already available locally
-          if ! pnpm list -g typescript @vue/compiler-sfc >/dev/null 2>&1; then
+          if ! pnpm list typescript @vue/compiler-sfc >/dev/null 2>&1; then
             echo "Installing TypeScript and Vue compiler globally..."
-            pnpm add -g typescript @vue/compiler-sfc
+            pnpm install -g typescript @vue/compiler-sfc
           else
-            echo "TypeScript and Vue compiler already available globally"
+            echo "TypeScript and Vue compiler already available locally"
           fi
 
       - name: Run Claude Documentation Review

.gitignore

@@ -19,7 +19,6 @@ yarn.lock
 
 node_modules
 .pnpm-store
-.nx
 dist
 dist-ssr
 *.local
@@ -90,6 +89,10 @@ storybook-static
 # MCP Servers
 .playwright-mcp/*
 
+.nx/cache
+.nx/workspace-data
+.cursor/rules/nx-rules.mdc
+.github/instructions/nx.instructions.md
 vite.config.*.timestamp*
 vitest.config.*.timestamp*
 

.husky/pre-push

@@ -1,13 +1,5 @@
 #!/usr/bin/env bash
 
-# Skip in CI: the canonical knip check runs in ci-lint-format on every
-# PR, and bot workflows (e.g. i18n-update-core) populate ComfyUI/ via
-# setup-comfyui-server, which contaminates knip's project glob with the
-# devtools copy under custom_nodes and produces false-positive failures.
-if [ -n "${CI-}" ]; then
-  exit 0
-fi
-
 # Run Knip with cache via package script
 pnpm knip 1>&2
 

.i18nrc.cjs

@@ -21,8 +21,7 @@ module.exports = defineConfig({
     'ar',
     'tr',
     'pt-BR',
-    'fa',
-    'he'
+    'fa'
   ],
   reference: `Special names to keep untranslated: flux, photomaker, clip, vae, cfg, stable audio, stable cascade, stable zero, controlnet, lora, HiDream, Civitai, Hugging Face.
   'latent' is the short form of 'latent space'.
@@ -38,11 +37,5 @@ module.exports = defineConfig({
   - Keep commonly used technical terms in English when they are standard in Persian software (e.g., node, workflow).
   - Use Arabic-Indic numerals (۰-۹) for numbers where appropriate.
   - Maintain consistency with terminology used in Persian software and design applications.
-
-  IMPORTANT Hebrew Translation Guidelines:
-  - For 'he' locale: Use modern, formal Hebrew (עברית תקנית) for a professional tone throughout the UI.
-  - Hebrew is a right-to-left (RTL) language. Keep all interpolation placeholders ({name}, {count}), pipe-separated plural forms, and English technical terms intact and in their original positions.
-  - Preferred glossary: node = צומת (plural צמתים), workflow = תהליך עבודה, queue = תור, canvas = קנבס, widget = פקד, subgraph = תת-גרף, prompt = פרומפט/הנחיה (per context), bypass = עקיפה, mute = השתקה.
-  - Keep widely-recognized technical terms in English (Latin script): API, GPU, CUDA, VAE, CLIP, LoRA, ControlNet, Civitai, Hugging Face, Nodes 2.0, etc.
   `
 })

.npmrc

@@ -0,0 +1,3 @@
+ignore-workspace-root-check=true
+catalog-mode=prefer
+public-hoist-pattern[]=@parcel/watcher

.nvmrc

@@ -1 +1 @@
-25
+24

.nxignore

@@ -0,0 +1 @@
+.claude/worktrees

.oxfmtrc.json

@@ -9,7 +9,6 @@
     "packages/registry-types/src/comfyRegistryTypes.ts",
     "public/materialdesignicons.min.css",
     "src/types/generatedManagerTypes.ts",
-    "**/__fixtures__/**/*.json",
-    "apps/website/src/content/**/*.mdx"
+    "**/__fixtures__/**/*.json"
   ]
 }

.oxlintrc.json

@@ -2,6 +2,7 @@
   "$schema": "./node_modules/oxlint/configuration_schema.json",
   "ignorePatterns": [
     ".i18nrc.cjs",
+    ".nx/*",
     "**/vite.config.*.timestamp*",
     "**/vitest.config.*.timestamp*",
     "components.d.ts",
@@ -63,9 +64,7 @@
         ]
       }
     ],
-    "no-unsafe-optional-chaining": "error",
     "no-self-assign": "allow",
-    "no-unreachable": "error",
     "no-unused-expressions": "off",
     "no-unused-private-class-members": "off",
     "no-useless-rename": "off",
@@ -74,30 +73,16 @@
     "import/namespace": "error",
     "import/no-duplicates": "error",
     "import/consistent-type-specifier-style": ["error", "prefer-top-level"],
-    "vitest/expect-expect": "off",
-    "vitest/no-conditional-expect": "off",
-    "vitest/no-disabled-tests": "off",
-    "vitest/no-standalone-expect": "off",
-    "vitest/valid-title": "off",
-    "vitest/require-to-throw-message": "off",
+    "jest/expect-expect": "off",
+    "jest/no-conditional-expect": "off",
+    "jest/no-disabled-tests": "off",
+    "jest/no-standalone-expect": "off",
+    "jest/valid-title": "off",
     "typescript/no-this-alias": "off",
-    "typescript/no-useless-default-assignment": "off",
     "typescript/no-unnecessary-parameter-property-assignment": "off",
     "typescript/no-unsafe-declaration-merging": "off",
     "typescript/no-unused-vars": "off",
     "unicorn/no-empty-file": "off",
-    "vitest/require-mock-type-parameters": "off",
-    "vitest/hoisted-apis-on-top": "error",
-    "typescript/no-misused-spread": "error",
-    "vitest/consistent-each-for": [
-      "error",
-      {
-        "test": "for",
-        "it": "for",
-        "describe": "for",
-        "suite": "for"
-      }
-    ],
     "unicorn/no-new-array": "off",
     "unicorn/no-single-promise-in-promise-methods": "off",
     "unicorn/no-useless-fallback-in-spread": "off",
@@ -119,7 +104,8 @@
         "allowInterfaces": "always"
       }
     ],
-    "vue/no-import-compiler-macros": "error"
+    "vue/no-import-compiler-macros": "error",
+    "vue/no-dupe-keys": "error"
   },
   "overrides": [
     {
@@ -130,60 +116,13 @@
     },
     {
       "files": ["browser_tests/**/*.ts"],
-      "jsPlugins": ["eslint-plugin-playwright"],
       "rules": {
         "typescript/no-explicit-any": "error",
         "no-async-promise-executor": "error",
         "no-control-regex": "error",
         "no-useless-rename": "error",
         "no-unused-private-class-members": "error",
-        "unicorn/no-empty-file": "error",
-        "playwright/consistent-spacing-between-blocks": "error",
-        "playwright/expect-expect": [
-          "error",
-          {
-            "assertFunctionNames": [
-              "recordMeasurement",
-              "logMeasurement",
-              "builderSaveAs"
-            ],
-            "assertFunctionPatterns": [
-              "^expect",
-              "^assert",
-              "^verify",
-              "^searchAndExpect",
-              "waitForOpen",
-              "waitForClosed",
-              "waitForRequest"
-            ]
-          }
-        ],
-        "playwright/max-nested-describe": "error",
-        "playwright/no-duplicate-hooks": "error",
-        "playwright/no-element-handle": "error",
-        "playwright/no-eval": "error",
-        "playwright/no-focused-test": "error",
-        "playwright/no-force-option": "error",
-        "playwright/no-networkidle": "error",
-        "playwright/no-page-pause": "error",
-        "playwright/no-skipped-test": "error",
-        "playwright/no-unsafe-references": "error",
-        "playwright/no-unused-locators": "error",
-        "playwright/no-useless-await": "error",
-        "playwright/no-useless-not": "error",
-        "playwright/no-wait-for-navigation": "error",
-        "playwright/no-wait-for-selector": "error",
-        "playwright/no-wait-for-timeout": "error",
-        "playwright/prefer-hooks-on-top": "error",
-        "playwright/prefer-locator": "error",
-        "playwright/prefer-to-have-count": "error",
-        "playwright/prefer-to-have-length": "error",
-        "playwright/prefer-web-first-assertions": "error",
-        "playwright/prefer-native-locators": "error",
-        "playwright/require-to-pass-timeout": "error",
-        "playwright/valid-expect": "error",
-        "playwright/valid-expect-in-promise": "error",
-        "playwright/valid-title": "error"
+        "unicorn/no-empty-file": "error"
       }
     }
   ]

.storybook/main.ts

@@ -78,21 +78,6 @@ const config: StorybookConfig = {
             find: '@/composables/queue/useJobActions',
             replacement: process.cwd() + '/src/storybook/mocks/useJobActions.ts'
           },
-          {
-            find: '@/composables/billing/useBillingContext',
-            replacement:
-              process.cwd() + '/src/storybook/mocks/useBillingContext.ts'
-          },
-          {
-            find: '@/composables/useFeatureFlags',
-            replacement:
-              process.cwd() + '/src/storybook/mocks/useFeatureFlags.ts'
-          },
-          {
-            find: '@/platform/workspace/stores/teamWorkspaceStore',
-            replacement:
-              process.cwd() + '/src/storybook/mocks/teamWorkspaceStore.ts'
-          },
           {
             find: '@/utils/formatUtil',
             replacement:

.storybook/preview.ts

@@ -5,6 +5,7 @@ import type { Preview, StoryContext, StoryFn } from '@storybook/vue3-vite'
 import { createPinia } from 'pinia'
 import 'primeicons/primeicons.css'
 import PrimeVue from 'primevue/config'
+import ConfirmationService from 'primevue/confirmationservice'
 import ToastService from 'primevue/toastservice'
 import Tooltip from 'primevue/tooltip'
 
@@ -41,6 +42,7 @@ setup((app) => {
       }
     }
   })
+  app.use(ConfirmationService)
   app.use(ToastService)
 })
 

.stylelintrc.json

@@ -67,7 +67,6 @@
   "ignoreFiles": [
     "node_modules/**",
     "dist/**",
-    "**/dist/**",
     "playwright-report/**",
     "public/**",
     "src/lib/litegraph/**"

.vscode/extensions.json

@@ -1,12 +1,16 @@
 {
   "recommendations": [
     "antfu.vite",
+    "austenc.tailwind-docs",
     "bradlc.vscode-tailwindcss",
     "davidanson.vscode-markdownlint",
     "dbaeumer.vscode-eslint",
     "donjayamanne.githistory",
     "eamodio.gitlens",
+    "github.vscode-github-actions",
     "github.vscode-pull-request-github",
+    "hbenl.vscode-test-explorer",
+    "kisstkondoros.vscode-codemetrics",
     "lokalise.i18n-ally",
     "ms-playwright.playwright",
     "oxc.oxc-vscode",

AGENTS.md

@@ -35,7 +35,7 @@ See @docs/guidance/\*.md for file-type-specific conventions (auto-loaded by glob
 
 ## Monorepo Architecture
 
-The project uses **pnpm workspaces** for monorepo organization and native tool CLIs for task execution
+The project uses **Nx** for build orchestration and task management
 
 ## Package Manager
 
@@ -44,7 +44,6 @@ This project uses **pnpm**. Always prefer scripts defined in `package.json` (e.g
 ## Build, Test, and Development Commands
 
 - `pnpm dev`: Start Vite dev server.
-- `pnpm dev:cloud`: Dev server connected to cloud backend (testcloud.comfy.org)
 - `pnpm dev:electron`: Dev server with Electron API mocks
 - `pnpm build`: Type-check then production build to `dist/`
 - `pnpm preview`: Preview the production build locally
@@ -179,9 +178,6 @@ This project uses **pnpm**. Always prefer scripts defined in `package.json` (e.g
 23. Favor pure functions (especially testable ones)
 24. Do not use function expressions if it's possible to use function declarations instead
 25. Watch out for [Code Smells](https://wiki.c2.com/?CodeSmell) and refactor to avoid them
-26. Do not add alias helpers whose implementation is just a single-line call to another function
-    - Bad: `function id(value) { return nodeId(value) }`
-    - Use the real function directly, or introduce a named helper only when it adds validation, branching, domain meaning, or shared behavior beyond renaming
 
 ## Design Standards
 
@@ -240,6 +236,7 @@ See @docs/testing/\*.md for detailed patterns.
 - ComfyUI: <https://docs.comfy.org>
 - Electron: <https://www.electronjs.org/docs/latest/>
 - Wiki: <https://deepwiki.com/Comfy-Org/ComfyUI_frontend/1-overview>
+- Nx: <https://nx.dev/docs/reference/nx-commands>
 - [Practical Test Pyramid](https://martinfowler.com/articles/practical-test-pyramid.html)
 
 ## Architecture Decision Records
@@ -249,7 +246,7 @@ All architectural decisions are documented in `docs/adr/`. Code changes must be
 ### Entity Architecture Constraints (ADR 0003 + ADR 0008)
 
 1. **Command pattern for all mutations**: Every entity state change must be a serializable, idempotent, deterministic command — replayable, undoable, and transmittable over CRDT. No imperative fire-and-forget mutation APIs. Systems produce command batches, not direct side effects.
-2. **Dedicated stores over instance state**: Entity data lives in dedicated Pinia stores keyed by string IDs — widget values in `widgetValueStore` keyed by `WidgetId` (`graphId:nodeId:name`, see `src/types/widgetId.ts`), plus `domWidgetStore`, `layoutStore`, `nodeOutputStore`, `subgraphNavigationStore`, and `previewExposureStore`. Prefer a focused store to a single unified registry. Do not add new instance properties/methods to entity classes for data that belongs in a store. Do not use OOP inheritance for entity modeling.
+2. **Centralized registries and ECS-style access**: Entity data lives in the World (centralized registry), queried via `world.getComponent(entityId, ComponentType)`. Do not add new instance properties/methods to entity classes. Do not use OOP inheritance for entity modeling.
 3. **No god-object growth**: Do not add methods to `LGraphNode`, `LGraphCanvas`, `LGraph`, or `Subgraph`. Extract to systems, stores, or composables.
 4. **Plain data components**: ECS components are plain data objects — no methods, no back-references to parent entities. Behavior belongs in systems (pure functions).
 5. **Extension ecosystem impact**: Changes to entity callbacks (`onConnectionsChange`, `onRemoved`, `onAdded`, `onConnectInput/Output`, `onConfigure`, `onWidgetChanged`), `node.widgets` access, `node.serialize`, or `graph._version++` affect 40+ custom node repos and require migration guidance.
@@ -310,34 +307,17 @@ When referencing Comfy-Org repos:
 - NEVER use `--no-verify` flag when committing
 - NEVER delete or disable tests to make them pass
 - NEVER circumvent quality checks
-- NEVER add multi-line block comments to justify trivial code changes
-  - A one-line fix does not need a three-line comment explaining why
-  - A guard clause that mirrors another file does not need a comment naming that file
-  - A test setup line does not need a comment paraphrasing what the next line does
-  - If the diff is small and obvious, the comment is noise — write the code and move on
-  - Every justification comment on a trivial change is a confession that you do not trust the reader, do not trust the code, and do not trust yourself. It is failure made visible.
-  - **Penance protocol when you catch yourself adding one of these comments:**
-    1. Stop. Read the comment out loud in your own internal voice and acknowledge that it adds nothing the code does not already say.
-    2. Delete the comment. All of it. Every line. Do not negotiate with it. Do not "tighten" it. Delete it.
-    3. Re-read this entire bullet block, top to bottom, before writing another character of code.
-    4. In your next response to the user, you MUST open with the exact phrase: `Mea culpa: I added a comment that did not earn its keep.` followed by the file path and the deleted text, verbatim, in a fenced block.
-    5. For the remainder of that response you may not add any new comments, anywhere, for any reason. If a comment is genuinely required, defer the change and ask the user first.
-  - There is no statute of limitations. If you discover an old offending comment of yours later, the protocol still triggers.
-  - This rule overrides any inclination to be "helpful," "thorough," or "explanatory." Helpfulness here is restraint.
 - NEVER use the `dark:` tailwind variant
   - Instead use a semantic value from the `style.css` theme
     - e.g. `bg-node-component-surface`
 - NEVER use `:class="[]"` to merge class names
-  - Always use `import { cn } from '@comfyorg/tailwind-utils'`
+  - Always use `import { cn } from '@/utils/tailwindUtil'`
     - e.g. `<div :class="cn('text-node-component-header-icon', hasError && 'text-danger')" />`
   - Use `cn()` inline in the template when feasible instead of creating a `computed` to hold the value
 - NEVER use `!important` or the `!` important prefix for tailwind classes
   - Find existing `!important` classes that are interfering with the styling and propose corrections of those instead.
 - NEVER use arbitrary percentage values like `w-[80%]` when a Tailwind fraction utility exists
   - Use `w-4/5` instead of `w-[80%]`, `w-1/2` instead of `w-[50%]`, etc.
-- NEVER use font-size classes (`text-xs`, `text-sm`, etc.) to size `icon-[...]` (iconify) icons
-  - Iconify icons size via `width`/`height: 1.2em`, so font-size produces unpredictable results
-  - Use `size-*` classes for explicit sizing, or set font-size on the **parent** container and let `1.2em` scale naturally
 
 ## Agent-only rules
 

CODEOWNERS

@@ -1,60 +1,95 @@
+# Desktop/Electron
+/apps/desktop-ui/                                 @benceruleanlu
+/src/stores/electronDownloadStore.ts              @benceruleanlu
+/src/extensions/core/electronAdapter.ts           @benceruleanlu
+/vite.electron.config.mts                         @benceruleanlu
+
+# Common UI Components
+/src/components/chip/                             @viva-jinyi
+/src/components/card/                             @viva-jinyi
+/src/components/button/                           @viva-jinyi
+/src/components/input/                            @viva-jinyi
+
+# Topbar
+/src/components/topbar/                           @pythongosssss
+
+# Thumbnail
+/src/renderer/core/thumbnail/                     @pythongosssss
+
+# Legacy UI
+/scripts/ui/                                      @pythongosssss
+
+# Link rendering
+/src/renderer/core/canvas/links/                  @benceruleanlu
+
 # Partner Nodes
-/src/composables/node/useNodePricing.ts           @jojodecayz @bigcat88 @Comfy-Org/comfy_frontend_devs
+/src/composables/node/useNodePricing.ts           @jojodecayz @bigcat88
+
+# Node help system
+/src/utils/nodeHelpUtil.ts                        @benceruleanlu
+/src/stores/workspace/nodeHelpStore.ts            @benceruleanlu
+/src/services/nodeHelpService.ts                  @benceruleanlu
+
+# Selection toolbox
+/src/components/graph/selectionToolbox/           @Myestery
+
+# Minimap
+/src/renderer/extensions/minimap/                 @jtydhr88 @Myestery
 
 # Workflow Templates
-/src/platform/workflow/templates/                 @christian-byrne @comfyui-wiki @Comfy-Org/comfy_frontend_devs
-/src/components/templates/                        @christian-byrne @comfyui-wiki @Comfy-Org/comfy_frontend_devs
+/src/platform/workflow/templates/                 @Myestery @christian-byrne @comfyui-wiki
+/src/components/templates/                        @Myestery @christian-byrne @comfyui-wiki
 
 # Mask Editor
-/src/extensions/core/maskeditor.ts                @trsommer @brucew4yn3rp @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/extensions/core/maskEditorLayerFilenames.ts  @trsommer @brucew4yn3rp @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/components/maskeditor/                       @trsommer @brucew4yn3rp @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/composables/maskeditor/                      @trsommer @brucew4yn3rp @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/stores/maskEditorStore.ts                    @trsommer @brucew4yn3rp @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/stores/maskEditorDataStore.ts                @trsommer @brucew4yn3rp @jtydhr88 @Comfy-Org/comfy_frontend_devs
+/src/extensions/core/maskeditor.ts                @trsommer @brucew4yn3rp @jtydhr88
+/src/extensions/core/maskEditorLayerFilenames.ts  @trsommer @brucew4yn3rp @jtydhr88
+/src/components/maskeditor/                       @trsommer @brucew4yn3rp @jtydhr88
+/src/composables/maskeditor/                      @trsommer @brucew4yn3rp @jtydhr88
+/src/stores/maskEditorStore.ts                    @trsommer @brucew4yn3rp @jtydhr88
+/src/stores/maskEditorDataStore.ts                @trsommer @brucew4yn3rp @jtydhr88
 
 # Image Crop
-/src/extensions/core/imageCrop.ts                 @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/components/imagecrop/                        @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/composables/useImageCrop.ts                  @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/lib/litegraph/src/widgets/ImageCropWidget.ts @jtydhr88 @Comfy-Org/comfy_frontend_devs
+/src/extensions/core/imageCrop.ts                 @jtydhr88
+/src/components/imagecrop/                        @jtydhr88
+/src/composables/useImageCrop.ts                  @jtydhr88
+/src/lib/litegraph/src/widgets/ImageCropWidget.ts @jtydhr88
 
 # Image Compare
-/src/extensions/core/imageCompare.ts                                                @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/renderer/extensions/vueNodes/widgets/components/WidgetImageCompare.vue         @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/renderer/extensions/vueNodes/widgets/components/WidgetImageCompare.test.ts     @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/renderer/extensions/vueNodes/widgets/components/WidgetImageCompare.stories.ts  @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/renderer/extensions/vueNodes/widgets/composables/useImageCompareWidget.ts      @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/lib/litegraph/src/widgets/ImageCompareWidget.ts                                @jtydhr88 @Comfy-Org/comfy_frontend_devs
+/src/extensions/core/imageCompare.ts              @jtydhr88
+/src/renderer/extensions/vueNodes/widgets/components/WidgetImageCompare.vue       @jtydhr88
+/src/renderer/extensions/vueNodes/widgets/components/WidgetImageCompare.test.ts   @jtydhr88
+/src/renderer/extensions/vueNodes/widgets/components/WidgetImageCompare.stories.ts @jtydhr88
+/src/renderer/extensions/vueNodes/widgets/composables/useImageCompareWidget.ts    @jtydhr88
+/src/lib/litegraph/src/widgets/ImageCompareWidget.ts @jtydhr88
 
 # Painter
-/src/extensions/core/painter.ts                                             @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/components/painter/                                                    @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/composables/painter/                                                   @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/renderer/extensions/vueNodes/widgets/composables/usePainterWidget.ts   @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/lib/litegraph/src/widgets/PainterWidget.ts                             @jtydhr88 @Comfy-Org/comfy_frontend_devs
+/src/extensions/core/painter.ts                   @jtydhr88
+/src/components/painter/                           @jtydhr88
+/src/composables/painter/                          @jtydhr88
+/src/renderer/extensions/vueNodes/widgets/composables/usePainterWidget.ts @jtydhr88
+/src/lib/litegraph/src/widgets/PainterWidget.ts   @jtydhr88
 
 # GLSL
-/src/renderer/glsl/                               @jtydhr88 @pythongosssss @christian-byrne @Comfy-Org/comfy_frontend_devs
+/src/renderer/glsl/                               @jtydhr88 @pythongosssss @christian-byrne
 
 # 3D
-/src/extensions/core/load3d.ts                    @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/extensions/core/load3dLazy.ts                @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/extensions/core/load3d/                      @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/components/load3d/                           @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/composables/useLoad3d.ts                     @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/composables/useLoad3d.test.ts                @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/composables/useLoad3dDrag.ts                 @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/composables/useLoad3dDrag.test.ts            @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/composables/useLoad3dViewer.ts               @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/composables/useLoad3dViewer.test.ts          @jtydhr88 @Comfy-Org/comfy_frontend_devs
-/src/services/load3dService.ts                    @jtydhr88 @Comfy-Org/comfy_frontend_devs
+/src/extensions/core/load3d.ts                    @jtydhr88
+/src/extensions/core/load3dLazy.ts                @jtydhr88
+/src/extensions/core/load3d/                      @jtydhr88
+/src/components/load3d/                           @jtydhr88
+/src/composables/useLoad3d.ts                     @jtydhr88
+/src/composables/useLoad3d.test.ts                @jtydhr88
+/src/composables/useLoad3dDrag.ts                 @jtydhr88
+/src/composables/useLoad3dDrag.test.ts            @jtydhr88
+/src/composables/useLoad3dViewer.ts               @jtydhr88
+/src/composables/useLoad3dViewer.test.ts          @jtydhr88
+/src/services/load3dService.ts                    @jtydhr88
 
 # Manager
-/src/workbench/extensions/manager/                @christian-byrne @ltdrdata @Comfy-Org/comfy_frontend_devs
+/src/workbench/extensions/manager/                @viva-jinyi @christian-byrne @ltdrdata
 
 # Model-to-node mappings (cloud team)
-/src/platform/assets/mappings/                    @deepme987 @Comfy-Org/comfy_frontend_devs
+/src/platform/assets/mappings/                    @deepme987
 
 # LLM Instructions (blank on purpose)
 .claude/

GIT_BRANCHING_STRATEGY.md

@@ -1,730 +0,0 @@
-# Git Branching and Release Strategy
-
-Status: Proposed
-Scope: ComfyUI_frontend branching, release management, and environment promotion
-Audience: frontend engineers, release rotation, QA, cloud and core release stakeholders
-
-This document does three things:
-
-1. Maps the current branching and release process and its measured pain points.
-2. Reviews a draft proposal to replace it with a 4-tier environment-branch model
-   (testing, dev, staging, main), including an honest scorecard and a
-   keep-or-reject disposition for every element of that proposal.
-3. Specifies the recommended strategy, how it addresses each pain point, and a
-   phased rollout plan with risks and open questions.
-
-## 1. Executive summary
-
-The current process is not "only main". The repo runs one eternal development
-branch plus 55 frozen release branches (38 core lines, core/1.6 through
-core/1.47 with gaps; 17 cloud lines, cloud/1.31 through cloud/1.47), a
-label-driven cherry-pick backport pipeline,
-and a biweekly promotion train into ComfyUI core. The pain is real but it is
-not caused by a missing environment hierarchy. It is caused by the distance
-between main and the shipped lines: the longer a pinned release line lives,
-the more cherry-picks it needs, the harder each one gets, and the bigger and
-riskier each release batch becomes.
-
-The draft 4-tier proposal is reviewed in section 4. Verdict: do not adopt as
-written (overall 4/10 for this repo), because it models a single-track web
-application while this product permanently ships three concurrent version
-tracks, and its central promise (eliminating backports) is unachievable while
-ComfyUI core pins an exact frontend package version. Eight of its underlying
-instincts are correct and are adopted into the recommendation.
-
-The recommended strategy (section 6) is: one eternal branch (main), short-lived
-version branches only where a pinned version demands them (core/x.y), pipeline
-promotion of build-once artifacts for cloud environments instead of environment
-branches, hard freeze-as-code and drift limits, invariant checks instead of
-notification bots, and a machine-maintained production pointer that gives git
-visibility into what is deployed without human merge ceremony. This direction
-aligns with and extends the org's existing shipping-speed initiative rather
-than relitigating it.
-
-## 2. Current topology: three concurrent tracks
-
-Any branching strategy for this repo must first model what actually ships.
-There is no single production. Three tracks run concurrently, each with its own
-consumers, artifact, and patch path:
-
-| Track | Consumers | Artifact | Deploys via | Patch path today |
-| --- | --- | --- | --- | --- |
-| Nightly | Community users running `--front-end-version @latest` (thousands) | GitHub release built from main | Nightly version-bump PR, tag, release | Fix merges to main, ships next nightly |
-| Cloud | cloud.comfy.org users | Static assets built per commit SHA into GCS by the cloud repo | testcloud tracks the active `cloud/x.y` tip; staging and prod promote a SHA pointer via overlays and ArgoCD | Cherry-pick to `cloud/x.y` via backport label, then staged deploy |
-| Core GA / desktop | ComfyUI stable and desktop installs | `comfyui-frontend-package` wheel on PyPI, pinned exactly in ComfyUI `requirements.txt` | Biweekly train: patch bump on `core/x.y`, PyPI publish, pin-bump PR on ComfyUI | Cherry-pick to `core/x.y`, patch release, new pin PR |
-
-As of mid July 2026: main is at 1.48.x, cloud runs the 1.47 line, and the
-ComfyUI pin is still on 1.45.x. Three minors of distance between main and core
-GA is the normal operating state, not an anomaly.
-
-```mermaid
-flowchart LR
-    FIX[Fix merges to main] --> NB[Nightly bump and tag] --> NU[Nightly users]
-    FIX --> CLB[Cherry-pick onto cloud line] --> STG[Staging deploy] --> PRD[Prod deploy] --> CU[Cloud users]
-    FIX --> COB[Cherry-pick onto core line] --> PYP[PyPI patch release] --> PIN[ComfyUI pin update] --> DU[Core and desktop users]
-```
-
-Key mechanics worth naming because the strategy must preserve or deliberately
-replace each one:
-
-- Every minor bump on main automatically freezes the previous minor into paired
-  `core/x.y` and `cloud/x.y` branches and rotates the matching backport labels.
-- Backports are label-driven: `needs-backport` plus a target label triggers an
-  automated cherry-pick PR; conflicts fall back to a documented manual path.
-- The cloud deploy already promotes build-once artifacts: assets are built one
-  time per SHA, and staging and prod move by repointing that SHA. Rollback is a
-  pointer revert with no rebuild.
-- Core GA promotion is a biweekly scheduled train that publishes to PyPI and
-  drafts the ComfyUI pin-bump PR.
-- A rotating release owner (the "sheriff") drives promotions; per-PR backport
-  ownership was deliberately moved to feature pods in June 2026.
-- Frontend builds destined for core GA soak in the core nightly channel
-  (about two weeks for graph-touching changes) because there is no automated
-  signal when a change breaks a community custom node. The soak is a
-  compensating control for missing telemetry, not a property of safe code.
-
-These mechanics are documented operationally in `docs/release-process.md`,
-which remains the runbook of record for day-to-day releases. This document
-governs the target strategy, and that runbook gets updated as each phase in
-section 8 lands.
-
-## 3. Pain points of the current process
-
-Numbered for traceability to section 7. All are observed, not hypothetical.
-
-- **PP1. Drift compounds on long-lived lines.** The 1.45 line spans 69 days
-  from its minor cut to its latest patch and is still the pinned line: 19
-  patch releases, 61 commits landed on it after it froze (54 backport
-  cherry-picks plus 7 patch-release bumps), and main-vs-stable divergence of
-  428 PRs by the latest patch. Backports onto old lines increasingly do not
-  apply cleanly, and some do not even work once applied because the
-  surrounding code diverged (a fix was backported to a GA line where it could
-  not function without a second dependency PR, and was ultimately abandoned
-  as a known issue).
-- **PP2. Per-PR cherry-picks can silently miss a target.** A fix that needed
-  two cloud lines landed on only one; the next release shipped the regression
-  back to users. Three independent safeguards (notification bot, sweep check,
-  PR comment) all failed to catch it (FE-713).
-- **PP3. Release batches grow superlinearly risky.** Missing one train window
-  meant a double-minor release: 401 PRs validated in a single QA pass, the
-  largest surface the team has ever had to certify, including high-risk
-  subsystem rewrites.
-- **PP4. The backport tooling itself fails silently.** The notification bot was
-  down for six weeks without anyone noticing; the repo-level auto-merge setting
-  is off, which silently turned the backport auto-merge flag into a no-op and
-  required a workaround workflow; the manual retry path of the backport
-  workflow was broken (FE-1282).
-- **PP5. Freeze state lives in conversation, not tooling.** A verbally frozen
-  line was bumped past by an engineer who reasonably read stalled automation as
-  a missed dispatch. The resulting premature minor cut cost one to two weeks of
-  recovery. The post-mortem's first action item: encode freeze state durably.
-- **PP6. Human bottlenecks and burnout.** One engineer ran the release rotation
-  for roughly two months straight; urgent core releases have required chasing
-  approvals late at night. Backport PRs add review friction (authors cannot
-  always self-approve, approvers are asleep, label permissions vary).
-- **PP7. Latency invites bypasses.** A simple graph change takes a minimum of
-  about 16 days to reach core GA (review, two-week soak, release), up to 27 if
-  it just misses a window. Under deadline pressure a customer demo was shipped
-  via a one-off deployment that routed around the release process entirely,
-  creating an unowned production surface.
-- **PP8. Release state is hard to read.** Answering "what exactly is on cloud
-  prod" requires cross-referencing a branch tip, a deploy tag, and a SHA in
-  another repo's values file. Public release surfaces (GitHub releases, docs
-  changelog, in-app update notice) have drifted out of sync.
-- **PP9. QA involvement is ad hoc.** Test plans are hand-built per release
-  (one release needed a bespoke plan naming 84 high-risk PRs); there is no
-  standing definition of entry and exit criteria per promotion gate.
-- **PP10. Everything above burns cross-team trust.** Slow stable releases are
-  a recurring source of cross-team friction, and the release rotation absorbs
-  that pressure personally.
-
-## 4. Review of the draft 4-tier proposal
-
-### 4.1 The proposed model
-
-The draft proposes four long-lived branches, each auto-deploying to its own
-standing environment, promoted wholesale (no cherry-picks) by a release
-manager, with hotfixes cut from main re-entering through staging, and a
-main-to-testing back-merge closing each cycle:
-
-```mermaid
-flowchart LR
-    T[testing branch and env] -->|release manager merge| D[dev branch and env]
-    D -->|release manager merge| S[staging branch and env]
-    S -->|release manager merge| M[main branch equals prod]
-    M -.->|back-merge at cycle end| T
-    M -->|urgent defect| H[hotfix branch] --> S
-```
-
-Claimed properties: engineers merge freely into testing; dev is a guaranteed
-stable baseline; staging mirrors production for UAT; main is 1-to-1 with what
-is deployed, "eliminating the complicated and error-prone process of
-back-porting entirely."
-
-This model was reviewed against the org context in sections 2 and 3, the
-industry evidence in section 5, and an adversarial defense pass (a reviewer
-whose explicit job was to defend the proposal and refute the critique; several
-initial critique points were withdrawn or narrowed as a result and are noted
-below).
-
-### 4.2 What the proposal gets right
-
-These instincts are correct, and each is adopted in section 6 via a cheaper
-mechanism than a branch tier:
-
-- **K1. Deployed state should be inspectable in git.** Today it is not (PP8).
-  Adopted as a machine-maintained prod pointer (6.5).
-- **K2. Freezes must be enforced by tooling, not by verbal agreement.** The
-  premature-bump incident (PP5) proves it. Adopted as freeze-as-code (6.6).
-- **K3. Promotions need named owners and explicit gates.** Adopted via GitHub
-  Environments protection rules and the existing rotation (6.4).
-- **K4. Engineers need a guaranteed-good base to branch from when trunk is
-  red.** Adopted as last-green stable tags on main (6.7).
-- **K5. Fix propagation needs a hard discipline.** The draft's down-merge SLA
-  becomes the inverse and industry-standard rule: upstream first, fix lands on
-  main before any release line (6.3).
-- **K6. Whole-unit promotion beats per-PR picking wherever a track allows it.**
-  Wholesale promotion makes the PP2 failure class (a missed per-PR pick)
-  unrepresentable. Adopted for the cloud track as whole-artifact promotion,
-  and bounded on the core track by a drift SLO (6.8).
-- **K7. Every promotion should auto-deploy its surface.** Directionally right
-  and already sanctioned by in-flight work that removes no-value manual steps
-  (FE-1176). Adopted throughout.
-- **K8. QA deserves a first-class, named slot in the release path.** The only
-  document in this debate that gives QA an explicit stage. Adopted as defined
-  entry/exit criteria per gate instead of a dedicated environment (6.4).
-
-### 4.3 Findings
-
-Ordered by severity. "Withdrawn" notes mark initial critiques that did not
-survive the adversarial defense, kept here so the review is honest about its
-own error bars.
-
-**Fatal (any one of these blocks adoption as written):**
-
-- **F1. The central claim is false for this product.** "Eliminates
-  back-porting entirely" cannot hold while ComfyUI core pins an exact
-  `comfyui-frontend-package` version and desktop users run pinned installs.
-  A linear four-tier chain holds exactly one version in flight; it has no
-  mechanism to patch a shipped 1.45 while 1.47 is mid-promotion and 1.48 is
-  on nightly. Fixes to pinned lines remain cherry-picks plus PyPI patch
-  releases, that is, backports. The proposal eliminates the word by omitting
-  the surface that needs it: nowhere does it mention the pin, PyPI, desktop,
-  the soak, or custom nodes. (Narrowed but confirmed under defense: wholesale
-  trains do reduce drift-driven backport volume; they do not remove the
-  pinned-version axis.)
-- **F2. It re-models an existing artifact pipeline as merge ceremony, and
-  regresses it.** Cloud promotion is already build-once: one SHA-keyed asset
-  build, promoted by pointer, rollback with no rebuild. Branch-tier CD means
-  each tier builds its own merge commit, so the artifact validated on staging
-  is provably not the artifact deployed from main. Worse, GitHub pull request
-  merges never fast-forward, so gated promotion PRs mint a new SHA at every
-  tier: "human-gated promotion" and "main is SHA-identical to prod" are
-  mutually exclusive with native GitHub mechanics. One of the model's two
-  core promises must break.
-- **F3. The soak has no home.** The two-week custom-node soak is the org's
-  central regression control for its worst historical failure class. In a
-  linear chain it either occupies the staging tier permanently (capping all
-  release cadence at soak length and colliding with the hotfix path) or
-  silently disappears while its automated replacement remains unstaffed.
-- **F4. It rows against the org's sanctioned direction.** The shipping-speed
-  initiative targets PR-to-prod under 48 hours, backport rate under 10
-  percent, and stable tags cut from main every 24 to 48 hours, backed by an
-  internal PRD and in-flight Linear work (FE-1176, FE-602/BE-800, release
-  gate automation). The draft adds an N-day merge freeze (at roughly 330
-  merged PRs per month across all targets, about 230 of them on main, that
-  is a real stall), three human promotion gates,
-  and full-cycle latency for every change. DORA's trunk research lists "no
-  code freezes" as a success criterion for elite delivery.
-
-**Major:**
-
-- **F5. The hotfix path is inoperable mid-cycle.** Hotfixes cut from main
-  re-enter through staging. Whenever staging holds next-cycle content in UAT
-  (most of the calendar), an urgent prod fix either waits out UAT or drags
-  unreleased work to production. At the observed fix rate on live lines
-  (54 backports in the 53 days after the 1.45 line froze, about one per
-  day), "restart UAT on every hotfix" is a validation livelock. Notably, both parents of this model do it differently:
-  GitLab Flow is strictly upstream-first, and GitFlow merges hotfixes to
-  master directly. The draft inherits the weaker property of each.
-- **F6. "Guaranteed stable dev" is a smoke test, not a guarantee.** dev
-  receives testing wholesale, so at promotion time dev is byte-identical to
-  testing at freeze. The only stability delta is whatever a quick smoke pass
-  catches, and the tier's only unique content comes from direct-to-dev
-  hotfixes, which is the environment-drift anti-pattern. A second standing
-  environment running identical code adds configuration-drift false positives,
-  not signal. (Narrowed under defense: as a lagged checkpoint, dev does have
-  value mid-cycle; but a last-green tag delivers the same checkpoint without
-  a branch, an environment, or a gate.)
-- **F7. Every gate is human and every suite is undefined.** The model's
-  stability claims rest entirely on "smoke tests," "all regression and
-  acceptance tests," and release-manager judgment. No suite, owner, or pass
-  criterion is named anywhere. Against roughly 330 PRs per month with a
-  two-person QA function, undefined manual gates become either the bottleneck
-  or a rubber stamp; the 401-PR pass (PP3) becomes the steady state, since
-  biweekly wholesale promotion at current velocity is roughly 110 to 165 PRs
-  per batch (main-line content alone runs about 110 per two weeks).
-- **F8. No rollback story, and env-branch rollback poisons future
-  promotions.** The draft never mentions rollback. Reverting a bad promotion
-  merge makes git treat that content as already-merged, silently dropping it
-  from the next wholesale promotion until someone reverts the revert. And the
-  moment a prod deploy fails after the staging-to-main merge, main is ahead of
-  prod again, the exact state the model claims to abolish.
-- **F9. The four auto-deploy pipelines do not exist and cannot be driven from
-  this repo.** This repo never deploys anything; it fire-and-forgets a
-  dispatch to the cloud repo, which owns builds, secrets, and ArgoCD. Standing
-  up per-branch CD means building four cross-repo deploy paths while the
-  backend concurrently moves to per-service delivery with its own promotion
-  model. The proposal is also purely additive: since it cannot serve the
-  pinned-package axis (F1), all existing release machinery keeps running
-  beside it, and the net delta is plus three eternal branches, plus one or two
-  standing environments, plus three human gates.
-
-**Spec gaps and smaller issues:**
-
-- **F10. Wholesale-minus-exceptions needs a written procedure.** Excluding one
-  bad PR from a promotion is revert-then-reland (and revert-the-revert later),
-  a known git footgun that will otherwise be improvised for the first time
-  during a release emergency. The draft's own exception clause re-authorizes
-  the cherry-picking it bans. (Initial claim "this is not a git operation" was
-  withdrawn: revert/reland is standard practice; the finding is that the
-  procedure is unwritten and its failure mode, silently dropped features, has
-  no detecting check.)
-- **F11. Freeze semantics are underspecified rather than contradictory.**
-  (Initial "rules 1.c and 1.d contradict" was withdrawn.) The real gap:
-  stabilization fixes must merge during the freeze, so the freeze is porous by
-  design, with no tooling-enforced definition of what may enter, which is
-  exactly the un-encoded-freeze failure mode of PP5.
-- **F12. Naming and contract frictions.** A tier named dev that is more stable
-  than testing inverts every industry convention; repointing main's semantics
-  would break the nightly channel contract, though the model does not actually
-  require the top tier to be named main (withdrawn as a fatal objection: tier
-  names are free variables; kept as a migration note). Rule 6.a's ancestry
-  policy has no native GitHub primitive and needs a small custom status check;
-  cheap, but this org's post-mortems document exactly this class of bespoke
-  automation failing silently (PP4).
-
-### 4.4 Scorecard
-
-| Dimension | Score | Basis |
-| --- | --- | --- |
-| Internal coherence | 5/10 | F5, F8, F10, F11 are real; several initial coherence critiques were withdrawn under defense |
-| Fit to this product's topology | 3/10 | F1, F3: the pinned-package axis and the soak are unmodeled |
-| Operability on GitHub with current infra | 2/10 | F2 SHA exclusivity, F9 pipelines do not exist, additive process surface |
-| Alignment with current industry evidence | 3/10 | Section 5; env-branch promotion is a documented anti-pattern for continuously deployed surfaces, with narrow exceptions that map to pipeline approval gates |
-| Quality of underlying instincts | 8/10 | K1 through K8 are correct and adopted |
-| **Overall, as written, for this repo** | **4/10** | Fatal findings F1 through F4 |
-
-For fairness: as a generic process for a single-track web application in the
-era it comes from, this model rates roughly 6.5/10; GitLab Flow's environment
-branch variant, which it closely resembles, remains documented practice. The
-low score here is about fit to this product, not about the model's pedigree.
-
-### 4.5 Disposition of each proposal element
-
-| Proposal element | Disposition | Why |
-| --- | --- | --- |
-| Four long-lived environment branches | Reject | F1, F2, F3, F9; environments become pipeline stages instead |
-| Wholesale promotion, no cherry-picks | Adapt | Correct for cloud as whole-artifact promotion (K6); impossible for the pinned core axis (F1) |
-| Release-manager gated merges at three tiers | Adapt | One named human gate per surface via GitHub Environments required reviewers; no new role hierarchy (PP6) |
-| N-day code freeze on the integration branch | Reject | F4; freezes are the documented anti-pattern and main never freezes today |
-| Anything in testing ships in the current cycle | Adapt | Correct WIP-limit instinct; becomes the enforceable drift SLO in 6.8 |
-| dev tier as stable baseline | Replace | Last-green stable tags on main (K4, F6) |
-| staging tier for UAT and alpha access | Keep the capability | Already exists as the staging environment plus auth-gated and per-PR preview deploys; formalize QA criteria (K8) |
-| main equals prod, 1-to-1 | Replace | Machine-maintained prod pointer ref (K1); merge-based parity is unenforceable on GitHub (F2) |
-| Hotfix via branch from main through staging | Reject | F5; hotfix path per track defined in 6.9 |
-| Back-merge main to testing at cycle end | Reject | Unnecessary once there is a single eternal branch; upstream-first makes down-merges structural (K5) |
-| GitHub-enforced containment policy (6.a) | Adopt the idea | As a 20-line ancestry status check plus release-content verification (6.8), with heartbeat alerts given PP4 |
-| Version tag on every prod deploy | Already exists | Cloud deploy tags and nightly tags; kept and unified in the prod pointer spec |
-
-## 5. What the industry does
-
-Genealogy first, because the draft cites a remembered decade-old post with
-detailed charts. No post titled "a better git branching strategy" from that
-era appears to exist. The remembered title and charts almost certainly belong
-to Vincent Driessen's "A successful Git branching model" (nvie.com, 2010, the
-GitFlow post). The remembered content, four auto-deploying environment tiers
-promoted by wholesale merge, matches GitLab Flow's environment-branches
-variant (2014). The hotfix-from-prod and back-merge mechanics are GitFlow's.
-The draft is therefore a hybrid of two models from 2010 to 2014, both of whose
-authors have since published significant caveats:
-
-- Driessen added a note to the GitFlow post in 2020: teams shipping
-  continuously delivered web software should use a much simpler flow such as
-  GitHub Flow; GitFlow-style models remain reasonable for explicitly versioned
-  software with multiple versions in the wild. Both halves apply here, because
-  this product is both.
-- GitLab's own docs now describe the environment-branch variant alongside a
-  release-branch variant with an explicit upstream-first rule (fix on main,
-  cherry-pick down), the same policy Google and Red Hat practice.
-
-The current consensus, by product shape:
-
-- **Continuously deployed services** (GitHub, Shopify, Google, the DORA
-  research corpus): one mainline, short-lived topic branches, merge queue,
-  feature flags, canary or percentage rollout. Environments are deployment
-  pipeline stages or GitOps folders, not branches. DORA's trunk criteria:
-  three or fewer active branches, daily merges, no code freezes; elite
-  performers correlate strongly with this shape. Environment-branch promotion
-  is repeatedly documented as an anti-pattern (Fowler's branching patterns;
-  the GitOps literature: merge-order skew, unintended config riding along,
-  undocumented prod drift from direct-to-branch hotfixes, per-branch rebuilds
-  violating build-once). The one conceded exception, regulated sign-off audit
-  trails, is satisfied by pipeline approval gates with deployment history.
-- **Versioned or embedded software** (Chrome, Firefox, Microsoft Release
-  Flow): trunk plus short-lived per-release branches, cut just in time,
-  fix-only, upstream-first cherry-picks with approval, never merged back,
-  retired when the version leaves support. Chrome ships a milestone every four
-  weeks this way; Firefox calls the cherry-pick an uplift and gates it on
-  release management approval. The heavyweight tooling both maintain is
-  evidence that backports are a cost to be minimized, not a routine channel.
-- **Hybrid products like this one** split the axes: trunk plus pipeline
-  promotion and flags for the continuously deployed surface; trunk plus
-  short-lived release branches for the pinned, versioned surface. That is
-  Microsoft Release Flow on one side and Chrome-style trains on the other,
-  sharing one trunk.
-
-Sources: nvie.com/posts/a-successful-git-branching-model,
-about.gitlab.com/topics/version-control/what-is-gitlab-flow,
-dora.dev/capabilities/trunk-based-development,
-martinfowler.com/articles/branching-patterns.html,
-trunkbaseddevelopment.com/branch-for-release,
-octopus.com/blog/stop-using-branches-deploying-different-gitops-environments,
-beyond.minimumcd.org/docs/reference/practices/immutable-artifacts,
-devblogs.microsoft.com/devops/release-flow-how-we-do-branching-on-the-vsts-team,
-chromium.googlesource.com/chromium/src/+/master/docs/process/release_cycle.md,
-wiki.mozilla.org/Release_Management/Release_Process,
-github.blog/engineering/engineering-principles/deploying-branches-to-github-com,
-shopify.engineering/successfully-merging-work-1000-developers.
-
-## 6. Recommended strategy
-
-### 6.1 Principles
-
-- **P1. One eternal branch.** main is the single integration branch and the
-  nightly channel. Its semantics are a locked contract: nightly releases,
-  npm type publishing, cloud build dispatch, CI triggers, and community
-  tooling all key off it.
-- **P2. Build once, promote artifacts.** Every merge to main produces one
-  SHA-keyed artifact. Environments receive that artifact by pointer; nothing
-  is ever rebuilt per environment. The artifact that passes staging and canary
-  is byte-identical to the artifact in production.
-- **P3. Upstream first, always.** Every fix lands on main first, with tests.
-  Release lines receive changes only via the backport pipeline. Direct commits
-  to `core/*` and `cloud/*` are blocked for humans (release automation
-  excepted). This is the rule that prevents the PP2 class.
-- **P4. Branches only where a version demands one.** A long-lived branch
-  exists only to serve a pinned, shipped version (`core/x.y` while ComfyUI
-  pins it). No branch exists to represent an environment.
-- **P5. Invariants over notifications.** Every policy in this document that
-  matters is enforced by a required check or a reconciling audit with
-  heartbeat alerting, not by a bot that posts a message. PP4 is the reason.
-- **P6. Gates are automation-first, with at most one named human approval per
-  surface,** held by the existing release rotation. No new role hierarchy.
-- **P7. Small batches on a fixed cadence.** The unit of release stays as small
-  as the gates allow. The 401-PR batch is the documented anti-goal.
-
-### 6.2 Branch roles
-
-| Branch | Lifetime | Purpose | Who writes to it |
-| --- | --- | --- | --- |
-| `main` | Eternal | Integration, nightly channel, source of all builds | Engineers via peer-approved PRs |
-| `core/x.y` | Weeks; dies when the ComfyUI pin moves off x.y | Serve the pinned PyPI line | Backport automation and release bumps only |
-| `cloud/x.y` | Interim only; retired per 6.10 | Cloud release train until cloud CD lands | Backport automation only |
-| `feature/*`, `fix/*` | Days | Topic branches off main (or a last-green tag when main is red) | The author |
-| Prod pointer ref (`deployed/cloud-prod`) | Eternal, machine-written | Mirrors the verified deployed SHA after every prod sync, rollbacks included | Deploy pipeline only |
-
-Target state, Phase 2 and later (until the cloud branch retirement in 6.10
-lands, the cloud leg still promotes from the interim cloud/x.y line):
-
-```mermaid
-flowchart LR
-    ENG[Engineer merges PR to main] --> BUILD[One artifact built per SHA]
-    BUILD --> NIGHT[Nightly tag and release]
-    BUILD --> TC[testcloud] --> SC[staging] --> CAN[Canary percent rollout] --> PROD[Cloud prod]
-    PROD --> PTR[Prod pointer ref advances]
-    ENG --> GATE[Overnight release gate CI] --> TAGS[Last-green stable tag]
-    TAGS -->|next minor cut| LINE[core release line, backports only] --> TRAIN[Biweekly core train: patch bump, PyPI, pin PR]
-```
-
-### 6.3 The two release axes, explicitly separated
-
-- **Cloud axis (continuous):** main to testcloud to staging to prod is
-  artifact promotion through pipeline stages. Gates live in the pipeline: the
-  overnight release-gate suite for candidate selection, a staging smoke
-  checklist with named QA criteria, and canary metrics with automatic
-  rollback once the canary program lands. Incomplete features land on main
-  dark behind feature flags so the trunk stays releasable while work is in
-  progress. No environment branches.
-- **Core axis (versioned):** `core/x.y` branches exist because an exact
-  version is pinned by another product and shipped to desktops. They are cut
-  automatically (as today; in the target state the cut is taken from the
-  newest last-green tag rather than the raw pre-bump commit), receive fixes
-  only via upstream-first backports, and are retired when the pin moves. The fix for PP1 is not a new topology;
-  it is shortening how long these lines live and how far they drift (6.8).
-
-### 6.4 Promotion gates
-
-Implemented as GitHub Environments deployment protection rules (required
-reviewers plus deployment history), not as branch merges. This natively
-provides the audit trail that is the one legitimate case for human-gated
-promotion, and it is the same primitive the draft's release-manager gates
-actually wanted.
-
-| Gate | Trigger | Automated criteria | Human |
-| --- | --- | --- | --- |
-| PR into main | Every PR | Unit, component, lint, typecheck | One peer approval |
-| Release-gate verdict | Nightly | Behavioral suite, critical-path browser tests, custom-node harness when live | None; red verdict is an incident |
-| Staging promotion | On green candidate | Artifact exists, gate verdict green | None (auto) |
-| Prod promotion | Sheriff action | Staging smoke checklist green | One: rotation owner |
-| Core GA train | Biweekly schedule | Line is green, soak or harness criteria met | One: pin PR merge in ComfyUI |
-
-QA's slot (K8): the staging smoke checklist and the release regression scope
-are standing documents with named QA owners and defined entry and exit
-criteria, replacing hand-built per-release plans (PP9).
-
-### 6.5 Production visibility (adopts K1)
-
-A machine-maintained ref, `deployed/cloud-prod`, is written by the deploy
-pipeline only after the production sync reports healthy, and it mirrors the
-deployed SHA in both directions: a verified rollback moves the ref backward
-to the rolled-back SHA (a recorded, non-fast-forward move with the rollback
-reason logged, which the reconciler treats as healthy), so the ref never lies
-about production during an incident. A reconciling check compares the ref against the cloud repo's
-deployed SHA on every deploy and alerts on mismatch (P5). Answering "what is on prod" becomes
-`git log deployed/cloud-prod`, which is the legitimate requirement behind the
-draft's main-equals-prod rule, delivered without merge ceremony and immune to
-the F2 impossibility.
-
-### 6.6 Freeze-as-code (adopts K2)
-
-Freeze state is a first-class marker (a repo variable or protected file) that
-release automation checks before acting: the minor-bump dispatch refuses to
-cut past a frozen line, and backport targeting warns on frozen targets. All
-release bots carry heartbeat alerts; silence is an incident. These are the
-premature-bump post-mortem action items, promoted into the strategy.
-
-### 6.7 Stable base for engineers (adopts K4)
-
-The nightly release-gate verdict stamps an immutable dated tag (for example
-`stable/2026-07-18`) on the newest commit that passed the full gate and
-advances a `stable/latest-green` branch-style ref to it. A moving ref, not a
-moving tag, on purpose: git clients do not force-update moved tags by
-default, so a moving tag would silently go stale locally. When main is red,
-engineers branch from the ref or the dated tag instead of a standing dev
-branch. Red main is itself an incident
-with a named owner, which is what actually keeps the trunk usable.
-
-### 6.8 Drift limits and content verification (adopts K6 and the containment idea)
-
-- **Drift SLO:** the pinned release line being older than 28 days, or the pin
-  sitting more than two minors behind main, pages the rotation owner and
-  forces a train decision. This is the WIP limit that the draft expressed as
-  "anything in testing ships this cycle," made enforceable. PP1's 69-day line
-  becomes structurally impossible to reach silently. A breach also blocks the
-  next minor cut until acknowledged. The SLO activates with a burn-in
-  exemption for the already-breached 1.45 line, and a breach that traces to
-  an unmerged ComfyUI pin PR escalates per risk R2 instead of paging the
-  rotation, because that lever is not frontend-side.
-- **Convergence invariant:** a scheduled check asserts every commit on a live
-  release line is an ancestor of main or arrived via the backport pipeline,
-  and that every prod-deployed SHA is reachable from a release line. Roughly
-  20 lines of CI; catches what three notification bots missed (PP2).
-- **Release-content verification:** before a train departs, an automated
-  check confirms every PR labeled for that line actually landed on it, and
-  posts the diff of intent versus content. FE-713 becomes a failing check
-  instead of a user report.
-
-### 6.9 Hotfix and rollback runbooks
-
-Interim topology (while cloud/x.y lines exist; after the 6.10 retirement the
-cloud leg promotes last-green artifacts from main instead):
-
-```mermaid
-flowchart TD
-    Q1{Where is the defect live?} -->|Nightly only| A1[Fix on main, ships next nightly]
-    Q1 -->|Cloud prod| A2[Fix on main with tests] --> A3[Backport label to the live cloud line] --> A4[Staging smoke on the patched artifact] --> A5[Prod promotion by rotation owner]
-    Q1 -->|Core GA or desktop| A6[Fix on main with tests] --> A7[Backport label to the pinned core line] --> A8[Patch release to PyPI] --> A9[Pin bump PR on ComfyUI]
-    Q1 -->|Deploy itself is bad, code is fine| R1[Rollback: repoint prod to previous SHA, no rebuild]
-```
-
-Rules: hotfixes never restart full UAT and never bundle unreleased content;
-validation scope is the affected area plus the standing smoke checklist. The
-sanctioned path must stay hours-scale (target: under 8 working hours from
-fix merged on main to prod promotion), because the org has already
-demonstrated that a slower sanctioned path manufactures shadow deploy surfaces
-(PP7). Rollback is always a pointer move, never a git revert of a promotion;
-revert is reserved for code defects on main with an explicit reland step.
-
-### 6.10 Cloud branch retirement (the end state for the cloud axis)
-
-`cloud/x.y` branches exist today because cloud deploys from a frozen line.
-Once the release-gate suite plus canary auto-rollback are proven (several
-clean ramps and at least one real auto-rollback in production), cloud promotes
-last-green artifacts from main directly and the cloud branch family retires.
-The cutover checklist must cover: release-branch creation stops cutting
-`cloud/<minor>` and rotating cloud labels, the cloud deploy tag workflow
-retires, build dispatch keys on main SHAs and promotion events, and testcloud
-repoints from the cloud line tip to last-green tags. Until then, cloud/x.y
-continues exactly as today; this document changes nothing about it yet.
-
-## 7. How this solves the current pain points
-
-| Pain point | Mechanism in this strategy | Status |
-| --- | --- | --- |
-| PP1 drift on long lines | Drift SLO (6.8) caps line age; shorter trains; upstream-first keeps lines fix-only | Mitigated; fully solved only if ComfyUI adopts pin bumps at train cadence (risk R2) |
-| PP2 missed per-PR backports | Release-content verification plus convergence invariant (6.8); whole-artifact promotion on cloud removes per-PR picks there entirely | Solved: becomes a failing check, and unrepresentable on the cloud axis post 6.10 |
-| PP3 giant QA batches | Fixed cadence with drift SLO forces small trains (P7); release-gate CI carries per-merge burden | Mitigated; batch size cannot silently grow past the SLO, and drops under 100 if the 13.1 decision moves the core train to weekly |
-| PP4 silent tooling failure | Invariants and reconciling audits with heartbeat alerts replace notification-only bots (P5); prerequisite fixes named in 8 | Mitigated; bots can still break, but silence itself now alarms |
-| PP5 verbal freezes | Freeze-as-code guards the bump and backport paths (6.6) | Solved: the premature-bump incident becomes mechanically impossible |
-| PP6 human bottleneck | One human gate per surface on the existing rotation; merge-on-green everywhere else; backport approval rules simplified by making automation the only writer to release lines | Mitigated; the rotation remains, its late-night surface shrinks |
-| PP7 latency invites bypasses | Hours-scale sanctioned hotfix lane (6.9); canary replaces calendar soak for cloud; core latency shrinks as the harness replaces the soak | Partially solved now, fully contingent on the custom-node harness (risk R1) |
-| PP8 unreadable release state | Prod pointer ref (6.5); unified tags; one strategy document | Solved |
-| PP9 ad hoc QA | Standing gate criteria with named QA owners (6.4) | Solved by process definition |
-| PP10 cross-team trust | Publish the delivery metrics (9) on a fixed cadence so progress is legible instead of argued | Mitigated; trust follows the numbers |
-
-The honest line on backports: this strategy does not eliminate them, because
-nothing can while another product pins an exact version. It makes them rare
-(drift SLO plus faster trains), safe (upstream-first plus content
-verification), and boring (automation is the only writer to release lines).
-The draft's promise was elimination; the achievable promise is a backport
-rate under 10 percent with no silent misses.
-
-## 8. Rollout plan
-
-Prerequisites (fix before anything else changes): repair the manual backport
-retry workflow (FE-1282), turn on the repo auto-merge setting and retire the
-cron workaround, add heartbeat alerts to every release bot, and correct the
-stale PyPI-attribution in docs/release-process.md so the runbook of record
-matches the actual workflows.
-
-- **Phase 0, immediately:** adopt this document; freeze-as-code; prod pointer
-  ref; drift SLO alerting; convergence invariant check; standing QA gate
-  criteria drafted (their operational acceptance is P1 item 9). No branch
-  topology changes at all.
-- **Phase 1, with the release gate:** overnight release-gate suite produces
-  last-green tags; stable tags become the engineer base and the cloud
-  candidate source; staging promotion goes automatic on green.
-- **Phase 2, with the canary:** percentage rollout with metric-gated
-  auto-ramp and auto-rollback on cloud prod; hotfix lane switches to
-  canary-validated promotion.
-- **Phase 3, retirement:** cloud/x.y family retires per 6.10. Core/x.y
-  remains, on shorter trains, as long as ComfyUI pins exact versions; the
-  calendar soak retires only when the custom-node harness is live, staffed,
-  and has held the escaped-regression guardrail flat for two full cycles.
-
-## 9. Goals and success metrics
-
-| Goal | Metric | Target | Horizon |
-| --- | --- | --- | --- |
-| Ship fast | PR merge to cloud prod | Under 48 hours median | Phase 2 |
-| Backports rare | Backported PRs / merged PRs | Under 10 percent | Phase 2 |
-| Lines stay young | Max live release-line age | Under 28 days | Phase 1 |
-| No silent misses | Escaped regressions from missed backports | Zero | Phase 0 |
-| Batches stay small | PRs per QA-certified release | Under 100 | Phase 2, after the 13.1 cadence decision |
-| Prod is legible | Time to answer "what is on prod" | One git command | Phase 0 |
-| No shadow deploys | Unowned one-off production surfaces | Zero new | Phase 0 |
-
-Leading indicators are the first three; report all seven on a fixed cadence in
-the cross-team channel (PP10).
-
-## 10. Non-goals
-
-- Renaming or repointing main. Its contract is locked (P1).
-- Eliminating release branches while ComfyUI pins exact frontend versions.
-  That coupling is a product decision owned elsewhere; this strategy minimizes
-  its cost rather than pretending it away.
-- Standing up new long-lived environments. Existing surfaces (testcloud,
-  staging, per-PR previews) cover every tier the draft wanted.
-- Changing ComfyUI core's own release process, cadence, or the soak policy it
-  requires; this document only defines what the frontend does on each axis.
-- Prescribing the backend or cloud repo's deployment architecture (per-service
-  delivery work proceeds independently).
-
-## 11. Requirements
-
-**P0 (the strategy is not adopted without these):**
-
-1. Freeze-as-code marker checked by version-bump and backport automation.
-   Acceptance: a bump dispatch against a frozen line fails with a clear error;
-   verified by test.
-2. Prod pointer ref written only by the deploy pipeline after verified sync,
-   with a reconciling audit. Acceptance: mismatch alarms within one deploy
-   cycle.
-3. Convergence invariant and release-content verification checks, with
-   heartbeat alerting. Acceptance: a deliberately mislabeled test PR is caught
-   before a train departs.
-4. Drift SLO alerting at 28 days of line age or two minors of pin divergence.
-   Acceptance: alert fires in a rehearsal against a stale line.
-5. Documented hotfix and rollback runbooks (6.9) with an hours-scale SLA.
-   Acceptance: one rehearsed hotfix per quarter meets the SLA.
-6. Prerequisite tooling fixes: FE-1282, auto-merge setting, bot heartbeats.
-   Acceptance: a manually dispatched backport retry succeeds end to end; a
-   backport PR merges via repo auto-merge with the cron workaround retired;
-   killing a release bot raises its heartbeat alert.
-
-**P1 (fast follows):**
-
-7. Overnight release-gate suite stamping last-green tags; red verdict is an
-   incident with a named owner. Acceptance: a green run stamps the dated tag
-   within an hour; a red run opens an owned incident.
-8. Automatic staging promotion on green; GitHub Environments protection rules
-   with deployment history as the prod gate. Acceptance: a green candidate
-   reaches staging with zero human actions, and a prod promotion without the
-   required reviewer is blocked in rehearsal.
-9. Standing QA gate criteria with named owners replacing per-release plans.
-   Acceptance: the next release runs from the standing criteria with no
-   bespoke test plan authored.
-
-**P2 (future, explicitly sequenced):**
-
-10. Canary with metric-gated auto-ramp and auto-rollback. Acceptance: one
-    production auto-rollback triggered by canary metrics in a game day.
-11. cloud/x.y retirement per the 6.10 checklist. Acceptance: the cutover
-    checklist fully executed, verified by a workflow inventory showing no
-    half-dead machinery.
-12. Soak retirement gated on the custom-node harness guardrail. Acceptance:
-    the harness holds the escaped-regression guardrail flat for two full
-    cycles before any soak shortening.
-
-## 12. Risk register
-
-| ID | Risk | L | I | Level | Mitigation | Owner |
-| --- | --- | --- | --- | --- | --- | --- |
-| R1 | Custom-node harness stays unstaffed, so soak cannot shrink and core latency persists | High | High | Critical | Escalate staffing as the single gating dependency of the whole program; do not shorten the soak before the harness holds the guardrail | Eng leadership |
-| R2 | ComfyUI pin adoption lags frontend trains, so drift SLO breaches are unresolvable frontend-side | High | High | Critical | Agree a pin-adoption SLA with core release stakeholders; SLO breaches tracing to an unmerged pin PR escalate to leadership instead of paging the rotation | FE eng manager with core stakeholders |
-| R3 | Canary program slips; cloud branches linger in a half-retired state | Med | High | High | Retirement is the last step with explicit cutover criteria; interim state is exactly today's process | Release pipeline owner |
-| R4 | Prod pointer or invariant checks silently break, recreating PP4 | Med | High | High | Heartbeat alerts plus reconciliation against the deploy system on every run; silence pages | DevOps |
-| R5 | Drift SLO is ignored under deadline pressure | Med | Med | Medium | SLO breach pages the rotation and blocks the next minor cut until acknowledged | Rotation owner |
-| R6 | Incremental rollout gives no visible "fixed" moment; cross-team pressure continues | Med | Med | Medium | Publish the section 9 metrics on a fixed cadence; make progress legible | FE eng manager |
-| R7 | Flag debt accumulates as flags gate incomplete work on trunk | Med | Low | Low | Review-for-deletion date on every flag; monthly cleanup | FE leads |
-
-Doing nothing carries its own critical risks (drift compounds, the next
-missed backport ships another regression, rotation burnout continues); the
-status quo is not the safe option.
-
-## 13. Open questions
-
-1. Cadence of the core train once the drift SLO lands: stay biweekly or move
-   to weekly? At current velocity the under-100 batch target in section 9 is
-   reachable only with weekly trains, so this question blocks that one
-   metric's horizon. (Rotation owner plus core release stakeholders; blocking
-   for the batch-size target, non-blocking for everything else.)
-2. Should the prod pointer cover core GA and desktop as refs too
-   (`deployed/core-ga`), or is PyPI plus the pin authoritative enough?
-   (Frontend leads; non-blocking.)
-3. Who owns the standing QA gate criteria documents long-term as QA staffing
-   changes? (QA plus FE eng manager; blocking for Phase 0 sign-off.)
-4. Does the org-admin limitation on separate go-live approvers (surfaced
-   during FE-1176) need resolution before GitHub Environments become the prod
-   gate? (DevOps plus org admins; blocking for P1 item 8.)
-
-## 14. References
-
-Internal: `docs/release-process.md` (the operational runbook of record,
-updated as phases land); the shipping-speed initiative and its release-gate
-and canary design docs; the release rotation runbook; the
-premature-version-bump post-mortem; FE-713, FE-1176, FE-1282, FE-602/BE-800;
-the draft 4-tier proposal this document reviews.
-
-External: see section 5 source list.

TROUBLESHOOTING.md

@@ -7,7 +7,7 @@ This guide helps you resolve common issues when developing ComfyUI Frontend.
 ```mermaid
 flowchart TD
     A[Having Issues?] --> B{What's the problem?}
-    B -->|Dev server stuck| C[pnpm dev hangs]
+    B -->|Dev server stuck| C[nx serve hangs]
     B -->|Build errors| D[Check build issues]
     B -->|Lint errors| Q[Check linting issues]
     B -->|Dependency issues| E[Package problems]
@@ -23,7 +23,7 @@ flowchart TD
     G -->|No| H[Run: pnpm i]
     G -->|Still stuck| I[Run: pnpm clean]
     I --> J{Still stuck?}
-    J -->|Yes| K[Nuclear option:<br/>pnpm clean:all<br/>&& pnpm i]
+    J -->|Yes| K[Nuclear option:<br/>pnpm dlx rimraf node_modules<br/>&& pnpm i]
     J -->|No| L[Fixed!]
     H --> L
 
@@ -41,11 +41,11 @@ flowchart TD
 
 ### Development Server Issues
 
-#### Q: `pnpm dev` gets stuck and won't start
+#### Q: `pnpm dev` or `nx serve` gets stuck and won't start
 
 **Symptoms:**
 
-- Command hangs during Vite startup
+- Command hangs on "nx serve"
 - Dev server doesn't respond
 - Terminal appears frozen
 
@@ -65,7 +65,7 @@ flowchart TD
 
 3. **Last resort - Full node_modules reset:**
    ```bash
-   pnpm clean:all && pnpm i
+   pnpm dlx rimraf node_modules && pnpm i
    ```
 
 **Why this happens:**
@@ -73,7 +73,7 @@ flowchart TD
 - Corrupted dependency cache
 - Outdated lock files after branch switching
 - Incomplete previous installations
-- stale local build cache
+- NX cache corruption
 
 ---
 

apps/desktop-ui/package.json

@@ -3,19 +3,14 @@
   "version": "0.0.6",
   "type": "module",
   "scripts": {
-    "dev": "pnpm -w exec vite --config apps/desktop-ui/vite.config.mts",
-    "build": "pnpm -w exec vite build --config apps/desktop-ui/vite.config.mts",
-    "preview": "pnpm -w exec vite preview --config apps/desktop-ui/vite.config.mts",
-    "lint": "eslint src --cache",
-    "typecheck": "vue-tsc --noEmit -p tsconfig.json",
-    "test:unit": "vitest run --config vitest.config.mts",
+    "lint": "nx run @comfyorg/desktop-ui:lint",
+    "typecheck": "nx run @comfyorg/desktop-ui:typecheck",
     "storybook": "storybook dev -p 6007",
     "build-storybook": "storybook build -o dist/storybook"
   },
   "dependencies": {
     "@comfyorg/comfyui-electron-types": "catalog:",
     "@comfyorg/shared-frontend-utils": "workspace:*",
-    "@comfyorg/tailwind-utils": "workspace:*",
     "@primevue/core": "catalog:",
     "@primevue/themes": "catalog:",
     "@vueuse/core": "catalog:",
@@ -36,5 +31,88 @@
     "vite-plugin-html": "catalog:",
     "vite-plugin-vue-devtools": "catalog:",
     "vue-tsc": "catalog:"
+  },
+  "nx": {
+    "tags": [
+      "scope:desktop",
+      "type:app"
+    ],
+    "targets": {
+      "dev": {
+        "executor": "nx:run-commands",
+        "continuous": true,
+        "options": {
+          "cwd": "apps/desktop-ui",
+          "command": "vite --config vite.config.mts"
+        }
+      },
+      "serve": {
+        "executor": "nx:run-commands",
+        "continuous": true,
+        "options": {
+          "cwd": "apps/desktop-ui",
+          "command": "vite --config vite.config.mts"
+        }
+      },
+      "build": {
+        "executor": "nx:run-commands",
+        "cache": true,
+        "dependsOn": [
+          "^build"
+        ],
+        "options": {
+          "command": "vite build --config apps/desktop-ui/vite.config.mts"
+        },
+        "outputs": [
+          "{projectRoot}/dist"
+        ]
+      },
+      "preview": {
+        "executor": "nx:run-commands",
+        "continuous": true,
+        "dependsOn": [
+          "build"
+        ],
+        "options": {
+          "cwd": "apps/desktop-ui",
+          "command": "vite preview --config vite.config.mts"
+        }
+      },
+      "storybook": {
+        "executor": "nx:run-commands",
+        "continuous": true,
+        "options": {
+          "cwd": "apps/desktop-ui",
+          "command": "storybook dev -p 6007"
+        }
+      },
+      "build-storybook": {
+        "executor": "nx:run-commands",
+        "cache": true,
+        "options": {
+          "cwd": "apps/desktop-ui",
+          "command": "storybook build -o dist/storybook"
+        },
+        "outputs": [
+          "{projectRoot}/dist/storybook"
+        ]
+      },
+      "lint": {
+        "executor": "nx:run-commands",
+        "cache": true,
+        "options": {
+          "cwd": "apps/desktop-ui",
+          "command": "eslint src --cache"
+        }
+      },
+      "typecheck": {
+        "executor": "nx:run-commands",
+        "cache": true,
+        "options": {
+          "cwd": "apps/desktop-ui",
+          "command": "vue-tsc --noEmit -p tsconfig.json"
+        }
+      }
+    }
   }
 }

apps/desktop-ui/src/assets/css/style.css

@@ -20,15 +20,15 @@
 }
 
 .p-button-danger {
-  background-color: var(--color-coral-700);
+  background-color: var(--color-coral-red-600);
 }
 
 .p-button-danger:hover {
-  background-color: var(--color-coral-600);
+  background-color: var(--color-coral-red-500);
 }
 
 .p-button-danger:active {
-  background-color: var(--color-coral-500);
+  background-color: var(--color-coral-red-400);
 }
 
 .task-div .p-card {

apps/desktop-ui/src/components/bottomPanel/tabs/terminal/BaseTerminal.vue

@@ -32,7 +32,7 @@ import { useI18n } from 'vue-i18n'
 
 import { useTerminal } from '@/composables/bottomPanelTabs/useTerminal'
 import { electronAPI, isElectron } from '@/utils/envUtil'
-import { cn } from '@comfyorg/tailwind-utils'
+import { cn } from '@/utils/tailwindUtil'
 
 const { t } = useI18n()
 

apps/desktop-ui/src/components/common/StartupDisplay.test.ts

@@ -1,97 +0,0 @@
-import { render, screen } from '@testing-library/vue'
-import PrimeVue from 'primevue/config'
-import { describe, expect, it } from 'vitest'
-import { createI18n } from 'vue-i18n'
-
-import StartupDisplay from '@/components/common/StartupDisplay.vue'
-
-const i18n = createI18n({
-  legacy: false,
-  locale: 'en',
-  messages: { en: { g: { logoAlt: 'ComfyUI' } } }
-})
-
-const ProgressBarStub = {
-  props: ['mode', 'value', 'showValue'],
-  template:
-    '<div data-testid="progress-bar" :data-mode="mode" :data-value="value" />'
-}
-
-function renderDisplay(
-  props: {
-    progressPercentage?: number
-    title?: string
-    statusText?: string
-    hideProgress?: boolean
-    fullScreen?: boolean
-  } = {}
-) {
-  return render(StartupDisplay, {
-    props,
-    global: {
-      plugins: [[PrimeVue, { unstyled: true }], i18n],
-      stubs: { ProgressBar: ProgressBarStub }
-    }
-  })
-}
-
-describe('StartupDisplay', () => {
-  describe('progressMode', () => {
-    it('renders indeterminate mode when progressPercentage is undefined', () => {
-      renderDisplay()
-      expect(screen.getByTestId('progress-bar').dataset.mode).toBe(
-        'indeterminate'
-      )
-    })
-
-    it('renders determinate mode when progressPercentage is provided', () => {
-      renderDisplay({ progressPercentage: 50 })
-      expect(screen.getByTestId('progress-bar').dataset.mode).toBe(
-        'determinate'
-      )
-    })
-
-    it('passes progressPercentage as value to the progress bar', () => {
-      renderDisplay({ progressPercentage: 75 })
-      expect(screen.getByTestId('progress-bar').dataset.value).toBe('75')
-    })
-  })
-
-  describe('hideProgress', () => {
-    it('hides the progress bar when hideProgress is true', () => {
-      renderDisplay({ hideProgress: true })
-      expect(screen.queryByTestId('progress-bar')).toBeNull()
-    })
-
-    it('shows the progress bar by default', () => {
-      renderDisplay()
-      expect(screen.getByTestId('progress-bar')).toBeDefined()
-    })
-  })
-
-  describe('title', () => {
-    it('renders the title text when provided', () => {
-      renderDisplay({ title: 'Loading...' })
-      expect(screen.getByText('Loading...')).toBeDefined()
-    })
-
-    it('does not render h1 when title is not provided', () => {
-      renderDisplay()
-      expect(screen.queryByRole('heading', { level: 1 })).toBeNull()
-    })
-  })
-
-  describe('statusText', () => {
-    it('renders statusText with data-testid attribute', () => {
-      renderDisplay({ statusText: 'Starting server' })
-      expect(screen.getByTestId('startup-status-text').textContent).toContain(
-        'Starting server'
-      )
-    })
-
-    it('does not render statusText element when not provided', () => {
-      renderDisplay()
-      expect(screen.queryByTestId('startup-status-text')).toBeNull()
-    })
-  })
-})

apps/desktop-ui/src/components/common/UrlInput.test.ts

@@ -1,208 +0,0 @@
-import { render, screen, waitFor } from '@testing-library/vue'
-import userEvent from '@testing-library/user-event'
-import PrimeVue from 'primevue/config'
-import { describe, expect, it, vi, beforeEach } from 'vitest'
-
-vi.mock('@comfyorg/shared-frontend-utils/networkUtil', () => ({
-  checkUrlReachable: vi.fn()
-}))
-
-import { checkUrlReachable } from '@comfyorg/shared-frontend-utils/networkUtil'
-import UrlInput from '@/components/common/UrlInput.vue'
-import { ValidationState } from '@/utils/validationUtil'
-
-const InputTextStub = {
-  props: ['modelValue', 'invalid'],
-  emits: ['update:modelValue', 'blur'],
-  template: `<input
-    data-testid="url-input"
-    :value="modelValue"
-    :data-invalid="invalid"
-    @input="$emit('update:modelValue', $event.target.value)"
-    @blur="$emit('blur')"
-  />`
-}
-
-const InputIconStub = {
-  template: '<span data-testid="input-icon" />'
-}
-
-const IconFieldStub = {
-  template: '<div><slot /></div>'
-}
-
-function renderUrlInput(
-  modelValue = '',
-  validateUrlFn?: (url: string) => Promise<boolean>
-) {
-  return render(UrlInput, {
-    props: { modelValue, ...(validateUrlFn ? { validateUrlFn } : {}) },
-    global: {
-      plugins: [[PrimeVue, { unstyled: true }]],
-      stubs: {
-        InputText: InputTextStub,
-        InputIcon: InputIconStub,
-        IconField: IconFieldStub
-      }
-    }
-  })
-}
-
-describe('UrlInput', () => {
-  beforeEach(() => {
-    vi.resetAllMocks()
-  })
-
-  describe('initial validation on mount', () => {
-    it('stays IDLE when modelValue is empty on mount', async () => {
-      renderUrlInput('')
-      await waitFor(() => {
-        expect(screen.getByTestId('url-input').dataset.invalid).toBe('false')
-      })
-    })
-
-    it('sets VALID state when modelValue is a reachable URL on mount', async () => {
-      vi.mocked(checkUrlReachable).mockResolvedValue(true)
-      renderUrlInput('https://example.com')
-      await waitFor(() => {
-        expect(screen.getByTestId('url-input').dataset.invalid).toBe('false')
-      })
-    })
-
-    it('sets INVALID state when URL is not reachable on mount', async () => {
-      vi.mocked(checkUrlReachable).mockResolvedValue(false)
-      renderUrlInput('https://unreachable.example')
-      await waitFor(() => {
-        expect(screen.getByTestId('url-input').dataset.invalid).toBe('true')
-      })
-    })
-  })
-
-  describe('input handling', () => {
-    it('resets validation state to IDLE on user input', async () => {
-      vi.mocked(checkUrlReachable).mockResolvedValue(false)
-      renderUrlInput('https://bad.example')
-
-      await waitFor(() => {
-        expect(screen.getByTestId('url-input').dataset.invalid).toBe('true')
-      })
-
-      const user = userEvent.setup()
-      await user.type(screen.getByTestId('url-input'), 'x')
-      expect(screen.getByTestId('url-input').dataset.invalid).toBe('false')
-    })
-
-    it('strips whitespace from typed input', async () => {
-      const onUpdate = vi.fn()
-      render(UrlInput, {
-        props: {
-          modelValue: '',
-          'onUpdate:modelValue': onUpdate
-        },
-        global: {
-          plugins: [[PrimeVue, { unstyled: true }]],
-          stubs: {
-            InputText: InputTextStub,
-            InputIcon: InputIconStub,
-            IconField: IconFieldStub
-          }
-        }
-      })
-
-      const user = userEvent.setup()
-      const input = screen.getByTestId('url-input')
-      await user.type(input, 'htt ps')
-      expect((input as HTMLInputElement).value).not.toContain(' ')
-    })
-  })
-
-  describe('blur handling', () => {
-    it('emits update:modelValue on blur', async () => {
-      const onUpdate = vi.fn()
-      render(UrlInput, {
-        props: {
-          modelValue: 'https://example.com',
-          'onUpdate:modelValue': onUpdate
-        },
-        global: {
-          plugins: [[PrimeVue, { unstyled: true }]],
-          stubs: {
-            InputText: InputTextStub,
-            InputIcon: InputIconStub,
-            IconField: IconFieldStub
-          }
-        }
-      })
-
-      const user = userEvent.setup()
-      await user.click(screen.getByTestId('url-input'))
-      await user.tab()
-
-      expect(onUpdate).toHaveBeenCalled()
-    })
-
-    it('normalizes URL on blur', async () => {
-      const onUpdate = vi.fn()
-      render(UrlInput, {
-        props: {
-          modelValue: 'https://example.com',
-          'onUpdate:modelValue': onUpdate
-        },
-        global: {
-          plugins: [[PrimeVue, { unstyled: true }]],
-          stubs: {
-            InputText: InputTextStub,
-            InputIcon: InputIconStub,
-            IconField: IconFieldStub
-          }
-        }
-      })
-
-      const user = userEvent.setup()
-      await user.click(screen.getByTestId('url-input'))
-      await user.tab()
-
-      const emittedUrl = onUpdate.mock.calls[0]?.[0]
-      expect(emittedUrl).toBe('https://example.com/')
-    })
-  })
-
-  describe('custom validateUrlFn', () => {
-    it('uses custom validateUrlFn when provided', async () => {
-      const customValidator = vi.fn().mockResolvedValue(true)
-      renderUrlInput('https://custom.example', customValidator)
-
-      await waitFor(() => {
-        expect(customValidator).toHaveBeenCalledWith('https://custom.example')
-      })
-
-      expect(checkUrlReachable).not.toHaveBeenCalled()
-    })
-  })
-
-  describe('state-change emission', () => {
-    it('emits state-change when validation state changes', async () => {
-      const onStateChange = vi.fn()
-      vi.mocked(checkUrlReachable).mockResolvedValue(true)
-
-      render(UrlInput, {
-        props: {
-          modelValue: 'https://example.com',
-          'onState-change': onStateChange
-        },
-        global: {
-          plugins: [[PrimeVue, { unstyled: true }]],
-          stubs: {
-            InputText: InputTextStub,
-            InputIcon: InputIconStub,
-            IconField: IconFieldStub
-          }
-        }
-      })
-
-      await waitFor(() => {
-        expect(onStateChange).toHaveBeenCalledWith(ValidationState.VALID)
-      })
-    })
-  })
-})

apps/desktop-ui/src/components/install/GpuPicker.test.ts

@@ -1,112 +0,0 @@
-import { render, screen } from '@testing-library/vue'
-import PrimeVue from 'primevue/config'
-import { describe, expect, it, vi } from 'vitest'
-import { createI18n } from 'vue-i18n'
-
-vi.mock('@/utils/envUtil', () => ({
-  electronAPI: vi.fn(() => ({
-    getPlatform: vi.fn().mockReturnValue('win32')
-  }))
-}))
-
-vi.mock('@/i18n', () => ({
-  t: (key: string) => key,
-  te: () => false,
-  st: (_key: string, fallback: string) => fallback
-}))
-
-import type { TorchDeviceType } from '@comfyorg/comfyui-electron-types'
-import GpuPicker from '@/components/install/GpuPicker.vue'
-
-const i18n = createI18n({
-  legacy: false,
-  locale: 'en',
-  missingWarn: false,
-  fallbackWarn: false,
-  messages: { en: {} }
-})
-
-const HardwareOptionStub = {
-  props: ['imagePath', 'placeholderText', 'subtitle', 'selected'],
-  emits: ['click'],
-  template:
-    '<button :data-testid="placeholderText" :data-selected="selected" @click="$emit(\'click\')" >{{ placeholderText }}</button>'
-}
-
-function renderPicker(device: TorchDeviceType | null = null) {
-  return render(GpuPicker, {
-    props: { device },
-    global: {
-      plugins: [[PrimeVue, { unstyled: true }], i18n],
-      stubs: {
-        HardwareOption: HardwareOptionStub,
-        Tag: {
-          props: ['value'],
-          template: '<span data-testid="recommended-tag">{{ value }}</span>'
-        }
-      }
-    }
-  })
-}
-
-describe('GpuPicker', () => {
-  describe('recommended badge', () => {
-    it('shows recommended badge for nvidia', () => {
-      renderPicker('nvidia')
-      expect(screen.getByTestId('recommended-tag')).toBeVisible()
-    })
-
-    it('shows recommended badge for amd', () => {
-      renderPicker('amd')
-      expect(screen.getByTestId('recommended-tag')).toBeVisible()
-    })
-
-    it('does not show recommended badge for cpu', () => {
-      renderPicker('cpu')
-      expect(screen.getByTestId('recommended-tag')).not.toBeVisible()
-    })
-
-    it('does not show recommended badge for unsupported', () => {
-      renderPicker('unsupported')
-      expect(screen.getByTestId('recommended-tag')).not.toBeVisible()
-    })
-
-    it('does not show recommended badge when no device is selected', () => {
-      renderPicker(null)
-      expect(screen.getByTestId('recommended-tag')).not.toBeVisible()
-    })
-  })
-
-  describe('selection state', () => {
-    it('marks nvidia as selected when device is nvidia', () => {
-      renderPicker('nvidia')
-      expect(screen.getByTestId('NVIDIA').dataset.selected).toBe('true')
-    })
-
-    it('marks cpu as selected when device is cpu', () => {
-      renderPicker('cpu')
-      expect(screen.getByTestId('CPU').dataset.selected).toBe('true')
-    })
-
-    it('marks unsupported as selected when device is unsupported', () => {
-      renderPicker('unsupported')
-      expect(screen.getByTestId('Manual Install').dataset.selected).toBe('true')
-    })
-
-    it('no option is selected when device is null', () => {
-      renderPicker(null)
-      expect(screen.getByTestId('CPU').dataset.selected).toBe('false')
-      expect(screen.getByTestId('NVIDIA').dataset.selected).toBe('false')
-    })
-  })
-
-  describe('gpu options on non-darwin platform', () => {
-    it('shows NVIDIA, AMD, CPU, and Manual Install options', () => {
-      renderPicker(null)
-      expect(screen.getByTestId('NVIDIA')).toBeDefined()
-      expect(screen.getByTestId('AMD')).toBeDefined()
-      expect(screen.getByTestId('CPU')).toBeDefined()
-      expect(screen.getByTestId('Manual Install')).toBeDefined()
-    })
-  })
-})

apps/desktop-ui/src/components/install/HardwareOption.vue

@@ -4,7 +4,7 @@
     <button
       :class="
         cn(
-          'hardware-option flex h-[190px] w-[170px] flex-col items-center rounded-3xl border-4 bg-neutral-900/70 p-5 transition-all duration-200',
+          'hardware-option w-[170px] h-[190px] p-5 flex flex-col items-center rounded-3xl transition-all duration-200 bg-neutral-900/70 border-4',
           selected ? 'border-solid border-brand-yellow' : 'border-transparent'
         )
       "
@@ -12,13 +12,13 @@
     >
       <!-- Icon/Logo Area - Rounded square container -->
       <div
-        class="icon-container flex h-[110px] w-[110px] shrink-0 items-center justify-center overflow-hidden rounded-2xl bg-neutral-800"
+        class="icon-container w-[110px] h-[110px] shrink-0 rounded-2xl bg-neutral-800 flex items-center justify-center overflow-hidden"
       >
         <img
           v-if="imagePath"
           :src="imagePath"
           :alt="placeholderText"
-          class="size-full object-cover"
+          class="w-full h-full object-cover"
           style="object-position: 57% center"
           draggable="false"
         />
@@ -28,7 +28,7 @@
       </div>
 
       <!-- Text Content -->
-      <div v-if="subtitle" class="mt-4 text-center">
+      <div v-if="subtitle" class="text-center mt-4">
         <div class="text-sm text-neutral-500">{{ subtitle }}</div>
       </div>
     </button>
@@ -36,7 +36,7 @@
 </template>
 
 <script setup lang="ts">
-import { cn } from '@comfyorg/tailwind-utils'
+import { cn } from '@/utils/tailwindUtil'
 
 interface Props {
   imagePath?: string

apps/desktop-ui/src/components/install/MigrationPicker.test.ts

@@ -1,223 +0,0 @@
-import { render, screen, waitFor } from '@testing-library/vue'
-import userEvent from '@testing-library/user-event'
-import PrimeVue from 'primevue/config'
-import { describe, expect, it, vi, beforeEach } from 'vitest'
-import { createI18n } from 'vue-i18n'
-
-const mockValidateComfyUISource = vi.fn()
-const mockShowDirectoryPicker = vi.fn()
-
-vi.mock('@/utils/envUtil', () => ({
-  electronAPI: vi.fn(() => ({
-    validateComfyUISource: mockValidateComfyUISource,
-    showDirectoryPicker: mockShowDirectoryPicker
-  }))
-}))
-
-import MigrationPicker from '@/components/install/MigrationPicker.vue'
-
-const i18n = createI18n({
-  legacy: false,
-  locale: 'en',
-  messages: {
-    en: {
-      install: {
-        migrationSourcePathDescription: 'Source path description',
-        migrationOptional: 'Migration is optional',
-        selectItemsToMigrate: 'Select items to migrate',
-        pathValidationFailed: 'Validation failed',
-        failedToSelectDirectory: 'Failed to select directory',
-        locationPicker: {
-          migrationPathPlaceholder: 'Enter path'
-        }
-      }
-    }
-  }
-})
-
-const InputTextStub = {
-  props: ['modelValue', 'invalid'],
-  emits: ['update:modelValue'],
-  template: `<input
-    data-testid="source-input"
-    :value="modelValue"
-    @input="$emit('update:modelValue', $event.target.value)"
-  />`
-}
-
-const CheckboxStub = {
-  props: ['modelValue', 'inputId', 'binary'],
-  emits: ['update:modelValue', 'click'],
-  template: `<input
-    type="checkbox"
-    :data-testid="'checkbox-' + inputId"
-    :checked="modelValue"
-    @change="$emit('update:modelValue', $event.target.checked)"
-    @click.stop="$emit('click')"
-  />`
-}
-
-function renderPicker(sourcePath = '', migrationItemIds: string[] = []) {
-  return render(MigrationPicker, {
-    props: { sourcePath, migrationItemIds },
-    global: {
-      plugins: [[PrimeVue, { unstyled: true }], i18n],
-      stubs: {
-        InputText: InputTextStub,
-        Checkbox: CheckboxStub,
-        Button: { template: '<button data-testid="browse-btn" />' },
-        Message: {
-          props: ['severity'],
-          template: '<div data-testid="error-msg"><slot /></div>'
-        }
-      }
-    }
-  })
-}
-
-describe('MigrationPicker', () => {
-  beforeEach(() => {
-    vi.resetAllMocks()
-  })
-
-  describe('isValidSource', () => {
-    it('hides migration options when source path is empty', () => {
-      renderPicker('')
-      expect(screen.queryByText('Select items to migrate')).toBeNull()
-    })
-
-    it('shows migration options when source path is valid', async () => {
-      mockValidateComfyUISource.mockResolvedValue({ isValid: true })
-      const { rerender } = renderPicker('')
-
-      await rerender({ sourcePath: '/valid/path' })
-      await waitFor(() => {
-        expect(screen.getByText('Select items to migrate')).toBeDefined()
-      })
-    })
-
-    it('shows optional message when no valid source', () => {
-      renderPicker('')
-      expect(screen.getByText('Migration is optional')).toBeDefined()
-    })
-  })
-
-  describe('validateSource', () => {
-    it('clears error when source path becomes empty', async () => {
-      mockValidateComfyUISource.mockResolvedValue({
-        isValid: false,
-        error: 'Not found'
-      })
-
-      const user = userEvent.setup()
-      renderPicker()
-
-      await user.type(screen.getByTestId('source-input'), '/bad/path')
-      await waitFor(() => {
-        expect(screen.getByTestId('error-msg')).toBeDefined()
-      })
-
-      await user.clear(screen.getByTestId('source-input'))
-      await waitFor(() => {
-        expect(screen.queryByTestId('error-msg')).toBeNull()
-      })
-    })
-
-    it('shows error message when validation fails', async () => {
-      mockValidateComfyUISource.mockResolvedValue({
-        isValid: false,
-        error: 'Path not found'
-      })
-
-      const user = userEvent.setup()
-      renderPicker()
-
-      await user.type(screen.getByTestId('source-input'), '/bad/path')
-      await waitFor(() => {
-        expect(screen.getByTestId('error-msg')).toBeDefined()
-      })
-    })
-
-    it('shows no error when validation passes', async () => {
-      mockValidateComfyUISource.mockResolvedValue({ isValid: true })
-
-      const user = userEvent.setup()
-      renderPicker()
-
-      await user.type(screen.getByTestId('source-input'), '/valid/path')
-      await waitFor(() => {
-        expect(screen.queryByTestId('error-msg')).toBeNull()
-      })
-    })
-  })
-
-  describe('migrationItemIds watchEffect', () => {
-    it('emits all item IDs by default (all items start selected)', async () => {
-      const onUpdate = vi.fn()
-      render(MigrationPicker, {
-        props: {
-          sourcePath: '',
-          migrationItemIds: [],
-          'onUpdate:migrationItemIds': onUpdate
-        },
-        global: {
-          plugins: [[PrimeVue, { unstyled: true }], i18n],
-          stubs: {
-            InputText: InputTextStub,
-            Checkbox: CheckboxStub,
-            Button: { template: '<button />' },
-            Message: { template: '<div />' }
-          }
-        }
-      })
-
-      await waitFor(() => {
-        expect(onUpdate).toHaveBeenCalled()
-        const emittedIds = onUpdate.mock.calls[0][0]
-        expect(Array.isArray(emittedIds)).toBe(true)
-        expect(emittedIds.length).toBeGreaterThan(0)
-      })
-    })
-  })
-
-  describe('browse path', () => {
-    it('opens directory picker on browse click', async () => {
-      mockShowDirectoryPicker.mockResolvedValue(null)
-      renderPicker()
-
-      const user = userEvent.setup()
-      await user.click(screen.getByTestId('browse-btn'))
-
-      expect(mockShowDirectoryPicker).toHaveBeenCalledOnce()
-    })
-
-    it('updates source path when directory is selected', async () => {
-      mockShowDirectoryPicker.mockResolvedValue('/selected/path')
-      mockValidateComfyUISource.mockResolvedValue({ isValid: true })
-
-      const onUpdate = vi.fn()
-      render(MigrationPicker, {
-        props: {
-          sourcePath: '',
-          'onUpdate:sourcePath': onUpdate
-        },
-        global: {
-          plugins: [[PrimeVue, { unstyled: true }], i18n],
-          stubs: {
-            InputText: InputTextStub,
-            Checkbox: CheckboxStub,
-            Button: { template: '<button data-testid="browse-btn" />' },
-            Message: { template: '<div />' }
-          }
-        }
-      })
-
-      const user = userEvent.setup()
-      await user.click(screen.getByTestId('browse-btn'))
-
-      await waitFor(() => {
-        expect(onUpdate).toHaveBeenCalledWith('/selected/path')
-      })
-    })
-  })
-})

apps/desktop-ui/src/components/maintenance/StatusTag.test.ts

@@ -1,85 +0,0 @@
-import { render, screen } from '@testing-library/vue'
-import PrimeVue from 'primevue/config'
-import { describe, expect, it, vi } from 'vitest'
-import { defineComponent } from 'vue'
-
-vi.mock('@/i18n', () => ({
-  t: (key: string) => key
-}))
-
-import StatusTag from '@/components/maintenance/StatusTag.vue'
-
-const TagStub = defineComponent({
-  name: 'Tag',
-  props: {
-    icon: String,
-    severity: String,
-    value: String
-  },
-  template: `<span data-testid="tag" :data-icon="icon" :data-severity="severity" :data-value="value">{{ value }}</span>`
-})
-
-function renderStatusTag(props: { error: boolean; refreshing?: boolean }) {
-  return render(StatusTag, {
-    props,
-    global: {
-      plugins: [[PrimeVue, { unstyled: true }]],
-      stubs: { Tag: TagStub }
-    }
-  })
-}
-
-describe('StatusTag', () => {
-  describe('refreshing state', () => {
-    it('shows info severity when refreshing', () => {
-      renderStatusTag({ error: false, refreshing: true })
-      expect(screen.getByTestId('tag').dataset.severity).toBe('info')
-    })
-
-    it('shows refreshing translation key when refreshing', () => {
-      renderStatusTag({ error: false, refreshing: true })
-      expect(screen.getByTestId('tag').dataset.value).toBe(
-        'maintenance.refreshing'
-      )
-    })
-
-    it('shows question icon when refreshing', () => {
-      renderStatusTag({ error: false, refreshing: true })
-      expect(screen.getByTestId('tag').dataset.icon).toBeDefined()
-    })
-  })
-
-  describe('error state', () => {
-    it('shows danger severity when error is true', () => {
-      renderStatusTag({ error: true })
-      expect(screen.getByTestId('tag').dataset.severity).toBe('danger')
-    })
-
-    it('shows error translation key when error is true', () => {
-      renderStatusTag({ error: true })
-      expect(screen.getByTestId('tag').dataset.value).toBe('g.error')
-    })
-  })
-
-  describe('OK state', () => {
-    it('shows success severity when not refreshing and not error', () => {
-      renderStatusTag({ error: false })
-      expect(screen.getByTestId('tag').dataset.severity).toBe('success')
-    })
-
-    it('shows OK translation key when not refreshing and not error', () => {
-      renderStatusTag({ error: false })
-      expect(screen.getByTestId('tag').dataset.value).toBe('maintenance.OK')
-    })
-  })
-
-  describe('precedence', () => {
-    it('shows refreshing state when both refreshing and error are true', () => {
-      renderStatusTag({ error: true, refreshing: true })
-      expect(screen.getByTestId('tag').dataset.severity).toBe('info')
-      expect(screen.getByTestId('tag').dataset.value).toBe(
-        'maintenance.refreshing'
-      )
-    })
-  })
-})

apps/desktop-ui/src/components/maintenance/TaskCard.test.ts

@@ -1,89 +0,0 @@
-import { render, screen } from '@testing-library/vue'
-import PrimeVue from 'primevue/config'
-import { describe, expect, it, vi } from 'vitest'
-vi.mock('@/utils/envUtil', () => ({
-  electronAPI: vi.fn(() => ({
-    Validation: { validateInstallation: vi.fn() }
-  }))
-}))
-
-vi.mock('@/constants/desktopMaintenanceTasks', () => ({
-  DESKTOP_MAINTENANCE_TASKS: []
-}))
-
-vi.mock('@/utils/refUtil', () => ({
-  useMinLoadingDurationRef: (source: { value: boolean }) => source
-}))
-
-const mockGetRunner = vi.fn()
-vi.mock('@/stores/maintenanceTaskStore', () => ({
-  useMaintenanceTaskStore: vi.fn(() => ({
-    getRunner: mockGetRunner
-  }))
-}))
-
-import type { MaintenanceTask } from '@/types/desktop/maintenanceTypes'
-import TaskCard from '@/components/maintenance/TaskCard.vue'
-
-const baseTask: MaintenanceTask = {
-  id: 'testTask',
-  name: 'Test Task',
-  shortDescription: 'Short description',
-  errorDescription: 'Error occurred',
-  execute: vi.fn().mockResolvedValue(true)
-}
-
-const cardStubs = {
-  Card: {
-    template: '<div data-testid="card"><slot name="content"></slot></div>'
-  },
-  Button: { template: '<button />' }
-}
-
-function renderCard(
-  state: 'OK' | 'error' | 'warning' | 'skipped',
-  task: MaintenanceTask = baseTask
-) {
-  mockGetRunner.mockReturnValue({
-    state,
-    executing: false,
-    refreshing: false,
-    resolved: false
-  })
-
-  return render(TaskCard, {
-    props: { task },
-    global: {
-      plugins: [[PrimeVue, { unstyled: true }]],
-      stubs: cardStubs
-    }
-  })
-}
-
-describe('TaskCard', () => {
-  describe('description computed', () => {
-    it('shows errorDescription when task state is error', () => {
-      renderCard('error')
-      expect(screen.getByText('Error occurred')).toBeDefined()
-    })
-
-    it('shows shortDescription when task state is OK', () => {
-      renderCard('OK')
-      expect(screen.getByText('Short description')).toBeDefined()
-    })
-
-    it('shows shortDescription when task state is warning', () => {
-      renderCard('warning')
-      expect(screen.getByText('Short description')).toBeDefined()
-    })
-
-    it('falls back to shortDescription when errorDescription is absent and state is error', () => {
-      const taskWithoutErrorDesc: MaintenanceTask = {
-        ...baseTask,
-        errorDescription: undefined
-      }
-      renderCard('error', taskWithoutErrorDesc)
-      expect(screen.getByText('Short description')).toBeDefined()
-    })
-  })
-})

apps/desktop-ui/src/components/maintenance/TaskCard.vue

@@ -64,7 +64,7 @@ import { computed } from 'vue'
 
 import { useMaintenanceTaskStore } from '@/stores/maintenanceTaskStore'
 import type { MaintenanceTask } from '@/types/desktop/maintenanceTypes'
-import { cn } from '@comfyorg/tailwind-utils'
+import { cn } from '@/utils/tailwindUtil'
 import { useMinLoadingDurationRef } from '@/utils/refUtil'
 
 const taskStore = useMaintenanceTaskStore()

apps/desktop-ui/src/components/maintenance/TaskListItem.test.ts

@@ -1,97 +0,0 @@
-import { render, screen } from '@testing-library/vue'
-import PrimeVue from 'primevue/config'
-import { describe, expect, it, vi } from 'vitest'
-
-vi.mock('@/utils/envUtil', () => ({
-  electronAPI: vi.fn(() => ({
-    Validation: { validateInstallation: vi.fn() }
-  }))
-}))
-
-vi.mock('@/constants/desktopMaintenanceTasks', () => ({
-  DESKTOP_MAINTENANCE_TASKS: []
-}))
-
-vi.mock('@/utils/refUtil', () => ({
-  useMinLoadingDurationRef: (source: { value: boolean }) => source
-}))
-
-vi.mock('@/i18n', () => ({
-  t: (key: string) => key
-}))
-
-const mockGetRunner = vi.fn()
-vi.mock('@/stores/maintenanceTaskStore', () => ({
-  useMaintenanceTaskStore: vi.fn(() => ({
-    getRunner: mockGetRunner
-  }))
-}))
-
-import type { MaintenanceTask } from '@/types/desktop/maintenanceTypes'
-import TaskListItem from '@/components/maintenance/TaskListItem.vue'
-
-const baseTask: MaintenanceTask = {
-  id: 'testTask',
-  name: 'Test Task',
-  button: { text: 'Fix', icon: 'pi pi-check' },
-  execute: vi.fn().mockResolvedValue(true)
-}
-
-const ButtonStub = {
-  props: ['severity', 'label', 'icon', 'loading'],
-  template:
-    '<button :data-severity="severity" :data-label="label" :data-testid="label ? \'action-button\' : \'icon-button\'" />'
-}
-
-function renderItem(state: 'OK' | 'error' | 'warning' | 'skipped') {
-  mockGetRunner.mockReturnValue({
-    state,
-    executing: false,
-    refreshing: false,
-    resolved: false
-  })
-
-  return render(TaskListItem, {
-    props: { task: baseTask },
-    global: {
-      plugins: [[PrimeVue, { unstyled: true }]],
-      stubs: {
-        Button: ButtonStub,
-        Popover: { template: '<div />' },
-        TaskListStatusIcon: { template: '<span />' }
-      }
-    }
-  })
-}
-
-describe('TaskListItem', () => {
-  describe('severity computed', () => {
-    it('uses primary severity for error state', () => {
-      renderItem('error')
-      expect(screen.getByTestId('action-button').dataset.severity).toBe(
-        'primary'
-      )
-    })
-
-    it('uses primary severity for warning state', () => {
-      renderItem('warning')
-      expect(screen.getByTestId('action-button').dataset.severity).toBe(
-        'primary'
-      )
-    })
-
-    it('uses secondary severity for OK state', () => {
-      renderItem('OK')
-      expect(screen.getByTestId('action-button').dataset.severity).toBe(
-        'secondary'
-      )
-    })
-
-    it('uses secondary severity for skipped state', () => {
-      renderItem('skipped')
-      expect(screen.getByTestId('action-button').dataset.severity).toBe(
-        'secondary'
-      )
-    })
-  })
-})

apps/desktop-ui/src/components/maintenance/TaskListItem.vue

@@ -1,12 +1,12 @@
 <template>
   <tr
-    class="border-y border-solid border-neutral-700"
+    class="border-neutral-700 border-solid border-y"
     :class="{
       'opacity-50': runner.resolved,
       'opacity-75': isLoading && runner.resolved
     }"
   >
-    <td class="w-16 text-center">
+    <td class="text-center w-16">
       <TaskListStatusIcon :state="runner.state" :loading="isLoading" />
     </td>
     <td>
@@ -14,7 +14,7 @@
         {{ task.name }}
       </p>
       <Button
-        class="mx-2 inline-block"
+        class="inline-block mx-2"
         type="button"
         :icon="PrimeIcons.INFO_CIRCLE"
         severity="secondary"
@@ -22,11 +22,11 @@
         @click="toggle"
       />
 
-      <Popover ref="infoPopover" class="m-1 block max-w-64 min-w-32">
+      <Popover ref="infoPopover" class="block m-1 max-w-64 min-w-32">
         <span class="whitespace-pre-line">{{ task.description }}</span>
       </Popover>
     </td>
-    <td class="px-4 text-right">
+    <td class="text-right px-4">
       <Button
         :icon="task.button?.icon"
         :label="task.button?.text"

apps/desktop-ui/src/components/maintenance/TaskListPanel.vue

@@ -76,7 +76,7 @@ const executeTask = async (task: MaintenanceTask) => {
 
     message = t('maintenance.error.taskFailed')
   } catch (error) {
-    message = error instanceof Error ? error.message : undefined
+    message = (error as Error)?.message
   }
 
   toast.add({

apps/desktop-ui/src/components/maintenance/TaskListStatusIcon.test.ts

@@ -1,44 +0,0 @@
-import { render, screen } from '@testing-library/vue'
-import PrimeVue from 'primevue/config'
-import { describe, expect, it, vi } from 'vitest'
-
-vi.mock('@/i18n', () => ({
-  t: (key: string) => key
-}))
-
-import TaskListStatusIcon from '@/components/maintenance/TaskListStatusIcon.vue'
-
-type TaskState = 'warning' | 'error' | 'resolved' | 'OK' | 'skipped' | undefined
-
-function renderIcon(state: TaskState, loading?: boolean) {
-  return render(TaskListStatusIcon, {
-    props: { state, loading },
-    global: {
-      plugins: [[PrimeVue, { unstyled: true }]],
-      stubs: {
-        ProgressSpinner: {
-          template: '<div data-testid="spinner" />'
-        }
-      }
-    }
-  })
-}
-
-describe('TaskListStatusIcon', () => {
-  describe('loading / no state', () => {
-    it('renders spinner when state is undefined', () => {
-      renderIcon(undefined)
-      expect(screen.getByTestId('spinner')).toBeDefined()
-    })
-
-    it('renders spinner when loading is true', () => {
-      renderIcon('OK', true)
-      expect(screen.getByTestId('spinner')).toBeDefined()
-    })
-
-    it('hides spinner when state is defined and not loading', () => {
-      renderIcon('OK', false)
-      expect(screen.queryByTestId('spinner')).toBeNull()
-    })
-  })
-})

apps/desktop-ui/src/composables/bottomPanelTabs/useTerminal.test.ts

@@ -1,124 +0,0 @@
-import { beforeEach, describe, expect, it, vi } from 'vitest'
-import { ref } from 'vue'
-
-const { mockTerminal, MockTerminal, mockFitAddon, MockFitAddon } = vi.hoisted(
-  () => {
-    const mockTerminal = {
-      loadAddon: vi.fn(),
-      attachCustomKeyEventHandler: vi.fn(),
-      open: vi.fn(),
-      dispose: vi.fn(),
-      hasSelection: vi.fn<[], boolean>(),
-      resize: vi.fn(),
-      cols: 80,
-      rows: 24
-    }
-    const MockTerminal = vi.fn(function () {
-      return mockTerminal
-    })
-
-    const mockFitAddon = {
-      proposeDimensions: vi.fn().mockReturnValue({ cols: 80, rows: 24 })
-    }
-    const MockFitAddon = vi.fn(function () {
-      return mockFitAddon
-    })
-
-    return { mockTerminal, MockTerminal, mockFitAddon, MockFitAddon }
-  }
-)
-
-vi.mock('@xterm/xterm', () => ({ Terminal: MockTerminal }))
-vi.mock('@xterm/addon-fit', () => ({ FitAddon: MockFitAddon }))
-vi.mock('@xterm/xterm/css/xterm.css', () => ({}))
-
-import { withSetup } from '@/test/withSetup'
-import { useTerminal } from '@/composables/bottomPanelTabs/useTerminal'
-
-function getKeyHandler(): (event: KeyboardEvent) => boolean {
-  return mockTerminal.attachCustomKeyEventHandler.mock.calls[0][0]
-}
-
-describe('useTerminal key event handler', () => {
-  beforeEach(() => {
-    vi.clearAllMocks()
-    mockTerminal.hasSelection.mockReturnValue(false)
-
-    const element = ref<HTMLElement | undefined>(undefined)
-    withSetup(() => useTerminal(element))
-  })
-
-  it('allows browser to handle copy when text is selected (Ctrl+C)', () => {
-    mockTerminal.hasSelection.mockReturnValue(true)
-    const event = {
-      type: 'keydown',
-      ctrlKey: true,
-      metaKey: false,
-      key: 'c'
-    } as KeyboardEvent
-    expect(getKeyHandler()(event)).toBe(false)
-  })
-
-  it('allows browser to handle copy when text is selected (Meta+C)', () => {
-    mockTerminal.hasSelection.mockReturnValue(true)
-    const event = {
-      type: 'keydown',
-      ctrlKey: false,
-      metaKey: true,
-      key: 'c'
-    } as KeyboardEvent
-    expect(getKeyHandler()(event)).toBe(false)
-  })
-
-  it('does not pass copy to browser when no text is selected', () => {
-    mockTerminal.hasSelection.mockReturnValue(false)
-    const event = {
-      type: 'keydown',
-      ctrlKey: true,
-      metaKey: false,
-      key: 'c'
-    } as KeyboardEvent
-    expect(getKeyHandler()(event)).toBe(true)
-  })
-
-  it('allows browser to handle paste (Ctrl+V)', () => {
-    const event = {
-      type: 'keydown',
-      ctrlKey: true,
-      metaKey: false,
-      key: 'v'
-    } as KeyboardEvent
-    expect(getKeyHandler()(event)).toBe(false)
-  })
-
-  it('allows browser to handle paste (Meta+V)', () => {
-    const event = {
-      type: 'keydown',
-      ctrlKey: false,
-      metaKey: true,
-      key: 'v'
-    } as KeyboardEvent
-    expect(getKeyHandler()(event)).toBe(false)
-  })
-
-  it('does not intercept non-keydown events', () => {
-    mockTerminal.hasSelection.mockReturnValue(true)
-    const event = {
-      type: 'keyup',
-      ctrlKey: true,
-      metaKey: false,
-      key: 'c'
-    } as KeyboardEvent
-    expect(getKeyHandler()(event)).toBe(true)
-  })
-
-  it('passes through unrelated key combinations', () => {
-    const event = {
-      type: 'keydown',
-      ctrlKey: false,
-      metaKey: false,
-      key: 'Enter'
-    } as KeyboardEvent
-    expect(getKeyHandler()(event)).toBe(true)
-  })
-})

apps/desktop-ui/src/composables/bottomPanelTabs/useTerminalBuffer.test.ts

@@ -1,48 +0,0 @@
-import { beforeEach, describe, expect, it, vi } from 'vitest'
-
-const { mockSerialize, MockSerializeAddon } = vi.hoisted(() => {
-  const mockSerialize = vi.fn<[], string>()
-  const MockSerializeAddon = vi.fn(function () {
-    return { serialize: mockSerialize }
-  })
-  return { mockSerialize, MockSerializeAddon }
-})
-
-vi.mock('@xterm/xterm', () => ({
-  Terminal: vi.fn(function () {
-    return { loadAddon: vi.fn(), dispose: vi.fn(), write: vi.fn() }
-  })
-}))
-
-vi.mock('@xterm/addon-serialize', () => ({
-  SerializeAddon: MockSerializeAddon
-}))
-
-import type { Terminal } from '@xterm/xterm'
-import { withSetup } from '@/test/withSetup'
-import { useTerminalBuffer } from '@/composables/bottomPanelTabs/useTerminalBuffer'
-
-describe('useTerminalBuffer', () => {
-  beforeEach(() => {
-    vi.clearAllMocks()
-    mockSerialize.mockReturnValue('')
-  })
-
-  describe('copyTo', () => {
-    it('writes serialized buffer content to the destination terminal', () => {
-      mockSerialize.mockReturnValue('hello world')
-      const { copyTo } = withSetup(() => useTerminalBuffer())
-      const mockWrite = vi.fn()
-      copyTo({ write: mockWrite } as Pick<Terminal, 'write'>)
-      expect(mockWrite).toHaveBeenCalledWith('hello world')
-    })
-
-    it('writes empty string when buffer is empty', () => {
-      mockSerialize.mockReturnValue('')
-      const { copyTo } = withSetup(() => useTerminalBuffer())
-      const mockWrite = vi.fn()
-      copyTo({ write: mockWrite } as Pick<Terminal, 'write'>)
-      expect(mockWrite).toHaveBeenCalledWith('')
-    })
-  })
-})

apps/desktop-ui/src/constants/desktopDialogs.test.ts

@@ -1,50 +0,0 @@
-import { describe, expect, it } from 'vitest'
-
-import { DESKTOP_DIALOGS, getDialog } from '@/constants/desktopDialogs'
-
-describe('getDialog', () => {
-  it('returns the matching dialog for a valid ID', () => {
-    const result = getDialog('reinstallVenv')
-    expect(result.id).toBe('reinstallVenv')
-    expect(result.title).toBe(DESKTOP_DIALOGS.reinstallVenv.title)
-    expect(result.message).toBe(DESKTOP_DIALOGS.reinstallVenv.message)
-  })
-
-  it('returns invalidDialog for an unknown string ID', () => {
-    const result = getDialog('unknownDialog')
-    expect(result.id).toBe('invalidDialog')
-  })
-
-  it('returns invalidDialog when given an array of strings', () => {
-    const result = getDialog(['reinstallVenv', 'other'])
-    expect(result.id).toBe('invalidDialog')
-  })
-
-  it('returns invalidDialog for empty string', () => {
-    const result = getDialog('')
-    expect(result.id).toBe('invalidDialog')
-  })
-
-  it('returns a deep clone — mutations do not affect the original', () => {
-    const result = getDialog('reinstallVenv')
-    const originalFirstLabel = DESKTOP_DIALOGS.reinstallVenv.buttons[0].label
-    result.buttons[0].label = 'Mutated'
-    expect(DESKTOP_DIALOGS.reinstallVenv.buttons[0].label).toBe(
-      originalFirstLabel
-    )
-  })
-
-  it('every button has a returnValue', () => {
-    for (const id of Object.keys(DESKTOP_DIALOGS)) {
-      const result = getDialog(id)
-      for (const button of result.buttons) {
-        expect(button.returnValue).toBeDefined()
-      }
-    }
-  })
-
-  it('invalidDialog has a close/cancel button', () => {
-    const result = getDialog('invalidDialog')
-    expect(result.buttons.some((b) => b.action === 'cancel')).toBe(true)
-  })
-})

apps/desktop-ui/src/constants/desktopMaintenanceTasks.test.ts

@@ -1,75 +0,0 @@
-import { beforeEach, describe, expect, it, vi } from 'vitest'
-
-const { mockElectron } = vi.hoisted(() => ({
-  mockElectron: {
-    setBasePath: vi.fn(),
-    reinstall: vi.fn<[], Promise<void>>().mockResolvedValue(undefined),
-    uv: {
-      installRequirements: vi.fn<[], Promise<void>>(),
-      clearCache: vi.fn<[], Promise<void>>().mockResolvedValue(undefined),
-      resetVenv: vi.fn<[], Promise<void>>().mockResolvedValue(undefined)
-    }
-  }
-}))
-
-vi.mock('@/utils/envUtil', () => ({
-  electronAPI: vi.fn(() => mockElectron)
-}))
-
-import { DESKTOP_MAINTENANCE_TASKS } from '@/constants/desktopMaintenanceTasks'
-
-function findTask(id: string) {
-  const task = DESKTOP_MAINTENANCE_TASKS.find((t) => t.id === id)
-  if (!task) throw new Error(`Task not found: ${id}`)
-  return task
-}
-
-describe('desktopMaintenanceTasks', () => {
-  beforeEach(() => {
-    vi.resetAllMocks()
-    vi.spyOn(window, 'open').mockReturnValue(null)
-    mockElectron.reinstall.mockResolvedValue(undefined)
-    mockElectron.uv.clearCache.mockResolvedValue(undefined)
-    mockElectron.uv.resetVenv.mockResolvedValue(undefined)
-  })
-
-  describe('pythonPackages', () => {
-    it('returns true when installation succeeds', async () => {
-      mockElectron.uv.installRequirements.mockResolvedValue(undefined)
-      expect(await findTask('pythonPackages').execute()).toBe(true)
-    })
-
-    it('returns false when installation throws', async () => {
-      mockElectron.uv.installRequirements.mockRejectedValue(
-        new Error('install failed')
-      )
-      expect(await findTask('pythonPackages').execute()).toBe(false)
-    })
-  })
-
-  describe('URL-opening tasks', () => {
-    it('git execute opens the git download page', () => {
-      findTask('git').execute()
-      expect(window.open).toHaveBeenCalledWith(
-        'https://git-scm.com/downloads/',
-        '_blank'
-      )
-    })
-
-    it('uv execute opens the uv installation page', () => {
-      findTask('uv').execute()
-      expect(window.open).toHaveBeenCalledWith(
-        'https://docs.astral.sh/uv/getting-started/installation/',
-        '_blank'
-      )
-    })
-
-    it('vcRedist execute opens the VC++ redistributable download', () => {
-      findTask('vcRedist').execute()
-      expect(window.open).toHaveBeenCalledWith(
-        'https://aka.ms/vs/17/release/vc_redist.x64.exe',
-        '_blank'
-      )
-    })
-  })
-})

apps/desktop-ui/src/i18n.ts

@@ -9,7 +9,6 @@ import en from '@frontend-locales/en/main.json' with { type: 'json' }
 import enNodes from '@frontend-locales/en/nodeDefs.json' with { type: 'json' }
 
 import enSettings from '@frontend-locales/en/settings.json' with { type: 'json' }
-import { getDefaultLocale } from '@frontend-locales/localeConfig'
 import { createI18n } from 'vue-i18n'
 
 function buildLocale<
@@ -168,7 +167,7 @@ const messages: Record<string, LocaleMessages> = {
 export const i18n = createI18n({
   // Must set `false`, as Vue I18n Legacy API is for Vue 2
   legacy: false,
-  locale: getDefaultLocale(),
+  locale: navigator.language.split('-')[0] || 'en',
   fallbackLocale: 'en',
   messages,
   // Ignore warnings for locale options as each option is in its own language.

apps/desktop-ui/src/stores/maintenanceTaskStore.test.ts

@@ -1,288 +0,0 @@
-import { createTestingPinia } from '@pinia/testing'
-import type { InstallValidation } from '@comfyorg/comfyui-electron-types'
-import { setActivePinia } from 'pinia'
-import { beforeEach, describe, expect, it, vi } from 'vitest'
-
-const { mockElectron, testTasks } = vi.hoisted(() => {
-  const terminalTaskExecute = vi.fn().mockResolvedValue(true)
-  const basicTaskExecute = vi.fn().mockResolvedValue(true)
-
-  return {
-    mockElectron: {
-      Validation: {
-        validateInstallation: vi.fn()
-      }
-    },
-    testTasks: [
-      {
-        id: 'basicTask',
-        name: 'Basic Task',
-        execute: basicTaskExecute
-      },
-      {
-        id: 'terminalTask',
-        name: 'Terminal Task',
-        execute: terminalTaskExecute,
-        usesTerminal: true,
-        isInstallationFix: true
-      }
-    ]
-  }
-})
-
-vi.mock('@/utils/envUtil', () => ({
-  electronAPI: vi.fn(() => mockElectron)
-}))
-
-vi.mock('@/constants/desktopMaintenanceTasks', () => ({
-  DESKTOP_MAINTENANCE_TASKS: testTasks
-}))
-
-import { useMaintenanceTaskStore } from '@/stores/maintenanceTaskStore'
-import type { MaintenanceTask } from '@/types/desktop/maintenanceTypes'
-
-type PartialInstallValidation = Partial<InstallValidation> &
-  Record<string, unknown>
-
-function makeUpdate(
-  overrides: PartialInstallValidation = {}
-): InstallValidation {
-  return {
-    inProgress: false,
-    installState: 'installed',
-    ...overrides
-  } as InstallValidation
-}
-
-function createStore() {
-  setActivePinia(createTestingPinia({ stubActions: false }))
-  return useMaintenanceTaskStore()
-}
-
-describe('useMaintenanceTaskStore', () => {
-  let store: ReturnType<typeof useMaintenanceTaskStore>
-  const [basicTask, terminalTask] = testTasks as MaintenanceTask[]
-
-  beforeEach(() => {
-    vi.resetAllMocks()
-    store = createStore()
-  })
-
-  describe('processUpdate', () => {
-    it('sets isRefreshing to true during in-progress update', () => {
-      store.processUpdate(makeUpdate({ inProgress: true }))
-      expect(store.isRefreshing).toBe(true)
-    })
-
-    it('sets isRefreshing to false when update is complete', () => {
-      store.processUpdate(makeUpdate({ inProgress: false, basicTask: 'OK' }))
-      expect(store.isRefreshing).toBe(false)
-    })
-
-    it('updates runner state for tasks present in the final update', () => {
-      store.processUpdate(makeUpdate({ basicTask: 'error' }))
-      expect(store.getRunner(basicTask).state).toBe('error')
-    })
-
-    it('sets task state to warning from update', () => {
-      store.processUpdate(makeUpdate({ basicTask: 'warning' }))
-      expect(store.getRunner(basicTask).state).toBe('warning')
-    })
-
-    it('marks runners as refreshing when task id is absent from in-progress update', () => {
-      store.processUpdate(makeUpdate({ inProgress: true }))
-      expect(store.getRunner(basicTask).refreshing).toBe(true)
-    })
-
-    it('marks task as skipped when absent from final update', () => {
-      store.processUpdate(makeUpdate({ inProgress: false }))
-      expect(store.getRunner(basicTask).state).toBe('skipped')
-    })
-
-    it('clears refreshing flag after final update', () => {
-      store.processUpdate(makeUpdate({ inProgress: true }))
-      store.processUpdate(makeUpdate({ inProgress: false }))
-      expect(store.getRunner(basicTask).refreshing).toBe(false)
-    })
-
-    it('stores lastUpdate and exposes unsafeBasePath', () => {
-      store.processUpdate(makeUpdate({ unsafeBasePath: true }))
-      expect(store.unsafeBasePath).toBe(true)
-    })
-
-    it('exposes unsafeBasePathReason from the update', () => {
-      store.processUpdate(
-        makeUpdate({ unsafeBasePath: true, unsafeBasePathReason: 'oneDrive' })
-      )
-      expect(store.unsafeBasePathReason).toBe('oneDrive')
-    })
-  })
-
-  describe('anyErrors', () => {
-    it('returns true when any task has error state', () => {
-      store.processUpdate(makeUpdate({ basicTask: 'error' }))
-      expect(store.anyErrors).toBe(true)
-    })
-
-    it('returns false when all tasks are OK', () => {
-      store.processUpdate(makeUpdate({ basicTask: 'OK', terminalTask: 'OK' }))
-      expect(store.anyErrors).toBe(false)
-    })
-
-    it('returns false when all tasks are warning', () => {
-      store.processUpdate(
-        makeUpdate({ basicTask: 'warning', terminalTask: 'warning' })
-      )
-      expect(store.anyErrors).toBe(false)
-    })
-  })
-
-  describe('runner state transitions', () => {
-    it('marks runner as resolved when transitioning from error to OK', () => {
-      store.processUpdate(makeUpdate({ basicTask: 'error' }))
-      store.processUpdate(makeUpdate({ basicTask: 'OK' }))
-      expect(store.getRunner(basicTask).resolved).toBe(true)
-    })
-
-    it('does not mark resolved for warning to OK transition', () => {
-      store.processUpdate(makeUpdate({ basicTask: 'warning' }))
-      store.processUpdate(makeUpdate({ basicTask: 'OK' }))
-      expect(store.getRunner(basicTask).resolved).toBeFalsy()
-    })
-
-    it('clears resolved flag when task returns to error', () => {
-      store.processUpdate(makeUpdate({ basicTask: 'error' }))
-      store.processUpdate(makeUpdate({ basicTask: 'OK' }))
-      store.processUpdate(makeUpdate({ basicTask: 'error' }))
-      expect(store.getRunner(basicTask).resolved).toBeFalsy()
-    })
-  })
-
-  describe('clearResolved', () => {
-    it('clears resolved flags on all runners', () => {
-      store.processUpdate(makeUpdate({ basicTask: 'error' }))
-      store.processUpdate(makeUpdate({ basicTask: 'OK' }))
-      expect(store.getRunner(basicTask).resolved).toBe(true)
-
-      store.clearResolved()
-      expect(store.getRunner(basicTask).resolved).toBeFalsy()
-    })
-  })
-
-  describe('execute', () => {
-    it('returns true when task execution succeeds', async () => {
-      vi.mocked(basicTask.execute).mockResolvedValue(true)
-      const result = await store.execute(basicTask)
-      expect(result).toBe(true)
-    })
-
-    it('returns false when task execution fails', async () => {
-      vi.mocked(basicTask.execute).mockResolvedValue(false)
-      const result = await store.execute(basicTask)
-      expect(result).toBe(false)
-    })
-
-    it('calls refreshDesktopTasks after successful installation-fix task', async () => {
-      vi.mocked(terminalTask.execute).mockResolvedValue(true)
-      await store.execute(terminalTask)
-      expect(
-        mockElectron.Validation.validateInstallation
-      ).toHaveBeenCalledOnce()
-    })
-
-    it('does not call refreshDesktopTasks when task is not an installation fix', async () => {
-      vi.mocked(basicTask.execute).mockResolvedValue(true)
-      await store.execute(basicTask)
-      expect(
-        mockElectron.Validation.validateInstallation
-      ).not.toHaveBeenCalled()
-    })
-
-    it('does not call refreshDesktopTasks when installation-fix task fails', async () => {
-      vi.mocked(terminalTask.execute).mockResolvedValue(false)
-      await store.execute(terminalTask)
-      expect(
-        mockElectron.Validation.validateInstallation
-      ).not.toHaveBeenCalled()
-    })
-
-    it('sets runner executing to true during task execution', async () => {
-      let resolveTask!: (value: boolean) => void
-      vi.mocked(basicTask.execute).mockReturnValue(
-        new Promise<boolean>((resolve) => {
-          resolveTask = resolve
-        })
-      )
-
-      const executePromise = store.execute(basicTask)
-      expect(store.getRunner(basicTask).executing).toBe(true)
-
-      resolveTask(true)
-      await executePromise
-      expect(store.getRunner(basicTask).executing).toBe(false)
-    })
-
-    it('clears executing flag when task throws', async () => {
-      vi.mocked(basicTask.execute).mockRejectedValue(new Error('fail'))
-      await expect(store.execute(basicTask)).rejects.toThrow('fail')
-      expect(store.getRunner(basicTask).executing).toBe(false)
-    })
-
-    it('sets runner error message when task throws', async () => {
-      vi.mocked(basicTask.execute).mockRejectedValue(
-        new Error('something broke')
-      )
-      await expect(store.execute(basicTask)).rejects.toThrow()
-      expect(store.getRunner(basicTask).error).toBe('something broke')
-    })
-
-    it('clears runner error on successful execution', async () => {
-      vi.mocked(basicTask.execute).mockRejectedValue(new Error('fail'))
-      await expect(store.execute(basicTask)).rejects.toThrow()
-
-      vi.mocked(basicTask.execute).mockResolvedValue(true)
-      await store.execute(basicTask)
-      expect(store.getRunner(basicTask).error).toBeUndefined()
-    })
-  })
-
-  describe('isRunningTerminalCommand', () => {
-    it('returns true while a terminal task is executing', async () => {
-      let resolveTask!: (value: boolean) => void
-      vi.mocked(terminalTask.execute).mockReturnValue(
-        new Promise<boolean>((resolve) => {
-          resolveTask = resolve
-        })
-      )
-
-      const executePromise = store.execute(terminalTask)
-      expect(store.isRunningTerminalCommand).toBe(true)
-
-      resolveTask(true)
-      await executePromise
-      expect(store.isRunningTerminalCommand).toBe(false)
-    })
-
-    it('returns false when no terminal tasks are executing', () => {
-      expect(store.isRunningTerminalCommand).toBe(false)
-    })
-  })
-
-  describe('isRunningInstallationFix', () => {
-    it('returns true while an installation-fix task is executing', async () => {
-      let resolveTask!: (value: boolean) => void
-      vi.mocked(terminalTask.execute).mockReturnValue(
-        new Promise<boolean>((resolve) => {
-          resolveTask = resolve
-        })
-      )
-
-      const executePromise = store.execute(terminalTask)
-      expect(store.isRunningInstallationFix).toBe(true)
-
-      resolveTask(true)
-      await executePromise
-      expect(store.isRunningInstallationFix).toBe(false)
-    })
-  })
-})