[fix] some typescript issues in src/composables

.env_example

@@ -33,3 +33,4 @@ DISABLE_VUE_PLUGINS=false
 # Algolia credentials required for developing with the new custom node manager.
 ALGOLIA_APP_ID=4E0RO38HS8
 ALGOLIA_API_KEY=684d998c36b67a9a9fce8fc2d8860579
+

.github/workflows/backport.yaml

@@ -133,10 +133,11 @@ jobs:
         if: steps.check-existing.outputs.skip != 'true' && steps.backport.outputs.success
         env:
           GH_TOKEN: ${{ secrets.PR_GH_TOKEN }}
-          PR_TITLE: ${{ github.event.pull_request.title }}
-          PR_NUMBER: ${{ github.event.pull_request.number }}
-          PR_AUTHOR: ${{ github.event.pull_request.user.login }}
         run: |
+          PR_TITLE="${{ github.event.pull_request.title }}"
+          PR_NUMBER="${{ github.event.pull_request.number }}"
+          PR_AUTHOR="${{ github.event.pull_request.user.login }}"
+
           for backport in ${{ steps.backport.outputs.success }}; do
             IFS=':' read -r version branch <<< "${backport}"
 

.github/workflows/i18n.yaml

@@ -11,13 +11,7 @@ on:
 jobs:
   update-locales:
     # Branch detection: Only run for manual dispatch or version-bump-* branches from main repo
-    # add sno-fix-playwright-babel temporarily to fix playwright issue with babel
-    if: >
-      github.event_name == 'workflow_dispatch' || 
-      (github.event.pull_request.head.repo.full_name == github.repository && 
-       startsWith(github.head_ref, 'version-bump-')) || 
-      startsWith(github.head_ref, 'sno-fix-playwright-babel')
-
+    if: github.event_name == 'workflow_dispatch' || (github.event.pull_request.head.repo.full_name == github.repository && startsWith(github.head_ref, 'version-bump-'))
     runs-on: ubuntu-latest
     steps:
     - uses: Comfy-Org/ComfyUI_frontend_setup_action@v3

.gitignore

@@ -51,7 +51,6 @@ tests-ui/workflows/examples
 /blob-report/
 /playwright/.cache/
 browser_tests/**/*-win32.png
-browser-tests/local/
 
 .env
 

.storybook/preview-head.html

@@ -57,8 +57,9 @@
 
   /* Override Storybook's problematic & selector styles */
   /* Reset only the specific properties that Storybook injects */
-  li+li {
-    margin: 0;
-    padding: revert-layer;
+  #storybook-root li+li,
+  #storybook-docs li+li {
+    margin: inherit;
+    padding: inherit;
   }
 </style>

browser_tests/globalSetupWithI18n.ts

@@ -1,7 +0,0 @@
-import type { FullConfig } from '@playwright/test'
-
-import { preprocessLitegraph } from './i18nSetup'
-
-export default async function globalSetup(config: FullConfig) {
-  await preprocessLitegraph()
-}

browser_tests/globalTeardownWithI18n.ts

@@ -1,7 +0,0 @@
-import type { FullConfig } from '@playwright/test'
-
-import { restoreLitegraph } from './i18nSetup'
-
-export default async function globalTeardown(config: FullConfig) {
-  await restoreLitegraph()
-}

browser_tests/i18nSetup.ts

@@ -1,81 +0,0 @@
-/**
- * Setup for i18n collection tests
- * Handles preprocessing of litegraph files that contain TypeScript 'declare' keywords
- */
-import { promises as fs } from 'fs'
-import { glob } from 'glob'
-import * as path from 'path'
-import { fileURLToPath } from 'url'
-
-const __dirname = path.dirname(fileURLToPath(import.meta.url))
-const rootDir = path.resolve(__dirname, '..')
-const litegraphSrcDir = path.join(rootDir, 'src/lib/litegraph/src')
-
-const backupMap = new Map<string, string>()
-
-export async function preprocessLitegraph() {
-  console.log('Preprocessing litegraph files for i18n collection...')
-
-  // Search for all .ts files in litegraph src directory
-  const pattern = path.join(litegraphSrcDir, '**/*.ts')
-  const files = await glob(pattern, {
-    ignore: ['**/*.test.ts', '**/*.spec.ts', '**/node_modules/**']
-  })
-
-  let processedCount = 0
-
-  // Process files in parallel - read once and process if needed
-  await Promise.all(
-    files.map(async (filePath) => {
-      try {
-        const originalContent = await fs.readFile(filePath, 'utf-8')
-
-        // Check for class property declarations with 'declare' keyword
-        if (!/^\s*declare\s+/m.test(originalContent)) {
-          return // Skip files without declare keywords
-        }
-
-        // Store original content in memory
-        backupMap.set(filePath, originalContent)
-
-        // Remove 'declare' keyword from class properties
-        const modifiedContent = originalContent.replace(
-          /^(\s*)declare\s+/gm,
-          '$1// @ts-ignore - removed declare for Playwright\n$1'
-        )
-
-        // Write modified content
-        await fs.writeFile(filePath, modifiedContent)
-        console.log(`  ✓ Processed ${path.relative(litegraphSrcDir, filePath)}`)
-        processedCount++
-      } catch (error: unknown) {
-        console.warn(
-          `  ⚠ Could not preprocess file for litegraph ${filePath}: ${String((error as Error)?.message || error)}`
-        )
-      }
-    })
-  )
-
-  if (processedCount === 0) {
-    console.log('  ℹ No files with declare keywords found')
-  } else {
-    console.log(`  Processed ${processedCount} files with declare keywords`)
-  }
-}
-
-export async function restoreLitegraph() {
-  if (backupMap.size === 0) {
-    return
-  }
-
-  console.log('Restoring original litegraph files...')
-
-  await Promise.all(
-    Array.from(backupMap.entries()).map(async ([filePath, originalContent]) => {
-      await fs.writeFile(filePath, originalContent)
-      console.log(`  ✓ Restored ${path.relative(litegraphSrcDir, filePath)}`)
-    })
-  )
-
-  backupMap.clear()
-}

browser_tests/tests/dialog.spec.ts

@@ -36,10 +36,6 @@ test('Does not report warning on undo/redo', async ({ comfyPage }) => {
   await comfyPage.loadWorkflow('missing/missing_nodes')
   await comfyPage.closeDialog()
 
-  // Wait for any async operations to complete after dialog closes
-  await comfyPage.nextFrame()
-  await comfyPage.page.waitForTimeout(100)
-
   // Make a change to the graph
   await comfyPage.doubleClickCanvas()
   await comfyPage.searchBox.fillAndSelectFirstNode('KSampler')