fix: Missing .value led to the release dot always showing (#5500)

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@comfyorg/comfyui-frontend",
   "private": true,
-  "version": "1.26.13",
+  "version": "1.26.10",
   "type": "module",
   "repository": "https://github.com/Comfy-Org/ComfyUI_frontend",
   "homepage": "https://comfy.org",

src/components/dialog/content/LoadWorkflowWarning.vue

@@ -138,7 +138,7 @@ const allMissingNodesInstalled = computed(() => {
 })
 // Watch for completion and close dialog
 watch(allMissingNodesInstalled, async (allInstalled) => {
-  if (allInstalled && showInstallAllButton.value) {
+  if (allInstalled) {
     // Use nextTick to ensure state updates are complete
     await nextTick()
 

src/components/install/GpuPicker.vue

@@ -112,12 +112,16 @@
     </div>
 
     <div
-      class="transition-opacity flex gap-3 h-0 items-center"
+      class="transition-opacity flex gap-3 h-0"
       :class="{
         'opacity-40': selected && selected !== 'cpu'
       }"
     >
-      <ToggleSwitch v-model="cpuMode" input-id="cpu-mode" />
+      <ToggleSwitch
+        v-model="cpuMode"
+        input-id="cpu-mode"
+        class="-translate-y-40"
+      />
       <label for="cpu-mode" class="select-none">
         {{ $t('install.gpuSelection.enableCpuMode') }}
       </label>

src/composables/useManagerState.ts

@@ -42,12 +42,7 @@ export function useManagerState() {
       )
 
       // Check command line args first (highest priority)
-      // --enable-manager flag enables the manager (opposite of old --disable-manager)
-      const hasEnableManager =
-        systemStats.value?.system?.argv?.includes('--enable-manager')
-
-      // If --enable-manager is NOT present, manager is disabled
-      if (!hasEnableManager) {
+      if (systemStats.value?.system?.argv?.includes('--disable-manager')) {
         return ManagerUIState.DISABLED
       }
 

tests-ui/tests/composables/useManagerState.test.ts

@@ -56,10 +56,10 @@ describe('useManagerState', () => {
   })
 
   describe('managerUIState property', () => {
-    it('should return DISABLED state when --enable-manager is NOT present', () => {
+    it('should return DISABLED state when --disable-manager is present', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
         systemStats: ref({
-          system: { argv: ['python', 'main.py'] } // No --enable-manager flag
+          system: { argv: ['python', 'main.py', '--disable-manager'] }
         }),
         isInitialized: ref(true)
       } as any)
@@ -76,14 +76,7 @@ describe('useManagerState', () => {
     it('should return LEGACY_UI state when --enable-manager-legacy-ui is present', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
         systemStats: ref({
-          system: {
-            argv: [
-              'python',
-              'main.py',
-              '--enable-manager',
-              '--enable-manager-legacy-ui'
-            ]
-          } // Both flags needed
+          system: { argv: ['python', 'main.py', '--enable-manager-legacy-ui'] }
         }),
         isInitialized: ref(true)
       } as any)
@@ -99,9 +92,7 @@ describe('useManagerState', () => {
 
     it('should return NEW_UI state when client and server both support v4', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
-        systemStats: ref({
-          system: { argv: ['python', 'main.py', '--enable-manager'] }
-        }), // Need --enable-manager
+        systemStats: ref({ system: { argv: ['python', 'main.py'] } }),
         isInitialized: ref(true)
       } as any)
       vi.mocked(api.getClientFeatureFlags).mockReturnValue({
@@ -123,9 +114,7 @@ describe('useManagerState', () => {
 
     it('should return LEGACY_UI state when server supports v4 but client does not', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
-        systemStats: ref({
-          system: { argv: ['python', 'main.py', '--enable-manager'] }
-        }), // Need --enable-manager
+        systemStats: ref({ system: { argv: ['python', 'main.py'] } }),
         isInitialized: ref(true)
       } as any)
       vi.mocked(api.getClientFeatureFlags).mockReturnValue({
@@ -147,9 +136,7 @@ describe('useManagerState', () => {
 
     it('should return LEGACY_UI state when legacy manager extension exists', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
-        systemStats: ref({
-          system: { argv: ['python', 'main.py', '--enable-manager'] }
-        }), // Need --enable-manager
+        systemStats: ref({ system: { argv: ['python', 'main.py'] } }),
         isInitialized: ref(true)
       } as any)
       vi.mocked(api.getClientFeatureFlags).mockReturnValue({})
@@ -168,9 +155,7 @@ describe('useManagerState', () => {
 
     it('should return NEW_UI state when server feature flags are undefined', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
-        systemStats: ref({
-          system: { argv: ['python', 'main.py', '--enable-manager'] }
-        }), // Need --enable-manager
+        systemStats: ref({ system: { argv: ['python', 'main.py'] } }),
         isInitialized: ref(true)
       } as any)
       vi.mocked(api.getClientFeatureFlags).mockReturnValue({})
@@ -190,9 +175,7 @@ describe('useManagerState', () => {
 
     it('should return LEGACY_UI state when server does not support v4', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
-        systemStats: ref({
-          system: { argv: ['python', 'main.py', '--enable-manager'] }
-        }), // Need --enable-manager
+        systemStats: ref({ system: { argv: ['python', 'main.py'] } }),
         isInitialized: ref(true)
       } as any)
       vi.mocked(api.getClientFeatureFlags).mockReturnValue({})
@@ -229,17 +212,14 @@ describe('useManagerState', () => {
 
       const managerState = useManagerState()
 
-      // When systemStats is null, we can't check for --enable-manager flag, so manager is disabled
-      expect(managerState.managerUIState.value).toBe(ManagerUIState.DISABLED)
+      expect(managerState.managerUIState.value).toBe(ManagerUIState.NEW_UI)
     })
   })
 
   describe('helper properties', () => {
     it('isManagerEnabled should return true when state is not DISABLED', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
-        systemStats: ref({
-          system: { argv: ['python', 'main.py', '--enable-manager'] }
-        }), // Need --enable-manager
+        systemStats: ref({ system: { argv: ['python', 'main.py'] } }),
         isInitialized: ref(true)
       } as any)
       vi.mocked(api.getClientFeatureFlags).mockReturnValue({
@@ -257,7 +237,7 @@ describe('useManagerState', () => {
     it('isManagerEnabled should return false when state is DISABLED', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
         systemStats: ref({
-          system: { argv: ['python', 'main.py'] } // No --enable-manager flag means disabled
+          system: { argv: ['python', 'main.py', '--disable-manager'] }
         }),
         isInitialized: ref(true)
       } as any)
@@ -272,9 +252,7 @@ describe('useManagerState', () => {
 
     it('isNewManagerUI should return true when state is NEW_UI', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
-        systemStats: ref({
-          system: { argv: ['python', 'main.py', '--enable-manager'] }
-        }), // Need --enable-manager
+        systemStats: ref({ system: { argv: ['python', 'main.py'] } }),
         isInitialized: ref(true)
       } as any)
       vi.mocked(api.getClientFeatureFlags).mockReturnValue({
@@ -292,14 +270,7 @@ describe('useManagerState', () => {
     it('isLegacyManagerUI should return true when state is LEGACY_UI', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
         systemStats: ref({
-          system: {
-            argv: [
-              'python',
-              'main.py',
-              '--enable-manager',
-              '--enable-manager-legacy-ui'
-            ]
-          } // Both flags needed
+          system: { argv: ['python', 'main.py', '--enable-manager-legacy-ui'] }
         }),
         isInitialized: ref(true)
       } as any)
@@ -314,9 +285,7 @@ describe('useManagerState', () => {
 
     it('shouldShowInstallButton should return true only for NEW_UI', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
-        systemStats: ref({
-          system: { argv: ['python', 'main.py', '--enable-manager'] }
-        }), // Need --enable-manager
+        systemStats: ref({ system: { argv: ['python', 'main.py'] } }),
         isInitialized: ref(true)
       } as any)
       vi.mocked(api.getClientFeatureFlags).mockReturnValue({
@@ -333,9 +302,7 @@ describe('useManagerState', () => {
 
     it('shouldShowManagerButtons should return true when not DISABLED', () => {
       vi.mocked(useSystemStatsStore).mockReturnValue({
-        systemStats: ref({
-          system: { argv: ['python', 'main.py', '--enable-manager'] }
-        }), // Need --enable-manager
+        systemStats: ref({ system: { argv: ['python', 'main.py'] } }),
         isInitialized: ref(true)
       } as any)
       vi.mocked(api.getClientFeatureFlags).mockReturnValue({