Compare commits
25 Commits
v1.44.19
...
ecs-vue-ho
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
3a6fe052cd | ||
|
|
83263fd2ee | ||
|
|
581c5bb38e | ||
|
|
4d37194be6 | ||
|
|
5bb54de0d7 | ||
|
|
68843967cf | ||
|
|
8c295e7c68 | ||
|
|
219a574eed | ||
|
|
fef2cab31e | ||
|
|
20ee262f78 | ||
|
|
6a8c453659 | ||
|
|
ea277dec4d | ||
|
|
a7aa124c10 | ||
|
|
9c62bbc74a | ||
|
|
f0e16cdf46 | ||
|
|
0658c1ac9c | ||
|
|
997501d8fb | ||
|
|
ab6e5ba094 | ||
|
|
2322a5a497 | ||
|
|
0bc951fd12 | ||
|
|
0446ca7a18 | ||
|
|
653ee48444 | ||
|
|
81d9df61f2 | ||
|
|
f4358cb161 | ||
|
|
5948002dee |
36
.github/workflows/ci-tests-e2e-coverage.yaml
vendored
@@ -20,6 +20,8 @@ jobs:
|
||||
github.event.workflow_run.conclusion == 'success'
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 10
|
||||
outputs:
|
||||
has-coverage: ${{ steps.coverage-shards.outputs.has-coverage }}
|
||||
|
||||
steps:
|
||||
- name: Checkout repository
|
||||
@@ -37,31 +39,33 @@ jobs:
|
||||
path: temp/coverage-shards
|
||||
if_no_artifact_found: warn
|
||||
|
||||
- name: Detect shard coverage data
|
||||
id: coverage-shards
|
||||
run: |
|
||||
if [ -d temp/coverage-shards ] && find temp/coverage-shards -name 'coverage.lcov' -type f | grep -q .; then
|
||||
echo "has-coverage=true" >> "$GITHUB_OUTPUT"
|
||||
else
|
||||
echo "has-coverage=false" >> "$GITHUB_OUTPUT"
|
||||
echo "No E2E coverage shard artifacts found; treating this run as skipped." >> "$GITHUB_STEP_SUMMARY"
|
||||
fi
|
||||
|
||||
- name: Install lcov
|
||||
if: steps.coverage-shards.outputs.has-coverage == 'true'
|
||||
run: sudo apt-get install -y -qq lcov
|
||||
|
||||
- name: Merge shard coverage into single LCOV
|
||||
if: steps.coverage-shards.outputs.has-coverage == 'true'
|
||||
run: |
|
||||
mkdir -p coverage/playwright
|
||||
LCOV_FILES=$(find temp/coverage-shards -name 'coverage.lcov' -type f)
|
||||
if [ -z "$LCOV_FILES" ]; then
|
||||
echo "No coverage.lcov files found"
|
||||
touch coverage/playwright/coverage.lcov
|
||||
exit 0
|
||||
fi
|
||||
ADD_ARGS=""
|
||||
for f in $LCOV_FILES; do ADD_ARGS="$ADD_ARGS -a $f"; done
|
||||
lcov $ADD_ARGS -o coverage/playwright/coverage.lcov
|
||||
wc -l coverage/playwright/coverage.lcov
|
||||
|
||||
- name: Validate merged coverage
|
||||
if: steps.coverage-shards.outputs.has-coverage == 'true'
|
||||
run: |
|
||||
SHARD_COUNT=$(find temp/coverage-shards -name 'coverage.lcov' -type f | wc -l | tr -d ' ')
|
||||
if [ "$SHARD_COUNT" -eq 0 ]; then
|
||||
echo "::notice::No shard coverage files; upstream E2E was likely skipped."
|
||||
exit 0
|
||||
fi
|
||||
|
||||
MERGED_SF=$(grep -c '^SF:' coverage/playwright/coverage.lcov || echo 0)
|
||||
MERGED_LH=$(awk -F: '/^LH:/{s+=$2}END{print s+0}' coverage/playwright/coverage.lcov)
|
||||
MERGED_LF=$(awk -F: '/^LF:/{s+=$2}END{print s+0}' coverage/playwright/coverage.lcov)
|
||||
@@ -82,7 +86,7 @@ jobs:
|
||||
done
|
||||
|
||||
- name: Upload merged coverage data
|
||||
if: always()
|
||||
if: steps.coverage-shards.outputs.has-coverage == 'true'
|
||||
uses: actions/upload-artifact@v6
|
||||
with:
|
||||
name: e2e-coverage
|
||||
@@ -91,7 +95,7 @@ jobs:
|
||||
if-no-files-found: warn
|
||||
|
||||
- name: Upload E2E coverage to Codecov
|
||||
if: always()
|
||||
if: steps.coverage-shards.outputs.has-coverage == 'true'
|
||||
uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5.5.3
|
||||
with:
|
||||
files: coverage/playwright/coverage.lcov
|
||||
@@ -100,6 +104,7 @@ jobs:
|
||||
fail_ci_if_error: false
|
||||
|
||||
- name: Generate HTML coverage report
|
||||
if: steps.coverage-shards.outputs.has-coverage == 'true'
|
||||
run: |
|
||||
if [ ! -s coverage/playwright/coverage.lcov ]; then
|
||||
echo "No coverage data; generating placeholder report."
|
||||
@@ -114,6 +119,7 @@ jobs:
|
||||
--precision 1
|
||||
|
||||
- name: Upload HTML report artifact
|
||||
if: steps.coverage-shards.outputs.has-coverage == 'true'
|
||||
uses: actions/upload-artifact@v6
|
||||
with:
|
||||
name: e2e-coverage-html
|
||||
@@ -122,7 +128,9 @@ jobs:
|
||||
|
||||
deploy:
|
||||
needs: merge
|
||||
if: github.event.workflow_run.head_branch == 'main'
|
||||
if: >
|
||||
github.event.workflow_run.head_branch == 'main' &&
|
||||
needs.merge.outputs.has-coverage == 'true'
|
||||
runs-on: ubuntu-latest
|
||||
permissions:
|
||||
pages: write
|
||||
|
||||
88
.github/workflows/ci-tests-extension-api.yaml
vendored
Normal file
@@ -0,0 +1,88 @@
|
||||
# Description: Extension API test suite (I-TF) + compat-floor gate (I-TF.7)
|
||||
#
|
||||
# Runs on any PR touching extension-api declaration files, extension-api-v2
|
||||
# implementation/tests, or the touch-point DB/rollup (blast-radius changes).
|
||||
#
|
||||
# Two jobs:
|
||||
# test — vitest run against src/extension-api-v2/__tests__/
|
||||
# compat-floor — python scripts/check-compat-floor.py (exits 1 if any
|
||||
# blast_radius ≥ 2.0 category is missing a stub triple)
|
||||
#
|
||||
# The compat-floor job is the CI enforcement of PLAN.md §Compat-floor:
|
||||
# "Every blast_radius ≥ 2.0 pattern MUST pass v1 + v2 + migration before v2 ships."
|
||||
name: 'CI: Tests Extension API'
|
||||
|
||||
on:
|
||||
push:
|
||||
branches: [main, master, dev*, core/*, extension-v2*]
|
||||
paths:
|
||||
- 'src/extension-api/**'
|
||||
- 'src/extension-api-v2/**'
|
||||
- 'packages/extension-api/**'
|
||||
- 'vitest.extension-api.config.mts'
|
||||
- 'research/touch-points/rollup.yaml'
|
||||
- 'research/touch-points/behavior-categories.yaml'
|
||||
- 'scripts/check-compat-floor.py'
|
||||
- 'pnpm-lock.yaml'
|
||||
pull_request:
|
||||
branches-ignore: [wip/*, draft/*, temp/*]
|
||||
paths:
|
||||
- 'src/extension-api/**'
|
||||
- 'src/extension-api-v2/**'
|
||||
- 'packages/extension-api/**'
|
||||
- 'vitest.extension-api.config.mts'
|
||||
- 'research/touch-points/rollup.yaml'
|
||||
- 'research/touch-points/behavior-categories.yaml'
|
||||
- 'scripts/check-compat-floor.py'
|
||||
- 'pnpm-lock.yaml'
|
||||
|
||||
concurrency:
|
||||
group: ${{ github.workflow }}-${{ github.ref }}
|
||||
cancel-in-progress: true
|
||||
|
||||
jobs:
|
||||
test:
|
||||
name: Extension API tests (vitest)
|
||||
runs-on: ubuntu-latest
|
||||
|
||||
steps:
|
||||
- uses: actions/checkout@v6
|
||||
|
||||
- name: Setup frontend
|
||||
uses: ./.github/actions/setup-frontend
|
||||
|
||||
- name: Run extension-api test suite
|
||||
run: pnpm test:extension-api
|
||||
|
||||
- name: Run with coverage (push only)
|
||||
if: github.event_name == 'push'
|
||||
run: pnpm test:extension-api:coverage
|
||||
|
||||
- name: Upload coverage to Codecov
|
||||
if: github.event_name == 'push'
|
||||
uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5.5.3
|
||||
with:
|
||||
files: coverage/lcov.info
|
||||
flags: extension-api
|
||||
token: ${{ secrets.CODECOV_TOKEN }}
|
||||
fail_ci_if_error: false
|
||||
|
||||
compat-floor:
|
||||
name: Compat-floor gate (blast_radius ≥ 2.0)
|
||||
runs-on: ubuntu-latest
|
||||
|
||||
steps:
|
||||
- uses: actions/checkout@v6
|
||||
|
||||
- name: Set up Python
|
||||
uses: actions/setup-python@v5
|
||||
with:
|
||||
python-version: '3.11'
|
||||
|
||||
- name: Install PyYAML
|
||||
run: pip install pyyaml
|
||||
|
||||
- name: Check compat floor
|
||||
run: python3 scripts/check-compat-floor.py
|
||||
# Exits 1 if any blast_radius ≥ 2.0 behavior category is missing
|
||||
# any of its three stub files (v1/v2/migration). Enforces PLAN.md §Compat-floor.
|
||||
33
apps/website/e2e/customers.spec.ts
Normal file
@@ -0,0 +1,33 @@
|
||||
import { expect } from '@playwright/test'
|
||||
|
||||
import { test } from './fixtures/blockExternalMedia'
|
||||
|
||||
test.describe('Customers @smoke', () => {
|
||||
test.beforeEach(async ({ page }) => {
|
||||
await page.goto('/customers')
|
||||
})
|
||||
|
||||
test('hero image declares intrinsic dimensions so layout reserves space before load', async ({
|
||||
page
|
||||
}) => {
|
||||
const heroImage = page.locator('img[alt="Comfy 3D logo"]')
|
||||
await expect(heroImage).toBeVisible()
|
||||
await expect(heroImage).toHaveAttribute('width', /^\d+$/)
|
||||
await expect(heroImage).toHaveAttribute('height', /^\d+$/)
|
||||
|
||||
// Regression guard: an unloaded <img> without intrinsic dimensions
|
||||
// collapses to ~0px, then jumps to its natural size on load and pushes
|
||||
// the video below it. Reserved space must persist before bytes arrive.
|
||||
const heightWhileUnloaded = await page.evaluate(() => {
|
||||
const img = document.querySelector<HTMLImageElement>(
|
||||
'img[alt="Comfy 3D logo"]'
|
||||
)
|
||||
if (!img) return null
|
||||
img.removeAttribute('src')
|
||||
return img.getBoundingClientRect().height
|
||||
})
|
||||
|
||||
expect(heightWhileUnloaded).not.toBeNull()
|
||||
expect(heightWhileUnloaded!).toBeGreaterThan(100)
|
||||
})
|
||||
})
|
||||
@@ -26,8 +26,8 @@ async function assertNoOverflow(page: Page) {
|
||||
}
|
||||
|
||||
async function navigateAndSettle(page: Page, url: string) {
|
||||
await page.goto(url)
|
||||
await page.waitForLoadState('networkidle')
|
||||
await page.goto(url, { waitUntil: 'domcontentloaded' })
|
||||
await page.waitForLoadState('load')
|
||||
}
|
||||
|
||||
test.describe('Home', { tag: '@visual' }, () => {
|
||||
|
||||
|
Before Width: | Height: | Size: 39 KiB After Width: | Height: | Size: 38 KiB |
|
Before Width: | Height: | Size: 40 KiB After Width: | Height: | Size: 39 KiB |
|
Before Width: | Height: | Size: 58 KiB After Width: | Height: | Size: 58 KiB |
|
Before Width: | Height: | Size: 58 KiB After Width: | Height: | Size: 58 KiB |
|
Before Width: | Height: | Size: 85 KiB After Width: | Height: | Size: 85 KiB |
|
Before Width: | Height: | Size: 86 KiB After Width: | Height: | Size: 85 KiB |
|
Before Width: | Height: | Size: 95 KiB After Width: | Height: | Size: 95 KiB |
|
Before Width: | Height: | Size: 100 KiB After Width: | Height: | Size: 99 KiB |
@@ -28,7 +28,7 @@ export default defineConfig({
|
||||
? [['html'], ['json', { outputFile: 'results.json' }]]
|
||||
: 'html',
|
||||
expect: {
|
||||
toHaveScreenshot: { maxDiffPixels: 50 }
|
||||
toHaveScreenshot: { maxDiffPixels: 100 }
|
||||
},
|
||||
...maybeLocalOptions,
|
||||
webServer: {
|
||||
|
||||
@@ -13,7 +13,7 @@ const { stars } = defineProps<{
|
||||
target="_blank"
|
||||
rel="noopener noreferrer"
|
||||
:aria-label="`ComfyUI on GitHub — ${stars} stars`"
|
||||
class="hidden shrink-0 items-center gap-2 lg:flex"
|
||||
class="hidden shrink-0 items-center gap-1 lg:flex"
|
||||
>
|
||||
<NodeBadge
|
||||
:segments="[{ text: stars }]"
|
||||
@@ -22,7 +22,7 @@ const { stars } = defineProps<{
|
||||
size-class="h-5 sm:h-5"
|
||||
/>
|
||||
<span
|
||||
class="bg-primary-comfy-yellow block size-7"
|
||||
class="bg-primary-comfy-yellow block size-6 shrink-0"
|
||||
aria-hidden="true"
|
||||
style="mask: url('/icons/social/github.svg') center / contain no-repeat"
|
||||
/>
|
||||
|
||||
@@ -75,7 +75,7 @@ const progressPercent = computed(() => `${progress.value * 100}%`)
|
||||
<!-- Progress bar -->
|
||||
<div class="h-1 flex-1 rounded-full bg-white/20">
|
||||
<div
|
||||
class="bg-primary-comfy-yellow h-full rounded-full transition-all duration-200"
|
||||
class="bg-primary-comfy-yellow h-full rounded-full"
|
||||
:style="{ width: progressPercent }"
|
||||
/>
|
||||
</div>
|
||||
|
||||
@@ -5,6 +5,7 @@ import { useHeroAnimation } from '../../composables/useHeroAnimation'
|
||||
import SectionLabel from '../common/SectionLabel.vue'
|
||||
import type { Locale } from '../../i18n/translations'
|
||||
import { t } from '../../i18n/translations'
|
||||
import { ScrollTrigger } from '../../scripts/gsapSetup'
|
||||
import VideoPlayer from '../common/VideoPlayer.vue'
|
||||
|
||||
const { locale = 'en' } = defineProps<{ locale?: Locale }>()
|
||||
@@ -22,6 +23,10 @@ useHeroAnimation({
|
||||
logo: logoRef,
|
||||
video: videoRef
|
||||
})
|
||||
|
||||
function handleLogoLoad() {
|
||||
ScrollTrigger.refresh(true)
|
||||
}
|
||||
</script>
|
||||
|
||||
<template>
|
||||
@@ -37,7 +42,10 @@ useHeroAnimation({
|
||||
<img
|
||||
src="https://media.comfy.org/website/customers/c-projection.webp"
|
||||
alt="Comfy 3D logo"
|
||||
class="mx-auto w-full max-w-md lg:max-w-none"
|
||||
width="1568"
|
||||
height="1763"
|
||||
class="mx-auto h-auto w-full max-w-md lg:max-w-none"
|
||||
@load="handleLogoLoad"
|
||||
/>
|
||||
</div>
|
||||
|
||||
|
||||
@@ -25,7 +25,7 @@ const categories: Category[] = [
|
||||
{
|
||||
label: t('useCase.vfx', locale),
|
||||
leftSrc: 'https://media.comfy.org/website/homepage/use-case/left1.webm',
|
||||
rightSrc: 'https://media.comfy.org/website/homepage/use-case/right1.webp'
|
||||
rightSrc: 'https://media.comfy.org/website/homepage/use-case/right1.webm'
|
||||
},
|
||||
{
|
||||
label: t('useCase.advertising', locale),
|
||||
|
||||
@@ -190,6 +190,9 @@ export class ComfyPage {
|
||||
/** Worker index to test user ID */
|
||||
public readonly userIds: string[] = []
|
||||
|
||||
/** Whether the current test runs in Vue Nodes mode (initialized from `@vue-nodes` tag). */
|
||||
public isVueNodes = false
|
||||
|
||||
/** Test user ID for the current context */
|
||||
get id() {
|
||||
return this.userIds[comfyPageFixture.info().parallelIndex]
|
||||
@@ -500,6 +503,7 @@ export const comfyPageFixture = base.extend<{
|
||||
comfyPage.userIds[parallelIndex] = userId
|
||||
|
||||
const isVueNodes = testInfo.tags.includes('@vue-nodes')
|
||||
comfyPage.isVueNodes = isVueNodes
|
||||
|
||||
try {
|
||||
await comfyPage.setupSettings({
|
||||
|
||||
@@ -217,13 +217,20 @@ export class VueNodeHelpers {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Locator for the Enter Subgraph footer button.
|
||||
*/
|
||||
getSubgraphEnterButton(nodeId?: string): Locator {
|
||||
const root = nodeId ? this.getNodeLocator(nodeId) : this.page
|
||||
return root.getByTestId(TestIds.widgets.subgraphEnterButton).first()
|
||||
}
|
||||
|
||||
/**
|
||||
* Enter the subgraph of a node.
|
||||
* @param nodeId - The ID of the node to enter the subgraph of. If not provided, the first matched subgraph will be entered.
|
||||
*/
|
||||
async enterSubgraph(nodeId?: string): Promise<void> {
|
||||
const locator = nodeId ? this.getNodeLocator(nodeId) : this.page
|
||||
const editButton = locator.getByTestId(TestIds.widgets.subgraphEnterButton)
|
||||
const editButton = this.getSubgraphEnterButton(nodeId)
|
||||
|
||||
// The footer tab button extends below the node body (visible area),
|
||||
// but its bounding box center overlaps the node body div.
|
||||
|
||||
@@ -20,6 +20,7 @@ export class ContextMenu {
|
||||
|
||||
async clickMenuItemExact(name: string): Promise<void> {
|
||||
await this.page.getByRole('menuitem', { name, exact: true }).click()
|
||||
await this.waitForHidden()
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
12
browser_tests/fixtures/components/WidgetSelectDropdown.ts
Normal file
@@ -0,0 +1,12 @@
|
||||
import type { Locator } from '@playwright/test'
|
||||
|
||||
export class WidgetSelectDropdownFixture {
|
||||
public readonly selection: Locator
|
||||
|
||||
constructor(public readonly root: Locator) {
|
||||
this.selection = root.locator('button span span')
|
||||
}
|
||||
async selectedItem(): Promise<string> {
|
||||
return await this.selection.innerText()
|
||||
}
|
||||
}
|
||||
@@ -9,13 +9,15 @@ import { BuilderFooterHelper } from '@e2e/fixtures/helpers/BuilderFooterHelper'
|
||||
import { BuilderSaveAsHelper } from '@e2e/fixtures/helpers/BuilderSaveAsHelper'
|
||||
import { BuilderSelectHelper } from '@e2e/fixtures/helpers/BuilderSelectHelper'
|
||||
import { BuilderStepsHelper } from '@e2e/fixtures/helpers/BuilderStepsHelper'
|
||||
import { MobileAppHelper } from '@e2e/fixtures/helpers/MobileAppHelper'
|
||||
|
||||
export class AppModeHelper {
|
||||
readonly steps: BuilderStepsHelper
|
||||
readonly footer: BuilderFooterHelper
|
||||
readonly mobile: MobileAppHelper
|
||||
readonly saveAs: BuilderSaveAsHelper
|
||||
readonly select: BuilderSelectHelper
|
||||
readonly outputHistory: OutputHistoryComponent
|
||||
readonly steps: BuilderStepsHelper
|
||||
readonly widgets: AppModeWidgetHelper
|
||||
|
||||
/** The "Connect an output" popover shown when saving without outputs. */
|
||||
@@ -60,13 +62,16 @@ export class AppModeHelper {
|
||||
public readonly vueNodeSwitchDismissButton: Locator
|
||||
/** The "Don't show again" checkbox inside the Vue Node switch popup. */
|
||||
public readonly vueNodeSwitchDontShowAgainCheckbox: Locator
|
||||
/** The main content area where outputs are displayed*/
|
||||
public readonly centerPanel: Locator
|
||||
|
||||
constructor(private readonly comfyPage: ComfyPage) {
|
||||
this.steps = new BuilderStepsHelper(comfyPage)
|
||||
this.mobile = new MobileAppHelper(comfyPage)
|
||||
this.footer = new BuilderFooterHelper(comfyPage)
|
||||
this.saveAs = new BuilderSaveAsHelper(comfyPage)
|
||||
this.select = new BuilderSelectHelper(comfyPage)
|
||||
this.outputHistory = new OutputHistoryComponent(comfyPage.page)
|
||||
this.steps = new BuilderStepsHelper(comfyPage)
|
||||
this.widgets = new AppModeWidgetHelper(comfyPage)
|
||||
|
||||
this.connectOutputPopover = this.page.getByTestId(
|
||||
@@ -125,6 +130,7 @@ export class AppModeHelper {
|
||||
this.vueNodeSwitchDontShowAgainCheckbox = this.page.getByTestId(
|
||||
TestIds.appMode.vueNodeSwitchDontShowAgain
|
||||
)
|
||||
this.centerPanel = this.page.getByTestId(TestIds.linear.centerPanel)
|
||||
}
|
||||
|
||||
private get page(): Page {
|
||||
|
||||
@@ -215,11 +215,12 @@ export class AssetHelper {
|
||||
return this.store.size
|
||||
}
|
||||
private handleListAssets(route: Route, url: URL) {
|
||||
const includeTags = url.searchParams.get('include_tags')?.split(',') ?? []
|
||||
const includeTags = parseAssetTagParam(url.searchParams.get('include_tags'))
|
||||
const excludeTags = parseAssetTagParam(url.searchParams.get('exclude_tags'))
|
||||
const limit = parseInt(url.searchParams.get('limit') ?? '0', 10)
|
||||
const offset = parseInt(url.searchParams.get('offset') ?? '0', 10)
|
||||
|
||||
let filtered = this.getFilteredAssets(includeTags)
|
||||
let filtered = this.getFilteredAssets(includeTags, excludeTags)
|
||||
if (limit > 0) {
|
||||
filtered = filtered.slice(offset, offset + limit)
|
||||
}
|
||||
@@ -296,15 +297,29 @@ export class AssetHelper {
|
||||
this.paginationOptions = null
|
||||
this.uploadResponse = null
|
||||
}
|
||||
private getFilteredAssets(tags: string[]): Asset[] {
|
||||
private getFilteredAssets(
|
||||
includeTags: string[],
|
||||
excludeTags: string[]
|
||||
): Asset[] {
|
||||
const assets = [...this.store.values()]
|
||||
if (tags.length === 0) return assets
|
||||
|
||||
return assets.filter((asset) =>
|
||||
tags.every((tag) => (asset.tags ?? []).includes(tag))
|
||||
return assets.filter(
|
||||
(asset) =>
|
||||
includeTags.every((tag) => (asset.tags ?? []).includes(tag)) &&
|
||||
excludeTags.every((tag) => !(asset.tags ?? []).includes(tag))
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
function parseAssetTagParam(value: string | null): string[] {
|
||||
return (
|
||||
value
|
||||
?.split(',')
|
||||
.map((tag) => tag.trim())
|
||||
.filter(Boolean) ?? []
|
||||
)
|
||||
}
|
||||
|
||||
export function createAssetHelper(
|
||||
page: Page,
|
||||
...operators: AssetOperator[]
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import { readFileSync } from 'fs'
|
||||
import { basename } from 'path'
|
||||
|
||||
import type { Page } from '@playwright/test'
|
||||
|
||||
@@ -13,6 +14,7 @@ export class DragDropHelper {
|
||||
async dragAndDropExternalResource(
|
||||
options: {
|
||||
fileName?: string
|
||||
filePath?: string
|
||||
url?: string
|
||||
dropPosition?: Position
|
||||
waitForUpload?: boolean
|
||||
@@ -22,13 +24,14 @@ export class DragDropHelper {
|
||||
const {
|
||||
dropPosition = { x: 100, y: 100 },
|
||||
fileName,
|
||||
filePath,
|
||||
url,
|
||||
waitForUpload = false,
|
||||
preserveNativePropagation = false
|
||||
} = options
|
||||
|
||||
if (!fileName && !url)
|
||||
throw new Error('Must provide either fileName or url')
|
||||
if (!fileName && !filePath && !url)
|
||||
throw new Error('Must provide fileName, filePath, or url')
|
||||
|
||||
const evaluateParams: {
|
||||
dropPosition: Position
|
||||
@@ -39,12 +42,22 @@ export class DragDropHelper {
|
||||
preserveNativePropagation: boolean
|
||||
} = { dropPosition, preserveNativePropagation }
|
||||
|
||||
if (fileName) {
|
||||
const filePath = assetPath(fileName)
|
||||
const buffer = readFileSync(filePath)
|
||||
if (fileName || filePath) {
|
||||
const resolvedPath = filePath ?? assetPath(fileName!)
|
||||
const displayName = fileName ?? basename(resolvedPath)
|
||||
let buffer: Buffer
|
||||
try {
|
||||
buffer = readFileSync(resolvedPath)
|
||||
} catch (error) {
|
||||
const reason = error instanceof Error ? error.message : String(error)
|
||||
throw new Error(
|
||||
`Failed to read drag-and-drop fixture at "${resolvedPath}": ${reason}`,
|
||||
{ cause: error }
|
||||
)
|
||||
}
|
||||
|
||||
evaluateParams.fileName = fileName
|
||||
evaluateParams.fileType = getMimeType(fileName)
|
||||
evaluateParams.fileName = displayName
|
||||
evaluateParams.fileType = getMimeType(displayName)
|
||||
evaluateParams.buffer = [...new Uint8Array(buffer)]
|
||||
}
|
||||
|
||||
@@ -148,6 +161,13 @@ export class DragDropHelper {
|
||||
return this.dragAndDropExternalResource({ fileName, ...options })
|
||||
}
|
||||
|
||||
async dragAndDropFilePath(
|
||||
filePath: string,
|
||||
options: { dropPosition?: Position; waitForUpload?: boolean } = {}
|
||||
): Promise<void> {
|
||||
return this.dragAndDropExternalResource({ filePath, ...options })
|
||||
}
|
||||
|
||||
async dragAndDropURL(
|
||||
url: string,
|
||||
options: {
|
||||
|
||||
33
browser_tests/fixtures/helpers/MobileAppHelper.ts
Normal file
@@ -0,0 +1,33 @@
|
||||
import type { Locator, Page } from '@playwright/test'
|
||||
|
||||
import type { ComfyPage } from '@e2e/fixtures/ComfyPage'
|
||||
import { TestIds } from '@e2e/fixtures/selectors'
|
||||
|
||||
export class MobileAppHelper {
|
||||
private readonly page: Page
|
||||
readonly contentPanel: Locator
|
||||
readonly navigation: Locator
|
||||
readonly navigationTabs: Locator
|
||||
readonly view: Locator
|
||||
readonly workflows: Locator
|
||||
|
||||
constructor(comfyPage: ComfyPage) {
|
||||
this.page = comfyPage.page
|
||||
this.view = this.page.getByTestId(TestIds.linear.mobile)
|
||||
this.contentPanel = this.page.getByRole('tabpanel')
|
||||
this.navigation = this.page.getByRole('tablist').filter({ hasText: 'Run' })
|
||||
this.navigationTabs = this.navigation.getByRole('tab')
|
||||
this.workflows = this.view.getByTestId(TestIds.linear.mobileWorkflows)
|
||||
}
|
||||
|
||||
async switchWorkflow(workflowName: string) {
|
||||
await this.workflows.click()
|
||||
await this.page.getByRole('menu').getByText(workflowName).click()
|
||||
}
|
||||
async navigateTab(name: 'run' | 'outputs' | 'assets') {
|
||||
await this.navigation.getByRole('tab', { name }).click()
|
||||
}
|
||||
async tap(locator: Locator, { count = 1 }: { count?: number } = {}) {
|
||||
for (let i = 0; i < count; i++) await locator.tap()
|
||||
}
|
||||
}
|
||||
@@ -362,6 +362,9 @@ export class SubgraphHelper {
|
||||
|
||||
await this.comfyPage.nextFrame()
|
||||
await expect.poll(async () => this.isInSubgraph()).toBe(false)
|
||||
if (this.comfyPage.isVueNodes) {
|
||||
await this.comfyPage.vueNodes.waitForNodes()
|
||||
}
|
||||
}
|
||||
|
||||
async countGraphPseudoPreviewEntries(): Promise<number> {
|
||||
|
||||
@@ -144,6 +144,14 @@ export const TestIds = {
|
||||
domWidgetTextarea: 'dom-widget-textarea',
|
||||
subgraphEnterButton: 'subgraph-enter-button'
|
||||
},
|
||||
linear: {
|
||||
centerPanel: 'linear-center-panel',
|
||||
mobile: 'linear-mobile',
|
||||
mobileNavigation: 'linear-mobile-navigation',
|
||||
mobileWorkflows: 'linear-mobile-workflows',
|
||||
outputInfo: 'linear-output-info',
|
||||
widgetContainer: 'linear-widgets'
|
||||
},
|
||||
builder: {
|
||||
footerNav: 'builder-footer-nav',
|
||||
saveButton: 'builder-save-button',
|
||||
|
||||
@@ -7,6 +7,9 @@ export function getMimeType(fileName: string): string {
|
||||
if (name.endsWith('.avif')) return 'image/avif'
|
||||
if (name.endsWith('.webm')) return 'video/webm'
|
||||
if (name.endsWith('.mp4')) return 'video/mp4'
|
||||
if (name.endsWith('.mp3')) return 'audio/mpeg'
|
||||
if (name.endsWith('.flac')) return 'audio/flac'
|
||||
if (name.endsWith('.ogg') || name.endsWith('.opus')) return 'audio/ogg'
|
||||
if (name.endsWith('.json')) return 'application/json'
|
||||
if (name.endsWith('.glb')) return 'model/gltf-binary'
|
||||
return 'application/octet-stream'
|
||||
|
||||
@@ -1,3 +1,7 @@
|
||||
export function assetPath(fileName: string): string {
|
||||
return `./browser_tests/assets/${fileName}`
|
||||
}
|
||||
|
||||
export function metadataFixturePath(fileName: string): string {
|
||||
return `./src/scripts/metadata/__fixtures__/${fileName}`
|
||||
}
|
||||
|
||||
@@ -13,6 +13,7 @@ export class VueNodeFixture {
|
||||
public readonly collapseButton: Locator
|
||||
public readonly collapseIcon: Locator
|
||||
public readonly root: Locator
|
||||
public readonly widgets: Locator
|
||||
|
||||
constructor(private readonly locator: Locator) {
|
||||
this.header = locator.locator('[data-testid^="node-header-"]')
|
||||
@@ -23,6 +24,7 @@ export class VueNodeFixture {
|
||||
this.collapseButton = locator.getByTestId('node-collapse-button')
|
||||
this.collapseIcon = this.collapseButton.locator('i')
|
||||
this.root = locator
|
||||
this.widgets = this.locator.locator('.lg-node-widget')
|
||||
}
|
||||
|
||||
async getTitle(): Promise<string> {
|
||||
@@ -39,6 +41,16 @@ export class VueNodeFixture {
|
||||
await this.collapseButton.click()
|
||||
}
|
||||
|
||||
/**
|
||||
* Select this node and delete it via the Delete key, waiting for the node
|
||||
* element to leave the DOM before resolving.
|
||||
*/
|
||||
async delete(): Promise<void> {
|
||||
await this.header.click()
|
||||
await this.header.press('Delete')
|
||||
await this.locator.waitFor({ state: 'hidden' })
|
||||
}
|
||||
|
||||
async getCollapseIconClass(): Promise<string> {
|
||||
return (await this.collapseIcon.getAttribute('class')) ?? ''
|
||||
}
|
||||
|
||||
154
browser_tests/tests/appMode.spec.ts
Normal file
@@ -0,0 +1,154 @@
|
||||
import {
|
||||
comfyPageFixture as test,
|
||||
comfyExpect as expect
|
||||
} from '@e2e/fixtures/ComfyPage'
|
||||
import { WidgetSelectDropdownFixture } from '@e2e/fixtures/components/WidgetSelectDropdown'
|
||||
|
||||
test.describe('App mode usage', () => {
|
||||
test('Drag and Drop', async ({ comfyPage, comfyFiles }) => {
|
||||
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
||||
await comfyPage.settings.setSetting(
|
||||
'Comfy.NodeSearchBoxImpl',
|
||||
'v1 (legacy)'
|
||||
)
|
||||
const { centerPanel } = comfyPage.appMode
|
||||
await comfyPage.appMode.enterAppModeWithInputs([['3', 'seed']])
|
||||
await expect(centerPanel, 'Enter app mode').toBeVisible()
|
||||
|
||||
//an app without an image input will load the workflow
|
||||
await test.step('App without an image input loads workflow', async () => {
|
||||
await comfyPage.dragDrop.dragAndDropFile('workflowInMedia/workflow.webp')
|
||||
await expect(centerPanel).toBeHidden()
|
||||
})
|
||||
|
||||
//prep a load image
|
||||
await test.step('Add a load image node', async () => {
|
||||
await comfyPage.workflow.loadWorkflow('default')
|
||||
await comfyPage.page.mouse.dblclick(200, 200, { delay: 5 })
|
||||
await comfyPage.searchBox.fillAndSelectFirstNode('Load Image')
|
||||
const loadImage = await comfyPage.vueNodes.getNodeLocator('10')
|
||||
await expect(loadImage).toBeVisible()
|
||||
})
|
||||
|
||||
const imageInput = new WidgetSelectDropdownFixture(
|
||||
comfyPage.appMode.linearWidgets.locator('.lg-node-widget')
|
||||
)
|
||||
|
||||
await test.step('Enter app mode with image input', async () => {
|
||||
await comfyPage.appMode.enterAppModeWithInputs([['10', 'image']])
|
||||
await expect(centerPanel).toBeVisible()
|
||||
|
||||
await expect(imageInput.root).toBeVisible()
|
||||
})
|
||||
|
||||
await test.step('Dragging an image redirects to image input', async () => {
|
||||
const initialImage = await imageInput.selectedItem()
|
||||
|
||||
await comfyPage.dragDrop.dragAndDropExternalResource({
|
||||
fileName: 'workflow.webp',
|
||||
filePath: './browser_tests/assets/workflowInMedia/workflow.webp',
|
||||
preserveNativePropagation: true
|
||||
})
|
||||
comfyFiles.deleteAfterTest({ filename: 'workflow.webp', type: 'input' })
|
||||
|
||||
await expect(imageInput.selection).not.toHaveText(initialImage)
|
||||
await expect(
|
||||
centerPanel,
|
||||
'A file with workflow should not open a new workflow'
|
||||
).toBeVisible()
|
||||
})
|
||||
|
||||
await test.step('Dragging a url redirects to image input', async () => {
|
||||
const secondImage = await imageInput.selectedItem()
|
||||
await comfyPage.dragDrop.dragAndDropURL('/assets/images/og-image.png', {
|
||||
preserveNativePropagation: true
|
||||
})
|
||||
comfyFiles.deleteAfterTest({
|
||||
filename: 'og-image.png',
|
||||
type: 'input'
|
||||
})
|
||||
await expect(imageInput.selection).not.toHaveText(secondImage)
|
||||
})
|
||||
})
|
||||
|
||||
test('Widget Interaction', async ({ comfyPage }) => {
|
||||
await comfyPage.appMode.enterAppModeWithInputs([
|
||||
['3', 'seed'],
|
||||
['3', 'sampler_name'],
|
||||
['6', 'text']
|
||||
])
|
||||
const seed = comfyPage.appMode.linearWidgets.getByLabel('seed', {
|
||||
exact: true
|
||||
})
|
||||
const { input, incrementButton, decrementButton } =
|
||||
comfyPage.vueNodes.getInputNumberControls(seed)
|
||||
const initialValue = Number(await input.inputValue())
|
||||
|
||||
await seed.dragTo(incrementButton, { steps: 5 })
|
||||
const intermediateValue = Number(await input.inputValue())
|
||||
expect(intermediateValue).toBeGreaterThan(initialValue)
|
||||
|
||||
await seed.dragTo(decrementButton, { steps: 5 })
|
||||
const endValue = Number(await input.inputValue())
|
||||
expect(endValue).toBeLessThan(intermediateValue)
|
||||
|
||||
const sampler = comfyPage.appMode.linearWidgets.getByLabel('sampler_name', {
|
||||
exact: true
|
||||
})
|
||||
await sampler.click()
|
||||
|
||||
await comfyPage.page.getByRole('searchbox').fill('uni')
|
||||
await comfyPage.page.keyboard.press('ArrowDown')
|
||||
await comfyPage.page.keyboard.press('Enter')
|
||||
await expect(sampler).toHaveText('uni_pc')
|
||||
|
||||
//verify values are consistent with litegraph
|
||||
})
|
||||
|
||||
test.describe('Mobile', { tag: ['@mobile'] }, () => {
|
||||
test('panel navigation', async ({ comfyPage }) => {
|
||||
const { mobile } = comfyPage.appMode
|
||||
await comfyPage.appMode.enterAppModeWithInputs([['3', 'steps']])
|
||||
await expect(mobile.view).toBeVisible()
|
||||
await expect(mobile.navigation).toBeVisible()
|
||||
|
||||
await mobile.navigateTab('assets')
|
||||
await expect(mobile.contentPanel).toHaveAccessibleName('Assets')
|
||||
|
||||
const buttons = await mobile.navigationTabs.all()
|
||||
await buttons[0].dragTo(buttons[2], { steps: 5 })
|
||||
await expect(mobile.contentPanel).toHaveAccessibleName('Outputs')
|
||||
|
||||
await mobile.navigateTab('run')
|
||||
await expect(comfyPage.appMode.linearWidgets).toBeInViewport({ ratio: 1 })
|
||||
|
||||
const steps = comfyPage.page.getByRole('spinbutton')
|
||||
const initialValue = Number(await steps.inputValue())
|
||||
await mobile.tap(
|
||||
comfyPage.page.getByRole('button', { name: 'increment' }),
|
||||
{ count: 5 }
|
||||
)
|
||||
await expect(steps).toHaveValue(String(initialValue + 5))
|
||||
await mobile.tap(
|
||||
comfyPage.page.getByRole('button', { name: 'decrement' }),
|
||||
{ count: 3 }
|
||||
)
|
||||
|
||||
await expect(steps).toHaveValue(String(initialValue + 2))
|
||||
})
|
||||
|
||||
test('workflow selection', async ({ comfyPage }) => {
|
||||
const widgetNames = ['seed', 'steps', 'denoise', 'cfg']
|
||||
for (const name of widgetNames)
|
||||
await comfyPage.appMode.enterAppModeWithInputs([['3', name]])
|
||||
await expect(comfyPage.appMode.mobile.workflows).toBeVisible()
|
||||
|
||||
const widgets = comfyPage.appMode.linearWidgets
|
||||
await comfyPage.appMode.mobile.navigateTab('run')
|
||||
for (let i = 0; i < widgetNames.length; i++) {
|
||||
await comfyPage.appMode.mobile.switchWorkflow(`(${i + 2})`)
|
||||
await expect(widgets.getByText(widgetNames[i])).toBeVisible()
|
||||
}
|
||||
})
|
||||
})
|
||||
})
|
||||
121
browser_tests/tests/appModeBuilder.spec.ts
Normal file
@@ -0,0 +1,121 @@
|
||||
import {
|
||||
comfyPageFixture as test,
|
||||
comfyExpect as expect
|
||||
} from '@e2e/fixtures/ComfyPage'
|
||||
|
||||
test.describe('App mode builder selection', () => {
|
||||
test.beforeEach(async ({ comfyPage }) => {
|
||||
await comfyPage.appMode.enableLinearMode()
|
||||
})
|
||||
|
||||
test('Can independently select inputs of same name', async ({
|
||||
comfyPage
|
||||
}) => {
|
||||
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
||||
const items = comfyPage.appMode.select.inputItems
|
||||
|
||||
await comfyPage.vueNodes.selectNodes(['6', '7'])
|
||||
await comfyPage.command.executeCommand('Comfy.Graph.ConvertToSubgraph')
|
||||
|
||||
await comfyPage.appMode.enterBuilder()
|
||||
await comfyPage.appMode.steps.goToInputs()
|
||||
await expect(items).toHaveCount(0)
|
||||
|
||||
const prompts = comfyPage.vueNodes
|
||||
.getNodeByTitle('New Subgraph')
|
||||
.locator('.lg-node-widget')
|
||||
const count = await prompts.count()
|
||||
for (let i = 0; i < count; i++) {
|
||||
await expect(prompts.nth(i)).toBeVisible()
|
||||
await prompts.nth(i).click()
|
||||
await expect(items).toHaveCount(i + 1)
|
||||
}
|
||||
})
|
||||
|
||||
test('Can select outputs', async ({ comfyPage }) => {
|
||||
await comfyPage.appMode.enterBuilder()
|
||||
await comfyPage.appMode.steps.goToOutputs()
|
||||
|
||||
await comfyPage.nodeOps
|
||||
.getNodeRefById('9')
|
||||
.then((ref) => ref.centerOnNode())
|
||||
const saveImage = await comfyPage.vueNodes.getNodeLocator('9')
|
||||
await saveImage.click()
|
||||
|
||||
const items = comfyPage.appMode.select.inputItems
|
||||
await expect(items).toHaveCount(1)
|
||||
})
|
||||
|
||||
test('Can not select nodes with errors or notes', async ({ comfyPage }) => {
|
||||
//Manually set error state on checkpoint loader
|
||||
//Shouldn't be needed on ci, but has spotty reliability
|
||||
await comfyPage.page.evaluate(() => (graph!.nodes[6].has_errors = true))
|
||||
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
||||
|
||||
const items = comfyPage.appMode.select.inputItems
|
||||
await comfyPage.appMode.enterBuilder()
|
||||
await comfyPage.appMode.steps.goToInputs()
|
||||
await expect(items).toHaveCount(0)
|
||||
|
||||
await comfyPage.appMode.select.selectInputWidget(
|
||||
'Load Checkpoint',
|
||||
'ckpt_name'
|
||||
)
|
||||
await expect(items).toHaveCount(0)
|
||||
|
||||
await comfyPage.workflow.loadWorkflow('nodes/note_nodes')
|
||||
await comfyPage.appMode.enterBuilder()
|
||||
await comfyPage.appMode.steps.goToInputs()
|
||||
await expect(items).toHaveCount(0)
|
||||
|
||||
await comfyPage.appMode.select.selectInputWidget('Note', 'text')
|
||||
await comfyPage.appMode.select.selectInputWidget('Markdown Note', 'text')
|
||||
|
||||
await expect(items).toHaveCount(0)
|
||||
})
|
||||
|
||||
test('Marks canvas readOnly', async ({ comfyPage }) => {
|
||||
await comfyPage.settings.setSetting(
|
||||
'Comfy.NodeSearchBoxImpl',
|
||||
'v1 (legacy)'
|
||||
)
|
||||
|
||||
await comfyPage.page.mouse.dblclick(100, 100, { delay: 5 })
|
||||
await expect(
|
||||
comfyPage.searchBox.input,
|
||||
'Canvas is initially editable'
|
||||
).toHaveCount(1)
|
||||
await comfyPage.page.keyboard.press('Escape')
|
||||
|
||||
await comfyPage.appMode.enterBuilder()
|
||||
await comfyPage.appMode.steps.goToInputs()
|
||||
|
||||
await comfyPage.page.mouse.dblclick(100, 100, { delay: 5 })
|
||||
await expect(
|
||||
comfyPage.searchBox.input,
|
||||
'Entering builder makes the canvas readonly'
|
||||
).toHaveCount(0)
|
||||
|
||||
await comfyPage.page.keyboard.press('Space')
|
||||
await comfyPage.page.mouse.dblclick(100, 100, { delay: 5 })
|
||||
await expect(
|
||||
comfyPage.searchBox.input,
|
||||
'Canvas remains readonly after pressing space'
|
||||
).toHaveCount(0)
|
||||
|
||||
const ksampler = await comfyPage.vueNodes.getFixtureByTitle('KSampler')
|
||||
// oxlint-disable-next-line playwright/no-force-option -- Node container has conditional pointer-events:none that blocks actionability
|
||||
await ksampler.header.dblclick({ force: true })
|
||||
await expect(
|
||||
ksampler.titleEditor.input,
|
||||
'Double clicking node titles will not initiate a rename'
|
||||
).toBeHidden()
|
||||
|
||||
await comfyPage.page.keyboard.press('Escape')
|
||||
await comfyPage.page.mouse.dblclick(100, 100, { delay: 5 })
|
||||
await expect(
|
||||
comfyPage.searchBox.input,
|
||||
'Canvas is no longer readonly after exiting'
|
||||
).toHaveCount(1)
|
||||
})
|
||||
})
|
||||
@@ -133,6 +133,29 @@ test.describe('AssetHelper', () => {
|
||||
expect(data.assets[0].id).toBe(STABLE_CHECKPOINT.id)
|
||||
})
|
||||
|
||||
test('GET /assets filters by exclude_tags', async ({
|
||||
comfyPage,
|
||||
assetApi
|
||||
}) => {
|
||||
assetApi.configure(
|
||||
withAsset(STABLE_INPUT_IMAGE),
|
||||
withAsset({
|
||||
...STABLE_INPUT_IMAGE,
|
||||
id: 'missing-input',
|
||||
tags: ['input', 'missing']
|
||||
})
|
||||
)
|
||||
await assetApi.mock()
|
||||
|
||||
const { body } = await assetApi.fetch(
|
||||
`${comfyPage.url}/api/assets?include_tags=input,&exclude_tags= missing,`
|
||||
)
|
||||
const data = body as { assets: Array<{ id: string }> }
|
||||
expect(data.assets.map((asset) => asset.id)).toEqual([
|
||||
STABLE_INPUT_IMAGE.id
|
||||
])
|
||||
})
|
||||
|
||||
test('GET /assets/:id returns single asset or 404', async ({
|
||||
comfyPage,
|
||||
assetApi
|
||||
|
||||
62
browser_tests/tests/metadataWorkflowImport.spec.ts
Normal file
@@ -0,0 +1,62 @@
|
||||
import {
|
||||
comfyPageFixture as test,
|
||||
comfyExpect as expect
|
||||
} from '@e2e/fixtures/ComfyPage'
|
||||
import { metadataFixturePath } from '@e2e/fixtures/utils/paths'
|
||||
|
||||
type MetadataFixture = {
|
||||
fileName: string
|
||||
parser: string
|
||||
}
|
||||
|
||||
// Each fixture embeds the same single-KSampler workflow (see
|
||||
// scripts/generate-embedded-metadata-test-files.py), exercising a different
|
||||
// parser in src/scripts/metadata/. Dropping the file should import that
|
||||
// workflow.
|
||||
const FIXTURES: readonly MetadataFixture[] = [
|
||||
{ fileName: 'with_metadata.png', parser: 'png' },
|
||||
{ fileName: 'with_metadata.avif', parser: 'avif' },
|
||||
{ fileName: 'with_metadata.webp', parser: 'webp' },
|
||||
{ fileName: 'with_metadata_exif_prefix.webp', parser: 'webp (exif prefix)' },
|
||||
{ fileName: 'with_metadata.flac', parser: 'flac' },
|
||||
{ fileName: 'with_metadata.mp3', parser: 'mp3' },
|
||||
{ fileName: 'with_metadata.opus', parser: 'ogg' },
|
||||
{ fileName: 'with_metadata.mp4', parser: 'isobmff' },
|
||||
{ fileName: 'with_metadata.webm', parser: 'ebml (webm)' }
|
||||
] as const
|
||||
|
||||
test.describe(
|
||||
'Metadata drop-to-load workflow import',
|
||||
{ tag: ['@workflow'] },
|
||||
() => {
|
||||
test.beforeEach(async ({ comfyPage }) => {
|
||||
await comfyPage.nodeOps.clearGraph()
|
||||
await expect.poll(() => comfyPage.nodeOps.getGraphNodesCount()).toBe(0)
|
||||
})
|
||||
|
||||
for (const { fileName, parser } of FIXTURES) {
|
||||
test(`loads embedded workflow from ${fileName} (${parser})`, async ({
|
||||
comfyPage
|
||||
}) => {
|
||||
await test.step(`drop ${fileName} on canvas`, async () => {
|
||||
await comfyPage.dragDrop.dragAndDropFilePath(
|
||||
metadataFixturePath(fileName)
|
||||
)
|
||||
})
|
||||
|
||||
await test.step('graph contains only the embedded KSampler', async () => {
|
||||
await expect
|
||||
.poll(() => comfyPage.nodeOps.getGraphNodesCount())
|
||||
.toBe(1)
|
||||
|
||||
const ksamplers =
|
||||
await comfyPage.nodeOps.getNodeRefsByType('KSampler')
|
||||
expect(
|
||||
ksamplers,
|
||||
'exactly one KSampler should have been loaded from the fixture'
|
||||
).toHaveLength(1)
|
||||
})
|
||||
})
|
||||
}
|
||||
}
|
||||
)
|
||||
@@ -692,19 +692,27 @@ test.describe('Painter', { tag: ['@widget', '@vue-nodes'] }, () => {
|
||||
})
|
||||
})
|
||||
|
||||
test('Controls collapse to single column in compact mode', async ({
|
||||
test('Controls stack label above widget in compact mode', async ({
|
||||
comfyPage
|
||||
}) => {
|
||||
const painterWidget = comfyPage.vueNodes
|
||||
.getNodeLocator('1')
|
||||
.locator('.widget-expands')
|
||||
const toolLabel = painterWidget.getByText('Tool', { exact: true })
|
||||
const brushButton = painterWidget.getByText('Brush', { exact: true })
|
||||
|
||||
await expect(
|
||||
toolLabel,
|
||||
'tool label should be visible in two-column layout'
|
||||
'tool label should be visible in wide layout'
|
||||
).toBeVisible()
|
||||
|
||||
const wideLabelBox = await toolLabel.boundingBox()
|
||||
const wideBrushBox = await brushButton.boundingBox()
|
||||
expect(
|
||||
wideLabelBox && wideBrushBox && wideLabelBox.x < wideBrushBox.x,
|
||||
'label should sit to the left of the brush button in wide layout'
|
||||
).toBe(true)
|
||||
|
||||
await comfyPage.page.evaluate(() => {
|
||||
const graph = window.graph as TestGraphAccess | undefined
|
||||
const node = graph?._nodes_by_id?.['1']
|
||||
@@ -716,8 +724,22 @@ test.describe('Painter', { tag: ['@widget', '@vue-nodes'] }, () => {
|
||||
|
||||
await expect(
|
||||
toolLabel,
|
||||
'tool label should hide in compact single-column layout'
|
||||
).toBeHidden()
|
||||
'tool label should remain visible in compact layout'
|
||||
).toBeVisible()
|
||||
|
||||
await expect
|
||||
.poll(
|
||||
async () => {
|
||||
const labelBox = await toolLabel.boundingBox()
|
||||
const brushBox = await brushButton.boundingBox()
|
||||
if (!labelBox || !brushBox) return false
|
||||
return labelBox.y + labelBox.height <= brushBox.y
|
||||
},
|
||||
{
|
||||
message: 'label should stack above the brush button in compact layout'
|
||||
}
|
||||
)
|
||||
.toBe(true)
|
||||
})
|
||||
|
||||
test('Multiple sequential strokes at different positions all accumulate', async ({
|
||||
|
||||
@@ -558,5 +558,52 @@ test.describe(
|
||||
.toBe(0)
|
||||
})
|
||||
})
|
||||
|
||||
test.fail(
|
||||
'Promoted text widget is removed when source node is deleted inside the subgraph',
|
||||
{ tag: '@vue-nodes' },
|
||||
async ({ comfyPage }) => {
|
||||
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
||||
|
||||
const clipFixture = await comfyPage.vueNodes.getFixtureByTitle(
|
||||
'CLIP Text Encode (Prompt)'
|
||||
)
|
||||
await comfyPage.contextMenu.openForVueNode(clipFixture.header)
|
||||
await comfyPage.contextMenu.clickMenuItemExact('Convert to Subgraph')
|
||||
|
||||
const subgraphNode = comfyPage.vueNodes
|
||||
.getNodeByTitle('New Subgraph')
|
||||
.first()
|
||||
await expect(subgraphNode).toBeVisible()
|
||||
|
||||
const subgraphNodeId =
|
||||
await comfyPage.vueNodes.getNodeIdByTitle('New Subgraph')
|
||||
|
||||
await expect
|
||||
.poll(() => getPromotedWidgetNames(comfyPage, subgraphNodeId))
|
||||
.toContain('text')
|
||||
await expect(
|
||||
subgraphNode.getByTestId(TestIds.widgets.domWidgetTextarea)
|
||||
).toBeVisible()
|
||||
|
||||
await comfyPage.vueNodes.enterSubgraph(subgraphNodeId)
|
||||
await expect.poll(() => comfyPage.subgraph.isInSubgraph()).toBe(true)
|
||||
await comfyPage.vueNodes.waitForNodes()
|
||||
|
||||
const interiorClip = await comfyPage.vueNodes.getFixtureByTitle(
|
||||
'CLIP Text Encode (Prompt)'
|
||||
)
|
||||
await interiorClip.delete()
|
||||
|
||||
await comfyPage.subgraph.exitViaBreadcrumb()
|
||||
|
||||
const subgraphNodeAfter =
|
||||
comfyPage.vueNodes.getNodeLocator(subgraphNodeId)
|
||||
await expect(subgraphNodeAfter).toBeVisible()
|
||||
await expect(
|
||||
subgraphNodeAfter.getByTestId(TestIds.widgets.domWidgetTextarea)
|
||||
).toBeHidden()
|
||||
}
|
||||
)
|
||||
}
|
||||
)
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import { expect } from '@playwright/test'
|
||||
import type { Locator, Page } from '@playwright/test'
|
||||
|
||||
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
||||
|
||||
@@ -188,4 +189,79 @@ test.describe('Workflow tabs', () => {
|
||||
await topbar.closeWorkflowTab('Unsaved Workflow (2)')
|
||||
await expect.poll(() => topbar.getTabNames()).toHaveLength(2)
|
||||
})
|
||||
|
||||
test.describe('Closing a modified workflow tab (FE-419)', () => {
|
||||
async function modifyActiveWorkflow(page: Page, activeTab: Locator) {
|
||||
await page.evaluate(() => {
|
||||
const graph = window.app?.graph
|
||||
const node = window.LiteGraph?.createNode('Note')
|
||||
if (graph && node) graph.add(node)
|
||||
})
|
||||
await expect(
|
||||
activeTab.getByTestId('workflow-dirty-indicator')
|
||||
).toHaveCount(1)
|
||||
}
|
||||
|
||||
test('shows "Close anyway" label and no Cancel button on dirtyClose dialog', async ({
|
||||
comfyPage
|
||||
}) => {
|
||||
const topbar = comfyPage.menu.topbar
|
||||
|
||||
await topbar.newWorkflowButton.click()
|
||||
await expect.poll(() => topbar.getTabNames()).toHaveLength(2)
|
||||
|
||||
await modifyActiveWorkflow(comfyPage.page, topbar.getActiveTab())
|
||||
await topbar.closeWorkflowTab('Unsaved Workflow (2)')
|
||||
|
||||
const dialog = comfyPage.page.getByRole('dialog')
|
||||
await expect(dialog).toBeVisible()
|
||||
await expect(
|
||||
dialog.getByRole('button', { name: 'Close anyway' })
|
||||
).toBeVisible()
|
||||
await expect(dialog.getByRole('button', { name: 'Save' })).toBeVisible()
|
||||
await expect(dialog.getByRole('button', { name: 'Cancel' })).toHaveCount(
|
||||
0
|
||||
)
|
||||
})
|
||||
|
||||
test('clicking "Close anyway" closes the tab without saving', async ({
|
||||
comfyPage
|
||||
}) => {
|
||||
const topbar = comfyPage.menu.topbar
|
||||
|
||||
await topbar.newWorkflowButton.click()
|
||||
await expect.poll(() => topbar.getTabNames()).toHaveLength(2)
|
||||
|
||||
await modifyActiveWorkflow(comfyPage.page, topbar.getActiveTab())
|
||||
await topbar.closeWorkflowTab('Unsaved Workflow (2)')
|
||||
|
||||
await comfyPage.page
|
||||
.getByRole('dialog')
|
||||
.getByRole('button', { name: 'Close anyway' })
|
||||
.click()
|
||||
|
||||
await expect.poll(() => topbar.getTabNames()).toHaveLength(1)
|
||||
await expect
|
||||
.poll(() => topbar.getActiveTabName())
|
||||
.toContain('Unsaved Workflow')
|
||||
})
|
||||
|
||||
test('dismissing the dialog keeps the modified tab open', async ({
|
||||
comfyPage
|
||||
}) => {
|
||||
const topbar = comfyPage.menu.topbar
|
||||
|
||||
await topbar.newWorkflowButton.click()
|
||||
await expect.poll(() => topbar.getTabNames()).toHaveLength(2)
|
||||
|
||||
await modifyActiveWorkflow(comfyPage.page, topbar.getActiveTab())
|
||||
await topbar.closeWorkflowTab('Unsaved Workflow (2)')
|
||||
|
||||
await expect(comfyPage.page.getByRole('dialog')).toBeVisible()
|
||||
await comfyPage.page.keyboard.press('Escape')
|
||||
await expect(comfyPage.page.getByRole('dialog')).toBeHidden()
|
||||
|
||||
await expect.poll(() => topbar.getTabNames()).toHaveLength(2)
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
@@ -1,3 +1,5 @@
|
||||
import type { Locator } from '@playwright/test'
|
||||
|
||||
import {
|
||||
comfyExpect as expect,
|
||||
comfyPageFixture as test
|
||||
@@ -39,6 +41,19 @@ test.describe('Vue Node Moving', { tag: '@vue-nodes' }, () => {
|
||||
expect(Math.abs(a.y - b.y)).toBeLessThanOrEqual(tol)
|
||||
}
|
||||
|
||||
const dragFromTabButton = async (comfyPage: ComfyPage, button: Locator) => {
|
||||
const box = await button.boundingBox()
|
||||
if (!box) throw new Error('Tab button has no bounding box')
|
||||
const start = {
|
||||
x: box.x + box.width / 2,
|
||||
y: box.y + box.height * 0.75
|
||||
}
|
||||
await comfyPage.canvasOps.dragAndDrop(start, {
|
||||
x: start.x + 120,
|
||||
y: start.y + 80
|
||||
})
|
||||
}
|
||||
|
||||
test('should allow moving nodes by dragging', async ({ comfyPage }) => {
|
||||
const loadCheckpointHeaderPos = await getLoadCheckpointHeaderPos(comfyPage)
|
||||
await comfyPage.canvasOps.dragAndDrop(loadCheckpointHeaderPos, {
|
||||
@@ -90,6 +105,63 @@ test.describe('Vue Node Moving', { tag: '@vue-nodes' }, () => {
|
||||
await expectPosChanged(headerPos, afterPos)
|
||||
})
|
||||
|
||||
test('should not toggle advanced inputs when dragging by the Advanced button', async ({
|
||||
comfyPage
|
||||
}) => {
|
||||
await comfyPage.settings.setSetting(
|
||||
'Comfy.Node.AlwaysShowAdvancedWidgets',
|
||||
false
|
||||
)
|
||||
await comfyPage.nodeOps.addNode(
|
||||
'ModelSamplingFlux',
|
||||
{},
|
||||
{
|
||||
x: 500,
|
||||
y: 200
|
||||
}
|
||||
)
|
||||
await comfyPage.vueNodes.waitForNodes()
|
||||
|
||||
const node = comfyPage.vueNodes.getNodeByTitle('ModelSamplingFlux')
|
||||
const showButton = node.getByText('Show advanced inputs')
|
||||
const widgets = node.locator('.lg-node-widget')
|
||||
|
||||
await expect(showButton).toBeVisible()
|
||||
await expect(widgets).toHaveCount(2)
|
||||
|
||||
const beforePos = await node.boundingBox()
|
||||
if (!beforePos) throw new Error('Node has no bounding box')
|
||||
|
||||
await dragFromTabButton(comfyPage, showButton)
|
||||
|
||||
await expect(showButton).toBeVisible()
|
||||
await expect(node.getByText('Hide advanced inputs')).toBeHidden()
|
||||
await expect(widgets).toHaveCount(2)
|
||||
|
||||
const afterPos = await node.boundingBox()
|
||||
if (!afterPos) throw new Error('Node missing after drag')
|
||||
await expectPosChanged(beforePos, afterPos)
|
||||
})
|
||||
|
||||
test('should not enter subgraph when dragging by the Enter Subgraph button', async ({
|
||||
comfyPage
|
||||
}) => {
|
||||
await comfyPage.workflow.loadWorkflow('subgraphs/basic-subgraph')
|
||||
|
||||
const subgraphNode = await comfyPage.nodeOps.getNodeRefById('2')
|
||||
const beforePos = await subgraphNode.getPosition()
|
||||
|
||||
await dragFromTabButton(
|
||||
comfyPage,
|
||||
comfyPage.vueNodes.getSubgraphEnterButton('2')
|
||||
)
|
||||
|
||||
expect(await comfyPage.subgraph.isInSubgraph()).toBe(false)
|
||||
|
||||
const afterPos = await subgraphNode.getPosition()
|
||||
await expectPosChanged(beforePos, afterPos)
|
||||
})
|
||||
|
||||
test('should move all selected nodes together when dragging one with Meta held', async ({
|
||||
comfyPage
|
||||
}) => {
|
||||
|
||||
128
docs/architecture/extension-api-v2/README.md
Normal file
@@ -0,0 +1,128 @@
|
||||
# v2 Extension API — Touch-Point Database
|
||||
|
||||
This directory is the **canonical compatibility-surface map** for the upcoming
|
||||
v2 extension API redesign. Every API surface that real-world ComfyUI
|
||||
extensions touch is enumerated here, weighted by usage frequency and ecosystem
|
||||
star count, with citations to verifiable evidence (file paths and line
|
||||
numbers in real custom-node repos).
|
||||
|
||||
It exists so the v2 redesign can answer two questions deterministically:
|
||||
|
||||
1. **What will silently break?** — every entry maps to a v2 replacement (or to
|
||||
an explicit "deprecated, no replacement" decision).
|
||||
2. **What does the v2 test framework need to cover?** — every entry maps to
|
||||
≥1 test target so the test floor reflects real extension shapes.
|
||||
|
||||
## Artifacts
|
||||
|
||||
| File | Role |
|
||||
|---|---|
|
||||
| [`touch-points-plan.md`](./touch-points-plan.md) | Methodology, schema, surface-family enumeration, severity rubric |
|
||||
| [`touch-points-database.yaml`](./touch-points-database.yaml) | Source of truth — 52 patterns × 15 surface families with evidence rows |
|
||||
| [`touch-points-star-cache.yaml`](./touch-points-star-cache.yaml) | GitHub star/fork/last-commit snapshot for every cited repo (drift detection) |
|
||||
| [`touch-points-rollup.yaml`](./touch-points-rollup.yaml) | Computed blast-radius scores per pattern (sorted) — the prioritization output |
|
||||
| [`scripts/fetch-stars.sh`](./scripts/fetch-stars.sh) | Refresh the star cache via `gh api` |
|
||||
| [`scripts/rollup-blast-radius.py`](./scripts/rollup-blast-radius.py) | Recompute blast radius from database + star cache |
|
||||
| [`scripts/add-evidence.py`](./scripts/add-evidence.py) | Idempotently merge new evidence rows / new patterns into the database |
|
||||
|
||||
## The 15 surface families
|
||||
|
||||
| Family | One-liner |
|
||||
|---|---|
|
||||
| **S1** | `ComfyExtension` lifecycle hooks (`init`, `setup`, `nodeCreated`, `beforeRegisterNodeDef`, …) |
|
||||
| **S2** | `LGraphNode.prototype` methods extensions monkey-patch (`onConnectionsChange`, `onSerialize`, `onDrawForeground`, …) |
|
||||
| **S3** | `LGraphCanvas.prototype` methods extensions monkey-patch (`processKey`, `processContextMenu`, `drawNode`, …) |
|
||||
| **S4** | Widget-level patterns — `.callback` chaining, `.value` r/w, `.serializeValue`, `.options.*`, DOM widgets |
|
||||
| **S5** | `ComfyApi` / `app.api` event surfaces — execution lifecycle WebSocket events |
|
||||
| **S6** | `ComfyApp` god-object touch points — `app.graphToPrompt`, `app.queuePrompt`, `app.api.fetchApi`, … |
|
||||
| **S7** | Window / global escape hatches — `window.app`, `window.LiteGraph`, `globalThis.LGraphCanvas` |
|
||||
| **S8** | Special node properties (magic flags) — `isVirtualNode`, `serialize_widgets`, `category`, `color_on` |
|
||||
| **S9** | Non-Node entity kinds (per [ADR 0008](../decisions/0008-entity-taxonomy.md)) — subgraphs, groups, reroutes, links |
|
||||
| **S10** | Dynamic node API — `addInput` / `removeInput` / `addOutput` / `removeOutput` slot mutation at runtime |
|
||||
| **S11** | Graph-level state and change-tracking — `graph.add`, `graph.remove`, `graph.serialize`, version bumps |
|
||||
| **S12** | Shell UI registries — `extensionManager.registerSidebarTab`, bottom panel, commands, toasts |
|
||||
| **S13** | Schema interpretation — `ComfyNodeDef` / `InputSpec` consumers (validation, default values, type coercion) |
|
||||
| **S14** | Identity / Locator scheme — node IDs, slot keys, widget identity across reload |
|
||||
| **S15** | Output system — preview-image / preview-any / display-text axis (per `widget-api-thoughts.md`) |
|
||||
|
||||
Full details, schema, and severity rubric are in [`touch-points-plan.md`](./touch-points-plan.md).
|
||||
|
||||
## Top 12 patterns by blast radius
|
||||
|
||||
Computed from [`touch-points-rollup.yaml`](./touch-points-rollup.yaml). Blast
|
||||
radius is `log10(1+stars)·1.0 + log10(1+occurrences)·0.7 +
|
||||
(signature_count-1)·0.5 + silent_breakage·0.5 + lifecycle_coupling·0.4`.
|
||||
|
||||
| Rank | BR | ★ sum | occ | sig | Pattern | Surface |
|
||||
|---:|---:|---:|---:|---:|---|---|
|
||||
| 1 | 6.67 | 17 101 | 7 | 1 | `S6.A1` | `app.graphToPrompt` monkey-patching ⚠️ CRITICAL |
|
||||
| 2 | 5.42 | 2 567 | 1 | 1 | `S9.SG1` | Subgraph "set/get virtual node" pattern (KJNodes-style) |
|
||||
| 3 | 5.27 | 4 314 | 4 | 1 | `S11.G2` | `graph.add` / `graph.remove` / `graph.findNodesByType` / `graph.findNodeById` / `graph.serialize` / `graph.configure` |
|
||||
| 4 | 5.23 | 1 808 | 3 | 1 | `S10.D1` | `node.addInput` / `node.removeInput` / `node.addOutput` / `node.removeOutput` dynamic slot mutation |
|
||||
| 5 | 5.18 | 3 049 | 5 | 1 | `S2.N13` | `nodeType.prototype.onConnectOutput` patching |
|
||||
| 6 | 5.08 | 6 147 | 4 | 1 | `S4.W2` | `node.addDOMWidget(name, type, element, options)` |
|
||||
| 7 | 5.01 | 412 | 6 | 1 | `S2.N15` | `nodeType.prototype.serialize` / `node.serialize` direct method patching |
|
||||
| 8 | 4.89 | 1 789 | 4 | 1 | `S2.N14` | `nodeType.prototype.onWidgetChanged` patching |
|
||||
| 9 | 4.89 | 7 932 | 6 | 1 | `S2.N4` | `nodeType.prototype.onRemoved` patching (de-facto teardown) |
|
||||
| 10 | 4.66 | 1 837 | 6 | 1 | `S4.W3` | `widget.serializeValue` direct assignment |
|
||||
| 11 | 4.61 | 1 788 | 1 | 1 | `S2.N12` | `nodeType.prototype.onConnectInput` patching |
|
||||
| 12 | 4.55 | 1 793 | 5 | 1 | `S6.A3` | `api.fetchApi` — extensions hit backend HTTP endpoints |
|
||||
|
||||
The top three pattern categories — graph mutation (`S11.G2`, `S10.D1`),
|
||||
prototype patching (`S2.*`), and the `app.graphToPrompt` god-object — together
|
||||
account for the majority of the blast radius and define the v2 API's
|
||||
non-negotiable compatibility surfaces.
|
||||
|
||||
## Refresh workflow
|
||||
|
||||
The database is curated by hand; the star cache and rollup are derived.
|
||||
|
||||
```bash
|
||||
# from this directory
|
||||
bash scripts/fetch-stars.sh # refresh GitHub stars (needs `gh` auth)
|
||||
python3 scripts/rollup-blast-radius.py # recompute touch-points-rollup.yaml
|
||||
```
|
||||
|
||||
To add new evidence or new patterns discovered during a future MCP
|
||||
code-search sweep, edit `scripts/add-evidence.py` (the inline `APPEND` and
|
||||
`NEW_PATTERNS` blocks are the source of truth for reproducibility) and run:
|
||||
|
||||
```bash
|
||||
python3 scripts/add-evidence.py
|
||||
python3 scripts/rollup-blast-radius.py
|
||||
```
|
||||
|
||||
## Source documents
|
||||
|
||||
The 52 patterns were derived from three primary inputs, then expanded by an
|
||||
MCP code-search sweep across 87 ecosystem repos:
|
||||
|
||||
1. **`AGENTS.md` §5** in this repo — 40+ repo callouts for contributor
|
||||
conventions and known extension surfaces.
|
||||
2. **[ADR 0008 — Entity Taxonomy](../decisions/0008-entity-taxonomy.md)** —
|
||||
defines the non-Node entity kinds (subgraphs, groups, reroutes, links)
|
||||
that drive surface family **S9**.
|
||||
3. **`widget-api-thoughts.md`** (in the cross-repo workspace) — the output
|
||||
system axis and widget lifecycle dependencies that drive surface family
|
||||
**S15** plus the lifecycle-coupling weight.
|
||||
|
||||
## Cross-references
|
||||
|
||||
This database is consumed by, and consumes, the rest of the ECS architecture
|
||||
docs:
|
||||
|
||||
- [`../ecs-target-architecture.md`](../ecs-target-architecture.md) — the
|
||||
target ECS shape this v2 API redesign serves
|
||||
- [`../ecs-world-command-api.md`](../ecs-world-command-api.md) — the World /
|
||||
Command API that v2 extensions will program against
|
||||
- [`../ecs-migration-plan.md`](../ecs-migration-plan.md) — how we get from
|
||||
today's monkey-patched LiteGraph to v2 + ECS
|
||||
- [`../ecs-lifecycle-scenarios.md`](../ecs-lifecycle-scenarios.md) — the
|
||||
lifecycle scenarios the test framework must cover (every touch-point row
|
||||
here ⇒ ≥1 scenario there)
|
||||
- [`../entity-interactions.md`](../entity-interactions.md) /
|
||||
[`../entity-problems.md`](../entity-problems.md) — the entity-model
|
||||
problems v2 must not perpetuate
|
||||
- [`../change-tracker.md`](../change-tracker.md) — the change-tracking
|
||||
contract that S11 (graph state) and S2 (`onSerialize`/`onDeserialize`
|
||||
patches) must remain compatible with
|
||||
265
docs/architecture/extension-api-v2/scripts/add-evidence-pass2.py
Normal file
@@ -0,0 +1,265 @@
|
||||
#!/usr/bin/env python3
|
||||
# add-evidence-pass2.py — second MCP sweep. Appends evidence to under-evidenced
|
||||
# patterns and adds new patterns discovered in pass-2 (graph batching seam,
|
||||
# window.* globals, setDirtyCanvas redraw idiom).
|
||||
#
|
||||
# Idempotent: skips evidence already present (matched by repo+file+lines).
|
||||
#
|
||||
# Run: python3 scripts/add-evidence-pass2.py
|
||||
|
||||
from pathlib import Path
|
||||
|
||||
import yaml
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
DB = ROOT / "research" / "touch-points" / "database.yaml"
|
||||
|
||||
|
||||
def url(repo: str, file: str, line: int) -> str:
|
||||
return f"https://github.com/{repo}/blob/main/{file}#L{line}"
|
||||
|
||||
|
||||
def ev(repo, file, lines, **kw):
|
||||
e = {
|
||||
"repo": repo,
|
||||
"file": file,
|
||||
"lines": lines if isinstance(lines, list) else [lines],
|
||||
"url": url(repo, file, lines if isinstance(lines, int) else lines[0]),
|
||||
}
|
||||
e.update(kw)
|
||||
return e
|
||||
|
||||
|
||||
# ─── Evidence to append to existing patterns ──────────────────────────────
|
||||
APPEND = {
|
||||
"S2.N17": [ # onSelected / onDeselected
|
||||
ev("nodelee733/ComfyUI-mxToolkit", "js/Slider.js", 1, variant="prototype-patch", breakage_class="silent",
|
||||
notes="mxToolkit Slider patches onSelected for highlight state"),
|
||||
ev("nodelee733/ComfyUI-mxToolkit", "js/Slider2D.js", 1, variant="prototype-patch", breakage_class="silent"),
|
||||
],
|
||||
"S2.N19": [ # onResize
|
||||
ev("SKBv0/ComfyUI_SKBundle", "js/MultiFloat.js", 1, variant="prototype-patch", breakage_class="silent",
|
||||
notes="MultiFloat widget syncs internal layout on resize"),
|
||||
ev("PGCRT/CRT-Nodes", "js/Magic_Lora_Loader.js", 1, variant="prototype-patch", breakage_class="silent"),
|
||||
ev("dorpxam/ComfyUI-LTX2-Microscope", "web/js/ui/visualizer.js", 1, variant="prototype-patch", breakage_class="silent",
|
||||
notes="visualizer reflows DOM widget on resize"),
|
||||
],
|
||||
"S9.R1": [ # Reroute manipulation
|
||||
ev("linjm8780860/ljm_comfyui", "src/utils/vintageClipboard.ts", 1, variant="graph.reroutes.values()", breakage_class="loud",
|
||||
notes="iterates reroute map directly — fork of frontend, but represents real internal contract surface"),
|
||||
ev("nodetool-ai/nodetool", "subgraphs.md", [1, 50], variant="documented-pattern", breakage_class="loud",
|
||||
notes="external doc treats graph.reroutes as part of subgraph contract"),
|
||||
],
|
||||
"S9.SG1": [ # Set/Get virtual node
|
||||
ev("krismasdev/ComfyUI-Flux-Continuum", "web/hint.js", 1, variant="virtual-node-companion", breakage_class="silent",
|
||||
notes="Flux Continuum hint system depends on Set/Get virtual node graph"),
|
||||
ev("SpaceWarpStudio/ComfyUI-SetInputGetOutput", "web/js/setinputgetoutput.js", 1, variant="full-implementation",
|
||||
breakage_class="loud", notes="another SetInput/GetOutput pack — variant of KJNodes pattern"),
|
||||
],
|
||||
"S13.SC1": [ # ComfyNodeDef inspection
|
||||
ev("xeinherjer-dev/ComfyUI-XENodes", "web/js/combo_selector.js", 1, variant="nodeData.input.optional",
|
||||
breakage_class="silent", notes="reads nodeData.input.optional to drive UI generation"),
|
||||
ev("StableLlama/ComfyUI-basic_data_handling", "web/js/dynamicnode.js", 1, variant="nodeData.input.optional",
|
||||
breakage_class="silent"),
|
||||
ev("IXIWORKS-KIMJUNGHO/comfyui-ixiworks-tools", "js/sb_concat.js", 1, variant="nodeData.input.optional",
|
||||
breakage_class="silent"),
|
||||
ev("BennyKok/comfyui-deploy", "web-plugin/index.js", 1, variant="nodeData.input.required",
|
||||
breakage_class="silent", notes="comfyui-deploy is widely used; treats schema as a public contract"),
|
||||
ev("egormly/ComfyUI-EG_Tools", "web/dynamic_inputs.js", 1, variant="nodeData.input.optional",
|
||||
breakage_class="silent"),
|
||||
],
|
||||
"S3.C1": [ # LGraphCanvas.prototype.* monkey-patching — drawNodeShape variant
|
||||
ev("yolain/ComfyUI-Easy-Use-Frontend", "src/extensions/ui.js", 1, variant="drawNodeShape-patch",
|
||||
breakage_class="silent", notes="Easy-Use is a major pack; patches LGraphCanvas.prototype.drawNodeShape"),
|
||||
ev("melMass/comfy_mtb", "web/note_plus.js", 1, variant="canvas-draw-patch", breakage_class="silent",
|
||||
notes="comfy_mtb (popular pack) — note_plus draws decorations via canvas patching"),
|
||||
ev("lucafoscili/lf-nodes", "web/src/nodes/reroute.ts", 1, variant="onDrawForeground+canvas-draw",
|
||||
breakage_class="silent"),
|
||||
ev("krismasdev/ComfyUI-Flux-Continuum", "web/outputgetnode.js", 1, variant="onDrawForeground",
|
||||
breakage_class="silent"),
|
||||
],
|
||||
"S10.D2": [ # disconnectInput / disconnectOutput / connect
|
||||
ev("MockbaTheBorg/ComfyUI-Mockba", "js/slider.js", 1, variant="programmatic-disconnect",
|
||||
breakage_class="loud", notes="app.graph.getNodeById(tlink.target_id).disconnectInput(tlink.target_slot)"),
|
||||
ev("vjumpkung/comfyui-infinitetalk-native-sampler", "README.md", [1, 50], variant="documented-as-API",
|
||||
breakage_class="loud", notes="3rd-party docs treat node.disconnect* as a stable extension surface"),
|
||||
],
|
||||
"S8.P1": [ # isVirtualNode = true
|
||||
ev("ComfyNodePRs/PR-comfyui-pkg39-ccab78b5", "js/libs/image.js", [541, 1382], variant="filter-by-virtual",
|
||||
breakage_class="loud", notes="extension code filters nodes by isVirtualNode — treats it as discovery API"),
|
||||
],
|
||||
}
|
||||
|
||||
|
||||
# ─── Brand-new patterns discovered in pass-2 ──────────────────────────────
|
||||
NEW_PATTERNS = [
|
||||
{
|
||||
"pattern_id": "S11.G3",
|
||||
"surface_family": "S11",
|
||||
"surface": "graph.beforeChange / graph.afterChange — explicit batching seam for multi-step mutations",
|
||||
"fingerprint": "graph.beforeChange(); ...mutations...; graph.afterChange();",
|
||||
"semantic": (
|
||||
"extensions wrap multi-node/multi-link mutations in beforeChange/afterChange so undo, "
|
||||
"dirty-tracking, and re-render coalesce around the batch instead of per-mutation"
|
||||
),
|
||||
"v2_replacement": "world.batch(() => { ...mutations... }) — typed batching API",
|
||||
"decision_ref": (
|
||||
"First-class batching is required for any reactive layer that wants stable diffs; "
|
||||
"v2 should expose this as a mandatory wrapper for multi-mutation operations"
|
||||
),
|
||||
"test_target": "GRAPH_BATCH_BOUNDARY",
|
||||
"lifecycle_coupling": 1,
|
||||
"severity": "HIGH",
|
||||
"evidence_status": "swept",
|
||||
"evidence": [
|
||||
ev("nodetool-ai/nodetool", "subgraphs.md", [1, 50], variant="documented-pattern", breakage_class="loud",
|
||||
notes="docs use beforeChange/afterChange around subgraph promotion"),
|
||||
ev("linjm8780860/ljm_comfyui", "src/utils/vintageClipboard.ts", 1, variant="paste-undo-batch",
|
||||
breakage_class="loud", notes="paste flow batches mutations across clipboard restore"),
|
||||
],
|
||||
},
|
||||
{
|
||||
"pattern_id": "S7.G1",
|
||||
"surface_family": "S7",
|
||||
"surface": "window.LiteGraph / window.comfyAPI.* — globals as public surface",
|
||||
"fingerprint": "window.LiteGraph.createNode(...); window.comfyAPI.app.app",
|
||||
"semantic": (
|
||||
"extensions reach into the global namespace for LiteGraph constructors/enums or for the "
|
||||
"module-as-global comfyAPI registry. This is the closest thing to a 'public ABI' today"
|
||||
),
|
||||
"v2_replacement": (
|
||||
"explicit `import { app, graph, LiteGraph } from '@comfy/extension'` + a typed registry "
|
||||
"keyed by extension name; window.* should remain as a deprecated read-only mirror"
|
||||
),
|
||||
"decision_ref": (
|
||||
"Cannot break window.LiteGraph immediately — too much ecosystem code reaches for it. "
|
||||
"Must ship typed import path first, then deprecate. Similar story to S11.G2 graph globals."
|
||||
),
|
||||
"test_target": "GLOBAL_NAMESPACE_COMPAT",
|
||||
"lifecycle_coupling": 0,
|
||||
"severity": "CRITICAL",
|
||||
"evidence_status": "swept",
|
||||
"evidence": [
|
||||
ev("krismasdev/ComfyUI-Flux-Continuum", "web/hint.js", 1, variant="window.LiteGraph",
|
||||
breakage_class="loud"),
|
||||
ev("SpaceWarpStudio/ComfyUI-SetInputGetOutput", "web/js/setinputgetoutput.js", 1,
|
||||
variant="window.LiteGraph", breakage_class="loud"),
|
||||
ev("ArtHommage/HommageTools", "web/js/index.js", 1, variant="window.LiteGraph", breakage_class="loud"),
|
||||
ev("PROJECTMAD/PROJECT-MAD-NODES", "web/js/index.js", 1, variant="window.LiteGraph", breakage_class="loud"),
|
||||
ev("ryanontheinside/ComfyUI_RyanOnTheInside", "web/js/index.js", 1, variant="window.LiteGraph",
|
||||
breakage_class="loud"),
|
||||
ev("stavzszn/comfyui-teskors-utils", "web/js/index.js", 1, variant="window.LiteGraph",
|
||||
breakage_class="loud"),
|
||||
],
|
||||
},
|
||||
{
|
||||
"pattern_id": "S11.G4",
|
||||
"surface_family": "S11",
|
||||
"surface": "graph.setDirtyCanvas(true, true) — imperative canvas-redraw trigger",
|
||||
"fingerprint": "node.graph?.setDirtyCanvas?.(true, true); app.graph.setDirtyCanvas(true, true);",
|
||||
"semantic": (
|
||||
"after any imperative mutation extensions call setDirtyCanvas to force a redraw — the "
|
||||
"ecosystem's de-facto 'reactivity flush' primitive. v2 reactivity should make this unnecessary"
|
||||
),
|
||||
"v2_replacement": (
|
||||
"implicit — reactive system schedules redraw automatically when tracked entity mutates. "
|
||||
"Provide an escape hatch `world.markDirty()` only for non-reactive third-party canvas use"
|
||||
),
|
||||
"decision_ref": (
|
||||
"Replacing this surface is the strongest evidence that v2 reactivity actually buys something. "
|
||||
"Should be in v2 'value proposition' demo extension"
|
||||
),
|
||||
"test_target": "REDRAW_NO_LONGER_NEEDED",
|
||||
"lifecycle_coupling": 0,
|
||||
"severity": "MEDIUM",
|
||||
"evidence_status": "swept",
|
||||
"evidence": [
|
||||
ev("AlexZ1967/ComfyUI_ALEXZ_tools", "web/video_cut_match_upload.js", 111,
|
||||
variant="post-mutation-redraw", breakage_class="silent"),
|
||||
ev("AlexZ1967/ComfyUI_ALEXZ_tools", "web/widget_visibility_profiles.js", 285,
|
||||
variant="post-mutation-redraw", breakage_class="silent"),
|
||||
ev("AlexZ1967/ComfyUI_ALEXZ_tools", "web/ui/module_node_picker_node_factory.js", 189,
|
||||
variant="post-mutation-redraw", breakage_class="silent"),
|
||||
ev("akawana/ComfyUI-Folded-Prompts", "js/FPFoldedPrompts.js", [776, 1087],
|
||||
variant="post-mutation-redraw", breakage_class="silent",
|
||||
notes="multiple call sites — extension assumes manual flush is the contract"),
|
||||
],
|
||||
},
|
||||
{
|
||||
"pattern_id": "S10.D3",
|
||||
"surface_family": "S10",
|
||||
"surface": "node.setSize(node.computeSize()) — imperative resize after dynamic mutation",
|
||||
"fingerprint": "node.setSize?.(node.computeSize())",
|
||||
"semantic": (
|
||||
"after dynamic widget/input/output mutation, extensions manually call computeSize+setSize "
|
||||
"to reflow the node. Companion to S2.N11 (computeSize override) and S11.G4 (setDirtyCanvas)"
|
||||
),
|
||||
"v2_replacement": (
|
||||
"automatic — reactive layout system recomputes node size when widget/slot collection changes. "
|
||||
"Expose `nodeHandle.requestLayout()` only as escape hatch"
|
||||
),
|
||||
"decision_ref": "Pairs with S11.G4 — both are 'manual flush' idioms that v2 should obviate",
|
||||
"test_target": "AUTO_RELAYOUT_ON_MUTATION",
|
||||
"lifecycle_coupling": 0,
|
||||
"severity": "MEDIUM",
|
||||
"evidence_status": "swept",
|
||||
"evidence": [
|
||||
ev("AlexZ1967/ComfyUI_ALEXZ_tools", "web/widget_visibility_profiles.js", 283,
|
||||
variant="setSize+computeSize", breakage_class="silent",
|
||||
notes="exact 'node.setSize?.(node.computeSize())' canonical idiom"),
|
||||
ev("zhupeter010903/ComfyUI-XYZ-prompt-library", "js/prompt_library_node.js", 466,
|
||||
variant="manual-height", breakage_class="silent",
|
||||
notes="commented-out manual setSize — shows the pattern is well-known"),
|
||||
],
|
||||
},
|
||||
]
|
||||
|
||||
|
||||
def normalize_evidence_key(e):
|
||||
return (e.get("repo"), e.get("file"), tuple(e.get("lines") or []))
|
||||
|
||||
|
||||
def main():
|
||||
db = yaml.safe_load(DB.read_text())
|
||||
|
||||
appended = 0
|
||||
skipped = 0
|
||||
for pid, new_evs in APPEND.items():
|
||||
for p in db["patterns"]:
|
||||
if p["pattern_id"] == pid:
|
||||
if "evidence" not in p or p["evidence"] is None:
|
||||
p["evidence"] = []
|
||||
existing = {normalize_evidence_key(e) for e in p["evidence"]}
|
||||
for e in new_evs:
|
||||
if normalize_evidence_key(e) in existing:
|
||||
skipped += 1
|
||||
continue
|
||||
p["evidence"].append(e)
|
||||
appended += 1
|
||||
p["evidence_status"] = "swept"
|
||||
break
|
||||
else:
|
||||
print(f"⚠️ pattern {pid} not found")
|
||||
|
||||
added_new = 0
|
||||
existing_ids = {p["pattern_id"] for p in db["patterns"]}
|
||||
for np in NEW_PATTERNS:
|
||||
if np["pattern_id"] in existing_ids:
|
||||
print(f"⚠️ pattern {np['pattern_id']} already exists — skipping")
|
||||
continue
|
||||
db["patterns"].append(np)
|
||||
added_new += 1
|
||||
|
||||
db["meta"]["patterns_count"] = len(db["patterns"])
|
||||
db["meta"]["sweep_status"] = "in-progress"
|
||||
if "evidence-sweep-pass-2" not in db["meta"].get("sweeps_done", []):
|
||||
db["meta"]["sweeps_done"].append("evidence-sweep-pass-2")
|
||||
|
||||
DB.write_text(yaml.safe_dump(db, sort_keys=False, width=200, allow_unicode=True))
|
||||
print(f"✅ appended {appended} evidence rows ({skipped} dupes skipped)")
|
||||
print(f"✅ added {added_new} new patterns")
|
||||
print(f"✅ DB now has {len(db['patterns'])} patterns")
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
213
docs/architecture/extension-api-v2/scripts/add-evidence.py
Normal file
@@ -0,0 +1,213 @@
|
||||
#!/usr/bin/env python3
|
||||
# add-evidence.py — append evidence to existing patterns and add NEW patterns
|
||||
# discovered during the MCP sweep. Idempotent: skips evidence already present
|
||||
# (matched by repo+file+lines).
|
||||
#
|
||||
# Run: python3 scripts/add-evidence.py
|
||||
#
|
||||
# Source-of-truth for evidence is inline below — keeping it in version
|
||||
# control makes the sweep reproducible and reviewable.
|
||||
|
||||
from pathlib import Path
|
||||
|
||||
import yaml
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
DB = ROOT / "touch-points-database.yaml"
|
||||
|
||||
|
||||
def url(repo: str, file: str, line: int) -> str:
|
||||
return f"https://github.com/{repo}/blob/main/{file}#L{line}"
|
||||
|
||||
|
||||
def ev(repo, file, lines, **kw):
|
||||
e = {
|
||||
"repo": repo,
|
||||
"file": file,
|
||||
"lines": lines if isinstance(lines, list) else [lines],
|
||||
"url": url(repo, file, lines if isinstance(lines, int) else lines[0]),
|
||||
}
|
||||
e.update(kw)
|
||||
return e
|
||||
|
||||
|
||||
# ─── Evidence to merge into existing patterns ─────────────────────────────
|
||||
APPEND = {
|
||||
"S2.N12": [
|
||||
# already has core dynamicWidgets entry
|
||||
],
|
||||
"S2.N13": [
|
||||
ev("rgthree/rgthree-comfy", "web/comfyui/node_mode_relay.js", [90, 92], variant="subclass-override", breakage_class="loud", notes="rgthree — major pack. Subclass override pattern (calls super)."),
|
||||
ev("rgthree/rgthree-comfy", "web/comfyui/node_mode_repeater.js", [21, 24], variant="subclass-override", breakage_class="loud"),
|
||||
ev("rgthree/rgthree-comfy", "src_web/comfyui/node_mode_relay.ts", [146, 153], variant="subclass-override-ts", breakage_class="loud"),
|
||||
ev("rgthree/rgthree-comfy", "src_web/comfyui/node_mode_repeater.ts", [46, 56], variant="subclass-override-ts", breakage_class="loud"),
|
||||
ev("rgthree/rgthree-comfy", "web/comfyui/base_any_input_connected_node.js", [136, 138], variant="subclass-override", breakage_class="loud"),
|
||||
],
|
||||
"S2.N14": [
|
||||
ev("niknah/presentation-ComfyUI", "js/PresentationDropDown.js", [12, 75], variant="prototype-chain", breakage_class="silent", notes="captures original onWidgetChanged via prototype chain"),
|
||||
ev("chyer/Chye-ComfyUI-Toolset", "web/comfyui/text_file_loader.js", [35, 115], variant="instance-method", breakage_class="silent"),
|
||||
],
|
||||
"S2.N15": [
|
||||
ev("Azornes/Comfyui-LayerForge", "js/CanvasView.js", 1438, variant="prototype-replace", breakage_class="silent", notes="LayerForge (313★) — replaces serialize wholesale"),
|
||||
ev("Azornes/Comfyui-LayerForge", "src/CanvasView.ts", 1657, variant="prototype-replace-ts", breakage_class="silent"),
|
||||
ev("IAMCCS/IAMCCS-nodes", "web/iamccs_wan_motion_presets.js", 598, variant="prototype-replace", breakage_class="silent"),
|
||||
ev("IAMCCS/IAMCCS-nodes", "web/iamccs_ltx2_extension_presets.js", 350, variant="prototype-replace", breakage_class="silent"),
|
||||
ev("DazzleNodes/ComfyUI-Smart-Resolution-Calc", "web/utils/serialization.js", 32, variant="prototype-replace", breakage_class="silent"),
|
||||
ev("alankent/ComfyUI-OA-360-Clip", "web/oa_360_clip.js", 900, variant="prototype-replace", breakage_class="silent"),
|
||||
],
|
||||
"S2.N16": [
|
||||
ev("krismasdev/ComfyUI-Flux-Continuum", "web/outputgetnode.js", 328, variant="push", breakage_class="silent", notes="extension pushes to node.widgets directly"),
|
||||
ev("max-dingsda/ComfyUI-AllinOne-LazyNode", "web/js/aio_core_preview.js", 170, variant="push", breakage_class="silent"),
|
||||
ev("r-vage/ComfyUI_Eclipse", "js/eclipse-set-get.js", 9, variant="indexed-read", breakage_class="loud", notes="reads node.widgets[0].value to get name"),
|
||||
ev("r-vage/ComfyUI_Eclipse", "js/eclipse-load-image.js", 56, variant="indexOf", breakage_class="loud"),
|
||||
ev("viswamohankomati/ComfyUI-Copilot", "ComfyUI/custom_nodes/ComfyUI-Copilot/ui/src/utils/comfyuiWorkflowApi2Ui.ts", [305, 316], variant="widgets_values-push", breakage_class="silent", notes="touches node.widgets_values, the serialized array"),
|
||||
],
|
||||
"S11.G1": [
|
||||
ev("FloyoAI/ComfyUI-SoundFlow", "js/PreviewAudio.js", 293, variant="post-mutation-bump", breakage_class="silent", notes="bumps version after node-internal mutation to trigger redraw"),
|
||||
ev("krismasdev/ComfyUI-Flux-Continuum", "web/outputgetnode.js", 84, variant="post-mutation-bump", breakage_class="silent"),
|
||||
ev("coeuskoalemoss/comfyUI-layerstyle-custom", "js/dz_mtb_widgets.js", 292, variant="post-mutation-bump", breakage_class="silent"),
|
||||
ev("40740/ComfyUI_LayerStyle_Bmss", "js/dz_mtb_widgets.js", 292, variant="post-mutation-bump", breakage_class="silent", notes="duplicate-of-coeuskoalemoss pattern — fork"),
|
||||
],
|
||||
"S11.G2": [
|
||||
ev("yolain/ComfyUI-Easy-Use", "web_version/v1/js/easy/easyExtraMenu.js", 439, variant="add+createNode", breakage_class="loud", notes="Easy-Use is a major pack; uses graph.add(LiteGraph.createNode(...))"),
|
||||
ev("KumihoIO/kumiho-plugins", "comfyui/web/js/kumiho.js", 431, variant="add+createNode", breakage_class="loud"),
|
||||
ev("r-vage/ComfyUI_Eclipse", "js/eclipse-ui-enhancements.js", 29, variant="remove-then-add", breakage_class="loud", notes="swap nodes by remove+add — preserves layout via savedProps"),
|
||||
ev("Comfy-Org/ComfyUI_frontend", "browser_tests/tests/workflowPersistence.spec.ts", [351, 413], variant="add+createNode", breakage_class="loud", notes="OUR OWN E2E TESTS rely on window.app.graph.add(window.LiteGraph.createNode(...))"),
|
||||
],
|
||||
"S12.UI1": [
|
||||
ev("robertvoy/ComfyUI-Distributed", "web/main.js", [269, 270], variant="extensionManager.registerSidebarTab", breakage_class="loud", notes="real call site for sidebar registration"),
|
||||
ev("criskb/Comfypencil", "web/comfy_pencil_extension.js", [955, 956], variant="extensionManager.registerSidebarTab", breakage_class="loud"),
|
||||
ev("maxi45274/ComfyUI_LinkFX", "js/LinkFX.js", [707, 709], variant="extensionManager.registerSidebarTab", breakage_class="loud"),
|
||||
],
|
||||
"S10.D1": [
|
||||
ev("zhupeter010903/ComfyUI-XYZ-prompt-library", "js/node.js", [18, 53], variant="dynamic-addInput-loop", breakage_class="loud", notes="real-world dynamic input expansion: this.addInput('infix '+i,'STRING')"),
|
||||
ev("r-vage/ComfyUI_Eclipse", "js/eclipse-mode-nodes.js", [42, 106], variant="virtual-node-setup", breakage_class="loud", notes="Eclipse uses addOutput within isVirtualNode setup"),
|
||||
ev("Comfy-Org/ComfyUI_frontend", "src/lib/litegraph/src/canvas/LinkConnector.core.test.ts", [121, 158], variant="OUR-TESTS", breakage_class="loud", notes="OUR OWN TESTS depend on addOutput"),
|
||||
],
|
||||
"S9.S1": [
|
||||
ev("lordwedggie/xcpNodes", "js/xcpDerpINT.js", 162, variant="output-color_on-assignment", breakage_class="silent", notes="this.outputs[0].color_on = templateSlotColorOn — direct slot visual override"),
|
||||
ev("nodetool-ai/nodetool", "subgraphs.md", [267, 299], variant="documented-pattern", breakage_class="loud", notes="external docs reference color_on for subgraph slot inheritance"),
|
||||
],
|
||||
"S4.W4": [
|
||||
ev("AlexZ1967/ComfyUI_ALEXZ_tools", "web/video_cut_match_upload.js", [24, 27], variant="includes-then-push", breakage_class="silent", notes="checks values then mutates"),
|
||||
ev("zzggi2024/shaobkj", "js/dynamic_inputs.js", [374, 376], variant="snapshot-then-mutate", breakage_class="silent", notes="saves __originalValues snapshot before mutating widget.options.values"),
|
||||
ev("EnragedAntelope/EA_LMStudio", "web/ea_lmstudio.js", 11, variant="documented-fallback", breakage_class="loud", notes="explicit comment: 'Legacy LiteGraph frontend: full support via widget.options.values'"),
|
||||
],
|
||||
}
|
||||
|
||||
|
||||
# ─── Brand-new patterns discovered during sweep ───────────────────────────
|
||||
NEW_PATTERNS = [
|
||||
{
|
||||
"pattern_id": "S6.A3",
|
||||
"surface_family": "S6",
|
||||
"surface": "api.fetchApi — extensions hit backend HTTP endpoints",
|
||||
"fingerprint": "await api.fetchApi('/upload/image', { method: 'POST', body: data })",
|
||||
"semantic": "extensions call ComfyAPI.fetchApi as the canonical way to reach backend HTTP routes (auth, base URL, error handling all handled)",
|
||||
"v2_replacement": "ctx.api.fetch(path, init) typed wrapper; same semantics, narrower surface",
|
||||
"decision_ref": "Pattern is widely used and CORRECT — keep contract, just type it",
|
||||
"test_target": "BACKEND_HTTP_CLIENT",
|
||||
"lifecycle_coupling": 0,
|
||||
"severity": "HIGH",
|
||||
"evidence_status": "swept",
|
||||
"evidence": [
|
||||
ev("AlexZ1967/ComfyUI_ALEXZ_tools", "web/video_cut_match_upload.js", 54, variant="POST-multipart", breakage_class="loud"),
|
||||
ev("AlexZ1967/ComfyUI_ALEXZ_tools", "web/api/module_node_picker_api.js", 43, variant="generic-wrapper", breakage_class="loud"),
|
||||
ev("akawana/ComfyUI-Folded-Prompts", "js/FPFoldedPrompts.js", 1227, variant="POST-upload", breakage_class="loud"),
|
||||
ev("zhupeter010903/ComfyUI-XYZ-prompt-library", "js/prompt_library_window.js", 1379, variant="GET", breakage_class="loud"),
|
||||
ev("Comfy-Org/ComfyUI_frontend", "src/components/common/BackgroundImageUpload.vue", 61, variant="POST-upload", breakage_class="loud", notes="OUR OWN UI uses api.fetchApi for image upload"),
|
||||
],
|
||||
},
|
||||
{
|
||||
"pattern_id": "S6.A4",
|
||||
"surface_family": "S6",
|
||||
"surface": "app.queuePrompt / app.api.queuePrompt patching or direct call",
|
||||
"fingerprint": "const orig = window.app.api.queuePrompt; window.app.api.queuePrompt = async function(...args) {...; return orig(...args)}",
|
||||
"semantic": "intercept or trigger workflow execution; auth tokens, custom payload mutation, sidebar 'Run' buttons",
|
||||
"v2_replacement": "graph.run({ batch }) explicit API + app.on('beforeRun', payload => mutate(payload))",
|
||||
"decision_ref": "Pairs with S6.A1 graphToPrompt as the OTHER half of the execute-pipeline interception story",
|
||||
"test_target": "PROMPT_QUEUE_INTERCEPT",
|
||||
"lifecycle_coupling": 2,
|
||||
"severity": "CRITICAL",
|
||||
"evidence_status": "swept",
|
||||
"evidence": [
|
||||
ev("gigici/ComfyUI_BlendPack", "js/ui/NodeUI.js", 99, variant="bind-then-replace", breakage_class="silent", notes="window.app.api.queuePrompt?.bind(window.app.api) — patches the API-level queue"),
|
||||
ev("MajoorWaldi/ComfyUI-Majoor-AssetsManager", "js/features/viewer/workflowSidebar/sidebarRunButton.js", [317, 321], variant="multi-path-fallback", breakage_class="loud", notes="documents 4 distinct invocation paths: app.api.queuePrompt, app.queuePrompt, fetch /prompt, etc."),
|
||||
ev("rohapa/comfyui-replay", "README.md", [497, 975], variant="call+fallback", breakage_class="loud", notes="app.queuePrompt(0,1) with raw fetch /prompt fallback"),
|
||||
],
|
||||
},
|
||||
{
|
||||
"pattern_id": "S5.A3",
|
||||
"surface_family": "S5",
|
||||
"surface": "api.addEventListener('execution_start' | 'execution_success' | 'execution_error' | 'execution_cached' | 'executing' | 'status' | 'reconnecting')",
|
||||
"fingerprint": "api.addEventListener('execution_start', e => ...)",
|
||||
"semantic": "extensions subscribe to backend execution lifecycle WebSocket events",
|
||||
"v2_replacement": "ctx.execution.on('start' | 'success' | 'error' | 'cached', payload => ...) typed events",
|
||||
"decision_ref": "Cross-references S5.A1 (existence-proof of events-everywhere)",
|
||||
"test_target": "EXECUTION_LIFECYCLE_EVENTS",
|
||||
"lifecycle_coupling": 0,
|
||||
"severity": "HIGH",
|
||||
"evidence_status": "swept",
|
||||
"evidence": [
|
||||
ev("zzw5516/ComfyUI-zw-tools", "entry/entry.js", [27, 28], variant="execution_start", breakage_class="loud"),
|
||||
ev("flymyd/koishi-plugin-comfyui-client", "src/ComfyUINode.ts", 109, variant="execution_start-case", breakage_class="loud"),
|
||||
ev("kyuz0/amd-strix-halo-comfyui-toolboxes", "scripts/benchmark_workflows.py", 52, variant="execution_start-message-type", breakage_class="loud"),
|
||||
ev("philippjbauer/devint25-comfyui-api-demo", "README.md", [144, 179], variant="documented-event-list", breakage_class="loud"),
|
||||
ev("philippjbauer/devint25-comfyui-api-demo", "Models/ComfyModels.cs", 159, variant="enum-of-event-names", breakage_class="loud", notes="C# wrapper enumerates the WebSocket event vocabulary as the public API"),
|
||||
ev("huafitwjb/ComfyUI-GO-Mobile-app", "app/src/main/java/com/example/myapplication/util/Constants.kt", 26, variant="execution_success-const", breakage_class="loud"),
|
||||
ev("hernantech/comfymcp", "src/comfymcp/client/types.py", 17, variant="execution_success-enum", breakage_class="loud"),
|
||||
ev("choovin/comfyui-api", "README.md", [57, 1945], variant="execution_success-doc", breakage_class="loud", notes="explicit 'Sidecar-like tracing' depending on execution_* events as public API"),
|
||||
],
|
||||
},
|
||||
]
|
||||
|
||||
|
||||
def normalize_evidence_key(e):
|
||||
return (e.get("repo"), e.get("file"), tuple(e.get("lines") or []))
|
||||
|
||||
|
||||
def main():
|
||||
db = yaml.safe_load(DB.read_text())
|
||||
|
||||
appended = 0
|
||||
skipped = 0
|
||||
for pid, new_evs in APPEND.items():
|
||||
for p in db["patterns"]:
|
||||
if p["pattern_id"] == pid:
|
||||
existing = {normalize_evidence_key(e) for e in (p.get("evidence") or [])}
|
||||
if "evidence" not in p or p["evidence"] is None:
|
||||
p["evidence"] = []
|
||||
for e in new_evs:
|
||||
if normalize_evidence_key(e) in existing:
|
||||
skipped += 1
|
||||
continue
|
||||
p["evidence"].append(e)
|
||||
appended += 1
|
||||
# Mark evidence_status as swept now that we've sourced real data
|
||||
p["evidence_status"] = "swept"
|
||||
break
|
||||
else:
|
||||
print(f"⚠️ pattern {pid} not found")
|
||||
|
||||
added_new = 0
|
||||
existing_ids = {p["pattern_id"] for p in db["patterns"]}
|
||||
for np in NEW_PATTERNS:
|
||||
if np["pattern_id"] in existing_ids:
|
||||
print(f"⚠️ pattern {np['pattern_id']} already exists — skipping")
|
||||
continue
|
||||
db["patterns"].append(np)
|
||||
added_new += 1
|
||||
|
||||
db["meta"]["patterns_count"] = len(db["patterns"])
|
||||
db["meta"]["sweep_status"] = "in-progress"
|
||||
if "evidence-sweep-pass-1" not in db["meta"].get("sweeps_done", []):
|
||||
db["meta"]["sweeps_done"].append("evidence-sweep-pass-1")
|
||||
|
||||
DB.write_text(yaml.safe_dump(db, sort_keys=False, width=200, allow_unicode=True))
|
||||
print(f"✅ appended {appended} evidence rows ({skipped} dupes skipped)")
|
||||
print(f"✅ added {added_new} new patterns")
|
||||
print(f"✅ DB now has {len(db['patterns'])} patterns")
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
67
docs/architecture/extension-api-v2/scripts/fetch-stars.sh
Executable file
@@ -0,0 +1,67 @@
|
||||
#!/usr/bin/env bash
|
||||
# fetch-stars.sh — populate research/touch-points/star-cache.yaml
|
||||
# Reads database.yaml, extracts unique repo: entries, queries gh api for stars.
|
||||
# Usage: bash scripts/fetch-stars.sh
|
||||
set -euo pipefail
|
||||
|
||||
DIR="$(cd "$(dirname "$0")" && pwd)"
|
||||
DB="$DIR/../touch-points-database.yaml"
|
||||
CACHE="$DIR/../touch-points-star-cache.yaml"
|
||||
|
||||
if ! command -v gh >/dev/null 2>&1; then
|
||||
echo "❌ gh CLI not installed"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
# Extract unique repo: entries from database
|
||||
repos=$(grep -E '^\s*-\s*repo:\s' "$DB" | sed -E 's/^\s*-\s*repo:\s*//' | sort -u | grep -v '^$' || true)
|
||||
|
||||
today=$(date +%Y-%m-%d)
|
||||
|
||||
{
|
||||
echo "# ───────────────────────────────────────────────────────────────────────"
|
||||
echo "# GitHub star cache for repos referenced in database.yaml"
|
||||
echo "# Refresh: bash scripts/fetch-stars.sh"
|
||||
echo "# Asof dates allow drift detection"
|
||||
echo "# ───────────────────────────────────────────────────────────────────────"
|
||||
echo ""
|
||||
echo "asof: $today"
|
||||
echo "populated_via: scripts/fetch-stars.sh"
|
||||
echo ""
|
||||
echo "repos:"
|
||||
} > "$CACHE.tmp"
|
||||
|
||||
count=0
|
||||
err_count=0
|
||||
for r in $repos; do
|
||||
count=$((count + 1))
|
||||
printf " [%3d] %s ... " "$count" "$r" >&2
|
||||
if data=$(gh api "repos/$r" 2>/dev/null); then
|
||||
stars=$(echo "$data" | jq -r '.stargazers_count')
|
||||
archived=$(echo "$data" | jq -r '.archived')
|
||||
forks=$(echo "$data" | jq -r '.forks_count')
|
||||
last=$(echo "$data" | jq -r '.pushed_at' | cut -dT -f1)
|
||||
echo "★ $stars" >&2
|
||||
{
|
||||
echo " - repo: $r"
|
||||
echo " stars: $stars"
|
||||
echo " archived: $archived"
|
||||
echo " forks: $forks"
|
||||
echo " last_commit: $last"
|
||||
echo " asof: $today"
|
||||
} >> "$CACHE.tmp"
|
||||
else
|
||||
err_count=$((err_count + 1))
|
||||
echo "ERROR" >&2
|
||||
{
|
||||
echo " - repo: $r"
|
||||
echo " stars: null"
|
||||
echo " error: \"gh api failed (rate limit / repo missing / network)\""
|
||||
echo " asof: $today"
|
||||
} >> "$CACHE.tmp"
|
||||
fi
|
||||
done
|
||||
|
||||
mv "$CACHE.tmp" "$CACHE"
|
||||
echo "" >&2
|
||||
echo "✅ Wrote $CACHE — $count repos, $err_count errors" >&2
|
||||
@@ -0,0 +1,221 @@
|
||||
#!/usr/bin/env python3
|
||||
# merge-staging-pass3.py — single-threaded merger for pass-3 staging files.
|
||||
#
|
||||
# Reads:
|
||||
# research/touch-points/staging/r8-evidence.yaml (clone-grep)
|
||||
# research/touch-points/staging/r9-security.yaml (security scan + proposed S16.* patterns)
|
||||
# research/touch-points/staging/r9-guides.yaml (sanctioned surfaces from docs we ship)
|
||||
# research/touch-points/staging/r9-cookiecutter.yaml (scaffolded = forced-public surfaces)
|
||||
#
|
||||
# Writes back to:
|
||||
# research/touch-points/database.yaml
|
||||
#
|
||||
# Safe to re-run; per-(repo, file, lines) dedup is enforced.
|
||||
# R8 evidence is capped at 6 rows per pattern (already capped per repo+pattern in producer).
|
||||
#
|
||||
# R9.popularity is metadata about repos, not evidence — skipped here.
|
||||
# R9.qa is regression-scenario seeds for I-TF.3 — referenced but not merged into DB.
|
||||
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
import yaml
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
DB = ROOT / "research" / "touch-points" / "database.yaml"
|
||||
STAGING = ROOT / "research" / "touch-points" / "staging"
|
||||
|
||||
R8 = STAGING / "r8-evidence.yaml"
|
||||
R9_SEC = STAGING / "r9-security.yaml"
|
||||
R9_GUIDES = STAGING / "r9-guides.yaml"
|
||||
R9_CK = STAGING / "r9-cookiecutter.yaml"
|
||||
|
||||
CAP_PER_PATTERN_FROM_R8 = 8 # adjust if DB explodes
|
||||
|
||||
|
||||
def normalize_lines(lines):
|
||||
if isinstance(lines, str):
|
||||
# R8 emitted strings like "[119, 131]" — convert
|
||||
try:
|
||||
return tuple(eval(lines, {"__builtins__": {}}, {}))
|
||||
except Exception:
|
||||
return (lines,)
|
||||
if isinstance(lines, list):
|
||||
return tuple(lines)
|
||||
return (lines,)
|
||||
|
||||
|
||||
def evkey(e):
|
||||
return (e.get("repo"), e.get("file"), normalize_lines(e.get("lines")))
|
||||
|
||||
|
||||
def append_dedup(target_evidence, new_rows, cap=None):
|
||||
existing = {evkey(e) for e in target_evidence}
|
||||
appended = 0
|
||||
skipped = 0
|
||||
rows_to_consider = list(new_rows)
|
||||
if cap and len(rows_to_consider) > cap:
|
||||
# Prefer rows from higher-star repos when capping.
|
||||
# Order is producer-defined; keep first `cap`.
|
||||
rows_to_consider = rows_to_consider[:cap]
|
||||
for e in rows_to_consider:
|
||||
# Normalize line representation
|
||||
if isinstance(e.get("lines"), str):
|
||||
e["lines"] = list(normalize_lines(e["lines"]))
|
||||
if evkey(e) in existing:
|
||||
skipped += 1
|
||||
continue
|
||||
target_evidence.append(e)
|
||||
existing.add(evkey(e))
|
||||
appended += 1
|
||||
return appended, skipped
|
||||
|
||||
|
||||
def main():
|
||||
db = yaml.safe_load(DB.read_text())
|
||||
patterns_by_id = {p["pattern_id"]: p for p in db["patterns"]}
|
||||
|
||||
total_appended = 0
|
||||
total_skipped = 0
|
||||
new_patterns_added = 0
|
||||
|
||||
# ─── R8 (clone-grep) ────────────────────────────────────────────
|
||||
r8 = yaml.safe_load(R8.read_text())
|
||||
print(f"R8: {sum(len(v) for v in r8.values())} total rows across {len(r8)} patterns")
|
||||
for pid, rows in r8.items():
|
||||
if pid not in patterns_by_id:
|
||||
print(f" ⚠️ R8 pattern {pid} not in DB — skipping")
|
||||
continue
|
||||
p = patterns_by_id[pid]
|
||||
if "evidence" not in p or p["evidence"] is None:
|
||||
p["evidence"] = []
|
||||
a, s = append_dedup(p["evidence"], rows, cap=CAP_PER_PATTERN_FROM_R8)
|
||||
total_appended += a
|
||||
total_skipped += s
|
||||
p["evidence_status"] = "swept"
|
||||
|
||||
# ─── R9.security: proposed S16.* patterns ───────────────────────
|
||||
sec = yaml.safe_load(R9_SEC.read_text())
|
||||
for sp in sec.get("proposed_patterns", []):
|
||||
pid = sp.get("proposed_pattern_id")
|
||||
if not pid:
|
||||
continue
|
||||
if pid in patterns_by_id:
|
||||
print(f" R9.sec pattern {pid} already exists — appending evidence only")
|
||||
target = patterns_by_id[pid]
|
||||
else:
|
||||
# Materialize the new pattern
|
||||
new_p = {
|
||||
"pattern_id": pid,
|
||||
"surface_family": sp.get("surface_family", "S16"),
|
||||
"surface": sp.get("surface", ""),
|
||||
"fingerprint": sp.get("fingerprint", ""),
|
||||
"semantic": sp.get("semantic", ""),
|
||||
"v2_replacement": sp.get("v2_replacement", ""),
|
||||
"decision_ref": sp.get("rationale", ""),
|
||||
"test_target": sp.get("test_target", ""),
|
||||
"lifecycle_coupling": 0,
|
||||
"severity": "MEDIUM",
|
||||
"evidence_status": "swept",
|
||||
"evidence": [],
|
||||
}
|
||||
db["patterns"].append(new_p)
|
||||
patterns_by_id[pid] = new_p
|
||||
target = new_p
|
||||
new_patterns_added += 1
|
||||
print(f" ➕ R9.sec NEW pattern {pid}: {sp.get('surface', '')[:60]}")
|
||||
|
||||
# Materialize evidence rows from R9.sec
|
||||
evidence_field = sp.get("evidence")
|
||||
if isinstance(evidence_field, str):
|
||||
try:
|
||||
evidence_field = eval(evidence_field, {"__builtins__": {}}, {})
|
||||
except Exception:
|
||||
evidence_field = []
|
||||
if not isinstance(evidence_field, list):
|
||||
evidence_field = []
|
||||
rows = []
|
||||
for e in evidence_field:
|
||||
if not isinstance(e, dict):
|
||||
continue
|
||||
rows.append({
|
||||
"pattern_id": pid,
|
||||
"repo": e.get("repo", "unknown"),
|
||||
"file": e.get("file", "unknown"),
|
||||
"lines": e.get("lines", [1]) if isinstance(e.get("lines"), (list, int)) else [1],
|
||||
"url": e.get("url", ""),
|
||||
"rule": e.get("rule", ""),
|
||||
"source": "security",
|
||||
"variant": e.get("rule", "yara/bandit-hit"),
|
||||
})
|
||||
a, s = append_dedup(target["evidence"], rows)
|
||||
total_appended += a
|
||||
total_skipped += s
|
||||
|
||||
# ─── R9.cookiecutter: scaffolded surfaces ───────────────────────
|
||||
ck = yaml.safe_load(R9_CK.read_text())
|
||||
for entry in ck.get("scaffold_surfaces", []):
|
||||
pid = entry.get("pattern_id")
|
||||
if not pid or pid not in patterns_by_id:
|
||||
continue
|
||||
target = patterns_by_id[pid]
|
||||
if "evidence" not in target or target["evidence"] is None:
|
||||
target["evidence"] = []
|
||||
rows = [{
|
||||
"pattern_id": pid,
|
||||
"repo": "cookiecutter-comfy-extension",
|
||||
"file": entry.get("template_file", "unknown"),
|
||||
"lines": entry.get("lines", [1]),
|
||||
"url": "",
|
||||
"source": "cookiecutter",
|
||||
"variant": "scaffolded-by-default",
|
||||
"excerpt": entry.get("excerpt", ""),
|
||||
"notes": "FORCED-PUBLIC: this surface is generated by the default scaffold, so v2 cannot break it without breaking new-extension onboarding",
|
||||
}]
|
||||
a, s = append_dedup(target["evidence"], rows)
|
||||
total_appended += a
|
||||
total_skipped += s
|
||||
|
||||
# ─── R9.guides: surfaces we teach in docs ───────────────────────
|
||||
guides = yaml.safe_load(R9_GUIDES.read_text())
|
||||
for entry in guides.get("sanctioned_surfaces", []):
|
||||
pid = entry.get("pattern_id")
|
||||
if not pid or pid not in patterns_by_id:
|
||||
continue
|
||||
target = patterns_by_id[pid]
|
||||
if "evidence" not in target or target["evidence"] is None:
|
||||
target["evidence"] = []
|
||||
rows = [{
|
||||
"pattern_id": pid,
|
||||
"repo": "comfyanonymous/custom-nodes-guides",
|
||||
"file": entry.get("taught_in", "unknown"),
|
||||
"lines": entry.get("lines", [1]),
|
||||
"url": "",
|
||||
"source": "guides",
|
||||
"variant": "taught-in-official-docs",
|
||||
"excerpt": entry.get("excerpt", ""),
|
||||
"notes": "SANCTIONED-PUBLIC: this surface is taught in official docs we ship, so v2 must keep it stable",
|
||||
}]
|
||||
a, s = append_dedup(target["evidence"], rows)
|
||||
total_appended += a
|
||||
total_skipped += s
|
||||
|
||||
# ─── Update meta ────────────────────────────────────────────────
|
||||
db["meta"]["patterns_count"] = len(db["patterns"])
|
||||
db["meta"]["sweep_status"] = "in-progress"
|
||||
sweeps = db["meta"].setdefault("sweeps_done", [])
|
||||
if "evidence-sweep-pass-3" not in sweeps:
|
||||
sweeps.append("evidence-sweep-pass-3")
|
||||
|
||||
DB.write_text(yaml.safe_dump(db, sort_keys=False, width=200, allow_unicode=True))
|
||||
|
||||
total_evidence = sum(len(p.get("evidence") or []) for p in db["patterns"])
|
||||
print()
|
||||
print(f"✅ appended {total_appended} rows ({total_skipped} dupes skipped)")
|
||||
print(f"✅ added {new_patterns_added} new patterns")
|
||||
print(f"✅ DB now: {len(db['patterns'])} patterns, {total_evidence} evidence rows")
|
||||
return 0
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
@@ -0,0 +1,121 @@
|
||||
#!/usr/bin/env python3
|
||||
# rollup-blast-radius.py — compute per-pattern blast-radius metrics from
|
||||
# database.yaml + star-cache.yaml, write to research/touch-points/rollup.yaml.
|
||||
#
|
||||
# Blast-radius formula (per PLAN.md):
|
||||
# br = (log10(1 + cumulative_stars)) * w_stars (default 1.0)
|
||||
# + (log10(1 + occurrence_count)) * w_occ (default 0.7)
|
||||
# + (signature_count - 1) * w_sig (default 0.5)
|
||||
# + silent_breakage_weight * w_silent (default 0.5)
|
||||
# + lifecycle_coupling_weight * w_lifecycle (default 0.4)
|
||||
#
|
||||
# silent_breakage_weight & lifecycle_coupling_weight come from the per-pattern
|
||||
# heuristics field; if absent they default to 0.
|
||||
|
||||
import math
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
import yaml
|
||||
|
||||
ROOT = Path(__file__).resolve().parent.parent
|
||||
DB = ROOT / "touch-points-database.yaml"
|
||||
STARS = ROOT / "touch-points-star-cache.yaml"
|
||||
OUT = ROOT / "touch-points-rollup.yaml"
|
||||
|
||||
W = {
|
||||
"stars": 1.0,
|
||||
"occ": 0.7,
|
||||
"sig": 0.5,
|
||||
"silent": 0.5,
|
||||
"lifecycle": 0.4,
|
||||
}
|
||||
|
||||
|
||||
def load_stars() -> dict[str, int]:
|
||||
if not STARS.exists():
|
||||
return {}
|
||||
cache = yaml.safe_load(STARS.read_text())
|
||||
out = {}
|
||||
for r in cache.get("repos", []) or []:
|
||||
if r.get("stars") is not None:
|
||||
out[r["repo"]] = int(r["stars"])
|
||||
return out
|
||||
|
||||
|
||||
def main() -> int:
|
||||
db = yaml.safe_load(DB.read_text())
|
||||
stars = load_stars()
|
||||
|
||||
rows = []
|
||||
for p in db.get("patterns", []) or []:
|
||||
evidence = p.get("evidence") or []
|
||||
repos = []
|
||||
for e in evidence:
|
||||
r = e.get("repo")
|
||||
if r:
|
||||
repos.append(r)
|
||||
unique_repos = sorted(set(repos))
|
||||
cum_stars = sum(stars.get(r, 0) for r in unique_repos)
|
||||
occ = len(evidence)
|
||||
sig_count = p.get("signature_count") or len(p.get("signatures") or []) or 1
|
||||
|
||||
# Pattern fields can be top-level or under 'heuristics'
|
||||
h = p.get("heuristics") or {}
|
||||
sev_map = {"CRITICAL": 2, "HIGH": 1.5, "MEDIUM": 1, "LOW": 0.5}
|
||||
silent_w = float(h.get("silent_breakage", sev_map.get(p.get("severity", ""), 0)))
|
||||
life_w = float(h.get("lifecycle_coupling", p.get("lifecycle_coupling", 0)))
|
||||
|
||||
br = (
|
||||
math.log10(1 + cum_stars) * W["stars"]
|
||||
+ math.log10(1 + occ) * W["occ"]
|
||||
+ max(0, sig_count - 1) * W["sig"]
|
||||
+ silent_w * W["silent"]
|
||||
+ life_w * W["lifecycle"]
|
||||
)
|
||||
|
||||
rows.append(
|
||||
{
|
||||
"pattern_id": p["pattern_id"],
|
||||
"surface_family": p.get("surface_family"),
|
||||
"name": p.get("name") or p.get("surface") or p.get("semantic_intent") or p.get("semantic"),
|
||||
"occurrences": occ,
|
||||
"unique_repos": len(unique_repos),
|
||||
"cumulative_stars": cum_stars,
|
||||
"signature_count": sig_count,
|
||||
"silent_breakage": silent_w,
|
||||
"lifecycle_coupling": life_w,
|
||||
"blast_radius": round(br, 3),
|
||||
"top_repos": [
|
||||
{"repo": r, "stars": stars.get(r, 0)}
|
||||
for r in sorted(unique_repos, key=lambda x: -stars.get(x, 0))[:5]
|
||||
],
|
||||
}
|
||||
)
|
||||
|
||||
rows.sort(key=lambda r: -r["blast_radius"])
|
||||
|
||||
out = {
|
||||
"meta": {
|
||||
"generated_from": ["database.yaml", "star-cache.yaml"],
|
||||
"weights": W,
|
||||
"patterns_count": len(rows),
|
||||
},
|
||||
"patterns": rows,
|
||||
}
|
||||
OUT.write_text(yaml.safe_dump(out, sort_keys=False, width=120))
|
||||
print(f"✅ wrote {OUT.relative_to(ROOT)} ({len(rows)} patterns)")
|
||||
|
||||
print()
|
||||
print("Top 12 by blast radius:")
|
||||
print(f" {'rank':>4} {'br':>6} {'★sum':>6} {'occ':>3} {'sig':>3} pattern")
|
||||
for i, r in enumerate(rows[:12], 1):
|
||||
print(
|
||||
f" {i:>4} {r['blast_radius']:>6.2f} {r['cumulative_stars']:>6} "
|
||||
f"{r['occurrences']:>3} {r['signature_count']:>3} {r['pattern_id']} {r['name']}"
|
||||
)
|
||||
return 0
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
15118
docs/architecture/extension-api-v2/touch-points-database.yaml
Normal file
313
docs/architecture/extension-api-v2/touch-points-plan.md
Normal file
@@ -0,0 +1,313 @@
|
||||
---
|
||||
source: in-house (no external URL — synthesized from R4 + database.yaml + meeting transcript)
|
||||
date_accessed: 2026-05-06
|
||||
created: 2026-05-06
|
||||
purpose: Plan + schema for the canonical touch-point database
|
||||
status: active
|
||||
---
|
||||
|
||||
# Touch-Point Database — Plan
|
||||
|
||||
## Why we are building this
|
||||
|
||||
The v2 extension API redesign (P1, D3.x) and the eventual test framework need a **shared evidence layer**: every API surface that real-world extensions touch, frequency-weighted by usage, with citations to verify. Without this, two failure modes are guaranteed:
|
||||
|
||||
1. **Silent regressions in v2.** Surfaces we don't know about can't be re-implemented or formally deprecated. The v2 service ships, big custom-node packs break, ComfyUI looks unstable.
|
||||
2. **Test framework with the wrong floor.** Tests that don't reflect real extension shapes will pass v2 while production extensions break.
|
||||
|
||||
The database is the input for:
|
||||
- v2 API gap analysis (D4 G1–G13, plus future Gs surfaced here)
|
||||
- Test framework design (widget-api-thoughts.md "Test Framework" section): every entry maps to ≥1 test case
|
||||
- Migration guide writing (P3, DEP3, DEP4)
|
||||
- "What can we actually delete" decisions (e.g., R4 found `loadedGraphNode` has 1 real call site)
|
||||
|
||||
## What the v2 POC shipped (CONTEXT for the audit)
|
||||
|
||||
There are 5 untracked v2 files in `ComfyUI_frontend` worktree (proof-of-concept):
|
||||
|
||||
- `src/types/extensionV2.ts` — `NodeHandle`, `WidgetHandle`, `defineNodeExtension`, `defineWidgetExtension` interfaces
|
||||
- `src/services/extensionV2Service.ts` — scope registry, reactive mount system, handle factories (with inline open-question comments)
|
||||
- `src/extensions/core/dynamicPrompts.v2.ts` — POC migration
|
||||
- `src/extensions/core/imageCrop.v2.ts` — POC migration (13→12 lines)
|
||||
- `src/extensions/core/previewAny.v2.ts` — POC migration (90→35 lines)
|
||||
|
||||
**Open questions left in v2 service comments** (touch-points must answer these):
|
||||
- `setLabel` — special vs just an option? `setHidden` — same?
|
||||
- `on('change')` watches `WidgetValue.value` only — how do extensions watch options/props?
|
||||
- `setSerializeValue` callback — should be `on('serialize')` or `onBeforeSerialize`?
|
||||
- Get/set vs getters/setters — should NodeHandle expose `get pos()` accessors?
|
||||
- `getProperties` — current `properties` bag is heavily used by extensions for "persist across teardown"; v2 must verify that pattern still works
|
||||
- `addWidget` returns by what mechanism? sync dispatch? promise?
|
||||
- Widget figler tree / coverage report of "strangler-figged vs re-implemented vs unsupported"
|
||||
|
||||
These open questions become *test cases*: for each, the database tells us how many extensions in the wild touch the underlying surface.
|
||||
|
||||
## Comprehensive surface enumeration
|
||||
|
||||
The audit covers **8 surface families**. Each family contains specific patterns to search for.
|
||||
|
||||
### S1 — `ComfyExtension` lifecycle hooks (17 hooks)
|
||||
|
||||
From `src/types/comfy.ts`, lines 144-266:
|
||||
|
||||
| Hook | Core extension files using it | Replacement direction |
|
||||
|---|---:|---|
|
||||
| `init` | 16 | unchanged in v2 (ExtensionOptions.init) |
|
||||
| `setup` | 3 | unchanged in v2 (ExtensionOptions.setup) |
|
||||
| `addCustomNodeDefs` | 1 | unknown — may need v2 registration API |
|
||||
| `getCustomWidgets` | 4 | replaced by `defineWidgetExtension` |
|
||||
| `beforeRegisterNodeDef` | 10 | replaced by `nodeTypes` filter + `inspectNodeDef` (G1) |
|
||||
| `beforeRegisterVueAppNodeDefs` | 0 | candidate for removal |
|
||||
| `registerCustomNodes` | 3 | NO v2 equivalent (D4-G2 BLOCKER) |
|
||||
| `loadedGraphNode` | 0 (core), 1 (entire wild corpus) | candidate for removal |
|
||||
| `nodeCreated` | 12 | `defineNodeExtension({ nodeCreated })` |
|
||||
| `beforeConfigureGraph` | 1 | needs decision — graph lifecycle hook |
|
||||
| `afterConfigureGraph` | 0 | candidate for removal |
|
||||
| `getSelectionToolboxCommands` | 0 | candidate for removal |
|
||||
| `getCanvasMenuItems` | 4 | EXISTS — replaces canvas right-click monkey-patching |
|
||||
| `getNodeMenuItems` | 4 | EXISTS — replaces node right-click monkey-patching (P6 in R4) |
|
||||
| `onAuthUserResolved` | 1 | unchanged |
|
||||
| `onAuthTokenRefreshed` | 1 | unchanged |
|
||||
| `onAuthUserLogout` | 1 | unchanged |
|
||||
|
||||
### S2 — `LGraphNode.prototype` methods commonly patched
|
||||
|
||||
Already-confirmed (R4): `onNodeCreated`, `onExecuted`, `onConnectionsChange`, `onRemoved`, `getExtraMenuOptions`, `convertWidgetToInput`, `onGraphConfigured`, `onConfigure`, `onInputDblClick`.
|
||||
|
||||
Add to search: `onAdded`, `onSerialize`, `onDeserialize`, `onDrawForeground`, `onDrawBackground`, `onSelected`, `onDeselected`, `onMouseDown`, `onMouseEnter`, `onMouseLeave`, `onDblClick`, `onPropertyChanged`, `onWidgetChanged`, `onResize`, `onAction`, `onConnectInput`, `onConnectOutput`, `onConfigure`, `onWorkflowConfigure`, `onConnectionsChange`, `onConfigure`, `onCreate`, `clone`, `computeSize`.
|
||||
|
||||
### S3 — `LGraphCanvas.prototype` methods commonly patched
|
||||
|
||||
Confirmed (R4 P7): `processKey`, `processContextMenu`, `computeVisibleNodes`. Our own core: `processMouseDown`, `processMouseMove` (simpleTouchSupport.ts).
|
||||
|
||||
Add to search: `drawNode`, `drawNodeShape`, `drawConnections`, `onMouseDown`, `onDblClick`, `getCanvasMenuOptions`, `getNodeMenuOptions`, `getGroupMenuOptions`, `processNodeWidgets`, `selectNodes`, `deselectAllNodes`, `setSelectedNodes`.
|
||||
|
||||
### S4 — Widget-level patterns (the heart of widget-api-thoughts.md)
|
||||
|
||||
- `.callback` chaining (R4 P1) — the dominant value-change pattern
|
||||
- `.value` direct reads/writes (R4 evidence: imageCompare, widgetInputs, customWidgets, saveImageExtraOutput)
|
||||
- `.serializeValue` assignment (dynamicPrompts.v2 uses it)
|
||||
- `.options.*` direct mutation
|
||||
- `.computedHeight`, `.y`, `.last_y` — layout-level reads
|
||||
- `.options.values` — combo widget values
|
||||
- `.options.serialize`, `.options.hidden`, `.options.readonly` — option flags
|
||||
- Custom widget types declared via `getCustomWidgets`
|
||||
- `addDOMWidget(name, type, element, options)` — DOM widget contribution (R4 P9)
|
||||
|
||||
**Widget thoughts file flags lifecycle dependencies** (widget-api-thoughts.md:25-30):
|
||||
- 3D widgets: file uploads
|
||||
- Webcam widgets: heavy perf
|
||||
- Webcam widgets: lifecycle-dependent serialization
|
||||
- Widgets whose post-serialize value depends on lifecycle steps
|
||||
|
||||
These need explicit DB entries with `lifecycle_dependent: true` flag.
|
||||
|
||||
### S5 — `ComfyApi` / `app.api` event surfaces
|
||||
|
||||
Confirmed (R4 P8): `addEventListener('executed', …)`, custom `'extName.eventName'` events.
|
||||
|
||||
Add to search: `addEventListener('executing', …)`, `'progress'`, `'progress_state'`, `'status'`, `'reconnecting'`, `'reconnected'`, `'execution_start'`, `'execution_success'`, `'execution_error'`, `'execution_cached'`, `'b_preview'`, `'logs'`.
|
||||
|
||||
### S6 — `ComfyApp` god-object touch points
|
||||
|
||||
- `app.graph` — direct LiteGraph object access
|
||||
- `app.canvas` — direct LGraphCanvas access
|
||||
- `app.canvasManager` — newer wrapper
|
||||
- `app.queuePrompt` — submit a workflow
|
||||
- `app.graphToPrompt` — serialize current graph to API payload
|
||||
- `app.loadGraphData` — load a workflow JSON
|
||||
- `app.extensionManager` — ExtensionManager registry access
|
||||
- `app.api` — see S5
|
||||
- `app.getNodeDefs` — node definition registry
|
||||
- `app.registerExtension` — the entry point itself
|
||||
- `app.ui` — legacy UI shim
|
||||
|
||||
### S7 — Window / global escape hatches
|
||||
|
||||
- `window.app` — escape hatch documented in index.ts
|
||||
- `window.graph` — escape hatch documented in index.ts
|
||||
- `window.LiteGraph` — direct LiteGraph access
|
||||
- `window.LGraphCanvas` — direct canvas class access
|
||||
- `window.comfyAPI.modules[...]` — production-only shim mechanism (per extension-development-guide.md)
|
||||
|
||||
### S8 — Special node properties (magic flags)
|
||||
|
||||
- `nodeType.prototype.isVirtualNode` (R4 P10) — virtual node flag
|
||||
- `nodeType.prototype.serialize_widgets` — serialization toggle
|
||||
- `nodeType.prototype.color`, `bgcolor` — visual override
|
||||
- `nodeType.prototype.shape` — node shape override
|
||||
- `nodeType['@<input>']` — input-type metadata (Eclipse pattern)
|
||||
- `nodeType.category` — menu category override
|
||||
|
||||
### S9 — Non-Node entity kinds (per ADR 0008)
|
||||
|
||||
ADR 0008 enumerates **six** entity kinds; the bulk of the ecosystem touches more than just `Node` and `Widget`. These touch points are largely undocumented in the v1 extension API.
|
||||
|
||||
- **Reroute** (`Reroute`, `RerouteId`) — `LiteGraph.createRerouteOnLink`, `graph.reroutes`, `node.connectByRerouteId`
|
||||
- **Group** (`LGraphGroup`) — `graph.groups`, `group.color`, `group.font`, `group.font_size`, `group.children`
|
||||
- **Link** (`LLink`, `LinkId`) — `link.color`, `link._pos`, `link._dragging`, `link.data`
|
||||
- **Slot** (`SlotBase` / `INodeInputSlot` / `INodeOutputSlot`) — `slot.color_on/_off`, `slot.shape`, `slot.dir`, `slot.localized_name`
|
||||
- **Subgraph virtual nodes** — set/get virtual node trick (KJNodes), `nodeType.isVirtualNode = true` (S8) coupled with `graphToPrompt` rewriting (S6.A1)
|
||||
|
||||
### S10 — Dynamic node API (slot/connection mutation at runtime)
|
||||
|
||||
- `node.addInput(name, type)` / `node.removeInput(slot)` — runtime input mutation (typically inside `onConnectionsChange`)
|
||||
- `node.addOutput(name, type)` / `node.removeOutput(slot)` — runtime output mutation
|
||||
- `node.connect(srcSlot, target, dstSlot)` / `node.disconnectInput(slot)` / `node.disconnectOutput(slot)` — programmatic linking
|
||||
- `node.findOutputSlot(name)` / `node.findInputSlot(name)` — slot lookup by name
|
||||
- `node.setDirtyCanvas(true, true)` — force redraw (extremely common after any mutation)
|
||||
- `node.collapse()` / `node.setSize([w,h])` — imperative geometry
|
||||
|
||||
### S11 — Graph-level state and change-tracking
|
||||
|
||||
- `graph._version++` and `graph._version` reads — change-tracking signal **(project AGENTS.md §5: affects 40+ repos)**
|
||||
- `graph.add(node)` / `graph.remove(node)` / `graph.findNodesByType(type)` / `graph.findNodeById(id)`
|
||||
- `graph.serialize()` / `graph.configure(json)` — full-graph serialization (related to S6.A1 graphToPrompt but distinct)
|
||||
- `graph.beforeChange()` / `graph.afterChange()` — explicit batching seam
|
||||
- `graph.onNodeAdded` / `graph.onNodeRemoved` / `graph.onNodeConnectionChange` — graph-level callbacks (vs per-node)
|
||||
|
||||
### S12 — Shell UI registries (sidebar / bottom panel / commands / toasts)
|
||||
|
||||
These are *declarative* surfaces in v1 (extensions push registrations) but their semantics are still public API. Migration must preserve names and contracts.
|
||||
|
||||
- `extensionManager.registerSidebarTab(...)` — `SidebarTabExtension`
|
||||
- `extensionManager.registerBottomPanelTab(...)` — `BottomPanelExtension`
|
||||
- `commandManager.registerCommand(...)` — `CommandManager`
|
||||
- `toastManager.add(...)` / `toastManager.remove(...)` — `ToastManager`
|
||||
- `app.registerExtension({ settings: [...] })` — Settings system contributions
|
||||
- `app.registerExtension({ keybindings: [...] })` — Keybinding contributions
|
||||
- `app.registerExtension({ commands: [...], menuCommands: [...] })` — Menu/command contributions
|
||||
|
||||
### S13 — Schema interpretation (`ComfyNodeDef` / `InputSpec`)
|
||||
|
||||
Extensions inspect the node-def schema directly to drive UI/behavior — this is a public API by accident.
|
||||
|
||||
- `nodeData.input.required` / `nodeData.input.optional` / `nodeData.input.hidden` — input bag inspection
|
||||
- `nodeData.output[]` / `nodeData.output_name[]` / `nodeData.output_is_list[]` — output schema inspection
|
||||
- `nodeData.output_node` — special "output node" boolean flag
|
||||
- `nodeData.category` / `nodeData.python_module` — origin metadata
|
||||
- `InputSpec` sentinel objects — `["INT", { default, min, max, step }]`, `["STRING", { multiline }]`, `["COMBO", { values, default }]`, `["IMAGEUPLOAD", {...}]`, etc.
|
||||
|
||||
### S14 — Identity / Locator scheme
|
||||
|
||||
- `NodeLocatorId` — encodes `(graphScope, nodeId)` for cross-subgraph references
|
||||
- `NodeExecutionId` — backend execution-graph identifier
|
||||
- `parseNodeLocatorId` / `createNodeLocatorId` / `isNodeLocatorId` — public helpers exported from `src/types/index.ts`
|
||||
- Implicit pattern: extensions resolve "node X in subgraph Y" — must work after subgraph promotion
|
||||
|
||||
### S15 — Output system (per `widget-api-thoughts.md`)
|
||||
|
||||
`widget-api-thoughts.md` flags this as a separate change axis from widgets:
|
||||
|
||||
- Dynamic output mutation via `node.addOutput` / `node.removeOutput` (cross-references S10)
|
||||
- Schema-declared outputs (preferred end-state) — `OUTPUT_TYPES`-style explicit declaration
|
||||
- `nodeData.output_node` flag — node is a terminal/sink
|
||||
- `node.onExecuted({ images: [...] })` — output-display pattern (cross-references S2.N2)
|
||||
- "Force declaration" goal: extensions must declare output types in the node schema, not mutate at runtime
|
||||
|
||||
## Database schema
|
||||
|
||||
Each entry is a YAML record:
|
||||
|
||||
```yaml
|
||||
- pattern_id: P1.1 # stable ID for cross-reference
|
||||
surface_family: S4 # S1-S8
|
||||
surface: "widget.callback assignment" # human-readable name
|
||||
fingerprint: 'w.callback = function(v) {...}' # regex-ish
|
||||
semantic: "subscribe to widget value change" # what extensions are *trying* to do
|
||||
v2_replacement: "widget.on('change', fn)" # proposed
|
||||
decision_ref: D3.3 # which decision doc covers it
|
||||
test_target: WIDGET_VALUE_CHANGE_LISTENER # test framework symbol
|
||||
evidence:
|
||||
- repo: crom8505/ComfyUI-Dynamic-Sigmas
|
||||
file: web/js/graph_sigmas.js
|
||||
lines: [79, 80]
|
||||
url: https://github.com/crom8505/ComfyUI-Dynamic-Sigmas/blob/main/web/js/graph_sigmas.js#L79
|
||||
stars: 12 # github stars (cached, asof date)
|
||||
stars_asof: 2026-05-06
|
||||
variant: canonical # canonical | unsafe | with-bind | tempCallback-swap | per-instance | prototype
|
||||
breakage_class: silent # silent | loud | undefined-behavior | crash
|
||||
notes: "fourteen instances in same file"
|
||||
derived:
|
||||
occurrences: 7 # rolled up from evidence
|
||||
repos_touched: 5
|
||||
cumulative_stars: 245
|
||||
canonical_signatures: 1 # how many distinct shapes seen (P4 had 6 for onConnectionsChange!)
|
||||
breakage_classes: [silent, undefined-behavior]
|
||||
blast_radius: 3.2 # see formula
|
||||
```
|
||||
|
||||
## Blast-radius scoring formula
|
||||
|
||||
Goal: rank patterns by how disruptive their breakage would be in v2 rollout.
|
||||
|
||||
```
|
||||
blast_radius = 0.40 * log10(1 + cumulative_stars)
|
||||
+ 0.20 * log10(1 + occurrences)
|
||||
+ 0.15 * canonical_signatures # more shapes = more migration cases to support
|
||||
+ 0.15 * silent_breakage_weight # silent > loud > crash for danger
|
||||
+ 0.10 * lifecycle_coupling # 0/1/2; widgets that break on serialize timing get 2
|
||||
```
|
||||
|
||||
Where:
|
||||
- `silent_breakage_weight` = max over evidence: silent=1.0, undefined=0.6, loud=0.3, crash=0.2
|
||||
- `lifecycle_coupling` = 0 (none) | 1 (depends on init/teardown order) | 2 (depends on serialization-timing or DOM-mount-timing)
|
||||
|
||||
Rationale:
|
||||
- `log10` on stars + occurrences damps mega-popular packs from drowning out long-tail diversity
|
||||
- Silent breakage scores higher than loud — these are the ones that destroy trust
|
||||
- Lifecycle coupling captures widget-api-thoughts.md concerns (3D, webcam)
|
||||
- Canonical signatures captures "the API has no schema" risk (R4 P4 with 6 sigs)
|
||||
|
||||
A blast_radius ≥ 3.0 = MUST have a v1-compat shim or the migration story breaks.
|
||||
|
||||
## Star-fetching strategy
|
||||
|
||||
For each unique repo:
|
||||
```bash
|
||||
gh api "repos/<owner>/<name>" --jq '.stargazers_count'
|
||||
```
|
||||
|
||||
Cache in `research/touch-points/star-cache.yaml`:
|
||||
```yaml
|
||||
- repo: crom8505/ComfyUI-Dynamic-Sigmas
|
||||
stars: 12
|
||||
asof: 2026-05-06
|
||||
```
|
||||
|
||||
Refresh quarterly. If gh CLI errors (rate limit, repo gone), record `stars: null` and `error: <reason>`.
|
||||
|
||||
## Workflow
|
||||
|
||||
1. **Plan + schema (this doc)** ✅
|
||||
2. **Build initial database** — start with the 12 patterns from R4, structured properly
|
||||
3. **Sweep S1–S8 systematically** — batched code search, populate evidence
|
||||
4. **Star fetch pass** — `gh api` for every unique repo, populate cache
|
||||
5. **Compute derived fields** — script that rolls up evidence into derived metrics
|
||||
6. **Generate ranked report** — `database-by-blast-radius.md`
|
||||
7. **Map to test framework** — each pattern_id → test symbol
|
||||
|
||||
## Dispatch strategy for queries
|
||||
|
||||
- ~50 queries needed across S1–S8 (each surface gets 1-3 queries)
|
||||
- Run in parallel batches of 4-6 (MCP tolerates this if no DNS error)
|
||||
- Retry failed queries with 3-token reformulations (R4 workaround)
|
||||
- After each batch: append findings to `database.yaml`, never overwrite
|
||||
- After full sweep: run star-fetch script, run roll-up script
|
||||
|
||||
## Integration with the test framework
|
||||
|
||||
Each pattern in the database becomes a test triple:
|
||||
|
||||
1. **v1 contract test** (legacy): proves the v1 hook still works for shimmed extensions
|
||||
2. **v2 contract test** (new): proves the v2 replacement covers the same semantic
|
||||
3. **Migration test**: takes a real extension snippet from evidence, confirms it works in v2 (or fails with a documented compat error)
|
||||
|
||||
The test framework's "compatibility floor" is: every blast_radius ≥ 2.0 entry MUST pass all three tests before v2 ships.
|
||||
|
||||
## Out of scope (deferred)
|
||||
|
||||
- Sandboxing model (Chrome-extension-style isolation): noted in CONTEXT.md, deferred
|
||||
- Performance benchmarks vs v1: separate workstream
|
||||
- Documentation generation from the database: separate workstream
|
||||
- npm package design for `@comfyui/extension-api`: separate workstream (per R4 P11 finding)
|
||||
1184
docs/architecture/extension-api-v2/touch-points-rollup.yaml
Normal file
724
docs/architecture/extension-api-v2/touch-points-star-cache.yaml
Normal file
@@ -0,0 +1,724 @@
|
||||
# ───────────────────────────────────────────────────────────────────────
|
||||
# GitHub star cache for repos referenced in database.yaml
|
||||
# Refresh: bash scripts/fetch-stars.sh
|
||||
# Asof dates allow drift detection
|
||||
# ───────────────────────────────────────────────────────────────────────
|
||||
|
||||
asof: 2026-05-08
|
||||
populated_via: scripts/fetch-stars.sh
|
||||
|
||||
repos:
|
||||
- repo: 40740/ComfyUI_LayerStyle_Bmss
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2024-10-16
|
||||
asof: 2026-05-08
|
||||
- repo: 834t/ComfyUI_834t_scene_composer
|
||||
stars: 5
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-04-03
|
||||
asof: 2026-05-08
|
||||
- repo: aicocoa981/WhatDreamsCost-ComfyUI-private
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-03-30
|
||||
asof: 2026-05-08
|
||||
- repo: AIGODLIKE/AIGODLIKE-ComfyUI-Studio
|
||||
stars: 405
|
||||
archived: false
|
||||
forks: 25
|
||||
last_commit: 2025-10-27
|
||||
asof: 2026-05-08
|
||||
- repo: akawana/ComfyUI-Folded-Prompts
|
||||
stars: 4
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-04-30
|
||||
asof: 2026-05-08
|
||||
- repo: AkihaTatsu/ComfyUI-Simple-Utility-Nodes
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-11
|
||||
asof: 2026-05-08
|
||||
- repo: alankent/ComfyUI-OA-360-Clip
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2025-11-16
|
||||
asof: 2026-05-08
|
||||
- repo: AlexZ1967/ComfyUI_ALEXZ_tools
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: ameliacode/comfyui-face3d
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-23
|
||||
asof: 2026-05-08
|
||||
- repo: andreszs/ComfyUI-Ultralytics-Studio
|
||||
stars: 3
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-04-13
|
||||
asof: 2026-05-08
|
||||
- repo: ArtHommage/HommageTools
|
||||
stars: 4
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2025-05-20
|
||||
asof: 2026-05-08
|
||||
- repo: Azornes/Comfyui-LayerForge
|
||||
stars: 312
|
||||
archived: false
|
||||
forks: 16
|
||||
last_commit: 2026-05-01
|
||||
asof: 2026-05-08
|
||||
- repo: becky3/comfyui-workspace
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-13
|
||||
asof: 2026-05-08
|
||||
- repo: BennyKok/comfyui-deploy
|
||||
stars: 1508
|
||||
archived: false
|
||||
forks: 222
|
||||
last_commit: 2025-11-13
|
||||
asof: 2026-05-08
|
||||
- repo: brycecovert/ComfyUI-compass-images
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-23
|
||||
asof: 2026-05-08
|
||||
- repo: choovin/comfyui-api
|
||||
stars: 3
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-03-08
|
||||
asof: 2026-05-08
|
||||
- repo: chyer/Chye-ComfyUI-Toolset
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-03-10
|
||||
asof: 2026-05-08
|
||||
- repo: coeuskoalemoss/comfyUI-layerstyle-custom
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2025-06-23
|
||||
asof: 2026-05-08
|
||||
- repo: ComfyNodePRs/PR-comfyui-pkg39-ccab78b5
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2024-07-31
|
||||
asof: 2026-05-08
|
||||
- repo: Comfy-Org/ComfyUI_frontend
|
||||
stars: 1787
|
||||
archived: false
|
||||
forks: 563
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: Comfy-Org/ComfyUI-Manager
|
||||
stars: 14564
|
||||
archived: false
|
||||
forks: 2187
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: Comfy-Org/ComfyUI-test-framework
|
||||
stars: 2
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-03-23
|
||||
asof: 2026-05-08
|
||||
- repo: ComfyUI-Kelin/ComfyUI_Image_Anything
|
||||
stars: 3
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-20
|
||||
asof: 2026-05-08
|
||||
- repo: Creepybits/ComfyUI-Creepy_nodes
|
||||
stars: 29
|
||||
archived: false
|
||||
forks: 5
|
||||
last_commit: 2026-04-14
|
||||
asof: 2026-05-08
|
||||
- repo: criskb/Comfypencil
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-04-13
|
||||
asof: 2026-05-08
|
||||
- repo: criskb/Fancy_Grid
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-04-13
|
||||
asof: 2026-05-08
|
||||
- repo: crom8505/ComfyUI-Dynamic-Sigmas
|
||||
stars: 8
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-03-30
|
||||
asof: 2026-05-08
|
||||
- repo: Damkohler/jlc-comfyui-nodes
|
||||
stars: 16
|
||||
archived: false
|
||||
forks: 4
|
||||
last_commit: 2026-04-17
|
||||
asof: 2026-05-08
|
||||
- repo: darth-veitcher/comfyui-ollama-model-manager
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2025-11-05
|
||||
asof: 2026-05-08
|
||||
- repo: DazzleNodes/ComfyUI-Smart-Resolution-Calc
|
||||
stars: 7
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-04-22
|
||||
asof: 2026-05-08
|
||||
- repo: diodiogod/TTS-Audio-Suite
|
||||
stars: 911
|
||||
archived: false
|
||||
forks: 101
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: dorpxam/ComfyUI-LTX2-Microscope
|
||||
stars: 4
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-04-23
|
||||
asof: 2026-05-08
|
||||
- repo: DumiFlex/ComfyUI-Wildcard-Pipeline
|
||||
stars: 4
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-04-08
|
||||
asof: 2026-05-08
|
||||
- repo: egormly/ComfyUI-EG_Tools
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2025-11-19
|
||||
asof: 2026-05-08
|
||||
- repo: EmanuelRiquelme/comfyui-art-venture
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2024-09-04
|
||||
asof: 2026-05-08
|
||||
- repo: EnragedAntelope/EA_LMStudio
|
||||
stars: 7
|
||||
archived: false
|
||||
forks: 4
|
||||
last_commit: 2026-04-22
|
||||
asof: 2026-05-08
|
||||
- repo: Firetheft/ComfyUI-Animate-Progress
|
||||
stars: 3
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2025-09-09
|
||||
asof: 2026-05-08
|
||||
- repo: FloyoAI/ComfyUI-SoundFlow
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2025-11-21
|
||||
asof: 2026-05-08
|
||||
- repo: flymyd/koishi-plugin-comfyui-client
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2025-08-21
|
||||
asof: 2026-05-08
|
||||
- repo: FunnyFinger/Dynamic_Sliders_stack
|
||||
stars: 4
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2025-04-22
|
||||
asof: 2026-05-08
|
||||
- repo: gigici/ComfyUI_BlendPack
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: goodtab/ComfyUI-Custom-Scripts
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2024-09-02
|
||||
asof: 2026-05-08
|
||||
- repo: guido-gfv/gfv_pro_upgrade
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-20
|
||||
asof: 2026-05-08
|
||||
- repo: haohaocreates/PR-rk-comfy-nodes-36d8f0a5
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2024-05-22
|
||||
asof: 2026-05-08
|
||||
- repo: hernantech/comfymcp
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-01-03
|
||||
asof: 2026-05-08
|
||||
- repo: hhayiyuan/ComfyUI-FFmpegURLMedia
|
||||
stars: 2
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-01-02
|
||||
asof: 2026-05-08
|
||||
- repo: huafitwjb/ComfyUI-GO-Mobile-app
|
||||
stars: 6
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-03-04
|
||||
asof: 2026-05-08
|
||||
- repo: ialhabbal/compare
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-03-31
|
||||
asof: 2026-05-08
|
||||
- repo: IAMCCS/IAMCCS-nodes
|
||||
stars: 92
|
||||
archived: false
|
||||
forks: 6
|
||||
last_commit: 2026-05-04
|
||||
asof: 2026-05-08
|
||||
- repo: IXIWORKS-KIMJUNGHO/comfyui-ixiworks-tools
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-03-15
|
||||
asof: 2026-05-08
|
||||
- repo: JichaoLiang/Immortal_comfyui_public
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2025-12-05
|
||||
asof: 2026-05-08
|
||||
- repo: jiekouai/ComfyUI-JieKou-API
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-03-25
|
||||
asof: 2026-05-08
|
||||
- repo: jonstreeter/comfyui-compressed-metadata
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2025-10-12
|
||||
asof: 2026-05-08
|
||||
- repo: ketle-man/ComfyUI-Workflow-Studio
|
||||
stars: 2
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-28
|
||||
asof: 2026-05-08
|
||||
- repo: kijai/ComfyUI-KJNodes
|
||||
stars: 2569
|
||||
archived: false
|
||||
forks: 292
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: koshimazaki/ComfyUI-Koshi-Nodes
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-03-12
|
||||
asof: 2026-05-08
|
||||
- repo: krismasdev/ComfyUI-Flux-Continuum
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2025-08-04
|
||||
asof: 2026-05-08
|
||||
- repo: KumihoIO/kumiho-plugins
|
||||
stars: 2
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-03-28
|
||||
asof: 2026-05-08
|
||||
- repo: kyuz0/amd-strix-halo-comfyui-toolboxes
|
||||
stars: 109
|
||||
archived: false
|
||||
forks: 14
|
||||
last_commit: 2026-02-13
|
||||
asof: 2026-05-08
|
||||
- repo: LaoMaoBoss/ComfyUI-WBLESS
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-04-07
|
||||
asof: 2026-05-08
|
||||
- repo: Lightricks/ComfyUI-LTXVideo
|
||||
stars: 3587
|
||||
archived: false
|
||||
forks: 390
|
||||
last_commit: 2026-04-26
|
||||
asof: 2026-05-08
|
||||
- repo: linjm8780860/ljm_comfyui
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-29
|
||||
asof: 2026-05-08
|
||||
- repo: lordwedggie/xcpNodes
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: lucafoscili/lf-nodes
|
||||
stars: 34
|
||||
archived: false
|
||||
forks: 3
|
||||
last_commit: 2025-12-23
|
||||
asof: 2026-05-08
|
||||
- repo: m3rr/h4_Live
|
||||
stars: 2
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-05-07
|
||||
asof: 2026-05-08
|
||||
- repo: MajoorWaldi/ComfyUI-Majoor-AssetsManager
|
||||
stars: 97
|
||||
archived: false
|
||||
forks: 6
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: max-dingsda/ComfyUI-AllinOne-LazyNode
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-03-30
|
||||
asof: 2026-05-08
|
||||
- repo: maxi45274/ComfyUI_LinkFX
|
||||
stars: 3
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: melMass/comfy_mtb
|
||||
stars: 702
|
||||
archived: false
|
||||
forks: 82
|
||||
last_commit: 2026-03-19
|
||||
asof: 2026-05-08
|
||||
- repo: MockbaTheBorg/ComfyUI-Mockba
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-13
|
||||
asof: 2026-05-08
|
||||
- repo: mudknight/comfyui-mudknight-utils
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: MuhammadMuradKhan/efficiency-nodes-comfyui
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2024-02-11
|
||||
asof: 2026-05-08
|
||||
- repo: niknah/presentation-ComfyUI
|
||||
stars: 2
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-04-21
|
||||
asof: 2026-05-08
|
||||
- repo: nodelee733/ComfyUI-mxToolkit
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-27
|
||||
asof: 2026-05-08
|
||||
- repo: nodetool-ai/nodetool
|
||||
stars: 332
|
||||
archived: false
|
||||
forks: 40
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: nvmax/aspect-ratio-resizer
|
||||
stars: 5
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-04-23
|
||||
asof: 2026-05-08
|
||||
- repo: o-l-l-i/ComfyUI-Olm-ImageAdjust
|
||||
stars: 45
|
||||
archived: false
|
||||
forks: 4
|
||||
last_commit: 2025-08-09
|
||||
asof: 2026-05-08
|
||||
- repo: PGCRT/CRT-Nodes
|
||||
stars: 108
|
||||
archived: false
|
||||
forks: 14
|
||||
last_commit: 2026-05-03
|
||||
asof: 2026-05-08
|
||||
- repo: philippjbauer/devint25-comfyui-api-demo
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2025-10-09
|
||||
asof: 2026-05-08
|
||||
- repo: pictorialink/ComfyUI-Easy-Use
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2025-07-15
|
||||
asof: 2026-05-08
|
||||
- repo: PioneerMNDR/ComfyUI-Polza
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-04-23
|
||||
asof: 2026-05-08
|
||||
- repo: pixaroma/ComfyUI-Pixaroma
|
||||
stars: 146
|
||||
archived: false
|
||||
forks: 9
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: PROJECTMAD/PROJECT-MAD-NODES
|
||||
stars: 4
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-04-01
|
||||
asof: 2026-05-08
|
||||
- repo: Raykosan/ComfyUI_RaykoStudio
|
||||
stars: 45
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-05-05
|
||||
asof: 2026-05-08
|
||||
- repo: rgthree/rgthree-comfy
|
||||
stars: 3054
|
||||
archived: false
|
||||
forks: 226
|
||||
last_commit: 2026-04-07
|
||||
asof: 2026-05-08
|
||||
- repo: robertvoy/ComfyUI-Distributed
|
||||
stars: 544
|
||||
archived: false
|
||||
forks: 57
|
||||
last_commit: 2026-04-26
|
||||
asof: 2026-05-08
|
||||
- repo: rohapa/comfyui-replay
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-03-27
|
||||
asof: 2026-05-08
|
||||
- repo: r-vage/ComfyUI_Eclipse
|
||||
stars: 19
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: ryanontheinside/ComfyUI_RyanOnTheInside
|
||||
stars: 801
|
||||
archived: false
|
||||
forks: 50
|
||||
last_commit: 2026-03-20
|
||||
asof: 2026-05-08
|
||||
- repo: sammykumar/ComfyUI-SwissArmyKnife
|
||||
stars: 5
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-01-14
|
||||
asof: 2026-05-08
|
||||
- repo: SaturMars/ComfyUI-NVVFR
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2025-08-05
|
||||
asof: 2026-05-08
|
||||
- repo: ShakerSmith/ShakerNodesSuite
|
||||
stars: 8
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-02-18
|
||||
asof: 2026-05-08
|
||||
- repo: shrimbly/willie-comfy-frontend
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-28
|
||||
asof: 2026-05-08
|
||||
- repo: SKBv0/ComfyUI_SKBundle
|
||||
stars: 116
|
||||
archived: false
|
||||
forks: 7
|
||||
last_commit: 2026-04-23
|
||||
asof: 2026-05-08
|
||||
- repo: SKBv0/ComfyUI_SpideyReroute
|
||||
stars: 13
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2025-12-19
|
||||
asof: 2026-05-08
|
||||
- repo: sofakid/dandy
|
||||
stars: 54
|
||||
archived: false
|
||||
forks: 4
|
||||
last_commit: 2025-12-15
|
||||
asof: 2026-05-08
|
||||
- repo: SpaceWarpStudio/ComfyUI-SetInputGetOutput
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-03-30
|
||||
asof: 2026-05-08
|
||||
- repo: SparknightLLC/ComfyUI-EnumCombo
|
||||
stars: 2
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: StableLlama/ComfyUI-basic_data_handling
|
||||
stars: 43
|
||||
archived: false
|
||||
forks: 7
|
||||
last_commit: 2026-05-07
|
||||
asof: 2026-05-08
|
||||
- repo: stavzszn/comfyui-teskors-utils
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-03-29
|
||||
asof: 2026-05-08
|
||||
- repo: Stibo/comfyui-nifty-nodes
|
||||
stars: 3
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-03-21
|
||||
asof: 2026-05-08
|
||||
- repo: Sunwood-ai-labs/ComfyUI-LTXLongAudio
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-01
|
||||
asof: 2026-05-08
|
||||
- repo: sypex6/ComfyUI_InstaRAW_Nodes
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-07
|
||||
asof: 2026-05-08
|
||||
- repo: tavyra/ComfyUI_Curves
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2025-05-08
|
||||
asof: 2026-05-08
|
||||
- repo: tetsuoo-online/Comfyui-TOO-Pack
|
||||
stars: 4
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-04-02
|
||||
asof: 2026-05-08
|
||||
- repo: touge/ComfyUI-NCE_Utils
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-01-25
|
||||
asof: 2026-05-08
|
||||
- repo: treforyan-hue/comfyui-deploy
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-05-05
|
||||
asof: 2026-05-08
|
||||
- repo: Valiant-Cat/ComfyUI-WanMove-Trajectory
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2025-12-12
|
||||
asof: 2026-05-08
|
||||
- repo: viswamohankomati/ComfyUI-Copilot
|
||||
stars: 0
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2025-09-17
|
||||
asof: 2026-05-08
|
||||
- repo: vjumpkung/comfyui-infinitetalk-native-sampler
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-03-31
|
||||
asof: 2026-05-08
|
||||
- repo: Winnougan/WINT8-ComfyUI
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 2
|
||||
last_commit: 2026-04-17
|
||||
asof: 2026-05-08
|
||||
- repo: xeinherjer-dev/ComfyUI-XENodes
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2026-05-07
|
||||
asof: 2026-05-08
|
||||
- repo: yardimli/SafetensorViewer
|
||||
stars: 7
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2025-02-19
|
||||
asof: 2026-05-08
|
||||
- repo: yolain/ComfyUI-Easy-Use
|
||||
stars: 2504
|
||||
archived: false
|
||||
forks: 195
|
||||
last_commit: 2026-04-29
|
||||
asof: 2026-05-08
|
||||
- repo: yolain/ComfyUI-Easy-Use-Frontend
|
||||
stars: 27
|
||||
archived: false
|
||||
forks: 9
|
||||
last_commit: 2026-04-01
|
||||
asof: 2026-05-08
|
||||
- repo: yorkane/ComfyUI-KYNode
|
||||
stars: 10
|
||||
archived: false
|
||||
forks: 4
|
||||
last_commit: 2026-02-04
|
||||
asof: 2026-05-08
|
||||
- repo: zhupeter010903/ComfyUI-XYZ-prompt-library
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-26
|
||||
asof: 2026-05-08
|
||||
- repo: zzggi2024/shaobkj
|
||||
stars: 1
|
||||
archived: false
|
||||
forks: 0
|
||||
last_commit: 2026-04-27
|
||||
asof: 2026-05-08
|
||||
- repo: zzw5516/ComfyUI-zw-tools
|
||||
stars: 6
|
||||
archived: false
|
||||
forks: 1
|
||||
last_commit: 2025-12-03
|
||||
asof: 2026-05-08
|
||||
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "@comfyorg/comfyui-frontend",
|
||||
"version": "1.44.18",
|
||||
"version": "1.45.0",
|
||||
"private": true,
|
||||
"description": "Official front-end implementation of ComfyUI",
|
||||
"homepage": "https://comfy.org",
|
||||
@@ -47,6 +47,9 @@
|
||||
"test:browser:coverage": "cross-env COLLECT_COVERAGE=true pnpm test:browser",
|
||||
"test:browser:local": "cross-env PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm test:browser",
|
||||
"test:coverage": "vitest run --coverage",
|
||||
"test:extension-api": "vitest run --config vitest.extension-api.config.mts",
|
||||
"test:extension-api:watch": "vitest --config vitest.extension-api.config.mts",
|
||||
"test:extension-api:coverage": "vitest run --config vitest.extension-api.config.mts --coverage",
|
||||
"test:unit": "nx run test",
|
||||
"typecheck": "vue-tsc --noEmit",
|
||||
"typecheck:browser": "vue-tsc --project browser_tests/tsconfig.json",
|
||||
|
||||
3
packages/extension-api/.gitignore
vendored
Normal file
@@ -0,0 +1,3 @@
|
||||
docs-build/
|
||||
build/
|
||||
node_modules/
|
||||
50
packages/extension-api/README.md
Normal file
@@ -0,0 +1,50 @@
|
||||
# @comfyorg/extension-api
|
||||
|
||||
> **Status**: scaffolded. Package implementation pending PKG3 — see
|
||||
> `../../../plans/P2-extension-api-package.md` and
|
||||
> `../../../plans/prompts/PKG3-npm-package.md` in the workspace root.
|
||||
|
||||
The official TypeScript declaration package for ComfyUI extensions. This
|
||||
package replaces the practice of vendoring `comfy.d.ts` files in custom
|
||||
node repos.
|
||||
|
||||
## Install (post-publish)
|
||||
|
||||
```bash
|
||||
pnpm add -D @comfyorg/extension-api
|
||||
```
|
||||
|
||||
```ts
|
||||
import { defineExtension } from '@comfyorg/extension-api'
|
||||
|
||||
export default defineExtension({
|
||||
name: 'MyExtension',
|
||||
setup(ctx) {
|
||||
ctx.onNodeMounted((node) => {
|
||||
// ...
|
||||
})
|
||||
}
|
||||
})
|
||||
```
|
||||
|
||||
## Source
|
||||
|
||||
This package is built from the source-of-truth folder
|
||||
`../../src/extension-api/`. Do not edit the package's `build/` output
|
||||
directly.
|
||||
|
||||
## Versioning
|
||||
|
||||
- `0.x.y` — experimental during parallel-paths transition (D6 Phase A).
|
||||
- `1.0.0` — first stable release once D5/D6/D7/D8 are accepted and the
|
||||
surface has stabilized.
|
||||
- Breaking changes follow semver strictly from `1.0.0` onward.
|
||||
|
||||
## Cross-references
|
||||
|
||||
- `decisions/D6-parallel-paths-migration.md` — versioning rationale
|
||||
- `plans/P2-extension-api-package.md` — package structure plan
|
||||
- `plans/prompts/PKG3-npm-package.md` — implementation prompt
|
||||
- `plans/prompts/PKG4-ci-workflows.md` — publish workflow
|
||||
- `plans/prompts/PKG5-docgen-mdx.md` — docgen pipeline
|
||||
- `plans/prompts/PKG6-docs-comfy-org.md` — docs.comfy.org integration
|
||||
28
packages/extension-api/package.json
Normal file
@@ -0,0 +1,28 @@
|
||||
{
|
||||
"name": "@comfyorg/extension-api",
|
||||
"version": "0.1.0",
|
||||
"description": "Official TypeScript extension API for ComfyUI custom nodes",
|
||||
"type": "module",
|
||||
"exports": {
|
||||
".": "./build/index.js"
|
||||
},
|
||||
"types": "./build/index.d.ts",
|
||||
"scripts": {
|
||||
"typecheck": "tsc --noEmit",
|
||||
"build": "tsc --emitDeclarationOnly --outDir build",
|
||||
"docs:build": "tsx scripts/build-docs.ts",
|
||||
"docs:watch": "tsx scripts/build-docs.ts --watch"
|
||||
},
|
||||
"devDependencies": {
|
||||
"tsx": "catalog:",
|
||||
"typedoc": "0.28.19",
|
||||
"typedoc-plugin-markdown": "^4.6.3",
|
||||
"typescript": "catalog:"
|
||||
},
|
||||
"nx": {
|
||||
"tags": [
|
||||
"scope:shared",
|
||||
"type:api"
|
||||
]
|
||||
}
|
||||
}
|
||||
470
packages/extension-api/scripts/build-docs.ts
Normal file
@@ -0,0 +1,470 @@
|
||||
#!/usr/bin/env tsx
|
||||
/**
|
||||
* PKG5 docgen pipeline: TypeDoc → Mintlify MDX
|
||||
*
|
||||
* Steps:
|
||||
* 1. Run TypeDoc with typedoc-plugin-markdown to emit raw markdown into docs-build/raw/
|
||||
* 2. Post-process each markdown file:
|
||||
* - Add Mintlify frontmatter (title, description, sidebarTitle, icon)
|
||||
* - Convert ``` fences without lang tag → ```ts
|
||||
* - Replace raw [TypeName] cross-refs with MDX relative links
|
||||
* - Wrap @example blocks in proper code fences
|
||||
* 3. Write final .mdx files to docs-build/mintlify/
|
||||
* 4. Emit docs-build/mintlify/nav-snippet.json — merges into docs.comfy.org mint.json
|
||||
*
|
||||
* Run: pnpm --filter @comfyorg/extension-api docs:build
|
||||
*/
|
||||
|
||||
import { execSync } from 'node:child_process'
|
||||
import fs from 'node:fs'
|
||||
import path from 'node:path'
|
||||
import { fileURLToPath } from 'node:url'
|
||||
|
||||
const __dirname = path.dirname(fileURLToPath(import.meta.url))
|
||||
const pkgRoot = path.resolve(__dirname, '..')
|
||||
const rawDir = path.join(pkgRoot, 'docs-build', 'raw')
|
||||
const mintlifyDir = path.join(pkgRoot, 'docs-build', 'mintlify')
|
||||
const watchMode = process.argv.includes('--watch')
|
||||
|
||||
// ── Page metadata ────────────────────────────────────────────────────────────
|
||||
// Controls frontmatter for each generated page. Key = TypeDoc output filename
|
||||
// stem (lowercased). Unrecognised files get generic metadata.
|
||||
|
||||
interface PageMeta {
|
||||
title: string
|
||||
sidebarTitle?: string
|
||||
description: string
|
||||
icon?: string
|
||||
group: 'core' | 'handles' | 'events' | 'shell' | 'identity' | 'root'
|
||||
order: number
|
||||
}
|
||||
|
||||
const PAGE_META: Record<string, PageMeta> = {
|
||||
// Top-level overview
|
||||
index: {
|
||||
title: 'Extension API Overview',
|
||||
description: 'TypeScript API reference for ComfyUI custom node extensions.',
|
||||
icon: 'puzzle-piece',
|
||||
group: 'root',
|
||||
order: 0
|
||||
},
|
||||
// Lifecycle / registration
|
||||
defineextension: {
|
||||
title: 'defineExtension',
|
||||
description: 'Register an app-scoped extension for init, setup, and shell UI contributions.',
|
||||
icon: 'code',
|
||||
group: 'core',
|
||||
order: 1
|
||||
},
|
||||
definenodeextension: {
|
||||
title: 'defineNodeExtension',
|
||||
description: 'Register a node-scoped extension reacting to node lifecycle events.',
|
||||
icon: 'code',
|
||||
group: 'core',
|
||||
order: 2
|
||||
},
|
||||
definewidgetextension: {
|
||||
title: 'defineWidgetExtension',
|
||||
description: 'Register a custom widget type with its own DOM rendering.',
|
||||
icon: 'code',
|
||||
group: 'core',
|
||||
order: 3
|
||||
},
|
||||
extensionoptions: {
|
||||
title: 'ExtensionOptions',
|
||||
description: 'Options object for defineExtension — app-wide lifecycle and shell UI.',
|
||||
group: 'core',
|
||||
order: 4
|
||||
},
|
||||
nodeextensionoptions: {
|
||||
title: 'NodeExtensionOptions',
|
||||
description: 'Options object for defineNodeExtension — node lifecycle hooks.',
|
||||
group: 'core',
|
||||
order: 5
|
||||
},
|
||||
widgetextensionoptions: {
|
||||
title: 'WidgetExtensionOptions',
|
||||
description: 'Options object for defineWidgetExtension — custom widget rendering.',
|
||||
group: 'core',
|
||||
order: 6
|
||||
},
|
||||
onnoderemoved: {
|
||||
title: 'onNodeRemoved',
|
||||
sidebarTitle: 'onNodeRemoved',
|
||||
description: 'Implicit-context lifecycle hook: fires when a node is removed from the graph.',
|
||||
group: 'core',
|
||||
order: 7
|
||||
},
|
||||
onnodemounted: {
|
||||
title: 'onNodeMounted',
|
||||
sidebarTitle: 'onNodeMounted',
|
||||
description: 'Implicit-context lifecycle hook: fires when a node is fully mounted.',
|
||||
group: 'core',
|
||||
order: 8
|
||||
},
|
||||
// Handles
|
||||
nodehandle: {
|
||||
title: 'NodeHandle',
|
||||
description: 'Controlled access to node state, mutations, slots, and events.',
|
||||
icon: 'circle-nodes',
|
||||
group: 'handles',
|
||||
order: 10
|
||||
},
|
||||
widgethandle: {
|
||||
title: 'WidgetHandle',
|
||||
description: 'Controlled access to widget state, mutations, and events.',
|
||||
icon: 'sliders',
|
||||
group: 'handles',
|
||||
order: 11
|
||||
},
|
||||
slotinfo: {
|
||||
title: 'SlotInfo',
|
||||
description: 'Read-only snapshot of a node slot (input or output).',
|
||||
group: 'handles',
|
||||
order: 12
|
||||
},
|
||||
// Events
|
||||
nodeexecutedevent: {
|
||||
title: 'NodeExecutedEvent',
|
||||
description: 'Payload fired when a node finishes execution.',
|
||||
group: 'events',
|
||||
order: 20
|
||||
},
|
||||
nodeconnectedevent: {
|
||||
title: 'NodeConnectedEvent',
|
||||
description: 'Payload fired when a slot connection is made.',
|
||||
group: 'events',
|
||||
order: 21
|
||||
},
|
||||
nodedisconnectedevent: {
|
||||
title: 'NodeDisconnectedEvent',
|
||||
description: 'Payload fired when a slot connection is removed.',
|
||||
group: 'events',
|
||||
order: 22
|
||||
},
|
||||
nodepositionchangedevent: {
|
||||
title: 'NodePositionChangedEvent',
|
||||
description: 'Payload fired when a node is moved on the canvas.',
|
||||
group: 'events',
|
||||
order: 23
|
||||
},
|
||||
nodesizechangedevent: {
|
||||
title: 'NodeSizeChangedEvent',
|
||||
description: 'Payload fired when a node is resized.',
|
||||
group: 'events',
|
||||
order: 24
|
||||
},
|
||||
nodemodechangedevent: {
|
||||
title: 'NodeModeChangedEvent',
|
||||
description: 'Payload fired when a node execution mode changes.',
|
||||
group: 'events',
|
||||
order: 25
|
||||
},
|
||||
nodebeforeserializeevent: {
|
||||
title: 'NodeBeforeSerializeEvent',
|
||||
description: 'Pre-serialization hook payload — override or skip node data.',
|
||||
group: 'events',
|
||||
order: 26
|
||||
},
|
||||
widgetvaluechangeevent: {
|
||||
title: 'WidgetValueChangeEvent',
|
||||
description: 'Payload fired when a widget value changes.',
|
||||
group: 'events',
|
||||
order: 27
|
||||
},
|
||||
widgetbeforeserializeevent: {
|
||||
title: 'WidgetBeforeSerializeEvent',
|
||||
description: 'Pre-serialization hook payload — override or skip widget value.',
|
||||
group: 'events',
|
||||
order: 28
|
||||
},
|
||||
widgetbeforequeueevent: {
|
||||
title: 'WidgetBeforeQueueEvent',
|
||||
description: 'Pre-queue validation payload — call reject() to cancel queue.',
|
||||
group: 'events',
|
||||
order: 29
|
||||
},
|
||||
// Shell UI
|
||||
sidebartabextension: {
|
||||
title: 'SidebarTabExtension',
|
||||
description: 'Register a custom sidebar tab.',
|
||||
group: 'shell',
|
||||
order: 40
|
||||
},
|
||||
bottompanelextension: {
|
||||
title: 'BottomPanelExtension',
|
||||
description: 'Register a custom bottom panel tab.',
|
||||
group: 'shell',
|
||||
order: 41
|
||||
},
|
||||
toastmanager: {
|
||||
title: 'ToastManager',
|
||||
description: 'Show toast notifications to the user.',
|
||||
group: 'shell',
|
||||
order: 42
|
||||
},
|
||||
commandmanager: {
|
||||
title: 'CommandManager',
|
||||
description: 'Register keyboard shortcuts and command palette entries.',
|
||||
group: 'shell',
|
||||
order: 43
|
||||
},
|
||||
extensionmanager: {
|
||||
title: 'ExtensionManager',
|
||||
description: 'Access shell UI registration APIs.',
|
||||
group: 'shell',
|
||||
order: 44
|
||||
},
|
||||
// Identity
|
||||
nodelocatorid: {
|
||||
title: 'NodeLocatorId',
|
||||
description: 'Branded string ID that uniquely locates a node across graph snapshots.',
|
||||
group: 'identity',
|
||||
order: 50
|
||||
},
|
||||
nodeexecutionid: {
|
||||
title: 'NodeExecutionId',
|
||||
description: 'Branded string ID for a specific node execution run.',
|
||||
group: 'identity',
|
||||
order: 51
|
||||
}
|
||||
}
|
||||
|
||||
const GROUP_LABELS: Record<PageMeta['group'], string> = {
|
||||
root: 'Extensions API',
|
||||
core: 'Registration',
|
||||
handles: 'Handles',
|
||||
events: 'Events',
|
||||
shell: 'Shell UI',
|
||||
identity: 'Identity'
|
||||
}
|
||||
|
||||
// ── Utilities ────────────────────────────────────────────────────────────────
|
||||
|
||||
function slug(stem: string): string {
|
||||
return stem.toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/^-|-$/g, '')
|
||||
}
|
||||
|
||||
function metaFor(stem: string): PageMeta {
|
||||
const key = stem.toLowerCase().replace(/[^a-z]/g, '')
|
||||
return (
|
||||
PAGE_META[key] ?? {
|
||||
title: stem,
|
||||
description: `API reference for ${stem}.`,
|
||||
group: 'core',
|
||||
order: 99
|
||||
}
|
||||
)
|
||||
}
|
||||
|
||||
/** Convert TypeDoc raw markdown to Mintlify-compatible MDX. */
|
||||
function toMintlifyMdx(raw: string, stem: string): string {
|
||||
const meta = metaFor(stem)
|
||||
|
||||
// Build frontmatter
|
||||
const fm: string[] = [
|
||||
`---`,
|
||||
`title: "${meta.title}"`,
|
||||
...(meta.sidebarTitle ? [`sidebarTitle: "${meta.sidebarTitle}"`] : []),
|
||||
`description: "${meta.description}"`,
|
||||
...(meta.icon ? [`icon: "${meta.icon}"`] : []),
|
||||
`---`
|
||||
]
|
||||
|
||||
let body = raw
|
||||
|
||||
// Strip TypeDoc breadcrumb header lines (e.g. "[**@comfyorg/...**](../index.md)\n\n***\n\n[@comfyorg...]...")
|
||||
body = body.replace(/^\[.*?\]\(\.\.\/index\.md\)\n+\*+\n+/gm, '')
|
||||
body = body.replace(/^\[.*?\]\(\.\.\/index\.md\).*\n+/gm, '')
|
||||
|
||||
// Remove the TypeDoc-generated H1 (we use frontmatter title instead)
|
||||
body = body.replace(/^# .+\n+/, '')
|
||||
|
||||
// Ensure opening code fences that have no lang tag get `ts`
|
||||
// Only match a ``` that is immediately followed by a newline (opening fence),
|
||||
// not a closing fence (which also has just ``` + newline but we can detect
|
||||
// by context: opening fences follow non-fence lines; closing fences follow content).
|
||||
// Simpler heuristic: replace ``` at start of line only when not already closing a block.
|
||||
// We track state via a flag pass instead of a single regex.
|
||||
let inBlock = false
|
||||
body = body
|
||||
.split('\n')
|
||||
.map((line) => {
|
||||
if (inBlock) {
|
||||
if (line.trim() === '```') { inBlock = false; return line }
|
||||
return line
|
||||
}
|
||||
if (line.startsWith('```')) {
|
||||
if (line.trim() === '```') {
|
||||
// bare opening fence → add ts
|
||||
inBlock = true
|
||||
return '```ts'
|
||||
}
|
||||
// has a lang tag already
|
||||
inBlock = true
|
||||
return line
|
||||
}
|
||||
return line
|
||||
})
|
||||
.join('\n')
|
||||
|
||||
// TypeDoc emits `typescript` lang tag; normalize to `ts`
|
||||
body = body.replace(/^```typescript\b/gm, '```ts')
|
||||
|
||||
// Fix TypeDoc cross-ref links: [TypeName](../type-alias/TypeName.md) → relative MDX paths
|
||||
// Pattern: [Label](../category/FileName.md) → [Label](./filename)
|
||||
body = body.replace(
|
||||
/\[([^\]]+)\]\(\.\.\/([\w-]+)\/([\w-]+)\.md\)/g,
|
||||
(_match, label, _category, file) => `[${label}](./${slug(file)})`
|
||||
)
|
||||
// Same-dir links
|
||||
body = body.replace(
|
||||
/\[([^\]]+)\]\(([\w-]+)\.md\)/g,
|
||||
(_match, label, file) => `[${label}](./${slug(file)})`
|
||||
)
|
||||
|
||||
// TypeDoc wraps @example content in a "## Example" heading; Mintlify prefers
|
||||
// code examples to be directly under prose without a sub-heading.
|
||||
// Flatten "## Example\n\n```ts" → "```ts"
|
||||
body = body.replace(/^## Example\s*\n+/gm, '')
|
||||
|
||||
// Stability tags: render as a <Tip> callout
|
||||
body = body.replace(
|
||||
/\*\*Stability\*\*: `(stable|experimental|deprecated)`/g,
|
||||
(_match, level) => {
|
||||
const label =
|
||||
level === 'stable'
|
||||
? '<Tip>**Stability:** Stable — part of the public API contract.</Tip>'
|
||||
: level === 'experimental'
|
||||
? '<Warning>**Stability:** Experimental — may change before 1.0.</Warning>'
|
||||
: '<Warning>**Stability:** Deprecated — will be removed. See migration guide.</Warning>'
|
||||
return label
|
||||
}
|
||||
)
|
||||
|
||||
// @stability TSDoc tag (appears as plain text after TypeDoc strips tags)
|
||||
body = body.replace(
|
||||
/^Stability: (stable|experimental|deprecated)\s*$/gm,
|
||||
(_match, level) => {
|
||||
if (level === 'stable') return '<Tip>**Stability:** Stable</Tip>'
|
||||
if (level === 'experimental') return '<Warning>**Stability:** Experimental</Warning>'
|
||||
return '<Warning>**Stability:** Deprecated</Warning>'
|
||||
}
|
||||
)
|
||||
|
||||
return [...fm, '', body.trim(), ''].join('\n')
|
||||
}
|
||||
|
||||
// ── Nav snippet builder ───────────────────────────────────────────────────────
|
||||
|
||||
interface NavPage {
|
||||
group?: string
|
||||
pages: (string | NavPage)[]
|
||||
}
|
||||
|
||||
function buildNavSnippet(stems: string[]): NavPage {
|
||||
const byGroup: Record<string, string[]> = {}
|
||||
|
||||
for (const stem of stems) {
|
||||
const meta = metaFor(stem)
|
||||
const group = meta.group
|
||||
if (!byGroup[group]) byGroup[group] = []
|
||||
byGroup[group].push(`extensions/api/${slug(stem)}`)
|
||||
}
|
||||
|
||||
// Sort each group by order
|
||||
const sortedStems = stems.slice().sort((a, b) => metaFor(a).order - metaFor(b).order)
|
||||
const sortedByGroup: Record<string, string[]> = {}
|
||||
for (const stem of sortedStems) {
|
||||
const group = metaFor(stem).group
|
||||
if (!sortedByGroup[group]) sortedByGroup[group] = []
|
||||
sortedByGroup[group].push(`extensions/api/${slug(stem)}`)
|
||||
}
|
||||
|
||||
const groupOrder: PageMeta['group'][] = ['root', 'core', 'handles', 'events', 'shell', 'identity']
|
||||
|
||||
const pages: (string | NavPage)[] = []
|
||||
|
||||
// Overview at top level
|
||||
if (sortedByGroup['root']) {
|
||||
for (const p of sortedByGroup['root']) pages.push(p)
|
||||
}
|
||||
|
||||
for (const grp of groupOrder) {
|
||||
if (grp === 'root') continue
|
||||
const grpPages = sortedByGroup[grp]
|
||||
if (!grpPages?.length) continue
|
||||
pages.push({ group: GROUP_LABELS[grp], pages: grpPages })
|
||||
}
|
||||
|
||||
return { group: 'Extensions API', pages }
|
||||
}
|
||||
|
||||
// ── Main pipeline ────────────────────────────────────────────────────────────
|
||||
|
||||
function runTypedoc(): void {
|
||||
console.log('▶ Running TypeDoc...')
|
||||
execSync(
|
||||
`npx typedoc --options ${path.join(pkgRoot, 'typedoc.json')} --out ${rawDir}`,
|
||||
{ cwd: pkgRoot, stdio: 'inherit' }
|
||||
)
|
||||
}
|
||||
|
||||
function processFiles(): void {
|
||||
if (!fs.existsSync(rawDir)) {
|
||||
throw new Error(`TypeDoc output directory not found: ${rawDir}`)
|
||||
}
|
||||
|
||||
fs.mkdirSync(mintlifyDir, { recursive: true })
|
||||
|
||||
const mdFiles = fs.readdirSync(rawDir, { recursive: true })
|
||||
.filter((f): f is string => typeof f === 'string' && f.endsWith('.md'))
|
||||
|
||||
const stems: string[] = []
|
||||
|
||||
for (const relPath of mdFiles) {
|
||||
const src = path.join(rawDir, relPath)
|
||||
const stem = path.basename(relPath, '.md')
|
||||
const raw = fs.readFileSync(src, 'utf8')
|
||||
const mdx = toMintlifyMdx(raw, stem)
|
||||
|
||||
const destName = slug(stem) + '.mdx'
|
||||
const dest = path.join(mintlifyDir, destName)
|
||||
fs.writeFileSync(dest, mdx)
|
||||
console.log(` ✔ ${relPath} → mintlify/${destName}`)
|
||||
stems.push(stem)
|
||||
}
|
||||
|
||||
// Write nav snippet
|
||||
const nav = buildNavSnippet(stems)
|
||||
const navDest = path.join(mintlifyDir, 'nav-snippet.json')
|
||||
fs.writeFileSync(navDest, JSON.stringify(nav, null, 2) + '\n')
|
||||
console.log(` ✔ nav-snippet.json`)
|
||||
|
||||
console.log(`\n✅ Mintlify MDX written to: ${mintlifyDir}`)
|
||||
console.log(` ${stems.length} pages + nav-snippet.json`)
|
||||
}
|
||||
|
||||
function run(): void {
|
||||
runTypedoc()
|
||||
processFiles()
|
||||
}
|
||||
|
||||
if (watchMode) {
|
||||
// Simple watch: re-run on change to source files
|
||||
console.log('👁 Watch mode — watching src/extension-api/**')
|
||||
const srcDir = path.resolve(pkgRoot, '../../src/extension-api')
|
||||
let debounce: ReturnType<typeof setTimeout> | null = null
|
||||
|
||||
run()
|
||||
|
||||
fs.watch(srcDir, { recursive: true }, () => {
|
||||
if (debounce) clearTimeout(debounce)
|
||||
debounce = setTimeout(() => {
|
||||
console.log('\n🔄 Source changed — rebuilding...')
|
||||
try { run() } catch (e) { console.error(e) }
|
||||
}, 500)
|
||||
})
|
||||
} else {
|
||||
run()
|
||||
}
|
||||
21
packages/extension-api/tsconfig.docs.json
Normal file
@@ -0,0 +1,21 @@
|
||||
{
|
||||
"compilerOptions": {
|
||||
"target": "ES2022",
|
||||
"module": "ESNext",
|
||||
"moduleResolution": "bundler",
|
||||
"strict": true,
|
||||
"skipLibCheck": true,
|
||||
"noEmit": true,
|
||||
"paths": {
|
||||
"@/*": ["../../src/*"]
|
||||
}
|
||||
},
|
||||
"include": [
|
||||
"../../src/extension-api/**/*.ts"
|
||||
],
|
||||
"exclude": [
|
||||
"../../src/**/*.test.ts",
|
||||
"../../src/**/*.spec.ts",
|
||||
"../../src/**/*.vue"
|
||||
]
|
||||
}
|
||||
37
packages/extension-api/typedoc.json
Normal file
@@ -0,0 +1,37 @@
|
||||
{
|
||||
"entryPoints": ["../../src/extension-api/index.ts"],
|
||||
"tsconfig": "./tsconfig.docs.json",
|
||||
"out": "./docs-build/raw",
|
||||
"plugin": ["typedoc-plugin-markdown"],
|
||||
"excludeInternal": true,
|
||||
"excludePrivate": true,
|
||||
"excludeProtected": true,
|
||||
"readme": "none",
|
||||
"skipErrorChecking": true,
|
||||
"githubPages": false,
|
||||
"blockTags": ["@stability", "@packageDocumentation", "@example", "@typeParam", "@returns", "@deprecated", "@remarks"],
|
||||
"hideGenerator": true,
|
||||
"useCodeBlocks": true,
|
||||
"flattenOutputFiles": false,
|
||||
"entryFileName": "index",
|
||||
"fileExtension": ".md",
|
||||
"outputFileStrategy": "members",
|
||||
"hidePageHeader": false,
|
||||
"hideBreadcrumbs": false,
|
||||
"useHTMLAnchors": false,
|
||||
"sanitizeComments": true,
|
||||
"expandObjects": false,
|
||||
"parametersFormat": "table",
|
||||
"propertiesFormat": "table",
|
||||
"typeDeclarationFormat": "table",
|
||||
"indexFormat": "table",
|
||||
"tableColumnSettings": {
|
||||
"hideDefaults": false,
|
||||
"hideInherited": false,
|
||||
"hideModifiers": false,
|
||||
"hideOverrides": false,
|
||||
"hideSources": true,
|
||||
"hideValues": false,
|
||||
"leftAlignHeaders": false
|
||||
}
|
||||
}
|
||||
@@ -3,6 +3,7 @@
|
||||
"LoadImage": 3474,
|
||||
"CLIPTextEncode": 2435,
|
||||
"SaveImage": 1762,
|
||||
"SaveImageAdvanced": 1762,
|
||||
"VAEDecode": 1754,
|
||||
"KSampler": 1511,
|
||||
"CheckpointLoaderSimple": 1293,
|
||||
|
||||
@@ -19,6 +19,7 @@ import subprocess
|
||||
|
||||
import av
|
||||
from PIL import Image
|
||||
from PIL.PngImagePlugin import PngInfo
|
||||
|
||||
REPO_ROOT = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
|
||||
FIXTURES_DIR = os.path.join(REPO_ROOT, 'src', 'scripts', 'metadata', '__fixtures__')
|
||||
@@ -115,6 +116,15 @@ def generate_av_fixture(
|
||||
report(name)
|
||||
|
||||
|
||||
def generate_png():
|
||||
img = make_1x1_image()
|
||||
info = PngInfo()
|
||||
info.add_text('workflow', WORKFLOW_JSON)
|
||||
info.add_text('prompt', PROMPT_JSON)
|
||||
img.save(out('with_metadata.png'), 'PNG', pnginfo=info)
|
||||
report('with_metadata.png')
|
||||
|
||||
|
||||
def generate_webp():
|
||||
img = make_1x1_image()
|
||||
exif = build_exif_bytes()
|
||||
@@ -167,6 +177,7 @@ def generate_webm():
|
||||
|
||||
if __name__ == '__main__':
|
||||
print('Generating fixtures...')
|
||||
generate_png()
|
||||
generate_webp()
|
||||
generate_avif()
|
||||
generate_flac()
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import { render, screen } from '@testing-library/vue'
|
||||
import userEvent from '@testing-library/user-event'
|
||||
import { createPinia, setActivePinia } from 'pinia'
|
||||
import PrimeVue from 'primevue/config'
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
@@ -42,4 +43,43 @@ describe('ConfirmationDialogContent', () => {
|
||||
renderComponent({ message: longFilename })
|
||||
expect(screen.getByText(longFilename)).toBeInTheDocument()
|
||||
})
|
||||
|
||||
it('omits the Cancel button when type is dirtyClose', () => {
|
||||
renderComponent({ type: 'dirtyClose' })
|
||||
expect(screen.queryByText('g.cancel')).not.toBeInTheDocument()
|
||||
expect(screen.getByText('g.save')).toBeInTheDocument()
|
||||
})
|
||||
|
||||
it('uses the provided denyLabel for the deny button on dirtyClose', () => {
|
||||
renderComponent({ type: 'dirtyClose', denyLabel: 'Sign out anyway' })
|
||||
expect(screen.getByText('Sign out anyway')).toBeInTheDocument()
|
||||
expect(screen.queryByText('g.no')).not.toBeInTheDocument()
|
||||
})
|
||||
|
||||
it('calls onConfirm(false) when deny is clicked on dirtyClose', async () => {
|
||||
const onConfirm = vi.fn()
|
||||
renderComponent({
|
||||
type: 'dirtyClose',
|
||||
denyLabel: 'Close anyway',
|
||||
onConfirm
|
||||
})
|
||||
|
||||
await userEvent.click(screen.getByRole('button', { name: 'Close anyway' }))
|
||||
|
||||
expect(onConfirm).toHaveBeenCalledWith(false)
|
||||
})
|
||||
|
||||
it('calls onConfirm(true) when save is clicked on dirtyClose', async () => {
|
||||
const onConfirm = vi.fn()
|
||||
renderComponent({ type: 'dirtyClose', onConfirm })
|
||||
|
||||
await userEvent.click(screen.getByRole('button', { name: 'g.save' }))
|
||||
|
||||
expect(onConfirm).toHaveBeenCalledWith(true)
|
||||
})
|
||||
|
||||
it('falls back to "no" label when denyLabel is not provided', () => {
|
||||
renderComponent({ type: 'dirtyClose' })
|
||||
expect(screen.getByText('g.no')).toBeInTheDocument()
|
||||
})
|
||||
})
|
||||
|
||||
@@ -55,7 +55,7 @@
|
||||
</div>
|
||||
|
||||
<Button
|
||||
v-if="type !== 'info'"
|
||||
v-if="type !== 'info' && type !== 'dirtyClose'"
|
||||
variant="secondary"
|
||||
autofocus
|
||||
@click="onCancel"
|
||||
@@ -86,9 +86,9 @@
|
||||
<template v-else-if="type === 'dirtyClose'">
|
||||
<Button variant="secondary" @click="onDeny">
|
||||
<i class="pi pi-times" />
|
||||
{{ $t('g.no') }}
|
||||
{{ denyLabel ?? $t('g.no') }}
|
||||
</Button>
|
||||
<Button @click="onConfirm">
|
||||
<Button autofocus @click="onConfirm">
|
||||
<i class="pi pi-save" />
|
||||
{{ $t('g.save') }}
|
||||
</Button>
|
||||
@@ -131,6 +131,7 @@ const props = defineProps<{
|
||||
onConfirm: (value?: boolean) => void
|
||||
itemList?: string[]
|
||||
hint?: string
|
||||
denyLabel?: string
|
||||
}>()
|
||||
|
||||
const { t } = useI18n()
|
||||
|
||||
164
src/components/helpcenter/HelpCenterMenuContent.test.ts
Normal file
@@ -0,0 +1,164 @@
|
||||
import { cleanup, render, screen } from '@testing-library/vue'
|
||||
import userEvent from '@testing-library/user-event'
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
import { defineComponent, h } from 'vue'
|
||||
import { createI18n } from 'vue-i18n'
|
||||
|
||||
import enMessages from '@/locales/en/main.json' with { type: 'json' }
|
||||
|
||||
import HelpCenterMenuContent from './HelpCenterMenuContent.vue'
|
||||
|
||||
const distribution = vi.hoisted(() => ({
|
||||
isCloud: false,
|
||||
isDesktop: false,
|
||||
isNightly: false
|
||||
}))
|
||||
|
||||
const commandStoreExecute = vi.hoisted(() => vi.fn())
|
||||
|
||||
vi.mock('@/platform/distribution/types', () => ({
|
||||
get isCloud() {
|
||||
return distribution.isCloud
|
||||
},
|
||||
get isDesktop() {
|
||||
return distribution.isDesktop
|
||||
},
|
||||
get isNightly() {
|
||||
return distribution.isNightly
|
||||
}
|
||||
}))
|
||||
|
||||
vi.mock('@/composables/useExternalLink', () => ({
|
||||
useExternalLink: () => ({
|
||||
staticUrls: { discord: '', github: '' },
|
||||
buildDocsUrl: () => 'https://docs.comfy.org'
|
||||
})
|
||||
}))
|
||||
|
||||
vi.mock('@/platform/settings/settingStore', () => ({
|
||||
useSettingStore: () => ({
|
||||
get: () => false
|
||||
})
|
||||
}))
|
||||
|
||||
vi.mock('@/platform/telemetry', () => ({
|
||||
useTelemetry: () => ({
|
||||
trackHelpResourceClicked: vi.fn(),
|
||||
trackHelpCenterOpened: vi.fn(),
|
||||
trackHelpCenterClosed: vi.fn()
|
||||
})
|
||||
}))
|
||||
|
||||
vi.mock('@/platform/updates/common/releaseStore', () => ({
|
||||
useReleaseStore: () => ({
|
||||
releases: [],
|
||||
recentReleases: [],
|
||||
isLoading: false,
|
||||
fetchReleases: vi.fn().mockResolvedValue(undefined)
|
||||
})
|
||||
}))
|
||||
|
||||
vi.mock('@/stores/commandStore', () => ({
|
||||
useCommandStore: () => ({ execute: commandStoreExecute })
|
||||
}))
|
||||
|
||||
vi.mock('@/utils/envUtil', () => ({
|
||||
electronAPI: () => null
|
||||
}))
|
||||
|
||||
vi.mock(
|
||||
'@/workbench/extensions/manager/composables/useConflictAcknowledgment',
|
||||
() => ({
|
||||
useConflictAcknowledgment: () => ({ shouldShowRedDot: { value: false } })
|
||||
})
|
||||
)
|
||||
|
||||
vi.mock('@/workbench/extensions/manager/composables/useManagerState', () => ({
|
||||
useManagerState: () => ({ isNewManagerUI: { value: false } })
|
||||
}))
|
||||
|
||||
vi.mock('@/workbench/extensions/manager/services/comfyManagerService', () => ({
|
||||
useComfyManagerService: () => ({})
|
||||
}))
|
||||
|
||||
vi.mock('primevue/usetoast', () => ({
|
||||
useToast: () => ({ add: vi.fn() })
|
||||
}))
|
||||
|
||||
vi.mock('@/components/icons/PuzzleIcon.vue', () => ({
|
||||
default: defineComponent({
|
||||
name: 'PuzzleIconStub',
|
||||
render: () => h('div')
|
||||
})
|
||||
}))
|
||||
|
||||
function renderComponent() {
|
||||
const user = userEvent.setup()
|
||||
const i18n = createI18n({
|
||||
legacy: false,
|
||||
locale: 'en',
|
||||
messages: { en: enMessages }
|
||||
})
|
||||
|
||||
const result = render(HelpCenterMenuContent, {
|
||||
global: {
|
||||
plugins: [i18n]
|
||||
}
|
||||
})
|
||||
|
||||
return { user, ...result }
|
||||
}
|
||||
|
||||
describe('HelpCenterMenuContent feedback item', () => {
|
||||
let openSpy: ReturnType<typeof vi.spyOn>
|
||||
|
||||
beforeEach(() => {
|
||||
distribution.isCloud = false
|
||||
distribution.isDesktop = false
|
||||
distribution.isNightly = false
|
||||
commandStoreExecute.mockReset()
|
||||
openSpy = vi.spyOn(window, 'open').mockReturnValue(null)
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
openSpy.mockRestore()
|
||||
cleanup()
|
||||
})
|
||||
|
||||
it('opens the Typeform survey tagged with help-center source on Cloud', async () => {
|
||||
distribution.isCloud = true
|
||||
const { user } = renderComponent()
|
||||
|
||||
await user.click(screen.getByRole('menuitem', { name: 'Give Feedback' }))
|
||||
|
||||
expect(openSpy).toHaveBeenCalledWith(
|
||||
'https://form.typeform.com/to/q7azbWPi#distribution=ccloud&source=help-center',
|
||||
'_blank',
|
||||
'noopener,noreferrer'
|
||||
)
|
||||
expect(commandStoreExecute).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('opens the Typeform survey tagged with help-center source on Nightly', async () => {
|
||||
distribution.isNightly = true
|
||||
const { user } = renderComponent()
|
||||
|
||||
await user.click(screen.getByRole('menuitem', { name: 'Give Feedback' }))
|
||||
|
||||
expect(openSpy).toHaveBeenCalledWith(
|
||||
'https://form.typeform.com/to/q7azbWPi#distribution=oss-nightly&source=help-center',
|
||||
'_blank',
|
||||
'noopener,noreferrer'
|
||||
)
|
||||
expect(commandStoreExecute).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('falls back to Comfy.ContactSupport on OSS builds', async () => {
|
||||
const { user } = renderComponent()
|
||||
|
||||
await user.click(screen.getByRole('menuitem', { name: 'Give Feedback' }))
|
||||
|
||||
expect(openSpy).not.toHaveBeenCalled()
|
||||
expect(commandStoreExecute).toHaveBeenCalledWith('Comfy.ContactSupport')
|
||||
})
|
||||
})
|
||||
@@ -163,6 +163,7 @@ import PuzzleIcon from '@/components/icons/PuzzleIcon.vue'
|
||||
import { useExternalLink } from '@/composables/useExternalLink'
|
||||
import { isCloud, isDesktop, isNightly } from '@/platform/distribution/types'
|
||||
import { useSettingStore } from '@/platform/settings/settingStore'
|
||||
import { buildFeedbackTypeformUrl } from '@/platform/support/config'
|
||||
import { useTelemetry } from '@/platform/telemetry'
|
||||
import type { ReleaseNote } from '@/platform/updates/common/releaseService'
|
||||
import { useReleaseStore } from '@/platform/updates/common/releaseStore'
|
||||
@@ -306,7 +307,7 @@ const menuItems = computed<MenuItem[]>(() => {
|
||||
trackResourceClick('help_feedback', isCloud || isNightly)
|
||||
if (isCloud || isNightly) {
|
||||
window.open(
|
||||
'https://form.typeform.com/to/q7azbWPi',
|
||||
buildFeedbackTypeformUrl('help-center'),
|
||||
'_blank',
|
||||
'noopener,noreferrer'
|
||||
)
|
||||
|
||||
334
src/components/painter/WidgetPainter.test.ts
Normal file
@@ -0,0 +1,334 @@
|
||||
import { fireEvent, render, screen, within } from '@testing-library/vue'
|
||||
import userEvent from '@testing-library/user-event'
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
import { defineComponent, ref } from 'vue'
|
||||
import { createI18n } from 'vue-i18n'
|
||||
|
||||
const sizeHolder = vi.hoisted(() => ({ width: 0, height: 0 }))
|
||||
|
||||
vi.mock('@vueuse/core', async (importOriginal) => {
|
||||
const actual = await importOriginal()
|
||||
return {
|
||||
...(actual as object),
|
||||
useElementSize: () => ({
|
||||
width: ref(sizeHolder.width),
|
||||
height: ref(sizeHolder.height)
|
||||
})
|
||||
}
|
||||
})
|
||||
|
||||
const painterHolder = vi.hoisted(() => ({
|
||||
state: null as Record<string, unknown> | null
|
||||
}))
|
||||
|
||||
function createDefaultPainterState() {
|
||||
return {
|
||||
tool: ref('brush'),
|
||||
brushSize: ref(20),
|
||||
brushColor: ref('#000000'),
|
||||
brushOpacity: ref(1),
|
||||
brushHardness: ref(1),
|
||||
backgroundColor: ref('#ffffff'),
|
||||
canvasWidth: ref(512),
|
||||
canvasHeight: ref(512),
|
||||
cursorVisible: ref(true),
|
||||
displayBrushSize: ref(20),
|
||||
inputImageUrl: ref<string | null>(null),
|
||||
isImageInputConnected: ref(false),
|
||||
handlePointerDown: vi.fn(),
|
||||
handlePointerMove: vi.fn(),
|
||||
handlePointerUp: vi.fn(),
|
||||
handlePointerEnter: vi.fn(),
|
||||
handlePointerLeave: vi.fn(),
|
||||
handleInputImageLoad: vi.fn(),
|
||||
handleClear: vi.fn()
|
||||
}
|
||||
}
|
||||
|
||||
vi.mock('@/composables/painter/usePainter', () => ({
|
||||
PAINTER_TOOLS: { BRUSH: 'brush', ERASER: 'eraser' } as const,
|
||||
usePainter: () => {
|
||||
if (!painterHolder.state) painterHolder.state = createDefaultPainterState()
|
||||
return painterHolder.state
|
||||
}
|
||||
}))
|
||||
|
||||
import WidgetPainter from './WidgetPainter.vue'
|
||||
|
||||
const i18n = createI18n({
|
||||
legacy: false,
|
||||
locale: 'en',
|
||||
messages: {
|
||||
en: {
|
||||
painter: {
|
||||
tool: 'Tool',
|
||||
brush: 'Brush',
|
||||
eraser: 'Eraser',
|
||||
size: 'Size',
|
||||
color: 'Color',
|
||||
hardness: 'Hardness',
|
||||
width: 'Width',
|
||||
height: 'Height',
|
||||
background: 'Background',
|
||||
clear: 'Clear'
|
||||
}
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
const ButtonStub = defineComponent({
|
||||
name: 'Button',
|
||||
inheritAttrs: false,
|
||||
template: '<button v-bind="$attrs" type="button"><slot /></button>'
|
||||
})
|
||||
|
||||
const SliderStub = defineComponent({
|
||||
name: 'Slider',
|
||||
props: {
|
||||
modelValue: { type: Array, default: () => [] },
|
||||
min: Number,
|
||||
max: Number,
|
||||
step: Number
|
||||
},
|
||||
emits: ['update:modelValue'],
|
||||
template:
|
||||
'<div data-testid="slider-stub" :data-min="min" @click="$emit(\'update:modelValue\', [Number(min) + Number(step ?? 1)])" />'
|
||||
})
|
||||
|
||||
function primePainterState(overrides: Record<string, unknown> = {}) {
|
||||
painterHolder.state = { ...createDefaultPainterState(), ...overrides }
|
||||
}
|
||||
|
||||
function renderWidget(initialModel = '') {
|
||||
const value = ref(initialModel)
|
||||
const Harness = defineComponent({
|
||||
components: { WidgetPainter },
|
||||
setup: () => ({ value }),
|
||||
template: '<WidgetPainter v-model="value" node-id="42" />'
|
||||
})
|
||||
return render(Harness, {
|
||||
global: {
|
||||
plugins: [i18n],
|
||||
stubs: { Button: ButtonStub, Slider: SliderStub }
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
describe('WidgetPainter', () => {
|
||||
beforeEach(() => {
|
||||
sizeHolder.width = 0
|
||||
sizeHolder.height = 0
|
||||
painterHolder.state = null
|
||||
})
|
||||
|
||||
describe('Label visibility', () => {
|
||||
const allLabels = [
|
||||
'Tool',
|
||||
'Size',
|
||||
'Color',
|
||||
'Hardness',
|
||||
'Width',
|
||||
'Height',
|
||||
'Background'
|
||||
]
|
||||
|
||||
it('renders every label in wide layout (width >= 350)', () => {
|
||||
sizeHolder.width = 600
|
||||
primePainterState()
|
||||
renderWidget()
|
||||
for (const label of allLabels) {
|
||||
expect(screen.getByText(label)).toBeInTheDocument()
|
||||
}
|
||||
})
|
||||
|
||||
it('still renders every label in compact layout (width < 350)', () => {
|
||||
sizeHolder.width = 200
|
||||
primePainterState()
|
||||
renderWidget()
|
||||
for (const label of allLabels) {
|
||||
expect(screen.getByText(label)).toBeInTheDocument()
|
||||
}
|
||||
})
|
||||
|
||||
it('keeps labels at the responsive boundary (width = 350)', () => {
|
||||
sizeHolder.width = 350
|
||||
primePainterState()
|
||||
renderWidget()
|
||||
for (const label of allLabels) {
|
||||
expect(screen.getByText(label)).toBeInTheDocument()
|
||||
}
|
||||
})
|
||||
})
|
||||
|
||||
describe('Image-input branch', () => {
|
||||
it('hides canvas-size and background controls when an image is connected', () => {
|
||||
primePainterState({
|
||||
isImageInputConnected: ref(true),
|
||||
inputImageUrl: ref('/img.png')
|
||||
})
|
||||
renderWidget()
|
||||
|
||||
expect(screen.queryByText('Width')).toBeNull()
|
||||
expect(screen.queryByText('Height')).toBeNull()
|
||||
expect(screen.queryByText('Background')).toBeNull()
|
||||
expect(screen.getByTestId('painter-dimension-text')).toBeInTheDocument()
|
||||
})
|
||||
|
||||
it('renders the input image inside the canvas container', () => {
|
||||
primePainterState({
|
||||
isImageInputConnected: ref(true),
|
||||
inputImageUrl: ref('/img.png')
|
||||
})
|
||||
renderWidget()
|
||||
|
||||
const container = screen.getByTestId('painter-canvas-container')
|
||||
expect(within(container).getByRole('img')).toBeInTheDocument()
|
||||
})
|
||||
})
|
||||
|
||||
describe('Tool selection', () => {
|
||||
it('hides brush-only controls when the eraser tool is active', () => {
|
||||
primePainterState({ tool: ref('eraser') })
|
||||
renderWidget()
|
||||
|
||||
expect(screen.queryByText('Color')).toBeNull()
|
||||
expect(screen.queryByText('Hardness')).toBeNull()
|
||||
})
|
||||
|
||||
it('updates the active tool when clicking brush/eraser buttons', async () => {
|
||||
const tool = ref<'brush' | 'eraser'>('brush')
|
||||
primePainterState({ tool })
|
||||
renderWidget()
|
||||
const user = userEvent.setup()
|
||||
|
||||
await user.click(screen.getByText('Eraser'))
|
||||
expect(tool.value).toBe('eraser')
|
||||
|
||||
await user.click(screen.getByText('Brush'))
|
||||
expect(tool.value).toBe('brush')
|
||||
})
|
||||
})
|
||||
|
||||
describe('Canvas events', () => {
|
||||
it('forwards pointerdown/up to the composable on click', async () => {
|
||||
primePainterState()
|
||||
renderWidget()
|
||||
const user = userEvent.setup()
|
||||
|
||||
await user.click(screen.getByTestId('painter-canvas'))
|
||||
|
||||
const s = painterHolder.state!
|
||||
expect(s.handlePointerDown).toHaveBeenCalled()
|
||||
expect(s.handlePointerUp).toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('forwards pointerenter/leave to the composable on hover', async () => {
|
||||
primePainterState()
|
||||
renderWidget()
|
||||
const user = userEvent.setup()
|
||||
const canvas = screen.getByTestId('painter-canvas')
|
||||
|
||||
await user.hover(canvas)
|
||||
await user.unhover(canvas)
|
||||
|
||||
const s = painterHolder.state!
|
||||
expect(s.handlePointerEnter).toHaveBeenCalled()
|
||||
expect(s.handlePointerLeave).toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('invokes handleInputImageLoad when the input image fires load', async () => {
|
||||
primePainterState({
|
||||
isImageInputConnected: ref(true),
|
||||
inputImageUrl: ref('/img.png')
|
||||
})
|
||||
renderWidget()
|
||||
|
||||
const img = within(
|
||||
screen.getByTestId('painter-canvas-container')
|
||||
).getByRole('img')
|
||||
await fireEvent.load(img)
|
||||
expect(painterHolder.state!.handleInputImageLoad).toHaveBeenCalled()
|
||||
})
|
||||
})
|
||||
|
||||
describe('Control bindings', () => {
|
||||
it('invokes handleClear when the clear button is clicked', async () => {
|
||||
primePainterState()
|
||||
renderWidget()
|
||||
const user = userEvent.setup()
|
||||
|
||||
await user.click(screen.getByTestId('painter-clear-button'))
|
||||
expect(painterHolder.state!.handleClear).toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('updates brushSize via the size slider', async () => {
|
||||
const brushSize = ref(20)
|
||||
primePainterState({ brushSize })
|
||||
renderWidget()
|
||||
const user = userEvent.setup()
|
||||
|
||||
const slider = within(screen.getByTestId('painter-size-row')).getByTestId(
|
||||
'slider-stub'
|
||||
)
|
||||
await user.click(slider)
|
||||
expect(brushSize.value).toBe(2) // min=1, step=1 -> emits 2
|
||||
})
|
||||
|
||||
it('updates brushColor via the color picker', async () => {
|
||||
const brushColor = ref('#000000')
|
||||
primePainterState({ brushColor })
|
||||
renderWidget()
|
||||
|
||||
const colorInput = within(
|
||||
screen.getByTestId('painter-color-row')
|
||||
).getByDisplayValue('#000000')
|
||||
// <input type="color"> has no userEvent equivalent — fire input directly
|
||||
// eslint-disable-next-line testing-library/prefer-user-event
|
||||
await fireEvent.input(colorInput, { target: { value: '#ff0000' } })
|
||||
expect(brushColor.value.toLowerCase()).toBe('#ff0000')
|
||||
})
|
||||
|
||||
it('updates brushOpacity via the percent input', async () => {
|
||||
const brushOpacity = ref(1)
|
||||
primePainterState({ brushOpacity })
|
||||
renderWidget()
|
||||
const user = userEvent.setup()
|
||||
|
||||
const percentInput = within(
|
||||
screen.getByTestId('painter-color-row')
|
||||
).getByDisplayValue('100')
|
||||
await user.clear(percentInput)
|
||||
await user.type(percentInput, '50')
|
||||
await user.tab() // blur to trigger @change
|
||||
expect(brushOpacity.value).toBeCloseTo(0.5)
|
||||
})
|
||||
|
||||
it('clamps opacity input to the 0-100 range', async () => {
|
||||
const brushOpacity = ref(1)
|
||||
primePainterState({ brushOpacity })
|
||||
renderWidget()
|
||||
const user = userEvent.setup()
|
||||
|
||||
const percentInput = within(
|
||||
screen.getByTestId('painter-color-row')
|
||||
).getByDisplayValue('100')
|
||||
await user.clear(percentInput)
|
||||
await user.type(percentInput, '999')
|
||||
await user.tab()
|
||||
expect(brushOpacity.value).toBe(1) // clamped to 100% -> 1.0
|
||||
})
|
||||
|
||||
it('updates background color via the bg color input', async () => {
|
||||
const backgroundColor = ref('#ffffff')
|
||||
primePainterState({ backgroundColor })
|
||||
renderWidget()
|
||||
|
||||
const bgInput = within(
|
||||
screen.getByTestId('painter-bg-color-row')
|
||||
).getByDisplayValue('#ffffff')
|
||||
// eslint-disable-next-line testing-library/prefer-user-event
|
||||
await fireEvent.input(bgInput, { target: { value: '#00ff00' } })
|
||||
expect(backgroundColor.value.toLowerCase()).toBe('#00ff00')
|
||||
})
|
||||
})
|
||||
})
|
||||
@@ -23,6 +23,7 @@
|
||||
/>
|
||||
<canvas
|
||||
ref="canvasEl"
|
||||
data-testid="painter-canvas"
|
||||
class="absolute inset-0 size-full cursor-none touch-none"
|
||||
@pointerdown="handlePointerDown"
|
||||
@pointermove="handlePointerMove"
|
||||
@@ -58,7 +59,6 @@
|
||||
"
|
||||
>
|
||||
<div
|
||||
v-if="!compact"
|
||||
class="flex w-28 items-center truncate text-sm text-muted-foreground"
|
||||
>
|
||||
{{ $t('painter.tool') }}
|
||||
@@ -99,7 +99,6 @@
|
||||
</div>
|
||||
|
||||
<div
|
||||
v-if="!compact"
|
||||
class="flex w-28 items-center truncate text-sm text-muted-foreground"
|
||||
>
|
||||
{{ $t('painter.size') }}
|
||||
@@ -126,7 +125,6 @@
|
||||
|
||||
<template v-if="tool === PAINTER_TOOLS.BRUSH">
|
||||
<div
|
||||
v-if="!compact"
|
||||
class="flex w-28 items-center truncate text-sm text-muted-foreground"
|
||||
>
|
||||
{{ $t('painter.color') }}
|
||||
@@ -170,7 +168,6 @@
|
||||
</div>
|
||||
|
||||
<div
|
||||
v-if="!compact"
|
||||
class="flex w-28 items-center truncate text-sm text-muted-foreground"
|
||||
>
|
||||
{{ $t('painter.hardness') }}
|
||||
@@ -199,7 +196,6 @@
|
||||
|
||||
<template v-if="!isImageInputConnected">
|
||||
<div
|
||||
v-if="!compact"
|
||||
class="flex w-28 items-center truncate text-sm text-muted-foreground"
|
||||
>
|
||||
{{ $t('painter.width') }}
|
||||
@@ -222,7 +218,6 @@
|
||||
</div>
|
||||
|
||||
<div
|
||||
v-if="!compact"
|
||||
class="flex w-28 items-center truncate text-sm text-muted-foreground"
|
||||
>
|
||||
{{ $t('painter.height') }}
|
||||
@@ -245,7 +240,6 @@
|
||||
</div>
|
||||
|
||||
<div
|
||||
v-if="!compact"
|
||||
class="flex w-28 items-center truncate text-sm text-muted-foreground"
|
||||
>
|
||||
{{ $t('painter.background') }}
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
import { render, screen } from '@testing-library/vue'
|
||||
import userEvent from '@testing-library/user-event'
|
||||
import { describe, expect, it, vi } from 'vitest'
|
||||
import { ref } from 'vue'
|
||||
|
||||
import CompareSliderThumbnail from '@/components/templates/thumbnails/CompareSliderThumbnail.vue'
|
||||
|
||||
@@ -21,13 +21,19 @@ vi.mock('@/components/common/LazyImage.vue', () => ({
|
||||
}
|
||||
}))
|
||||
|
||||
vi.mock('@vueuse/core', () => ({
|
||||
useMouseInElement: () => ({
|
||||
elementX: ref(50),
|
||||
elementWidth: ref(100),
|
||||
isOutside: ref(false)
|
||||
})
|
||||
}))
|
||||
const mockRect = (el: HTMLElement, width: number) => {
|
||||
vi.spyOn(el, 'getBoundingClientRect').mockReturnValue({
|
||||
left: 0,
|
||||
top: 0,
|
||||
right: width,
|
||||
bottom: 100,
|
||||
width,
|
||||
height: 100,
|
||||
x: 0,
|
||||
y: 0,
|
||||
toJSON: () => ({})
|
||||
} as DOMRect)
|
||||
}
|
||||
|
||||
describe('CompareSliderThumbnail', () => {
|
||||
const renderThumbnail = (props = {}) => {
|
||||
@@ -74,4 +80,44 @@ describe('CompareSliderThumbnail', () => {
|
||||
const divider = screen.getByTestId('compare-slider-divider')
|
||||
expect(divider.style.left).toBe('50%')
|
||||
})
|
||||
|
||||
it('updates slider position on mousemove', async () => {
|
||||
renderThumbnail()
|
||||
const container = screen.getByTestId('compare-slider-container')
|
||||
mockRect(container, 200)
|
||||
|
||||
const user = userEvent.setup()
|
||||
await user.pointer({ target: container, coords: { clientX: 50 } })
|
||||
|
||||
const divider = screen.getByTestId('compare-slider-divider')
|
||||
expect(divider.style.left).toBe('25%')
|
||||
})
|
||||
|
||||
it('clamps slider position to [0, 100] when pointer overshoots', async () => {
|
||||
renderThumbnail()
|
||||
const container = screen.getByTestId('compare-slider-container')
|
||||
mockRect(container, 200)
|
||||
|
||||
const user = userEvent.setup()
|
||||
|
||||
await user.pointer({ target: container, coords: { clientX: -10 } })
|
||||
let divider = screen.getByTestId('compare-slider-divider')
|
||||
expect(divider.style.left).toBe('0%')
|
||||
|
||||
await user.pointer({ target: container, coords: { clientX: 250 } })
|
||||
divider = screen.getByTestId('compare-slider-divider')
|
||||
expect(divider.style.left).toBe('100%')
|
||||
})
|
||||
|
||||
it('ignores mousemove when container has zero width', async () => {
|
||||
renderThumbnail()
|
||||
const container = screen.getByTestId('compare-slider-container')
|
||||
mockRect(container, 0)
|
||||
|
||||
const user = userEvent.setup()
|
||||
await user.pointer({ target: container, coords: { clientX: 50 } })
|
||||
|
||||
const divider = screen.getByTestId('compare-slider-divider')
|
||||
expect(divider.style.left).toBe('50%')
|
||||
})
|
||||
})
|
||||
|
||||
@@ -9,7 +9,11 @@
|
||||
: 'max-w-full max-h-64 object-contain'
|
||||
"
|
||||
/>
|
||||
<div ref="containerRef" class="absolute inset-0">
|
||||
<div
|
||||
data-testid="compare-slider-container"
|
||||
class="absolute inset-0"
|
||||
@mousemove="updateSliderPosition"
|
||||
>
|
||||
<LazyImage
|
||||
:src="overlayImageSrc"
|
||||
:alt="alt"
|
||||
@@ -34,8 +38,7 @@
|
||||
</template>
|
||||
|
||||
<script setup lang="ts">
|
||||
import { useMouseInElement } from '@vueuse/core'
|
||||
import { ref, watch } from 'vue'
|
||||
import { ref } from 'vue'
|
||||
|
||||
import LazyImage from '@/components/common/LazyImage.vue'
|
||||
import BaseThumbnail from '@/components/templates/thumbnails/BaseThumbnail.vue'
|
||||
@@ -57,18 +60,20 @@ const isVideoType =
|
||||
false
|
||||
|
||||
const sliderPosition = ref(SLIDER_START_POSITION)
|
||||
const containerRef = ref<HTMLElement | null>(null)
|
||||
|
||||
const { elementX, elementWidth, isOutside } = useMouseInElement(containerRef)
|
||||
|
||||
// Update slider position based on mouse position when hovered
|
||||
watch(
|
||||
[() => isHovered, elementX, elementWidth, isOutside],
|
||||
([isHovered, x, width, outside]) => {
|
||||
if (!isHovered) return
|
||||
if (!outside) {
|
||||
sliderPosition.value = (x / width) * 100
|
||||
}
|
||||
}
|
||||
)
|
||||
/**
|
||||
* Update slider position from a local mousemove. Scoped to currentTarget so
|
||||
* only the hovered card reads its rect — unlike useMouseInElement which
|
||||
* attaches a global mousemove listener and fires for every mounted instance.
|
||||
*/
|
||||
function updateSliderPosition(event: MouseEvent) {
|
||||
const el = event.currentTarget as HTMLElement
|
||||
const rect = el.getBoundingClientRect()
|
||||
if (rect.width === 0) return
|
||||
// Clamp to [0, 100] — subpixel rounding or stale rects on hover-in can
|
||||
// push the raw percentage slightly out of range, which would offset the
|
||||
// divider past the container or invert the overlay's clipPath.
|
||||
const raw = ((event.clientX - rect.left) / rect.width) * 100
|
||||
sliderPosition.value = Math.max(0, Math.min(100, raw))
|
||||
}
|
||||
</script>
|
||||
|
||||
@@ -23,6 +23,7 @@
|
||||
<div class="relative">
|
||||
<span
|
||||
v-if="shouldShowStatusIndicator"
|
||||
data-testid="workflow-dirty-indicator"
|
||||
class="absolute top-1/2 left-1/2 z-10 w-4 -translate-1/2 bg-(--comfy-menu-bg) text-2xl font-bold group-hover:hidden"
|
||||
>•</span
|
||||
>
|
||||
|
||||
186
src/components/topbar/WorkflowTabs.test.ts
Normal file
@@ -0,0 +1,186 @@
|
||||
import { render, screen } from '@testing-library/vue'
|
||||
import userEvent from '@testing-library/user-event'
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
import { defineComponent, h, reactive } from 'vue'
|
||||
import { createI18n } from 'vue-i18n'
|
||||
|
||||
import enMessages from '@/locales/en/main.json' with { type: 'json' }
|
||||
|
||||
import WorkflowTabs from './WorkflowTabs.vue'
|
||||
|
||||
const distribution = vi.hoisted(() => ({
|
||||
isCloud: false,
|
||||
isDesktop: false,
|
||||
isNightly: false
|
||||
}))
|
||||
|
||||
const tabBarLayout = vi.hoisted(() => ({ value: 'Default' }))
|
||||
|
||||
vi.mock('@/platform/distribution/types', () => ({
|
||||
get isCloud() {
|
||||
return distribution.isCloud
|
||||
},
|
||||
get isDesktop() {
|
||||
return distribution.isDesktop
|
||||
},
|
||||
get isNightly() {
|
||||
return distribution.isNightly
|
||||
}
|
||||
}))
|
||||
|
||||
vi.mock('@/platform/settings/settingStore', () => ({
|
||||
useSettingStore: () => ({
|
||||
get: (key: string) =>
|
||||
key === 'Comfy.UI.TabBarLayout' ? tabBarLayout.value : undefined
|
||||
})
|
||||
}))
|
||||
|
||||
vi.mock('@/composables/auth/useCurrentUser', () => ({
|
||||
useCurrentUser: () => ({ isLoggedIn: { value: false } })
|
||||
}))
|
||||
|
||||
vi.mock('@/composables/useFeatureFlags', () => ({
|
||||
useFeatureFlags: () => ({ flags: { showSignInButton: false } })
|
||||
}))
|
||||
|
||||
vi.mock('@/composables/element/useOverflowObserver', () => ({
|
||||
useOverflowObserver: () => ({
|
||||
isOverflowing: { value: false },
|
||||
disposed: { value: false },
|
||||
checkOverflow: vi.fn(),
|
||||
dispose: vi.fn()
|
||||
})
|
||||
}))
|
||||
|
||||
vi.mock('@/platform/workflow/core/services/workflowService', () => ({
|
||||
useWorkflowService: () => ({
|
||||
openWorkflow: vi.fn(),
|
||||
closeWorkflow: vi.fn()
|
||||
})
|
||||
}))
|
||||
|
||||
vi.mock('@/platform/workflow/management/stores/workflowStore', () => ({
|
||||
useWorkflowStore: () =>
|
||||
reactive({
|
||||
openWorkflows: [],
|
||||
activeWorkflow: null
|
||||
})
|
||||
}))
|
||||
|
||||
vi.mock('@/stores/commandStore', () => ({
|
||||
useCommandStore: () => ({ execute: vi.fn() })
|
||||
}))
|
||||
|
||||
vi.mock('@/stores/workspaceStore', () => ({
|
||||
useWorkspaceStore: () => ({ shiftDown: false })
|
||||
}))
|
||||
|
||||
vi.mock('@/utils/mouseDownUtil', () => ({
|
||||
whileMouseDown: vi.fn()
|
||||
}))
|
||||
|
||||
vi.mock('./WorkflowOverflowMenu.vue', () => ({
|
||||
default: defineComponent({
|
||||
name: 'WorkflowOverflowMenuStub',
|
||||
render: () => h('div')
|
||||
})
|
||||
}))
|
||||
|
||||
vi.mock('./WorkflowTab.vue', () => ({
|
||||
default: defineComponent({
|
||||
name: 'WorkflowTabStub',
|
||||
render: () => h('div')
|
||||
})
|
||||
}))
|
||||
|
||||
vi.mock('./CurrentUserButton.vue', () => ({
|
||||
default: defineComponent({
|
||||
name: 'CurrentUserButtonStub',
|
||||
render: () => h('div')
|
||||
})
|
||||
}))
|
||||
|
||||
vi.mock('./LoginButton.vue', () => ({
|
||||
default: defineComponent({
|
||||
name: 'LoginButtonStub',
|
||||
render: () => h('div')
|
||||
})
|
||||
}))
|
||||
|
||||
function renderComponent() {
|
||||
const user = userEvent.setup()
|
||||
const i18n = createI18n({
|
||||
legacy: false,
|
||||
locale: 'en',
|
||||
messages: { en: enMessages }
|
||||
})
|
||||
|
||||
const result = render(WorkflowTabs, {
|
||||
global: {
|
||||
plugins: [i18n],
|
||||
directives: {
|
||||
tooltip: {}
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
return { user, ...result }
|
||||
}
|
||||
|
||||
describe('WorkflowTabs feedback button', () => {
|
||||
let openSpy: ReturnType<typeof vi.spyOn>
|
||||
|
||||
beforeEach(() => {
|
||||
distribution.isCloud = false
|
||||
distribution.isDesktop = false
|
||||
distribution.isNightly = false
|
||||
tabBarLayout.value = 'Default'
|
||||
openSpy = vi.spyOn(window, 'open').mockReturnValue(null)
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
openSpy.mockRestore()
|
||||
})
|
||||
|
||||
it('opens the Typeform survey tagged with topbar source on Cloud', async () => {
|
||||
distribution.isCloud = true
|
||||
const { user } = renderComponent()
|
||||
|
||||
await user.click(screen.getByRole('button', { name: 'Feedback' }))
|
||||
|
||||
expect(openSpy).toHaveBeenCalledWith(
|
||||
'https://form.typeform.com/to/q7azbWPi#distribution=ccloud&source=topbar',
|
||||
'_blank',
|
||||
'noopener,noreferrer'
|
||||
)
|
||||
})
|
||||
|
||||
it('opens the Typeform survey tagged with topbar source on Nightly', async () => {
|
||||
distribution.isNightly = true
|
||||
const { user } = renderComponent()
|
||||
|
||||
await user.click(screen.getByRole('button', { name: 'Feedback' }))
|
||||
|
||||
expect(openSpy).toHaveBeenCalledWith(
|
||||
'https://form.typeform.com/to/q7azbWPi#distribution=oss-nightly&source=topbar',
|
||||
'_blank',
|
||||
'noopener,noreferrer'
|
||||
)
|
||||
})
|
||||
|
||||
it('does not render the feedback button on non-Cloud/non-Nightly builds', () => {
|
||||
renderComponent()
|
||||
expect(
|
||||
screen.queryByRole('button', { name: 'Feedback' })
|
||||
).not.toBeInTheDocument()
|
||||
})
|
||||
|
||||
it('does not render the feedback button when the legacy tab bar is active', () => {
|
||||
distribution.isCloud = true
|
||||
tabBarLayout.value = 'Legacy'
|
||||
renderComponent()
|
||||
expect(
|
||||
screen.queryByRole('button', { name: 'Feedback' })
|
||||
).not.toBeInTheDocument()
|
||||
})
|
||||
})
|
||||
@@ -119,7 +119,7 @@ import { useCurrentUser } from '@/composables/auth/useCurrentUser'
|
||||
import { useFeatureFlags } from '@/composables/useFeatureFlags'
|
||||
import { useOverflowObserver } from '@/composables/element/useOverflowObserver'
|
||||
import { useSettingStore } from '@/platform/settings/settingStore'
|
||||
import { buildFeedbackUrl } from '@/platform/support/config'
|
||||
import { buildFeedbackTypeformUrl } from '@/platform/support/config'
|
||||
import { useWorkflowService } from '@/platform/workflow/core/services/workflowService'
|
||||
import type { ComfyWorkflow } from '@/platform/workflow/management/stores/workflowStore'
|
||||
import { useWorkflowStore } from '@/platform/workflow/management/stores/workflowStore'
|
||||
@@ -152,9 +152,12 @@ const isIntegratedTabBar = computed(
|
||||
)
|
||||
const showCurrentUser = computed(() => isCloud || isLoggedIn.value)
|
||||
|
||||
const feedbackUrl = buildFeedbackUrl()
|
||||
function openFeedback() {
|
||||
window.open(feedbackUrl, '_blank', 'noopener,noreferrer')
|
||||
window.open(
|
||||
buildFeedbackTypeformUrl('topbar'),
|
||||
'_blank',
|
||||
'noopener,noreferrer'
|
||||
)
|
||||
}
|
||||
|
||||
const containerRef = ref<HTMLElement | null>(null)
|
||||
|
||||
195
src/composables/auth/useAuthActions.test.ts
Normal file
@@ -0,0 +1,195 @@
|
||||
import { createPinia, setActivePinia } from 'pinia'
|
||||
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
||||
|
||||
import { useAuthActions } from '@/composables/auth/useAuthActions'
|
||||
import type { ComfyWorkflow } from '@/platform/workflow/management/stores/workflowStore'
|
||||
|
||||
type ModifiedWorkflow = Pick<ComfyWorkflow, 'path' | 'isModified'>
|
||||
|
||||
const mockAuthStore = vi.hoisted(() => ({
|
||||
logout: vi.fn().mockResolvedValue(undefined)
|
||||
}))
|
||||
|
||||
const mockToastStore = vi.hoisted(() => ({
|
||||
add: vi.fn()
|
||||
}))
|
||||
|
||||
const mockWorkflowStore = vi.hoisted(() => ({
|
||||
modifiedWorkflows: [] as ModifiedWorkflow[]
|
||||
}))
|
||||
|
||||
const mockWorkflowService = vi.hoisted(() => ({
|
||||
saveWorkflow: vi.fn().mockResolvedValue(true)
|
||||
}))
|
||||
|
||||
const mockDialogService = vi.hoisted(() => ({
|
||||
confirm: vi.fn()
|
||||
}))
|
||||
|
||||
vi.mock('@/i18n', () => ({
|
||||
t: (key: string, values?: { workflow?: string }) =>
|
||||
values?.workflow ? `${key}:${values.workflow}` : key
|
||||
}))
|
||||
|
||||
vi.mock('@/platform/distribution/types', () => ({
|
||||
isCloud: false
|
||||
}))
|
||||
|
||||
vi.mock('@/platform/telemetry', () => ({
|
||||
useTelemetry: vi.fn(() => undefined)
|
||||
}))
|
||||
|
||||
vi.mock('@/platform/updates/common/toastStore', () => ({
|
||||
useToastStore: vi.fn(() => mockToastStore)
|
||||
}))
|
||||
|
||||
vi.mock('@/platform/workflow/management/stores/workflowStore', () => ({
|
||||
useWorkflowStore: vi.fn(() => mockWorkflowStore)
|
||||
}))
|
||||
|
||||
vi.mock('@/platform/workflow/core/services/workflowService', () => ({
|
||||
useWorkflowService: vi.fn(() => mockWorkflowService)
|
||||
}))
|
||||
|
||||
vi.mock('@/services/dialogService', () => ({
|
||||
useDialogService: vi.fn(() => mockDialogService)
|
||||
}))
|
||||
|
||||
vi.mock('@/stores/authStore', () => ({
|
||||
useAuthStore: vi.fn(() => mockAuthStore)
|
||||
}))
|
||||
|
||||
vi.mock('@/composables/billing/useBillingContext', () => ({
|
||||
useBillingContext: vi.fn(() => ({
|
||||
isActiveSubscription: { value: false },
|
||||
isFreeTier: { value: true },
|
||||
type: { value: 'free' }
|
||||
}))
|
||||
}))
|
||||
|
||||
vi.mock('@/composables/useErrorHandling', () => ({
|
||||
useErrorHandling: () => ({
|
||||
wrapWithErrorHandlingAsync: <TArgs extends unknown[], TReturn>(
|
||||
action: (...args: TArgs) => Promise<TReturn> | TReturn
|
||||
) => action,
|
||||
toastErrorHandler: vi.fn()
|
||||
})
|
||||
}))
|
||||
|
||||
function makeWorkflow(path: string): ModifiedWorkflow {
|
||||
return { path, isModified: true } satisfies ModifiedWorkflow
|
||||
}
|
||||
|
||||
describe('useAuthActions.logout', () => {
|
||||
beforeEach(() => {
|
||||
setActivePinia(createPinia())
|
||||
vi.clearAllMocks()
|
||||
mockWorkflowStore.modifiedWorkflows = []
|
||||
})
|
||||
|
||||
it('logs out without prompting when no workflows are modified', async () => {
|
||||
const { logout } = useAuthActions()
|
||||
|
||||
await logout()
|
||||
|
||||
expect(mockDialogService.confirm).not.toHaveBeenCalled()
|
||||
expect(mockWorkflowService.saveWorkflow).not.toHaveBeenCalled()
|
||||
expect(mockAuthStore.logout).toHaveBeenCalledTimes(1)
|
||||
})
|
||||
|
||||
it('cancels sign-out when the dialog is dismissed (null)', async () => {
|
||||
mockWorkflowStore.modifiedWorkflows = [makeWorkflow('a.json')]
|
||||
mockDialogService.confirm.mockResolvedValueOnce(null)
|
||||
const { logout } = useAuthActions()
|
||||
|
||||
await logout()
|
||||
|
||||
expect(mockDialogService.confirm).toHaveBeenCalledTimes(1)
|
||||
expect(mockWorkflowService.saveWorkflow).not.toHaveBeenCalled()
|
||||
expect(mockAuthStore.logout).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('signs out without saving when the user picks "Sign out anyway" (false)', async () => {
|
||||
mockWorkflowStore.modifiedWorkflows = [makeWorkflow('a.json')]
|
||||
mockDialogService.confirm.mockResolvedValueOnce(false)
|
||||
const { logout } = useAuthActions()
|
||||
|
||||
await logout()
|
||||
|
||||
expect(mockDialogService.confirm).toHaveBeenCalledTimes(1)
|
||||
expect(mockWorkflowService.saveWorkflow).not.toHaveBeenCalled()
|
||||
expect(mockAuthStore.logout).toHaveBeenCalledTimes(1)
|
||||
})
|
||||
|
||||
it('cancels sign-out when saving a workflow is cancelled', async () => {
|
||||
mockWorkflowStore.modifiedWorkflows = [makeWorkflow('a.json')]
|
||||
mockDialogService.confirm.mockResolvedValueOnce(true)
|
||||
mockWorkflowService.saveWorkflow.mockResolvedValueOnce(false)
|
||||
const { logout } = useAuthActions()
|
||||
|
||||
await logout()
|
||||
|
||||
expect(mockWorkflowService.saveWorkflow).toHaveBeenCalledTimes(1)
|
||||
expect(mockAuthStore.logout).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('does not log out if a workflow save fails', async () => {
|
||||
mockWorkflowStore.modifiedWorkflows = [
|
||||
makeWorkflow('a.json'),
|
||||
makeWorkflow('b.json')
|
||||
]
|
||||
mockDialogService.confirm.mockResolvedValueOnce(true)
|
||||
mockWorkflowService.saveWorkflow.mockRejectedValueOnce(
|
||||
new Error('disk full')
|
||||
)
|
||||
const { logout } = useAuthActions()
|
||||
|
||||
await expect(logout()).rejects.toThrow('auth.signOut.saveFailed:a.json')
|
||||
|
||||
expect(mockWorkflowService.saveWorkflow).toHaveBeenCalledTimes(1)
|
||||
expect(mockAuthStore.logout).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('saves every modified workflow before signing out when user picks Save (true)', async () => {
|
||||
const workflows = [makeWorkflow('a.json'), makeWorkflow('b.json')]
|
||||
mockWorkflowStore.modifiedWorkflows = workflows
|
||||
mockDialogService.confirm.mockResolvedValueOnce(true)
|
||||
const { logout } = useAuthActions()
|
||||
|
||||
await logout()
|
||||
|
||||
expect(mockWorkflowService.saveWorkflow).toHaveBeenCalledTimes(2)
|
||||
expect(mockWorkflowService.saveWorkflow).toHaveBeenNthCalledWith(
|
||||
1,
|
||||
workflows[0]
|
||||
)
|
||||
expect(mockWorkflowService.saveWorkflow).toHaveBeenNthCalledWith(
|
||||
2,
|
||||
workflows[1]
|
||||
)
|
||||
expect(mockAuthStore.logout).toHaveBeenCalledTimes(1)
|
||||
expect(
|
||||
mockWorkflowService.saveWorkflow.mock.invocationCallOrder[1]
|
||||
).toBeLessThan(mockAuthStore.logout.mock.invocationCallOrder[0])
|
||||
expect(
|
||||
mockWorkflowService.saveWorkflow.mock.invocationCallOrder[0]
|
||||
).toBeLessThan(mockWorkflowService.saveWorkflow.mock.invocationCallOrder[1])
|
||||
})
|
||||
|
||||
it('passes denyLabel "Sign out anyway" to the dialog', async () => {
|
||||
mockWorkflowStore.modifiedWorkflows = [makeWorkflow('a.json')]
|
||||
mockDialogService.confirm.mockResolvedValueOnce(null)
|
||||
const { logout } = useAuthActions()
|
||||
|
||||
await logout()
|
||||
|
||||
expect(mockDialogService.confirm).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
type: 'dirtyClose',
|
||||
title: 'auth.signOut.unsavedChangesTitle',
|
||||
message: 'auth.signOut.unsavedChangesMessage',
|
||||
denyLabel: 'auth.signOut.signOutAnyway'
|
||||
})
|
||||
)
|
||||
})
|
||||
})
|
||||
@@ -9,6 +9,7 @@ import { t } from '@/i18n'
|
||||
import { isCloud } from '@/platform/distribution/types'
|
||||
import { useTelemetry } from '@/platform/telemetry'
|
||||
import { useToastStore } from '@/platform/updates/common/toastStore'
|
||||
import { useWorkflowService } from '@/platform/workflow/core/services/workflowService'
|
||||
import { useWorkflowStore } from '@/platform/workflow/management/stores/workflowStore'
|
||||
import { useDialogService } from '@/services/dialogService'
|
||||
import { useAuthStore } from '@/stores/authStore'
|
||||
@@ -53,14 +54,30 @@ export const useAuthActions = () => {
|
||||
|
||||
const logout = wrapWithErrorHandlingAsync(async () => {
|
||||
const workflowStore = useWorkflowStore()
|
||||
if (workflowStore.modifiedWorkflows.length > 0) {
|
||||
const modifiedWorkflows = workflowStore.modifiedWorkflows
|
||||
if (modifiedWorkflows.length > 0) {
|
||||
const dialogService = useDialogService()
|
||||
const confirmed = await dialogService.confirm({
|
||||
title: t('auth.signOut.unsavedChangesTitle'),
|
||||
message: t('auth.signOut.unsavedChangesMessage'),
|
||||
type: 'dirtyClose'
|
||||
type: 'dirtyClose',
|
||||
denyLabel: t('auth.signOut.signOutAnyway')
|
||||
})
|
||||
if (!confirmed) return
|
||||
if (confirmed === null) return
|
||||
|
||||
if (confirmed === true) {
|
||||
const workflowService = useWorkflowService()
|
||||
for (const workflow of modifiedWorkflows) {
|
||||
try {
|
||||
const saved = await workflowService.saveWorkflow(workflow)
|
||||
if (!saved) return
|
||||
} catch {
|
||||
throw new Error(
|
||||
t('auth.signOut.saveFailed', { workflow: workflow.path })
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
await authStore.logout()
|
||||
|
||||
@@ -73,12 +73,14 @@ export const useNodeDragAndDrop = <T>(
|
||||
return true
|
||||
}
|
||||
|
||||
const uri = URL.parse(e?.dataTransfer?.getData('text/uri-list') ?? '')
|
||||
const baseUri = e?.dataTransfer?.getData('text/uri-list') ?? ''
|
||||
const uri = URL.parse(baseUri, location.href)
|
||||
if (!uri || uri.origin !== location.origin) return false
|
||||
|
||||
try {
|
||||
const resp = await fetch(uri)
|
||||
const fileName = uri?.searchParams?.get('filename')
|
||||
const fileName =
|
||||
uri?.searchParams?.get('filename') ?? baseUri.split('/').at(-1)
|
||||
if (!fileName || !resp.ok) return false
|
||||
|
||||
const blob = await resp.blob()
|
||||
|
||||
39
src/extension-api-v2/__tests__/bc-01.migration.test.ts
Normal file
@@ -0,0 +1,39 @@
|
||||
// Category: BC.01 — Node lifecycle: creation
|
||||
// DB cross-ref: S2.N1, S2.N8
|
||||
// Exemplar: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/extensions/core/saveImageExtraOutput.ts#L31
|
||||
// compat-floor: blast_radius 4.48 ≥ 2.0 — MUST pass before v2 ships
|
||||
// Migration: v1 nodeCreated(node) + beforeRegisterNodeDef → v2 defineNodeExtension({ nodeCreated(handle) })
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.01 migration — node lifecycle: creation', () => {
|
||||
describe('nodeCreated parity (S2.N1)', () => {
|
||||
it.todo(
|
||||
'v1 nodeCreated and v2 nodeCreated are both invoked the same number of times when N nodes are created'
|
||||
)
|
||||
it.todo(
|
||||
'side-effects applied to the node in v1 nodeCreated(node) are reproducible via NodeHandle methods in v2'
|
||||
)
|
||||
it.todo(
|
||||
'v2 nodeCreated fires in the same relative order as v1 for extensions registered in the same order'
|
||||
)
|
||||
})
|
||||
|
||||
describe('beforeRegisterNodeDef → type-scoped defineNodeExtension (S2.N8)', () => {
|
||||
it.todo(
|
||||
'prototype mutation applied in v1 beforeRegisterNodeDef produces the same per-instance behavior as v2 type-scoped nodeCreated'
|
||||
)
|
||||
it.todo(
|
||||
'v2 type-scoped extension does not affect node types that were excluded, matching v1 type-guard behavior'
|
||||
)
|
||||
})
|
||||
|
||||
describe('VueNode mount timing invariant', () => {
|
||||
it.todo(
|
||||
'both v1 and v2 nodeCreated fire before VueNode mounts — extensions relying on this ordering do not need changes'
|
||||
)
|
||||
it.todo(
|
||||
'extensions that deferred DOM work to a callback in v1 can use onNodeMounted in v2 for the same guarantee'
|
||||
)
|
||||
})
|
||||
})
|
||||
45
src/extension-api-v2/__tests__/bc-01.v1.test.ts
Normal file
@@ -0,0 +1,45 @@
|
||||
// Category: BC.01 — Node lifecycle: creation
|
||||
// DB cross-ref: S2.N1, S2.N8
|
||||
// Exemplar: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/extensions/core/saveImageExtraOutput.ts#L31
|
||||
// Surface: S2.N1 = nodeCreated hook, S2.N8 = beforeRegisterNodeDef
|
||||
// compat-floor: blast_radius 4.48 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v1 contract: app.registerExtension({ nodeCreated(node) { ... } })
|
||||
// Note: nodeCreated fires BEFORE the VueNode Vue component mounts; extensions needing
|
||||
// VueNode-backed state must defer (see BC.37).
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.01 v1 contract — node lifecycle: creation', () => {
|
||||
describe('S2.N1 — nodeCreated hook', () => {
|
||||
it.todo(
|
||||
'nodeCreated is called once per node instance immediately after the node is constructed'
|
||||
)
|
||||
it.todo(
|
||||
'nodeCreated receives the LGraphNode instance as its first argument'
|
||||
)
|
||||
it.todo(
|
||||
'nodeCreated fires before the node is added to the graph (graph.nodes does not yet contain the node)'
|
||||
)
|
||||
it.todo(
|
||||
'nodeCreated fires before the VueNode Vue component is mounted (vm.$el is null at call time)'
|
||||
)
|
||||
it.todo(
|
||||
'properties set on node inside nodeCreated are accessible in subsequent lifecycle hooks'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S2.N8 — beforeRegisterNodeDef hook', () => {
|
||||
it.todo(
|
||||
'beforeRegisterNodeDef is called once per node type before the type is registered in the node registry'
|
||||
)
|
||||
it.todo(
|
||||
'beforeRegisterNodeDef receives the node constructor and the raw node definition object'
|
||||
)
|
||||
it.todo(
|
||||
'prototype mutations made in beforeRegisterNodeDef affect all subsequently created instances of that type'
|
||||
)
|
||||
it.todo(
|
||||
'beforeRegisterNodeDef is NOT called again on graph reload if the type is already registered'
|
||||
)
|
||||
})
|
||||
})
|
||||
41
src/extension-api-v2/__tests__/bc-01.v2.test.ts
Normal file
@@ -0,0 +1,41 @@
|
||||
// Category: BC.01 — Node lifecycle: creation
|
||||
// DB cross-ref: S2.N1, S2.N8
|
||||
// Exemplar: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/extensions/core/saveImageExtraOutput.ts#L31
|
||||
// compat-floor: blast_radius 4.48 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v2 replacement: defineNodeExtension({ nodeCreated(handle) { ... } })
|
||||
// Note: v2 nodeCreated receives a NodeHandle, not a raw LGraphNode. VueNode mount
|
||||
// timing guarantee is unchanged — defer to onNodeMounted for Vue-backed state.
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.01 v2 contract — node lifecycle: creation', () => {
|
||||
describe('nodeCreated(handle) — per-instance setup', () => {
|
||||
it.todo(
|
||||
'nodeCreated is called once per node instance and receives a NodeHandle wrapping the created node'
|
||||
)
|
||||
it.todo(
|
||||
'NodeHandle.id is stable and matches the underlying LGraphNode id at call time'
|
||||
)
|
||||
it.todo(
|
||||
'NodeHandle.type returns the registered node type string'
|
||||
)
|
||||
it.todo(
|
||||
'state stored via NodeHandle.setState() inside nodeCreated is retrievable in subsequent hooks for the same instance'
|
||||
)
|
||||
it.todo(
|
||||
'nodeCreated fires before VueNode mounts; accessing NodeHandle.vueRef inside nodeCreated returns null'
|
||||
)
|
||||
})
|
||||
|
||||
describe('type-level registration (replacement for S2.N8)', () => {
|
||||
it.todo(
|
||||
'defineNodeExtension({ types: [\"MyNode\"] }) scopes nodeCreated to only instances of the listed types'
|
||||
)
|
||||
it.todo(
|
||||
'omitting types: causes nodeCreated to fire for every node type (global registration)'
|
||||
)
|
||||
it.todo(
|
||||
'type-scoped registration does not receive nodeCreated calls for unregistered node types'
|
||||
)
|
||||
})
|
||||
})
|
||||
36
src/extension-api-v2/__tests__/bc-02.migration.test.ts
Normal file
@@ -0,0 +1,36 @@
|
||||
// Category: BC.02 — Node lifecycle: teardown
|
||||
// DB cross-ref: S2.N4
|
||||
// Exemplar: https://github.com/Lightricks/ComfyUI-LTXVideo/blob/main/web/js/sparse_track_editor.js#L137
|
||||
// compat-floor: blast_radius 5.20 ≥ 2.0 — MUST pass before v2 ships
|
||||
// Migration: v1 node.onRemoved assignment → v2 defineNodeExtension({ onRemoved(handle) })
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.02 migration — node lifecycle: teardown', () => {
|
||||
describe('invocation parity (S2.N4)', () => {
|
||||
it.todo(
|
||||
'v1 onRemoved and v2 onRemoved are both called the same number of times for the same sequence of node removals'
|
||||
)
|
||||
it.todo(
|
||||
'v2 onRemoved fires at the same point in the removal lifecycle as v1 (after node is detached from graph)'
|
||||
)
|
||||
})
|
||||
|
||||
describe('resource cleanup equivalence', () => {
|
||||
it.todo(
|
||||
'intervals cleared in v1 onRemoved are equally suppressible via NodeHandle.onDispose() in v2 without manual tracking'
|
||||
)
|
||||
it.todo(
|
||||
'DOM elements removed manually in v1 onRemoved are automatically removed by v2 auto-disposal when registered via addDOMWidget()'
|
||||
)
|
||||
it.todo(
|
||||
'observer.disconnect() patterns in v1 can be replaced by NodeHandle.onDispose(() => observer.disconnect()) in v2'
|
||||
)
|
||||
})
|
||||
|
||||
describe('graph clear coverage', () => {
|
||||
it.todo(
|
||||
'both v1 and v2 teardown hooks are invoked for all nodes when graph.clear() is called'
|
||||
)
|
||||
})
|
||||
})
|
||||
135
src/extension-api-v2/__tests__/bc-02.v1.test.ts
Normal file
@@ -0,0 +1,135 @@
|
||||
// Category: BC.02 — Node lifecycle: teardown
|
||||
// DB cross-ref: S2.N4
|
||||
// Exemplar: https://github.com/Lightricks/ComfyUI-LTXVideo/blob/main/web/js/sparse_track_editor.js#L137
|
||||
// Surface: S2.N4 = node.onRemoved
|
||||
// compat-floor: blast_radius 5.20 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v1 contract: node.onRemoved = function() { /* cleanup DOM, intervals, observers */ }
|
||||
//
|
||||
// I-TF.3.C3 — proof-of-concept harness wiring.
|
||||
// Phase A harness limitation: MiniGraph.remove() deletes the entity from the World
|
||||
// but does NOT automatically call onRemoved (that requires Phase B eval sandbox +
|
||||
// LiteGraph prototype wiring). The wired tests below call onRemoved explicitly after
|
||||
// graph.remove() to prove the harness mechanics and assertion patterns work.
|
||||
// The TODO stubs below them track what needs Phase B to become real assertions.
|
||||
|
||||
import { describe, expect, it, vi } from 'vitest'
|
||||
|
||||
import {
|
||||
countEvidenceExcerpts,
|
||||
createHarnessWorld,
|
||||
createMiniComfyApp,
|
||||
loadEvidenceSnippet
|
||||
} from '../harness'
|
||||
|
||||
// ── Proof-of-concept wired tests (I-TF.3.C3) ────────────────────────────────
|
||||
// These pass today. They prove: (a) the harness can model the v1 teardown
|
||||
// pattern, (b) removal is reflected in the World, (c) the cleanup callback
|
||||
// fires when the extension calls it, (d) evidence excerpts load for S2.N4.
|
||||
|
||||
describe('BC.02 v1 contract — node lifecycle: teardown [harness POC]', () => {
|
||||
describe('S2.N4 — onRemoved harness mechanics', () => {
|
||||
it('cleanup callback fires when extension calls it after graph.remove()', () => {
|
||||
const world = createHarnessWorld()
|
||||
const app = createMiniComfyApp(world)
|
||||
|
||||
// v1 pattern: extension patches onRemoved on the node during nodeCreated.
|
||||
// We model this as a plain function stored on a node-shaped object.
|
||||
const cleanupFn = vi.fn()
|
||||
const node = {
|
||||
type: 'LTXVideo',
|
||||
entityId: app.graph.add({ type: 'LTXVideo' }),
|
||||
onRemoved: cleanupFn
|
||||
}
|
||||
|
||||
expect(world.findNode(node.entityId)).toBeDefined()
|
||||
|
||||
// Simulate the LiteGraph removal sequence (Phase A: explicit call).
|
||||
app.graph.remove(node.entityId)
|
||||
node.onRemoved()
|
||||
|
||||
expect(world.findNode(node.entityId)).toBeUndefined()
|
||||
expect(cleanupFn).toHaveBeenCalledOnce()
|
||||
})
|
||||
|
||||
it('cleanup callback does not fire if remove is never called', () => {
|
||||
const world = createHarnessWorld()
|
||||
const app = createMiniComfyApp(world)
|
||||
const cleanupFn = vi.fn()
|
||||
const entityId = app.graph.add({ type: 'KSampler' })
|
||||
|
||||
// Node exists; no removal; callback should not have been invoked.
|
||||
void entityId
|
||||
expect(cleanupFn).not.toHaveBeenCalled()
|
||||
expect(world.allNodes()).toHaveLength(1)
|
||||
})
|
||||
|
||||
it('multiple nodes — each removal triggers only its own callback', () => {
|
||||
const world = createHarnessWorld()
|
||||
const app = createMiniComfyApp(world)
|
||||
|
||||
const cbA = vi.fn()
|
||||
const cbB = vi.fn()
|
||||
const idA = app.graph.add({ type: 'NodeA' })
|
||||
const idB = app.graph.add({ type: 'NodeB' })
|
||||
|
||||
// Remove only A.
|
||||
app.graph.remove(idA)
|
||||
cbA() // simulate LiteGraph calling onRemoved on the removed node only
|
||||
|
||||
expect(cbA).toHaveBeenCalledOnce()
|
||||
expect(cbB).not.toHaveBeenCalled()
|
||||
expect(world.findNode(idA)).toBeUndefined()
|
||||
expect(world.findNode(idB)).toBeDefined()
|
||||
})
|
||||
|
||||
it('graph.clear() removes all nodes from the World', () => {
|
||||
const world = createHarnessWorld()
|
||||
const app = createMiniComfyApp(world)
|
||||
|
||||
app.graph.add({ type: 'NodeA' })
|
||||
app.graph.add({ type: 'NodeB' })
|
||||
app.graph.add({ type: 'NodeC' })
|
||||
expect(world.allNodes()).toHaveLength(3)
|
||||
|
||||
world.clear()
|
||||
expect(world.allNodes()).toHaveLength(0)
|
||||
})
|
||||
})
|
||||
|
||||
describe('S2.N4 — evidence excerpt (loadEvidenceSnippet)', () => {
|
||||
it('S2.N4 has at least one evidence excerpt in the snapshot', () => {
|
||||
expect(countEvidenceExcerpts('S2.N4')).toBeGreaterThan(0)
|
||||
})
|
||||
|
||||
it('S2.N4 excerpt contains onRemoved fingerprint', () => {
|
||||
const snippet = loadEvidenceSnippet('S2.N4', 0)
|
||||
expect(snippet.length).toBeGreaterThan(0)
|
||||
expect(snippet).toMatch(/onRemoved/i)
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
// ── Phase B stubs — need eval sandbox + LiteGraph prototype wiring ───────────
|
||||
|
||||
describe('BC.02 v1 contract — node lifecycle: teardown [Phase B]', () => {
|
||||
describe('S2.N4 — node.onRemoved', () => {
|
||||
it.todo(
|
||||
'onRemoved is called exactly once when a node is removed from the graph via graph.remove(node)'
|
||||
)
|
||||
it.todo(
|
||||
'onRemoved is called when a node is deleted via the canvas context-menu delete action'
|
||||
)
|
||||
it.todo(
|
||||
'onRemoved is called for every node when the graph is cleared (graph.clear())'
|
||||
)
|
||||
it.todo(
|
||||
'DOM widgets appended by the extension are accessible for cleanup inside onRemoved (not yet garbage-collected)'
|
||||
)
|
||||
it.todo(
|
||||
'setInterval / requestAnimationFrame handles stored on the node instance can be cancelled inside onRemoved'
|
||||
)
|
||||
it.todo(
|
||||
'MutationObserver and ResizeObserver instances stored on the node can be disconnected inside onRemoved'
|
||||
)
|
||||
})
|
||||
})
|
||||
38
src/extension-api-v2/__tests__/bc-02.v2.test.ts
Normal file
@@ -0,0 +1,38 @@
|
||||
// Category: BC.02 — Node lifecycle: teardown
|
||||
// DB cross-ref: S2.N4
|
||||
// Exemplar: https://github.com/Lightricks/ComfyUI-LTXVideo/blob/main/web/js/sparse_track_editor.js#L137
|
||||
// compat-floor: blast_radius 5.20 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v2 replacement: defineNodeExtension({ onRemoved(handle) { ... } })
|
||||
// Note: v2 onRemoved runs inside the NodeHandle scope; extension-owned resources
|
||||
// registered via handle APIs are auto-disposed before onRemoved fires.
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.02 v2 contract — node lifecycle: teardown', () => {
|
||||
describe('onRemoved(handle) — cleanup hook', () => {
|
||||
it.todo(
|
||||
'onRemoved is called exactly once per node instance when the node is removed from the graph'
|
||||
)
|
||||
it.todo(
|
||||
'onRemoved receives the same NodeHandle that was passed to nodeCreated for the same instance'
|
||||
)
|
||||
it.todo(
|
||||
'NodeHandle.getState() is still readable inside onRemoved (state not yet cleared)'
|
||||
)
|
||||
it.todo(
|
||||
'onRemoved is called for every node when the graph is cleared, in no guaranteed order'
|
||||
)
|
||||
})
|
||||
|
||||
describe('auto-disposal of handle-registered resources', () => {
|
||||
it.todo(
|
||||
'DOM widgets registered via NodeHandle.addDOMWidget() are removed from the DOM before onRemoved fires'
|
||||
)
|
||||
it.todo(
|
||||
'cleanup functions registered via NodeHandle.onDispose() are invoked before onRemoved fires'
|
||||
)
|
||||
it.todo(
|
||||
'extension can still perform additional teardown in onRemoved after auto-disposal completes'
|
||||
)
|
||||
})
|
||||
})
|
||||
36
src/extension-api-v2/__tests__/bc-03.migration.test.ts
Normal file
@@ -0,0 +1,36 @@
|
||||
// Category: BC.03 — Node lifecycle: hydration from saved workflows
|
||||
// DB cross-ref: S1.H1, S2.N7
|
||||
// Exemplar: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/extensions/core/
|
||||
// compat-floor: blast_radius 4.91 ≥ 2.0 — MUST pass before v2 ships
|
||||
// Migration: v1 node.onConfigure / beforeRegisterNodeDef → v2 defineNodeExtension({ onConfigure(handle, data) })
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.03 migration — node lifecycle: hydration from saved workflows', () => {
|
||||
describe('onConfigure parity (S2.N7)', () => {
|
||||
it.todo(
|
||||
'v1 node.onConfigure and v2 onConfigure are both called exactly once per node during workflow load'
|
||||
)
|
||||
it.todo(
|
||||
'the serialized data object received in v2 onConfigure contains the same fields as in v1'
|
||||
)
|
||||
it.todo(
|
||||
'custom property restoration logic written for v1 onConfigure is portable to v2 with only handle substitution'
|
||||
)
|
||||
})
|
||||
|
||||
describe('beforeRegisterNodeDef hydration guard → type-scoped extension (S1.H1)', () => {
|
||||
it.todo(
|
||||
'prototype-level onConfigure injected via v1 beforeRegisterNodeDef produces the same hydration result as a v2 type-scoped onConfigure'
|
||||
)
|
||||
it.todo(
|
||||
'v2 type-scoped onConfigure does not fire for node types not listed in types:, matching v1 guard behavior'
|
||||
)
|
||||
})
|
||||
|
||||
describe('fresh-creation exclusion invariant', () => {
|
||||
it.todo(
|
||||
'neither v1 nor v2 onConfigure fires when a node is created fresh (not from a saved workflow)'
|
||||
)
|
||||
})
|
||||
})
|
||||
39
src/extension-api-v2/__tests__/bc-03.v1.test.ts
Normal file
@@ -0,0 +1,39 @@
|
||||
// Category: BC.03 — Node lifecycle: hydration from saved workflows
|
||||
// DB cross-ref: S1.H1, S2.N7
|
||||
// Exemplar: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/extensions/core/
|
||||
// Surface: S1.H1 = beforeRegisterNodeDef (used for hydration guards), S2.N7 = node.onConfigure
|
||||
// compat-floor: blast_radius 4.91 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v1 contract: S1.H1 = beforeRegisterNodeDef guard; S2.N7 = node.onConfigure = function(data) { ... }
|
||||
// Note: loadedGraphNode hook exists in LiteGraph but is effectively unused in ComfyUI —
|
||||
// onConfigure is the de-facto hydration surface.
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.03 v1 contract — node lifecycle: hydration from saved workflows', () => {
|
||||
describe('S2.N7 — node.onConfigure', () => {
|
||||
it.todo(
|
||||
'onConfigure is called when a saved workflow is loaded and the node is rehydrated from serialized data'
|
||||
)
|
||||
it.todo(
|
||||
'onConfigure receives the raw serialized node object (data) as its first argument'
|
||||
)
|
||||
it.todo(
|
||||
'onConfigure is NOT called on freshly created nodes (only on deserialization)'
|
||||
)
|
||||
it.todo(
|
||||
'widget values written to data inside a prior session are accessible via data.widgets_values in onConfigure'
|
||||
)
|
||||
it.todo(
|
||||
'extensions can restore custom properties stored in data.properties inside onConfigure'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S1.H1 — beforeRegisterNodeDef hydration guard', () => {
|
||||
it.todo(
|
||||
'beforeRegisterNodeDef can inject a custom onConfigure override on the node prototype before any instance is created'
|
||||
)
|
||||
it.todo(
|
||||
'prototype-level onConfigure injected in beforeRegisterNodeDef is invoked for all instances during workflow load'
|
||||
)
|
||||
})
|
||||
})
|
||||
36
src/extension-api-v2/__tests__/bc-03.v2.test.ts
Normal file
@@ -0,0 +1,36 @@
|
||||
// Category: BC.03 — Node lifecycle: hydration from saved workflows
|
||||
// DB cross-ref: S1.H1, S2.N7
|
||||
// Exemplar: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/extensions/core/
|
||||
// compat-floor: blast_radius 4.91 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v2 replacement: defineNodeExtension({ onConfigure(handle, data) { ... } })
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.03 v2 contract — node lifecycle: hydration from saved workflows', () => {
|
||||
describe('onConfigure(handle, data) — workflow hydration hook', () => {
|
||||
it.todo(
|
||||
'onConfigure is called when a node is rehydrated from a saved workflow and NOT on fresh node creation'
|
||||
)
|
||||
it.todo(
|
||||
'onConfigure receives the NodeHandle as first argument and the raw serialized node object as second argument'
|
||||
)
|
||||
it.todo(
|
||||
'data passed to onConfigure contains widgets_values from the saved workflow'
|
||||
)
|
||||
it.todo(
|
||||
'data passed to onConfigure contains properties from the saved workflow'
|
||||
)
|
||||
it.todo(
|
||||
'state written to NodeHandle inside onConfigure is readable in all subsequent hook calls for that instance'
|
||||
)
|
||||
})
|
||||
|
||||
describe('ordering and idempotency guarantees', () => {
|
||||
it.todo(
|
||||
'onConfigure fires after nodeCreated for the same instance during workflow load'
|
||||
)
|
||||
it.todo(
|
||||
'onConfigure is not called a second time if the same node receives a re-configure (idempotent load)'
|
||||
)
|
||||
})
|
||||
})
|
||||
45
src/extension-api-v2/__tests__/bc-04.migration.test.ts
Normal file
@@ -0,0 +1,45 @@
|
||||
// Category: BC.04 — Node interaction: pointer, selection, resize
|
||||
// DB cross-ref: S2.N10, S2.N17, S2.N19
|
||||
// Exemplar: https://github.com/diodiogod/TTS-Audio-Suite/blob/main/web/chatterbox_voice_capture.js#L202
|
||||
// compat-floor: blast_radius 4.95 ≥ 2.0 — MUST pass before v2 ships
|
||||
// Migration: v1 node.onMouseDown/onSelected/onResize → v2 handle.on('mousedown'|'selected'|'resize', ...)
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.04 migration — node interaction: pointer, selection, resize', () => {
|
||||
describe('mousedown parity (S2.N10)', () => {
|
||||
it.todo(
|
||||
'v1 node.onMouseDown and v2 handle.on("mousedown") are both invoked for the same pointer-down events'
|
||||
)
|
||||
it.todo(
|
||||
'propagation-stop by returning true in v1 is equivalent to event.stopPropagation() in v2 handler'
|
||||
)
|
||||
it.todo(
|
||||
'local coordinates passed to v1 onMouseDown match the x/y in the v2 event object for the same input'
|
||||
)
|
||||
})
|
||||
|
||||
describe('selection parity (S2.N17)', () => {
|
||||
it.todo(
|
||||
'v1 node.onSelected and v2 handle.on("selected") are both invoked when the node is selected'
|
||||
)
|
||||
it.todo(
|
||||
'v2 introduces an explicit deselected event absent in v1; migration must add deselected handler for cleanup that relied on onSelected re-fire'
|
||||
)
|
||||
})
|
||||
|
||||
describe('resize parity (S2.N19)', () => {
|
||||
it.todo(
|
||||
'v1 node.onResize([w,h]) and v2 handle.on("resize", { width, height }) convey the same dimensions for the same resize action'
|
||||
)
|
||||
it.todo(
|
||||
'computeSize overrides that triggered onResize in v1 still trigger the resize event in v2'
|
||||
)
|
||||
})
|
||||
|
||||
describe('listener lifetime', () => {
|
||||
it.todo(
|
||||
'v1 listeners on removed nodes remain registered (leak); v2 handle.on() listeners are auto-removed on node removal'
|
||||
)
|
||||
})
|
||||
})
|
||||
49
src/extension-api-v2/__tests__/bc-04.v1.test.ts
Normal file
@@ -0,0 +1,49 @@
|
||||
// Category: BC.04 — Node interaction: pointer, selection, resize
|
||||
// DB cross-ref: S2.N10, S2.N17, S2.N19
|
||||
// Exemplar: https://github.com/diodiogod/TTS-Audio-Suite/blob/main/web/chatterbox_voice_capture.js#L202
|
||||
// Surface: S2.N10 = node.onMouseDown, S2.N17 = node.onSelected, S2.N19 = node.onResize
|
||||
// compat-floor: blast_radius 4.95 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v1 contract: node.onMouseDown, node.onSelected, node.onResize prototype method assignments
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.04 v1 contract — node interaction: pointer, selection, resize', () => {
|
||||
describe('S2.N10 — node.onMouseDown', () => {
|
||||
it.todo(
|
||||
'onMouseDown is called when a pointer-down event occurs within the node bounding box on the canvas'
|
||||
)
|
||||
it.todo(
|
||||
'onMouseDown receives the MouseEvent and the local [x, y] position within the node as arguments'
|
||||
)
|
||||
it.todo(
|
||||
'returning true from onMouseDown stops propagation to LiteGraph default mouse handling'
|
||||
)
|
||||
it.todo(
|
||||
'onMouseDown is NOT called when the pointer down is outside the node bounding box'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S2.N17 — node.onSelected', () => {
|
||||
it.todo(
|
||||
'onSelected is called when the node transitions to selected state (single-click or box-select)'
|
||||
)
|
||||
it.todo(
|
||||
'onSelected is called once per selection event even if the node was already selected'
|
||||
)
|
||||
it.todo(
|
||||
'onSelected is not called when a different node is selected and this node is deselected'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S2.N19 — node.onResize', () => {
|
||||
it.todo(
|
||||
'onResize is called after the node dimensions change (user drag-resize or programmatic setSize)'
|
||||
)
|
||||
it.todo(
|
||||
'onResize receives the new [width, height] array as its argument'
|
||||
)
|
||||
it.todo(
|
||||
'onResize is called after the node size is committed, not during the drag'
|
||||
)
|
||||
})
|
||||
})
|
||||
48
src/extension-api-v2/__tests__/bc-04.v2.test.ts
Normal file
@@ -0,0 +1,48 @@
|
||||
// Category: BC.04 — Node interaction: pointer, selection, resize
|
||||
// DB cross-ref: S2.N10, S2.N17, S2.N19
|
||||
// Exemplar: https://github.com/diodiogod/TTS-Audio-Suite/blob/main/web/chatterbox_voice_capture.js#L202
|
||||
// compat-floor: blast_radius 4.95 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v2 replacement: defineNodeExtension({ on('mousedown', ...), on('selected', ...), on('resize', ...) })
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.04 v2 contract — node interaction: pointer, selection, resize', () => {
|
||||
describe('on(\"mousedown\", handler) — pointer events (S2.N10)', () => {
|
||||
it.todo(
|
||||
'handle.on("mousedown", handler) registers a listener called when pointer-down occurs within the node bounding box'
|
||||
)
|
||||
it.todo(
|
||||
'handler receives an event object with local x/y coordinates relative to the node origin'
|
||||
)
|
||||
it.todo(
|
||||
'handler returning true stops propagation to LiteGraph default mouse handling'
|
||||
)
|
||||
it.todo(
|
||||
'listener registered via handle.on() is automatically removed when the node is removed from the graph'
|
||||
)
|
||||
})
|
||||
|
||||
describe('on(\"selected\", handler) — selection focus (S2.N17)', () => {
|
||||
it.todo(
|
||||
'handle.on("selected", handler) is called when the node enters selected state'
|
||||
)
|
||||
it.todo(
|
||||
'handle.on("deselected", handler) is called when the node exits selected state'
|
||||
)
|
||||
it.todo(
|
||||
'selected and deselected events do not fire during programmatic selection with { silent: true } option'
|
||||
)
|
||||
})
|
||||
|
||||
describe('on(\"resize\", handler) — resize feedback (S2.N19)', () => {
|
||||
it.todo(
|
||||
'handle.on("resize", handler) is called after the node dimensions change'
|
||||
)
|
||||
it.todo(
|
||||
'handler receives a { width, height } object matching the new node size'
|
||||
)
|
||||
it.todo(
|
||||
'resize event fires for both user drag-resize and programmatic NodeHandle.setSize() calls'
|
||||
)
|
||||
})
|
||||
})
|
||||
39
src/extension-api-v2/__tests__/bc-05.migration.test.ts
Normal file
@@ -0,0 +1,39 @@
|
||||
// Category: BC.05 — Custom DOM widgets and node sizing
|
||||
// DB cross-ref: S4.W2, S2.N11
|
||||
// Exemplar: https://github.com/Lightricks/ComfyUI-LTXVideo/blob/main/web/js/sparse_track_editor.js#L218
|
||||
// compat-floor: blast_radius 5.45 ≥ 2.0 — MUST pass before v2 ships
|
||||
// Migration: v1 node.addDOMWidget + node.computeSize → v2 NodeHandle.addDOMWidget + WidgetHandle.setHeight
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.05 migration — custom DOM widgets and node sizing', () => {
|
||||
describe('widget registration parity (S4.W2)', () => {
|
||||
it.todo(
|
||||
'v1 node.addDOMWidget and v2 NodeHandle.addDOMWidget both result in the element being visible inside the node widget area'
|
||||
)
|
||||
it.todo(
|
||||
'the widget is accessible by name in both v1 node.widgets and v2 NodeHandle.widgets after registration'
|
||||
)
|
||||
it.todo(
|
||||
'v1 opts.getHeight() returning N produces the same reserved height as v2 addDOMWidget({ height: N })'
|
||||
)
|
||||
})
|
||||
|
||||
describe('computeSize elimination (S2.N11)', () => {
|
||||
it.todo(
|
||||
'v1 manual computeSize override is unnecessary in v2; equivalent height reservation is achieved via WidgetHandle.setHeight()'
|
||||
)
|
||||
it.todo(
|
||||
'node rendered with v2 auto-computeSize integration has the same final dimensions as v1 with an equivalent manual computeSize override'
|
||||
)
|
||||
})
|
||||
|
||||
describe('cleanup parity', () => {
|
||||
it.todo(
|
||||
'v1 requires manual DOM removal in onRemoved; v2 auto-removes the widget element — both result in the element being absent after node removal'
|
||||
)
|
||||
it.todo(
|
||||
'v2 auto-cleanup does not remove DOM elements that were not registered via addDOMWidget, matching v1 scoping'
|
||||
)
|
||||
})
|
||||
})
|
||||
43
src/extension-api-v2/__tests__/bc-05.v1.test.ts
Normal file
@@ -0,0 +1,43 @@
|
||||
// Category: BC.05 — Custom DOM widgets and node sizing
|
||||
// DB cross-ref: S4.W2, S2.N11
|
||||
// Exemplar: https://github.com/Lightricks/ComfyUI-LTXVideo/blob/main/web/js/sparse_track_editor.js#L218
|
||||
// Surface: S4.W2 = node.addDOMWidget, S2.N11 = node.computeSize override
|
||||
// compat-floor: blast_radius 5.45 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v1 contract: node.addDOMWidget(name, type, element, opts) + node.computeSize = function(out) { ... }
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.05 v1 contract — custom DOM widgets and node sizing', () => {
|
||||
describe('S4.W2 — node.addDOMWidget', () => {
|
||||
it.todo(
|
||||
'addDOMWidget(name, type, element, opts) appends the provided DOM element inside the node widget area'
|
||||
)
|
||||
it.todo(
|
||||
'widget registered via addDOMWidget is accessible via node.widgets array by the given name'
|
||||
)
|
||||
it.todo(
|
||||
'addDOMWidget opts.getHeight() is called during layout to determine the widget reserved height'
|
||||
)
|
||||
it.todo(
|
||||
'addDOMWidget opts.onDraw(ctx) callback is invoked during each canvas render pass'
|
||||
)
|
||||
it.todo(
|
||||
'the DOM element is removed from the document when the node is removed via graph.remove()'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S2.N11 — node.computeSize override', () => {
|
||||
it.todo(
|
||||
'assigning node.computeSize = function(out) { ... } overrides the default size calculation for the node'
|
||||
)
|
||||
it.todo(
|
||||
'overridden computeSize is called by LiteGraph layout engine before rendering'
|
||||
)
|
||||
it.todo(
|
||||
'computeSize can return a [width, height] pair that accounts for the DOM widget reserved height'
|
||||
)
|
||||
it.todo(
|
||||
'computeSize override persists across graph load/reload if set in nodeCreated or beforeRegisterNodeDef'
|
||||
)
|
||||
})
|
||||
})
|
||||
39
src/extension-api-v2/__tests__/bc-05.v2.test.ts
Normal file
@@ -0,0 +1,39 @@
|
||||
// Category: BC.05 — Custom DOM widgets and node sizing
|
||||
// DB cross-ref: S4.W2, S2.N11
|
||||
// Exemplar: https://github.com/Lightricks/ComfyUI-LTXVideo/blob/main/web/js/sparse_track_editor.js#L218
|
||||
// compat-floor: blast_radius 5.45 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v2 replacement: NodeHandle.addDOMWidget(opts) — auto-hooks computeSize via WidgetHandle geometry
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.05 v2 contract — custom DOM widgets and node sizing', () => {
|
||||
describe('NodeHandle.addDOMWidget(opts) — widget registration', () => {
|
||||
it.todo(
|
||||
'NodeHandle.addDOMWidget({ name, element }) appends the element inside the node widget area'
|
||||
)
|
||||
it.todo(
|
||||
'addDOMWidget returns a WidgetHandle that exposes the registered widget for further configuration'
|
||||
)
|
||||
it.todo(
|
||||
'widget registered via addDOMWidget is included in NodeHandle.widgets list under opts.name'
|
||||
)
|
||||
it.todo(
|
||||
'addDOMWidget({ name, element, height }) reserves the specified height without requiring a manual computeSize override'
|
||||
)
|
||||
it.todo(
|
||||
'the DOM element is removed from the document automatically when the node is removed (no manual cleanup)'
|
||||
)
|
||||
})
|
||||
|
||||
describe('WidgetHandle geometry — auto-computeSize integration (S2.N11)', () => {
|
||||
it.todo(
|
||||
'WidgetHandle.setHeight(px) updates the reserved height and triggers a node relayout without a manual computeSize call'
|
||||
)
|
||||
it.todo(
|
||||
'when multiple DOM widgets are registered, the total node height accounts for all widget heights'
|
||||
)
|
||||
it.todo(
|
||||
'calling WidgetHandle.setHeight() after initial mount correctly re-lays out the node on next render frame'
|
||||
)
|
||||
})
|
||||
})
|
||||
40
src/extension-api-v2/__tests__/bc-06.migration.test.ts
Normal file
@@ -0,0 +1,40 @@
|
||||
// Category: BC.06 — Custom canvas drawing (per-node and canvas-level)
|
||||
// DB cross-ref: S2.N9, S3.C1, S3.C2
|
||||
// Exemplar: https://github.com/kijai/ComfyUI-KJNodes/blob/main/web/js/setgetnodes.js#L1256
|
||||
// compat-floor: blast_radius 5.25 ≥ 2.0 — MUST pass before v2 ships
|
||||
// Migration: v1 node.onDrawForeground → v2 NodeHandle.onDraw (partial).
|
||||
// S3.C1 / S3.C2 canvas-level overrides: no v2 migration path yet (D9 Phase C).
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.06 migration — custom canvas drawing (per-node and canvas-level)', () => {
|
||||
describe('per-node drawing migration (S2.N9)', () => {
|
||||
it.todo(
|
||||
'v1 node.onDrawForeground and v2 NodeHandle.onDraw both produce visually equivalent output on the canvas for the same drawing operations'
|
||||
)
|
||||
it.todo(
|
||||
'draw callback in v2 fires the same number of times per second as v1 onDrawForeground for a static scene'
|
||||
)
|
||||
it.todo(
|
||||
'v2 DrawContext.ctx is the same CanvasRenderingContext2D state as v1 receives (same transform, same clip)'
|
||||
)
|
||||
})
|
||||
|
||||
describe('auto-deregistration vs manual cleanup', () => {
|
||||
it.todo(
|
||||
'v1 onDrawForeground continues to fire after node removal if the reference is not cleared (leak); v2 onDraw is auto-removed'
|
||||
)
|
||||
it.todo(
|
||||
'v2 auto-deregistration on node removal does not affect onDraw callbacks registered for other nodes'
|
||||
)
|
||||
})
|
||||
|
||||
describe('canvas-level override coexistence (S3.C1, S3.C2)', () => {
|
||||
it.todo(
|
||||
'extensions that replace LGraphCanvas.prototype methods in v1 continue to function alongside v2 NodeHandle.onDraw registrations without conflict'
|
||||
)
|
||||
it.todo(
|
||||
'processContextMenu replacement in v1 is not disrupted by extensions migrated to v2 per-node APIs'
|
||||
)
|
||||
})
|
||||
})
|
||||
55
src/extension-api-v2/__tests__/bc-06.v1.test.ts
Normal file
@@ -0,0 +1,55 @@
|
||||
// Category: BC.06 — Custom canvas drawing (per-node and canvas-level)
|
||||
// DB cross-ref: S2.N9, S3.C1, S3.C2
|
||||
// Exemplar: https://github.com/kijai/ComfyUI-KJNodes/blob/main/web/js/setgetnodes.js#L1256
|
||||
// Surface: S2.N9 = node.onDrawForeground, S3.C1 = LGraphCanvas.prototype overrides, S3.C2 = ContextMenu replacement
|
||||
// compat-floor: blast_radius 5.25 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v1 contract: node.onDrawForeground(ctx, area), LGraphCanvas.prototype.processContextMenu = ...,
|
||||
// LGraphCanvas.prototype.drawNodeShape = ... etc.
|
||||
// v1_scope_note: Simon Tranter (COM-3668) vetoed canvas drawing overrides as "too hacky/specific".
|
||||
// S3.C* patterns tracked for blast-radius / strangler-fig planning only.
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.06 v1 contract — custom canvas drawing (per-node and canvas-level)', () => {
|
||||
describe('S2.N9 — node.onDrawForeground', () => {
|
||||
it.todo(
|
||||
'onDrawForeground(ctx, visibleArea) is called once per render frame for each visible node'
|
||||
)
|
||||
it.todo(
|
||||
'ctx passed to onDrawForeground is the same CanvasRenderingContext2D used by LiteGraph for the node layer'
|
||||
)
|
||||
it.todo(
|
||||
'drawing operations performed in onDrawForeground appear above the node body and below the selection highlight'
|
||||
)
|
||||
it.todo(
|
||||
'onDrawForeground is NOT called for nodes outside the visible area (culled by LiteGraph)'
|
||||
)
|
||||
it.todo(
|
||||
'canvas transform (scale, translate) is already applied when onDrawForeground fires — coordinates are in graph space'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S3.C1 — LGraphCanvas.prototype method overrides', () => {
|
||||
it.todo(
|
||||
'assigning LGraphCanvas.prototype.drawNodeShape replaces the built-in node shape renderer for all nodes'
|
||||
)
|
||||
it.todo(
|
||||
'prototype override affects all canvas instances sharing the same prototype (global side-effect)'
|
||||
)
|
||||
it.todo(
|
||||
'two extensions both overriding the same LGraphCanvas.prototype method result in last-writer-wins behavior'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S3.C2 — ContextMenu global replacement', () => {
|
||||
it.todo(
|
||||
'reassigning LGraphCanvas.prototype.processContextMenu replaces the context-menu handler for every right-click on the canvas'
|
||||
)
|
||||
it.todo(
|
||||
'extensions replacing processContextMenu must call the original to preserve built-in menu items'
|
||||
)
|
||||
it.todo(
|
||||
'replacing processContextMenu is the most destructive canvas-level override — absence of original call silently drops all built-in menu entries'
|
||||
)
|
||||
})
|
||||
})
|
||||
41
src/extension-api-v2/__tests__/bc-06.v2.test.ts
Normal file
@@ -0,0 +1,41 @@
|
||||
// Category: BC.06 — Custom canvas drawing (per-node and canvas-level)
|
||||
// DB cross-ref: S2.N9, S3.C1, S3.C2
|
||||
// Exemplar: https://github.com/kijai/ComfyUI-KJNodes/blob/main/web/js/setgetnodes.js#L1256
|
||||
// compat-floor: blast_radius 5.25 ≥ 2.0 — MUST pass before v2 ships
|
||||
// v2 replacement: NodeHandle.onDraw(callback) for per-node drawing (S2.N9).
|
||||
// Canvas-level overrides (S3.C1, S3.C2) are OUT OF v2 SCOPE — deferred to D9 Phase C.
|
||||
// S3.C* stubs present for blast-radius tracking and strangler-fig planning.
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.06 v2 contract — custom canvas drawing (per-node and canvas-level)', () => {
|
||||
describe('NodeHandle.onDraw(callback) — per-node foreground drawing (S2.N9)', () => {
|
||||
it.todo(
|
||||
'NodeHandle.onDraw(cb) registers cb to be called once per render frame while the node is visible'
|
||||
)
|
||||
it.todo(
|
||||
'callback receives a DrawContext with ctx (CanvasRenderingContext2D) and area (bounding rect) arguments'
|
||||
)
|
||||
it.todo(
|
||||
'drawing operations in the callback appear in the same layer as v1 onDrawForeground (above node body)'
|
||||
)
|
||||
it.todo(
|
||||
'the canvas transform is pre-applied when the callback fires — coordinates are in graph space, matching v1 behavior'
|
||||
)
|
||||
it.todo(
|
||||
'callback registered via NodeHandle.onDraw() is automatically deregistered when the node is removed'
|
||||
)
|
||||
})
|
||||
|
||||
describe('canvas-level overrides — deferred (S3.C1, S3.C2)', () => {
|
||||
it.todo(
|
||||
'[D9 Phase C] v2 exposes no stable API for replacing LGraphCanvas.prototype.drawNodeShape — extensions using this pattern must remain on v1 shim'
|
||||
)
|
||||
it.todo(
|
||||
'[D9 Phase C] v2 exposes no stable API for replacing processContextMenu — context-menu customization is deferred to the ComfyUI menu extension point'
|
||||
)
|
||||
it.todo(
|
||||
'[D9 Phase C] blast-radius tracking: S3.C1 and S3.C2 overrides coexist with v2 per-node drawing without mutual interference'
|
||||
)
|
||||
})
|
||||
})
|
||||
44
src/extension-api-v2/__tests__/bc-07.migration.test.ts
Normal file
@@ -0,0 +1,44 @@
|
||||
// Category: BC.07 — Connection observation, intercept, and veto
|
||||
// DB cross-ref: S2.N3, S2.N12, S2.N13
|
||||
// Exemplar: https://github.com/rgthree/rgthree-comfy/blob/main/web/comfyui/node_mode_relay.js#L90
|
||||
// Migration: v1 prototype method assignment → v2 NodeHandle.on('connectInput'/'connectOutput'/'connectionChange')
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.07 migration — connection observation, intercept, and veto', () => {
|
||||
describe('onConnectionsChange → on(\'connectionChange\') (S2.N3)', () => {
|
||||
it.todo(
|
||||
'v1 onConnectionsChange and v2 on(\'connectionChange\') both fire for the same link connect event with equivalent payload data'
|
||||
)
|
||||
it.todo(
|
||||
'v2 connectionChange event fires at the same point in the link-wiring sequence as v1 onConnectionsChange'
|
||||
)
|
||||
})
|
||||
|
||||
describe('onConnectInput → on(\'connectInput\') (S2.N12)', () => {
|
||||
it.todo(
|
||||
'v1 onConnectInput returning false and v2 on(\'connectInput\') returning false both result in an unwired graph with no link object created'
|
||||
)
|
||||
it.todo(
|
||||
'type coercion performed inside v1 onConnectInput produces the same wired slot type as equivalent mutation inside v2 on(\'connectInput\')'
|
||||
)
|
||||
})
|
||||
|
||||
describe('onConnectOutput → on(\'connectOutput\') (S2.N13)', () => {
|
||||
it.todo(
|
||||
'v1 onConnectOutput veto and v2 on(\'connectOutput\') veto both prevent connectionChange from firing on either endpoint node'
|
||||
)
|
||||
it.todo(
|
||||
'v2 on(\'connectOutput\') listener receives equivalent data to v1 onConnectOutput arguments for the same connection attempt'
|
||||
)
|
||||
})
|
||||
|
||||
describe('scope and cleanup', () => {
|
||||
it.todo(
|
||||
'v1 prototype method persists after extension unregisters (no cleanup); v2 on() listeners are removed on scope dispose'
|
||||
)
|
||||
it.todo(
|
||||
'v2 cleanup does not affect connection listeners registered by other extensions on the same node'
|
||||
)
|
||||
})
|
||||
})
|
||||
53
src/extension-api-v2/__tests__/bc-07.v1.test.ts
Normal file
@@ -0,0 +1,53 @@
|
||||
// Category: BC.07 — Connection observation, intercept, and veto
|
||||
// DB cross-ref: S2.N3, S2.N12, S2.N13
|
||||
// Exemplar: https://github.com/rgthree/rgthree-comfy/blob/main/web/comfyui/node_mode_relay.js#L90
|
||||
// blast_radius: 5.46 — compat-floor: blast_radius ≥ 2.0 — MUST pass before v2 ships
|
||||
// v1 contract: node.onConnectInput(slot, type, link, node, fromSlot)
|
||||
// node.onConnectOutput(slot, type, link, node, toSlot)
|
||||
// node.onConnectionsChange(type, slot, connected, link, ioSlot)
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.07 v1 contract — connection observation, intercept, and veto', () => {
|
||||
describe('S2.N3 — onConnectionsChange: passive observation', () => {
|
||||
it.todo(
|
||||
'onConnectionsChange is called on the node when any input or output link is connected or disconnected'
|
||||
)
|
||||
it.todo(
|
||||
'onConnectionsChange receives type (INPUT=1/OUTPUT=2), slot index, connected boolean, link info, and ioSlot'
|
||||
)
|
||||
it.todo(
|
||||
'onConnectionsChange fires after the link is already wired into the graph (link is present at call time)'
|
||||
)
|
||||
it.todo(
|
||||
'onConnectionsChange fires for both the source node and the target node on a single link operation'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S2.N12 — onConnectInput: intercept and veto incoming connections', () => {
|
||||
it.todo(
|
||||
'onConnectInput returning false vetoes the connection before it is wired'
|
||||
)
|
||||
it.todo(
|
||||
'onConnectInput returning true (or undefined) allows the connection to proceed'
|
||||
)
|
||||
it.todo(
|
||||
'onConnectInput receives slot index, incoming type, link object, source node, and source slot'
|
||||
)
|
||||
it.todo(
|
||||
'onConnectInput can mutate the slot type to coerce an incompatible type before wiring'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S2.N13 — onConnectOutput: intercept and veto outgoing connections', () => {
|
||||
it.todo(
|
||||
'onConnectOutput returning false vetoes the outgoing connection before it is wired'
|
||||
)
|
||||
it.todo(
|
||||
'onConnectOutput receives slot index, outgoing type, link object, target node, and target slot'
|
||||
)
|
||||
it.todo(
|
||||
'onConnectOutput veto does not trigger onConnectionsChange on either node'
|
||||
)
|
||||
})
|
||||
})
|
||||
51
src/extension-api-v2/__tests__/bc-07.v2.test.ts
Normal file
@@ -0,0 +1,51 @@
|
||||
// Category: BC.07 — Connection observation, intercept, and veto
|
||||
// DB cross-ref: S2.N3, S2.N12, S2.N13
|
||||
// Exemplar: https://github.com/rgthree/rgthree-comfy/blob/main/web/comfyui/node_mode_relay.js#L90
|
||||
// blast_radius: 5.46 — compat-floor: blast_radius ≥ 2.0 — MUST pass before v2 ships
|
||||
// v2 replacement: NodeHandle.on('connectInput', ...), on('connectOutput', ...), on('connectionChange', ...)
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.07 v2 contract — connection observation, intercept, and veto', () => {
|
||||
describe('on(\'connectionChange\', fn) — passive observation', () => {
|
||||
it.todo(
|
||||
'NodeHandle.on(\'connectionChange\', fn) fires fn after any input or output link is connected or disconnected'
|
||||
)
|
||||
it.todo(
|
||||
'connectionChange event payload includes type (\'input\'|\'output\'), slotIndex, connected boolean, and link info'
|
||||
)
|
||||
it.todo(
|
||||
'multiple listeners registered via on(\'connectionChange\') are all invoked in registration order'
|
||||
)
|
||||
it.todo(
|
||||
'listener registered with on() is removed when the extension scope is disposed'
|
||||
)
|
||||
})
|
||||
|
||||
describe('on(\'connectInput\', fn) — intercept and veto incoming connections', () => {
|
||||
it.todo(
|
||||
'fn returning false from on(\'connectInput\') vetoes the connection; graph remains unwired'
|
||||
)
|
||||
it.todo(
|
||||
'fn returning true or undefined from on(\'connectInput\') allows the connection to proceed'
|
||||
)
|
||||
it.todo(
|
||||
'connectInput event payload includes slotIndex, type, link, sourceHandle, and sourceSlot'
|
||||
)
|
||||
it.todo(
|
||||
'fn can mutate event.type to coerce a type mismatch before the connection is wired'
|
||||
)
|
||||
})
|
||||
|
||||
describe('on(\'connectOutput\', fn) — intercept and veto outgoing connections', () => {
|
||||
it.todo(
|
||||
'fn returning false from on(\'connectOutput\') vetoes the outgoing connection; connectionChange does not fire'
|
||||
)
|
||||
it.todo(
|
||||
'connectOutput event payload includes slotIndex, type, link, targetHandle, and targetSlot'
|
||||
)
|
||||
it.todo(
|
||||
'veto from connectOutput does not affect other registered connectOutput listeners on the same node'
|
||||
)
|
||||
})
|
||||
})
|
||||
38
src/extension-api-v2/__tests__/bc-08.migration.test.ts
Normal file
@@ -0,0 +1,38 @@
|
||||
// Category: BC.08 — Programmatic linking
|
||||
// DB cross-ref: S10.D2
|
||||
// Exemplar: https://github.com/goodtab/ComfyUI-Custom-Scripts/blob/main/web/js/quickNodes.js#L138
|
||||
// Migration: v1 node.connect/disconnectInput → v2 NodeHandle.connect/disconnectInput (typed handles)
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.08 migration — programmatic linking', () => {
|
||||
describe('connect() equivalence', () => {
|
||||
it.todo(
|
||||
'v1 node.connect(srcSlot, targetNode, dstSlot) and v2 NodeHandle.connect(srcSlot, targetHandle, dstSlot) produce identical graph link state'
|
||||
)
|
||||
it.todo(
|
||||
'link id returned by v2 connect() matches the id on the underlying LGraph link created by an equivalent v1 call'
|
||||
)
|
||||
it.todo(
|
||||
'v2 connect() with a type-incompatible pair raises a typed error; v1 returns null — callers must handle both forms during migration'
|
||||
)
|
||||
})
|
||||
|
||||
describe('disconnectInput() equivalence', () => {
|
||||
it.todo(
|
||||
'v1 node.disconnectInput(slot) and v2 NodeHandle.disconnectInput(slotIndex) both leave the graph with no link on that slot'
|
||||
)
|
||||
it.todo(
|
||||
'onConnectionsChange (v1) and on(\'connectionChange\') (v2) both fire for the same disconnect operation with equivalent payload data'
|
||||
)
|
||||
})
|
||||
|
||||
describe('handle vs. raw node reference', () => {
|
||||
it.todo(
|
||||
'v2 NodeHandle.connect() accepts a NodeHandle for targetHandle; passing a raw LGraphNode instance throws a deprecation error'
|
||||
)
|
||||
it.todo(
|
||||
'NodeHandle obtained from v2 nodeCreated correctly wraps the same node that v1 connect() would operate on'
|
||||
)
|
||||
})
|
||||
})
|
||||
40
src/extension-api-v2/__tests__/bc-08.v1.test.ts
Normal file
@@ -0,0 +1,40 @@
|
||||
// Category: BC.08 — Programmatic linking
|
||||
// DB cross-ref: S10.D2
|
||||
// Exemplar: https://github.com/goodtab/ComfyUI-Custom-Scripts/blob/main/web/js/quickNodes.js#L138
|
||||
// blast_radius: 5.99 — compat-floor: blast_radius ≥ 2.0 — MUST pass before v2 ships
|
||||
// v1 contract: node.connect(srcSlot, targetNode, dstSlot)
|
||||
// node.disconnectInput(slot)
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.08 v1 contract — programmatic linking', () => {
|
||||
describe('S10.D2 — node.connect(srcSlot, targetNode, dstSlot)', () => {
|
||||
it.todo(
|
||||
'node.connect(srcSlot, targetNode, dstSlot) creates a link between the source output slot and the target input slot'
|
||||
)
|
||||
it.todo(
|
||||
'connect() returns the newly created link object with a stable numeric id'
|
||||
)
|
||||
it.todo(
|
||||
'connect() on an already-occupied input slot replaces the existing link without leaving a dangling reference'
|
||||
)
|
||||
it.todo(
|
||||
'connect() with a type-incompatible slot pair is rejected and returns null without modifying the graph'
|
||||
)
|
||||
it.todo(
|
||||
'onConnectionsChange fires on both the source and target node after a successful connect() call'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S10.D2 — node.disconnectInput(slot)', () => {
|
||||
it.todo(
|
||||
'node.disconnectInput(slot) removes the link on the specified input slot and updates both endpoint nodes'
|
||||
)
|
||||
it.todo(
|
||||
'disconnectInput() on an empty slot is a no-op and does not throw'
|
||||
)
|
||||
it.todo(
|
||||
'onConnectionsChange fires on both the source and target node after disconnectInput() removes a link'
|
||||
)
|
||||
})
|
||||
})
|
||||
39
src/extension-api-v2/__tests__/bc-08.v2.test.ts
Normal file
@@ -0,0 +1,39 @@
|
||||
// Category: BC.08 — Programmatic linking
|
||||
// DB cross-ref: S10.D2
|
||||
// Exemplar: https://github.com/goodtab/ComfyUI-Custom-Scripts/blob/main/web/js/quickNodes.js#L138
|
||||
// blast_radius: 5.99 — compat-floor: blast_radius ≥ 2.0 — MUST pass before v2 ships
|
||||
// v2 replacement: NodeHandle.connect(slotIndex, targetHandle, dstSlot) — same semantics, typed handles
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.08 v2 contract — programmatic linking', () => {
|
||||
describe('NodeHandle.connect(slotIndex, targetHandle, dstSlot) — create links', () => {
|
||||
it.todo(
|
||||
'NodeHandle.connect(slotIndex, targetHandle, dstSlot) creates a link between the source output slot and the target input slot'
|
||||
)
|
||||
it.todo(
|
||||
'connect() returns a LinkHandle with a stable id that matches the underlying graph link id'
|
||||
)
|
||||
it.todo(
|
||||
'connect() on an already-occupied input slot replaces the existing link and the old LinkHandle becomes invalid'
|
||||
)
|
||||
it.todo(
|
||||
'connect() with a type-incompatible slot pair throws a typed error and leaves the graph unchanged'
|
||||
)
|
||||
it.todo(
|
||||
'on(\'connectionChange\') fires on both NodeHandles after a successful connect() call'
|
||||
)
|
||||
})
|
||||
|
||||
describe('NodeHandle.disconnectInput(slotIndex) — remove links', () => {
|
||||
it.todo(
|
||||
'NodeHandle.disconnectInput(slotIndex) removes the link on the specified input slot and the returned LinkHandle becomes invalid'
|
||||
)
|
||||
it.todo(
|
||||
'disconnectInput() on an empty slot is a no-op and does not throw'
|
||||
)
|
||||
it.todo(
|
||||
'on(\'connectionChange\') fires on both source and target NodeHandles after disconnectInput() removes a link'
|
||||
)
|
||||
})
|
||||
})
|
||||
42
src/extension-api-v2/__tests__/bc-09.migration.test.ts
Normal file
@@ -0,0 +1,42 @@
|
||||
// Category: BC.09 — Dynamic slot and output mutation
|
||||
// DB cross-ref: S10.D1, S10.D3, S15.OS1
|
||||
// Exemplar: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/lib/litegraph/src/canvas/LinkConnector.core.test.ts#L121
|
||||
// Migration: v1 positional addInput/removeInput/addOutput/removeOutput + manual setSize
|
||||
// → v2 name-based NodeHandle.addInput/removeInput/addOutput/removeOutput with auto-reflow
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.09 migration — dynamic slot and output mutation', () => {
|
||||
describe('addInput / addOutput equivalence (S10.D1, S10.D3)', () => {
|
||||
it.todo(
|
||||
'v1 node.addInput(name, type) and v2 NodeHandle.addInput({ name, type }) both result in an equivalent slot appended to the node'
|
||||
)
|
||||
it.todo(
|
||||
'v1 node.addOutput(name, type) and v2 NodeHandle.addOutput({ name, type }) both result in an equivalent output slot with a matching type'
|
||||
)
|
||||
it.todo(
|
||||
'slot added via v2 addInput() is accessible at the same index position as an equivalent v1 addInput() call (append-only ordering preserved)'
|
||||
)
|
||||
})
|
||||
|
||||
describe('removeInput / removeOutput equivalence', () => {
|
||||
it.todo(
|
||||
'v1 node.removeInput(slotIndex) and v2 NodeHandle.removeInput(name) both remove the slot and detach active links; remaining slots have consistent indices'
|
||||
)
|
||||
it.todo(
|
||||
'v2 removeInput(name) correctly identifies the slot when multiple slots exist, matching by name not by position'
|
||||
)
|
||||
})
|
||||
|
||||
describe('reflow: manual setSize vs. automatic (S15.OS1)', () => {
|
||||
it.todo(
|
||||
'v1 addInput() + setSize([...computeSize()]) and v2 addInput() auto-reflow both produce a node with equal or greater height to display the new slot'
|
||||
)
|
||||
it.todo(
|
||||
'v2 auto-reflow after removeOutput() shrinks the node to the same height as a v1 removeOutput() + manual setSize() sequence'
|
||||
)
|
||||
it.todo(
|
||||
'omitting setSize after a v1 addInput() call causes slot overlap; v2 auto-reflow never produces this condition'
|
||||
)
|
||||
})
|
||||
})
|
||||
50
src/extension-api-v2/__tests__/bc-09.v1.test.ts
Normal file
@@ -0,0 +1,50 @@
|
||||
// Category: BC.09 — Dynamic slot and output mutation
|
||||
// DB cross-ref: S10.D1, S10.D3, S15.OS1
|
||||
// Exemplar: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/lib/litegraph/src/canvas/LinkConnector.core.test.ts#L121
|
||||
// blast_radius: 6.03 — compat-floor: blast_radius ≥ 2.0 — MUST pass before v2 ships
|
||||
// v1 contract: node.addInput(name, type), node.removeInput(slot)
|
||||
// node.addOutput(name, type), node.removeOutput(slot)
|
||||
// node.setSize([w, h])
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.09 v1 contract — dynamic slot and output mutation', () => {
|
||||
describe('S10.D1 — addInput / removeInput', () => {
|
||||
it.todo(
|
||||
'node.addInput(name, type) appends a new input slot to node.inputs and increments node.inputs.length'
|
||||
)
|
||||
it.todo(
|
||||
'node.removeInput(slot) removes the slot at the given index and shifts subsequent slots down by one'
|
||||
)
|
||||
it.todo(
|
||||
'removing an input slot that has an active link also removes the corresponding link from the graph'
|
||||
)
|
||||
it.todo(
|
||||
'addInput with a duplicate name appends a second slot without error (v1 allows duplicates)'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S10.D3 — addOutput / removeOutput', () => {
|
||||
it.todo(
|
||||
'node.addOutput(name, type) appends a new output slot to node.outputs and increments node.outputs.length'
|
||||
)
|
||||
it.todo(
|
||||
'node.removeOutput(slot) removes the output slot and detaches all outgoing links on that slot'
|
||||
)
|
||||
it.todo(
|
||||
'removing an output slot does not affect links on other output slots of the same node'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S15.OS1 — computeSize / setSize reflow', () => {
|
||||
it.todo(
|
||||
'node.setSize([w, h]) updates node.size to the provided dimensions immediately'
|
||||
)
|
||||
it.todo(
|
||||
'addInput/addOutput followed by node.setSize([...node.computeSize()]) produces a node tall enough to display all slots without overlap'
|
||||
)
|
||||
it.todo(
|
||||
'setSize does not trigger a canvas redraw synchronously; redraw occurs on the next animation frame'
|
||||
)
|
||||
})
|
||||
})
|
||||
50
src/extension-api-v2/__tests__/bc-09.v2.test.ts
Normal file
@@ -0,0 +1,50 @@
|
||||
// Category: BC.09 — Dynamic slot and output mutation
|
||||
// DB cross-ref: S10.D1, S10.D3, S15.OS1
|
||||
// Exemplar: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/lib/litegraph/src/canvas/LinkConnector.core.test.ts#L121
|
||||
// blast_radius: 6.03 — compat-floor: blast_radius ≥ 2.0 — MUST pass before v2 ships
|
||||
// v2 replacement: NodeHandle.addInput(opts), NodeHandle.removeInput(name)
|
||||
// NodeHandle.addOutput(opts), NodeHandle.removeOutput(name)
|
||||
// reflow handled automatically — no manual setSize required
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.09 v2 contract — dynamic slot and output mutation', () => {
|
||||
describe('NodeHandle.addInput / removeInput (S10.D1)', () => {
|
||||
it.todo(
|
||||
'NodeHandle.addInput({ name, type }) appends a new input slot and returns a SlotHandle with a stable name-based identity'
|
||||
)
|
||||
it.todo(
|
||||
'NodeHandle.removeInput(name) removes the named input slot and detaches any active link on that slot'
|
||||
)
|
||||
it.todo(
|
||||
'removeInput(name) on a non-existent slot name throws a typed SlotNotFoundError'
|
||||
)
|
||||
it.todo(
|
||||
'addInput with a duplicate name throws a DuplicateSlotError (v2 enforces uniqueness unlike v1)'
|
||||
)
|
||||
})
|
||||
|
||||
describe('NodeHandle.addOutput / removeOutput (S10.D3)', () => {
|
||||
it.todo(
|
||||
'NodeHandle.addOutput({ name, type }) appends a new output slot and returns a SlotHandle'
|
||||
)
|
||||
it.todo(
|
||||
'NodeHandle.removeOutput(name) removes the output slot and detaches all outgoing links on that slot'
|
||||
)
|
||||
it.todo(
|
||||
'removeOutput does not affect slots or links on other output slots of the same node'
|
||||
)
|
||||
})
|
||||
|
||||
describe('automatic reflow (replaces S15.OS1 manual setSize)', () => {
|
||||
it.todo(
|
||||
'after addInput() or addOutput() the node size is automatically reflowed to fit all slots without a manual setSize call'
|
||||
)
|
||||
it.todo(
|
||||
'after removeInput() or removeOutput() the node size is automatically shrunk to remove the vacated slot space'
|
||||
)
|
||||
it.todo(
|
||||
'automatic reflow does not trigger a synchronous canvas redraw; redraw occurs on the next animation frame'
|
||||
)
|
||||
})
|
||||
})
|
||||
39
src/extension-api-v2/__tests__/bc-10.migration.test.ts
Normal file
@@ -0,0 +1,39 @@
|
||||
// Category: BC.10 — Widget value subscription
|
||||
// DB cross-ref: S4.W1, S2.N14
|
||||
// Exemplar: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/extensions/core/widgetInputs.ts#L317
|
||||
// Migration: v1 widget.callback chain-patching / node.onWidgetChanged
|
||||
// → v2 WidgetHandle.on('change') / NodeHandle.on('widgetChanged')
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.10 migration — widget value subscription', () => {
|
||||
describe('widget.callback → WidgetHandle.on(\'change\') (S4.W1)', () => {
|
||||
it.todo(
|
||||
'v1 widget.callback and v2 WidgetHandle.on(\'change\') both fire with the new value for the same user interaction'
|
||||
)
|
||||
it.todo(
|
||||
'v2 on(\'change\') fires at the same point in the event sequence as the last v1 callback in the chain'
|
||||
)
|
||||
it.todo(
|
||||
'v1 chain-patching does not compose with v2 on(\'change\'): each operates independently; both fire for the same change event'
|
||||
)
|
||||
})
|
||||
|
||||
describe('node.onWidgetChanged → NodeHandle.on(\'widgetChanged\') (S2.N14)', () => {
|
||||
it.todo(
|
||||
'v1 node.onWidgetChanged and v2 NodeHandle.on(\'widgetChanged\') both receive equivalent widget name, value, and oldValue for the same change'
|
||||
)
|
||||
it.todo(
|
||||
'v2 widgetChanged payload includes a WidgetHandle reference instead of a raw widget object; WidgetHandle.name matches the widget name'
|
||||
)
|
||||
})
|
||||
|
||||
describe('ordering and isolation', () => {
|
||||
it.todo(
|
||||
'v2 on(\'change\') listeners from different extensions on the same widget all fire without one suppressing another'
|
||||
)
|
||||
it.todo(
|
||||
'disposing one extension scope removes only its own on(\'change\') listeners; other extensions\' listeners continue to fire'
|
||||
)
|
||||
})
|
||||
})
|
||||
37
src/extension-api-v2/__tests__/bc-10.v1.test.ts
Normal file
@@ -0,0 +1,37 @@
|
||||
// Category: BC.10 — Widget value subscription
|
||||
// DB cross-ref: S4.W1, S2.N14
|
||||
// Exemplar: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/extensions/core/widgetInputs.ts#L317
|
||||
// blast_radius: 5.09 — compat-floor: blast_radius ≥ 2.0 — MUST pass before v2 ships
|
||||
// v1 contract: widget.callback = function(value, ...) { ... } (chain-patching)
|
||||
// node.onWidgetChanged = function(name, value, ...) { ... }
|
||||
|
||||
import { describe, it } from 'vitest'
|
||||
|
||||
describe('BC.10 v1 contract — widget value subscription', () => {
|
||||
describe('S4.W1 — widget.callback chain-patching', () => {
|
||||
it.todo(
|
||||
'assigning widget.callback invokes the function with the new value whenever the widget is interacted with'
|
||||
)
|
||||
it.todo(
|
||||
'chain-patching preserves the previous callback: saving the old reference and calling it at the end of the new function'
|
||||
)
|
||||
it.todo(
|
||||
'widget.callback receives (value, app, node, pos, event) in that argument order'
|
||||
)
|
||||
it.todo(
|
||||
'if multiple extensions chain-patch widget.callback, all callbacks are invoked in stack order (last-patched first)'
|
||||
)
|
||||
})
|
||||
|
||||
describe('S2.N14 — node.onWidgetChanged', () => {
|
||||
it.todo(
|
||||
'node.onWidgetChanged is called once per widget value change with the widget name, new value, old value, and widget reference'
|
||||
)
|
||||
it.todo(
|
||||
'onWidgetChanged fires for every widget on the node, not only those with an explicit callback'
|
||||
)
|
||||
it.todo(
|
||||
'onWidgetChanged fires after widget.callback has been invoked for the same change event'
|
||||
)
|
||||
})
|
||||
})
|
||||