Compare commits

...

9 Commits

Author SHA1 Message Date
bymyself
219ebb3297 test: clean up useCoreCommands test hygiene
- Use vi.resetAllMocks for better mock isolation between tests
- Remove duplicate Help commands tests (already covered earlier)
- Remove unused useExternalLink import

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-05-14 13:01:38 -07:00
Connor Byrne
9d6313fed6 test: add non-error path tests for QueueSelectedOutputNodes and GroupSelectedNodes
- Add test for successful queue of selected output nodes
- Add test for successful group creation with selected items
- Add required mocks for filterOutputNodes, getExecutionIdsForSelectedNodes, and LGraphGroup

Addresses review feedback:
https://github.com/Comfy-Org/ComfyUI_frontend/pull/11148#discussion_r3187402906
https://github.com/Comfy-Org/ComfyUI_frontend/pull/11148#discussion_r3187405105
2026-05-13 13:54:10 -07:00
Connor Byrne
9a747fa8b1 test: remove duplicate test cases
Remove ZoomIn/ZoomOut, RefreshNodeDefinitions, and OpenClipspace tests
that are already covered in 'Canvas view commands' and 'Workflow lifecycle
commands' describe blocks.

Addresses review feedback:
https://github.com/Comfy-Org/ComfyUI_frontend/pull/11148#discussion_r3187368524
https://github.com/Comfy-Org/ComfyUI_frontend/pull/11148#discussion_r3187372447
https://github.com/Comfy-Org/ComfyUI_frontend/pull/11148#discussion_r3187375380
2026-05-13 13:50:24 -07:00
Connor Byrne
268af310d1 refactor: replace inline findCmd with shared findCommand helper
Addresses review feedback:
https://github.com/Comfy-Org/ComfyUI_frontend/pull/11148#discussion_r3187396151
2026-05-13 13:49:45 -07:00
bymyself
02298c4f6a test: assert restored link mode is not HIDDEN_LINK
Replace expect.any(Number) with a stronger check that the value
written back is not LiteGraph.HIDDEN_LINK, so the test fails if
the command writes the same hidden mode it just read.

Addresses review feedback:
https://github.com/Comfy-Org/ComfyUI_frontend/pull/11148#discussion_r3067235809
2026-05-02 14:10:14 -07:00
bymyself
b443442194 test: assert dispatched event type for no-items-selected
Strengthen the assertion in the DeleteSelectedItems no-selection test
so it fails if the wrong CustomEvent is emitted.

Addresses review feedback:
https://github.com/Comfy-Org/ComfyUI_frontend/pull/11148#discussion_r3067235804
2026-05-02 14:09:32 -07:00
bymyself
2306eea270 fix: improve findCommand error message per review feedback 2026-05-02 14:08:36 -07:00
GitHub Action
0d26a5a33d [automated] Apply ESLint and Oxfmt fixes 2026-05-02 14:08:36 -07:00
bymyself
3f5e516a00 test: expand useCoreCommands coverage with behavioral tests 2026-05-02 14:08:36 -07:00

File diff suppressed because it is too large Load Diff