mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-12 08:50:17 +00:00
0132c77c7d
## Summary
Harden 98 E2E spec files and 8 fixtures/helpers for deterministic CI
runs by replacing race-prone patterns with retry-safe alternatives.
No source code changes -- only `browser_tests/` is touched.
## Changes
- **E2E spec hardening** (98 spec files, 6 fixtures, 2 helpers):
| Fix class | Sites | Examples |
|-----------|-------|---------:|
| `expect(await ...)` -> `expect.poll()` | ~153 | interaction,
defaultKeybindings, workflows, featureFlags |
| `const x = await loc.count(); expect(x)` -> `toHaveCount()` | ~19 |
menu, linkInteraction, assets, bottomPanelShortcuts |
| `nextFrame()` -> `waitForHidden()` after menu clicks | ~22 |
contextMenu, rightClickMenu, subgraphHelper |
| Redundant `nextFrame()` removed | many | defaultKeybindings, minimap,
builderSaveFlow |
| `expect(async () => { ... }).toPass()` retry blocks | 5 | interaction
(graphdialog dismiss guard) |
| `force:true` removed from `BaseDialog.close()` | 1 | BaseDialog
fixture |
| ContextMenu `waitForHidden` simplified (check-then-act race removed) |
1 | ContextMenu fixture |
| Non-deterministic node order -> proximity-based selection | 1 |
interaction (toggle dom widget) |
| Tight poll timeout (250ms) -> >=2000ms | 2 | templates |
- **Helper improvements**: Exposed locator getters on
`ComfyPage.domWidgets`, `ToastHelper.toastErrors`, and
`WorkflowsSidebarTab.activeWorkflowLabel` so callers can use retrying
assertions (`toHaveCount()`, `toHaveText()`) directly.
- **Flake pattern catalog**: Added section 7 table to
`browser_tests/FLAKE_PREVENTION_RULES.md` documenting 8 pattern classes
for reviewers and future authors.
- **Docs**: Fixed bad examples in `browser_tests/README.md` to use
`expect.poll()`.
- **Breaking**: None
- **Dependencies**: None
## Review Focus
- All fixes follow the rules in
`browser_tests/FLAKE_PREVENTION_RULES.md`
- No behavioral changes to tests -- only timing/retry strategy is
updated
- The `ContextMenu.waitForHidden` simplification removes a
swallowed-error anti-pattern; both locators now use direct `waitFor({
state: 'hidden' })`
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: github-actions <github-actions@github.com>
109 lines
3.6 KiB
TypeScript
109 lines
3.6 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Node Library Essentials Tab', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
|
|
// Enable the essentials feature flag via the reactive serverFeatureFlags ref.
|
|
// In production, this flag comes via WebSocket or remoteConfig (cloud only).
|
|
// The localhost test server has neither, so we set it directly.
|
|
await comfyPage.page.evaluate(() => {
|
|
window.app!.api.serverFeatureFlags.value = {
|
|
...window.app!.api.serverFeatureFlags.value,
|
|
node_library_essentials_enabled: true
|
|
}
|
|
})
|
|
|
|
// Register a mock essential node so the essentials tab has content.
|
|
await comfyPage.page.evaluate(() => {
|
|
return window.app!.registerNodeDef('TestEssentialNode', {
|
|
name: 'TestEssentialNode',
|
|
display_name: 'Test Essential Node',
|
|
category: 'essentials_test',
|
|
input: { required: {}, optional: {} },
|
|
output: ['IMAGE'],
|
|
output_name: ['image'],
|
|
output_is_list: [false],
|
|
output_node: false,
|
|
python_module: 'comfy_essentials.nodes',
|
|
description: 'Mock essential node for testing',
|
|
essentials_category: 'Image Generation'
|
|
})
|
|
})
|
|
})
|
|
|
|
test('Node library opens via sidebar', async ({ comfyPage }) => {
|
|
const tabButton = comfyPage.page.locator('.node-library-tab-button')
|
|
await tabButton.click()
|
|
|
|
const sidebarContent = comfyPage.page.locator(
|
|
'.comfy-vue-side-bar-container'
|
|
)
|
|
await expect(sidebarContent).toBeVisible()
|
|
})
|
|
|
|
test('Essentials tab is visible in node library', async ({ comfyPage }) => {
|
|
const tabButton = comfyPage.page.locator('.node-library-tab-button')
|
|
await tabButton.click()
|
|
|
|
const essentialsTab = comfyPage.page.getByRole('tab', {
|
|
name: /essentials/i
|
|
})
|
|
await expect(essentialsTab).toBeVisible()
|
|
})
|
|
|
|
test('Clicking essentials tab shows essential node cards', async ({
|
|
comfyPage
|
|
}) => {
|
|
const tabButton = comfyPage.page.locator('.node-library-tab-button')
|
|
await tabButton.click()
|
|
|
|
const essentialsTab = comfyPage.page.getByRole('tab', {
|
|
name: /essentials/i
|
|
})
|
|
await essentialsTab.click()
|
|
|
|
const essentialCards = comfyPage.page.locator('[data-node-name]')
|
|
await expect(essentialCards.first()).toBeVisible()
|
|
})
|
|
|
|
test('Essential node cards have node names', async ({ comfyPage }) => {
|
|
const tabButton = comfyPage.page.locator('.node-library-tab-button')
|
|
await tabButton.click()
|
|
|
|
const essentialsTab = comfyPage.page.getByRole('tab', {
|
|
name: /essentials/i
|
|
})
|
|
await essentialsTab.click()
|
|
|
|
const firstCard = comfyPage.page.locator('[data-node-name]').first()
|
|
await expect(firstCard).toBeVisible()
|
|
|
|
await expect(firstCard).toHaveAttribute('data-node-name', /.+/)
|
|
})
|
|
|
|
test('Node library can switch between all and essentials tabs', async ({
|
|
comfyPage
|
|
}) => {
|
|
const tabButton = comfyPage.page.locator('.node-library-tab-button')
|
|
await tabButton.click()
|
|
|
|
const essentialsTab = comfyPage.page.getByRole('tab', {
|
|
name: /essentials/i
|
|
})
|
|
const allNodesTab = comfyPage.page.getByRole('tab', { name: /^all$/i })
|
|
|
|
await essentialsTab.click()
|
|
await expect(essentialsTab).toHaveAttribute('aria-selected', 'true')
|
|
const essentialCards = comfyPage.page.locator('[data-node-name]')
|
|
await expect(essentialCards.first()).toBeVisible()
|
|
|
|
await allNodesTab.click()
|
|
await expect(allNodesTab).toHaveAttribute('aria-selected', 'true')
|
|
await expect(essentialsTab).toHaveAttribute('aria-selected', 'false')
|
|
})
|
|
})
|