mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-11 08:20:53 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
44 lines
1.5 KiB
TypeScript
44 lines
1.5 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { userSelectPageFixture as test } from '@e2e/fixtures/UserSelectPage'
|
|
|
|
/**
|
|
* Expects ComfyUI backend to be launched with `--multi-user` flag.
|
|
*/
|
|
test.describe('User Select View', { tag: '@settings' }, () => {
|
|
test.beforeEach(async ({ userSelectPage, page }) => {
|
|
await page.goto(userSelectPage.url)
|
|
await page.evaluate(() => {
|
|
localStorage.clear()
|
|
sessionStorage.clear()
|
|
})
|
|
})
|
|
|
|
test('Redirects to user select view if no user is logged in', async ({
|
|
userSelectPage,
|
|
page
|
|
}) => {
|
|
await page.goto(userSelectPage.url)
|
|
await expect(userSelectPage.container).toBeVisible()
|
|
expect(page.url()).toBe(userSelectPage.selectionUrl)
|
|
})
|
|
|
|
test('Can create new user', async ({ userSelectPage, page }) => {
|
|
const randomUser = `test-user-${Math.random().toString(36).substring(2, 7)}`
|
|
await page.goto(userSelectPage.url)
|
|
await expect(page).toHaveURL(userSelectPage.selectionUrl)
|
|
await userSelectPage.newUserInput.fill(randomUser)
|
|
await userSelectPage.nextButton.click()
|
|
await expect(page).toHaveURL(userSelectPage.url)
|
|
})
|
|
|
|
test('Can choose existing user', async ({ userSelectPage, page }) => {
|
|
await page.goto(userSelectPage.url)
|
|
await expect(page).toHaveURL(userSelectPage.selectionUrl)
|
|
await userSelectPage.existingUserSelect.click()
|
|
await page.locator('.p-select-list .p-select-option').first().click()
|
|
await userSelectPage.nextButton.click()
|
|
await expect(page).toHaveURL(userSelectPage.url)
|
|
})
|
|
})
|