mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-28 18:22:40 +00:00
The zendesk support test was flaky because it waited for `networkidle` on an external Zendesk page (`support.comfy.org`). External network requests in CI are unreliable — they can timeout, be slow, or redirect. **Fix:** Intercept `window.open` to capture the URL that would be opened, without actually navigating to the external page. This makes the test deterministic and fast. - Fixes flaky test: `[chromium] › browser_tests/tests/dialog.spec.ts:339:3 › Support › Should open external zendesk link with OSS tag` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9035-fix-intercept-window-open-in-zendesk-test-to-avoid-external-network-dependency-30e6d73d365081c2a021edd816b8c1d0) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
14 KiB
14 KiB