mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-03-07 22:20:03 +00:00
## Summary Various fixes from app mode QA ## Changes - **What**: - fix: prevent inserting nodes from workflow/apps sidebar tabs - fix: hide json extension in workflow tab - fix: hide apps nav button in apps tab when already in apps mode - fix: center text on arrange page - fix: prevent IoItems from "jumping" due to stale transform after drag and drop op - fix: refactor side panels and add custom stable pixel based sizing - fix: make outputs/inputs lists in app builder scrollable - fix: fix rerun not working correctly - feat: add text to interrupt button - feat: add enter app mode button to builder toolbar - feat: add tooltip to download button on linear view - feat: show last output of workflow in arrange tab if available - feat: show download count in download all button, hide if only 1 asset to download ## Review Focus - Rerun - I am not sure why it was triggering widget actions, removing it seemed like the correct fix - useStablePrimeVueSplitter - this is a workaround for the fact it uses percent sizing, I also tried switching to reka-ui splitters, but they also only support % sizing in our version [pixel based looks to have been added in a newer version, will log an issue to upgrade & replace splitters with this] ## Screenshots (if applicable) <img width="1314" height="1129" alt="image" src="https://github.com/user-attachments/assets/c430f9d6-7c29-4853-803e-5b6fe7086fca" /> <img width="511" height="283" alt="image" src="https://github.com/user-attachments/assets/b7e594d4-70a1-41e3-8ba1-78512f2a5c8b" /> <img width="254" height="232" alt="image" src="https://github.com/user-attachments/assets/1d146399-39ea-4b0e-928c-340b74957535" /> <img width="487" height="198" alt="image" src="https://github.com/user-attachments/assets/e2ba7f5d-8ff5-47f4-9526-61ebb99514b8" /> <img width="378" height="647" alt="image" src="https://github.com/user-attachments/assets/a47a3054-9320-4327-bdc0-b0a16e19f83d" /> <img width="1016" height="476" alt="image" src="https://github.com/user-attachments/assets/479ae50e-d380-4d56-a5c9-5df142b14ed0" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9439-feat-fix-App-mode-QA-updates-31a6d73d365081b38337d63207b88817) by [Unito](https://www.unito.io)
134 lines
4.5 KiB
TypeScript
134 lines
4.5 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
import { getMiddlePoint } from '../fixtures/utils/litegraphUtils'
|
|
|
|
test.describe('Reroute Node', { tag: ['@screenshot', '@node'] }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
})
|
|
|
|
test.afterEach(async ({ comfyPage }) => {
|
|
await comfyPage.workflow.setupWorkflowsDirectory({})
|
|
})
|
|
|
|
test('loads from inserted workflow', async ({ comfyPage }) => {
|
|
const workflowName = 'single_connected_reroute_node'
|
|
await comfyPage.workflow.setupWorkflowsDirectory({
|
|
[`${workflowName}.json`]: `links/${workflowName}.json`
|
|
})
|
|
await comfyPage.setup()
|
|
await comfyPage.menu.topbar.triggerTopbarCommand(['New'])
|
|
|
|
// Insert the workflow
|
|
const workflowsTab = comfyPage.menu.workflowsTab
|
|
await workflowsTab.open()
|
|
await workflowsTab.getPersistedItem(workflowName).click({ button: 'right' })
|
|
const insertButton = comfyPage.page.locator('.p-contextmenu-item-link', {
|
|
hasText: 'Insert'
|
|
})
|
|
await insertButton.click()
|
|
|
|
// Close the sidebar tab
|
|
await workflowsTab.tabButton.click()
|
|
await workflowsTab.root.waitFor({ state: 'hidden' })
|
|
await comfyPage.setFocusMode(true)
|
|
|
|
await expect(comfyPage.canvas).toHaveScreenshot('reroute_inserted.png')
|
|
})
|
|
})
|
|
|
|
test.describe(
|
|
'LiteGraph Native Reroute Node',
|
|
{ tag: ['@screenshot', '@node'] },
|
|
() => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
await comfyPage.settings.setSetting('LiteGraph.Reroute.SplineOffset', 80)
|
|
})
|
|
|
|
test('loads from workflow', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('reroute/native_reroute')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('native_reroute.png')
|
|
})
|
|
|
|
test('@2x @0.5x Can add reroute by alt clicking on link', async ({
|
|
comfyPage
|
|
}) => {
|
|
const loadCheckpointNode = (
|
|
await comfyPage.nodeOps.getNodeRefsByTitle('Load Checkpoint')
|
|
)[0]
|
|
const clipEncodeNode = (
|
|
await comfyPage.nodeOps.getNodeRefsByTitle('CLIP Text Encode (Prompt)')
|
|
)[0]
|
|
|
|
const slot1 = await loadCheckpointNode.getOutput(1)
|
|
const slot2 = await clipEncodeNode.getInput(0)
|
|
const middlePoint = getMiddlePoint(
|
|
await slot1.getPosition(),
|
|
await slot2.getPosition()
|
|
)
|
|
|
|
await comfyPage.page.keyboard.down('Alt')
|
|
await comfyPage.page.mouse.click(middlePoint.x, middlePoint.y)
|
|
await comfyPage.page.keyboard.up('Alt')
|
|
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'native_reroute_alt_click.png'
|
|
)
|
|
})
|
|
|
|
test('Can add reroute by clicking middle of link context menu', async ({
|
|
comfyPage
|
|
}) => {
|
|
const loadCheckpointNode = (
|
|
await comfyPage.nodeOps.getNodeRefsByTitle('Load Checkpoint')
|
|
)[0]
|
|
const clipEncodeNode = (
|
|
await comfyPage.nodeOps.getNodeRefsByTitle('CLIP Text Encode (Prompt)')
|
|
)[0]
|
|
|
|
const slot1 = await loadCheckpointNode.getOutput(1)
|
|
const slot2 = await clipEncodeNode.getInput(0)
|
|
const middlePoint = getMiddlePoint(
|
|
await slot1.getPosition(),
|
|
await slot2.getPosition()
|
|
)
|
|
|
|
await comfyPage.page.mouse.click(middlePoint.x, middlePoint.y)
|
|
await comfyPage.page
|
|
.locator('.litecontextmenu .litemenu-entry', { hasText: 'Add Reroute' })
|
|
.click()
|
|
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'native_reroute_context_menu.png'
|
|
)
|
|
})
|
|
|
|
test('Can delete link that is connected to two reroutes', async ({
|
|
comfyPage
|
|
}) => {
|
|
// https://github.com/Comfy-Org/ComfyUI_frontend/issues/4695
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'reroute/single-native-reroute-default-workflow'
|
|
)
|
|
|
|
// To find the clickable midpoint button, we use the hardcoded value from the browser logs
|
|
// since the link is a bezier curve and not a straight line.
|
|
const middlePoint = { x: 359.4188232421875, y: 468.7716979980469 }
|
|
|
|
// Click the middle point of the link to open the context menu.
|
|
await comfyPage.page.mouse.click(middlePoint.x, middlePoint.y)
|
|
|
|
// Click the "Delete" context menu option.
|
|
await comfyPage.page
|
|
.locator('.litecontextmenu .litemenu-entry', { hasText: 'Delete' })
|
|
.click()
|
|
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'native_reroute_delete_from_midpoint_context_menu.png'
|
|
)
|
|
})
|
|
}
|
|
)
|