mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-08 09:00:05 +00:00

Files

Alexander Brown b56045c462 fix: browser_tests Phase 1 - mechanical fixes

- Rename dragAndDrop to dragDrop (7 occurrences)

- Add override modifiers in SidebarTab.ts (4 fixes)

- Remove .ts import extensions in actionbar.spec.ts

- Prefix unused variables with underscore (9 files)

- Fix ESLint import() type annotation in globals.d.ts

Reduces typecheck:browser errors from 229 to 215

Amp-Thread-ID: https://ampcode.com/threads/T-019c1787-c781-761d-b95a-4844e909e64c
Co-authored-by: Amp <amp@ampcode.com>

2026-01-31 21:57:58 -08:00

1.2 KiB

Raw Blame History

globs

**/*.spec.ts

Playwright E2E Test Conventions

See docs/testing/*.md for detailed patterns.

Best Practices

Follow Playwright Best Practices
Do NOT use waitForTimeout - use Locator actions and retrying assertions
Prefer specific selectors (role, label, test-id)
Test across viewports

Window Globals

Browser tests access window.app, window.graph, and window.LiteGraph which are optional in the main app types. In E2E tests, use non-null assertions (!):

window.app!.graph!.nodes
window.LiteGraph!.registered_node_types

This is the only context where non-null assertions are acceptable.

TODO: Consolidate these references into a central utility (e.g., getApp()) that performs proper runtime type checking, removing the need for scattered ! assertions.

Test Tags

Tags are respected by config:

@mobile - Mobile viewport tests
@2x - High DPI tests

Test Data

Check browser_tests/assets/ for test data and fixtures
Use realistic ComfyUI workflows for E2E tests

Running Tests

pnpm test:browser:local                 # Run all E2E tests
pnpm test:browser:local -- --ui         # Interactive UI mode

1.2 KiB Raw Blame History