ComfyUI_frontend/tests at 69b57eaba54674a86069cecea3e0958e4d8720e9 - ComfyUI_frontend - Public git mirror

Comfy-Org/ComfyUI_frontend

mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-01-26 10:59:53 +00:00

Files

History

Johnpaul Chiwetelu 941cd2b4a5 refactor: improve TypeScript patterns in test files (Group 1/8) (#8253 )

## Summary
Improves type safety in test files by replacing unsafe type patterns
with proper TypeScript idioms.

## Changes
- Define typed `TestWindow` interface extending `Window` for Playwright
tests with custom properties
- Use `Partial<HTMLElement>` with single type assertion for DOM element
mocks
- Remove redundant type imports
- Fix `console.log` → `console.warn` in test fixture

## Files Changed
16 test files across browser_tests, packages, and src/components

## Test Plan
- ✅ `pnpm typecheck` passes
- ✅ No new `any` types introduced
- ✅ All pre-commit hooks pass

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8253-refactor-improve-TypeScript-patterns-in-test-files-Group-1-8-2f16d73d365081548f9ece7bcf0525ee)
by [Unito](https://www.unito.io)

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

2026-01-23 02:35:09 +01:00

..

colorPalette.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

copyPaste.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

domWidget.spec.ts-snapshots

Component: The Rest of the PrimeVue buttons (#7649 )

2025-12-29 15:03:34 -08:00

execution.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

graphCanvasMenu.spec.ts-snapshots

Component: The Rest of the PrimeVue buttons (#7649 )

2025-12-29 15:03:34 -08:00

groupNode.spec.ts-snapshots

[Refactor] Re-organize browser_tests directory (#3105 )

2025-03-17 15:32:14 -04:00

interaction.spec.ts-snapshots

Component: The Rest of the PrimeVue buttons (#7649 )

2025-12-29 15:03:34 -08:00

loadWorkflowInMedia.spec.ts-snapshots

fix: loading api-format workflow that contains "parameters" string (#7411 )

2025-12-12 21:39:30 -07:00

lodThreshold.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

mobileBaseline.spec.ts-snapshots

feat: show active jobs label in top menu (#8169 )

2026-01-21 20:45:29 -07:00

nodeBadge.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

nodeDisplay.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

nodeSearchBox.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

noteNode.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

primitiveNode.spec.ts-snapshots

Disable control widgets on link to parent (#8112 )

2026-01-16 22:11:00 -07:00

propertiesPanel

feat: right side panel favorites, no selection state, and more... (#7812 )

2026-01-13 20:37:17 -07:00

recordAudio.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

rerouteNode.spec.ts-snapshots

Component: The Rest of the PrimeVue buttons (#7649 )

2025-12-29 15:03:34 -08:00

rightClickMenu.spec.ts-snapshots

feat: right side panel favorites, no selection state, and more... (#7812 )

2026-01-13 20:37:17 -07:00

selectionToolbox.spec.ts-snapshots

fix: adjust toolbox sizing to match Figma design (#8115 )

2026-01-17 00:38:58 +01:00

Component: The Rest of the PrimeVue buttons (#7649 )

2025-12-29 15:03:34 -08:00

templates.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

viewport.spec.ts-snapshots

feat: show active jobs label in top menu (#8169 )

2026-01-21 20:45:29 -07:00

refactor: improve TypeScript patterns in test files (Group 1/8) (#8253 )

2026-01-23 02:35:09 +01:00

widget.spec.ts-snapshots

Fix: Update for Image Widget test (#8031 )

2026-01-13 14:46:41 -08:00

actionbar.spec.ts

Floating Menus - UI rework (#5980 )

2025-10-16 18:12:09 -07:00

backgroundImageUpload.spec.ts

Fix: Flaky Playwright Tests: retry some assertions (#7389 )

2025-12-11 14:02:23 -08:00

bottomPanelShortcuts.spec.ts

Keyboard Shortcut Bottom Panel (#4635 )

2025-08-07 11:51:23 -07:00

browserTabTitle.spec.ts

[Refactor] Re-organize browser_tests directory (#3105 )

2025-03-17 15:32:14 -04:00

changeTracker.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

colorPalette.spec.ts

Tests: Playwright test timeouts (#7231 )

2025-12-08 15:50:35 -08:00

commands.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

copyPaste.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

customIcons.spec.ts

Enhanced custom icon support with tailwind (#5159 )

2025-08-25 10:20:12 -07:00

dialog.spec.ts

Component: The Rest of the PrimeVue buttons (#7649 )

2025-12-29 15:03:34 -08:00

domWidget.spec.ts

Cleanup: YAGNI readonly props, private swap on ComfyApp, Canvas resize events simplification, v-memos on individual instances (#5869 )

2025-10-02 10:35:10 -07:00

execution.spec.ts

Fix: Flaky Playwright Tests: retry some assertions (#7389 )

2025-12-11 14:02:23 -08:00

extensionAPI.spec.ts

lint: add tsconfig for browser_tests, fix existing violations (#5633 )

2025-09-18 11:35:44 -07:00

featureFlags.spec.ts

refactor: improve TypeScript patterns in test files (Group 1/8) (#8253 )

2026-01-23 02:35:09 +01:00

graph.spec.ts

fix: enable workflow validation (#7833 )

2026-01-02 19:58:16 -08:00

graphCanvasMenu.spec.ts

rework minimap, toolbox, and menu designs with unified theming (#6038 )

2025-10-14 14:26:07 -07:00

groupNode.spec.ts

Tests: Playwright test timeouts (#7231 )

2025-12-08 15:50:35 -08:00

interaction.spec.ts

fix: make flaky legacy prompt dialog test use locator rather than snapshot (#7371 )

2025-12-11 11:47:39 -08:00

keybindings.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

litegraphEvent.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

loadWorkflowInMedia.spec.ts

fix: loading api-format workflow that contains "parameters" string (#7411 )

2025-12-12 21:39:30 -07:00

lodThreshold.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

menu.spec.ts

Subgraph/workflow breadcrumbs menu updates (#7852 )

2026-01-12 16:08:28 -07:00

minimap.spec.ts

rework minimap, toolbox, and menu designs with unified theming (#6038 )

2025-10-14 14:26:07 -07:00

mobileBaseline.spec.ts

Fix(test): Mask username field in settings since it's not deterministic. (#8033 )

2026-01-13 15:44:45 -08:00

nodeBadge.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

nodeDisplay.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

nodeHelp.spec.ts

refactor: improve TypeScript patterns in test files (Group 1/8) (#8253 )

2026-01-23 02:35:09 +01:00

nodeSearchBox.spec.ts

fix: flaky legacy context menu e2e test (#7373 )

2025-12-12 15:33:10 -08:00

noteNode.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

primitiveNode.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

recordAudio.spec.ts

[fix] Enable AUDIO_RECORD widget in both LiteGraph and Vue nodes modes (#6094 )

2025-10-18 03:15:26 -07:00

releaseNotifications.spec.ts

style: update ui and design of system notification components (what's new, new release notification, help center) (#6300 )

2025-12-09 00:07:02 -07:00

remoteWidgets.spec.ts

Fix: Flaky Playwright Tests: retry some assertions (#7389 )

2025-12-11 14:02:23 -08:00

rerouteNode.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

rightClickMenu.spec.ts

Tests: Playwright test timeouts (#7231 )

2025-12-08 15:50:35 -08:00

selectionToolbox.spec.ts

test(e2e): align test default menu to Top; make legacy specs explicit (#5746 )

2025-09-24 18:43:22 -07:00

selectionToolboxSubmenus.spec.ts

refactor: improve TypeScript patterns in test files (Group 1/8) (#8253 )

2026-01-23 02:35:09 +01:00

subgraph-rename-dialog.spec.ts

[refactor] Organize all browser test assets into logical folders (#5058 )

2025-08-18 10:39:53 -07:00

subgraph.spec.ts

Fix subgraphNode widget cloning with compressed target_slot (#7388 )

2025-12-11 12:32:35 -08:00

templates.spec.ts

refactor: restructure BaseModalLayout from flexbox to CSS Grid (#8211 )

2026-01-21 13:20:39 -08:00

userSelectView.spec.ts

[Refactor] Re-organize browser_tests directory (#3105 )

2025-03-17 15:32:14 -04:00

useSettingSearch.spec.ts

Tests: Playwright test timeouts (#7231 )

2025-12-08 15:50:35 -08:00

versionMismatchWarnings.spec.ts

Test: Double timeout for Version Mismatch Warnings (#5814 )

2025-09-27 20:08:00 +10:00

viewport.spec.ts

feat: when restored position has no nodes in viewport, automatically fit to view (#7435 )

2025-12-17 15:38:05 -08:00

widget.spec.ts

Fix: Update for Image Widget test (#8031 )

2026-01-13 14:46:41 -08:00

workflowTabThumbnail.spec.ts

Refactor app menu items (#4665 )

2025-08-14 14:53:46 -07:00