mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-11 16:30:57 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
71 lines
2.5 KiB
TypeScript
71 lines
2.5 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { PropertiesPanelHelper } from '@e2e/tests/propertiesPanel/PropertiesPanelHelper'
|
|
|
|
test.describe('Properties panel - Workflow Overview', () => {
|
|
let panel: PropertiesPanelHelper
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
panel = new PropertiesPanelHelper(comfyPage.page)
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
await expect(panel.root).toBeVisible()
|
|
})
|
|
|
|
test('should show "Workflow Overview" title when nothing is selected', async () => {
|
|
await expect(panel.panelTitle).toContainText('Workflow Overview')
|
|
})
|
|
|
|
test('should show Parameters, Nodes, and Settings tabs', async () => {
|
|
await expect(panel.getTab('Parameters')).toBeVisible()
|
|
await expect(panel.getTab('Nodes')).toBeVisible()
|
|
await expect(panel.getTab('Settings')).toBeVisible()
|
|
})
|
|
|
|
test('should not show Info tab when nothing is selected', async () => {
|
|
await expect(panel.getTab('Info')).not.toBeVisible()
|
|
})
|
|
|
|
test('should switch to Nodes tab and list all workflow nodes', async ({
|
|
comfyPage
|
|
}) => {
|
|
await panel.switchToTab('Nodes')
|
|
const nodeCount = await comfyPage.nodeOps.getNodeCount()
|
|
expect(nodeCount).toBeGreaterThan(0)
|
|
await expect(panel.contentArea.locator('text=KSampler')).toBeVisible()
|
|
})
|
|
|
|
test('should filter nodes by search in Nodes tab', async () => {
|
|
await panel.switchToTab('Nodes')
|
|
await panel.searchWidgets('KSampler')
|
|
await expect(panel.contentArea.getByText('KSampler').first()).toBeVisible()
|
|
})
|
|
|
|
test('should switch to Settings tab and show global settings', async () => {
|
|
await panel.switchToTab('Settings')
|
|
await expect(panel.viewAllSettingsButton).toBeVisible()
|
|
})
|
|
|
|
test('should show "View all settings" button', async () => {
|
|
await panel.switchToTab('Settings')
|
|
await expect(panel.viewAllSettingsButton).toBeVisible()
|
|
})
|
|
|
|
test('should show Nodes section with toggles', async () => {
|
|
await panel.switchToTab('Settings')
|
|
await expect(
|
|
panel.contentArea.getByRole('button', { name: 'NODES' })
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('should show Canvas section with grid settings', async () => {
|
|
await panel.switchToTab('Settings')
|
|
await expect(panel.contentArea.getByText('Canvas')).toBeVisible()
|
|
})
|
|
|
|
test('should show Connection Links section', async () => {
|
|
await panel.switchToTab('Settings')
|
|
await expect(panel.contentArea.getByText('Connection Links')).toBeVisible()
|
|
})
|
|
})
|