mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-07 16:40:05 +00:00
b979ba8992
## Summary - Fixes issue where locale commits would cancel in-progress E2E tests on release PRs - E2E tests now run **once** after i18n workflow completes for version-bump PRs ## Changes 1. **Modified `ci-tests-e2e.yaml`**: - Added `workflow_call` trigger with `ref` and `pr_number` inputs - Added skip condition for version-bump PRs on `pull_request` trigger - Updated checkout steps to use `inputs.ref` when called via `workflow_call` 2. **Created `ci-tests-e2e-release.yaml`**: - Triggers on `workflow_run` completion of `i18n: Update Core` - Only runs for version-bump PRs from main repo - Calls original E2E workflow via `workflow_call` (no job duplication) ## How it works **Regular PRs:** `CI: Tests E2E` runs normally via `pull_request` trigger **Version-bump PRs:** 1. `CI: Tests E2E` skips (setup job condition fails) 2. `i18n: Update Core` runs and commits locale updates 3. `CI: Tests E2E (Release PRs)` triggers after i18n completes 4. Calls `CI: Tests E2E` via `workflow_call` 5. E2E tests run to completion without cancellation ## Test plan - [x] Tested workflow_call chain on fork - [x] Verify version-bump PR skips regular E2E workflow - [x] Verify E2E runs after i18n completes on next release Fixes the issue identified during v1.38.2 release where locale commits caused E2E tests to restart multiple times. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8091-fix-run-E2E-tests-after-i18n-completes-on-release-PRs-2ea6d73d36508151a315ed1f415afcc6) by [Unito](https://www.unito.io)
GitHub Workflows
Naming Convention
Workflow files follow a consistent naming pattern: <prefix>-<descriptive-name>.yaml
Category Prefixes
| Prefix | Purpose | Example |
|---|---|---|
ci- |
Testing, linting, validation | ci-tests-e2e.yaml |
release- |
Version management, publishing | release-version-bump.yaml |
pr- |
PR automation (triggered by labels) | pr-claude-review.yaml |
api- |
External Api type generation | api-update-registry-api-types.yaml |
i18n- |
Internationalization updates | i18n-update-core.yaml |
Documentation
Each workflow file contains comments explaining its purpose, triggers, and behavior. For specific details about what each workflow does, refer to the comments at the top of each .yaml file.
For GitHub Actions documentation, see Events that trigger workflows.