mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-25 01:04:06 +00:00
b979ba8992
## Summary - Fixes issue where locale commits would cancel in-progress E2E tests on release PRs - E2E tests now run **once** after i18n workflow completes for version-bump PRs ## Changes 1. **Modified `ci-tests-e2e.yaml`**: - Added `workflow_call` trigger with `ref` and `pr_number` inputs - Added skip condition for version-bump PRs on `pull_request` trigger - Updated checkout steps to use `inputs.ref` when called via `workflow_call` 2. **Created `ci-tests-e2e-release.yaml`**: - Triggers on `workflow_run` completion of `i18n: Update Core` - Only runs for version-bump PRs from main repo - Calls original E2E workflow via `workflow_call` (no job duplication) ## How it works **Regular PRs:** `CI: Tests E2E` runs normally via `pull_request` trigger **Version-bump PRs:** 1. `CI: Tests E2E` skips (setup job condition fails) 2. `i18n: Update Core` runs and commits locale updates 3. `CI: Tests E2E (Release PRs)` triggers after i18n completes 4. Calls `CI: Tests E2E` via `workflow_call` 5. E2E tests run to completion without cancellation ## Test plan - [x] Tested workflow_call chain on fork - [x] Verify version-bump PR skips regular E2E workflow - [x] Verify E2E runs after i18n completes on next release Fixes the issue identified during v1.38.2 release where locale commits caused E2E tests to restart multiple times. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8091-fix-run-E2E-tests-after-i18n-completes-on-release-PRs-2ea6d73d36508151a315ed1f415afcc6) by [Unito](https://www.unito.io)
66 lines
2.5 KiB
YAML
66 lines
2.5 KiB
YAML
# Description: Runs E2E tests for release PRs after i18n workflow completes
|
|
name: 'CI: Tests E2E (Release PRs)'
|
|
|
|
on:
|
|
workflow_run:
|
|
workflows: ['i18n: Update Core']
|
|
types: [completed]
|
|
|
|
jobs:
|
|
check-eligibility:
|
|
runs-on: ubuntu-latest
|
|
# Only run if:
|
|
# 1. This is the main repository
|
|
# 2. The i18n workflow was triggered by a pull_request
|
|
# 3. The i18n workflow completed successfully or was skipped (no locale changes)
|
|
# 4. The branch is a version-bump branch
|
|
# 5. The PR is from the main repo (not a fork)
|
|
if: |
|
|
github.repository == 'Comfy-Org/ComfyUI_frontend' &&
|
|
github.event.workflow_run.event == 'pull_request' &&
|
|
(github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == 'skipped') &&
|
|
startsWith(github.event.workflow_run.head_branch, 'version-bump-') &&
|
|
github.event.workflow_run.head_repository.full_name == github.event.workflow_run.repository.full_name
|
|
outputs:
|
|
pr_number: ${{ steps.pr.outputs.result }}
|
|
head_sha: ${{ github.event.workflow_run.head_sha }}
|
|
steps:
|
|
- name: Log workflow trigger info
|
|
run: |
|
|
echo "Repository: ${{ github.repository }}"
|
|
echo "Event: ${{ github.event.workflow_run.event }}"
|
|
echo "Conclusion: ${{ github.event.workflow_run.conclusion }}"
|
|
echo "Head branch: ${{ github.event.workflow_run.head_branch }}"
|
|
echo "Head SHA: ${{ github.event.workflow_run.head_sha }}"
|
|
echo "Head repo: ${{ github.event.workflow_run.head_repository.full_name }}"
|
|
|
|
- name: Get PR Number
|
|
id: pr
|
|
uses: actions/github-script@v7
|
|
with:
|
|
script: |
|
|
const { data: prs } = await github.rest.pulls.list({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
state: 'open',
|
|
});
|
|
|
|
const pr = prs.find(p => p.head.sha === context.payload.workflow_run.head_sha);
|
|
|
|
if (!pr) {
|
|
console.log('No PR found for SHA:', context.payload.workflow_run.head_sha);
|
|
return null;
|
|
}
|
|
|
|
console.log(`Found PR #${pr.number} for version bump: ${context.payload.workflow_run.head_branch}`);
|
|
return pr.number;
|
|
|
|
run-e2e-tests:
|
|
needs: check-eligibility
|
|
if: needs.check-eligibility.outputs.pr_number != 'null'
|
|
uses: ./.github/workflows/ci-tests-e2e.yaml
|
|
with:
|
|
ref: ${{ needs.check-eligibility.outputs.head_sha }}
|
|
pr_number: ${{ needs.check-eligibility.outputs.pr_number }}
|
|
secrets: inherit
|