[PR #55] [MERGED] Dev/direct read #89

New issue

Closed

opened 2026-10-26 22:24:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:24:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-aimdo/pull/55
Author: @rattus128
Created: 5/26/2026
Status: ✅ Merged
Merged: 5/26/2026
Merged by: @rattus128

Base: master ← Head: dev/direct-read

📝 Commits (5)

31aceed add events APIs
0b1a288 hostbuf: added buffered direct file reader
41e8585 mmap: Implement linux bounce as MADV_DONTNEED
13a4bb0 hostbuf: Add async decommitment and reservation
f7fa832 mmap: return file handle

📊 Changes

14 files changed (+371 additions, -7 deletions)

View changed files

📝 comfy_aimdo/host_buffer.py (+24 -0)
📝 comfy_aimdo/model_mmap.py (+6 -0)
📝 src-cuda/dispatch.c (+4 -0)
📝 src-hip/dispatch.c (+4 -0)
📝 src-posix/model-mmap.c (+13 -1)
📝 src-win/model-mmap.c (+11 -1)
📝 src/control.c (+3 -0)
📝 src/gpu_abi.h (+5 -0)
📝 src/gpu_dispatch.h (+8 -0)
➕ src/hostbuf-decommit.c (+107 -0)
➕ src/hostbuf-decommit.h (+44 -0)
➕ src/hostbuf-file-reader.c (+114 -0)
📝 src/hostbuf.c (+24 -5)
📝 src/plat.h (+4 -0)

📄 Description

Contribution Agreement

I agree that my contributions are licensed under the GPLv3.
I grant Comfy Org the rights to relicense these contributions as outlined in CONTRIBUTING.md.

Implemented direct read from file -> GPU via ring buffer
Make decommit queue async

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-aimdo/pull/55 **Author:** [@rattus128](https://github.com/rattus128) **Created:** 5/26/2026 **Status:** ✅ Merged **Merged:** 5/26/2026 **Merged by:** [@rattus128](https://github.com/rattus128) **Base:** `master` ← **Head:** `dev/direct-read` --- ### 📝 Commits (5) - [`31aceed`](https://github.com/Comfy-Org/comfy-aimdo/commit/31aceed4e4c14c8c36e9e19f7a4b17d63f8d397b) add events APIs - [`0b1a288`](https://github.com/Comfy-Org/comfy-aimdo/commit/0b1a28861ddea28b2454bcec8903ba69ee14e91c) hostbuf: added buffered direct file reader - [`41e8585`](https://github.com/Comfy-Org/comfy-aimdo/commit/41e85854a87bf614a287ab0a7432aa078946806e) mmap: Implement linux bounce as MADV_DONTNEED - [`13a4bb0`](https://github.com/Comfy-Org/comfy-aimdo/commit/13a4bb009af6d93bf7cb79de47af96977cce4e2e) hostbuf: Add async decommitment and reservation - [`f7fa832`](https://github.com/Comfy-Org/comfy-aimdo/commit/f7fa832ef6554dee3c4ba4298c97fd38491e8221) mmap: return file handle ### 📊 Changes **14 files changed** (+371 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `comfy_aimdo/host_buffer.py` (+24 -0) 📝 `comfy_aimdo/model_mmap.py` (+6 -0) 📝 `src-cuda/dispatch.c` (+4 -0) 📝 `src-hip/dispatch.c` (+4 -0) 📝 `src-posix/model-mmap.c` (+13 -1) 📝 `src-win/model-mmap.c` (+11 -1) 📝 `src/control.c` (+3 -0) 📝 `src/gpu_abi.h` (+5 -0) 📝 `src/gpu_dispatch.h` (+8 -0) ➕ `src/hostbuf-decommit.c` (+107 -0) ➕ `src/hostbuf-decommit.h` (+44 -0) ➕ `src/hostbuf-file-reader.c` (+114 -0) 📝 `src/hostbuf.c` (+24 -5) 📝 `src/plat.h` (+4 -0) </details> ### 📄 Description ### Contribution Agreement - [X] I agree that my contributions are licensed under the GPLv3. - [X] I grant **Comfy Org** the rights to relicense these contributions as outlined in [CONTRIBUTING.md](./CONTRIBUTING.md). Implemented direct read from file -> GPU via ring buffer Make decommit queue async --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:24:28 +00:00