Comfy-Org/comfy-angle
1
0
Fork 0
mirror of https://github.com/Comfy-Org/comfy-angle.git synced 2026-11-04 23:37:28 +00:00
Code Issues 1 Projects Packages Wiki Activity

[PR #11] [CLOSED] ci: run ANGLE downloads on Node 26 #11

New issue
Closed
opened 2026-10-26 22:27:45 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 22:27:45 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-angle/pull/11
Author: @benceruleanlu
Created: 9/29/2026
Status: ❌ Closed

Base: main ← Head: chore/node-runtime-refresh-2026-09-28

📝 Commits (1)

  • f560baf ci: run ANGLE downloads on Node 26

📊 Changes

3 files changed (+11 additions, -11 deletions)

View changed files

📝 .github/workflows/audit-workflows.yml (+1 -1)
📝 .github/workflows/publish-test.yml (+5 -5)
📝 .github/workflows/publish.yml (+5 -5)

📄 Description

Use Node 26 for the Electron ANGLE download stage and refresh checkout/setup-node to v7, preserving SHA pins.

Validation: On Node 26.10.0: npm ci, downloader syntax check, and loading @electron/get and yauzl passed. actionlint and git diff --check passed. Cross-platform Electron downloads, native builds, and publication remain for CI.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-angle/pull/11 **Author:** [@benceruleanlu](https://github.com/benceruleanlu) **Created:** 9/29/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `chore/node-runtime-refresh-2026-09-28` --- ### 📝 Commits (1) - [`f560baf`](https://github.com/Comfy-Org/comfy-angle/commit/f560baf9d776d7cc0e10671d9bc48b9a8d582878) ci: run ANGLE downloads on Node 26 ### 📊 Changes **3 files changed** (+11 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/audit-workflows.yml` (+1 -1) 📝 `.github/workflows/publish-test.yml` (+5 -5) 📝 `.github/workflows/publish.yml` (+5 -5) </details> ### 📄 Description Use Node 26 for the Electron ANGLE download stage and refresh checkout/setup-node to v7, preserving SHA pins. Validation: On Node 26.10.0: npm ci, downloader syntax check, and loading @electron/get and yauzl passed. actionlint and git diff --check passed. Cross-platform Electron downloads, native builds, and publication remain for CI. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:27:45 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
chore/node-runtime-refresh-2026-09-28
fix/cla-api-failure-handling
alexisrolland-patch-2
alexisrolland-patch-1
v0.1.1
v0.1.0
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/comfy-angle#11
No description provided.