[PR #1] [MERGED] Fail CLA allowlist build when GitHub API fails #1

Closed
opened 2026-10-26 22:40:20 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-cla/pull/1
Author: @alexisrolland
Created: 8/21/2026
Status: ✅ Merged
Merged: 8/21/2026
Merged by: @alexisrolland

Base: main ← Head: fix/cla-api-failure-handling


📝 Commits (1)

  • 3adf499 Fail CLA allowlist build when GitHub API fails

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 .github/workflows/cla.yml (+6 -3)

📄 Description

Summary

  • capture the pull request commit API response before processing the author list
  • fail the allowlist step explicitly when gh api fails
  • preserve the valid author-only case where filtering produces no co-authors

Verification

  • parsed the workflow as YAML
  • checked the embedded Bash syntax
  • exercised co-author, author-only, and simulated API-failure scenarios
  • ran git diff --check

Closes Comfy-Org/ComfyUI_frontend#15555


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-cla/pull/1 **Author:** [@alexisrolland](https://github.com/alexisrolland) **Created:** 8/21/2026 **Status:** ✅ Merged **Merged:** 8/21/2026 **Merged by:** [@alexisrolland](https://github.com/alexisrolland) **Base:** `main` ← **Head:** `fix/cla-api-failure-handling` --- ### 📝 Commits (1) - [`3adf499`](https://github.com/Comfy-Org/comfy-cla/commit/3adf499acb8367163426b043838d5796edd437cb) Fail CLA allowlist build when GitHub API fails ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/cla.yml` (+6 -3) </details> ### 📄 Description ## Summary - capture the pull request commit API response before processing the author list - fail the allowlist step explicitly when `gh api` fails - preserve the valid author-only case where filtering produces no co-authors ## Verification - parsed the workflow as YAML - checked the embedded Bash syntax - exercised co-author, author-only, and simulated API-failure scenarios - ran `git diff --check` Closes Comfy-Org/ComfyUI_frontend#15555 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:40:20 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/comfy-cla#1
No description provided.