Comfy-Org/comfy-complete
1
0
Fork 0
mirror of https://github.com/Comfy-Org/comfy-complete.git synced 2026-11-04 23:37:26 +00:00
Code Issues 3 Projects Packages Wiki Activity

[PR #2] feat: add repo guardrails (CODEOWNERS, branch ruleset) #2

New issue
Open
opened 2026-10-26 22:27:42 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 22:27:42 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-complete/pull/2
Author: @deepme987
Created: 3/27/2026
Status: 🔄 Open

Base: main ← Head: setup/guardrails

📝 Commits (3)

  • 56afae6 feat: add CODEOWNERS and update admin setup guide
  • 3a8159c feat: add author skills (build/validate/submit) and custom node updater
  • 48b7563 feat: add CPU CI container for frontend E2E testing

📊 Changes

9 files changed (+1604 additions, -46 deletions)

View changed files

➕ .claude/agents/custom-node-updater.md (+435 -0)
➕ .claude/skills/build-node/SKILL.md (+306 -0)
➕ .claude/skills/submit-node/SKILL.md (+310 -0)
➕ .claude/skills/validate-node/SKILL.md (+206 -0)
➕ .github/workflows/build-ci-container.yml (+115 -0)
➕ .github/workflows/custom-node-updater.yml (+53 -0)
➕ CODEOWNERS (+22 -0)
➕ docker/Dockerfile.ci (+82 -0)
📝 docs/admin-setup.md (+75 -46)

📄 Description

Summary

  • Add CODEOWNERS file: @Comfy-Org/comfy-cloud-team owns all files, @deepme987 @bigcat88 own supported_nodes.yaml, LLM config excluded
  • Update docs/admin-setup.md marking applied guardrails and remaining manual steps

Already active (applied via API)

  • Repo settings: squash-only merge, delete branch on merge
  • Ruleset ProtectMain (ID 14420755): 1 approval + code owner review + required checks + stale review dismissal + linear history
  • Team access: comfy-cloud-team granted write

Still needs manual action

  • ANTHROPIC_API_KEY secret (AI review agent)
  • CLOUD_REPO_PAT secret (cross-repo ephemeral dispatch)

Test plan

  • This PR validates the ruleset — should require approval and passing checks
  • Verify CODEOWNERS triggers review request from comfy-cloud-team
  • After merge, verify direct push to main is blocked

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-complete/pull/2 **Author:** [@deepme987](https://github.com/deepme987) **Created:** 3/27/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `setup/guardrails` --- ### 📝 Commits (3) - [`56afae6`](https://github.com/Comfy-Org/comfy-complete/commit/56afae6368f33dbd5a931909f49ee578afc1d71e) feat: add CODEOWNERS and update admin setup guide - [`3a8159c`](https://github.com/Comfy-Org/comfy-complete/commit/3a8159c708cba6ad10208e47fe2aff3e10478e94) feat: add author skills (build/validate/submit) and custom node updater - [`48b7563`](https://github.com/Comfy-Org/comfy-complete/commit/48b7563d690878b49e8c2729c8c34e159ee2e935) feat: add CPU CI container for frontend E2E testing ### 📊 Changes **9 files changed** (+1604 additions, -46 deletions) <details> <summary>View changed files</summary> ➕ `.claude/agents/custom-node-updater.md` (+435 -0) ➕ `.claude/skills/build-node/SKILL.md` (+306 -0) ➕ `.claude/skills/submit-node/SKILL.md` (+310 -0) ➕ `.claude/skills/validate-node/SKILL.md` (+206 -0) ➕ `.github/workflows/build-ci-container.yml` (+115 -0) ➕ `.github/workflows/custom-node-updater.yml` (+53 -0) ➕ `CODEOWNERS` (+22 -0) ➕ `docker/Dockerfile.ci` (+82 -0) 📝 `docs/admin-setup.md` (+75 -46) </details> ### 📄 Description ## Summary - Add CODEOWNERS file: `@Comfy-Org/comfy-cloud-team` owns all files, `@deepme987 @bigcat88` own `supported_nodes.yaml`, LLM config excluded - Update `docs/admin-setup.md` marking applied guardrails and remaining manual steps ## Already active (applied via API) - Repo settings: squash-only merge, delete branch on merge - Ruleset `ProtectMain` (ID 14420755): 1 approval + code owner review + required checks + stale review dismissal + linear history - Team access: `comfy-cloud-team` granted write ## Still needs manual action - `ANTHROPIC_API_KEY` secret (AI review agent) - `CLOUD_REPO_PAT` secret (cross-repo ephemeral dispatch) ## Test plan - [ ] This PR validates the ruleset — should require approval and passing checks - [ ] Verify CODEOWNERS triggers review request from comfy-cloud-team - [ ] After merge, verify direct push to main is blocked 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
matt/be-3569-promote-claude-md-to-agents-md
chore/node-runtime-refresh-2026-09-28
setup/guardrails
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/comfy-complete#2
No description provided.