[PR #3] [CLOSED] feat: adopt cloud's authoritative content as canonical source #4

New issue

Closed

opened 2026-10-26 22:27:42 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:27:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-complete/pull/3
Author: @deepme987
Created: 5/13/2026
Status: ❌ Closed

Base: main ← Head: deepme987/comfy-complete/migration-premortem

📝 Commits (3)

a694ddd feat: adopt cloud's authoritative content as canonical source
bbe3f54 chore: bump comfyui v0.21.1 + workflow_templates 0.9.75
ac4662a test: align label-count assertions with current production set

📊 Changes

8 files changed (+385 additions, -722 deletions)

View changed files

📝 .github/workflows/notify-cloud.yml (+3 -2)
📝 README.md (+24 -3)
📝 config.yaml.example (+9 -10)
📝 docker/Dockerfile.cloudbuild (+111 -172)
📝 requirements.txt (+7 -5)
📝 supported_nodes.yaml (+204 -516)
📝 tests/test_resolve_disabled_nodes.py (+18 -9)
📝 version_lock.yaml (+9 -5)

📄 Description

Summary

Promotes external Comfy-Org/comfy-complete to canonical source for the ComfyComplete distribution. Replaces the drifted March snapshot with cloud's current production state.

This is the external half of a two-PR migration. The cloud-side PR (https://github.com/Comfy-Org/cloud/pull/) deletes cloud's comfy-complete/ subdir and switches to clone-at-build-time consumption against this repo.

Changes

File	Change
`supported_nodes.yaml`	Replaced with cloud's content (87 packs, current pin set, current label config)
`requirements.txt`	Replaced with cloud's content (308 pinned pip deps including security-blocked node removals through May)
`version_lock.yaml`	Replaced with cloud's content (ComfyUI v0.21.0, frontend 1.43.18, workflow_templates 0.9.73); removed the "future external pin" comment block that no longer applies on this side
`scripts/install_custom_nodes.py`	Replaced with cloud's hardened version (`--no-deps` default, sys.path handling, comfy-cli >=1.5.1)
`gpu_import_allowlist.txt`	Replaced with cloud's current allowlist
`docker/Dockerfile.cloudbuild`	Replaced with cloud's cc-base Dockerfile layer-order tuning; COPY paths fixed to be relative to repo root (this Dockerfile becomes the canonical cc-base build recipe)
`README.md`	Reflects canonical-source role; explicit "submissions not guaranteed" framing; "build it yourself" section
`.github/workflows/notify-cloud.yml`	Comment updated (workflow itself is fine: dispatches commit SHA to cloud's new comfy-complete-sync workflow which bumps `comfy_complete_version.yaml`)

Architecture (cloud-side consumption)

Comfy-Org/comfy-complete (this repo)
   │
   │  push to main
   │  └─► notify-cloud.yml dispatches `comfy-complete-updated` event
   │
   ▼
Comfy-Org/cloud (companion PR)
   │
   │  comfy-complete-sync.yml receives dispatch
   │  └─► opens draft PR bumping `comfy_complete_version.yaml.ref`
   │
   ▼  When that PR merges, inference cloudbuild's cc-resolve:
      1. Clones this repo at the pinned ref into /workspace/comfy-complete
      2. Content-hashes the cloned files + Dockerfile.cloudbuild
      3. Looks up :hash-X in Artifact Registry; HIT reuses, MISS builds from the clone

Path-1 (pre-built artifact pin via image+digest in cloud's pin file) is also wired but unused — forward-looking hook for when/if we decide to publish pre-built artifacts.

Drift discussion

External had a March 26 snapshot that drifted from cloud's tracked subdir on both sides. Per Deep's call (see decisions.md in the analysis worktree), we don't preserve external's drift — cloud is authoritative for what's currently in production, and external evolves forward from this commit. The earlier OSS scaffolding in this repo (LICENSE, CONTRIBUTING.md, CLAUDE.md, DECISIONS.md, docs/, scripts/add-node/, scripts/pr-review/, .github/workflows/ci.yml + custom-node-review.yml + ephemeral-test.yml) is preserved.

Test plan

docker build -f docker/Dockerfile.cloudbuild . succeeds (locally validated via docker buildx build --check; no syntax warnings)
pytest tests/ passes (existing CI)
After cloud-side PR merges + cloud's first cc-resolve runs against this branch's head: cc-base image lands in cloud's Artifact Registry
After merging: notify-cloud.yml dispatches successfully, cloud's comfy-complete-sync.yml opens a draft PR bumping the ref

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-complete/pull/3 **Author:** [@deepme987](https://github.com/deepme987) **Created:** 5/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `deepme987/comfy-complete/migration-premortem` --- ### 📝 Commits (3) - [`a694ddd`](https://github.com/Comfy-Org/comfy-complete/commit/a694dddbe8363d18de2e31a978f77717e4685657) feat: adopt cloud's authoritative content as canonical source - [`bbe3f54`](https://github.com/Comfy-Org/comfy-complete/commit/bbe3f54dd253cd9ed3f843733158429219dbb6d0) chore: bump comfyui v0.21.1 + workflow_templates 0.9.75 - [`ac4662a`](https://github.com/Comfy-Org/comfy-complete/commit/ac4662a8c880281e22690262fa694c1c9d7fb677) test: align label-count assertions with current production set ### 📊 Changes **8 files changed** (+385 additions, -722 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/notify-cloud.yml` (+3 -2) 📝 `README.md` (+24 -3) 📝 `config.yaml.example` (+9 -10) 📝 `docker/Dockerfile.cloudbuild` (+111 -172) 📝 `requirements.txt` (+7 -5) 📝 `supported_nodes.yaml` (+204 -516) 📝 `tests/test_resolve_disabled_nodes.py` (+18 -9) 📝 `version_lock.yaml` (+9 -5) </details> ### 📄 Description ## Summary Promotes external `Comfy-Org/comfy-complete` to canonical source for the ComfyComplete distribution. Replaces the drifted March snapshot with cloud's current production state. This is the **external half** of a two-PR migration. The cloud-side PR (https://github.com/Comfy-Org/cloud/pull/<TBD>) deletes cloud's `comfy-complete/` subdir and switches to clone-at-build-time consumption against this repo. ## Changes | File | Change | |------|--------| | `supported_nodes.yaml` | Replaced with cloud's content (87 packs, current pin set, current label config) | | `requirements.txt` | Replaced with cloud's content (308 pinned pip deps including security-blocked node removals through May) | | `version_lock.yaml` | Replaced with cloud's content (ComfyUI v0.21.0, frontend 1.43.18, workflow_templates 0.9.73); removed the "future external pin" comment block that no longer applies on this side | | `scripts/install_custom_nodes.py` | Replaced with cloud's hardened version (`--no-deps` default, sys.path handling, comfy-cli >=1.5.1) | | `gpu_import_allowlist.txt` | Replaced with cloud's current allowlist | | `docker/Dockerfile.cloudbuild` | Replaced with cloud's cc-base Dockerfile layer-order tuning; COPY paths fixed to be relative to repo root (this Dockerfile becomes the canonical cc-base build recipe) | | `README.md` | Reflects canonical-source role; explicit "submissions not guaranteed" framing; "build it yourself" section | | `.github/workflows/notify-cloud.yml` | Comment updated (workflow itself is fine: dispatches commit SHA to cloud's new comfy-complete-sync workflow which bumps `comfy_complete_version.yaml`) | ## Architecture (cloud-side consumption) ``` Comfy-Org/comfy-complete (this repo) │ │ push to main │ └─► notify-cloud.yml dispatches `comfy-complete-updated` event │ ▼ Comfy-Org/cloud (companion PR) │ │ comfy-complete-sync.yml receives dispatch │ └─► opens draft PR bumping `comfy_complete_version.yaml.ref` │ ▼ When that PR merges, inference cloudbuild's cc-resolve: 1. Clones this repo at the pinned ref into /workspace/comfy-complete 2. Content-hashes the cloned files + Dockerfile.cloudbuild 3. Looks up :hash-X in Artifact Registry; HIT reuses, MISS builds from the clone ``` Path-1 (pre-built artifact pin via `image`+`digest` in cloud's pin file) is also wired but unused — forward-looking hook for when/if we decide to publish pre-built artifacts. ## Drift discussion External had a March 26 snapshot that drifted from cloud's tracked subdir on both sides. Per Deep's call (see decisions.md in the analysis worktree), we don't preserve external's drift — cloud is authoritative for what's currently in production, and external evolves forward from this commit. The earlier OSS scaffolding in this repo (LICENSE, CONTRIBUTING.md, CLAUDE.md, DECISIONS.md, docs/, scripts/add-node/, scripts/pr-review/, .github/workflows/ci.yml + custom-node-review.yml + ephemeral-test.yml) is preserved. ## Test plan - [ ] `docker build -f docker/Dockerfile.cloudbuild .` succeeds (locally validated via `docker buildx build --check`; no syntax warnings) - [ ] `pytest tests/` passes (existing CI) - [ ] After cloud-side PR merges + cloud's first cc-resolve runs against this branch's head: cc-base image lands in cloud's Artifact Registry - [ ] After merging: `notify-cloud.yml` dispatches successfully, cloud's `comfy-complete-sync.yml` opens a draft PR bumping the ref --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:27:42 +00:00