Comfy-Org/comfy-complete
1
0
Fork 0
mirror of https://github.com/Comfy-Org/comfy-complete.git synced 2026-11-04 23:37:26 +00:00
Code Issues 3 Projects Packages Wiki Activity

[PR #4] [MERGED] feat: adopt comfy-complete content + phase-1 transparency framing #6

New issue
Closed
opened 2026-10-26 22:27:43 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 22:27:43 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-complete/pull/4
Author: @deepme987
Created: 5/18/2026
Status: ✅ Merged
Merged: 5/18/2026
Merged by: @deepme987

Base: main ← Head: deepme987/comfy-complete/migration-premortem

📝 Commits (10+)

  • 56afae6 feat: add CODEOWNERS and update admin setup guide
  • 3a8159c feat: add author skills (build/validate/submit) and custom node updater
  • 48b7563 feat: add CPU CI container for frontend E2E testing
  • a694ddd feat: adopt cloud's authoritative content as canonical source
  • bbe3f54 chore: bump comfyui v0.21.1 + workflow_templates 0.9.75
  • ac4662a test: align label-count assertions with current production set
  • 2df7fc5 feat: incorporate author skill chain (build-node, validate-node, submit-node) + CODEOWNERS
  • d2ae2b5 docs(submit-node): add selective-funnel framing
  • baef44e feat(workflows): port automation from cloud (no-follow-up migration)
  • a13647c feat(workflows): auto-merge bump-comfyui-on-tag + sync-core-ref PRs

📊 Changes

20 files changed (+1768 additions, -1370 deletions)

View changed files

➕ .claude/agents/custom-node-updater.md (+435 -0)
📝 .github/PULL_REQUEST_TEMPLATE.md (+3 -12)
➕ .github/workflows/build-ci-container.yml (+115 -0)
➕ .github/workflows/bump-comfyui-on-tag.yml (+239 -0)
➕ .github/workflows/custom-node-updater.yml (+53 -0)
📝 .github/workflows/notify-cloud.yml (+3 -2)
➕ .github/workflows/sync-core-ref.yml (+160 -0)
➕ CODEOWNERS (+22 -0)
➖ CONTRIBUTING.md (+0 -116)
📝 README.md (+103 -169)
📝 config.yaml.example (+9 -10)
➕ docker/Dockerfile.ci (+82 -0)
📝 docker/Dockerfile.cloudbuild (+111 -172)
➖ docs/adding-custom-nodes.md (+0 -308)
📝 docs/admin-setup.md (+75 -46)
📝 requirements.txt (+7 -5)
➕ scripts/comfyui_pins.py (+120 -0)
📝 supported_nodes.yaml (+204 -516)
📝 tests/test_resolve_disabled_nodes.py (+18 -9)
📝 version_lock.yaml (+9 -5)

📄 Description

Replaces the initial scaffold (071e55e) with the canonical comfy-complete content the Cloud team has been iterating on at deepme987/comfy-complete. This is the content cloud's comfy_complete_version.yaml will pin to once the cloud-side migration PR (Comfy-Org/cloud#3679) merges.

What's here

  • ComfyUI + frontend + workflow_templates pins (version_lock.yaml)
  • Pinned Python deps (requirements.txt)
  • Curated custom node packs with permission labels (supported_nodes.yaml)
  • Reproducible Dockerfile (docker/Dockerfile.cloudbuild) producing cc-base
  • CI workflows for pin validation, custom-node review, ephemeral testing, etc.
  • Ported automation from cloud: bump-comfyui-on-tag.yml, sync-core-ref.yml, notify-cloud.yml, custom-node-updater.yml

What's NOT here (phase-1 transparency framing)

The very last commit (43d47a0) drops external-author surfaces — CONTRIBUTING.md, docs/adding-custom-nodes.md, the submit-node/build-node/validate-node Claude skills, and reworks README.md to lead with "this is what cloud runs, public for transparency" rather than "submit your node here".

We're still the only consumers in phase 1. External contributions come later.

How this gets used

Cloud's services/inference/cloudbuild*.yaml runs a cc-clone step that clones Comfy-Org/comfy-complete at the ref pinned in cloud's comfy_complete_version.yaml, then cc-resolve content-hashes the cloned files to decide if cc-base needs rebuilding.

Update flow:

  1. ComfyUI tags a release → dispatches to this repo
  2. bump-comfyui-on-tag.yml opens an auto-merge PR (after this repo's CI passes)
  3. Merge fires notify-cloud.yml → dispatches to cloud
  4. Cloud opens a pin-bump PR (human-reviewed before merge, by design)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-complete/pull/4 **Author:** [@deepme987](https://github.com/deepme987) **Created:** 5/18/2026 **Status:** ✅ Merged **Merged:** 5/18/2026 **Merged by:** [@deepme987](https://github.com/deepme987) **Base:** `main` ← **Head:** `deepme987/comfy-complete/migration-premortem` --- ### 📝 Commits (10+) - [`56afae6`](https://github.com/Comfy-Org/comfy-complete/commit/56afae6368f33dbd5a931909f49ee578afc1d71e) feat: add CODEOWNERS and update admin setup guide - [`3a8159c`](https://github.com/Comfy-Org/comfy-complete/commit/3a8159c708cba6ad10208e47fe2aff3e10478e94) feat: add author skills (build/validate/submit) and custom node updater - [`48b7563`](https://github.com/Comfy-Org/comfy-complete/commit/48b7563d690878b49e8c2729c8c34e159ee2e935) feat: add CPU CI container for frontend E2E testing - [`a694ddd`](https://github.com/Comfy-Org/comfy-complete/commit/a694dddbe8363d18de2e31a978f77717e4685657) feat: adopt cloud's authoritative content as canonical source - [`bbe3f54`](https://github.com/Comfy-Org/comfy-complete/commit/bbe3f54dd253cd9ed3f843733158429219dbb6d0) chore: bump comfyui v0.21.1 + workflow_templates 0.9.75 - [`ac4662a`](https://github.com/Comfy-Org/comfy-complete/commit/ac4662a8c880281e22690262fa694c1c9d7fb677) test: align label-count assertions with current production set - [`2df7fc5`](https://github.com/Comfy-Org/comfy-complete/commit/2df7fc58c3993d070e1b6a567a61f6b6f197d9ec) feat: incorporate author skill chain (build-node, validate-node, submit-node) + CODEOWNERS - [`d2ae2b5`](https://github.com/Comfy-Org/comfy-complete/commit/d2ae2b540157a9f1bb64323aad0f38de185683d2) docs(submit-node): add selective-funnel framing - [`baef44e`](https://github.com/Comfy-Org/comfy-complete/commit/baef44e774ef0e33efec4b848a39df99fae74d1f) feat(workflows): port automation from cloud (no-follow-up migration) - [`a13647c`](https://github.com/Comfy-Org/comfy-complete/commit/a13647c6cf3a441ea2650b69c7a91235b91ea4fe) feat(workflows): auto-merge bump-comfyui-on-tag + sync-core-ref PRs ### 📊 Changes **20 files changed** (+1768 additions, -1370 deletions) <details> <summary>View changed files</summary> ➕ `.claude/agents/custom-node-updater.md` (+435 -0) 📝 `.github/PULL_REQUEST_TEMPLATE.md` (+3 -12) ➕ `.github/workflows/build-ci-container.yml` (+115 -0) ➕ `.github/workflows/bump-comfyui-on-tag.yml` (+239 -0) ➕ `.github/workflows/custom-node-updater.yml` (+53 -0) 📝 `.github/workflows/notify-cloud.yml` (+3 -2) ➕ `.github/workflows/sync-core-ref.yml` (+160 -0) ➕ `CODEOWNERS` (+22 -0) ➖ `CONTRIBUTING.md` (+0 -116) 📝 `README.md` (+103 -169) 📝 `config.yaml.example` (+9 -10) ➕ `docker/Dockerfile.ci` (+82 -0) 📝 `docker/Dockerfile.cloudbuild` (+111 -172) ➖ `docs/adding-custom-nodes.md` (+0 -308) 📝 `docs/admin-setup.md` (+75 -46) 📝 `requirements.txt` (+7 -5) ➕ `scripts/comfyui_pins.py` (+120 -0) 📝 `supported_nodes.yaml` (+204 -516) 📝 `tests/test_resolve_disabled_nodes.py` (+18 -9) 📝 `version_lock.yaml` (+9 -5) </details> ### 📄 Description Replaces the initial scaffold (071e55e) with the canonical comfy-complete content the Cloud team has been iterating on at deepme987/comfy-complete. This is the content cloud's `comfy_complete_version.yaml` will pin to once the cloud-side migration PR (Comfy-Org/cloud#3679) merges. ## What's here - ComfyUI + frontend + workflow_templates pins (`version_lock.yaml`) - Pinned Python deps (`requirements.txt`) - Curated custom node packs with permission labels (`supported_nodes.yaml`) - Reproducible Dockerfile (`docker/Dockerfile.cloudbuild`) producing cc-base - CI workflows for pin validation, custom-node review, ephemeral testing, etc. - Ported automation from cloud: `bump-comfyui-on-tag.yml`, `sync-core-ref.yml`, `notify-cloud.yml`, `custom-node-updater.yml` ## What's NOT here (phase-1 transparency framing) The very last commit (43d47a0) drops external-author surfaces — `CONTRIBUTING.md`, `docs/adding-custom-nodes.md`, the `submit-node`/`build-node`/`validate-node` Claude skills, and reworks README.md to lead with *"this is what cloud runs, public for transparency"* rather than *"submit your node here"*. We're still the only consumers in phase 1. External contributions come later. ## How this gets used Cloud's `services/inference/cloudbuild*.yaml` runs a `cc-clone` step that clones `Comfy-Org/comfy-complete` at the ref pinned in cloud's `comfy_complete_version.yaml`, then `cc-resolve` content-hashes the cloned files to decide if cc-base needs rebuilding. Update flow: 1. ComfyUI tags a release → dispatches to this repo 2. `bump-comfyui-on-tag.yml` opens an auto-merge PR (after this repo's CI passes) 3. Merge fires `notify-cloud.yml` → dispatches to cloud 4. Cloud opens a pin-bump PR (human-reviewed before merge, by design) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:27:43 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
matt/be-3569-promote-claude-md-to-agents-md
chore/node-runtime-refresh-2026-09-28
setup/guardrails
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/comfy-complete#6
No description provided.