[PR #187] Fix triton rms_rope grid overflow for sequences of 65536 or more #206

New issue

Open

opened 2026-10-26 22:21:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:21:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-kitchen/pull/187
Author: @arcusbuilds
Created: 9/19/2026
Status: 🔄 Open

Base: main ← Head: fix/triton-rms-rope-grid-limit

📝 Commits (1)

f9f11c8 Fix triton rms_rope grid overflow for sequences of 65536 or more

📊 Changes

2 files changed (+32 additions, -3 deletions)

View changed files

📝 comfy_kitchen/backends/triton/rms_rope.py (+4 -3)
📝 tests/test_rms_rope.py (+28 -0)

📄 Description

Fixes #169. Moves the Triton sequence dimension to grid axis 0 and adds a regression test.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-kitchen/pull/187 **Author:** [@arcusbuilds](https://github.com/arcusbuilds) **Created:** 9/19/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/triton-rms-rope-grid-limit` --- ### 📝 Commits (1) - [`f9f11c8`](https://github.com/Comfy-Org/comfy-kitchen/commit/f9f11c8e3d1274d742541995080de3bb442394aa) Fix triton rms_rope grid overflow for sequences of 65536 or more ### 📊 Changes **2 files changed** (+32 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `comfy_kitchen/backends/triton/rms_rope.py` (+4 -3) 📝 `tests/test_rms_rope.py` (+28 -0) </details> ### 📄 Description Fixes #169. Moves the Triton sequence dimension to grid axis 0 and adds a regression test. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-26 22:21:35 +00:00

bsakaguchi referenced this issue

2026-10-26 22:21:45 +00:00

[PR #206] [HIP] Integrate iGPU Optimizations (gfx1035 + gfx1103) #225