mirror of
https://github.com/Comfy-Org/comfy-model-tools.git
synced 2026-11-04 23:37:31 +00:00
[PR #3] [MERGED] Add int8 ConvRot and full-block quantization to the SeedVR2 converter #1
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/comfy-model-tools#1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Comfy-Org/comfy-model-tools/pull/3
Author: @pollockjj
Created: 7/2/2026
Status: ✅ Merged
Merged: 7/2/2026
Merged by: @pollockjj
Base:
main← Head:seedvr2-full-block-quantization📝 Commits (1)
c488de5Add int8 ConvRot and full-block quantization to the SeedVR2 converter📊 Changes
2 files changed (+115 additions, -57 deletions)
View changed files
📝
README.md(+2 -2)📝
seedvr2_convert.py(+113 -55)📄 Description
Summary
Adds an int8 ConvRot precision to the SeedVR2 converter, removes the last-DiT-block fp16 exemption from the nvfp4 and mxfp8 paths, and removes the fp8_e4m3fn_mixed_block35_fp16 mode entirely, so every quantized format quantizes all eligible blocks.
The exemption and the mixed fp8 mode dated from early fp8 line and tile artifacts on 7B. Re-measured on the current ComfyUI SeedVR2 runtime (RTX 5090, three-video pooled PSNR over 291 frames against canonical references), full-block conversions land within 0.03 dB of the mixed variants for every format and above them for mxfp8 and fp8, with no per-frame artifact signature, while the fp16 tail block costs real sampler time: 43.6 s to 39.4 s for mxfp8 and 37.2 s to 36.5 s for nvfp4 on a 109-frame single-step latent.
Changes
Single file, seedvr2_convert.py.
The fp16 and fp8_e4m3fn job paths are untouched and produce identical bytes; nvfp4 and mxfp8 produce different bytes than the current script; int8 is new.
Example
Expected output:
The sha suffix on the job makes the run self-verifying against the published artifact.
Prior art
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.