[PR #189] chore: require @guill approval for public workflow API changes #189

New issue

Open

opened 2026-10-31 22:02:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:02:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-python-sdk/pull/189
Author: @guill
Created: 9/24/2026
Status: 🔄 Open

Base: main ← Head: js/codeowners

📝 Commits (2)

5c425b8 Add CODEOWNERS for public API
d8fd756 Update documentation

📊 Changes

2 files changed (+23 additions, -3 deletions)

View changed files

📝 .github/CODEOWNERS (+22 -3)
📝 CONTRIBUTING.md (+1 -0)

📄 Description

Adds @guill as the required code owner for the files that make up the SDK's public API outside the models (Comfy Router) API: the non-Router modules under src/comfy_sdk/, plus spec/openapi.yaml.

Everything else, including the Router surface and any file added in the future, keeps the existing default of @Comfy-Org/comfy-cloud-team @Comfy-Org/core-engine-team. That means new Router files can still land without @guill's review.

This is a .github/CODEOWNERS change only.

Summary by CodeRabbit

Chores
- Updated code ownership assignments for selected API specification and SDK files. All other files remain under the existing default ownership rule.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-python-sdk/pull/189 **Author:** [@guill](https://github.com/guill) **Created:** 9/24/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `js/codeowners` --- ### 📝 Commits (2) - [`5c425b8`](https://github.com/Comfy-Org/comfy-python-sdk/commit/5c425b8869a9858865ea889c4045f98b782e0357) Add CODEOWNERS for public API - [`d8fd756`](https://github.com/Comfy-Org/comfy-python-sdk/commit/d8fd756fc2866310fb8689ab80f619a755d2bbac) Update documentation ### 📊 Changes **2 files changed** (+23 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/CODEOWNERS` (+22 -3) 📝 `CONTRIBUTING.md` (+1 -0) </details> ### 📄 Description Adds @guill as the required code owner for the files that make up the SDK's public API outside the models (Comfy Router) API: the non-Router modules under `src/comfy_sdk/`, plus `spec/openapi.yaml`. Everything else, including the Router surface and any file added in the future, keeps the existing default of `@Comfy-Org/comfy-cloud-team @Comfy-Org/core-engine-team`. That means new Router files can still land without @guill's review. This is a `.github/CODEOWNERS` change only.  ## Summary by CodeRabbit * **Chores** * Updated code ownership assignments for selected API specification and SDK files. All other files remain under the existing default ownership rule.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-31 22:02:11 +00:00