[PR #3] [CLOSED] feat(serialization): add VIDEO encode + VIDEO_MP4_BASE64 capability #2

New issue

Closed

opened 2026-10-26 22:28:49 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:28:49 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-remote-nodes/pull/3
Author: @Kosinkadink
Created: 5/13/2026
Status: ❌ Closed

Base: feat/audio-capabilities ← Head: feat/video-input-capability

📝 Commits (1)

8a9955b feat(serialization): add VIDEO encode + VIDEO_MP4_BASE64 capability

📊 Changes

4 files changed (+61 additions, -1 deletions)

View changed files

📝 client.py (+1 -0)
📝 protocol.py (+1 -0)
📝 proxy_node.py (+2 -0)
📝 serialization.py (+57 -1)

📄 Description

Stacks on top of #2.

Mirrors the AUDIO sweep: adds encode_video_input / is_video_input helpers in serialization.py, wires them into proxy_node._encode_one, and advertises VIDEO_MP4_BASE64 in CLIENT_CAPABILITIES so servers can require it for VIDEO inputs.

encode_video_input re-encodes through video.save_to(buf, MP4, H264) to normalize the container — Bria's video endpoints (the first vendor with VIDEO inputs) only accept mp4_h264. Populates an optional duration_s extra from get_duration() so servers can pre-validate against duration bounds without demuxing.

Paired with comfy-rnp-server PR for BriaRemoveVideoBackground.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-remote-nodes/pull/3 **Author:** [@Kosinkadink](https://github.com/Kosinkadink) **Created:** 5/13/2026 **Status:** ❌ Closed **Base:** `feat/audio-capabilities` ← **Head:** `feat/video-input-capability` --- ### 📝 Commits (1) - [`8a9955b`](https://github.com/Comfy-Org/comfy-remote-nodes/commit/8a9955be721aa22a43e2a1182f7f4dcd7db24430) feat(serialization): add VIDEO encode + VIDEO_MP4_BASE64 capability ### 📊 Changes **4 files changed** (+61 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `client.py` (+1 -0) 📝 `protocol.py` (+1 -0) 📝 `proxy_node.py` (+2 -0) 📝 `serialization.py` (+57 -1) </details> ### 📄 Description Stacks on top of #2. Mirrors the AUDIO sweep: adds `encode_video_input` / `is_video_input` helpers in `serialization.py`, wires them into `proxy_node._encode_one`, and advertises `VIDEO_MP4_BASE64` in `CLIENT_CAPABILITIES` so servers can require it for VIDEO inputs. `encode_video_input` re-encodes through `video.save_to(buf, MP4, H264)` to normalize the container — Bria's video endpoints (the first vendor with VIDEO inputs) only accept `mp4_h264`. Populates an optional `duration_s` extra from `get_duration()` so servers can pre-validate against duration bounds without demuxing. Paired with comfy-rnp-server PR for `BriaRemoveVideoBackground`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:28:49 +00:00