Comfy-Org/comfy-skills

Fork 0

mirror of https://github.com/Comfy-Org/comfy-skills.git synced 2026-11-04 23:37:45 +00:00

[PR #18] [MERGED] fix(generate-video): MiniMax H3 IS reachable via partner_generate #17

New issue

Closed

opened 2026-10-26 22:34:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:34:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-skills/pull/18
Author: @mattmillerai
Created: 8/20/2026
Status: ✅ Merged
Merged: 8/20/2026
Merged by: @mattmillerai

Base: main ← Head: fix/minimax-partner-generate-reachable

📝 Commits (1)

9cc4256 fix(generate-video): MiniMax H3 IS reachable via partner_generate

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 skills/comfy-generate-video.md (+1 -1)

📄 Description

Summary

One sentence in the "Model notes: MiniMax H3" bullet of skills/comfy-generate-video.md tells agents:

MiniMax is not reachable through partner_generate at all: it registers no MiniMax model id, so every slug you try comes back "unknown model".

That has been false since 2026-08-12, six days before #17 merged. Comfy-Org/comfy-cloud-mcp-server commit ee004af1 ("feat(partner): register minimax v2 + bfl flux-3 video models", BE-7336) registered minimax/hailuo-03-t2v as a video model. #17 corrected the Hailuo-02-vs-H3 half of this bullet and left this sentence behind.

Verification

Run in-process against comfy-cloud-mcp-server main — read/validation paths only, no dispatch, no credits:

Probe	Result
`ALL_MODELS` keys matching `/minimax\|hailuo/i`	`minimax/hailuo-03-t2v` — 1 of 22 entries, `type: video`, `apiNodeType: MinimaxHailuo03TextToVideoNode`
`partnerModelsAsEnriched()` (what `search_models({source:"partner"})` serves)	`['minimax/hailuo-03-t2v']`
`partnerUnknownModelMessage('minimax/hailuo-03', 'video')`	`unknown model "minimax/hailuo-03". Did you mean: minimax/hailuo-03-t2v?`
`data/templates.json`	`api_minimax_h3_{t2v,r2v,flf2v}` + OSS `video_minimax_h3_{t2v,i2v,r2v}` — note there is no `api_minimax_h3_i2v`

So the guide denied a capability on the same turn the server's own unknown-model bounce pointed an agent at that capability — and the MCP server's system prompt separately says "never refuse because a provider 'isn't wired up' without first checking partner_generate".

The replacement

As of 2026-08, `partner_generate` DOES serve H3 text-to-video: pass `type: "video"` with the
slug `minimax/hailuo-03-t2v`. That is the only registered MiniMax slug, so the other paid H3
shapes go through `run_template` instead — `api_minimax_h3_r2v` (reference-to-video) and
`api_minimax_h3_flf2v` (first/last frame). Confirm the live set with
`search_models({ source: "partner", q: "minimax" })` rather than trusting this list; if a slug
is refused, the "unknown model" bounce names the closest real one.

It keeps the run_template redirect for the shapes that genuinely have no slug, names them specifically instead of the api_minimax_h3_* glob, and points the reader at search_models rather than at a hardcoded list — so the next registry change degrades to a stale-but-hedged note instead of a false denial.

Why this is blocking downstream

comfy-cloud-mcp-server mirrors this file into data/skills.json daily and runs a lint (src/guide-negative-claims.test.ts, BE-4787) whose whole job is to refuse a shipped sentence that says a capability is absent unless something proves it. This sentence cannot be waived (it is false) or asserted (no check passes), so it has kept the daily refresh PR red:

Comfy-Org/comfy-cloud-mcp-server#1232 — daily refresh, open + red
Comfy-Org/comfy-cloud-mcp-server#1235 — the escalation vehicle, draft, deliberately red on this one claim

Once this merges and the refresh regenerates, the only remaining edit there is one inventory row for the corrected sentence.

Refs BE-6922, BE-7336.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-skills/pull/18 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 8/20/2026 **Status:** ✅ Merged **Merged:** 8/20/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `fix/minimax-partner-generate-reachable` --- ### 📝 Commits (1) - [`9cc4256`](https://github.com/Comfy-Org/comfy-skills/commit/9cc425628ff67e2d62300b68472f3c119e6d9967) fix(generate-video): MiniMax H3 IS reachable via partner_generate ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `skills/comfy-generate-video.md` (+1 -1) </details> ### 📄 Description ## Summary One sentence in the "Model notes: MiniMax H3" bullet of `skills/comfy-generate-video.md` tells agents: > MiniMax is not reachable through `partner_generate` at all: it registers no MiniMax model id, so every slug you try comes back "unknown model". That has been **false since 2026-08-12**, six days before #17 merged. `Comfy-Org/comfy-cloud-mcp-server` commit `ee004af1` ("feat(partner): register minimax v2 + bfl flux-3 video models", BE-7336) registered `minimax/hailuo-03-t2v` as a video model. #17 corrected the *Hailuo-02-vs-H3* half of this bullet and left this sentence behind. ## Verification Run in-process against `comfy-cloud-mcp-server` `main` — read/validation paths only, no dispatch, no credits: | Probe | Result | |---|---| | `ALL_MODELS` keys matching `/minimax\|hailuo/i` | **`minimax/hailuo-03-t2v`** — 1 of 22 entries, `type: video`, `apiNodeType: MinimaxHailuo03TextToVideoNode` | | `partnerModelsAsEnriched()` (what `search_models({source:"partner"})` serves) | `['minimax/hailuo-03-t2v']` | | `partnerUnknownModelMessage('minimax/hailuo-03', 'video')` | `unknown model "minimax/hailuo-03". **Did you mean: minimax/hailuo-03-t2v?**` | | `data/templates.json` | `api_minimax_h3_{t2v,r2v,flf2v}` + OSS `video_minimax_h3_{t2v,i2v,r2v}` — note there is **no** `api_minimax_h3_i2v` | So the guide denied a capability on the same turn the server's own unknown-model bounce pointed an agent *at* that capability — and the MCP server's system prompt separately says *"never refuse because a provider 'isn't wired up' without first checking `partner_generate`"*. ## The replacement ``` As of 2026-08, `partner_generate` DOES serve H3 text-to-video: pass `type: "video"` with the slug `minimax/hailuo-03-t2v`. That is the only registered MiniMax slug, so the other paid H3 shapes go through `run_template` instead — `api_minimax_h3_r2v` (reference-to-video) and `api_minimax_h3_flf2v` (first/last frame). Confirm the live set with `search_models({ source: "partner", q: "minimax" })` rather than trusting this list; if a slug is refused, the "unknown model" bounce names the closest real one. ``` It keeps the `run_template` redirect for the shapes that genuinely have no slug, names them specifically instead of the `api_minimax_h3_*` glob, and points the reader at `search_models` rather than at a hardcoded list — so the next registry change degrades to a stale-but-hedged note instead of a false denial. ## Why this is blocking downstream `comfy-cloud-mcp-server` mirrors this file into `data/skills.json` daily and runs a lint (`src/guide-negative-claims.test.ts`, BE-4787) whose whole job is to refuse a shipped sentence that says a capability is absent unless something proves it. This sentence cannot be waived (it is false) or asserted (no check passes), so it has kept the daily refresh PR red: - Comfy-Org/comfy-cloud-mcp-server#1232 — daily refresh, open + red - Comfy-Org/comfy-cloud-mcp-server#1235 — the escalation vehicle, draft, deliberately red on this one claim Once this merges and the refresh regenerates, the only remaining edit there is one inventory row for the corrected sentence. Refs BE-6922, BE-7336. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:34:00 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfy-skills#17

No description provided.

Rows
Columns