[PR #26] [MERGED] fix(comfy-build): read the failure where it is, check the scanned id, and answer where a model lands #25

New issue

Closed

opened 2026-10-26 22:34:06 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:34:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-skills/pull/26
Author: @james00012
Created: 8/25/2026
Status: ✅ Merged
Merged: 8/25/2026
Merged by: @james00012

Base: main ← Head: james/comfy-build-recovery-scan-and-model-placement

📝 Commits (10+)

4fec6e2 fix(comfy-build): read the failure where it is, and fix what is broken
d6e0a46 fix(comfy-build): check the id, carry the pin you already found, and say what
bf86977 feat(comfy-build): say where a model file has to land, and when a
cdacfe3 fix(comfy-build): say what the scan leaves out of the definition
b2e4167 fix(comfy-build): keep internal architecture out of a public skill
f68c82c fix(comfy-build): say release, key the table on what the builder emits, and
d57c6d1 fix(comfy-build): correct four claims the code does not support
ac5196a fix(comfy-build): give the pin a way to find its version, and name the id
d1fb8c6 fix(comfy-build): six gaps a fresh agent hit on a real install
2e9105d fix(comfy-build): four contradictions a fresh agent could not resolve

📊 Changes

1 file changed (+224 additions, -89 deletions)

View changed files

📝 comfy-cli/comfy-build/SKILL.md (+224 -89)

📄 Description

TL;DR: Correct the comfy-build skill against the shipping CLI and builder, so an agent following it stops abandoning healthy builds, stops reading a field that does not exist, and stops prescribing a fix that breaks the build.

Linear: BE-8971

Why: an agent driven by this file abandoned a build that had named its cause, because the file pointed at failureReason on the release and it lives on the artifact. It was then told to pin numpy down for numpy.core.multiarray failed to import, which breaks ComfyUI core at numpy>=1.25.0.

Validation

Development environment: two real cuts on staging, same build, one variable. Following this file, release 8d8cea97 reached complete with deployable: true first time, on the install that failed at assemble before. Removing the pin this file now tells you to carry into cut one, release d13f43d3 failed with assemble: ComfyUI did not start ... numpy.core.multiarray failed to import on three packs. That is the differential.
Development environment, claims: the preview promised 3 uploads and 383 MiB while the cut reported uploaded: 0; the base-image and policy warnings printed verbatim; the passing pin check printed nothing; building held four minutes, which the previous text told an agent to abandon.
Local stack, end to end: four agents driven by the corrected file alone, which is the evaluation a content change owes. One reached the pre-cut disclosure on the six-pack install, one recovered a failed release, one built from a described result with no install, and one checked every command, flag, field and error string against origin/main in both repos. Twenty-two defects came back and are fixed here.
Not run: Unit and Integration. This repository has no test suite and a skill file has nothing to execute. Prod is also not touched: both cuts were staging.

What changed

[comfy-skills] comfy-build/SKILL.md, failure recovery and polling: reads artifacts[].failureReason and the log's middle, names queued and building as normal rather than stopping on them, and keys the table on strings the builder emits rather than three it never does.
[comfy-skills] comfy-build/SKILL.md, scan, pins and refusals: comfy build release replaces the retired version spelling, a wrong scanned registry id may now be corrected, a conflict the reading names travels into the first cut, and a refusal is described as leaving nothing behind, which is what the CLI does.
[comfy-skills] comfy-build/SKILL.md, models and policy: a new section on which directory a model type names and what a self-fetching pack costs, plus modelPolicy corrected from a restriction to a record.

Contradicts: nothing. The file is public, so it says only what a user observes; four sentences describing internal mechanics were removed rather than bent.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-skills/pull/26 **Author:** [@james00012](https://github.com/james00012) **Created:** 8/25/2026 **Status:** ✅ Merged **Merged:** 8/25/2026 **Merged by:** [@james00012](https://github.com/james00012) **Base:** `main` ← **Head:** `james/comfy-build-recovery-scan-and-model-placement` --- ### 📝 Commits (10+) - [`4fec6e2`](https://github.com/Comfy-Org/comfy-skills/commit/4fec6e27e4936ae361ca590253c5703f3b3cfb61) fix(comfy-build): read the failure where it is, and fix what is broken - [`d6e0a46`](https://github.com/Comfy-Org/comfy-skills/commit/d6e0a46e3f70e16e4b51cff4aceebaef05843034) fix(comfy-build): check the id, carry the pin you already found, and say what - [`bf86977`](https://github.com/Comfy-Org/comfy-skills/commit/bf86977e340b9f652b3f4b516318f438a6bd1e2b) feat(comfy-build): say where a model file has to land, and when a - [`cdacfe3`](https://github.com/Comfy-Org/comfy-skills/commit/cdacfe3509e39f034bfc615dd12cb580c12c8ea8) fix(comfy-build): say what the scan leaves out of the definition - [`b2e4167`](https://github.com/Comfy-Org/comfy-skills/commit/b2e4167f393bb2e562fb7787a1c182f94002b404) fix(comfy-build): keep internal architecture out of a public skill - [`f68c82c`](https://github.com/Comfy-Org/comfy-skills/commit/f68c82cde702f9811c48106d63f94359c7fb301d) fix(comfy-build): say release, key the table on what the builder emits, and - [`d57c6d1`](https://github.com/Comfy-Org/comfy-skills/commit/d57c6d1de8dd197984cc3a65f8473e258578d363) fix(comfy-build): correct four claims the code does not support - [`ac5196a`](https://github.com/Comfy-Org/comfy-skills/commit/ac5196a47e3773942d368925a294349ffe5dc90f) fix(comfy-build): give the pin a way to find its version, and name the id - [`d1fb8c6`](https://github.com/Comfy-Org/comfy-skills/commit/d1fb8c624dc7781e9450709d4e6a80f40ba57684) fix(comfy-build): six gaps a fresh agent hit on a real install - [`2e9105d`](https://github.com/Comfy-Org/comfy-skills/commit/2e9105ddf32b5232d91350b1785ad4f7aceabc39) fix(comfy-build): four contradictions a fresh agent could not resolve ### 📊 Changes **1 file changed** (+224 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `comfy-cli/comfy-build/SKILL.md` (+224 -89) </details> ### 📄 Description **TL;DR:** Correct the comfy-build skill against the shipping CLI and builder, so an agent following it stops abandoning healthy builds, stops reading a field that does not exist, and stops prescribing a fix that breaks the build. Linear: [BE-8971](https://linear.app/comfyorg/issue/BE-8971) **Why:** an agent driven by this file abandoned a build that had named its cause, because the file pointed at `failureReason` on the release and it lives on the artifact. It was then told to pin `numpy` down for `numpy.core.multiarray failed to import`, which breaks ComfyUI core at `numpy>=1.25.0`. **Validation** * **Development environment**: two real cuts on staging, same build, one variable. Following this file, release `8d8cea97` reached `complete` with `deployable: true` first time, on the install that failed at `assemble` before. Removing the pin this file now tells you to carry into cut one, release `d13f43d3` failed with `assemble: ComfyUI did not start ... numpy.core.multiarray failed to import` on three packs. That is the differential. * **Development environment, claims**: the preview promised 3 uploads and 383 MiB while the cut reported `uploaded: 0`; the base-image and policy warnings printed verbatim; the passing pin check printed nothing; `building` held four minutes, which the previous text told an agent to abandon. * **Local stack, end to end**: four agents driven by the corrected file alone, which is the evaluation a content change owes. One reached the pre-cut disclosure on the six-pack install, one recovered a failed release, one built from a described result with no install, and one checked every command, flag, field and error string against `origin/main` in both repos. Twenty-two defects came back and are fixed here. * **Not run**: Unit and Integration. This repository has no test suite and a skill file has nothing to execute. Prod is also not touched: both cuts were staging. **What changed** * **[comfy-skills] comfy-build/SKILL.md, failure recovery and polling**: reads `artifacts[].failureReason` and the log's middle, names `queued` and `building` as normal rather than stopping on them, and keys the table on strings the builder emits rather than three it never does. * **[comfy-skills] comfy-build/SKILL.md, scan, pins and refusals**: `comfy build release` replaces the retired `version` spelling, a wrong scanned registry id may now be corrected, a conflict the reading names travels into the first cut, and a refusal is described as leaving nothing behind, which is what the CLI does. * **[comfy-skills] comfy-build/SKILL.md, models and policy**: a new section on which directory a model `type` names and what a self-fetching pack costs, plus `modelPolicy` corrected from a restriction to a record. **Contradicts:** nothing. The file is public, so it says only what a user observes; four sentences describing internal mechanics were removed rather than bent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:34:06 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfy-skills#25

No description provided.

Rows
Columns