[PR #30] [CLOSED] fix(comfy-build): what four end-to-end runs found, including a core-class trap #29

New issue

Closed

opened 2026-10-26 22:34:09 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:34:09 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-skills/pull/30
Author: @james00012
Created: 8/26/2026
Status: ❌ Closed

Base: main ← Head: james/comfy-build-e2e-findings

📝 Commits (4)

d87dd2f fix(comfy-build): what a real workflow import taught, including one stop
654bf48 fix(comfy-build): what a green workflow build taught
32b363f fix(comfy-build): a 200 from the class lookup is not proof
46e38c8 fix(comfy-build): say which query the search example used

📊 Changes

1 file changed (+69 additions, -34 deletions)

View changed files

📝 comfy-cli/comfy-build/SKILL.md (+69 -34)

📄 Description

TL;DR: Correct the comfy-build skill against four end-to-end runs on staging, one of which showed the file sending an agent to install an unrelated pack to supply a core node.

Linear: BE-8426

Why: the skill had never been driven to a real build by anyone but its author. Four agents given only the file, and authorised to cut, produced three green builds and one correct refusal, and eighteen defects on the way.

Validation

Local stack, end to end: three green builds on staging, each on the first cut, one per path. Scan: release 5fb7b0bd, deployable: true, 15m36s. Workflow: release c9a2fd84, 12m29s. Described intent: release ebb23011, 13m51s. Each was driven by an agent reading only this file.
Local stack, end to end: a workflow carrying a class nobody publishes. The agent refused to cut and spent nothing, which is the correct outcome and the case BE-8426 names.
Not run: Unit and Integration. This repository has no test suite and a skill file has nothing to execute.
Not run: production. Every cut was staging, with COMFY_BUILDER_URL set on every call.

What changed

[comfy-skills] comfy-build/SKILL.md, Find the packs: core is settled before the registry is asked, and a 200 from the class lookup is described as a claim rather than an answer. LoadImage returns one.
[comfy-skills] comfy-build/SKILL.md, the workflow shortcut: the commands now write the models in and run validate, the report is saved before the first save clears it, unresolvedClasses stops the run, and an empty definition is named as a real answer.
[comfy-skills] comfy-build/SKILL.md, Reading what comes back and the disclosure: the advisories are marked as an import's fields rather than a cut's, an absent key is the all-clear, and a build that uploads nothing has wording for it.

Contradicts: nothing. Two lines of the file disagreed with each other on whether to check comfy --version or check for the verb, and the version one is removed rather than kept.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-skills/pull/30 **Author:** [@james00012](https://github.com/james00012) **Created:** 8/26/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `james/comfy-build-e2e-findings` --- ### 📝 Commits (4) - [`d87dd2f`](https://github.com/Comfy-Org/comfy-skills/commit/d87dd2f05197d59fc31d92905f3310181efdf838) fix(comfy-build): what a real workflow import taught, including one stop - [`654bf48`](https://github.com/Comfy-Org/comfy-skills/commit/654bf486f840cd24eb0a98bdbf8640ef62c8d96d) fix(comfy-build): what a green workflow build taught - [`32b363f`](https://github.com/Comfy-Org/comfy-skills/commit/32b363fcaa2b55439186dc75c248c3e98f8e1e73) fix(comfy-build): a 200 from the class lookup is not proof - [`46e38c8`](https://github.com/Comfy-Org/comfy-skills/commit/46e38c857855ff01f581e004e46879d6518790af) fix(comfy-build): say which query the search example used ### 📊 Changes **1 file changed** (+69 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `comfy-cli/comfy-build/SKILL.md` (+69 -34) </details> ### 📄 Description **TL;DR:** Correct the comfy-build skill against four end-to-end runs on staging, one of which showed the file sending an agent to install an unrelated pack to supply a core node. Linear: [BE-8426](https://linear.app/comfyorg/issue/BE-8426) **Why:** the skill had never been driven to a real build by anyone but its author. Four agents given only the file, and authorised to cut, produced three green builds and one correct refusal, and eighteen defects on the way. **Validation** * **Local stack, end to end**: three green builds on staging, each on the first cut, one per path. Scan: release `5fb7b0bd`, `deployable: true`, 15m36s. Workflow: release `c9a2fd84`, 12m29s. Described intent: release `ebb23011`, 13m51s. Each was driven by an agent reading only this file. * **Local stack, end to end**: a workflow carrying a class nobody publishes. The agent refused to cut and spent nothing, which is the correct outcome and the case [BE-8426](https://linear.app/comfyorg/issue/BE-8426) names. * **Not run**: Unit and Integration. This repository has no test suite and a skill file has nothing to execute. * **Not run**: production. Every cut was staging, with `COMFY_BUILDER_URL` set on every call. **What changed** * **[comfy-skills] comfy-build/SKILL.md, Find the packs**: core is settled before the registry is asked, and a `200` from the class lookup is described as a claim rather than an answer. `LoadImage` returns one. * **[comfy-skills] comfy-build/SKILL.md, the workflow shortcut**: the commands now write the models in and run `validate`, the report is saved before the first save clears it, `unresolvedClasses` stops the run, and an empty definition is named as a real answer. * **[comfy-skills] comfy-build/SKILL.md, Reading what comes back and the disclosure**: the advisories are marked as an import's fields rather than a cut's, an absent key is the all-clear, and a build that uploads nothing has wording for it. **Contradicts:** nothing. Two lines of the file disagreed with each other on whether to check `comfy --version` or check for the verb, and the version one is removed rather than kept. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:34:09 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfy-skills#29

No description provided.

Rows
Columns