[PR #18] [MERGED] ci: gated live cancel smoke test (manual + nightly) #20

New issue

Closed

opened 2026-10-26 22:34:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:34:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-swift-sdk/pull/18
Author: @mattmillerai
Created: 6/21/2026
Status: ✅ Merged
Merged: 6/21/2026
Merged by: @mattmillerai

Base: main ← Head: ci/live-cancel-smoke

📝 Commits (1)

5e67db6 ci: add gated live cancel smoke test (manual + nightly)

📊 Changes

1 file changed (+33 additions, -0 deletions)

View changed files

➕ .github/workflows/smoke.yml (+33 -0)

📄 Description

Wires the COMFY_API_KEY secret (just added) into a gated live smoke test.

Behaviour

Runs the cancel_round_trip test (added in #17) against cloud.comfy.org: submits a real job and confirms POST /api/jobs/{job_id}/cancel returns {cancelled: true}.
Triggers on workflow_dispatch + nightly schedule only — never push/pull_request.

Why gated

Each run submits a real, billable job and uses the COMFY_API_KEY secret. On a public repo, secrets must only reach main-context runs (manual/scheduled), never PR runs. So this never fires on a PR, and the nightly run catches a backend contract regression on submit → cancel even when no SDK change triggers CI.

Note on the key

Using the production COMFY_API_KEY since there's no key scoping available yet. When scoped keys exist, swap the secret for a low-quota CI key — no workflow change needed.

After merge, verify with: gh workflow run "Smoke (live)" --repo Comfy-Org/ComfySwiftSDK.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-swift-sdk/pull/18 **Author:** [@mattmillerai](https://github.com/mattmillerai) **Created:** 6/21/2026 **Status:** ✅ Merged **Merged:** 6/21/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `ci/live-cancel-smoke` --- ### 📝 Commits (1) - [`5e67db6`](https://github.com/Comfy-Org/comfy-swift-sdk/commit/5e67db6e889520b4003395c5071ec24d44eff27f) ci: add gated live cancel smoke test (manual + nightly) ### 📊 Changes **1 file changed** (+33 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/smoke.yml` (+33 -0) </details> ### 📄 Description Wires the `COMFY_API_KEY` secret (just added) into a **gated** live smoke test. ### Behaviour - Runs the `cancel_round_trip` test (added in #17) against `cloud.comfy.org`: submits a real job and confirms `POST /api/jobs/{job_id}/cancel` returns `{cancelled: true}`. - Triggers on **`workflow_dispatch` + nightly `schedule` only** — never `push`/`pull_request`. ### Why gated Each run submits a real, billable job and uses the `COMFY_API_KEY` secret. On a public repo, secrets must only reach **main-context** runs (manual/scheduled), never PR runs. So this never fires on a PR, and the nightly run catches a backend contract regression on submit → cancel even when no SDK change triggers CI. ### Note on the key Using the production `COMFY_API_KEY` since there's no key scoping available yet. When scoped keys exist, swap the secret for a low-quota CI key — no workflow change needed. After merge, verify with: `gh workflow run "Smoke (live)" --repo Comfy-Org/ComfySwiftSDK`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:34:00 +00:00