[PR #183] chore: require @guill approval for public workflow API changes #183

New issue

Open

opened 2026-10-31 22:05:26 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:05:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-typescript-sdk/pull/183
Author: @guill
Created: 9/24/2026
Status: 🔄 Open

Base: main ← Head: js/codeowners

📝 Commits (2)

a865868 Requiring human approval on public API changes
4b74261 Update documentation

📊 Changes

3 files changed (+23 additions, -4 deletions)

View changed files

📝 .github/CODEOWNERS (+20 -3)
📝 AGENTS.md (+2 -1)
📝 CONTRIBUTING.md (+1 -0)

📄 Description

Adds @guill as the required code owner for the files that make up the SDK's public API outside the models (Comfy Router) API: the non-Router modules under src/sdk/, plus spec/openapi.yaml.

Everything else, including the Router surface and any file added in the future, keeps the existing default of @Comfy-Org/comfy-cloud-team @Comfy-Org/core-engine-team. That means new Router files can still land without @guill's review.

This is a .github/CODEOWNERS change only.

Summary by CodeRabbit

Chores
- Updated review ownership for selected API specification and SDK files. No end-user functionality changed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-typescript-sdk/pull/183 **Author:** [@guill](https://github.com/guill) **Created:** 9/24/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `js/codeowners` --- ### 📝 Commits (2) - [`a865868`](https://github.com/Comfy-Org/comfy-typescript-sdk/commit/a86586870c99cc5203446c84751d3840f3315912) Requiring human approval on public API changes - [`4b74261`](https://github.com/Comfy-Org/comfy-typescript-sdk/commit/4b742617411203a593e5a02a09e15662f50e33a7) Update documentation ### 📊 Changes **3 files changed** (+23 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/CODEOWNERS` (+20 -3) 📝 `AGENTS.md` (+2 -1) 📝 `CONTRIBUTING.md` (+1 -0) </details> ### 📄 Description Adds @guill as the required code owner for the files that make up the SDK's public API outside the models (Comfy Router) API: the non-Router modules under `src/sdk/`, plus `spec/openapi.yaml`. Everything else, including the Router surface and any file added in the future, keeps the existing default of `@Comfy-Org/comfy-cloud-team @Comfy-Org/core-engine-team`. That means new Router files can still land without @guill's review. This is a `.github/CODEOWNERS` change only.  ## Summary by CodeRabbit * **Chores** * Updated review ownership for selected API specification and SDK files. No end-user functionality changed.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-31 22:05:26 +00:00