[PR #4] [MERGED] Add pnpm-workspace.yaml to approve dependency build scripts #4

New issue

Closed

opened 2026-10-31 22:05:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:05:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfyci-dashboard/pull/4
Author: @marawan206
Created: 6/4/2026
Status: ✅ Merged
Merged: 6/9/2026
Merged by: @marawan206

Base: main ← Head: fix/pnpm-allow-builds

📝 Commits (1)

bf45eb4 Add pnpm-workspace.yaml to approve dependency build scripts

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

➕ pnpm-workspace.yaml (+3 -0)

📄 Description

Summary

pnpm 11 blocks dependency install/build lifecycle scripts by default as a supply-chain safeguard. Two dependencies legitimately need theirs:

esbuild — its postinstall downloads/links the platform-specific native binary
pi-decimals — its install script generates required data files

Without approval, pnpm install exits with code 1 (ERR_PNPM_IGNORED_BUILDS), and since pnpm 11 verifies dependencies before running a script, pnpm dev fails to start on a fresh clone.

Change

Adds pnpm-workspace.yaml approving both packages via allowBuilds, so install completes cleanly and pnpm dev boots.

Testing

pnpm install → exits 0, both build scripts run
pnpm dev → Next.js dev server ready on http://localhost:3000

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfyci-dashboard/pull/4 **Author:** [@marawan206](https://github.com/marawan206) **Created:** 6/4/2026 **Status:** ✅ Merged **Merged:** 6/9/2026 **Merged by:** [@marawan206](https://github.com/marawan206) **Base:** `main` ← **Head:** `fix/pnpm-allow-builds` --- ### 📝 Commits (1) - [`bf45eb4`](https://github.com/Comfy-Org/comfyci-dashboard/commit/bf45eb45442c973d52120860390bebdcdb25c1d8) Add pnpm-workspace.yaml to approve dependency build scripts ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `pnpm-workspace.yaml` (+3 -0) </details> ### 📄 Description ## Summary pnpm 11 blocks dependency install/build lifecycle scripts by default as a supply-chain safeguard. Two dependencies legitimately need theirs: - **esbuild** — its `postinstall` downloads/links the platform-specific native binary - **pi-decimals** — its `install` script generates required data files Without approval, `pnpm install` exits with code 1 (`ERR_PNPM_IGNORED_BUILDS`), and since pnpm 11 verifies dependencies before running a script, `pnpm dev` fails to start on a fresh clone. ## Change Adds `pnpm-workspace.yaml` approving both packages via `allowBuilds`, so install completes cleanly and `pnpm dev` boots. ## Testing - `pnpm install` → exits 0, both build scripts run - `pnpm dev` → Next.js dev server ready on http://localhost:3000 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:05:55 +00:00